)]}'
{"octavia/common/data_models.py":[{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"f6307ac47908cf3bb04d7e4ae0d0304f48b0f78f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"import datetime"},{"line_number":17,"context_line":"import re"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from sqlalchemy.orm import collections"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_ee73e5b2","line":16,"updated":"2016-08-08 15:24:37.000000000","message":"New line","commit_id":"70217568922f60813efc8b67d27ccb175ccd3aca"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"f6307ac47908cf3bb04d7e4ae0d0304f48b0f78f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                continue"},{"line_number":34,"context_line":"            if isinstance(getattr(self, attr), (BaseDataModel, list)):"},{"line_number":35,"context_line":"                ret[attr] \u003d None"},{"line_number":36,"context_line":"            elif isinstance(getattr(self, attr), datetime.datetime):"},{"line_number":37,"context_line":"                ret[attr] \u003d getattr(self, attr).isoformat(\u0027 \u0027)"},{"line_number":38,"context_line":"            else:"},{"line_number":39,"context_line":"                ret[attr] \u003d self.__dict__[attr]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_ce78a192","line":36,"updated":"2016-08-08 15:24:37.000000000","message":"No way, that line is doing the same what was previously. Like Reepip said we should have a tast for that but did you tried to change wmse type for a datetime from string?","commit_id":"70217568922f60813efc8b67d27ccb175ccd3aca"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"0189337540a0c6226168d72361b14838e1c0168f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                continue"},{"line_number":34,"context_line":"            if isinstance(getattr(self, attr), (BaseDataModel, list)):"},{"line_number":35,"context_line":"                ret[attr] \u003d None"},{"line_number":36,"context_line":"            elif isinstance(getattr(self, attr), datetime.datetime):"},{"line_number":37,"context_line":"                ret[attr] \u003d getattr(self, attr).isoformat(\u0027 \u0027)"},{"line_number":38,"context_line":"            else:"},{"line_number":39,"context_line":"                ret[attr] \u003d self.__dict__[attr]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_3160a735","line":36,"in_reply_to":"9ad45d7e_ce78a192","updated":"2016-08-09 01:50:10.000000000","message":"I did a simple test like this:\n\n\u003e\u003e\u003e from wsme import types as wtypes\n\u003e\u003e\u003e created_at \u003d wtypes.wsattr(wtypes.StringType())\n\u003e\u003e\u003e import datetime\n\u003e\u003e\u003e test_obj\u003ddatetime.datetime.now()\n\u003e\u003e\u003e created_at \u003d test_obj\n\u003e\u003e\u003e print created_at\n2016-08-08 20:07:13.206661\n\u003e\u003e\u003e type(created_at)\n\u003ctype \u0027datetime.datetime\u0027\u003e\n\nThe type of created_at has been changed.\n\nAnd, I could not find a proper place to add test case, any suggestions ?","commit_id":"70217568922f60813efc8b67d27ccb175ccd3aca"}],"octavia/db/repositories.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fbecdaffe5617cfd9d2703802c3dbaea6bb07026","unresolved":false,"context_lines":[{"line_number":349,"context_line":"            # If a load balancer was never updated use its creation timestamp"},{"line_number":350,"context_line":"            last_update \u003d lb.updated_at or lb.created_at"},{"line_number":351,"context_line":"            # Convert string to timestamp"},{"line_number":352,"context_line":"            last_update \u003d dateutil.parser.parse(last_update)"},{"line_number":353,"context_line":"            return last_update \u003c timestamp"},{"line_number":354,"context_line":"        else:"},{"line_number":355,"context_line":"            # Load balancer was just deleted."}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_a084b2d2","line":352,"updated":"2016-08-05 13:53:36.000000000","message":"My comment might be similar to diltram\u0027s.\nShouldn\u0027t sqlalchemy be returning a python datetime formated object here?  Do we really need to covert it at all?\n\nIf we do need to convert it, I am ok with using this library.  I firmly don\u0027t trust sqlalchemy to \"do the right thing\", especially across locales that may have different formats.\n\nI do not however want us to create our own parser since the above is available in global-requirements.","commit_id":"7836003cf0f60a9de6bb0d60e2304cee3c14c41c"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"046c5dddd80fa228ab21d63b1a82452bdf1353b3","unresolved":false,"context_lines":[{"line_number":349,"context_line":"            # If a load balancer was never updated use its creation timestamp"},{"line_number":350,"context_line":"            last_update \u003d lb.updated_at or lb.created_at"},{"line_number":351,"context_line":"            # Convert string to timestamp"},{"line_number":352,"context_line":"            last_update \u003d dateutil.parser.parse(last_update)"},{"line_number":353,"context_line":"            return last_update \u003c timestamp"},{"line_number":354,"context_line":"        else:"},{"line_number":355,"context_line":"            # Load balancer was just deleted."}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_bd84d0d2","line":352,"updated":"2016-08-05 16:37:36.000000000","message":"Yesterday I was discussing that with Li and he\u0027s woring on fixing that by removing that weird code which originaly created that issue so it not will be needed any more","commit_id":"7836003cf0f60a9de6bb0d60e2304cee3c14c41c"}]}