)]}'
{"octavia/network/drivers/neutron/allowed_address_pairs.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"9592aa51847f2717be0d524dc07bc51d838e0954","unresolved":false,"context_lines":[{"line_number":251,"context_line":"                self._delete_vip_security_group(sec_grp)"},{"line_number":252,"context_line":"            return"},{"line_number":253,"context_line":"        try:"},{"line_number":254,"context_line":"            self.neutron_client.delete_port(vip.port_id)"},{"line_number":255,"context_line":"        except Exception:"},{"line_number":256,"context_line":"            message \u003d _LE(\u0027Error deleting VIP port_id {port_id} from \u0027"},{"line_number":257,"context_line":"                          \u0027neutron\u0027).format(port_id\u003dvip.port_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_7ecd8bb6","side":"PARENT","line":254,"updated":"2016-08-04 07:38:22.000000000","message":"Interesting, unless my eyes are tricking me, this would have run even if device_owner !\u003d OCTAVIA_OWNER because it wasn\u0027t in an \"else\"?! :(","commit_id":"bb9612478b2efeeb44a3d4d0c1109e812da5eb7e"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"e954eeac4c302b12a876a162e42dfa503ee6beaf","unresolved":false,"context_lines":[{"line_number":251,"context_line":"                self._delete_vip_security_group(sec_grp)"},{"line_number":252,"context_line":"            return"},{"line_number":253,"context_line":"        try:"},{"line_number":254,"context_line":"            self.neutron_client.delete_port(vip.port_id)"},{"line_number":255,"context_line":"        except Exception:"},{"line_number":256,"context_line":"            message \u003d _LE(\u0027Error deleting VIP port_id {port_id} from \u0027"},{"line_number":257,"context_line":"                          \u0027neutron\u0027).format(port_id\u003dvip.port_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_58bb62e5","side":"PARENT","line":254,"updated":"2016-08-04 15:43:29.000000000","message":"No Adam, there is return at the end of this previous if :P Because of that I refactored that method - to make it easier to read and understand","commit_id":"bb9612478b2efeeb44a3d4d0c1109e812da5eb7e"},{"author":{"_account_id":10781,"name":"selvakumar","email":"selvakumar.s2@hpe.com","username":"selvakumar"},"change_message_id":"2319f853ab6699bc63a965abd469c1298c00212b","unresolved":false,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def _delete_security_group(self, vip, port):"},{"line_number":221,"context_line":"        if self.sec_grp_enabled:"},{"line_number":222,"context_line":"            sec_grp \u003d self._get_lb_security_group(vip.load_balancer.id)"},{"line_number":223,"context_line":"            if sec_grp:"},{"line_number":224,"context_line":"                sec_grp \u003d sec_grp.get(\u0027id\u0027)"},{"line_number":225,"context_line":"                LOG.info("}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_52d70abf","line":222,"range":{"start_line":222,"start_character":54,"end_line":222,"end_character":67},"updated":"2016-08-09 10:07:34.000000000","message":"Hi Diltram,\nI have question regarding the Line 222 change.\nsome times I get the AttributeError when we try to access \nvip.load_balancer.id.\nmysql\u003e desc vip;\n+------------------+-------------+------+-----+---------+-------+\n| Field            | Type        | Null | Key | Default | Extra |\n+------------------+-------------+------+-----+---------+-------+\n| load_balancer_id | varchar(36) | NO   | PRI | NULL    |       |\n| ip_address       | varchar(36) | YES  |     | NULL    |       |\n| port_id          | varchar(36) | YES  |     | NULL    |       |\n| subnet_id        | varchar(36) | YES  |     | NULL    |       |\n+------------------+-------------+------+-----+---------+-------+\n4 rows in set (0.03 sec)\n\nAs per the above model we need to access via load_balancer_id right rather than vip.load_balancer.id?","commit_id":"2b41699bbc8ee2ac536cf39184ddb6734f999385"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"aa079d243339ddf47163405443c4963e1a93fc59","unresolved":false,"context_lines":[{"line_number":222,"context_line":"            sec_grp \u003d self._get_lb_security_group(vip.load_balancer.id)"},{"line_number":223,"context_line":"            if sec_grp:"},{"line_number":224,"context_line":"                sec_grp \u003d sec_grp.get(\u0027id\u0027)"},{"line_number":225,"context_line":"                LOG.info("},{"line_number":226,"context_line":"                    _LI(\"Removing security group %(sg)s from port %(port)s\"),"},{"line_number":227,"context_line":"                    {\u0027sg\u0027: sec_grp, \u0027port\u0027: vip.port_id})"},{"line_number":228,"context_line":"                raw_port \u003d self.neutron_client.show_port(port.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_894a0782","line":225,"range":{"start_line":225,"start_character":0,"end_line":225,"end_character":25},"updated":"2016-08-09 05:13:20.000000000","message":"Nit: If you end up needing to refactor this, this should probably be a debug-level log message.","commit_id":"2b41699bbc8ee2ac536cf39184ddb6734f999385"}]}