)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d91d0e12f75ad71598ade72fec25a02e6be24b38","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixed UnmappedInstanceError thrown when  LB delete"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During loadbalancer delete in the liberty code in certain corner case where"},{"line_number":10,"context_line":"Amphora agent never reports the heartbeat to the octavia controller."},{"line_number":11,"context_line":"After load balancer creation the health manager updates the health status of"},{"line_number":12,"context_line":"amphora in the amphora_health table . Since none of the heartbeat received"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bacf61ea_8e814292","line":9,"updated":"2016-08-03 22:54:44.000000000","message":"nit: This is a patch against master and not the liberty code.  We should not be referencing liberty here.","commit_id":"3f5b854d02a75ad76b6f7517b130eb82b462aa80"}],"octavia/controller/worker/tasks/database_tasks.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"683bc5295f9c0c9086a4a5ac80a366a38453c900","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        except sqlalchemy.orm.exc.NoResultFound:"},{"line_number":78,"context_line":"            LOG.debug(\u0027No existing amphora health record to mark busy \u0027"},{"line_number":79,"context_line":"                      \u0027for amphora: %s, skipping.\u0027, amphora_id)"},{"line_number":80,"context_line":"        except sqlalchemy.orm.exc.UnmappedInstanceError:"},{"line_number":81,"context_line":"            LOG.debug(\"amphora_id %s was not found and therefore no delete \""},{"line_number":82,"context_line":"                      \"operation was performed\", amphora_id)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_a8d5291c","line":80,"updated":"2016-08-03 17:12:24.000000000","message":"Is this actually distinctly different enough that we need another debug message for it, or could it just be caught along with NoResultFound and use the same debug message?\nRegardless, this error message is not great -- this is \"mark_amp_health_busy\" and it\u0027s referencing a delete operation? If we don\u0027t just use the same message as above, could we at least be consistent in style?","commit_id":"94ca922adf7d69748ac844b4318f039615828189"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"6023e06c4c848990fb1b89e196ac93262f77d95f","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        except sqlalchemy.orm.exc.NoResultFound:"},{"line_number":78,"context_line":"            LOG.debug(\u0027No existing amphora health record to mark busy \u0027"},{"line_number":79,"context_line":"                      \u0027for amphora: %s, skipping.\u0027, amphora_id)"},{"line_number":80,"context_line":"        except sqlalchemy.orm.exc.UnmappedInstanceError:"},{"line_number":81,"context_line":"            LOG.debug(\"amphora_id %s was not found and therefore no delete \""},{"line_number":82,"context_line":"                      \"operation was performed\", amphora_id)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_ebad5b9c","line":80,"in_reply_to":"bacf61ea_486d8d31","updated":"2016-08-03 17:34:35.000000000","message":"Yes, sorry... I understand it is a different exception, I just meant could we catch it as part of the above like:\nexcept (sqlalchemy.orm.exc.NoResultFound, sqlalchemy.orm.exc.UnmappedInstanceError):","commit_id":"94ca922adf7d69748ac844b4318f039615828189"},{"author":{"_account_id":10781,"name":"selvakumar","email":"selvakumar.s2@hpe.com","username":"selvakumar"},"change_message_id":"5c73cd3fbc3843b1985cfc89294328ebbe124616","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        except sqlalchemy.orm.exc.NoResultFound:"},{"line_number":78,"context_line":"            LOG.debug(\u0027No existing amphora health record to mark busy \u0027"},{"line_number":79,"context_line":"                      \u0027for amphora: %s, skipping.\u0027, amphora_id)"},{"line_number":80,"context_line":"        except sqlalchemy.orm.exc.UnmappedInstanceError:"},{"line_number":81,"context_line":"            LOG.debug(\"amphora_id %s was not found and therefore no delete \""},{"line_number":82,"context_line":"                      \"operation was performed\", amphora_id)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_486d8d31","line":80,"in_reply_to":"bacf61ea_a8d5291c","updated":"2016-08-03 17:17:57.000000000","message":"Hi Adam ,\nThanks for reviewing this . Actually when there is no entry present in the DB actual exception thrown is UnMappedInstanceError and thats the reason we have explicitly caught the exception . You can refer the below link from neutron code, \nhttps://github.com/openstack/neutron/blob/master/neutron/db/ipam_backend_mixin.py#L460\n\nRegarding the error message I will modify to match the above one","commit_id":"94ca922adf7d69748ac844b4318f039615828189"},{"author":{"_account_id":10781,"name":"selvakumar","email":"selvakumar.s2@hpe.com","username":"selvakumar"},"change_message_id":"a841d4456aff6205a53f12d6e79fdf30669aa7d7","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        except sqlalchemy.orm.exc.NoResultFound:"},{"line_number":78,"context_line":"            LOG.debug(\u0027No existing amphora health record to mark busy \u0027"},{"line_number":79,"context_line":"                      \u0027for amphora: %s, skipping.\u0027, amphora_id)"},{"line_number":80,"context_line":"        except sqlalchemy.orm.exc.UnmappedInstanceError:"},{"line_number":81,"context_line":"            LOG.debug(\"amphora_id %s was not found and therefore no delete \""},{"line_number":82,"context_line":"                      \"operation was performed\", amphora_id)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_1668d220","line":80,"in_reply_to":"bacf61ea_ebad5b9c","updated":"2016-08-03 17:55:27.000000000","message":"Thanks Adam. It is incorporated in the latest patch","commit_id":"94ca922adf7d69748ac844b4318f039615828189"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"c770a9583735771f659d819d52633e5aff7e9704","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        except sqlalchemy.orm.exc.NoResultFound:"},{"line_number":78,"context_line":"            LOG.debug(\u0027No existing amphora health record to mark busy \u0027"},{"line_number":79,"context_line":"                      \u0027for amphora: %s, skipping.\u0027, amphora_id)"},{"line_number":80,"context_line":"        except sqlalchemy.orm.exc.UnmappedInstanceError:"},{"line_number":81,"context_line":"            LOG.debug(\u0027No existing amphora health record to mark busy \u0027"},{"line_number":82,"context_line":"                      \u0027for amphora: %s, skipping.\u0027, amphora_id)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_ab91a348","line":80,"updated":"2016-08-03 17:35:08.000000000","message":"Yes, sorry... I understand it is a different exception, I just meant could we catch it as part of the above like:\nexcept (sqlalchemy.orm.exc.NoResultFound, sqlalchemy.orm.exc.UnmappedInstanceError):","commit_id":"1e5d306186582806eb7c5b604b98ded536625f13"}]}