)]}'
{"octavia/controller/worker/tasks/amphora_driver_tasks.py":[{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"c64a4636339bf4a4b6b1677cdfbdb1a6d984480d","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def revert(self, result, loadbalancer, *args, **kwargs):"},{"line_number":233,"context_line":"        \"\"\"Handle a failed amphora vip plug notification.\"\"\""},{"line_number":234,"context_line":"        if isinstance(result, failure.Failure):"},{"line_number":235,"context_line":"            self.loadbalancer_repo.update(db_apis.get_session(),"},{"line_number":236,"context_line":"                                          id\u003dloadbalancer.id,"},{"line_number":237,"context_line":"                                          provisioning_status\u003dconstants.ERROR)"},{"line_number":238,"context_line":"            return"},{"line_number":239,"context_line":"        LOG.warning(_LW(\"Reverting post vip plug.\"))"},{"line_number":240,"context_line":"        self.loadbalancer_repo.update(db_apis.get_session(),"},{"line_number":241,"context_line":"                                      id\u003dloadbalancer.id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_d2ce5f59","line":238,"range":{"start_line":234,"start_character":8,"end_line":238,"end_character":18},"updated":"2016-08-09 08:21:42.000000000","message":"I\u0027m not an expert on taskflow, but do we need to check if the result is \"failure.Failure\" here at all? The code below does exactly the same thing, so we could just delete the if clause.","commit_id":"ee87d5fe205c573eff8e19476fc62ac24910c226"},{"author":{"_account_id":10781,"name":"selvakumar","email":"selvakumar.s2@hpe.com","username":"selvakumar"},"change_message_id":"bf8d86d192cbf1c33885235260943fc9e8ffd945","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def revert(self, result, loadbalancer, *args, **kwargs):"},{"line_number":233,"context_line":"        \"\"\"Handle a failed amphora vip plug notification.\"\"\""},{"line_number":234,"context_line":"        if isinstance(result, failure.Failure):"},{"line_number":235,"context_line":"            self.loadbalancer_repo.update(db_apis.get_session(),"},{"line_number":236,"context_line":"                                          id\u003dloadbalancer.id,"},{"line_number":237,"context_line":"                                          provisioning_status\u003dconstants.ERROR)"},{"line_number":238,"context_line":"            return"},{"line_number":239,"context_line":"        LOG.warning(_LW(\"Reverting post vip plug.\"))"},{"line_number":240,"context_line":"        self.loadbalancer_repo.update(db_apis.get_session(),"},{"line_number":241,"context_line":"                                      id\u003dloadbalancer.id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_2d82fe94","line":238,"range":{"start_line":234,"start_character":8,"end_line":238,"end_character":18},"in_reply_to":"9ad45d7e_d2ce5f59","updated":"2016-08-09 08:52:59.000000000","message":"Good comment Ezhova . I also thought the same. I will test and update the patch.","commit_id":"ee87d5fe205c573eff8e19476fc62ac24910c226"}]}