)]}'
{"octavia/amphorae/drivers/haproxy/rest_api_driver.py":[{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"aa2f7e21c894869ab2ebe5cd6fab982d75f11343","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                    r \u003d _request(**reqargs)"},{"line_number":253,"context_line":"                LOG.debug(\"Connected to amphora. Response: {resp}\".format("},{"line_number":254,"context_line":"                    resp\u003dr))"},{"line_number":255,"context_line":"                return r"},{"line_number":256,"context_line":"            except (requests.ConnectionError, requests.Timeout):"},{"line_number":257,"context_line":"                LOG.warning(_LW(\"Could not connect to instance. Retrying.\"))"},{"line_number":258,"context_line":"                time.sleep(CONF.haproxy_amphora.connection_retry_interval)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_9e0eb632","line":255,"range":{"start_line":255,"start_character":0,"end_line":255,"end_character":24},"updated":"2016-08-09 06:49:36.000000000","message":"Heh-- didn\u0027t see that we weren\u0027t actually returning the result before. Good catch, eh.","commit_id":"0fed3a50bbd4011006c392b2e688ae530f1a2d96"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"f9cb471304e101c655646005b14b0e1399f67e6e","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                time.sleep(CONF.haproxy_amphora.connection_retry_interval)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        LOG.error(_LE(\"Connection retries (currently set to %s) \""},{"line_number":261,"context_line":"                      \"exhausted.  The amphora is unavailable.\"),"},{"line_number":262,"context_line":"                  CONF.haproxy_amphora.connection_max_retries)"},{"line_number":263,"context_line":"        raise driver_except.TimeOutException()"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_306ebc2f","line":261,"updated":"2016-08-09 15:27:49.000000000","message":"Done","commit_id":"0fed3a50bbd4011006c392b2e688ae530f1a2d96"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"aa2f7e21c894869ab2ebe5cd6fab982d75f11343","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                time.sleep(CONF.haproxy_amphora.connection_retry_interval)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        LOG.error(_LE(\"Connection retries (currently set to %s) \""},{"line_number":261,"context_line":"                      \"exhausted.  The amphora is unavailable.\"),"},{"line_number":262,"context_line":"                  CONF.haproxy_amphora.connection_max_retries)"},{"line_number":263,"context_line":"        raise driver_except.TimeOutException()"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_aa17f94f","line":261,"range":{"start_line":261,"start_character":50,"end_line":261,"end_character":61},"updated":"2016-08-09 06:49:36.000000000","message":"Since you\u0027re changing the type of exception we\u0027re throwing on L263 below, can you also update the message to use the words \"time out\" instead of \"unavailable\"?","commit_id":"0fed3a50bbd4011006c392b2e688ae530f1a2d96"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"6c561be9fb4e242f0b704c42285c6905e65868ef","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        LOG.error(_LE(\"Connection retries (currently set to %s) \""},{"line_number":264,"context_line":"                      \"exhausted.  The amphora is unavailable.\"),"},{"line_number":265,"context_line":"                  CONF.haproxy_amphora.connection_max_retries)"},{"line_number":266,"context_line":"        raise driver_except.UnavailableException()"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def upload_config(self, amp, listener_id, config):"},{"line_number":269,"context_line":"        r \u003d self.put("}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_6ccd385d","side":"PARENT","line":266,"updated":"2016-08-12 16:34:24.000000000","message":"Done","commit_id":"7b18f1987005d4ec19e2e7b1c2c0a764aaad5078"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9a13ca68e2caf3bbb3e35197c721431ddf4edfa4","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        LOG.error(_LE(\"Connection retries (currently set to %s) \""},{"line_number":264,"context_line":"                      \"exhausted.  The amphora is unavailable.\"),"},{"line_number":265,"context_line":"                  CONF.haproxy_amphora.connection_max_retries)"},{"line_number":266,"context_line":"        raise driver_except.UnavailableException()"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def upload_config(self, amp, listener_id, config):"},{"line_number":269,"context_line":"        r \u003d self.put("}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_52e20130","side":"PARENT","line":266,"updated":"2016-08-10 23:18:52.000000000","message":"Since you are changing this exception, can you remove it from the driver_exceptions file as well?  It is not used elsewhere.","commit_id":"7b18f1987005d4ec19e2e7b1c2c0a764aaad5078"}]}