)]}'
{"octavia/amphorae/backends/health_daemon/health_daemon.py":[{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"2afdba0917a91c653218b5813033f5939feadce8","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    stat_sock_files \u003d list_sock_stat_files()"},{"line_number":85,"context_line":"    for listener_id, stat_sock_file in six.iteritems(stat_sock_files):"},{"line_number":86,"context_line":"        listener_dict \u003d {\u0027pools\u0027: {}, \u0027status\u0027: \u0027DOWN\u0027,"},{"line_number":87,"context_line":"                                      \u0027stats\u0027: {\u0027tx\u0027: 0, \u0027rx\u0027: 0,"},{"line_number":88,"context_line":"                                                \u0027conns\u0027: 0, \u0027totconns\u0027: 0,"},{"line_number":89,"context_line":"                                                \u0027ereq\u0027: 0}}"},{"line_number":90,"context_line":"        msg[\u0027listeners\u0027][listener_id] \u003d listener_dict"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_0db6f23c","line":87,"updated":"2016-08-16 15:11:40.000000000","message":"This code is improperly indented","commit_id":"ce0d2a7c3ad996ca709898f6570d0092dbe5a6f9"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"f6e6add169b62daa32f683aed3acde53daec479f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    stat_sock_files \u003d list_sock_stat_files()"},{"line_number":85,"context_line":"    for listener_id, stat_sock_file in six.iteritems(stat_sock_files):"},{"line_number":86,"context_line":"        listener_dict \u003d {\u0027pools\u0027: {}, \u0027status\u0027: \u0027DOWN\u0027,"},{"line_number":87,"context_line":"                                      \u0027stats\u0027: {\u0027tx\u0027: 0, \u0027rx\u0027: 0,"},{"line_number":88,"context_line":"                                                \u0027conns\u0027: 0, \u0027totconns\u0027: 0,"},{"line_number":89,"context_line":"                                                \u0027ereq\u0027: 0}}"},{"line_number":90,"context_line":"        msg[\u0027listeners\u0027][listener_id] \u003d listener_dict"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_e88b6b66","line":87,"in_reply_to":"3ac371cc_0db6f23c","updated":"2016-08-17 02:40:35.000000000","message":"Done","commit_id":"ce0d2a7c3ad996ca709898f6570d0092dbe5a6f9"}],"octavia/api/v1/controllers/listener_statistics.py":[{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"e74694073164b081ad28124ce3b17b3c27bae82c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        # the single set of stats"},{"line_number":54,"context_line":"        context \u003d pecan.request.context.get(\u0027octavia_context\u0027)"},{"line_number":55,"context_line":"        db_ls \u003d self._get_db_ls(context.session)"},{"line_number":56,"context_line":"        ls_stats \u003d self._convert_db_to_type("},{"line_number":57,"context_line":"            db_ls, ls_types.ListenerStatistics)"},{"line_number":58,"context_line":"        return ls_types.ListenerStatisticsResponse(ls_stats)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_ef9ac9c4","line":56,"updated":"2016-08-31 21:11:57.000000000","message":"nit: This change doesn\u0027t really do anything, but technically this variable\u0027s name is \"listenerstats_stats\"  If you have to make another change, I\u0027d suggest maybe just calling it \"stats\" or something.","commit_id":"e0aca889d9f5106953016529682fd9248d2449b2"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"19e737ed0935af4bc38fef48093e0cf28ffdb881","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        db_ls \u003d self._get_db_ls(context.session)"},{"line_number":56,"context_line":"        ls_stats \u003d self._convert_db_to_type("},{"line_number":57,"context_line":"            db_ls, ls_types.ListenerStatistics)"},{"line_number":58,"context_line":"        return ls_types.ListenerStatisticsResponse(ls_stats)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_ab07ce1b","line":58,"range":{"start_line":58,"start_character":24,"end_line":58,"end_character":50},"updated":"2016-09-01 00:50:27.000000000","message":"I don\u0027t like that solution. It\u0027s too much overhead for that simple thing.\n\n@wsme_pecan.wsexpose({wtypes.text: ls_types.ListenerStatistics})\nreturn {constants.LISTENER: self._convert_db_to_type(db_ls, ls_types.ListenerStatistics)}\n\nAlso, there will be no more ls_stats so there will be no more problem.","commit_id":"e0aca889d9f5106953016529682fd9248d2449b2"}],"octavia/common/data_models.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cfe77f5005cec057f30314bf8c17ea713b8862f0","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def __init__(self, listener_id\u003dNone, amphora_id\u003dNone, bytes_in\u003dNone,"},{"line_number":136,"context_line":"                 bytes_out\u003dNone, active_connections\u003dNone,"},{"line_number":137,"context_line":"                 total_connections\u003dNone, request_errors\u003dNone):"},{"line_number":138,"context_line":"        self.listener_id \u003d listener_id"},{"line_number":139,"context_line":"        self.amphora_id \u003d amphora_id"},{"line_number":140,"context_line":"        self.bytes_in \u003d bytes_in"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ac06dbe_94a800dd","line":137,"updated":"2016-08-23 03:00:26.000000000","message":"Again, the database will not allow nulls, so why are we setting a default to None?","commit_id":"03d3421ebbb3f5ceb5b1ee98c4f93ae4472be605"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"4903e5055badb3aed0cb90673ff92924f2c7e31e","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def __init__(self, listener_id\u003dNone, amphora_id\u003dNone, bytes_in\u003dNone,"},{"line_number":136,"context_line":"                 bytes_out\u003dNone, active_connections\u003dNone,"},{"line_number":137,"context_line":"                 total_connections\u003dNone, request_errors\u003dNone):"},{"line_number":138,"context_line":"        self.listener_id \u003d listener_id"},{"line_number":139,"context_line":"        self.amphora_id \u003d amphora_id"},{"line_number":140,"context_line":"        self.bytes_in \u003d bytes_in"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ac06dbe_bf423566","line":137,"in_reply_to":"1ac06dbe_94a800dd","updated":"2016-08-23 03:11:53.000000000","message":"I think here is just the same situation as other metrics. This column must been set, otherwise, can not be updated.","commit_id":"03d3421ebbb3f5ceb5b1ee98c4f93ae4472be605"}],"octavia/controller/healthmanager/update_db.py":[{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"2afdba0917a91c653218b5813033f5939feadce8","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        health \u003d {"},{"line_number":233,"context_line":"            \"id\": self.FAKE_UUID_1,"},{"line_number":234,"context_line":"            \"listeners\": {"},{"line_number":235,"context_line":"                \"listener-id-1\": {\"status\": constants.OPEN,"},{"line_number":236,"context_line":"                                  \u0027stats\u0027: {\u0027ereq\u0027:0,"},{"line_number":237,"context_line":"                                            \u0027conns\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_2dbbee28","line":234,"updated":"2016-08-16 15:11:40.000000000","message":"Please reindentate that code properly","commit_id":"ce0d2a7c3ad996ca709898f6570d0092dbe5a6f9"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"f6e6add169b62daa32f683aed3acde53daec479f","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        health \u003d {"},{"line_number":233,"context_line":"            \"id\": self.FAKE_UUID_1,"},{"line_number":234,"context_line":"            \"listeners\": {"},{"line_number":235,"context_line":"                \"listener-id-1\": {\"status\": constants.OPEN,"},{"line_number":236,"context_line":"                                  \u0027stats\u0027: {\u0027ereq\u0027:0,"},{"line_number":237,"context_line":"                                            \u0027conns\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_08c7e764","line":234,"in_reply_to":"3ac371cc_2dbbee28","updated":"2016-08-17 02:40:35.000000000","message":"Done","commit_id":"ce0d2a7c3ad996ca709898f6570d0092dbe5a6f9"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"f8fb18663fd2cbc4786517749d3a741845e0dd9a","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        :type map: string"},{"line_number":230,"context_line":"        :returns: null"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        health \u003d {"},{"line_number":233,"context_line":"            \"id\": self.FAKE_UUID_1,"},{"line_number":234,"context_line":"            \"listeners\": {"},{"line_number":235,"context_line":"                \"listener-id-1\": {"},{"line_number":236,"context_line":"                    \"status\": constants.OPEN,"},{"line_number":237,"context_line":"                    \"stats\": {"},{"line_number":238,"context_line":"                        \"ereq\":0,"},{"line_number":239,"context_line":"                        \"conns\": 0,"},{"line_number":240,"context_line":"                        \"totconns\": 0,"},{"line_number":241,"context_line":"                        \"rx\": 0,"},{"line_number":242,"context_line":"                        \"tx\": 0,"},{"line_number":243,"context_line":"                    },"},{"line_number":244,"context_line":"                    \"pools\": {"},{"line_number":245,"context_line":"                        \"pool-id-1\": {"},{"line_number":246,"context_line":"                            \"status\": constants.UP,"},{"line_number":247,"context_line":"                            \"members\": {"},{"line_number":248,"context_line":"                                \"member-id-1\": constants.ONLINE,"},{"line_number":249,"context_line":"                            }"},{"line_number":250,"context_line":"                        }"},{"line_number":251,"context_line":"                    }"},{"line_number":252,"context_line":"                }"},{"line_number":253,"context_line":"            }"},{"line_number":254,"context_line":"        }"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        \"\"\""},{"line_number":257,"context_line":"        session \u003d db_api.get_session()"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_a67e3ce2","line":254,"range":{"start_line":232,"start_character":8,"end_line":254,"end_character":9},"updated":"2016-08-26 14:57:39.000000000","message":"It\u0027s horribly indented and if I\u0027m right there is missing one closing bracket, but I\u0027m not sure","commit_id":"e0aca889d9f5106953016529682fd9248d2449b2"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"19e737ed0935af4bc38fef48093e0cf28ffdb881","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        :type map: string"},{"line_number":230,"context_line":"        :returns: null"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        health \u003d {"},{"line_number":233,"context_line":"            \"id\": self.FAKE_UUID_1,"},{"line_number":234,"context_line":"            \"listeners\": {"},{"line_number":235,"context_line":"                \"listener-id-1\": {"},{"line_number":236,"context_line":"                    \"status\": constants.OPEN,"},{"line_number":237,"context_line":"                    \"stats\": {"},{"line_number":238,"context_line":"                        \"ereq\":0,"},{"line_number":239,"context_line":"                        \"conns\": 0,"},{"line_number":240,"context_line":"                        \"totconns\": 0,"},{"line_number":241,"context_line":"                        \"rx\": 0,"},{"line_number":242,"context_line":"                        \"tx\": 0,"},{"line_number":243,"context_line":"                    },"},{"line_number":244,"context_line":"                    \"pools\": {"},{"line_number":245,"context_line":"                        \"pool-id-1\": {"},{"line_number":246,"context_line":"                            \"status\": constants.UP,"},{"line_number":247,"context_line":"                            \"members\": {"},{"line_number":248,"context_line":"                                \"member-id-1\": constants.ONLINE,"},{"line_number":249,"context_line":"                            }"},{"line_number":250,"context_line":"                        }"},{"line_number":251,"context_line":"                    }"},{"line_number":252,"context_line":"                }"},{"line_number":253,"context_line":"            }"},{"line_number":254,"context_line":"        }"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        \"\"\""},{"line_number":257,"context_line":"        session \u003d db_api.get_session()"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_b5fd6f3d","line":254,"range":{"start_line":232,"start_character":8,"end_line":254,"end_character":9},"in_reply_to":"fa7ab95a_4f29f536","updated":"2016-09-01 00:50:27.000000000","message":"No Trevor, in tests you can find that this is a dictionary which keeps listener data assigned to the key which is a UUID for the listener.","commit_id":"e0aca889d9f5106953016529682fd9248d2449b2"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"e74694073164b081ad28124ce3b17b3c27bae82c","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        :type map: string"},{"line_number":230,"context_line":"        :returns: null"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        health \u003d {"},{"line_number":233,"context_line":"            \"id\": self.FAKE_UUID_1,"},{"line_number":234,"context_line":"            \"listeners\": {"},{"line_number":235,"context_line":"                \"listener-id-1\": {"},{"line_number":236,"context_line":"                    \"status\": constants.OPEN,"},{"line_number":237,"context_line":"                    \"stats\": {"},{"line_number":238,"context_line":"                        \"ereq\":0,"},{"line_number":239,"context_line":"                        \"conns\": 0,"},{"line_number":240,"context_line":"                        \"totconns\": 0,"},{"line_number":241,"context_line":"                        \"rx\": 0,"},{"line_number":242,"context_line":"                        \"tx\": 0,"},{"line_number":243,"context_line":"                    },"},{"line_number":244,"context_line":"                    \"pools\": {"},{"line_number":245,"context_line":"                        \"pool-id-1\": {"},{"line_number":246,"context_line":"                            \"status\": constants.UP,"},{"line_number":247,"context_line":"                            \"members\": {"},{"line_number":248,"context_line":"                                \"member-id-1\": constants.ONLINE,"},{"line_number":249,"context_line":"                            }"},{"line_number":250,"context_line":"                        }"},{"line_number":251,"context_line":"                    }"},{"line_number":252,"context_line":"                }"},{"line_number":253,"context_line":"            }"},{"line_number":254,"context_line":"        }"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        \"\"\""},{"line_number":257,"context_line":"        session \u003d db_api.get_session()"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa7ab95a_4f29f536","line":254,"range":{"start_line":232,"start_character":8,"end_line":254,"end_character":9},"in_reply_to":"fa7ab95a_a67e3ce2","updated":"2016-08-31 21:11:57.000000000","message":"Also \"listeners\" is probably supposed to be a list.  So replace its curly braces with square brackets.","commit_id":"e0aca889d9f5106953016529682fd9248d2449b2"}],"octavia/db/migration/alembic_migrations/versions/c11292016060_add_request_errors_for_stats.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bc9a57c6fb6b9230f101e6c13e5f6aea9f64e3f6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    op.add_column(\u0027listener_statistics\u0027,"},{"line_number":33,"context_line":"                  sa.Column(\u0027request_errors\u0027,"},{"line_number":34,"context_line":"                            sa.BigInteger(),"},{"line_number":35,"context_line":"                            nullable\u003dFalse)"},{"line_number":36,"context_line":"                  )"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ac06dbe_f46a14b2","line":35,"updated":"2016-08-23 02:54:17.000000000","message":"Having nullable\u003dFalse here creates an upgrade problem.  Are you sure this needs to be not null?\nIf it must be null, there needs to be a mechanism to set a default value.","commit_id":"03d3421ebbb3f5ceb5b1ee98c4f93ae4472be605"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"4903e5055badb3aed0cb90673ff92924f2c7e31e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    op.add_column(\u0027listener_statistics\u0027,"},{"line_number":33,"context_line":"                  sa.Column(\u0027request_errors\u0027,"},{"line_number":34,"context_line":"                            sa.BigInteger(),"},{"line_number":35,"context_line":"                            nullable\u003dFalse)"},{"line_number":36,"context_line":"                  )"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ac06dbe_5f3861ef","line":35,"in_reply_to":"1ac06dbe_f46a14b2","updated":"2016-08-23 03:11:53.000000000","message":"Done","commit_id":"03d3421ebbb3f5ceb5b1ee98c4f93ae4472be605"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"a52d1b9c7d249da7a81a85d931bf7e841b25a222","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    op.add_column(\u0027listener_statistics\u0027,"},{"line_number":33,"context_line":"                  sa.Column(\u0027request_errors\u0027, sa.BigInteger(),"},{"line_number":34,"context_line":"                            nullable\u003dFalse, default\u003d0)"},{"line_number":35,"context_line":"                  )"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa7ab95a_9e187c77","line":35,"range":{"start_line":35,"start_character":18,"end_line":35,"end_character":19},"updated":"2016-09-01 08:12:44.000000000","message":"Nit: Put this closing parenthesis on the previous line. (We do python-like indentation, not C-like. :) )","commit_id":"fdb15044b88a01d0abb69395b9fcb14ae1a946eb"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"257c5b90387f8bb953c8e7d584004c4a8f3450f0","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    op.add_column(\u0027listener_statistics\u0027,"},{"line_number":33,"context_line":"                  sa.Column(\u0027request_errors\u0027, sa.BigInteger(),"},{"line_number":34,"context_line":"                            nullable\u003dFalse, default\u003d0)"},{"line_number":35,"context_line":"                  )"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a95cdbc_3ea7f3bd","line":35,"range":{"start_line":35,"start_character":18,"end_line":35,"end_character":19},"in_reply_to":"fa7ab95a_9e187c77","updated":"2016-10-10 02:11:32.000000000","message":"Done","commit_id":"fdb15044b88a01d0abb69395b9fcb14ae1a946eb"}],"octavia/db/models.py":[{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"2afdba0917a91c653218b5813033f5939feadce8","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        if value \u003c 0:"},{"line_number":136,"context_line":"            data \u003d {\u0027key\u0027: key, \u0027value\u0027: value}"},{"line_number":137,"context_line":"            raise ValueError(data)"},{"line_number":138,"context_line":"            # TODO(trevor-vardeman): Repair this functionality after OpenStack"},{"line_number":139,"context_line":"            # Common is in"},{"line_number":140,"context_line":"            # raise ValueError(_(\u0027The %(key)s field can not have \u0027"},{"line_number":141,"context_line":"            #                   \u0027negative value. \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_6d832657","line":138,"updated":"2016-08-16 15:11:40.000000000","message":"Please verify that this code still cannot be used. In my opinion we can finaly change that","commit_id":"ce0d2a7c3ad996ca709898f6570d0092dbe5a6f9"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"f6e6add169b62daa32f683aed3acde53daec479f","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        if value \u003c 0:"},{"line_number":136,"context_line":"            data \u003d {\u0027key\u0027: key, \u0027value\u0027: value}"},{"line_number":137,"context_line":"            raise ValueError(data)"},{"line_number":138,"context_line":"            # TODO(trevor-vardeman): Repair this functionality after OpenStack"},{"line_number":139,"context_line":"            # Common is in"},{"line_number":140,"context_line":"            # raise ValueError(_(\u0027The %(key)s field can not have \u0027"},{"line_number":141,"context_line":"            #                   \u0027negative value. \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_839d780c","line":138,"in_reply_to":"3ac371cc_6d832657","updated":"2016-08-17 02:40:35.000000000","message":"After test, the whole method do not work on my set-up at all.\n\nUpdated the method definition and added a new test case for it.","commit_id":"ce0d2a7c3ad996ca709898f6570d0092dbe5a6f9"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"4d97466e89ed83f74c1f261f94f08eec53d82b70","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    active_connections \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":128,"context_line":"    total_connections \u003d sa.Column(sa.BigInteger, nullable\u003dFalse)"},{"line_number":129,"context_line":"    request_errors \u003d sa.Column(sa.BigInteger, nullable\u003dFalse)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @validates(\u0027bytes_in\u0027, \u0027bytes_out\u0027,"},{"line_number":132,"context_line":"               \u0027active_connections\u0027, \u0027total_connections\u0027,"},{"line_number":133,"context_line":"               \u0027request_errors\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ac06dbe_deae5c84","line":130,"updated":"2016-08-22 00:51:46.000000000","message":"Why you removed that static method decorator? Is it really needed to change that declaration of this method? It\u0027s still not using anything from the self.","commit_id":"03d3421ebbb3f5ceb5b1ee98c4f93ae4472be605"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"094e897262f81c9bf89ed909fc4c241a5c23485f","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    active_connections \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":128,"context_line":"    total_connections \u003d sa.Column(sa.BigInteger, nullable\u003dFalse)"},{"line_number":129,"context_line":"    request_errors \u003d sa.Column(sa.BigInteger, nullable\u003dFalse)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @validates(\u0027bytes_in\u0027, \u0027bytes_out\u0027,"},{"line_number":132,"context_line":"               \u0027active_connections\u0027, \u0027total_connections\u0027,"},{"line_number":133,"context_line":"               \u0027request_errors\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ac06dbe_5e138c66","line":130,"in_reply_to":"1ac06dbe_3eecd08e","updated":"2016-08-22 01:31:28.000000000","message":"Here are the examples of the usage of  @validates:\n\nhttp://docs.sqlalchemy.org/en/latest/orm/mapped_attributes.html#simple-validators\n\nI think we\u0027re OK here.","commit_id":"03d3421ebbb3f5ceb5b1ee98c4f93ae4472be605"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"e3f0fab0ee6cfd7ffe05e1086987fb1fd1d623e0","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    active_connections \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":128,"context_line":"    total_connections \u003d sa.Column(sa.BigInteger, nullable\u003dFalse)"},{"line_number":129,"context_line":"    request_errors \u003d sa.Column(sa.BigInteger, nullable\u003dFalse)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @validates(\u0027bytes_in\u0027, \u0027bytes_out\u0027,"},{"line_number":132,"context_line":"               \u0027active_connections\u0027, \u0027total_connections\u0027,"},{"line_number":133,"context_line":"               \u0027request_errors\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ac06dbe_3eecd08e","line":130,"in_reply_to":"1ac06dbe_deae5c84","updated":"2016-08-22 01:16:43.000000000","message":"Because the method is never been called when we have the static method decorator.","commit_id":"03d3421ebbb3f5ceb5b1ee98c4f93ae4472be605"}],"octavia/tests/functional/api/v1/base.py":[{"author":{"_account_id":17419,"name":"Banashankar k","email":"banveerad@gmail.com","username":"banveerad"},"change_message_id":"13f9c5427a97c3405059b653e2e04521885a89bd","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            db_api.get_session(), listener_id\u003dlistener_id,"},{"line_number":135,"context_line":"            amphora_id\u003damphora_id, bytes_in\u003d0,"},{"line_number":136,"context_line":"            bytes_out\u003d0, active_connections\u003d0, total_connections\u003d0,"},{"line_number":137,"context_line":"            request_errors\u003d1)"},{"line_number":138,"context_line":"        return db_ls.to_dict()"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def create_amphora(self, amphora_id, loadbalancer_id, **optionals):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_6fc18fe4","line":137,"range":{"start_line":137,"start_character":12,"end_line":137,"end_character":28},"updated":"2016-08-15 18:36:49.000000000","message":"any reason for this to be 1?","commit_id":"a54e83291139324ad682c417fb7d37ec312e4dc8"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"c881b54eacbbefd285d9e4d39cbf80789ce5d4c1","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            db_api.get_session(), listener_id\u003dlistener_id,"},{"line_number":135,"context_line":"            amphora_id\u003damphora_id, bytes_in\u003d0,"},{"line_number":136,"context_line":"            bytes_out\u003d0, active_connections\u003d0, total_connections\u003d0,"},{"line_number":137,"context_line":"            request_errors\u003d1)"},{"line_number":138,"context_line":"        return db_ls.to_dict()"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def create_amphora(self, amphora_id, loadbalancer_id, **optionals):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_2072faad","line":137,"range":{"start_line":137,"start_character":12,"end_line":137,"end_character":28},"in_reply_to":"3ac371cc_6fc18fe4","updated":"2016-08-16 00:44:24.000000000","message":"o. Copied that from another place.....","commit_id":"a54e83291139324ad682c417fb7d37ec312e4dc8"}],"octavia/tests/unit/amphorae/backends/health_daemon/test_health_daemon.py":[{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"2afdba0917a91c653218b5813033f5939feadce8","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                 \u0027hrsp_2xx\u0027: \u00270\u0027, \u0027act\u0027: \u00271\u0027, \u0027chkdown\u0027: \u00270\u0027,"},{"line_number":104,"context_line":"                 \u0027svname\u0027: \u0027BACKEND\u0027, \u0027hrsp_3xx\u0027: \u00270\u0027})"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"SAMPLE_STATS_MSG \u003d {\u0027listeners\u0027: {"},{"line_number":107,"context_line":"                    LISTENER_ID1: {"},{"line_number":108,"context_line":"                        \u0027pools\u0027: {\u0027432fc8b3-d446-48d4-bb64-13beb90e22bc\u0027: {"},{"line_number":109,"context_line":"                            \u0027members\u0027: {"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_cdab3ad5","line":106,"updated":"2016-08-16 15:11:40.000000000","message":"This code is also horrible indentated","commit_id":"ce0d2a7c3ad996ca709898f6570d0092dbe5a6f9"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"f6e6add169b62daa32f683aed3acde53daec479f","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                 \u0027hrsp_2xx\u0027: \u00270\u0027, \u0027act\u0027: \u00271\u0027, \u0027chkdown\u0027: \u00270\u0027,"},{"line_number":104,"context_line":"                 \u0027svname\u0027: \u0027BACKEND\u0027, \u0027hrsp_3xx\u0027: \u00270\u0027})"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"SAMPLE_STATS_MSG \u003d {\u0027listeners\u0027: {"},{"line_number":107,"context_line":"                    LISTENER_ID1: {"},{"line_number":108,"context_line":"                        \u0027pools\u0027: {\u0027432fc8b3-d446-48d4-bb64-13beb90e22bc\u0027: {"},{"line_number":109,"context_line":"                            \u0027members\u0027: {"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_aeae9be3","line":106,"in_reply_to":"3ac371cc_cdab3ad5","updated":"2016-08-17 02:40:35.000000000","message":"Done","commit_id":"ce0d2a7c3ad996ca709898f6570d0092dbe5a6f9"}],"octavia/tests/unit/controller/healthmanager/test_update_db.py":[{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"2afdba0917a91c653218b5813033f5939feadce8","unresolved":false,"context_lines":[{"line_number":480,"context_line":"                                             \"rx\": self.bytes_in,"},{"line_number":481,"context_line":"                                             \"tx\": self.bytes_out},"},{"line_number":482,"context_line":"                                   \"pools\": {\"pool-id-1\":"},{"line_number":483,"context_line":"                                             {\"status\": constants.UP,"},{"line_number":484,"context_line":"                                              \"members\":"},{"line_number":485,"context_line":"                                              {\"member-id-1\": constants.ONLINE}"},{"line_number":486,"context_line":"                                              }"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_edb0b645","line":483,"updated":"2016-08-16 15:11:40.000000000","message":"It\u0027s not a 4 spaces, please reindentate that code","commit_id":"ce0d2a7c3ad996ca709898f6570d0092dbe5a6f9"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"f6e6add169b62daa32f683aed3acde53daec479f","unresolved":false,"context_lines":[{"line_number":480,"context_line":"                                             \"rx\": self.bytes_in,"},{"line_number":481,"context_line":"                                             \"tx\": self.bytes_out},"},{"line_number":482,"context_line":"                                   \"pools\": {\"pool-id-1\":"},{"line_number":483,"context_line":"                                             {\"status\": constants.UP,"},{"line_number":484,"context_line":"                                              \"members\":"},{"line_number":485,"context_line":"                                              {\"member-id-1\": constants.ONLINE}"},{"line_number":486,"context_line":"                                              }"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_ce4dd73f","line":483,"in_reply_to":"3ac371cc_edb0b645","updated":"2016-08-17 02:40:35.000000000","message":"Done","commit_id":"ce0d2a7c3ad996ca709898f6570d0092dbe5a6f9"}]}