)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"f5418939fc43fff72092137ba55ca6da332433c9","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    configure_auth_token_middleware $OCTAVIA_CONF octavia $OCTAVIA_AUTH_CACHE_DIR"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    # Ensure config is set up properly for authentication as admin"},{"line_number":62,"context_line":"    iniset $OCTAVIA_CONF service_auth auth_url $KEYSTONE_AUTH_URI"},{"line_number":63,"context_line":"    iniset $OCTAVIA_CONF service_auth auth_type password"},{"line_number":64,"context_line":"    iniset $OCTAVIA_CONF service_auth username $OCTAVIA_USERNAME"},{"line_number":65,"context_line":"    iniset $OCTAVIA_CONF service_auth password $OCTAVIA_PASSWORD"}],"source_content_type":"text/x-sh","patch_set":11,"id":"5a8bc5a2_6a46d024","line":62,"range":{"start_line":62,"start_character":47,"end_line":62,"end_character":65},"updated":"2016-09-22 13:53:58.000000000","message":"I guess it could be replaced by $OCTAVIA_AUTH_URL which you introduced in settings file.","commit_id":"f8dc29ffeda54b2f0109185c1e3f29e94fffd6b0"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"4679a193f7e71026562b4e68b22ad10b2b1df113","unresolved":false,"context_lines":[{"line_number":42,"context_line":"}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"function create_octavia_accounts {"},{"line_number":45,"context_line":"    create_service_user \"octavia\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    if [[ \"$KEYSTONE_CATALOG_BACKEND\" \u003d \u0027sql\u0027 ]]; then"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-sh","patch_set":18,"id":"7a77a97e_5faf597c","line":45,"updated":"2016-11-18 13:23:29.000000000","message":"As a note, using our own service user means the ACL setup for Barbican secrets will be a bit wonky until everything is fully merged -- ACLs will need to be set for BOTH users. T_T","commit_id":"076e016bb2eae41ff5361ce5fcd8b224de30c946"}],"devstack/settings":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c573002b3957f137b62bb267d2a65d2d430663d2","unresolved":false,"context_lines":[{"line_number":23,"context_line":"OCTAVIA_COMPUTE_DRIVER\u003d${OCTAVIA_COMPUTE_DRIVER:-\"compute_nova_driver\"}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"OCTAVIA_AUTH_VERSION\u003d${OCTAVIA_AUTH_VERSION:-\"3\"}"},{"line_number":26,"context_line":"OCTAVIA_USERNAME\u003d${OCTAVIA_ADMIN_USER:-\"admin\"}"},{"line_number":27,"context_line":"OCTAVIA_PASSWORD\u003d${OCTAVIA_PASSWORD:-${ADMIN_PASSWORD}}"},{"line_number":28,"context_line":"OCTAVIA_PROJECT_ID\u003d${OCTAVIA_TENANT_ID:-${ADMIN_TENANT_ID}}"},{"line_number":29,"context_line":"OCTAVIA_ADMIN_TENANT_NAME\u003d${OCTAVIA_ADMIN_TENANT_NAME:-${OCTAVIA_ADMIN_USER}}"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"fa6399be_41470fbb","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":47},"updated":"2016-10-11 23:35:54.000000000","message":"Defined twice","commit_id":"d868f2931b9919ebf492c682b88b124d5fead699"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"edee060805f03fd078b0f54c1991d4780b87bbcc","unresolved":false,"context_lines":[{"line_number":23,"context_line":"OCTAVIA_COMPUTE_DRIVER\u003d${OCTAVIA_COMPUTE_DRIVER:-\"compute_nova_driver\"}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"OCTAVIA_AUTH_VERSION\u003d${OCTAVIA_AUTH_VERSION:-\"3\"}"},{"line_number":26,"context_line":"OCTAVIA_USERNAME\u003d${OCTAVIA_ADMIN_USER:-\"admin\"}"},{"line_number":27,"context_line":"OCTAVIA_PASSWORD\u003d${OCTAVIA_PASSWORD:-${ADMIN_PASSWORD}}"},{"line_number":28,"context_line":"OCTAVIA_PROJECT_ID\u003d${OCTAVIA_TENANT_ID:-${ADMIN_TENANT_ID}}"},{"line_number":29,"context_line":"OCTAVIA_ADMIN_TENANT_NAME\u003d${OCTAVIA_ADMIN_TENANT_NAME:-${OCTAVIA_ADMIN_USER}}"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"fa6399be_052efcf9","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":47},"in_reply_to":"fa6399be_41470fbb","updated":"2016-10-19 17:39:16.000000000","message":"Done","commit_id":"d868f2931b9919ebf492c682b88b124d5fead699"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c573002b3957f137b62bb267d2a65d2d430663d2","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"OCTAVIA_AUTH_VERSION\u003d${OCTAVIA_AUTH_VERSION:-\"3\"}"},{"line_number":26,"context_line":"OCTAVIA_USERNAME\u003d${OCTAVIA_ADMIN_USER:-\"admin\"}"},{"line_number":27,"context_line":"OCTAVIA_PASSWORD\u003d${OCTAVIA_PASSWORD:-${ADMIN_PASSWORD}}"},{"line_number":28,"context_line":"OCTAVIA_PROJECT_ID\u003d${OCTAVIA_TENANT_ID:-${ADMIN_TENANT_ID}}"},{"line_number":29,"context_line":"OCTAVIA_ADMIN_TENANT_NAME\u003d${OCTAVIA_ADMIN_TENANT_NAME:-${OCTAVIA_ADMIN_USER}}"},{"line_number":30,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":12,"id":"fa6399be_e1266315","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":55},"updated":"2016-10-11 23:35:54.000000000","message":"Defined twice","commit_id":"d868f2931b9919ebf492c682b88b124d5fead699"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"edee060805f03fd078b0f54c1991d4780b87bbcc","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"OCTAVIA_AUTH_VERSION\u003d${OCTAVIA_AUTH_VERSION:-\"3\"}"},{"line_number":26,"context_line":"OCTAVIA_USERNAME\u003d${OCTAVIA_ADMIN_USER:-\"admin\"}"},{"line_number":27,"context_line":"OCTAVIA_PASSWORD\u003d${OCTAVIA_PASSWORD:-${ADMIN_PASSWORD}}"},{"line_number":28,"context_line":"OCTAVIA_PROJECT_ID\u003d${OCTAVIA_TENANT_ID:-${ADMIN_TENANT_ID}}"},{"line_number":29,"context_line":"OCTAVIA_ADMIN_TENANT_NAME\u003d${OCTAVIA_ADMIN_TENANT_NAME:-${OCTAVIA_ADMIN_USER}}"},{"line_number":30,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":12,"id":"fa6399be_2535c045","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":55},"in_reply_to":"fa6399be_e1266315","updated":"2016-10-19 17:39:16.000000000","message":"Done","commit_id":"d868f2931b9919ebf492c682b88b124d5fead699"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c573002b3957f137b62bb267d2a65d2d430663d2","unresolved":false,"context_lines":[{"line_number":29,"context_line":"OCTAVIA_ADMIN_TENANT_NAME\u003d${OCTAVIA_ADMIN_TENANT_NAME:-${OCTAVIA_ADMIN_USER}}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"OCTAVIA_AUTH_URL\u003d${OCTAVIA_AUTH_URL:-$KEYSTONE_AUTH_URI}"},{"line_number":32,"context_line":"OCTAVIA_USERNAME\u003d${OCTAVIA_USERNAME:-\"admin\"}"},{"line_number":33,"context_line":"OCTAVIA_PASSWORD\u003d${OCTAVIA_PASSWORD:-$OCTAVIA_USERNAME}"},{"line_number":34,"context_line":"OCTAVIA_PROJECT_NAME\u003d${OCTAVIA_PROJECT_NAME:-$OCTAVIA_USERNAME}"},{"line_number":35,"context_line":"OCTAVIA_USER_DOMAIN_NAME\u003d${OCTAVIA_USER_DOMAIN_NAME:-\"Default\"}"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"fa6399be_a10c6b95","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":45},"updated":"2016-10-11 23:35:54.000000000","message":"Defined twice","commit_id":"d868f2931b9919ebf492c682b88b124d5fead699"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"edee060805f03fd078b0f54c1991d4780b87bbcc","unresolved":false,"context_lines":[{"line_number":29,"context_line":"OCTAVIA_ADMIN_TENANT_NAME\u003d${OCTAVIA_ADMIN_TENANT_NAME:-${OCTAVIA_ADMIN_USER}}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"OCTAVIA_AUTH_URL\u003d${OCTAVIA_AUTH_URL:-$KEYSTONE_AUTH_URI}"},{"line_number":32,"context_line":"OCTAVIA_USERNAME\u003d${OCTAVIA_USERNAME:-\"admin\"}"},{"line_number":33,"context_line":"OCTAVIA_PASSWORD\u003d${OCTAVIA_PASSWORD:-$OCTAVIA_USERNAME}"},{"line_number":34,"context_line":"OCTAVIA_PROJECT_NAME\u003d${OCTAVIA_PROJECT_NAME:-$OCTAVIA_USERNAME}"},{"line_number":35,"context_line":"OCTAVIA_USER_DOMAIN_NAME\u003d${OCTAVIA_USER_DOMAIN_NAME:-\"Default\"}"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"fa6399be_4538f43d","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":45},"in_reply_to":"fa6399be_a10c6b95","updated":"2016-10-19 17:39:16.000000000","message":"Done","commit_id":"d868f2931b9919ebf492c682b88b124d5fead699"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c573002b3957f137b62bb267d2a65d2d430663d2","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"OCTAVIA_AUTH_URL\u003d${OCTAVIA_AUTH_URL:-$KEYSTONE_AUTH_URI}"},{"line_number":32,"context_line":"OCTAVIA_USERNAME\u003d${OCTAVIA_USERNAME:-\"admin\"}"},{"line_number":33,"context_line":"OCTAVIA_PASSWORD\u003d${OCTAVIA_PASSWORD:-$OCTAVIA_USERNAME}"},{"line_number":34,"context_line":"OCTAVIA_PROJECT_NAME\u003d${OCTAVIA_PROJECT_NAME:-$OCTAVIA_USERNAME}"},{"line_number":35,"context_line":"OCTAVIA_USER_DOMAIN_NAME\u003d${OCTAVIA_USER_DOMAIN_NAME:-\"Default\"}"},{"line_number":36,"context_line":"OCTAVIA_PROJECT_DOMAIN_NAME\u003d${OCTAVIA_PROJECT_DOMAIN_NAME:-\"Default\"}"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"fa6399be_411e2fbb","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":55},"updated":"2016-10-11 23:35:54.000000000","message":"Defined twice","commit_id":"d868f2931b9919ebf492c682b88b124d5fead699"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"edee060805f03fd078b0f54c1991d4780b87bbcc","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"OCTAVIA_AUTH_URL\u003d${OCTAVIA_AUTH_URL:-$KEYSTONE_AUTH_URI}"},{"line_number":32,"context_line":"OCTAVIA_USERNAME\u003d${OCTAVIA_USERNAME:-\"admin\"}"},{"line_number":33,"context_line":"OCTAVIA_PASSWORD\u003d${OCTAVIA_PASSWORD:-$OCTAVIA_USERNAME}"},{"line_number":34,"context_line":"OCTAVIA_PROJECT_NAME\u003d${OCTAVIA_PROJECT_NAME:-$OCTAVIA_USERNAME}"},{"line_number":35,"context_line":"OCTAVIA_USER_DOMAIN_NAME\u003d${OCTAVIA_USER_DOMAIN_NAME:-\"Default\"}"},{"line_number":36,"context_line":"OCTAVIA_PROJECT_DOMAIN_NAME\u003d${OCTAVIA_PROJECT_DOMAIN_NAME:-\"Default\"}"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"fa6399be_653fb825","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":55},"in_reply_to":"fa6399be_411e2fbb","updated":"2016-10-19 17:39:16.000000000","message":"Done","commit_id":"d868f2931b9919ebf492c682b88b124d5fead699"}],"etc/octavia.conf":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c573002b3957f137b62bb267d2a65d2d430663d2","unresolved":false,"context_lines":[{"line_number":242,"context_line":"# The name of the glance service in the keystone catalog"},{"line_number":243,"context_line":"# service_name \u003d"},{"line_number":244,"context_line":"# Custom glance endpoint if override is necessary"},{"line_number":245,"context_line":"# endpoint \u003d"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"# Region in Identity service catalog to use for communication with the OpenStack services."},{"line_number":248,"context_line":"# region_name \u003d"}],"source_content_type":"text/plain","patch_set":12,"id":"fa6399be_a458f9fb","side":"PARENT","line":245,"range":{"start_line":245,"start_character":0,"end_line":245,"end_character":12},"updated":"2016-10-11 23:35:54.000000000","message":"I don\u0027t think we can remove these.  Some operators need to specify specific endpoints and not rely on the keystone catalog.","commit_id":"f1ece8ddd4fbe15a5c2fba6134e8d99bedffb6f1"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"edee060805f03fd078b0f54c1991d4780b87bbcc","unresolved":false,"context_lines":[{"line_number":242,"context_line":"# The name of the glance service in the keystone catalog"},{"line_number":243,"context_line":"# service_name \u003d"},{"line_number":244,"context_line":"# Custom glance endpoint if override is necessary"},{"line_number":245,"context_line":"# endpoint \u003d"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"# Region in Identity service catalog to use for communication with the OpenStack services."},{"line_number":248,"context_line":"# region_name \u003d"}],"source_content_type":"text/plain","patch_set":12,"id":"fa6399be_cc20814c","side":"PARENT","line":245,"range":{"start_line":245,"start_character":0,"end_line":245,"end_character":12},"in_reply_to":"fa6399be_a458f9fb","updated":"2016-10-19 17:39:16.000000000","message":"So I\u0027m not sure is it proper to give the operator a way to change region and other stuff. Endpoint_type true - they should be able to use but allowing to provide something as an endpoint what is not a keystone server don\u0027t looks like a proper solution or I\u0027m wrong and I misunderstood something?","commit_id":"f1ece8ddd4fbe15a5c2fba6134e8d99bedffb6f1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e50e5df517369346ba409fb266eea581ae6044db","unresolved":false,"context_lines":[{"line_number":242,"context_line":"# The name of the glance service in the keystone catalog"},{"line_number":243,"context_line":"# service_name \u003d"},{"line_number":244,"context_line":"# Custom glance endpoint if override is necessary"},{"line_number":245,"context_line":"# endpoint \u003d"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"# Region in Identity service catalog to use for communication with the OpenStack services."},{"line_number":248,"context_line":"# region_name \u003d"}],"source_content_type":"text/plain","patch_set":12,"id":"fa6399be_f2aeda2c","side":"PARENT","line":245,"range":{"start_line":245,"start_character":0,"end_line":245,"end_character":12},"in_reply_to":"fa6399be_cc20814c","updated":"2016-10-20 15:57:12.000000000","message":"These were added for an operator that had a unique topology with \"under\" and \"over\" clouds.  The under cloud was the control plane, which may not have admin api interfaces accessible from the \"over\" clouds which had the customer facing APIs.  It allowed them to have a unique security stance with \"special\" regions and endpoints.  They also had a \"split horizon\" keystone setup.\nSee these:\nhttps://review.openstack.org/#/c/215567/\nhttps://review.openstack.org/#/c/275337/\nhttps://review.openstack.org/#/c/271476/","commit_id":"f1ece8ddd4fbe15a5c2fba6134e8d99bedffb6f1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c573002b3957f137b62bb267d2a65d2d430663d2","unresolved":false,"context_lines":[{"line_number":245,"context_line":"# endpoint \u003d"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"# Region in Identity service catalog to use for communication with the OpenStack services."},{"line_number":248,"context_line":"# region_name \u003d"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"# Endpoint type in Identity service catalog to use for communication with"},{"line_number":251,"context_line":"# the OpenStack services."}],"source_content_type":"text/plain","patch_set":12,"id":"fa6399be_645ee1ea","side":"PARENT","line":248,"range":{"start_line":248,"start_character":0,"end_line":248,"end_character":15},"updated":"2016-10-11 23:35:54.000000000","message":"I don\u0027t think we can remove these either.","commit_id":"f1ece8ddd4fbe15a5c2fba6134e8d99bedffb6f1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c573002b3957f137b62bb267d2a65d2d430663d2","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"# Endpoint type in Identity service catalog to use for communication with"},{"line_number":251,"context_line":"# the OpenStack services."},{"line_number":252,"context_line":"# endpoint_type \u003d publicURL"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"# CA certificates file to verify glance connections when TLS is enabled"},{"line_number":255,"context_line":"# insecure \u003d False"}],"source_content_type":"text/plain","patch_set":12,"id":"fa6399be_44539de1","side":"PARENT","line":252,"range":{"start_line":252,"start_character":0,"end_line":252,"end_character":27},"updated":"2016-10-11 23:35:54.000000000","message":"Same here.  I\u0027m pretty sure at least one operator is using this.","commit_id":"f1ece8ddd4fbe15a5c2fba6134e8d99bedffb6f1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c573002b3957f137b62bb267d2a65d2d430663d2","unresolved":false,"context_lines":[{"line_number":253,"context_line":""},{"line_number":254,"context_line":"# CA certificates file to verify glance connections when TLS is enabled"},{"line_number":255,"context_line":"# insecure \u003d False"},{"line_number":256,"context_line":"# ca_certificates_file \u003d"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"[nova]"},{"line_number":259,"context_line":"# The name of the nova service in the keystone catalog"}],"source_content_type":"text/plain","patch_set":12,"id":"fa6399be_44747d34","side":"PARENT","line":256,"range":{"start_line":256,"start_character":0,"end_line":256,"end_character":24},"updated":"2016-10-11 23:35:54.000000000","message":"Same","commit_id":"f1ece8ddd4fbe15a5c2fba6134e8d99bedffb6f1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c573002b3957f137b62bb267d2a65d2d430663d2","unresolved":false,"context_lines":[{"line_number":243,"context_line":"# password \u003d password"},{"line_number":244,"context_line":"# username \u003d admin"},{"line_number":245,"context_line":"# auth_type \u003d password"},{"line_number":246,"context_line":"# auth_url \u003d http://192.168.12.230/identity_v2_admin"}],"source_content_type":"text/plain","patch_set":12,"id":"fa6399be_84ee9520","line":246,"range":{"start_line":246,"start_character":13,"end_line":246,"end_character":52},"updated":"2016-10-11 23:35:54.000000000","message":"Should we really have this URL in here?  It looks like a v2 url","commit_id":"d868f2931b9919ebf492c682b88b124d5fead699"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"edee060805f03fd078b0f54c1991d4780b87bbcc","unresolved":false,"context_lines":[{"line_number":243,"context_line":"# password \u003d password"},{"line_number":244,"context_line":"# username \u003d admin"},{"line_number":245,"context_line":"# auth_type \u003d password"},{"line_number":246,"context_line":"# auth_url \u003d http://192.168.12.230/identity_v2_admin"}],"source_content_type":"text/plain","patch_set":12,"id":"fa6399be_05ca7c1a","line":246,"range":{"start_line":246,"start_character":13,"end_line":246,"end_character":52},"in_reply_to":"fa6399be_84ee9520","updated":"2016-10-19 17:39:16.000000000","message":"Done","commit_id":"d868f2931b9919ebf492c682b88b124d5fead699"},{"author":{"_account_id":31827,"name":"Jorhson Deng","email":"jorhson_deng@163.com","username":"dengzhaosen"},"change_message_id":"8166a643b37f6b657dfe67c92797011679173d33","unresolved":false,"context_lines":[{"line_number":232,"context_line":"# vrrp_garp_refresh_count \u003d 2"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"[service_auth]"},{"line_number":235,"context_line":"# memcached_servers \u003d "},{"line_number":236,"context_line":"# signing_dir \u003d"},{"line_number":237,"context_line":"# cafile \u003d /opt/stack/data/ca-bundle.pem"},{"line_number":238,"context_line":"# project_domain_name \u003d Default"}],"source_content_type":"text/plain","patch_set":18,"id":"9f560f44_ce6987f8","line":235,"range":{"start_line":235,"start_character":0,"end_line":235,"end_character":22},"updated":"2020-09-11 07:29:56.000000000","message":"I have a question. why should this parameter be placed in [keystone_authtoken], if in [service_auth], which file to register these parameters?","commit_id":"076e016bb2eae41ff5361ce5fcd8b224de30c946"}],"octavia/certificates/common/auth/barbican_acl.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c573002b3957f137b62bb267d2a65d2d430663d2","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        if not cls._barbican_client:"},{"line_number":40,"context_line":"            try:"},{"line_number":41,"context_line":"                session \u003d keystone.KeystoneSession("},{"line_number":42,"context_line":"                    \u0027certificates\u0027).get_session()"},{"line_number":43,"context_line":"                cls._barbican_client \u003d barbican_client.Client("},{"line_number":44,"context_line":"                    session\u003dsession,"},{"line_number":45,"context_line":"                    region_name\u003dCONF.certificates.region_name,"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa6399be_c4b96deb","line":42,"range":{"start_line":42,"start_character":20,"end_line":42,"end_character":34},"updated":"2016-10-11 23:35:54.000000000","message":"This should probably be a constant","commit_id":"d868f2931b9919ebf492c682b88b124d5fead699"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e50e5df517369346ba409fb266eea581ae6044db","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        if not cls._barbican_client:"},{"line_number":40,"context_line":"            try:"},{"line_number":41,"context_line":"                session \u003d keystone.KeystoneSession("},{"line_number":42,"context_line":"                    \u0027certificates\u0027).get_session()"},{"line_number":43,"context_line":"                cls._barbican_client \u003d barbican_client.Client("},{"line_number":44,"context_line":"                    session\u003dsession,"},{"line_number":45,"context_line":"                    region_name\u003dCONF.certificates.region_name,"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa6399be_1247cebc","line":42,"range":{"start_line":42,"start_character":20,"end_line":42,"end_character":34},"in_reply_to":"fa6399be_a5e550a9","updated":"2016-10-20 15:57:12.000000000","message":"No, I think certificates is fine, but we should put this string in the common/constants.py file and reference this via constants.","commit_id":"d868f2931b9919ebf492c682b88b124d5fead699"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"edee060805f03fd078b0f54c1991d4780b87bbcc","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        if not cls._barbican_client:"},{"line_number":40,"context_line":"            try:"},{"line_number":41,"context_line":"                session \u003d keystone.KeystoneSession("},{"line_number":42,"context_line":"                    \u0027certificates\u0027).get_session()"},{"line_number":43,"context_line":"                cls._barbican_client \u003d barbican_client.Client("},{"line_number":44,"context_line":"                    session\u003dsession,"},{"line_number":45,"context_line":"                    region_name\u003dCONF.certificates.region_name,"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa6399be_a5e550a9","line":42,"range":{"start_line":42,"start_character":20,"end_line":42,"end_character":34},"in_reply_to":"fa6399be_c4b96deb","updated":"2016-10-19 17:39:16.000000000","message":"That I should use barbican not certificates?","commit_id":"d868f2931b9919ebf492c682b88b124d5fead699"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"e34d8a08c3cb56acd457ad5b2fc9267079337a95","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                    \u0027certificates\u0027).get_session()"},{"line_number":43,"context_line":"                cls._barbican_client \u003d barbican_client.Client("},{"line_number":44,"context_line":"                    session\u003dsession,"},{"line_number":45,"context_line":"                    region_name\u003dCONF.certificates.region_name,"},{"line_number":46,"context_line":"                    interface\u003dCONF.certificates.endpoint_type"},{"line_number":47,"context_line":"                )"},{"line_number":48,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_1153053a","line":45,"updated":"2016-10-15 14:30:33.000000000","message":"How are these loaded now that you\u0027ve removed the config section? I think CONF.certificates no longer exists as a namespace?","commit_id":"47948da50888ffe2cb4f4f697cc1cf9351d6ab29"}],"octavia/common/clients.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c573002b3957f137b62bb267d2a65d2d430663d2","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    nova_client \u003d None"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def get_nova_client(cls, region, service_name\u003dNone, endpoint\u003dNone,"},{"line_number":34,"context_line":"                        endpoint_type\u003d\u0027publicURL\u0027, insecure\u003dFalse,"},{"line_number":35,"context_line":"                        cacert\u003dNone):"},{"line_number":36,"context_line":"        \"\"\"Create nova client object."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        :param region: The region of the service"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa6399be_e4f8317f","side":"PARENT","line":35,"range":{"start_line":33,"start_character":27,"end_line":35,"end_character":35},"updated":"2016-10-11 23:35:54.000000000","message":"Same thing here, I think this all needs to go back in.","commit_id":"f1ece8ddd4fbe15a5c2fba6134e8d99bedffb6f1"}],"octavia/compute/drivers/nova_driver.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c573002b3957f137b62bb267d2a65d2d430663d2","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        super(VirtualMachineManager, self).__init__()"},{"line_number":79,"context_line":"        # Must initialize nova api"},{"line_number":80,"context_line":"        self._nova_client \u003d clients.NovaAuth.get_nova_client("},{"line_number":81,"context_line":"            endpoint\u003dCONF.nova.endpoint,"},{"line_number":82,"context_line":"            region\u003dCONF.nova.region_name,"},{"line_number":83,"context_line":"            endpoint_type\u003dCONF.nova.endpoint_type,"},{"line_number":84,"context_line":"            insecure\u003dCONF.nova.insecure,"},{"line_number":85,"context_line":"            cacert\u003dCONF.nova.ca_certificates_file)"},{"line_number":86,"context_line":"        self._glance_client \u003d clients.GlanceAuth.get_glance_client("},{"line_number":87,"context_line":"            service_name\u003dCONF.glance.service_name,"},{"line_number":88,"context_line":"            endpoint\u003dCONF.glance.endpoint,"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa6399be_244a29c6","side":"PARENT","line":85,"range":{"start_line":81,"start_character":12,"end_line":85,"end_character":50},"updated":"2016-10-11 23:35:54.000000000","message":"Again, this stuff probably needs to return.","commit_id":"f1ece8ddd4fbe15a5c2fba6134e8d99bedffb6f1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7aac4b2d0eb5d677f3d06af0f1e0e974c4693b9c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"CONF \u003d cfg.CONF"},{"line_number":29,"context_line":"CONF.import_group(\u0027networking\u0027, \u0027octavia.common.config\u0027)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def _extract_amp_image_id_by_tag(client, image_tag, image_owner):"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a77a97e_06488d5a","line":29,"updated":"2016-11-16 23:14:35.000000000","message":"nit: Why did you leave this one?","commit_id":"6dbbfc3c624f65c21c69a6984a2dfd8563b1169f"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"64d730fd182be56ef9c0f933ca01cef302ca30a0","unresolved":false,"context_lines":[{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"CONF \u003d cfg.CONF"},{"line_number":29,"context_line":"CONF.import_group(\u0027networking\u0027, \u0027octavia.common.config\u0027)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def _extract_amp_image_id_by_tag(client, image_tag, image_owner):"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a77a97e_1901ab6a","line":29,"in_reply_to":"7a77a97e_06488d5a","updated":"2016-11-17 16:20:25.000000000","message":"I don\u0027t know :P In PS about removing all import group I will remove this also, ok?","commit_id":"6dbbfc3c624f65c21c69a6984a2dfd8563b1169f"}],"octavia/network/drivers/neutron/allowed_address_pairs.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c573002b3957f137b62bb267d2a65d2d430663d2","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        super(AllowedAddressPairsDriver, self).__init__()"},{"line_number":50,"context_line":"        self._check_aap_loaded()"},{"line_number":51,"context_line":"        self.nova_client \u003d clients.NovaAuth.get_nova_client("},{"line_number":52,"context_line":"            endpoint\u003dCONF.nova.endpoint,"},{"line_number":53,"context_line":"            region\u003dCONF.nova.region_name,"},{"line_number":54,"context_line":"            endpoint_type\u003dCONF.nova.endpoint_type,"},{"line_number":55,"context_line":"            service_name\u003dCONF.nova.service_name,"},{"line_number":56,"context_line":"            insecure\u003dCONF.nova.insecure,"},{"line_number":57,"context_line":"            cacert\u003dCONF.nova.ca_certificates_file"},{"line_number":58,"context_line":"        )"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _check_aap_loaded(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa6399be_44471dbb","side":"PARENT","line":57,"range":{"start_line":52,"start_character":12,"end_line":57,"end_character":49},"updated":"2016-10-11 23:35:54.000000000","message":"Same","commit_id":"f1ece8ddd4fbe15a5c2fba6134e8d99bedffb6f1"}],"octavia/network/drivers/neutron/base.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c573002b3957f137b62bb267d2a65d2d430663d2","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def __init__(self):"},{"line_number":38,"context_line":"        self.neutron_client \u003d clients.NeutronAuth.get_neutron_client("},{"line_number":39,"context_line":"            endpoint\u003dCONF.neutron.endpoint,"},{"line_number":40,"context_line":"            region\u003dCONF.neutron.region_name,"},{"line_number":41,"context_line":"            endpoint_type\u003dCONF.neutron.endpoint_type,"},{"line_number":42,"context_line":"            service_name\u003dCONF.neutron.service_name,"},{"line_number":43,"context_line":"            insecure\u003dCONF.neutron.insecure,"},{"line_number":44,"context_line":"            ca_cert\u003dCONF.neutron.ca_certificates_file"},{"line_number":45,"context_line":"        )"},{"line_number":46,"context_line":"        self._check_extension_cache \u003d {}"},{"line_number":47,"context_line":"        self.sec_grp_enabled \u003d self._check_extension_enabled(SEC_GRP_EXT_ALIAS)"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa6399be_641261b6","side":"PARENT","line":44,"range":{"start_line":39,"start_character":12,"end_line":44,"end_character":53},"updated":"2016-10-11 23:35:54.000000000","message":"Same","commit_id":"f1ece8ddd4fbe15a5c2fba6134e8d99bedffb6f1"}],"octavia/opts.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c573002b3957f137b62bb267d2a65d2d430663d2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import octavia.common.config"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"def list_opts():"},{"line_number":19,"context_line":"    return ["},{"line_number":20,"context_line":"        (\u0027DEFAULT\u0027,"},{"line_number":21,"context_line":"         itertools.chain(octavia.common.config.core_opts)),"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa6399be_bf0e4632","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":16},"updated":"2016-10-11 23:35:54.000000000","message":"I think we need a section here since you added the [service_auth] section.\nSomething like this section:\nhttp://docs.openstack.org/newton/config-reference/common-configurations/auth.html\nWhich may come in via:\nhttps://github.com/openstack/neutron/blob/master/neutron/opts.py#L297\nRegistered here: https://github.com/openstack/octavia/blob/master/setup.cfg#L74","commit_id":"d868f2931b9919ebf492c682b88b124d5fead699"}],"octavia/tests/unit/common/test_clients.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c573002b3957f137b62bb267d2a65d2d430663d2","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        # Mock out the keystone session and get the client"},{"line_number":44,"context_line":"        keystone._SESSION \u003d mock.MagicMock()"},{"line_number":45,"context_line":"        bc1 \u003d clients.NovaAuth.get_nova_client(region\u003dNone,"},{"line_number":46,"context_line":"                                               endpoint_type\u003d\u0027publicURL\u0027)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        # Our returned client should also be the saved client"},{"line_number":49,"context_line":"        self.assertIsInstance("}],"source_content_type":"text/x-python","patch_set":12,"id":"fa6399be_3f6076ce","side":"PARENT","line":46,"range":{"start_line":46,"start_character":47,"end_line":46,"end_character":72},"updated":"2016-10-11 23:35:54.000000000","message":"Needs to come back.\nSame for the rest of them here.","commit_id":"f1ece8ddd4fbe15a5c2fba6134e8d99bedffb6f1"}],"releasenotes/notes/change-keystone-backend-config-d246b1e34015c86c.yaml":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c573002b3957f137b62bb267d2a65d2d430663d2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Support for Keystone API v3."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - Octavia supports different Keystone APIs and choose authentication"},{"line_number":6,"context_line":"    mechanism based on configuration specified in \"keystone_authtoken\" section"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"fa6399be_9f7c2274","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":32},"updated":"2016-10-11 23:35:54.000000000","message":"We had support for Keystone API v3 in the past, so this should probably be reworded.","commit_id":"d868f2931b9919ebf492c682b88b124d5fead699"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"edee060805f03fd078b0f54c1991d4780b87bbcc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Support for Keystone API v3."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - Octavia supports different Keystone APIs and choose authentication"},{"line_number":6,"context_line":"    mechanism based on configuration specified in \"keystone_authtoken\" section"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"fa6399be_ccafa1e1","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":32},"in_reply_to":"fa6399be_9f7c2274","updated":"2016-10-19 17:39:16.000000000","message":"Done","commit_id":"d868f2931b9919ebf492c682b88b124d5fead699"}]}