)]}'
{"octavia/amphorae/backends/agent/api_server/listener.py":[{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"5c00ad21f5f2f686f0d9f7c5fb31df3a285b47a5","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    # HAProxy does not start the process when given a reload"},{"line_number":180,"context_line":"    # so start it if haproxy is not already running"},{"line_number":181,"context_line":"    if action \u003d\u003d \u0027reload\u0027:"},{"line_number":182,"context_line":"        if consts.OFFLINE \u003d\u003d _check_haproxy_status(listener_id):"},{"line_number":183,"context_line":"            action \u003d \u0027start\u0027"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_8f298f9d","line":181,"range":{"start_line":181,"start_character":18,"end_line":181,"end_character":24},"updated":"2016-09-08 16:44:40.000000000","message":"Nit: Personally, I would prefer to see this all actions as constants in this class.","commit_id":"9eaa623953f05de537302128f6906ada8475d3fb"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"832db86850d2e705e0cd33460b08c21fcef8014a","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    # HAProxy does not start the process when given a reload"},{"line_number":180,"context_line":"    # so start it if haproxy is not already running"},{"line_number":181,"context_line":"    if action \u003d\u003d \u0027reload\u0027:"},{"line_number":182,"context_line":"        if consts.OFFLINE \u003d\u003d _check_haproxy_status(listener_id):"},{"line_number":183,"context_line":"            action \u003d \u0027start\u0027"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_ccafe092","line":181,"range":{"start_line":181,"start_character":18,"end_line":181,"end_character":24},"in_reply_to":"9a89bdaa_541c6a13","updated":"2016-09-09 17:28:49.000000000","message":"Ditto for me: I don\u0027t really like comparisons with or assignments to string literals in code, even if they\u0027re only used once.","commit_id":"9eaa623953f05de537302128f6906ada8475d3fb"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"84bdd3e1e3064e97d0437ba78825bd2fab1e4fbf","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    # HAProxy does not start the process when given a reload"},{"line_number":180,"context_line":"    # so start it if haproxy is not already running"},{"line_number":181,"context_line":"    if action \u003d\u003d \u0027reload\u0027:"},{"line_number":182,"context_line":"        if consts.OFFLINE \u003d\u003d _check_haproxy_status(listener_id):"},{"line_number":183,"context_line":"            action \u003d \u0027start\u0027"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_541c6a13","line":181,"range":{"start_line":181,"start_character":18,"end_line":181,"end_character":24},"in_reply_to":"9a89bdaa_8f298f9d","updated":"2016-09-09 00:37:00.000000000","message":"I guess if there\u0027s another patchset it\u0027d be nice for them to be constants, yeah... I also consider this a nit though.","commit_id":"9eaa623953f05de537302128f6906ada8475d3fb"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"18ffa42bad6e26635cd4713d4b6e7f83f4e0f92b","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    # HAProxy does not start the process when given a reload"},{"line_number":180,"context_line":"    # so start it if haproxy is not already running"},{"line_number":181,"context_line":"    if action \u003d\u003d \u0027reload\u0027:"},{"line_number":182,"context_line":"        if consts.OFFLINE \u003d\u003d _check_haproxy_status(listener_id):"},{"line_number":183,"context_line":"            action \u003d \u0027start\u0027"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_2371db76","line":181,"range":{"start_line":181,"start_character":18,"end_line":181,"end_character":24},"in_reply_to":"9a89bdaa_ccafe092","updated":"2016-09-12 23:59:20.000000000","message":"Yep, just following the convention in the file (i.e. I touched it so I bought it...), but I will fix all of them.","commit_id":"9eaa623953f05de537302128f6906ada8475d3fb"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"84bdd3e1e3064e97d0437ba78825bd2fab1e4fbf","unresolved":false,"context_lines":[{"line_number":465,"context_line":"        else:  # pid file but no process..."},{"line_number":466,"context_line":"            return consts.OFFLINE"},{"line_number":467,"context_line":"    else:"},{"line_number":468,"context_line":"        return consts.OFFLINE"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_3e67c0eb","line":468,"updated":"2016-09-09 00:37:00.000000000","message":"I\u0027m thinking about this nested if/else, and I believe it would actually be the same as doing it with a single if/else using AND, since in both else-cases you just return OFFLINE. Did you do this for pep8 reasons? lol","commit_id":"9eaa623953f05de537302128f6906ada8475d3fb"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"832db86850d2e705e0cd33460b08c21fcef8014a","unresolved":false,"context_lines":[{"line_number":465,"context_line":"        else:  # pid file but no process..."},{"line_number":466,"context_line":"            return consts.OFFLINE"},{"line_number":467,"context_line":"    else:"},{"line_number":468,"context_line":"        return consts.OFFLINE"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_ccb8c0e8","line":468,"in_reply_to":"9a89bdaa_3e67c0eb","updated":"2016-09-09 17:28:49.000000000","message":"Yeah, this should really just be a single if statement with an AND in it.","commit_id":"9eaa623953f05de537302128f6906ada8475d3fb"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"18ffa42bad6e26635cd4713d4b6e7f83f4e0f92b","unresolved":false,"context_lines":[{"line_number":465,"context_line":"        else:  # pid file but no process..."},{"line_number":466,"context_line":"            return consts.OFFLINE"},{"line_number":467,"context_line":"    else:"},{"line_number":468,"context_line":"        return consts.OFFLINE"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_835f07e4","line":468,"in_reply_to":"9a89bdaa_ccb8c0e8","updated":"2016-09-12 23:59:20.000000000","message":"Personally this is more readable and allows the comment, not to mention the pep8 nightmare with long lines.\nI will change it.","commit_id":"9eaa623953f05de537302128f6906ada8475d3fb"}],"octavia/tests/unit/amphorae/drivers/haproxy/test_rest_api_driver.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"84bdd3e1e3064e97d0437ba78825bd2fab1e4fbf","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        self.driver.client.reload_listener.assert_called_once_with("},{"line_number":123,"context_line":"            self.amp, self.sl.id)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        # listener down"},{"line_number":126,"context_line":"        self.driver.client.get_cert_md5sum.side_effect \u003d ["},{"line_number":127,"context_line":"            \u0027d41d8cd98f00b204e9800998ecf8427e\u0027] * 3"},{"line_number":128,"context_line":"        self.driver.jinja.build_config.side_effect \u003d [\u0027fake_config\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_5eaba4d6","side":"PARENT","line":125,"updated":"2016-09-09 00:37:00.000000000","message":"I assume this went away along with us calling \"start_listener\", but isn\u0027t the case itself still valid? Is it tested elsewhere?","commit_id":"b6a52a7d4f0303c53536261f7b8dd6ed870064e4"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"832db86850d2e705e0cd33460b08c21fcef8014a","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        self.driver.client.reload_listener.assert_called_once_with("},{"line_number":123,"context_line":"            self.amp, self.sl.id)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        # listener down"},{"line_number":126,"context_line":"        self.driver.client.get_cert_md5sum.side_effect \u003d ["},{"line_number":127,"context_line":"            \u0027d41d8cd98f00b204e9800998ecf8427e\u0027] * 3"},{"line_number":128,"context_line":"        self.driver.jinja.build_config.side_effect \u003d [\u0027fake_config\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_ccb440d3","side":"PARENT","line":125,"in_reply_to":"9a89bdaa_5eaba4d6","updated":"2016-09-09 17:28:49.000000000","message":"I\u0027m on board with Adam on this too: Seems like this test should still work and be valid.","commit_id":"b6a52a7d4f0303c53536261f7b8dd6ed870064e4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"18ffa42bad6e26635cd4713d4b6e7f83f4e0f92b","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        self.driver.client.reload_listener.assert_called_once_with("},{"line_number":123,"context_line":"            self.amp, self.sl.id)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        # listener down"},{"line_number":126,"context_line":"        self.driver.client.get_cert_md5sum.side_effect \u003d ["},{"line_number":127,"context_line":"            \u0027d41d8cd98f00b204e9800998ecf8427e\u0027] * 3"},{"line_number":128,"context_line":"        self.driver.jinja.build_config.side_effect \u003d [\u0027fake_config\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_63ecc3f3","side":"PARENT","line":125,"in_reply_to":"9a89bdaa_ccb440d3","updated":"2016-09-12 23:59:20.000000000","message":"This test is bogus now since we no longer check if the listener is up or down prior to sending the update call.  Basically the driver no longer cares if the listener is up or down, that is a consideration for the amphora-agent to deal with.  I removed all of this logic from the driver and we only call reload now, which is tested in the lines above.","commit_id":"b6a52a7d4f0303c53536261f7b8dd6ed870064e4"}]}