)]}'
{"octavia/compute/compute_base.py":[{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"eaa06fc10c25441248c09bc9bd49d5d2fc3e25b6","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @abc.abstractmethod"},{"line_number":24,"context_line":"    def build(self, name\u003d\"amphora_name\", amphora_flavor\u003dNone,"},{"line_number":25,"context_line":"              image_id\u003dNone, image_tag\u003dNone, image_owner\u003dNone,"},{"line_number":26,"context_line":"              key_name\u003dNone, sec_groups\u003dNone, network_ids\u003dNone,"},{"line_number":27,"context_line":"              config_drive_files\u003dNone, user_data\u003dNone, server_group_id\u003dNone):"},{"line_number":28,"context_line":"        \"\"\"Build a new amphora."}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_b0b1d9e3","line":25,"range":{"start_line":25,"start_character":45,"end_line":25,"end_character":61},"updated":"2016-09-15 11:24:12.000000000","message":"Since this restriction is done for security reasones, will this be a good default?\nWith this default, the option of somemone missing that config option and exposing his setup to this issue still exists.\n\nIMHO, a better default would be the tenant_id of amp_boot_network_list (lb-mgmt-net).","commit_id":"84da978f570f2fe04f40fc5403dda1efbfdfbb4e"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"216df17319322b5985acc61124c6710365874bd6","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @abc.abstractmethod"},{"line_number":24,"context_line":"    def build(self, name\u003d\"amphora_name\", amphora_flavor\u003dNone,"},{"line_number":25,"context_line":"              image_id\u003dNone, image_tag\u003dNone, image_owner\u003dNone,"},{"line_number":26,"context_line":"              key_name\u003dNone, sec_groups\u003dNone, network_ids\u003dNone,"},{"line_number":27,"context_line":"              config_drive_files\u003dNone, user_data\u003dNone, server_group_id\u003dNone):"},{"line_number":28,"context_line":"        \"\"\"Build a new amphora."}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_eb3b6f36","line":25,"range":{"start_line":25,"start_character":45,"end_line":25,"end_character":61},"in_reply_to":"7a8ec9b2_b0b1d9e3","updated":"2016-09-15 12:31:09.000000000","message":"@nir\u0027s is a fair point if we want to provide good security by default. But I\u0027m not sure how could we resolve from \"lb-mgmt-net\" owner to the image owner easily. I guess that by querying neutron (and caching).","commit_id":"84da978f570f2fe04f40fc5403dda1efbfdfbb4e"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"255a3ae96dd75e7a0d69bff1e507dcf836de0b72","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @abc.abstractmethod"},{"line_number":24,"context_line":"    def build(self, name\u003d\"amphora_name\", amphora_flavor\u003dNone,"},{"line_number":25,"context_line":"              image_id\u003dNone, image_tag\u003dNone, image_owner\u003dNone,"},{"line_number":26,"context_line":"              key_name\u003dNone, sec_groups\u003dNone, network_ids\u003dNone,"},{"line_number":27,"context_line":"              config_drive_files\u003dNone, user_data\u003dNone, server_group_id\u003dNone):"},{"line_number":28,"context_line":"        \"\"\"Build a new amphora."}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_eb50cf60","line":25,"range":{"start_line":25,"start_character":45,"end_line":25,"end_character":61},"in_reply_to":"7a8ec9b2_eb3b6f36","updated":"2016-09-15 12:32:02.000000000","message":"What if we make None mean \"the owner of the lb-mgmt-net\" ?","commit_id":"84da978f570f2fe04f40fc5403dda1efbfdfbb4e"}],"octavia/compute/drivers/nova_driver.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"0ffc98821d6ed387930ffbbe2ce65d3b66a2c86b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            filters\u003d{\u0027tag\u0027: [image_tag],"},{"line_number":46,"context_line":"                     \u0027status\u0027: constants.GLANCE_IMAGE_ACTIVE},"},{"line_number":47,"context_line":"            sort\u003d\u0027created_at:desc\u0027,"},{"line_number":48,"context_line":"            limit\u003d2))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    if not images:"},{"line_number":51,"context_line":"        raise exceptions.GlanceNoTaggedImages(tag\u003dimage_tag)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_96a90e93","line":48,"updated":"2016-09-16 00:08:26.000000000","message":"Just out of curiosity, why is limit\u003d2 not limit\u003d1?","commit_id":"d7d062a47ab54a540d81f13a0e5f3085ebfaa0d2"}]}