)]}'
{"octavia/amphorae/backends/agent/api_server/plug.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"84cf288188c3090035d29d2b406097be927e1751","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        netmask \u003d (network.prefixlen if ip.version is 6"},{"line_number":64,"context_line":"                   else network.netmask.exploded)"},{"line_number":65,"context_line":"        if not mtu:"},{"line_number":66,"context_line":"            mtu \u003d 1500"},{"line_number":67,"context_line":"        vrrp_version \u003d None"},{"line_number":68,"context_line":"        if vrrp_ip:"},{"line_number":69,"context_line":"            vrrp_ip_obj \u003d ipaddress.ip_address("}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_e01e1aba","line":66,"updated":"2016-09-30 11:56:14.000000000","message":"Shouldn\u0027t this be using a default from a config or something? I guess maybe this is OK, but I feel like everything else that we default comes from a config variable.","commit_id":"733a0583f7071e1c966959bb62bc5e86ab70f6d0"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"84cf288188c3090035d29d2b406097be927e1751","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        return flask.make_response(flask.jsonify(dict("},{"line_number":244,"context_line":"            message\u003d\"Invalid network port\")), 400)"},{"line_number":245,"context_line":"    if not mtu:"},{"line_number":246,"context_line":"        mtu \u003d 1500"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    default_netns_interface \u003d _interface_by_mac(mac_address)"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_001ce6bf","line":246,"updated":"2016-09-30 11:56:14.000000000","message":"Same as above.","commit_id":"733a0583f7071e1c966959bb62bc5e86ab70f6d0"}],"octavia/tests/functional/amphorae/backend/agent/api_server/test_server_sysvinit.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"84cf288188c3090035d29d2b406097be927e1751","unresolved":false,"context_lines":[{"line_number":645,"context_line":"                \u0027\\niface \u0027 + consts.NETNS_PRIMARY_INTERFACE +"},{"line_number":646,"context_line":"                \u0027 inet static\\n\u0027 +"},{"line_number":647,"context_line":"                \u0027address \u0027 + IP + \u0027\\nbroadcast \u0027 + BROADCAST + \u0027\\n\u0027 +"},{"line_number":648,"context_line":"                \u0027netmask \u0027 + NETMASK + \u0027\\n\u0027 + \u0027mtu 1500\\n\u0027 +"},{"line_number":649,"context_line":"                \u0027up route add -net \u0027 + DEST1 + \u0027 gw \u0027 + NEXTHOP +"},{"line_number":650,"context_line":"                \u0027 dev \u0027 + consts.NETNS_PRIMARY_INTERFACE + \u0027\\n\u0027"},{"line_number":651,"context_line":"                \u0027down route del -net \u0027 + DEST1 + \u0027 gw \u0027 + NEXTHOP +"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_e0e37aa2","line":648,"updated":"2016-09-30 11:56:14.000000000","message":"As in one of the other files, please follow the pattern of defining this constant above, with the rest of the constants (IP/MAC/DEST1/DEST2/NEXTHOP/MTU)","commit_id":"733a0583f7071e1c966959bb62bc5e86ab70f6d0"}],"octavia/tests/unit/amphorae/backends/agent/api_server/test_plug.py":[{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"21cc5117ab9a605b0dff06d10a428c04c2eea385","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                          {\u0027destination\u0027: DEST2, \u0027nexthop\u0027: NEXTHOP}"},{"line_number":153,"context_line":"                      ]}]"},{"line_number":154,"context_line":"        text \u003d plug._generate_network_file_text(netns_interface,"},{"line_number":155,"context_line":"                                                fixed_ips, 1450)"},{"line_number":156,"context_line":"        expected_text \u003d ("},{"line_number":157,"context_line":"            \u0027\\n\\n# Generated by Octavia agent\\n\u0027"},{"line_number":158,"context_line":"            \u0027auto \u0027 + netns_interface + \u0027\\n\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_60f0d5c9","line":155,"range":{"start_line":155,"start_character":59,"end_line":155,"end_character":63},"updated":"2016-09-27 15:32:09.000000000","message":"Please follow the pattern and define this as a variable above, like every other parameter passed to this method.","commit_id":"6078b46f50b304f83a5953908f5ed5a4bf2ddeff"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"84cf288188c3090035d29d2b406097be927e1751","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                          {\u0027destination\u0027: DEST1, \u0027nexthop\u0027: NEXTHOP},"},{"line_number":152,"context_line":"                          {\u0027destination\u0027: DEST2, \u0027nexthop\u0027: NEXTHOP}"},{"line_number":153,"context_line":"                      ]}]"},{"line_number":154,"context_line":"        MTU \u003d 1450"},{"line_number":155,"context_line":"        text \u003d plug._generate_network_file_text(netns_interface,"},{"line_number":156,"context_line":"                                                fixed_ips, MTU)"},{"line_number":157,"context_line":"        expected_text \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_e0f0da93","line":154,"updated":"2016-09-30 11:56:14.000000000","message":"I\u0027d prefer this was defined in the same place as the rest of the constants, but it\u0027s only a few lines above so it isn\u0027t a huge deal.\nIf you do make another patchset though, please move this up just a little bit (just above fixed_ips is good).","commit_id":"733a0583f7071e1c966959bb62bc5e86ab70f6d0"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"84cf288188c3090035d29d2b406097be927e1751","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        MTU \u003d 1450"},{"line_number":155,"context_line":"        text \u003d plug._generate_network_file_text(netns_interface,"},{"line_number":156,"context_line":"                                                fixed_ips, MTU)"},{"line_number":157,"context_line":"        expected_text \u003d ("},{"line_number":158,"context_line":"            \u0027\\n\\n# Generated by Octavia agent\\n\u0027"},{"line_number":159,"context_line":"            \u0027auto \u0027 + netns_interface + \u0027\\n\u0027"},{"line_number":160,"context_line":"            \u0027iface \u0027 + netns_interface + \u0027 inet static\\n\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_00d786ed","line":157,"updated":"2016-09-30 11:56:14.000000000","message":"Ugh, this whole thing *should* be using .format() but I guess this is fine...","commit_id":"733a0583f7071e1c966959bb62bc5e86ab70f6d0"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"23668fd2669bbd6ab63cffb142cfbb6e3427b221","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                          {\u0027destination\u0027: DEST1, \u0027nexthop\u0027: NEXTHOP},"},{"line_number":156,"context_line":"                          {\u0027destination\u0027: DEST2, \u0027nexthop\u0027: NEXTHOP}"},{"line_number":157,"context_line":"                      ]}]"},{"line_number":158,"context_line":"        format_text \u003d ("},{"line_number":159,"context_line":"            \u0027\\n\\n# Generated by Octavia agent\\n\u0027"},{"line_number":160,"context_line":"            \u0027auto {netns_interface}\\n\u0027"},{"line_number":161,"context_line":"            \u0027iface {netns_interface} inet static\\n\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_1c20479b","line":158,"updated":"2016-10-11 07:59:17.000000000","message":"Thank you, this looks so much better.","commit_id":"89f6b2ccefa67d6a5b2d1c518d2361580f83fcc1"}]}