)]}'
{"octavia/tests/tempest/config.py":[{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"a2b8d8d639ac3e86931b468e41d28b39ffd9dc54","unresolved":false,"context_lines":[{"line_number":32,"context_line":"               default\u003d\u0027network\u0027,"},{"line_number":33,"context_line":"               help\u003d\u0027Catalog type of the Octavia service.\u0027),"},{"line_number":34,"context_line":"    cfg.IntOpt(\u0027build_interval\u0027,"},{"line_number":35,"context_line":"               default\u003d5,"},{"line_number":36,"context_line":"               help\u003d\u0027Time in seconds between build status checks for \u0027"},{"line_number":37,"context_line":"                    \u0027non-load-balancer resources to build\u0027),"},{"line_number":38,"context_line":"    cfg.IntOpt(\u0027build_timeout\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_e1ee55b3","line":35,"range":{"start_line":35,"start_character":23,"end_line":35,"end_character":24},"updated":"2016-10-05 21:07:23.000000000","message":"The previous code has this set to 1. I don\u0027t see why we wouldn\u0027t make that the case here as well, eh.","commit_id":"eac6aeb4be9b11eff86b75220891a307cd621bf2"},{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"78014a370ae8fdd74ee9e370ba8596bde63885fc","unresolved":false,"context_lines":[{"line_number":32,"context_line":"               default\u003d\u0027network\u0027,"},{"line_number":33,"context_line":"               help\u003d\u0027Catalog type of the Octavia service.\u0027),"},{"line_number":34,"context_line":"    cfg.IntOpt(\u0027build_interval\u0027,"},{"line_number":35,"context_line":"               default\u003d5,"},{"line_number":36,"context_line":"               help\u003d\u0027Time in seconds between build status checks for \u0027"},{"line_number":37,"context_line":"                    \u0027non-load-balancer resources to build\u0027),"},{"line_number":38,"context_line":"    cfg.IntOpt(\u0027build_timeout\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_92277c63","line":35,"range":{"start_line":35,"start_character":23,"end_line":35,"end_character":24},"in_reply_to":"1a95cdbc_e1ee55b3","updated":"2016-10-06 14:54:22.000000000","message":"I turned it up to reduce clutter in the logs. Same with the lb_build_interval.","commit_id":"eac6aeb4be9b11eff86b75220891a307cd621bf2"}],"octavia/tests/tempest/v1/scenario/base.py":[{"author":{"_account_id":7812,"name":"Franklin Naval","email":"franklin.naval@gmail.com","username":"fnaval"},"change_message_id":"a038e6e9d28dc943ba908edcac960e541c20aea0","unresolved":false,"context_lines":[{"line_number":629,"context_line":"            # of success and continue connection tries"},{"line_number":630,"context_line":"            except (error.HTTPError, error.URLError, socket.timeout) as e:"},{"line_number":631,"context_line":"                LOG.info((\u0027Got Error in sending request: {0}\u0027.format(e)))"},{"line_number":632,"context_line":"                continue"},{"line_number":633,"context_line":"        # Check that we had at least sent more than 1 request"},{"line_number":634,"context_line":"        counted \u003d 0"},{"line_number":635,"context_line":"        for server, counter in counters.items():"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_ac7d0fe9","side":"PARENT","line":632,"updated":"2016-09-29 21:27:05.000000000","message":"reason for removing this?  I\u0027d think that we should check that at least more than one request was sent.","commit_id":"70f009ee71821541fa99a31358981858afae502a"},{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"8b2a307f31cf43109cc3efec1db09e403166f257","unresolved":false,"context_lines":[{"line_number":629,"context_line":"            # of success and continue connection tries"},{"line_number":630,"context_line":"            except (error.HTTPError, error.URLError, socket.timeout) as e:"},{"line_number":631,"context_line":"                LOG.info((\u0027Got Error in sending request: {0}\u0027.format(e)))"},{"line_number":632,"context_line":"                continue"},{"line_number":633,"context_line":"        # Check that we had at least sent more than 1 request"},{"line_number":634,"context_line":"        counted \u003d 0"},{"line_number":635,"context_line":"        for server, counter in counters.items():"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_72e4bc3a","side":"PARENT","line":632,"in_reply_to":"3a98d1f4_ac7d0fe9","updated":"2016-09-30 15:10:25.000000000","message":"The test uses this method to check that no requests are sent successfully after a listener is removed from the load balancer, so this assertion was failing (see the _check_load_balancing_after_deleting_resources method).\n\nAll other callers of this method run their own asserts anyway.","commit_id":"70f009ee71821541fa99a31358981858afae502a"}],"octavia/tests/tempest/v1/scenario/test_listener_basic.py":[{"author":{"_account_id":7812,"name":"Franklin Naval","email":"franklin.naval@gmail.com","username":"fnaval"},"change_message_id":"a038e6e9d28dc943ba908edcac960e541c20aea0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_0c6fe32b","line":1,"updated":"2016-09-29 21:27:05.000000000","message":"add company copyright","commit_id":"ff4c1bca5bc14278f159f2764b34e8ebf520cdfb"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"a2b8d8d639ac3e86931b468e41d28b39ffd9dc54","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def test_listener_basic(self):"},{"line_number":42,"context_line":"        self._create_server(\u0027server1\u0027)"},{"line_number":43,"context_line":"        self._start_servers()"},{"line_number":44,"context_line":"        self._create_load_balancer()"},{"line_number":45,"context_line":"        self._check_load_balancing()"},{"line_number":46,"context_line":"        self._delete_listener()"},{"line_number":47,"context_line":"        self._check_load_balancing_after_deleting_resources()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_21f2fd6f","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":36},"updated":"2016-10-05 21:07:23.000000000","message":"So I realize there\u0027s already a scenario test that does this, and it creates a whole bunch of resources other than just a load balancer. Well, first off-- that test is not significantly different from this one. Further, I would really like to see this _create_load_balancer method split up into more granular methods like _create_listener _create_pool _create_member, all of which might take various options for their specific configuration.\n\nIf we want to get rid of of that test_load_balancer_basic test as part of this patch set, or change it to *only* launch a load balancer (and check that it\u0027s there using ping or something), that would be fine by me. As it is, that test isn\u0027t doing anything significantly different from this one, so it should either be simplified or removed, eh.","commit_id":"eac6aeb4be9b11eff86b75220891a307cd621bf2"},{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"78014a370ae8fdd74ee9e370ba8596bde63885fc","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def test_listener_basic(self):"},{"line_number":42,"context_line":"        self._create_server(\u0027server1\u0027)"},{"line_number":43,"context_line":"        self._start_servers()"},{"line_number":44,"context_line":"        self._create_load_balancer()"},{"line_number":45,"context_line":"        self._check_load_balancing()"},{"line_number":46,"context_line":"        self._delete_listener()"},{"line_number":47,"context_line":"        self._check_load_balancing_after_deleting_resources()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_f2cd205e","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":36},"in_reply_to":"1a95cdbc_21f2fd6f","updated":"2016-10-06 14:54:22.000000000","message":"I\u0027m not going to have time to work on this (other priorities at work), so I won\u0027t be doing that refactoring here and now.\n\nI agree about the redundancy of this and the basic loadbalancer test. I\u0027ll remove the other test.","commit_id":"eac6aeb4be9b11eff86b75220891a307cd621bf2"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"1bbd4a955aee1c67f99c99e6c3943c1c8dbd014f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def test_listener_basic(self):"},{"line_number":42,"context_line":"        self._create_server(\u0027server1\u0027)"},{"line_number":43,"context_line":"        self._start_servers()"},{"line_number":44,"context_line":"        self._create_load_balancer()"},{"line_number":45,"context_line":"        self._check_load_balancing()"},{"line_number":46,"context_line":"        self._delete_listener()"},{"line_number":47,"context_line":"        self._check_load_balancing_after_deleting_resources()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_77ce55b5","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":36},"in_reply_to":"1a95cdbc_f2cd205e","updated":"2016-10-06 18:29:16.000000000","message":"Ok. I don\u0027t think it\u0027s particularly urgent to merge this patch, so, I\u0027mma -1 this until the refactor happens. (It honestly shouldn\u0027t be that hard to do.)","commit_id":"eac6aeb4be9b11eff86b75220891a307cd621bf2"}]}