)]}'
{"octavia/tests/tempest/v1/scenario/base.py":[{"author":{"_account_id":11302,"name":"Phillip Toohill","email":"phillip.toohill@rackspace.com","username":"ptoohill1"},"change_message_id":"b3043816a10a4ca621f757f780a3b80dde987abf","unresolved":false,"context_lines":[{"line_number":301,"context_line":"            timeout\u003d5 * 1000,"},{"line_number":302,"context_line":"            fall_threshold\u003d5,"},{"line_number":303,"context_line":"            rise_threshold\u003d5,"},{"line_number":304,"context_line":"            # these optional fields default to null - see bug:"},{"line_number":305,"context_line":"            # https://bugs.launchpad.net/octavia/+bug/1630287"},{"line_number":306,"context_line":"            http_method\u003d\u0027GET\u0027,"},{"line_number":307,"context_line":"            url_path\u003d\u0027/\u0027,"},{"line_number":308,"context_line":"            expected_codes\u003d\u0027200\u0027,"},{"line_number":309,"context_line":"            lb_id\u003dself.load_balancer[\u0027id\u0027],"},{"line_number":310,"context_line":"            pool_id\u003dself.pool[\u0027id\u0027],"},{"line_number":311,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_5649c88a","line":308,"range":{"start_line":304,"start_character":12,"end_line":308,"end_character":33},"updated":"2016-10-04 19:44:36.000000000","message":"Please remove and make this patch dependent on: https://review.openstack.org/#/c/381993/.\n\n A more generic review that doesn\u0027t have to apply immediately is that we should certainly expand on these base methods to be more configurable and useful for the tests. We initially discussed having base functionality available and it kind of turned in to a beast class containing everything and its not too configurable which makes it difficult to reuse and test different cases. So, this is an entirely different thought process from this specific review goal, but, it is certainly something to keep in mind going forward to make it easier on ourselves.","commit_id":"0edf01861343ce591869d7a36c660559ef52a9d1"}]}