)]}'
{"etc/octavia.conf":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3e15eb87b48ad57c7ddbf5e2ab3aef48dbb9ed2b","unresolved":false,"context_lines":[{"line_number":119,"context_line":"# REST Driver specific"},{"line_number":120,"context_line":"# bind_host \u003d 0.0.0.0"},{"line_number":121,"context_line":"# bind_port \u003d 9443"},{"line_number":122,"context_line":"# lb_network_interface \u003d o-hm0"},{"line_number":123,"context_line":"# haproxy_cmd \u003d /usr/sbin/haproxy"},{"line_number":124,"context_line":"# respawn_count \u003d 2"},{"line_number":125,"context_line":"# respawn_interval \u003d 2"}],"source_content_type":"text/plain","patch_set":3,"id":"7a77a97e_47569806","line":122,"range":{"start_line":122,"start_character":0,"end_line":122,"end_character":30},"updated":"2016-11-18 22:53:47.000000000","message":"I would be nice to have a comment here about this being optional and only needed for link local addresses like we have in the config.py.  I don\u0027t want people to be too wound up about this default.","commit_id":"49bdbf1639872e56c70ccc508d8c4042cd5348e2"},{"author":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"change_message_id":"3e4ff53ac958400788202dc6299e5c4ded96a3c2","unresolved":false,"context_lines":[{"line_number":119,"context_line":"# REST Driver specific"},{"line_number":120,"context_line":"# bind_host \u003d 0.0.0.0"},{"line_number":121,"context_line":"# bind_port \u003d 9443"},{"line_number":122,"context_line":"# lb_network_interface \u003d o-hm0"},{"line_number":123,"context_line":"# haproxy_cmd \u003d /usr/sbin/haproxy"},{"line_number":124,"context_line":"# respawn_count \u003d 2"},{"line_number":125,"context_line":"# respawn_interval \u003d 2"}],"source_content_type":"text/plain","patch_set":3,"id":"5a74a57a_672d0ca7","line":122,"range":{"start_line":122,"start_character":0,"end_line":122,"end_character":30},"in_reply_to":"7a77a97e_47569806","updated":"2016-11-23 19:58:27.000000000","message":"done","commit_id":"49bdbf1639872e56c70ccc508d8c4042cd5348e2"}],"octavia/amphorae/drivers/haproxy/rest_api_driver.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3e15eb87b48ad57c7ddbf5e2ab3aef48dbb9ed2b","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            ip \u003d \u0027{ip}%{interface}\u0027.format("},{"line_number":244,"context_line":"                ip\u003dip,"},{"line_number":245,"context_line":"                interface\u003dCONF.haproxy_amphora.lb_network_interface)"},{"line_number":246,"context_line":"        return \"https://[{ip}]:{port}/{version}/\".format("},{"line_number":247,"context_line":"            ip\u003dip,"},{"line_number":248,"context_line":"            port\u003dCONF.haproxy_amphora.bind_port,"},{"line_number":249,"context_line":"            version\u003dAPI_VERSION)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_8716f049","line":246,"range":{"start_line":246,"start_character":24,"end_line":246,"end_character":30},"updated":"2016-11-18 22:53:47.000000000","message":"This is wrong.  Per RFC 3986, section 3.2.2 only ipv6 or future address formats can be in square brackets.  Putting an ipv4 address in brackets is invalid and fails in many cases (chrome, etc.).","commit_id":"49bdbf1639872e56c70ccc508d8c4042cd5348e2"},{"author":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"change_message_id":"3e4ff53ac958400788202dc6299e5c4ded96a3c2","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            ip \u003d \u0027{ip}%{interface}\u0027.format("},{"line_number":244,"context_line":"                ip\u003dip,"},{"line_number":245,"context_line":"                interface\u003dCONF.haproxy_amphora.lb_network_interface)"},{"line_number":246,"context_line":"        return \"https://[{ip}]:{port}/{version}/\".format("},{"line_number":247,"context_line":"            ip\u003dip,"},{"line_number":248,"context_line":"            port\u003dCONF.haproxy_amphora.bind_port,"},{"line_number":249,"context_line":"            version\u003dAPI_VERSION)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_4707301c","line":246,"range":{"start_line":246,"start_character":24,"end_line":246,"end_character":30},"in_reply_to":"7a77a97e_8716f049","updated":"2016-11-23 19:58:27.000000000","message":"Thanks for pointing this out, fixed.","commit_id":"49bdbf1639872e56c70ccc508d8c4042cd5348e2"}]}