)]}'
{"specs/version1.0/flavors.rst":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c1f362956ae6792b143f1e1b987ca7c4bdb435d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7a77a97e_4041ff38","updated":"2016-11-17 19:48:37.000000000","message":"We need to update the index so the docs page has a link to this.","commit_id":"c3c9cb41f34ee585560c08b6a155c2488c01e499"},{"author":{"_account_id":25279,"name":"Matt Greene","email":"m.greene@f5.com"},"change_message_id":"1b58748e24b438e68bf5a791a86a2e5ae314364c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"(such as HA, throughput or ddos protection)"},{"line_number":19,"context_line":"gives users a way to better plan their LB services and get a benefit"},{"line_number":20,"context_line":"of LBaaS functions which are not a part of Octavia API yet."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Since Octavia will become a new OpenStack LBaaS API,"},{"line_number":23,"context_line":"a new flavors API should be developed inside Octavia."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_8c88f0c6","line":21,"updated":"2017-02-23 22:54:45.000000000","message":"Recommend making a flavor and standalone, opaque object that could eventually be attached to a pool in addition to loadbalancer.  I think most vendors conceptually break a loadbalancer into client-side and server-side.","commit_id":"c3c9cb41f34ee585560c08b6a155c2488c01e499"},{"author":{"_account_id":25279,"name":"Matt Greene","email":"m.greene@f5.com"},"change_message_id":"1b58748e24b438e68bf5a791a86a2e5ae314364c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"support to Octavia."},{"line_number":30,"context_line":"Service providers will probably be configured via Octavia configuration file."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"However, eventually, loadbalancer flavor selection will replace"},{"line_number":33,"context_line":"provider selection. Definition of provider profiles for flavors"},{"line_number":34,"context_line":"will use service providers for provider profile driver validation."},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_3df1f501","line":32,"updated":"2017-02-23 22:54:45.000000000","message":"This provides two different ways to select the provider, and associated code to resolve conflicting selections. Recommend not allowing provider selection in the flavor (for now) and requiring use of the command-line option.","commit_id":"c3c9cb41f34ee585560c08b6a155c2488c01e499"},{"author":{"_account_id":25279,"name":"Matt Greene","email":"m.greene@f5.com"},"change_message_id":"1b58748e24b438e68bf5a791a86a2e5ae314364c","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  This is for both cases, when loadbalancer was created before"},{"line_number":72,"context_line":"  multi providers support and when loadbalancer was created with"},{"line_number":73,"context_line":"  certain provider."},{"line_number":74,"context_line":"* Adding default entries to DB tables representing the default Octavia"},{"line_number":75,"context_line":"  flavor and default Octavia provider profile."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_dd729910","line":74,"updated":"2017-02-23 22:54:45.000000000","message":"The default flavor model should not force any requirements on a vendor plugin to implement keys or meta-data that are not relevant.  Perhaps the default dictionary is empty?","commit_id":"c3c9cb41f34ee585560c08b6a155c2488c01e499"},{"author":{"_account_id":25279,"name":"Matt Greene","email":"m.greene@f5.com"},"change_message_id":"1b58748e24b438e68bf5a791a86a2e5ae314364c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  multi providers support and when loadbalancer was created with"},{"line_number":73,"context_line":"  certain provider."},{"line_number":74,"context_line":"* Adding default entries to DB tables representing the default Octavia"},{"line_number":75,"context_line":"  flavor and default Octavia provider profile."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_5d014969","line":75,"updated":"2017-02-23 22:54:45.000000000","message":"This section captures collecting operator config and storing it in the internal octavia DB.  This spec should be clear if it intends to solve the \u0027consumption\u0027 side.  For instance, the JSON given from API server to handler on the back-end will contain a flavor key with the contents of the flavor definition.","commit_id":"c3c9cb41f34ee585560c08b6a155c2488c01e499"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c1f362956ae6792b143f1e1b987ca7c4bdb435d2","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  certain provider."},{"line_number":74,"context_line":"* Adding default entries to DB tables representing the default Octavia"},{"line_number":75,"context_line":"  flavor and default Octavia provider profile."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Alternatives"},{"line_number":79,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a77a97e_366749ea","line":76,"updated":"2016-11-17 19:48:37.000000000","message":"The devstack plugin will need to be updated to have a \"default\" flavor.","commit_id":"c3c9cb41f34ee585560c08b6a155c2488c01e499"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"e7c96d249cacdd449161e796cf32b8dab86fad5c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"------------"},{"line_number":80,"context_line":"First alternative is not adding LBaaS flavoring capability to Octavia."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Second alternative is to complete neutron\u0027s flavors API implementation from"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"http://specs.openstack.org/openstack/neutron-specs/specs/mitaka/neutron-flavor-framework-templates.html"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"and use it for LBaaS flavoring, only in case when Octavia will not become"},{"line_number":87,"context_line":"OpenStack LBaaS front-end API."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Data model impact"},{"line_number":90,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a71b18c_1049078f","line":87,"range":{"start_line":82,"start_character":0,"end_line":87,"end_character":30},"updated":"2016-12-07 20:29:48.000000000","message":"Octavia is the OpenStack load balancer so it must be removed.","commit_id":"c3c9cb41f34ee585560c08b6a155c2488c01e499"},{"author":{"_account_id":25279,"name":"Matt Greene","email":"m.greene@f5.com"},"change_message_id":"1b58748e24b438e68bf5a791a86a2e5ae314364c","unresolved":false,"context_lines":[{"line_number":89,"context_line":"Data model impact"},{"line_number":90,"context_line":"-----------------"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"DB table \u0027flavors\u0027 introduced to represent flavors:"},{"line_number":93,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_ac4774ba","line":92,"updated":"2017-02-23 22:54:45.000000000","message":"Should all new tables contain a tenant_id key to filter/isolate access to users within the tenant?","commit_id":"c3c9cb41f34ee585560c08b6a155c2488c01e499"},{"author":{"_account_id":22736,"name":"Sanaz Zakeri","email":"s.zakeri@f5.com","username":"szakeri"},"change_message_id":"93e6ffebce2fbac95fd11335fc08671f3d555cdb","unresolved":false,"context_lines":[{"line_number":93,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"},{"line_number":96,"context_line":"    | Field              | Type        | Null | Key | Default  | Extra |"},{"line_number":97,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"},{"line_number":98,"context_line":"    | id                 | string(32)  | NO   | PRI | generated|       |"},{"line_number":99,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a6eadb0_dc933c4e","line":96,"updated":"2016-12-12 17:27:19.000000000","message":"There are some flavor attributes that are listed in the documentation but are not listed here such as \"Extension list\", \"Service\" and \"Service profile\". Are these attributes not going to be implemented in Flavor Framework?","commit_id":"c3c9cb41f34ee585560c08b6a155c2488c01e499"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c1f362956ae6792b143f1e1b987ca7c4bdb435d2","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"},{"line_number":96,"context_line":"    | Field              | Type        | Null | Key | Default  | Extra |"},{"line_number":97,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"},{"line_number":98,"context_line":"    | id                 | string(32)  | NO   | PRI | generated|       |"},{"line_number":99,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"},{"line_number":100,"context_line":"    | name               | string(255) | YES  |     | NULL     |       |"},{"line_number":101,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a77a97e_5b9150f0","line":98,"range":{"start_line":98,"start_character":27,"end_line":98,"end_character":37},"updated":"2016-11-17 19:48:37.000000000","message":"Our id columns are 36 long","commit_id":"c3c9cb41f34ee585560c08b6a155c2488c01e499"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"e7c96d249cacdd449161e796cf32b8dab86fad5c","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"},{"line_number":111,"context_line":"    | Field              | Type        | Null | Key | Default  | Extra |"},{"line_number":112,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"},{"line_number":113,"context_line":"    | id                 | string(32)  | NO   | PRI | generated|       |"},{"line_number":114,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"},{"line_number":115,"context_line":"    | name               | string(255) | YES  |     | NULL     |       |"},{"line_number":116,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a71b18c_c3e6eb43","line":113,"updated":"2016-12-07 20:29:48.000000000","message":"36","commit_id":"c3c9cb41f34ee585560c08b6a155c2488c01e499"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c1f362956ae6792b143f1e1b987ca7c4bdb435d2","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"},{"line_number":121,"context_line":"    | driver             | string(255) | NO   |     |          |       |"},{"line_number":122,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"},{"line_number":123,"context_line":"    | metainfo           | string(1023)| YES  |     | {}       |       |"},{"line_number":124,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"DB table \u0027flavorproviderprofilebinding\u0027 introduced to represent binding:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a77a97e_fb469c79","line":123,"range":{"start_line":123,"start_character":27,"end_line":123,"end_character":39},"updated":"2016-11-17 19:48:37.000000000","message":"This is larger in neutron.  Maybe 4096?","commit_id":"c3c9cb41f34ee585560c08b6a155c2488c01e499"},{"author":{"_account_id":13438,"name":"Kobi Samoray","email":"kobi.samoray@broadcom.com","username":"ksamoray"},"change_message_id":"f6c595bc0022a5c22473d449974ad5d9be0591c4","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"},{"line_number":121,"context_line":"    | driver             | string(255) | NO   |     |          |       |"},{"line_number":122,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"},{"line_number":123,"context_line":"    | metainfo           | string(1023)| YES  |     | {}       |       |"},{"line_number":124,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"DB table \u0027flavorproviderprofilebinding\u0027 introduced to represent binding:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a71b18c_5b3ac5ce","line":123,"range":{"start_line":123,"start_character":27,"end_line":123,"end_character":39},"in_reply_to":"7a77a97e_fb469c79","updated":"2016-12-01 14:35:45.000000000","message":"Maybe it\u0027s better to split metainfo into a separate attribute table. So a flavor can have memory attribute, CPU attribute, HW acceleration etc, without having to parse an ugly metainfo field","commit_id":"c3c9cb41f34ee585560c08b6a155c2488c01e499"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"e7c96d249cacdd449161e796cf32b8dab86fad5c","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"},{"line_number":130,"context_line":"    | Field              | Type        | Null | Key | Default  | Extra |"},{"line_number":131,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"},{"line_number":132,"context_line":"    | flavor_id          | string(32)  | NO   | PRI |          |       |"},{"line_number":133,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"},{"line_number":134,"context_line":"    | profile_id         | string(32)  | NO   |     |          |       |"},{"line_number":135,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a71b18c_43c9fbab","line":132,"range":{"start_line":132,"start_character":34,"end_line":132,"end_character":36},"updated":"2016-12-07 20:29:48.000000000","message":"36","commit_id":"c3c9cb41f34ee585560c08b6a155c2488c01e499"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"e7c96d249cacdd449161e796cf32b8dab86fad5c","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"},{"line_number":132,"context_line":"    | flavor_id          | string(32)  | NO   | PRI |          |       |"},{"line_number":133,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"},{"line_number":134,"context_line":"    | profile_id         | string(32)  | NO   |     |          |       |"},{"line_number":135,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a71b18c_a3c00f7e","line":134,"range":{"start_line":134,"start_character":34,"end_line":134,"end_character":36},"updated":"2016-12-07 20:29:48.000000000","message":"36","commit_id":"c3c9cb41f34ee585560c08b6a155c2488c01e499"},{"author":{"_account_id":25279,"name":"Matt Greene","email":"m.greene@f5.com"},"change_message_id":"1b58748e24b438e68bf5a791a86a2e5ae314364c","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"},{"line_number":134,"context_line":"    | profile_id         | string(32)  | NO   |     |          |       |"},{"line_number":135,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"REST API impact"},{"line_number":139,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_1dc351ee","line":136,"updated":"2017-02-23 22:54:45.000000000","message":"Add a section to capture how a flavor is attached to a loadbalancer.  For instance, a new row in the loadbalancer table with a foreign key to flavor.","commit_id":"c3c9cb41f34ee585560c08b6a155c2488c01e499"},{"author":{"_account_id":25279,"name":"Matt Greene","email":"m.greene@f5.com"},"change_message_id":"1b58748e24b438e68bf5a791a86a2e5ae314364c","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    | profile_id         | string(32)  | NO   |     |          |       |"},{"line_number":135,"context_line":"    +--------------------+-------------+------+-----+----------+-------+"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"REST API impact"},{"line_number":139,"context_line":"---------------"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_0ce400df","line":137,"updated":"2017-02-23 22:54:45.000000000","message":"I understand the model as presented for combining flavors with providerprofiles.  Suggest re-visiting this model to consider simplifying it down to just a flavor table with all necessary information (metadata, etc.) and attaching the flavor to a loadbalancer.","commit_id":"c3c9cb41f34ee585560c08b6a155c2488c01e499"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"e7c96d249cacdd449161e796cf32b8dab86fad5c","unresolved":false,"context_lines":[{"line_number":177,"context_line":"|enabled          |bool   |RO, all  |true     |bool        |toggle        |"},{"line_number":178,"context_line":"|                 |       |RW, admin|         |            |              |"},{"line_number":179,"context_line":"+-----------------+-------+---------+---------+------------+--------------+"},{"line_number":180,"context_line":"|driver           |string |RO, all  |\u0027\u0027       |string      |python module |"},{"line_number":181,"context_line":"|                 |       |RW, admin|         |            |path to driver|"},{"line_number":182,"context_line":"+-----------------+-------+---------+---------+------------+--------------+"},{"line_number":183,"context_line":"|metainfo         |string |RO, all  |{}       |json string |meta data     |"},{"line_number":184,"context_line":"|                 |       |RW, admin|         |            |              |"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a71b18c_83123357","line":181,"range":{"start_line":180,"start_character":1,"end_line":181,"end_character":74},"updated":"2016-12-07 20:29:48.000000000","message":"So what about that? In Octavia we support multiple drivers so how about enabling overriding all of them?","commit_id":"c3c9cb41f34ee585560c08b6a155c2488c01e499"},{"author":{"_account_id":25279,"name":"Matt Greene","email":"m.greene@f5.com"},"change_message_id":"1b58748e24b438e68bf5a791a86a2e5ae314364c","unresolved":false,"context_lines":[{"line_number":202,"context_line":"will be retained for operators that wish to track"},{"line_number":203,"context_line":"the user\u0027s flavor and backend."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Other end user impact"},{"line_number":206,"context_line":"---------------------"},{"line_number":207,"context_line":"None"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_6cdd7cdf","line":205,"updated":"2017-02-23 22:54:45.000000000","message":"Is it necessary to document migration/update behavior?  Is it legal to create a LB with no flavor, then update the LB to add a flavor?  Or a flavor must be specified only during create.  If the former, what impact does that have on already provisioned LBs?","commit_id":"c3c9cb41f34ee585560c08b6a155c2488c01e499"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"77e068bd27911ccab9a9738e7e11f856b3cb75c9","unresolved":false,"context_lines":[{"line_number":116,"context_line":"Data model impact"},{"line_number":117,"context_line":"-----------------"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"DB table \u0027provider\u0027 introduced to represent providers."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":122,"context_line":"    | Field              | Type         | Null | Key | Default  |"},{"line_number":123,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":124,"context_line":"    | id                 | varchar(36)  | NO   | PK  | generated|"},{"line_number":125,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":126,"context_line":"    | name               | varchar(255) | NO   |     |          |"},{"line_number":127,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":128,"context_line":"    | description        | varchar(255) | YES  |     | NULL     |"},{"line_number":129,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":130,"context_line":"    | driver             | varchar(255) | NO   | UK  |          |"},{"line_number":131,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":132,"context_line":"    | enabled            | tinyint(1)   | NO   |     | True     |"},{"line_number":133,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"DB table \u0027flavor_profile\u0027 introduced to represent the profile that is"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff346bd7_62bc54dc","line":133,"range":{"start_line":119,"start_character":0,"end_line":133,"end_character":65},"updated":"2017-07-24 16:20:25.000000000","message":"It\u0027s not clear to me that we need to actually store this.  Other than description, we can get all of this from the driver itself and the octavia.conf configuration for enabled providers.\nSee the discussion here: https://review.openstack.org/#/c/484325/","commit_id":"0264ae40a9e4364330792922872b0cbfd19e2c6e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"77e068bd27911ccab9a9738e7e11f856b3cb75c9","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    +--------------------+--------------+------+---------+----------+"},{"line_number":144,"context_line":"    | flavor_id          | varchar(36)  | NO   | FK1,UK1 |          |"},{"line_number":145,"context_line":"    +--------------------+--------------+------+---------+----------+"},{"line_number":146,"context_line":"    | provider_id        | varchar(36)  | NO   | FK2,UK1 |          |"},{"line_number":147,"context_line":"    +--------------------+--------------+------+---------+----------+"},{"line_number":148,"context_line":"    | metadata           | varchar(4096)| NO   |         |          |"},{"line_number":149,"context_line":"    +--------------------+--------------+------+---------+----------+"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff346bd7_02bb48e2","line":146,"range":{"start_line":146,"start_character":6,"end_line":146,"end_character":17},"updated":"2017-07-24 16:20:25.000000000","message":"This could be just provider_name if we go without a DB table for providers.","commit_id":"0264ae40a9e4364330792922872b0cbfd19e2c6e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"77e068bd27911ccab9a9738e7e11f856b3cb75c9","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    +--------------------+--------------+------+---------+----------+"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"DB table \u0027flavor\u0027 introduced to represent flavors.  The attribute"},{"line_number":153,"context_line":"lb_topology_name is added to this table given that a lb topology could"},{"line_number":154,"context_line":"apply to any flavor and/or provider.  It is a foreign key to the"},{"line_number":155,"context_line":"lb_topology table."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":158,"context_line":"    | Field              | Type         | Null | Key | Default  |"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff346bd7_4294b037","line":155,"range":{"start_line":152,"start_character":52,"end_line":155,"end_character":18},"updated":"2017-07-24 16:20:25.000000000","message":"Should this be removed?  I don\u0027t see the column below.\nI think we can just include topology in the metadata personally.","commit_id":"0264ae40a9e4364330792922872b0cbfd19e2c6e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"77e068bd27911ccab9a9738e7e11f856b3cb75c9","unresolved":false,"context_lines":[{"line_number":180,"context_line":"REST API impact"},{"line_number":181,"context_line":"---------------"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"PROVIDER(/provider)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"+--------------+--------+---------+---------+------------+-----------------+"},{"line_number":186,"context_line":"|Attribute     |Type    |Access   |Default  |Validation/ |Description      |"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff346bd7_c2c8a056","line":183,"range":{"start_line":183,"start_character":0,"end_line":183,"end_character":19},"updated":"2017-07-24 16:20:25.000000000","message":"See above, I think this can just be handled by:\n1. Is the driver installed?\n2. Is the provider listed as enabled in the config file.","commit_id":"0264ae40a9e4364330792922872b0cbfd19e2c6e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"77e068bd27911ccab9a9738e7e11f856b3cb75c9","unresolved":false,"context_lines":[{"line_number":202,"context_line":"|              |        |RW, admin|         |            |                 |"},{"line_number":203,"context_line":"+--------------+--------+---------+---------+------------+-----------------+"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"FLAVOR(/flavor)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"+-----------------+-------+---------+---------+------------+---------------+"},{"line_number":208,"context_line":"|Attribute        |Type   |Access   |Default  |Validation/ |Description    |"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff346bd7_021348b7","line":205,"range":{"start_line":205,"start_character":7,"end_line":205,"end_character":14},"updated":"2017-07-24 16:20:25.000000000","message":"Our existing URLs are mostly plural, so this should be /flavors\nSee: https://developer.openstack.org/api-ref/load-balancer/v2/index.html#load-balancers","commit_id":"0264ae40a9e4364330792922872b0cbfd19e2c6e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"77e068bd27911ccab9a9738e7e11f856b3cb75c9","unresolved":false,"context_lines":[{"line_number":208,"context_line":"|Attribute        |Type   |Access   |Default  |Validation/ |Description    |"},{"line_number":209,"context_line":"|Name             |       |         |Value    |Conversion  |               |"},{"line_number":210,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+"},{"line_number":211,"context_line":"|id               |string |RO, all  |generated|N/A         |identity       |"},{"line_number":212,"context_line":"|                 |(UUID) |RW, admin|         |            |               |"},{"line_number":213,"context_line":"+-----------------+-------+---------+---------+------------+---------------+"},{"line_number":214,"context_line":"|name             |string |RO, all  |\u0027\u0027       |string      |human-readable |"},{"line_number":215,"context_line":"|                 |       |RW, admin|         |            |name           |"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff346bd7_e2f96480","line":212,"range":{"start_line":211,"start_character":31,"end_line":212,"end_character":29},"updated":"2017-07-24 16:20:25.000000000","message":"ID should be RO as it is generated by the system","commit_id":"0264ae40a9e4364330792922872b0cbfd19e2c6e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"77e068bd27911ccab9a9738e7e11f856b3cb75c9","unresolved":false,"context_lines":[{"line_number":211,"context_line":"|id               |string |RO, all  |generated|N/A         |identity       |"},{"line_number":212,"context_line":"|                 |(UUID) |RW, admin|         |            |               |"},{"line_number":213,"context_line":"+-----------------+-------+---------+---------+------------+---------------+"},{"line_number":214,"context_line":"|name             |string |RO, all  |\u0027\u0027       |string      |human-readable |"},{"line_number":215,"context_line":"|                 |       |RW, admin|         |            |name           |"},{"line_number":216,"context_line":"+-----------------+-------+---------+---------+------------+---------------+"},{"line_number":217,"context_line":"|description      |string |RO, all  |\u0027\u0027       |string      |human-readable |"},{"line_number":218,"context_line":"|                 |       |RW, admin|         |            |description    |"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff346bd7_e23e0428","line":215,"range":{"start_line":214,"start_character":31,"end_line":215,"end_character":30},"updated":"2017-07-24 16:20:25.000000000","message":"I don\u0027t think we should have this RW open to everyone, just ADMINs right?","commit_id":"0264ae40a9e4364330792922872b0cbfd19e2c6e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"77e068bd27911ccab9a9738e7e11f856b3cb75c9","unresolved":false,"context_lines":[{"line_number":221,"context_line":"|                 |       |RW, admin|         |            |               |"},{"line_number":222,"context_line":"+-----------------+-------+---------+---------+------------+---------------+"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"FLAVOR PROFILE(/flavorprofile)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"+-----------------+--------+---------+---------+------------+---------------+"},{"line_number":227,"context_line":"|Attribute        |Type    |Access   |Default  |Validation/ |Description    |"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff346bd7_6279f4fa","line":224,"range":{"start_line":224,"start_character":15,"end_line":224,"end_character":29},"updated":"2017-07-24 16:20:25.000000000","message":"Same, /flavorprofiles","commit_id":"0264ae40a9e4364330792922872b0cbfd19e2c6e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"77e068bd27911ccab9a9738e7e11f856b3cb75c9","unresolved":false,"context_lines":[{"line_number":233,"context_line":"|name             |string  |RO, all  |\u0027\u0027       |string      |human-readable |"},{"line_number":234,"context_line":"|                 |        |RW, admin|         |            |name           |"},{"line_number":235,"context_line":"+-----------------+--------+---------+---------+------------+---------------+"},{"line_number":236,"context_line":"|flavor-id        |string  |RO, all  |\u0027\u0027       |string      |human-readable |"},{"line_number":237,"context_line":"|                 |        |RW, admin|         |            |flavor-id      |"},{"line_number":238,"context_line":"+-----------------+--------+---------+---------+------------+---------------+"},{"line_number":239,"context_line":"|provider-id      |string  |RO, all  |\u0027\u0027       |string      |human-readable |"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff346bd7_e2da84e7","line":236,"range":{"start_line":236,"start_character":1,"end_line":236,"end_character":12},"updated":"2017-07-24 16:20:25.000000000","message":"This seems odd to me.  Shouldn\u0027t flavor have a pointer to the profile?  It seems like you would create one or more profiles and them map flavors to those profiles.\nCould there be a migration reason to have more than one \"flavor\" point to the same profile?","commit_id":"0264ae40a9e4364330792922872b0cbfd19e2c6e"},{"author":{"_account_id":20279,"name":"Jason Niesz","email":"Jason.Niesz@walmart.com","username":"jniesz"},"change_message_id":"d162c0dfbe64770adc84fea3c3e911e3c38c362c","unresolved":false,"context_lines":[{"line_number":233,"context_line":"|name             |string  |RO, all  |\u0027\u0027       |string      |human-readable |"},{"line_number":234,"context_line":"|                 |        |RW, admin|         |            |name           |"},{"line_number":235,"context_line":"+-----------------+--------+---------+---------+------------+---------------+"},{"line_number":236,"context_line":"|flavor-id        |string  |RO, all  |\u0027\u0027       |string      |human-readable |"},{"line_number":237,"context_line":"|                 |        |RW, admin|         |            |flavor-id      |"},{"line_number":238,"context_line":"+-----------------+--------+---------+---------+------------+---------------+"},{"line_number":239,"context_line":"|provider-id      |string  |RO, all  |\u0027\u0027       |string      |human-readable |"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff346bd7_e645f118","line":236,"range":{"start_line":236,"start_character":1,"end_line":236,"end_character":12},"in_reply_to":"ff346bd7_e2da84e7","updated":"2017-07-24 21:14:16.000000000","message":"If we agree that a flavorprofile \u003d provider + flavor then the metadata would only be relevant based on the combination of the two (provider + flavor). Linking multiple flavors to a profile would mean that the metadata would be shared across flavors, which I think complicates managing flavors. \n\nIf flavors are represented as tiers, such as Gold, Silver, Bronze does it make sense to link multiple tiers to a single profile? For migrations, couldn\u0027t we just create a new flavorprofile (provider + flavor)?","commit_id":"0264ae40a9e4364330792922872b0cbfd19e2c6e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"77e068bd27911ccab9a9738e7e11f856b3cb75c9","unresolved":false,"context_lines":[{"line_number":323,"context_line":"* Implement the new models"},{"line_number":324,"context_line":"* Implement the REST API Extension (including tests)"},{"line_number":325,"context_line":"* Implementation migration script for existing deployments."},{"line_number":326,"context_line":"* Ensure notifications for Ceilometer are available."},{"line_number":327,"context_line":"* Add client API support"},{"line_number":328,"context_line":"* Add policies to the Octavia RBAC system"},{"line_number":329,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff346bd7_a24a3c52","line":326,"range":{"start_line":326,"start_character":2,"end_line":326,"end_character":52},"updated":"2017-07-24 16:20:25.000000000","message":"Neither neutron-lbaas or octavia currently send notifications to Ceilometer.  This seems to be a bit out of scope for this spec.","commit_id":"0264ae40a9e4364330792922872b0cbfd19e2c6e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"77e068bd27911ccab9a9738e7e11f856b3cb75c9","unresolved":false,"context_lines":[{"line_number":330,"context_line":"Dependencies"},{"line_number":331,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"Depends on deprecation of multi provider support"},{"line_number":334,"context_line":"if there will be one."},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"Testing"},{"line_number":337,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff346bd7_a2635cdc","line":334,"range":{"start_line":333,"start_character":0,"end_line":334,"end_character":21},"updated":"2017-07-24 16:20:25.000000000","message":"This does not make sense to me.  Why must we deprecate multi-provider support?","commit_id":"0264ae40a9e4364330792922872b0cbfd19e2c6e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"77e068bd27911ccab9a9738e7e11f856b3cb75c9","unresolved":false,"context_lines":[{"line_number":342,"context_line":""},{"line_number":343,"context_line":"Functional Tests"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"Functional testing is being excluded from this change because this API"},{"line_number":346,"context_line":"does not directly alter the data path. (Elements that alter the datapath are"},{"line_number":347,"context_line":"covered by other functional test)."},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"API Tests"},{"line_number":350,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff346bd7_02834855","line":347,"range":{"start_line":345,"start_character":0,"end_line":347,"end_character":34},"updated":"2017-07-24 16:20:25.000000000","message":"We have functional tests for both the API and the database that will need to be updated to include the flavors change.","commit_id":"0264ae40a9e4364330792922872b0cbfd19e2c6e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"77e068bd27911ccab9a9738e7e11f856b3cb75c9","unresolved":false,"context_lines":[{"line_number":366,"context_line":"Developer Documentation"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"Additionally, documentation of the new REST endpoints will need to be included"},{"line_number":369,"context_line":"in the Networking API description."},{"line_number":370,"context_line":""},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff346bd7_a2911c9c","line":369,"range":{"start_line":369,"start_character":7,"end_line":369,"end_character":17},"updated":"2017-07-24 16:20:25.000000000","message":"load-balancer","commit_id":"0264ae40a9e4364330792922872b0cbfd19e2c6e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"77e068bd27911ccab9a9738e7e11f856b3cb75c9","unresolved":false,"context_lines":[{"line_number":371,"context_line":""},{"line_number":372,"context_line":"References"},{"line_number":373,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":374,"context_line":"[1] http://docs.openstack.org/developer/octavia/api/octaviaapi.html"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff346bd7_82e3b833","line":374,"range":{"start_line":374,"start_character":4,"end_line":374,"end_character":67},"updated":"2017-07-24 16:20:25.000000000","message":"https://developer.openstack.org/api-ref/load-balancer/v2/index.html","commit_id":"0264ae40a9e4364330792922872b0cbfd19e2c6e"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"778a089785b064b86cb8029ed31d2e65e4463b12","unresolved":false,"context_lines":[{"line_number":73,"context_line":"prod or bronze, silver, gold.  A provider can have many flavor names and a"},{"line_number":74,"context_line":"flavor name can be used by only one provider.  Each provider/flavor pair is"},{"line_number":75,"context_line":"assigned a group of meta-parameters and forms a flavor profile. The flavor"},{"line_number":76,"context_line":"name or id is submitted when creating a load balancer."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"The proposal is to add LBaaS service flavoring to Octavia."},{"line_number":79,"context_line":"This will include following aspects:"}],"source_content_type":"text/x-rst","patch_set":14,"id":"ff346bd7_a2baee6a","line":76,"range":{"start_line":76,"start_character":53,"end_line":76,"end_character":54},"updated":"2017-07-26 13:40:39.000000000","message":"We should also be aware of driver\u0027s supported meta versions. For the case when driver starts supporting new capability which it did not support in previous version, and provider does not want to support the older meta parameters version anymore. The version should be part of meta info. Provider may also support several meta info versions, enable and disable them.\nSo, getting the supported parameters from driver will return a list of supported parameters versions.\nFor example, if newer driver version wants to obsolete the old supported parameters list, but tenant already has a profile for this older version, creating of LB with the old profile will not pass the driver\u0027s validation.","commit_id":"952a2e4a8f92a73527941c0b00d881a9f8a34051"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"df7ea7e2a9f92d36208a35dab6e473b505a8a4bf","unresolved":false,"context_lines":[{"line_number":73,"context_line":"prod or bronze, silver, gold.  A provider can have many flavor names and a"},{"line_number":74,"context_line":"flavor name can be used by only one provider.  Each provider/flavor pair is"},{"line_number":75,"context_line":"assigned a group of meta-parameters and forms a flavor profile. The flavor"},{"line_number":76,"context_line":"name or id is submitted when creating a load balancer."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"The proposal is to add LBaaS service flavoring to Octavia."},{"line_number":79,"context_line":"This will include following aspects:"}],"source_content_type":"text/x-rst","patch_set":14,"id":"ff346bd7_069c115b","line":76,"range":{"start_line":76,"start_character":53,"end_line":76,"end_character":54},"in_reply_to":"ff346bd7_a2baee6a","updated":"2017-07-27 05:14:57.000000000","message":"I fully agree with these statements and I think we have captured that in general here.  Maybe we should call out something more specific about the \"get capabilities\" interface.  Frankly, the provider interface is missing here, but I think that is ok as it should be in the provider spec (to be written).\nI do want to be careful specifying to much about the content of the metadata.  I think that we should try to handle it as a \"black box\" from an octavia perspective to give the providers full flexibility.  Some may version the json, some may not.  I\u0027m not sure I want to dictate that either way in this spec.\nAs long as we take the validation precautions (at flavor profile definition time and at lb creation time) we should be able to provide the operator and user with the proper feedback.","commit_id":"952a2e4a8f92a73527941c0b00d881a9f8a34051"},{"author":{"_account_id":20279,"name":"Jason Niesz","email":"Jason.Niesz@walmart.com","username":"jniesz"},"change_message_id":"a218b46e1f7ea455255abe0a381bd1fc82de3a7e","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    +--------------------+--------------+------+---------+----------+"},{"line_number":126,"context_line":"    | provider_name      | varchar(255) | NO   |         |          |"},{"line_number":127,"context_line":"    +--------------------+--------------+------+---------+----------+"},{"line_number":128,"context_line":"    | metadata           | varchar(4096)| NO   |         |          |"},{"line_number":129,"context_line":"    +--------------------+--------------+------+---------+----------+"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":".. note:: The provider_name is the name the driver is advertised as"}],"source_content_type":"text/x-rst","patch_set":14,"id":"ff346bd7_561f84b6","line":128,"updated":"2017-07-26 15:31:29.000000000","message":"I noticed we moved the metadata to the provider table.  I\u0027m assuming this model allows creating multiple flavors using the same provider?  If we created 10 flavors with the same provider, we would have 10 entries with the same name in the db, but different ids?  The only difference would be the metadata.","commit_id":"952a2e4a8f92a73527941c0b00d881a9f8a34051"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"df7ea7e2a9f92d36208a35dab6e473b505a8a4bf","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    +--------------------+--------------+------+---------+----------+"},{"line_number":126,"context_line":"    | provider_name      | varchar(255) | NO   |         |          |"},{"line_number":127,"context_line":"    +--------------------+--------------+------+---------+----------+"},{"line_number":128,"context_line":"    | metadata           | varchar(4096)| NO   |         |          |"},{"line_number":129,"context_line":"    +--------------------+--------------+------+---------+----------+"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":".. note:: The provider_name is the name the driver is advertised as"}],"source_content_type":"text/x-rst","patch_set":14,"id":"ff346bd7_06ae5197","line":128,"in_reply_to":"ff346bd7_561f84b6","updated":"2017-07-27 05:14:57.000000000","message":"Correct, flavor profiles are keyed by id.  The provider_name (octavia, f5, etc.) is a parameter and not unique in the table.  We could name/description flavor profiles, but it seems a excessive.  These are managed and exposed only to the operator.","commit_id":"952a2e4a8f92a73527941c0b00d881a9f8a34051"},{"author":{"_account_id":20279,"name":"Jason Niesz","email":"Jason.Niesz@walmart.com","username":"jniesz"},"change_message_id":"a218b46e1f7ea455255abe0a381bd1fc82de3a7e","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":157,"context_line":"    | Field              | Type         | Null | Key | Default  |"},{"line_number":158,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":159,"context_line":"    | flavor_profile_id  | varchar(36)  | YES  | FK1 |  NULL    |"},{"line_number":160,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"ff346bd7_d16dbecc","line":159,"updated":"2017-07-26 15:31:29.000000000","message":"Doesn\u0027t it make more sense to link this to a flavor_id, now that flavor has a reference to the flavor_profile_id?  It is possible to have a flavor_profile_id with no associated flavor.  Also the ability to enable/disable exists on the flavor itself and not the flavor_profile. \n\n1) User creates flavor_profile\n2) User creates flavor with flavor_profile\n3) load balancer gets associated to flavor.","commit_id":"952a2e4a8f92a73527941c0b00d881a9f8a34051"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"dcc2b13e469643dd7c48220e481f43db657bc702","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":157,"context_line":"    | Field              | Type         | Null | Key | Default  |"},{"line_number":158,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":159,"context_line":"    | flavor_profile_id  | varchar(36)  | YES  | FK1 |  NULL    |"},{"line_number":160,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"ff346bd7_3199aa78","line":159,"in_reply_to":"ff346bd7_d16dbecc","updated":"2017-07-26 15:38:44.000000000","message":"+1","commit_id":"952a2e4a8f92a73527941c0b00d881a9f8a34051"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"df7ea7e2a9f92d36208a35dab6e473b505a8a4bf","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":157,"context_line":"    | Field              | Type         | Null | Key | Default  |"},{"line_number":158,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":159,"context_line":"    | flavor_profile_id  | varchar(36)  | YES  | FK1 |  NULL    |"},{"line_number":160,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"ff346bd7_a69c256a","line":159,"in_reply_to":"ff346bd7_d16dbecc","updated":"2017-07-27 05:14:57.000000000","message":"Yes, this was my mistake.  Fixing.","commit_id":"952a2e4a8f92a73527941c0b00d881a9f8a34051"},{"author":{"_account_id":22733,"name":"Carlos Puga","email":"carlpuga@gmail.com","username":"carlpuga"},"change_message_id":"8a5e0104efde5238e91c6a319c927717573b8994","unresolved":false,"context_lines":[{"line_number":194,"context_line":"|id               |string  |admin    |generated|N/A         |identity       |"},{"line_number":195,"context_line":"|                 |(UUID)  |         |         |            |               |"},{"line_number":196,"context_line":"+-----------------+--------+---------+---------+------------+---------------+"},{"line_number":197,"context_line":"|name             |string  |admin    |\u0027\u0027       |string      |human-readable |"},{"line_number":198,"context_line":"|                 |        |         |         |            |name           |"},{"line_number":199,"context_line":"+-----------------+--------+---------+---------+------------+---------------+"},{"line_number":200,"context_line":"|provider-id      |string  |admin    |\u0027\u0027       |string      |human-readable |"}],"source_content_type":"text/x-rst","patch_set":15,"id":"9f436f4f_0494a443","line":197,"range":{"start_line":197,"start_character":1,"end_line":197,"end_character":5},"updated":"2017-08-08 08:27:45.000000000","message":"Does it make sense to keep this \"name\" attribute?  It isn\u0027t in the flavor_profile table, perhaps it can be dropped.","commit_id":"a33161749681a908ff5f96fb6d0e73263f518aee"},{"author":{"_account_id":22733,"name":"Carlos Puga","email":"carlpuga@gmail.com","username":"carlpuga"},"change_message_id":"8a5e0104efde5238e91c6a319c927717573b8994","unresolved":false,"context_lines":[{"line_number":197,"context_line":"|name             |string  |admin    |\u0027\u0027       |string      |human-readable |"},{"line_number":198,"context_line":"|                 |        |         |         |            |name           |"},{"line_number":199,"context_line":"+-----------------+--------+---------+---------+------------+---------------+"},{"line_number":200,"context_line":"|provider-id      |string  |admin    |\u0027\u0027       |string      |human-readable |"},{"line_number":201,"context_line":"|                 |        |         |         |            |provider-id    |"},{"line_number":202,"context_line":"+-----------------+--------+---------+---------+------------+---------------+"},{"line_number":203,"context_line":"|metadata         |string  |admin    |{}       |json        |flavor meta    |"}],"source_content_type":"text/x-rst","patch_set":15,"id":"9f436f4f_44b50cee","line":200,"range":{"start_line":200,"start_character":1,"end_line":200,"end_character":12},"updated":"2017-08-08 08:27:45.000000000","message":"Given the change to the flavor_profile table its attribute of provider-id should probably now be provider_name.","commit_id":"a33161749681a908ff5f96fb6d0e73263f518aee"}],"specs/version1/flavors.rst":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"c990ed4bad3bd3a2d5d7239a3b976dc2b34362d8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"octavia.  In addition operators can configure different flavors from a"},{"line_number":18,"context_line":"maintained list of provider capabilities.  This framework enables providers"},{"line_number":19,"context_line":"to supply new features with speed to market and provides operators with an"},{"line_number":20,"context_line":"ease of use experience."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f231b9d_c0b3b209","line":20,"updated":"2017-06-14 16:30:09.000000000","message":"Another goal was to simplify having multiple providers in the same installation, e.g. referring to a load balance not by it\u0027s provider name but rather some arbitrary identifier, e.g. \"gold\"","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7c6a2af7af4c34e4ace36798b98b6245d6593a3c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"the operators to enable capabilities that may possibly be unique to a"},{"line_number":16,"context_line":"particular provider or simply just not available at the moment within"},{"line_number":17,"context_line":"octavia.  In addition operators can configure different flavors from a"},{"line_number":18,"context_line":"maintained list of provider capabilities.  This framework enables providers"},{"line_number":19,"context_line":"to supply new features with speed to market and provides operators with an"},{"line_number":20,"context_line":"ease of use experience."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_2c0ad925","line":20,"range":{"start_line":18,"start_character":43,"end_line":20,"end_character":23},"updated":"2017-06-29 14:45:50.000000000","message":"We should include a warning that this should not be used as a crutch to bypass adding new features to the overall octavia API.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7c6a2af7af4c34e4ace36798b98b6245d6593a3c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"octavia.  In addition operators can configure different flavors from a"},{"line_number":18,"context_line":"maintained list of provider capabilities.  This framework enables providers"},{"line_number":19,"context_line":"to supply new features with speed to market and provides operators with an"},{"line_number":20,"context_line":"ease of use experience."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_cc30050b","line":20,"in_reply_to":"7f231b9d_c0b3b209","updated":"2017-06-29 14:45:50.000000000","message":"+1, this is very provider heavy when all of octavia will leverage this.  It kind of sends the wrong message.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":22733,"name":"Carlos Puga","email":"carlpuga@gmail.com","username":"carlpuga"},"change_message_id":"28375e4e468a6158a9c3e343412d2bedc79cf1a8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"octavia.  In addition operators can configure different flavors from a"},{"line_number":18,"context_line":"maintained list of provider capabilities.  This framework enables providers"},{"line_number":19,"context_line":"to supply new features with speed to market and provides operators with an"},{"line_number":20,"context_line":"ease of use experience."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f231b9d_d2fdc16e","line":20,"in_reply_to":"7f231b9d_c0b3b209","updated":"2017-06-14 22:44:47.000000000","message":"with this design we wouldn\u0027t reference a provider_name instead we would reference a flavor_profile_name, which is a combination of a provider and a flavor.  I was thinking the ability to reference only a flavor_name and have scheduling logic to choose the preferred provider could be added as an enhancement after the initial release, unless its a hard requirement then I can add it to this spec.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7c6a2af7af4c34e4ace36798b98b6245d6593a3c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"octavia.  In addition operators can configure different flavors from a"},{"line_number":18,"context_line":"maintained list of provider capabilities.  This framework enables providers"},{"line_number":19,"context_line":"to supply new features with speed to market and provides operators with an"},{"line_number":20,"context_line":"ease of use experience."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_2f0f6b2f","line":20,"in_reply_to":"7f231b9d_d2fdc16e","updated":"2017-06-29 14:45:50.000000000","message":"Yeah, the intent is to have a simplified \"bundle\" for users.  It should include the provider from the start.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7c6a2af7af4c34e4ace36798b98b6245d6593a3c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"ease of use experience."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Problem description"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"At the moment providers do not have a method of enabling capabilities that"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_0fbf0ffc","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":19},"updated":"2017-06-29 14:45:50.000000000","message":"We are missing the main intent of providers, which is enabling the operator to bundle settings into a single flavor.  For example, using the octavia provider the operator could specify a active/standby medium sized load balancer as the \"gold\" flavor.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7c6a2af7af4c34e4ace36798b98b6245d6593a3c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Problem description"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"At the moment providers do not have a method of enabling capabilities that"},{"line_number":27,"context_line":"are not exposed via the octavia api.  This dependency creates a waiting"},{"line_number":28,"context_line":"period for new features in the marketplace to be made available for use"},{"line_number":29,"context_line":"with octavia.  In addition not all features may be supported by other"},{"line_number":30,"context_line":"providers, thereby reducing the likely hood that said features will ever be"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_ef5f330c","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":36},"updated":"2017-06-29 14:45:50.000000000","message":"Not true.  They can propose additions to the octavia API.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7c6a2af7af4c34e4ace36798b98b6245d6593a3c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"As for now, Octavia does not support multi providers.  The ability to"},{"line_number":44,"context_line":"define different LBaaS providers is a mandatory feature for Octavia to be"},{"line_number":45,"context_line":"Openstack LbaaS API. Therefore, this spec depends on adding multi providers"},{"line_number":46,"context_line":"support to Octavia.  Service providers will probably be configured via"},{"line_number":47,"context_line":"Octavia configuration file.  However, eventually loadbalancer flavor"},{"line_number":48,"context_line":"selection will replace provider selection."},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_4f974792","line":46,"range":{"start_line":46,"start_character":44,"end_line":46,"end_character":52},"updated":"2017-06-29 14:45:50.000000000","message":"We can remove the word \"probably\"","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"859ad87c87d17c556947a423cb1f7768f109f6d8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"define different LBaaS providers is a mandatory feature for Octavia to be"},{"line_number":45,"context_line":"Openstack LbaaS API. Therefore, this spec depends on adding multi providers"},{"line_number":46,"context_line":"support to Octavia.  Service providers will probably be configured via"},{"line_number":47,"context_line":"Octavia configuration file.  However, eventually loadbalancer flavor"},{"line_number":48,"context_line":"selection will replace provider selection."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Its important to mention that adding flavors capability to Octavia is not"},{"line_number":51,"context_line":"actually dependent on the work for LBaaS API spinout, from Neutron to"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f201791_2020c8f6","line":48,"range":{"start_line":47,"start_character":29,"end_line":48,"end_character":42},"updated":"2017-06-28 08:08:33.000000000","message":"In a second thought, is it really good to remove the option of just picking up a provider and go with its defaults, without starting the flavors/profiles/meta journey?\nWe may want to leave the option to create LB by just specifying provider. What are your thoughts about it?","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"900e86c92f7b610140c98c6085704e60abd00426","unresolved":false,"context_lines":[{"line_number":44,"context_line":"define different LBaaS providers is a mandatory feature for Octavia to be"},{"line_number":45,"context_line":"Openstack LbaaS API. Therefore, this spec depends on adding multi providers"},{"line_number":46,"context_line":"support to Octavia.  Service providers will probably be configured via"},{"line_number":47,"context_line":"Octavia configuration file.  However, eventually loadbalancer flavor"},{"line_number":48,"context_line":"selection will replace provider selection."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Its important to mention that adding flavors capability to Octavia is not"},{"line_number":51,"context_line":"actually dependent on the work for LBaaS API spinout, from Neutron to"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_8f279f65","line":48,"range":{"start_line":47,"start_character":29,"end_line":48,"end_character":42},"in_reply_to":"3f1d235d_6ff7a3f7","updated":"2017-06-29 15:00:09.000000000","message":"flavor might define the provider, but provider does not require a flavor.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7c6a2af7af4c34e4ace36798b98b6245d6593a3c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"define different LBaaS providers is a mandatory feature for Octavia to be"},{"line_number":45,"context_line":"Openstack LbaaS API. Therefore, this spec depends on adding multi providers"},{"line_number":46,"context_line":"support to Octavia.  Service providers will probably be configured via"},{"line_number":47,"context_line":"Octavia configuration file.  However, eventually loadbalancer flavor"},{"line_number":48,"context_line":"selection will replace provider selection."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Its important to mention that adding flavors capability to Octavia is not"},{"line_number":51,"context_line":"actually dependent on the work for LBaaS API spinout, from Neutron to"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_6ff7a3f7","line":48,"range":{"start_line":47,"start_character":29,"end_line":48,"end_character":42},"in_reply_to":"5f201791_2020c8f6","updated":"2017-06-29 14:45:50.000000000","message":"+1, I would strike this sentence.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"859ad87c87d17c556947a423cb1f7768f109f6d8","unresolved":false,"context_lines":[{"line_number":69,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"The Provider Flavor framework enables the ability to create distinct"},{"line_number":72,"context_line":"provider flavor profiles of supported capabilities.  Admins have the"},{"line_number":73,"context_line":"ability to add and maintain a list of supported capabilities per provider."},{"line_number":74,"context_line":"Operators can then view the said list by provider and create flavors by"},{"line_number":75,"context_line":"selecting one or many capabilities from the list. Users then have the"},{"line_number":76,"context_line":"option of selecting from any of the existing flavors and submitting the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f201791_6597f249","line":73,"range":{"start_line":72,"start_character":53,"end_line":73,"end_character":73},"updated":"2017-06-28 08:08:33.000000000","message":"I think these are not capabilities but meta parameters.\nEach one of these parameters may also have a list of possible values.\nI\u0027m not sure this concern should be targeted in this spec , but how will Admin get this list of supported by provider meta parameters? Will the list be part of provider configuration file?","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"900e86c92f7b610140c98c6085704e60abd00426","unresolved":false,"context_lines":[{"line_number":69,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"The Provider Flavor framework enables the ability to create distinct"},{"line_number":72,"context_line":"provider flavor profiles of supported capabilities.  Admins have the"},{"line_number":73,"context_line":"ability to add and maintain a list of supported capabilities per provider."},{"line_number":74,"context_line":"Operators can then view the said list by provider and create flavors by"},{"line_number":75,"context_line":"selecting one or many capabilities from the list. Users then have the"},{"line_number":76,"context_line":"option of selecting from any of the existing flavors and submitting the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_ef69738b","line":73,"range":{"start_line":72,"start_character":53,"end_line":73,"end_character":73},"in_reply_to":"5f201791_6597f249","updated":"2017-06-29 15:00:09.000000000","message":"Agreed, capabilities is a bit too narrow of a focus, meta parameters might be better.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"900e86c92f7b610140c98c6085704e60abd00426","unresolved":false,"context_lines":[{"line_number":71,"context_line":"The Provider Flavor framework enables the ability to create distinct"},{"line_number":72,"context_line":"provider flavor profiles of supported capabilities.  Admins have the"},{"line_number":73,"context_line":"ability to add and maintain a list of supported capabilities per provider."},{"line_number":74,"context_line":"Operators can then view the said list by provider and create flavors by"},{"line_number":75,"context_line":"selecting one or many capabilities from the list. Users then have the"},{"line_number":76,"context_line":"option of selecting from any of the existing flavors and submitting the"},{"line_number":77,"context_line":"selected flavor upon the creation of the load balancer. The parameters that"},{"line_number":78,"context_line":"will be used to enable capabilities for specific functionality are nothing"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_0f026fb5","line":75,"range":{"start_line":74,"start_character":0,"end_line":75,"end_character":49},"updated":"2017-06-29 15:00:09.000000000","message":"So you are saying the provider driver must have an interface that can be queried to produce the list of valid meta parameters for that provider?  I like the idea, though it will need to be described in detail either in this or a related spec.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"900e86c92f7b610140c98c6085704e60abd00426","unresolved":false,"context_lines":[{"line_number":79,"context_line":"more than key/value pairs grouped and assigned to a provider and a flavor"},{"line_number":80,"context_line":"name. The following flavor name examples can be, but not limited to dev,"},{"line_number":81,"context_line":"stage, prod or bronze, silver, gold.  A provider can have many flavor names"},{"line_number":82,"context_line":"and a flavor name can be used by many providers.  Each provider/flavor set"},{"line_number":83,"context_line":"is assigned a group of key/values pairs and forms a flavor profile.  The"},{"line_number":84,"context_line":"flavor profile id is submitted when creating a load balancer."},{"line_number":85,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_afa5bbb7","line":82,"range":{"start_line":82,"start_character":6,"end_line":82,"end_character":47},"updated":"2017-06-29 15:00:09.000000000","message":"Hmm, This doesn\u0027t seem right.  A flavor can encapsulate the provider to use, so I don\u0027t see how this will work.  It certainly makes flavor selection much harder for the end user.  I mean I guess a name can just be meta-data, with the ID being the key, but this gives a lesser user experience.  flavor gold: Sorry, multiple flavors named gold, ID required.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cea0b65a1dc4b174afee3e5dcf02da092315f45b","unresolved":false,"context_lines":[{"line_number":82,"context_line":"and a flavor name can be used by many providers.  Each provider/flavor set"},{"line_number":83,"context_line":"is assigned a group of key/values pairs and forms a flavor profile.  The"},{"line_number":84,"context_line":"flavor profile id is submitted when creating a load balancer."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"The proposal is to add LBaaS service flavoring to Octavia."},{"line_number":87,"context_line":"This will include following aspects:"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_c0d20435","line":85,"updated":"2017-06-29 16:27:43.000000000","message":"flavor metadata should be expressed in json types","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"859ad87c87d17c556947a423cb1f7768f109f6d8","unresolved":false,"context_lines":[{"line_number":94,"context_line":"  created before flavors support. This is for both cases, when loadbalancer"},{"line_number":95,"context_line":"  was created before multi providers support and when loadbalancer was"},{"line_number":96,"context_line":"  created with certain provider."},{"line_number":97,"context_line":"* Adding default entries to DB tables representing the default Octavia"},{"line_number":98,"context_line":"  flavor and default Octavia provider profile."},{"line_number":99,"context_line":"* Adding \"default\" flavor to devstack plugin."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f201791_e5eb0210","line":98,"range":{"start_line":97,"start_character":2,"end_line":98,"end_character":46},"updated":"2017-06-28 08:08:33.000000000","message":"Does that means Octavia will populate DB tables as part of installation process?\nIf yes, is it a common practice in Openstack?","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"900e86c92f7b610140c98c6085704e60abd00426","unresolved":false,"context_lines":[{"line_number":94,"context_line":"  created before flavors support. This is for both cases, when loadbalancer"},{"line_number":95,"context_line":"  was created before multi providers support and when loadbalancer was"},{"line_number":96,"context_line":"  created with certain provider."},{"line_number":97,"context_line":"* Adding default entries to DB tables representing the default Octavia"},{"line_number":98,"context_line":"  flavor and default Octavia provider profile."},{"line_number":99,"context_line":"* Adding \"default\" flavor to devstack plugin."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_8f343f4c","line":98,"range":{"start_line":97,"start_character":2,"end_line":98,"end_character":46},"in_reply_to":"5f201791_e5eb0210","updated":"2017-06-29 15:00:09.000000000","message":"Yes and sometimes.  This is about the out-of-box-experience for operators.  I think we need to go down this path for an upgrade experience.  Otherwise we would just set them up using the devstack plugin.\nIf we don\u0027t, the instant the operator installs the upgrade users would no longer be able to create load balancers until the operator loaded a \"default\" flavor.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cea0b65a1dc4b174afee3e5dcf02da092315f45b","unresolved":false,"context_lines":[{"line_number":97,"context_line":"* Adding default entries to DB tables representing the default Octavia"},{"line_number":98,"context_line":"  flavor and default Octavia provider profile."},{"line_number":99,"context_line":"* Adding \"default\" flavor to devstack plugin."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Alternatives"},{"line_number":103,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_6013300f","line":100,"updated":"2017-06-29 16:27:43.000000000","message":"Use case?\n\nOperator flavor workflow\n\nOperator queries provider capabilities\noperator creates profile\nOperator uploads profile\nwe validate profile with driver\nprofile stored in octavia DB\npassed to driver when LB is created","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"900e86c92f7b610140c98c6085704e60abd00426","unresolved":false,"context_lines":[{"line_number":114,"context_line":"Data model impact"},{"line_number":115,"context_line":"-----------------"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"DB table \u0027provider\u0027 introduced to represent providers."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":120,"context_line":"    | Field              | Type         | Null | Key | Default  |"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_ef729311","line":117,"range":{"start_line":117,"start_character":0,"end_line":117,"end_character":54},"updated":"2017-06-29 15:00:09.000000000","message":"This may not be necessary and/or could be odd with the dynamic loading of the providers via stevedore.  I planed to have the enabled list in the config and just have them available if stevedore can find them.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"c990ed4bad3bd3a2d5d7239a3b976dc2b34362d8","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"DB table \u0027provider_metadata_key\u0027 introduced to contain provider metadata"},{"line_number":135,"context_line":"keys, these are only the keys of key/value pairs.  This table will have a"},{"line_number":136,"context_line":"one-to-many relationship with provider.  One provider can have one or many"},{"line_number":137,"context_line":"keys."}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f231b9d_407442fe","line":134,"updated":"2017-06-14 16:30:09.000000000","message":"this feels like a convoluted way to manage key-values which an operator (who should know what they are doing) puts on a flavor","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":22733,"name":"Carlos Puga","email":"carlpuga@gmail.com","username":"carlpuga"},"change_message_id":"28375e4e468a6158a9c3e343412d2bedc79cf1a8","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"DB table \u0027provider_metadata_key\u0027 introduced to contain provider metadata"},{"line_number":135,"context_line":"keys, these are only the keys of key/value pairs.  This table will have a"},{"line_number":136,"context_line":"one-to-many relationship with provider.  One provider can have one or many"},{"line_number":137,"context_line":"keys."}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f231b9d_926e292d","line":134,"in_reply_to":"7f231b9d_407442fe","updated":"2017-06-14 22:44:47.000000000","message":"the provider_metadata_key has a one-to-many relationship with provider_metadata_value table, it serves the purpose of maintaining a list of supported capabilites by provider.  \nThe list can then be viewed by the operator who would then create the flavor profile by cherry picking capabilities from the list.  \nExamples of the list could be compression_types such as gzip, deflate, bzip or a list of glance_images or of nova_flavors.  It is really just a place to maintain a list of supported key/values pairs, it would be up to the provider to determine what would go in there.\n\nIts purpose is to provide ease of use for the operator in creating the flavor profiles. These two tables are not mandatory for the flavor spec.  We could drop them.  It would just mean that the operator would then refer to the provider documentation upon creating flavor profiles, as opposed to selecting from a list.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":20279,"name":"Jason Niesz","email":"Jason.Niesz@walmart.com","username":"jniesz"},"change_message_id":"b8e17267825e77ad23d0a75681829c4de637a6d7","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"DB table \u0027provider_metadata_key\u0027 introduced to contain provider metadata"},{"line_number":135,"context_line":"keys, these are only the keys of key/value pairs.  This table will have a"},{"line_number":136,"context_line":"one-to-many relationship with provider.  One provider can have one or many"},{"line_number":137,"context_line":"keys."}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f231b9d_be9b0f16","line":134,"in_reply_to":"7f231b9d_926e292d","updated":"2017-06-15 20:15:36.000000000","message":"Is using a key/value table the best way to describe the capabilities a particular provider implements? How are we going to ensure that each provider keeps entries updated and ensure old values are updated/removed as the capabilities of a provider can change over time?   \n\nHow are we going to handle situations when a provider removes a capability and there are flavors currently using that capability?  Are we going to implement some sort of versioning for capabilities?","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":22733,"name":"Carlos Puga","email":"carlpuga@gmail.com","username":"carlpuga"},"change_message_id":"0d848980d7318877b08be9dce7e06d82b52dac93","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"DB table \u0027provider_metadata_key\u0027 introduced to contain provider metadata"},{"line_number":135,"context_line":"keys, these are only the keys of key/value pairs.  This table will have a"},{"line_number":136,"context_line":"one-to-many relationship with provider.  One provider can have one or many"},{"line_number":137,"context_line":"keys."}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f231b9d_052bae82","line":134,"in_reply_to":"7f231b9d_be9b0f16","updated":"2017-06-16 19:00:10.000000000","message":"--It not the only way but its a very common way.  Having a structured layout would provide flexibility with queries, update, etc.\n--It would be nice if upon the installation of the provider driver it would update the table with its supported capabilities, however most likely the admin/operator who installed the updated driver would refer to the providers documentation to update the table accordingly. \n--If a capability is removed from the table, the lbs using that flavor continue to run. Also timestamps on the flavor profile would display that it is no longer in sync.  \n--If a new version is desired, a new provider entry can be created and linked to a new set of key/values.  The provider_name could be set to something like \"provider-v2\".","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"859ad87c87d17c556947a423cb1f7768f109f6d8","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":140,"context_line":"    | Field              | Type         | Null | Key | Default  |"},{"line_number":141,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":142,"context_line":"    | id                 | varchar(36)  | NO   | PK  | generated|"},{"line_number":143,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":144,"context_line":"    | key_name           | varchar(255) | YES  |     | NULL     |"},{"line_number":145,"context_line":"    +--------------------+--------------+------+-----+----------+"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f201791_40718475","line":142,"range":{"start_line":142,"start_character":0,"end_line":142,"end_character":65},"updated":"2017-06-28 08:08:33.000000000","message":"While thinking of flavors CLI usability , I wounder may be the key and the value should have a name column as well.\nBuilding the profile metadata (binding meta values to a profile, especially) with UUIDs may not be a nice experience...","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"859ad87c87d17c556947a423cb1f7768f109f6d8","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    +--------------------------+--------------+------+-----+----------+"},{"line_number":161,"context_line":"    | id                       | varchar(36)  | NO   | PK  | generated|"},{"line_number":162,"context_line":"    +--------------------------+--------------+------+-----+----------+"},{"line_number":163,"context_line":"    | value                    | varchar(255) | YES  |     | NULL     |"},{"line_number":164,"context_line":"    +--------------------------+--------------+------+-----+----------+"},{"line_number":165,"context_line":"    | provider_metadata_key_id | varchar(36)  | NO   | FK1 |          |"},{"line_number":166,"context_line":"    +--------------------------+--------------+------+-----+----------+"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f201791_25069a21","line":163,"range":{"start_line":163,"start_character":33,"end_line":163,"end_character":45},"updated":"2017-06-28 08:08:33.000000000","message":"I\u0027m thinking what if the value is not just bool,int or string? Is it possible that provider will put a list of strings or even JSON as a value for certain meta key?\nwill 255 be enough ?","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"859ad87c87d17c556947a423cb1f7768f109f6d8","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    +--------------------------+--------------+------+-----+----------+"},{"line_number":161,"context_line":"    | id                       | varchar(36)  | NO   | PK  | generated|"},{"line_number":162,"context_line":"    +--------------------------+--------------+------+-----+----------+"},{"line_number":163,"context_line":"    | value                    | varchar(255) | YES  |     | NULL     |"},{"line_number":164,"context_line":"    +--------------------------+--------------+------+-----+----------+"},{"line_number":165,"context_line":"    | provider_metadata_key_id | varchar(36)  | NO   | FK1 |          |"},{"line_number":166,"context_line":"    +--------------------------+--------------+------+-----+----------+"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f201791_403984d4","line":163,"range":{"start_line":163,"start_character":48,"end_line":163,"end_character":65},"updated":"2017-06-28 08:08:33.000000000","message":"What is a rationale in creating NULL value for a meta key?","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"c990ed4bad3bd3a2d5d7239a3b976dc2b34362d8","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"DB table \u0027flavor\u0027 introduced to represent flavors.  The attribute"},{"line_number":205,"context_line":"lb_topology_name is added to this table given that a lb topology could"},{"line_number":206,"context_line":"apply to any flavor and/or provider.  It is a foreign key to the"},{"line_number":207,"context_line":"lb_topology table."},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    +--------------------+--------------+------+-----+----------+"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f231b9d_80dc9ae4","line":206,"updated":"2017-06-14 16:30:09.000000000","message":"isn\u0027t the topology just another key-value? Also do other providers but Octavia have a topology?","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":22733,"name":"Carlos Puga","email":"carlpuga@gmail.com","username":"carlpuga"},"change_message_id":"28375e4e468a6158a9c3e343412d2bedc79cf1a8","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"DB table \u0027flavor\u0027 introduced to represent flavors.  The attribute"},{"line_number":205,"context_line":"lb_topology_name is added to this table given that a lb topology could"},{"line_number":206,"context_line":"apply to any flavor and/or provider.  It is a foreign key to the"},{"line_number":207,"context_line":"lb_topology table."},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    +--------------------+--------------+------+-----+----------+"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f231b9d_f2cd5d31","line":206,"in_reply_to":"7f231b9d_80dc9ae4","updated":"2017-06-14 22:44:47.000000000","message":"I felt all providers would support at minimum \"single\" topology, however if not then it could also be left null.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"859ad87c87d17c556947a423cb1f7768f109f6d8","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"DB table \u0027flavor\u0027 introduced to represent flavors.  The attribute"},{"line_number":205,"context_line":"lb_topology_name is added to this table given that a lb topology could"},{"line_number":206,"context_line":"apply to any flavor and/or provider.  It is a foreign key to the"},{"line_number":207,"context_line":"lb_topology table."},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    +--------------------+--------------+------+-----+----------+"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5f201791_25c45a3f","line":206,"in_reply_to":"7f231b9d_f2cd5d31","updated":"2017-06-28 08:08:33.000000000","message":"Can you give an example for lb_topology value?\nIs it mandatory to specify lb_topology while creating LB?\nIt looks like this is just a parameter for LB and there is a lookup table for it. Does it have any functional effect in Octavia?","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":25279,"name":"Matt Greene","email":"m.greene@f5.com"},"change_message_id":"e2348dbc91419d80eb40ac00a08ae70a649305cb","unresolved":false,"context_lines":[{"line_number":204,"context_line":"DB table \u0027flavor\u0027 introduced to represent flavors.  The attribute"},{"line_number":205,"context_line":"lb_topology_name is added to this table given that a lb topology could"},{"line_number":206,"context_line":"apply to any flavor and/or provider.  It is a foreign key to the"},{"line_number":207,"context_line":"lb_topology table."},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":210,"context_line":"    | Field              | Type         | Null | Key | Default  |"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f231b9d_77681fb8","line":207,"updated":"2017-06-14 21:03:58.000000000","message":"How about removing the lb_topology_name row entirely?  I\u0027m not familiar with this field from a vendor perspective, though we\u0027ve not yet moved from neutron_lbaas to octavia.  If we keep \u0027flavor\u0027 as a generic table for containing it would restrict flavors to ONLY attaching to an lb.  I\u0027d like to see a flavor, or flavor-provider tuple be attachable to any octavia primary resource, such as pool, healthmonitor, listener, etc.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":22733,"name":"Carlos Puga","email":"carlpuga@gmail.com","username":"carlpuga"},"change_message_id":"28375e4e468a6158a9c3e343412d2bedc79cf1a8","unresolved":false,"context_lines":[{"line_number":204,"context_line":"DB table \u0027flavor\u0027 introduced to represent flavors.  The attribute"},{"line_number":205,"context_line":"lb_topology_name is added to this table given that a lb topology could"},{"line_number":206,"context_line":"apply to any flavor and/or provider.  It is a foreign key to the"},{"line_number":207,"context_line":"lb_topology table."},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":210,"context_line":"    | Field              | Type         | Null | Key | Default  |"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f231b9d_57fd20af","line":207,"in_reply_to":"7f231b9d_77681fb8","updated":"2017-06-14 22:44:47.000000000","message":"I could remove it and just let it be handled as any other provider key-value.  However I put it here because I felt it was a common attribute that could be part of a flavor and not necessarily a flavor profile.  Looking forward perhaps the flavor table could link to other tables to create different flavor configurations.  For example, at some point, the flavor table could link with \"algorithm\" or with \"protocol\" and then flavors of existing shared functionality could be created and potentially applied other lb components such as listener, pool, etc.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cea0b65a1dc4b174afee3e5dcf02da092315f45b","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":212,"context_line":"    | id                 | varchar(36)  | NO   | PK  | generated|"},{"line_number":213,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":214,"context_line":"    | name               | varchar(255) | NO   |     |          |"},{"line_number":215,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":216,"context_line":"    | description        | varchar(255) | YES  |     | NULL     |"},{"line_number":217,"context_line":"    +--------------------+--------------+------+-----+----------+"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_207ad823","line":214,"range":{"start_line":214,"start_character":6,"end_line":214,"end_character":10},"updated":"2017-06-29 16:27:43.000000000","message":"Name would be unique and point to one flavor profile ID at a time.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":25279,"name":"Matt Greene","email":"m.greene@f5.com"},"change_message_id":"e2348dbc91419d80eb40ac00a08ae70a649305cb","unresolved":false,"context_lines":[{"line_number":227,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":228,"context_line":"    | Field              | Type         | Null | Key | Default  |"},{"line_number":229,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":230,"context_line":"    | flavor_profile_id  | varchar(36)  | YES  | FK1 |  NULL    |"},{"line_number":231,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f231b9d_f720afae","line":230,"updated":"2017-06-14 21:03:58.000000000","message":"Does this field need to allow NULL in order to make the field optional for the command-line?  Could the default be the new default Octavia flavor profile instead of NULL?","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":22733,"name":"Carlos Puga","email":"carlpuga@gmail.com","username":"carlpuga"},"change_message_id":"28375e4e468a6158a9c3e343412d2bedc79cf1a8","unresolved":false,"context_lines":[{"line_number":227,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":228,"context_line":"    | Field              | Type         | Null | Key | Default  |"},{"line_number":229,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":230,"context_line":"    | flavor_profile_id  | varchar(36)  | YES  | FK1 |  NULL    |"},{"line_number":231,"context_line":"    +--------------------+--------------+------+-----+----------+"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f231b9d_b4059248","line":230,"in_reply_to":"7f231b9d_f720afae","updated":"2017-06-14 22:44:47.000000000","message":"I felt that it was the safer approach, instead of forcing a default empty flavor on all running lb\u0027s that would consist of different providers.  Leaving it NULL would allow for paced adoption.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ac87620a4bfc713f13b30f1508bc7f8618e4a94c","unresolved":false,"context_lines":[{"line_number":358,"context_line":"---------------"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"The policy.json will be updated to allow all users to query the flavor"},{"line_number":361,"context_line":"listing and request details about a specific flavor entry. All other REST"},{"line_number":362,"context_line":"points for create/update/delete operations will admin only. Additionally, the"},{"line_number":363,"context_line":"CRUD operations for Provider Profiles will be restricted to administrators."},{"line_number":364,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_e0a86078","line":361,"range":{"start_line":361,"start_character":12,"end_line":361,"end_character":27},"updated":"2017-06-29 16:35:10.000000000","message":"Name and description, but end users should not be able to see the flavor metadata.  That should be a separate API for the operator.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ac87620a4bfc713f13b30f1508bc7f8618e4a94c","unresolved":false,"context_lines":[{"line_number":363,"context_line":"CRUD operations for Provider Profiles will be restricted to administrators."},{"line_number":364,"context_line":""},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"Notifications impact"},{"line_number":367,"context_line":"--------------------"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"The content of current notifications will change minimally to add a new flavor"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_40d034f8","line":366,"range":{"start_line":366,"start_character":0,"end_line":366,"end_character":20},"updated":"2017-06-29 16:35:10.000000000","message":"We don\u0027t currently have notifications (aside from the lbaas sync system), so this should be no impact.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"c990ed4bad3bd3a2d5d7239a3b976dc2b34362d8","unresolved":false,"context_lines":[{"line_number":375,"context_line":"Other end user impact"},{"line_number":376,"context_line":"---------------------"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"An existing LB cannot be updated with a different flavor.  A flavor can"},{"line_number":379,"context_line":"only be applied upon the creation of the LB.  However it is possible that a"},{"line_number":380,"context_line":"LB is created with a particular flavor and then thereafter the flavor is"},{"line_number":381,"context_line":"updated.  Timestamps will be applied to any flavor update so that users can"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f231b9d_c011725f","line":378,"updated":"2017-06-14 16:30:09.000000000","message":"There is a patch for a failover functionality (https://review.openstack.org/#/c/444347/) so this could be extended to trigger a failover to a new load balancers with the new flavor","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ac87620a4bfc713f13b30f1508bc7f8618e4a94c","unresolved":false,"context_lines":[{"line_number":375,"context_line":"Other end user impact"},{"line_number":376,"context_line":"---------------------"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"An existing LB cannot be updated with a different flavor.  A flavor can"},{"line_number":379,"context_line":"only be applied upon the creation of the LB.  However it is possible that a"},{"line_number":380,"context_line":"LB is created with a particular flavor and then thereafter the flavor is"},{"line_number":381,"context_line":"updated.  Timestamps will be applied to any flavor update so that users can"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_20f65891","line":378,"in_reply_to":"7f231b9d_74c37a39","updated":"2017-06-29 16:35:10.000000000","message":"I agree with Carlos, I don\u0027t think this can change.  We might add a \"migrate\" API in the future, but that is independent from an \"update\" call on the LB or the failover API.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":22733,"name":"Carlos Puga","email":"carlpuga@gmail.com","username":"carlpuga"},"change_message_id":"28375e4e468a6158a9c3e343412d2bedc79cf1a8","unresolved":false,"context_lines":[{"line_number":375,"context_line":"Other end user impact"},{"line_number":376,"context_line":"---------------------"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"An existing LB cannot be updated with a different flavor.  A flavor can"},{"line_number":379,"context_line":"only be applied upon the creation of the LB.  However it is possible that a"},{"line_number":380,"context_line":"LB is created with a particular flavor and then thereafter the flavor is"},{"line_number":381,"context_line":"updated.  Timestamps will be applied to any flavor update so that users can"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f231b9d_74c37a39","line":378,"in_reply_to":"7f231b9d_9775fb66","updated":"2017-06-14 22:44:47.000000000","message":"It is the flavor profile which is applied to the lb.  The combination of a flavor and a provider makes up a flavor profile.  The metadata is tied to the flavor profile and it is passed to the lb upon creation of the lb.  Once an lb has been created with a specific profile it will remain with the lb for the life of the lb.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":25279,"name":"Matt Greene","email":"m.greene@f5.com"},"change_message_id":"e2348dbc91419d80eb40ac00a08ae70a649305cb","unresolved":false,"context_lines":[{"line_number":375,"context_line":"Other end user impact"},{"line_number":376,"context_line":"---------------------"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"An existing LB cannot be updated with a different flavor.  A flavor can"},{"line_number":379,"context_line":"only be applied upon the creation of the LB.  However it is possible that a"},{"line_number":380,"context_line":"LB is created with a particular flavor and then thereafter the flavor is"},{"line_number":381,"context_line":"updated.  Timestamps will be applied to any flavor update so that users can"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f231b9d_9775fb66","line":378,"in_reply_to":"7f231b9d_c011725f","updated":"2017-06-14 21:03:58.000000000","message":"Does this literally mean the flavor, the flavor profile, or both?  It seems that the flavor_profile_id is the FK for the LB, so cannot change. \n But can the underlying flavor_id and/or provider_id change?  Or perhaps just the meta or key/values contained within the flavor or provider table?","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":22733,"name":"Carlos Puga","email":"carlpuga@gmail.com","username":"carlpuga"},"change_message_id":"28375e4e468a6158a9c3e343412d2bedc79cf1a8","unresolved":false,"context_lines":[{"line_number":375,"context_line":"Other end user impact"},{"line_number":376,"context_line":"---------------------"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"An existing LB cannot be updated with a different flavor.  A flavor can"},{"line_number":379,"context_line":"only be applied upon the creation of the LB.  However it is possible that a"},{"line_number":380,"context_line":"LB is created with a particular flavor and then thereafter the flavor is"},{"line_number":381,"context_line":"updated.  Timestamps will be applied to any flavor update so that users can"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f231b9d_32df55d7","line":378,"in_reply_to":"7f231b9d_c011725f","updated":"2017-06-14 22:44:47.000000000","message":"k, I\u0027ll read through it. thx.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"c990ed4bad3bd3a2d5d7239a3b976dc2b34362d8","unresolved":false,"context_lines":[{"line_number":379,"context_line":"only be applied upon the creation of the LB.  However it is possible that a"},{"line_number":380,"context_line":"LB is created with a particular flavor and then thereafter the flavor is"},{"line_number":381,"context_line":"updated.  Timestamps will be applied to any flavor update so that users can"},{"line_number":382,"context_line":"identify if the LB is no longer in sync with original flavor definition."},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"Performance Impact"},{"line_number":385,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f231b9d_00652a1e","line":382,"updated":"2017-06-14 16:30:09.000000000","message":"what happens if a flavor is deleted and we still have LBs running with that flavor?","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":25279,"name":"Matt Greene","email":"m.greene@f5.com"},"change_message_id":"e2348dbc91419d80eb40ac00a08ae70a649305cb","unresolved":false,"context_lines":[{"line_number":379,"context_line":"only be applied upon the creation of the LB.  However it is possible that a"},{"line_number":380,"context_line":"LB is created with a particular flavor and then thereafter the flavor is"},{"line_number":381,"context_line":"updated.  Timestamps will be applied to any flavor update so that users can"},{"line_number":382,"context_line":"identify if the LB is no longer in sync with original flavor definition."},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"Performance Impact"},{"line_number":385,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f231b9d_97fa9bba","line":382,"in_reply_to":"7f231b9d_00652a1e","updated":"2017-06-14 21:03:58.000000000","message":"Same question for provider.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":22733,"name":"Carlos Puga","email":"carlpuga@gmail.com","username":"carlpuga"},"change_message_id":"28375e4e468a6158a9c3e343412d2bedc79cf1a8","unresolved":false,"context_lines":[{"line_number":379,"context_line":"only be applied upon the creation of the LB.  However it is possible that a"},{"line_number":380,"context_line":"LB is created with a particular flavor and then thereafter the flavor is"},{"line_number":381,"context_line":"updated.  Timestamps will be applied to any flavor update so that users can"},{"line_number":382,"context_line":"identify if the LB is no longer in sync with original flavor definition."},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"Performance Impact"},{"line_number":385,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f231b9d_328d15d3","line":382,"in_reply_to":"7f231b9d_00652a1e","updated":"2017-06-14 22:44:47.000000000","message":"The flavor couldn\u0027t be deleted because it would have a foreign key constraint.  However assuming it could happen then the behavior would be similar to that of when a glance image is deleted, the lb would continue to run.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ac87620a4bfc713f13b30f1508bc7f8618e4a94c","unresolved":false,"context_lines":[{"line_number":379,"context_line":"only be applied upon the creation of the LB.  However it is possible that a"},{"line_number":380,"context_line":"LB is created with a particular flavor and then thereafter the flavor is"},{"line_number":381,"context_line":"updated.  Timestamps will be applied to any flavor update so that users can"},{"line_number":382,"context_line":"identify if the LB is no longer in sync with original flavor definition."},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"Performance Impact"},{"line_number":385,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_203bf838","line":382,"in_reply_to":"7f231b9d_74525ae0","updated":"2017-06-29 16:35:10.000000000","message":"This is clarity around flavor profile ID vs. flavor.  LB should be tied to immutable flavor profile ID.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":22733,"name":"Carlos Puga","email":"carlpuga@gmail.com","username":"carlpuga"},"change_message_id":"28375e4e468a6158a9c3e343412d2bedc79cf1a8","unresolved":false,"context_lines":[{"line_number":379,"context_line":"only be applied upon the creation of the LB.  However it is possible that a"},{"line_number":380,"context_line":"LB is created with a particular flavor and then thereafter the flavor is"},{"line_number":381,"context_line":"updated.  Timestamps will be applied to any flavor update so that users can"},{"line_number":382,"context_line":"identify if the LB is no longer in sync with original flavor definition."},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"Performance Impact"},{"line_number":385,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7f231b9d_74525ae0","line":382,"in_reply_to":"7f231b9d_97fa9bba","updated":"2017-06-14 22:44:47.000000000","message":"the provider also has the foreign key constraint as flavors.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cea0b65a1dc4b174afee3e5dcf02da092315f45b","unresolved":false,"context_lines":[{"line_number":415,"context_line":"This proposal allows operators to offer services beyond those"},{"line_number":416,"context_line":"directly implemented, and to do so in a way that does not increase"},{"line_number":417,"context_line":"community maintenance or burden."},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"Implementation"},{"line_number":420,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":421,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_20709872","line":418,"updated":"2017-06-29 16:27:43.000000000","message":"We might want to have a \"provider driver impact\" section.\n\nPer today\u0027s discussion I can think of four items for that section:\n1. Be able to accept the flavor metadata\n2. Provide an interface to describe the available metadata options.\n3. Provide an interface to validate the flavor metadata.\n4. At create time, if a driver cannot support the previously validated flavor metadata it raises a \"not supported\" exception.  This is to account for driver updates that no longer support a previously loaded flavor metadata.","commit_id":"bf24b532ca16d30abf253b6a20e16baddfcb2320"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"388a76264efe73b9038637c21bac740db5d8c339","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"The Provider Flavor framework enables the ability to create distinct"},{"line_number":64,"context_line":"provider flavor profiles of supported parameters.  Operators will have the"},{"line_number":65,"context_line":"ability to query the provider driver interface for a list of supported"},{"line_number":66,"context_line":"parameters. Operators can view the said list by provider and create flavors"},{"line_number":67,"context_line":"by selecting one or many parameters from the list. The parameters that will"},{"line_number":68,"context_line":"be used to enable specific functionality will be json type in transit and"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f1d235d_6a6e78ca","line":65,"range":{"start_line":65,"start_character":61,"end_line":65,"end_character":70},"updated":"2017-07-07 19:00:43.000000000","message":"I think in our chat we talked about making the provider driver validate any setting the operator load up instead of exposing supported parameters.","commit_id":"d97bda6bd9fed4a8ecf744af3b1e54bf930a0899"},{"author":{"_account_id":22733,"name":"Carlos Puga","email":"carlpuga@gmail.com","username":"carlpuga"},"change_message_id":"3cde1d724041b1c54956e1ac4b21aa440d698660","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"The Provider Flavor framework enables the ability to create distinct"},{"line_number":64,"context_line":"provider flavor profiles of supported parameters.  Operators will have the"},{"line_number":65,"context_line":"ability to query the provider driver interface for a list of supported"},{"line_number":66,"context_line":"parameters. Operators can view the said list by provider and create flavors"},{"line_number":67,"context_line":"by selecting one or many parameters from the list. The parameters that will"},{"line_number":68,"context_line":"be used to enable specific functionality will be json type in transit and"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f1d235d_1b88466f","line":65,"range":{"start_line":65,"start_character":61,"end_line":65,"end_character":70},"in_reply_to":"3f1d235d_6a6e78ca","updated":"2017-07-10 19:45:18.000000000","message":"That is correct the provider driver will validate the settings uploaded but I also thought we spoke about having the provider driver expose the list of supported parameters.  Please let me know if I misunderstood.","commit_id":"d97bda6bd9fed4a8ecf744af3b1e54bf930a0899"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"388a76264efe73b9038637c21bac740db5d8c339","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"A sample use case of the operator flavor workflow would be the following:"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"* The operator queries the provider capabilities"},{"line_number":96,"context_line":"* The operator create profile"},{"line_number":97,"context_line":"* The operator uploads profile"},{"line_number":98,"context_line":"* The profile is validated with provider driver"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f1d235d_6aa31802","line":95,"updated":"2017-07-07 19:00:43.000000000","message":"wouldn\u0027t that be in the docs of the provider?","commit_id":"d97bda6bd9fed4a8ecf744af3b1e54bf930a0899"},{"author":{"_account_id":22733,"name":"Carlos Puga","email":"carlpuga@gmail.com","username":"carlpuga"},"change_message_id":"3cde1d724041b1c54956e1ac4b21aa440d698660","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"A sample use case of the operator flavor workflow would be the following:"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"* The operator queries the provider capabilities"},{"line_number":96,"context_line":"* The operator create profile"},{"line_number":97,"context_line":"* The operator uploads profile"},{"line_number":98,"context_line":"* The profile is validated with provider driver"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f1d235d_b620474b","line":95,"in_reply_to":"3f1d235d_6aa31802","updated":"2017-07-10 19:45:18.000000000","message":"The provider capabilities would be in the provider docs, but in addition to that I believe we said that the provider would expose their supported capabilities.  Please let me know if I misunderstood.","commit_id":"d97bda6bd9fed4a8ecf744af3b1e54bf930a0899"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"388a76264efe73b9038637c21bac740db5d8c339","unresolved":false,"context_lines":[{"line_number":97,"context_line":"* The operator uploads profile"},{"line_number":98,"context_line":"* The profile is validated with provider driver"},{"line_number":99,"context_line":"* The profile is stored in octavia db"},{"line_number":100,"context_line":"* The operator creates lb with flavor profile"},{"line_number":101,"context_line":"* The profile is validated against driver once again, upon every lb-create"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f1d235d_eab6083f","line":100,"range":{"start_line":100,"start_character":2,"end_line":100,"end_character":5},"updated":"2017-07-07 19:00:43.000000000","message":"usually end users create load balancer","commit_id":"d97bda6bd9fed4a8ecf744af3b1e54bf930a0899"},{"author":{"_account_id":22733,"name":"Carlos Puga","email":"carlpuga@gmail.com","username":"carlpuga"},"change_message_id":"3cde1d724041b1c54956e1ac4b21aa440d698660","unresolved":false,"context_lines":[{"line_number":97,"context_line":"* The operator uploads profile"},{"line_number":98,"context_line":"* The profile is validated with provider driver"},{"line_number":99,"context_line":"* The profile is stored in octavia db"},{"line_number":100,"context_line":"* The operator creates lb with flavor profile"},{"line_number":101,"context_line":"* The profile is validated against driver once again, upon every lb-create"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f1d235d_db2bee2d","line":100,"range":{"start_line":100,"start_character":2,"end_line":100,"end_character":5},"in_reply_to":"3f1d235d_eab6083f","updated":"2017-07-10 19:45:18.000000000","message":"Done","commit_id":"d97bda6bd9fed4a8ecf744af3b1e54bf930a0899"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"388a76264efe73b9038637c21bac740db5d8c339","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"DB table \u0027flavor\u0027 introduced to represent flavors.  The attribute"},{"line_number":153,"context_line":"lb_topology_name is added to this table given that a lb topology could"},{"line_number":154,"context_line":"apply to any flavor and/or provider.  It is a foreign key to the"},{"line_number":155,"context_line":"lb_topology table."},{"line_number":156,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f1d235d_aa5ed0e6","line":153,"range":{"start_line":153,"start_character":0,"end_line":153,"end_character":16},"updated":"2017-07-07 19:00:43.000000000","message":"I think we removed that?","commit_id":"d97bda6bd9fed4a8ecf744af3b1e54bf930a0899"},{"author":{"_account_id":22733,"name":"Carlos Puga","email":"carlpuga@gmail.com","username":"carlpuga"},"change_message_id":"3cde1d724041b1c54956e1ac4b21aa440d698660","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"DB table \u0027flavor\u0027 introduced to represent flavors.  The attribute"},{"line_number":153,"context_line":"lb_topology_name is added to this table given that a lb topology could"},{"line_number":154,"context_line":"apply to any flavor and/or provider.  It is a foreign key to the"},{"line_number":155,"context_line":"lb_topology table."},{"line_number":156,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f1d235d_9b1d7611","line":153,"range":{"start_line":153,"start_character":0,"end_line":153,"end_character":16},"in_reply_to":"3f1d235d_aa5ed0e6","updated":"2017-07-10 19:45:18.000000000","message":"Done","commit_id":"d97bda6bd9fed4a8ecf744af3b1e54bf930a0899"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"388a76264efe73b9038637c21bac740db5d8c339","unresolved":false,"context_lines":[{"line_number":195,"context_line":"|description      |string  |RO, all  |\u0027\u0027       |string      |human-readable|"},{"line_number":196,"context_line":"|                 |        |RW, admin|         |            |description   |"},{"line_number":197,"context_line":"+-----------------+--------+---------+---------+------------+--------------+"},{"line_number":198,"context_line":"|driver           |string  |RO, all  |\u0027\u0027       |string      |human-readable|"},{"line_number":199,"context_line":"|                 |        |RW, admin|         |            |driver        |"},{"line_number":200,"context_line":"+-----------------+--------+---------+---------+------------+--------------+"},{"line_number":201,"context_line":"|enabled          |bool    |RO, all  |true     |bool        |toggle        |"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f1d235d_4ae05cfb","line":198,"range":{"start_line":198,"start_character":61,"end_line":198,"end_character":66},"updated":"2017-07-07 19:00:43.000000000","message":"We probably want to out the stevedore name in it so better say \"system identifier name of the driver\" or so","commit_id":"d97bda6bd9fed4a8ecf744af3b1e54bf930a0899"},{"author":{"_account_id":22733,"name":"Carlos Puga","email":"carlpuga@gmail.com","username":"carlpuga"},"change_message_id":"3cde1d724041b1c54956e1ac4b21aa440d698660","unresolved":false,"context_lines":[{"line_number":195,"context_line":"|description      |string  |RO, all  |\u0027\u0027       |string      |human-readable|"},{"line_number":196,"context_line":"|                 |        |RW, admin|         |            |description   |"},{"line_number":197,"context_line":"+-----------------+--------+---------+---------+------------+--------------+"},{"line_number":198,"context_line":"|driver           |string  |RO, all  |\u0027\u0027       |string      |human-readable|"},{"line_number":199,"context_line":"|                 |        |RW, admin|         |            |driver        |"},{"line_number":200,"context_line":"+-----------------+--------+---------+---------+------------+--------------+"},{"line_number":201,"context_line":"|enabled          |bool    |RO, all  |true     |bool        |toggle        |"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f1d235d_1bc04650","line":198,"range":{"start_line":198,"start_character":61,"end_line":198,"end_character":66},"in_reply_to":"3f1d235d_4ae05cfb","updated":"2017-07-10 19:45:18.000000000","message":"Done","commit_id":"d97bda6bd9fed4a8ecf744af3b1e54bf930a0899"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"388a76264efe73b9038637c21bac740db5d8c339","unresolved":false,"context_lines":[{"line_number":233,"context_line":"|name             |string  |RO, all  |\u0027\u0027       |string      |human-readable |"},{"line_number":234,"context_line":"|                 |        |RW, admin|         |            |name           |"},{"line_number":235,"context_line":"+-----------------+--------+---------+---------+------------+---------------+"},{"line_number":236,"context_line":"|flavor           |flavor  |RO, all  |{}       |flavor      |json flavor    |"},{"line_number":237,"context_line":"|                 |        |RW, admin|         |            |object         |"},{"line_number":238,"context_line":"+-----------------+--------+---------+---------+------------+---------------+"},{"line_number":239,"context_line":"|provider         |provider|RO, all  |{}       |provider    |json provider  |"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f1d235d_aaba50de","line":236,"range":{"start_line":236,"start_character":1,"end_line":236,"end_character":7},"updated":"2017-07-07 19:00:43.000000000","message":"flavor-id?","commit_id":"d97bda6bd9fed4a8ecf744af3b1e54bf930a0899"},{"author":{"_account_id":22733,"name":"Carlos Puga","email":"carlpuga@gmail.com","username":"carlpuga"},"change_message_id":"3cde1d724041b1c54956e1ac4b21aa440d698660","unresolved":false,"context_lines":[{"line_number":233,"context_line":"|name             |string  |RO, all  |\u0027\u0027       |string      |human-readable |"},{"line_number":234,"context_line":"|                 |        |RW, admin|         |            |name           |"},{"line_number":235,"context_line":"+-----------------+--------+---------+---------+------------+---------------+"},{"line_number":236,"context_line":"|flavor           |flavor  |RO, all  |{}       |flavor      |json flavor    |"},{"line_number":237,"context_line":"|                 |        |RW, admin|         |            |object         |"},{"line_number":238,"context_line":"+-----------------+--------+---------+---------+------------+---------------+"},{"line_number":239,"context_line":"|provider         |provider|RO, all  |{}       |provider    |json provider  |"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f1d235d_7bc85a73","line":236,"range":{"start_line":236,"start_character":1,"end_line":236,"end_character":7},"in_reply_to":"3f1d235d_aaba50de","updated":"2017-07-10 19:45:18.000000000","message":"Done","commit_id":"d97bda6bd9fed4a8ecf744af3b1e54bf930a0899"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"388a76264efe73b9038637c21bac740db5d8c339","unresolved":false,"context_lines":[{"line_number":236,"context_line":"|flavor           |flavor  |RO, all  |{}       |flavor      |json flavor    |"},{"line_number":237,"context_line":"|                 |        |RW, admin|         |            |object         |"},{"line_number":238,"context_line":"+-----------------+--------+---------+---------+------------+---------------+"},{"line_number":239,"context_line":"|provider         |provider|RO, all  |{}       |provider    |json provider  |"},{"line_number":240,"context_line":"|                 |        |RW, admin|         |            |object         |"},{"line_number":241,"context_line":"+-----------------+--------+---------+---------+------------+---------------+"},{"line_number":242,"context_line":"|metadata         |string  |RO, all  |{}       |json        |flavor meta    |"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f1d235d_4ab97ce7","line":239,"range":{"start_line":239,"start_character":1,"end_line":239,"end_character":9},"updated":"2017-07-07 19:00:43.000000000","message":"provider-id?","commit_id":"d97bda6bd9fed4a8ecf744af3b1e54bf930a0899"},{"author":{"_account_id":22733,"name":"Carlos Puga","email":"carlpuga@gmail.com","username":"carlpuga"},"change_message_id":"3cde1d724041b1c54956e1ac4b21aa440d698660","unresolved":false,"context_lines":[{"line_number":236,"context_line":"|flavor           |flavor  |RO, all  |{}       |flavor      |json flavor    |"},{"line_number":237,"context_line":"|                 |        |RW, admin|         |            |object         |"},{"line_number":238,"context_line":"+-----------------+--------+---------+---------+------------+---------------+"},{"line_number":239,"context_line":"|provider         |provider|RO, all  |{}       |provider    |json provider  |"},{"line_number":240,"context_line":"|                 |        |RW, admin|         |            |object         |"},{"line_number":241,"context_line":"+-----------------+--------+---------+---------+------------+---------------+"},{"line_number":242,"context_line":"|metadata         |string  |RO, all  |{}       |json        |flavor meta    |"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f1d235d_5bc59e5a","line":239,"range":{"start_line":239,"start_character":1,"end_line":239,"end_character":9},"in_reply_to":"3f1d235d_4ab97ce7","updated":"2017-07-10 19:45:18.000000000","message":"Done","commit_id":"d97bda6bd9fed4a8ecf744af3b1e54bf930a0899"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"388a76264efe73b9038637c21bac740db5d8c339","unresolved":false,"context_lines":[{"line_number":325,"context_line":"* Implementation migration script for existing deployments."},{"line_number":326,"context_line":"* Ensure notifications for Ceilometer are available."},{"line_number":327,"context_line":"* Add client API support"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"Dependencies"},{"line_number":330,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":331,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f1d235d_2a7c001f","line":328,"updated":"2017-07-07 19:00:43.000000000","message":"Add policies to the Octavia RBAC system (I assume most of the flavor API should be admin only)","commit_id":"d97bda6bd9fed4a8ecf744af3b1e54bf930a0899"},{"author":{"_account_id":22733,"name":"Carlos Puga","email":"carlpuga@gmail.com","username":"carlpuga"},"change_message_id":"3cde1d724041b1c54956e1ac4b21aa440d698660","unresolved":false,"context_lines":[{"line_number":325,"context_line":"* Implementation migration script for existing deployments."},{"line_number":326,"context_line":"* Ensure notifications for Ceilometer are available."},{"line_number":327,"context_line":"* Add client API support"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"Dependencies"},{"line_number":330,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":331,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f1d235d_5ba7de50","line":328,"in_reply_to":"3f1d235d_2a7c001f","updated":"2017-07-10 19:45:18.000000000","message":"Done","commit_id":"d97bda6bd9fed4a8ecf744af3b1e54bf930a0899"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"388a76264efe73b9038637c21bac740db5d8c339","unresolved":false,"context_lines":[{"line_number":355,"context_line":"User Documentation"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"User documentation will need be included to describe to users how to use"},{"line_number":358,"context_line":"flavors when building their logical topology. Operator documentation will"},{"line_number":359,"context_line":"need to be created to detail how to manage Flavors and Provides Profiles."},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"Developer Documentation"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f1d235d_ea9cc86b","line":358,"updated":"2017-07-07 19:00:43.000000000","message":"NIT new line. We have different operator and user docs so should be different lines.","commit_id":"d97bda6bd9fed4a8ecf744af3b1e54bf930a0899"},{"author":{"_account_id":22733,"name":"Carlos Puga","email":"carlpuga@gmail.com","username":"carlpuga"},"change_message_id":"3cde1d724041b1c54956e1ac4b21aa440d698660","unresolved":false,"context_lines":[{"line_number":355,"context_line":"User Documentation"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"User documentation will need be included to describe to users how to use"},{"line_number":358,"context_line":"flavors when building their logical topology. Operator documentation will"},{"line_number":359,"context_line":"need to be created to detail how to manage Flavors and Provides Profiles."},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"Developer Documentation"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f1d235d_1b99661e","line":358,"in_reply_to":"3f1d235d_ea9cc86b","updated":"2017-07-10 19:45:18.000000000","message":"Done","commit_id":"d97bda6bd9fed4a8ecf744af3b1e54bf930a0899"}]}
