)]}'
{"octavia/common/policy.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ff171a0b4b893ecc10cb467bb7e74933f5691f3e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                          \u0027credentials %(credentials)s\u0027,"},{"line_number":102,"context_line":"                          {\u0027action\u0027: action, \u0027credentials\u0027: credentials})"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def check_is_admin(self, context):"},{"line_number":105,"context_line":"        \"\"\"Does roles contains \u0027admin\u0027 role according to policy setting."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_94eaa772","line":104,"updated":"2016-12-06 18:28:04.000000000","message":"Missing unit test for this method","commit_id":"e996630b9c1e44c0c5e7375eb7d58161614b3135"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"185a3d500e4c1c6ab09aab5f9f9bf1696054f42d","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                          \u0027credentials %(credentials)s\u0027,"},{"line_number":102,"context_line":"                          {\u0027action\u0027: action, \u0027credentials\u0027: credentials})"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def check_is_admin(self, context):"},{"line_number":105,"context_line":"        \"\"\"Does roles contains \u0027admin\u0027 role according to policy setting."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_83c9535d","line":104,"in_reply_to":"3a71b18c_94eaa772","updated":"2016-12-07 20:38:11.000000000","message":"Done","commit_id":"e996630b9c1e44c0c5e7375eb7d58161614b3135"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ff171a0b4b893ecc10cb467bb7e74933f5691f3e","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    def __init__(self, kind, match):"},{"line_number":121,"context_line":"        \"\"\"Initialize the check.\"\"\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        self.expected \u003d (match.lower() \u003d\u003d \u0027true\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        super(IsAdminCheck, self).__init__(kind, str(self.expected))"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_54664f51","line":123,"updated":"2016-12-06 18:28:04.000000000","message":"nit: These parentheses are not needed","commit_id":"e996630b9c1e44c0c5e7375eb7d58161614b3135"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"185a3d500e4c1c6ab09aab5f9f9bf1696054f42d","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    def __init__(self, kind, match):"},{"line_number":121,"context_line":"        \"\"\"Initialize the check.\"\"\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        self.expected \u003d (match.lower() \u003d\u003d \u0027true\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        super(IsAdminCheck, self).__init__(kind, str(self.expected))"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_a3c64f47","line":123,"in_reply_to":"3a71b18c_54664f51","updated":"2016-12-07 20:38:11.000000000","message":"Done","commit_id":"e996630b9c1e44c0c5e7375eb7d58161614b3135"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"7494bd934caf8f9e8a4da149062388ea76c20e13","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            :param use_conf: Whether to load rules from cache or config file."},{"line_number":49,"context_line":"            :param overwrite: Whether to overwrite existing rules when reload"},{"line_number":50,"context_line":"                              rules from config file."},{"line_number":51,"context_line":"        \"\"\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        super(Policy, self).__init__(conf, policy_file, rules, default_rule,"},{"line_number":54,"context_line":"                                     use_conf, overwrite)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_08e0c5f9","line":51,"updated":"2016-12-08 23:41:58.000000000","message":"good code comments!","commit_id":"024ceb946523f89a014bdc29cabf6d994dad16e3"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"2f6b42571a4e0cb9f1c7be1fc6c23552a08dd682","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.context \u003d context"},{"line_number":56,"context_line":"        self.register_defaults(policies.list_rules())"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def authorize(self, action, target, do_raise\u003dTrue, exc\u003dNone):"},{"line_number":59,"context_line":"        \"\"\"Verifies that the action is valid on the target in this context."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"           :param context: nova context"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_00ab6b75","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":65},"updated":"2016-12-13 09:53:21.000000000","message":"You should change the function signature to match the inherited[1] one, so it won\u0027t break the API.\n\nhttps://github.com/openstack/oslo.policy/blob/master/oslo_policy/policy.py#L763-L764","commit_id":"024ceb946523f89a014bdc29cabf6d994dad16e3"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"c65ba7c331b85e3303c9882a99fed88df3b972f7","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.context \u003d context"},{"line_number":56,"context_line":"        self.register_defaults(policies.list_rules())"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def authorize(self, action, target, do_raise\u003dTrue, exc\u003dNone):"},{"line_number":59,"context_line":"        \"\"\"Verifies that the action is valid on the target in this context."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"           :param context: nova context"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_cebc82de","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":65},"in_reply_to":"1a6eadb0_00ab6b75","updated":"2016-12-16 17:15:19.000000000","message":"I\u0027m breaking API because:\n1. I\u0027m not planning to expose publicly that this is policy.Enforcer class\n2. I\u0027m making it class optimized and to work with our code base in more natural way. This context is already specified and no one should remember that we need to specify that parameter","commit_id":"024ceb946523f89a014bdc29cabf6d994dad16e3"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"5daaf33e5f11f80d79d7a1160729dc004ab0843a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.context \u003d context"},{"line_number":56,"context_line":"        self.register_defaults(policies.list_rules())"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def authorize(self, action, target, do_raise\u003dTrue, exc\u003dNone):"},{"line_number":59,"context_line":"        \"\"\"Verifies that the action is valid on the target in this context."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"           :param context: nova context"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_8c55c4c7","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":65},"in_reply_to":"1a6eadb0_cebc82de","updated":"2016-12-20 11:18:34.000000000","message":"So, perhaps a proxy function can bridge that gap?","commit_id":"024ceb946523f89a014bdc29cabf6d994dad16e3"}],"octavia/common/singleton.py":[{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"2f6b42571a4e0cb9f1c7be1fc6c23552a08dd682","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class SingletonDecorator:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    def __init__(self, _class):"},{"line_number":20,"context_line":"        self._class \u003d _class"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_8cd177d0","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":25},"updated":"2016-12-13 09:53:21.000000000","message":"where is this being used?","commit_id":"024ceb946523f89a014bdc29cabf6d994dad16e3"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"c65ba7c331b85e3303c9882a99fed88df3b972f7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class SingletonDecorator:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    def __init__(self, _class):"},{"line_number":20,"context_line":"        self._class \u003d _class"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_eea69ebf","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":25},"in_reply_to":"1a6eadb0_8cd177d0","updated":"2016-12-16 17:15:19.000000000","message":"I changed my mind about how to implement policy enforcement. Removed.","commit_id":"024ceb946523f89a014bdc29cabf6d994dad16e3"}],"octavia/policies/__init__.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3ed4d1648d1cda466617f2d136a89a9af4539888","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ba5201f7_85f7a9d1","updated":"2017-01-08 01:57:14.000000000","message":"I am not a fan of code in the __init__.py, but since this is \"common\" code from OpenStack I won\u0027t bark too loud.","commit_id":"c7cebf77ae09aedb5a42d1008509562ba1e41de7"}]}
