)]}'
{"octavia/controller/healthmanager/update_db.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"a7c19b5a0c8d3fe51a6d3cc2093bb9e28d71d0c5","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    def __init__(self):"},{"line_number":222,"context_line":"        super(UpdateStatsDb, self).__init__()"},{"line_number":223,"context_line":"        self.event_streamer \u003d event_queue.EventStreamerNeutron()"},{"line_number":224,"context_line":"        self.event_notifier \u003d event_queue.EventStreamerNotifier()"},{"line_number":225,"context_line":"        self.repo_listener \u003d repo.ListenerRepository()"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def emit(self, info_type, info_id, info_obj):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_7d45546e","line":224,"updated":"2016-12-14 16:56:35.000000000","message":"please make this configurable to be switched off or provide a dummy driver which doesn\u0027t do anything so installations not needing this can switch it off","commit_id":"7d8180026e3e11fef2a4296642eeccee9b4ee139"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"ce2cc1f251c520df6e100c7e4d9c5737d17aa176","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    def __init__(self):"},{"line_number":222,"context_line":"        super(UpdateStatsDb, self).__init__()"},{"line_number":223,"context_line":"        self.event_streamer \u003d event_queue.EventStreamerNeutron()"},{"line_number":224,"context_line":"        self.event_notifier \u003d event_queue.EventStreamerNotifier()"},{"line_number":225,"context_line":"        self.repo_listener \u003d repo.ListenerRepository()"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def emit(self, info_type, info_id, info_obj):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_adb70087","line":224,"in_reply_to":"1a6eadb0_7d45546e","updated":"2017-06-29 17:50:56.000000000","message":"This was due to a bug that has actually been fixed in another patch now -- fixing this should be obvious when rebasing. I can see why this was done in an attempt to match, it\u0027s unfortunate this was done incorrectly in the first place!","commit_id":"7d8180026e3e11fef2a4296642eeccee9b4ee139"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"a7c19b5a0c8d3fe51a6d3cc2093bb9e28d71d0c5","unresolved":false,"context_lines":[{"line_number":227,"context_line":"    def emit(self, info_type, info_id, info_obj):"},{"line_number":228,"context_line":"        cnt \u003d update_serializer.InfoContainer(info_type, info_id, info_obj)"},{"line_number":229,"context_line":"        self.event_streamer.emit(cnt)"},{"line_number":230,"context_line":"        self.event_notifier.emit(cnt)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def update_stats(self, health_message):"},{"line_number":233,"context_line":"        \"\"\"This function is to update the db with listener stats"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_50515f0d","line":230,"updated":"2016-12-14 16:56:35.000000000","message":"The Oslo documentation says: Notification messages are sent ‘at-most-once’ - ensuring that they are not duplicated. (see http://docs.openstack.org/developer/oslo.messaging/notification_driver.html) so I am wondering if this will actually do what we want. Consider it sending a member-down, then a member-up, and another member-down - would that be registered? Was this tested?","commit_id":"7d8180026e3e11fef2a4296642eeccee9b4ee139"}],"octavia/controller/queue/event_queue.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"a7c19b5a0c8d3fe51a6d3cc2093bb9e28d71d0c5","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        self.publisher_id \u003d \u0027octavia\u0027"},{"line_number":86,"context_line":"        self.client \u003d oslo_messaging.Notifier(self.transport,"},{"line_number":87,"context_line":"                                              self.publisher_id,"},{"line_number":88,"context_line":"                                              driver\u003d\"messaging\", topic\u003dtopic)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def emit(self, cnt):"},{"line_number":91,"context_line":"        LOG.debug(\"Emitting event to listeners %s\", cnt.to_dict())"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_3dbd9c68","line":88,"updated":"2016-12-14 16:56:35.000000000","message":"please specify a retry (see http://docs.openstack.org/developer/oslo.messaging/notification_driver.html) - otherwise this thread will be stuck while we retry indefinitely in a queue outage","commit_id":"7d8180026e3e11fef2a4296642eeccee9b4ee139"}]}
