)]}'
{"octavia/api/v2/controllers/__init__.py":[{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"661d3f468eb297cec56041621e5615a94ab4444c","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class BaseV2Controller(base.BaseController):"},{"line_number":24,"context_line":"    loadbalancers \u003d load_balancer.LoadBalancersController()"},{"line_number":25,"context_line":"    pools \u003d pool.PoolsController()"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @wsme_pecan.wsexpose(wtypes.text)"}],"source_content_type":"text/x-python","patch_set":21,"id":"3a461143_95fab873","line":24,"updated":"2017-01-30 17:05:05.000000000","message":"loadbalancers not needed anymore.....can be removed","commit_id":"5b814ca6a2e20412efd18c7d03cbcd762fdf3a1a"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"6e7de4ed4a6e071e649540781e46b3e0eccb2f70","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class BaseV2Controller(base.BaseController):"},{"line_number":24,"context_line":"    loadbalancers \u003d load_balancer.LoadBalancersController()"},{"line_number":25,"context_line":"    pools \u003d pool.PoolsController()"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @wsme_pecan.wsexpose(wtypes.text)"}],"source_content_type":"text/x-python","patch_set":21,"id":"3a461143_c89ade6d","line":24,"in_reply_to":"3a461143_95fab873","updated":"2017-01-30 22:34:13.000000000","message":"Done","commit_id":"5b814ca6a2e20412efd18c7d03cbcd762fdf3a1a"}],"octavia/api/v2/controllers/pool.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"8f763bdd3d6761a194e141b5b077c2919b4ee204","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        pool \u003d pool_.pool"},{"line_number":128,"context_line":"        context \u003d pecan.request.context.get(\u0027octavia_context\u0027)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        lock_session \u003d db_api.get_session(autocommit\u003dFalse)"},{"line_number":131,"context_line":"        if self.repositories.check_quota_met("},{"line_number":132,"context_line":"                context.session,"},{"line_number":133,"context_line":"                lock_session,"}],"source_content_type":"text/x-python","patch_set":41,"id":"1a1ced50_444a7556","line":130,"updated":"2017-03-21 15:50:45.000000000","message":"Before we call check_quota_met, we need to have gotten the project_id from the token. See how this was done in the listener code.","commit_id":"65ce43341eb799fd72001e8773687fbc2d5ca74e"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"5124f05384d6a04eb35e8713d1a9247074f928f6","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        pool \u003d pool_.pool"},{"line_number":128,"context_line":"        context \u003d pecan.request.context.get(\u0027octavia_context\u0027)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        lock_session \u003d db_api.get_session(autocommit\u003dFalse)"},{"line_number":131,"context_line":"        if self.repositories.check_quota_met("},{"line_number":132,"context_line":"                context.session,"},{"line_number":133,"context_line":"                lock_session,"}],"source_content_type":"text/x-python","patch_set":41,"id":"1a1ced50_e4a2814a","line":130,"in_reply_to":"1a1ced50_444a7556","updated":"2017-03-21 16:02:22.000000000","message":"Scratch that, check the loadbalancer code, listeners is missing quotas completely, including project_id here, and just isn\u0027t hitting this bug. T_T","commit_id":"65ce43341eb799fd72001e8773687fbc2d5ca74e"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"003493bba77a421277a04dcfca167d2da55faa06","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        pool \u003d pool_.pool"},{"line_number":128,"context_line":"        context \u003d pecan.request.context.get(\u0027octavia_context\u0027)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        lock_session \u003d db_api.get_session(autocommit\u003dFalse)"},{"line_number":131,"context_line":"        if self.repositories.check_quota_met("},{"line_number":132,"context_line":"                context.session,"},{"line_number":133,"context_line":"                lock_session,"}],"source_content_type":"text/x-python","patch_set":41,"id":"1a1ced50_b6534d16","line":130,"in_reply_to":"1a1ced50_e4a2814a","updated":"2017-03-21 22:38:18.000000000","message":"I have added comments. It needs to be uncommented when _get_lb_project_id() is made available in v2 base.","commit_id":"65ce43341eb799fd72001e8773687fbc2d5ca74e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f42e82c86fbf3546ec024678a6ba9de392c437dc","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            LOG.info(_LI(\"Sending Creation of Pool %s to handler\"),"},{"line_number":104,"context_line":"                     db_pool.id)"},{"line_number":105,"context_line":"            self.handler.create(db_pool)"},{"line_number":106,"context_line":"        except Exception:"},{"line_number":107,"context_line":"            for listener_id in self._get_affected_listener_ids(db_pool):"},{"line_number":108,"context_line":"                with excutils.save_and_reraise_exception(reraise\u003dFalse):"},{"line_number":109,"context_line":"                    self.repositories.listener.update("}],"source_content_type":"text/x-python","patch_set":50,"id":"ffe62b97_e73b86e8","line":106,"updated":"2017-03-27 15:25:25.000000000","message":"We should be setting pool provisioning status to ERROR here.  Otherwise the pool will be stuck in pending create.","commit_id":"5b17faba9ad65b3f913b2fcc761b4905cc1ac436"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"afa20716ab1f30d5bf7197041f13bd9d9b2caa5c","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            LOG.info(_LI(\"Sending Creation of Pool %s to handler\"),"},{"line_number":104,"context_line":"                     db_pool.id)"},{"line_number":105,"context_line":"            self.handler.create(db_pool)"},{"line_number":106,"context_line":"        except Exception:"},{"line_number":107,"context_line":"            for listener_id in self._get_affected_listener_ids(db_pool):"},{"line_number":108,"context_line":"                with excutils.save_and_reraise_exception(reraise\u003dFalse):"},{"line_number":109,"context_line":"                    self.repositories.listener.update("}],"source_content_type":"text/x-python","patch_set":50,"id":"ffe62b97_1906cdcf","line":106,"in_reply_to":"ffe62b97_e73b86e8","updated":"2017-03-27 16:47:24.000000000","message":"Yeah I\u0027m fixing this whole section.","commit_id":"5b17faba9ad65b3f913b2fcc761b4905cc1ac436"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f42e82c86fbf3546ec024678a6ba9de392c437dc","unresolved":false,"context_lines":[{"line_number":189,"context_line":"                        operating_status\u003dconstants.ERROR)"},{"line_number":190,"context_line":"                self.repositories.pool.update("},{"line_number":191,"context_line":"                    context.session, db_pool.id,"},{"line_number":192,"context_line":"                    operating_status\u003dconstants.ERROR)"},{"line_number":193,"context_line":"        db_pool \u003d self._get_db_pool(context.session, id)"},{"line_number":194,"context_line":"        result \u003d self._convert_db_to_type(db_pool, pool_types.PoolResponse)"},{"line_number":195,"context_line":"        return pool_types.PoolRootResponse(pool\u003dresult)"}],"source_content_type":"text/x-python","patch_set":50,"id":"ffe62b97_8a65e1e3","line":192,"range":{"start_line":192,"start_character":20,"end_line":192,"end_character":36},"updated":"2017-03-27 15:25:25.000000000","message":"This should be provisioning status.","commit_id":"5b17faba9ad65b3f913b2fcc761b4905cc1ac436"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"afa20716ab1f30d5bf7197041f13bd9d9b2caa5c","unresolved":false,"context_lines":[{"line_number":189,"context_line":"                        operating_status\u003dconstants.ERROR)"},{"line_number":190,"context_line":"                self.repositories.pool.update("},{"line_number":191,"context_line":"                    context.session, db_pool.id,"},{"line_number":192,"context_line":"                    operating_status\u003dconstants.ERROR)"},{"line_number":193,"context_line":"        db_pool \u003d self._get_db_pool(context.session, id)"},{"line_number":194,"context_line":"        result \u003d self._convert_db_to_type(db_pool, pool_types.PoolResponse)"},{"line_number":195,"context_line":"        return pool_types.PoolRootResponse(pool\u003dresult)"}],"source_content_type":"text/x-python","patch_set":50,"id":"ffe62b97_b9124108","line":192,"range":{"start_line":192,"start_character":20,"end_line":192,"end_character":36},"in_reply_to":"ffe62b97_8a65e1e3","updated":"2017-03-27 16:47:24.000000000","message":"Yep, ton of refactoring.","commit_id":"5b17faba9ad65b3f913b2fcc761b4905cc1ac436"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0911e07c2b9de6bfba8baab4de0ffb5bcc3b6551","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        pool \u003d pool_.pool"},{"line_number":143,"context_line":"        context \u003d pecan.request.context.get(\u0027octavia_context\u0027)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        pool.project_id \u003d self._get_lb_project_id(context.session,"},{"line_number":146,"context_line":"                                                  pool.loadbalancer_id)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        lock_session \u003d db_api.get_session(autocommit\u003dFalse)"},{"line_number":149,"context_line":"        if self.repositories.check_quota_met("}],"source_content_type":"text/x-python","patch_set":53,"id":"ffe62b97_8cc72b97","line":146,"range":{"start_line":145,"start_character":0,"end_line":146,"end_character":71},"updated":"2017-03-27 22:17:26.000000000","message":"We support creating a pool using only a listner_id as well as the loadbalancer_id option.\n\nThis causes a failure when only a listener_id is passed in and not a loadbalancer_id","commit_id":"79aba306981f2eed6587e1cb8f8e6151e834c444"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b280619b929c089e5f992975f1aa514c5413faf0","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        pool \u003d pool_.pool"},{"line_number":143,"context_line":"        context \u003d pecan.request.context.get(\u0027octavia_context\u0027)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        pool.project_id \u003d self._get_lb_project_id(context.session,"},{"line_number":146,"context_line":"                                                  pool.loadbalancer_id)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        lock_session \u003d db_api.get_session(autocommit\u003dFalse)"},{"line_number":149,"context_line":"        if self.repositories.check_quota_met("}],"source_content_type":"text/x-python","patch_set":53,"id":"ffe62b97_6cce2783","line":146,"range":{"start_line":145,"start_character":0,"end_line":146,"end_character":71},"in_reply_to":"ffe62b97_8cc72b97","updated":"2017-03-27 22:40:23.000000000","message":"Done","commit_id":"79aba306981f2eed6587e1cb8f8e6151e834c444"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2910a8707a096265d6afea46df92b00a7a1d45f1","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        pool \u003d pool_.pool"},{"line_number":187,"context_line":"        context \u003d pecan.request.context.get(\u0027octavia_context\u0027)"},{"line_number":188,"context_line":"        db_pool \u003d self._get_db_pool(context.session, id)"},{"line_number":189,"context_line":"        self._test_lb_and_listener_statuses("},{"line_number":190,"context_line":"            context.session, lb_id\u003ddb_pool.load_balancer_id,"},{"line_number":191,"context_line":"            listener_ids\u003dself._get_affected_listener_ids(db_pool))"},{"line_number":192,"context_line":"        try:"},{"line_number":193,"context_line":"            LOG.info(_LI(\"Sending Update of Pool %s to handler\"), id)"},{"line_number":194,"context_line":"            self.handler.update(db_pool, pool)"}],"source_content_type":"text/x-python","patch_set":53,"id":"ffe62b97_cc59b38e","line":191,"range":{"start_line":189,"start_character":8,"end_line":191,"end_character":66},"updated":"2017-03-27 22:40:01.000000000","message":"The content returned from the PUT call has provisioning_status as \"ACTIVE\" instead of PENDING_UPDATE.","commit_id":"79aba306981f2eed6587e1cb8f8e6151e834c444"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"95999822a5c6136b91b0136a2969e919d66b048c","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        pool \u003d pool_.pool"},{"line_number":187,"context_line":"        context \u003d pecan.request.context.get(\u0027octavia_context\u0027)"},{"line_number":188,"context_line":"        db_pool \u003d self._get_db_pool(context.session, id)"},{"line_number":189,"context_line":"        self._test_lb_and_listener_statuses("},{"line_number":190,"context_line":"            context.session, lb_id\u003ddb_pool.load_balancer_id,"},{"line_number":191,"context_line":"            listener_ids\u003dself._get_affected_listener_ids(db_pool))"},{"line_number":192,"context_line":"        try:"},{"line_number":193,"context_line":"            LOG.info(_LI(\"Sending Update of Pool %s to handler\"), id)"},{"line_number":194,"context_line":"            self.handler.update(db_pool, pool)"}],"source_content_type":"text/x-python","patch_set":53,"id":"ffe62b97_e7349095","line":191,"range":{"start_line":189,"start_character":8,"end_line":191,"end_character":66},"in_reply_to":"ffe62b97_cc59b38e","updated":"2017-03-27 23:19:07.000000000","message":"Done","commit_id":"79aba306981f2eed6587e1cb8f8e6151e834c444"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"ed0e510184f14cbbd37e454abebb5191bf33f5eb","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                         \"Balancer is in an immutable state\"))"},{"line_number":77,"context_line":"            lb_repo \u003d self.repositories.load_balancer"},{"line_number":78,"context_line":"            db_lb \u003d lb_repo.get(session, id\u003dlb_id)"},{"line_number":79,"context_line":"            raise exceptions.ImmutableObject(resource\u003ddb_lb._name(),"},{"line_number":80,"context_line":"                                             id\u003dlb_id)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def _reset_lb_and_listener_statuses(self, session, lb_id, listener_ids):"}],"source_content_type":"text/x-python","patch_set":54,"id":"ffe62b97_466c06cd","line":79,"range":{"start_line":79,"start_character":54,"end_line":79,"end_character":67},"updated":"2017-03-29 15:31:12.000000000","message":"Using private object method can create a lot of problems in future.","commit_id":"5c991ad42550a1620fb39362a1e758525e3d5a35"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b5a730b2c8bafca5d51ec52a5a05bb2ff52b82ed","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                         \"Balancer is in an immutable state\"))"},{"line_number":77,"context_line":"            lb_repo \u003d self.repositories.load_balancer"},{"line_number":78,"context_line":"            db_lb \u003d lb_repo.get(session, id\u003dlb_id)"},{"line_number":79,"context_line":"            raise exceptions.ImmutableObject(resource\u003ddb_lb._name(),"},{"line_number":80,"context_line":"                                             id\u003dlb_id)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def _reset_lb_and_listener_statuses(self, session, lb_id, listener_ids):"}],"source_content_type":"text/x-python","patch_set":54,"id":"ffe62b97_efdd2ddd","line":79,"range":{"start_line":79,"start_character":54,"end_line":79,"end_character":67},"in_reply_to":"ffe62b97_466c06cd","updated":"2017-03-29 16:19:51.000000000","message":"Wait, why do we even do this? This isn\u0027t dynamic. We know it\u0027s a Load Balancer here... Obviously, since we bother to grab the load_balancer repo and pull one, it couldn\u0027t be anything else...\nThere is no point to even doing the two lines above this.\nGood catch.\n\nDone.","commit_id":"5c991ad42550a1620fb39362a1e758525e3d5a35"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"ed0e510184f14cbbd37e454abebb5191bf33f5eb","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    def _reset_lb_and_listener_statuses(self, session, lb_id, listener_ids):"},{"line_number":83,"context_line":"        # Setting LB + listeners back to active because this should be a"},{"line_number":84,"context_line":"        # recoverable error"},{"line_number":85,"context_line":"        self.repositories.load_balancer.update("},{"line_number":86,"context_line":"            session, lb_id,"},{"line_number":87,"context_line":"            provisioning_status\u003dconstants.ACTIVE)"},{"line_number":88,"context_line":"        for listener in listener_ids:"},{"line_number":89,"context_line":"            self.repositories.listener.update("},{"line_number":90,"context_line":"                session, listener,"},{"line_number":91,"context_line":"                provisioning_status\u003dconstants.ACTIVE)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def _validate_create_pool(self, lock_session, pool_dict, listener_id\u003dNone):"},{"line_number":94,"context_line":"        \"\"\"Validate creating pool on load balancer."}],"source_content_type":"text/x-python","patch_set":54,"id":"ffe62b97_06befefd","line":91,"range":{"start_line":85,"start_character":0,"end_line":91,"end_character":53},"updated":"2017-03-29 15:31:12.000000000","message":"Should be wrapped with non-autocommit db session.","commit_id":"5c991ad42550a1620fb39362a1e758525e3d5a35"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b5a730b2c8bafca5d51ec52a5a05bb2ff52b82ed","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    def _reset_lb_and_listener_statuses(self, session, lb_id, listener_ids):"},{"line_number":83,"context_line":"        # Setting LB + listeners back to active because this should be a"},{"line_number":84,"context_line":"        # recoverable error"},{"line_number":85,"context_line":"        self.repositories.load_balancer.update("},{"line_number":86,"context_line":"            session, lb_id,"},{"line_number":87,"context_line":"            provisioning_status\u003dconstants.ACTIVE)"},{"line_number":88,"context_line":"        for listener in listener_ids:"},{"line_number":89,"context_line":"            self.repositories.listener.update("},{"line_number":90,"context_line":"                session, listener,"},{"line_number":91,"context_line":"                provisioning_status\u003dconstants.ACTIVE)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def _validate_create_pool(self, lock_session, pool_dict, listener_id\u003dNone):"},{"line_number":94,"context_line":"        \"\"\"Validate creating pool on load balancer."}],"source_content_type":"text/x-python","patch_set":54,"id":"ffe62b97_ef708d42","line":91,"range":{"start_line":85,"start_character":0,"end_line":91,"end_character":53},"in_reply_to":"ffe62b97_06befefd","updated":"2017-03-29 16:19:51.000000000","message":"Done","commit_id":"5c991ad42550a1620fb39362a1e758525e3d5a35"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"5eb3c9395a7ba91823ee9e6e8a86516e9d63e04d","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        return pool_types.PoolRootResponse(pool\u003dresult)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    @pecan.expose()"},{"line_number":254,"context_line":"    def _lookup(self, pool_id, *remainder):"},{"line_number":255,"context_line":"        \"\"\"Overridden pecan _lookup method for custom routing."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        Verifies that the pool passed in the url exists, and if so decides"}],"source_content_type":"text/x-python","patch_set":54,"id":"ffe62b97_c4c28334","line":254,"updated":"2017-03-28 16:02:07.000000000","message":"lookup can be removed?","commit_id":"5c991ad42550a1620fb39362a1e758525e3d5a35"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"02b18eeaf6521d7ba9f1d4db63133fffa6b2bb9f","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        return pool_types.PoolRootResponse(pool\u003dresult)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    @pecan.expose()"},{"line_number":254,"context_line":"    def _lookup(self, pool_id, *remainder):"},{"line_number":255,"context_line":"        \"\"\"Overridden pecan _lookup method for custom routing."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        Verifies that the pool passed in the url exists, and if so decides"}],"source_content_type":"text/x-python","patch_set":54,"id":"ffe62b97_3cb0278a","line":254,"in_reply_to":"ffe62b97_3c7ca71d","updated":"2017-03-28 17:09:23.000000000","message":"Yes, I believe that is correct. This is the only entry-point for members.","commit_id":"5c991ad42550a1620fb39362a1e758525e3d5a35"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"df037e7b23c50459ed85f107da2281cadf26f764","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        return pool_types.PoolRootResponse(pool\u003dresult)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    @pecan.expose()"},{"line_number":254,"context_line":"    def _lookup(self, pool_id, *remainder):"},{"line_number":255,"context_line":"        \"\"\"Overridden pecan _lookup method for custom routing."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        Verifies that the pool passed in the url exists, and if so decides"}],"source_content_type":"text/x-python","patch_set":54,"id":"ffe62b97_3c7ca71d","line":254,"in_reply_to":"ffe62b97_c4c28334","updated":"2017-03-28 16:59:36.000000000","message":"Its required to find members and healthmonitors right?","commit_id":"5c991ad42550a1620fb39362a1e758525e3d5a35"}],"octavia/api/v2/types/pool.py":[{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"d7ca82d64e1cfc84d4073e8ad11f396ed2e3d62c","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from wsme import types as wtypes"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from octavia.api.common import types"},{"line_number":18,"context_line":"from octavia.api.v1.types import base"},{"line_number":19,"context_line":"from octavia.api.v1.types import health_monitor"},{"line_number":20,"context_line":"from octavia.api.v1.types import member"},{"line_number":21,"context_line":"from octavia.common import constants"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a461143_09b6f33c","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":37},"updated":"2017-01-27 16:13:51.000000000","message":"No need to use base from v1.types.\nYou can do something like: from octavia.api.common import types as base to keep the changes at minimum.","commit_id":"97672f4182c0c1905473437360cc925d5c412103"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"af67db37cfbe2fe70ec609f9f68820e04b8fd877","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    admin_state_up \u003d wtypes.wsattr(bool)"},{"line_number":53,"context_line":"    protocol \u003d wtypes.wsattr(wtypes.text)"},{"line_number":54,"context_line":"    lb_algorithm \u003d wtypes.wsattr(wtypes.text)"},{"line_number":55,"context_line":"    session_persistence \u003d wtypes.wsattr(SessionPersistenceResponse)"},{"line_number":56,"context_line":"    project_id \u003d wtypes.wsattr(wtypes.StringType())"},{"line_number":57,"context_line":"    health_monitor \u003d wtypes.wsattr(health_monitor.HealthMonitorResponse)"},{"line_number":58,"context_line":"    members \u003d wtypes.wsattr([member.MemberResponse])"}],"source_content_type":"text/x-python","patch_set":23,"id":"3a461143_61df203a","line":55,"updated":"2017-01-31 18:58:05.000000000","message":"health_monitors\nhealth_monitors_status\nprovider\nstatus\nstatus_description\n\nas per http://developer.openstack.org/api-ref/networking/v2/?expanded\u003dlist-pools-detail\n\nPlus the other attrs octavia stores","commit_id":"39f928500c9df26646df7f0c37353f3d39191390"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"8ed165da3ba6852ba9f3b532c5c63b32bc6923a2","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    admin_state_up \u003d wtypes.wsattr(bool)"},{"line_number":53,"context_line":"    protocol \u003d wtypes.wsattr(wtypes.text)"},{"line_number":54,"context_line":"    lb_algorithm \u003d wtypes.wsattr(wtypes.text)"},{"line_number":55,"context_line":"    session_persistence \u003d wtypes.wsattr(SessionPersistenceResponse)"},{"line_number":56,"context_line":"    project_id \u003d wtypes.wsattr(wtypes.StringType())"},{"line_number":57,"context_line":"    health_monitor \u003d wtypes.wsattr(health_monitor.HealthMonitorResponse)"},{"line_number":58,"context_line":"    members \u003d wtypes.wsattr([member.MemberResponse])"}],"source_content_type":"text/x-python","patch_set":23,"id":"3a461143_647b802a","line":55,"in_reply_to":"3a461143_61df203a","updated":"2017-02-01 19:54:09.000000000","message":"Done","commit_id":"39f928500c9df26646df7f0c37353f3d39191390"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"01fca0c1d23dcda463b79b105e8b35afc1cd3204","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    description \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d255))"},{"line_number":128,"context_line":"    admin_state_up \u003d wtypes.wsattr(bool, default\u003dTrue)"},{"line_number":129,"context_line":"    listener_id \u003d wtypes.wsattr(wtypes.UuidType())"},{"line_number":130,"context_line":"    load_balancer_id \u003d wtypes.wsattr(wtypes.UuidType(), mandatory\u003dTrue)"},{"line_number":131,"context_line":"    protocol \u003d wtypes.wsattr(wtypes.Enum(str, *constants.SUPPORTED_PROTOCOLS),"},{"line_number":132,"context_line":"                             mandatory\u003dTrue)"},{"line_number":133,"context_line":"    lb_algorithm \u003d wtypes.wsattr("}],"source_content_type":"text/x-python","patch_set":41,"id":"1a1ced50_3a9bd373","line":130,"updated":"2017-03-21 15:08:25.000000000","message":"Similarly to my comment on the Listeners patch, this needs to be \"loadbalancer_id\" to match neutron-lbaas. One less underscore.\n\nThe docs page is unfortunately a bit broken and doesn\u0027t list it, but it is consistent with the listeners parameter name.","commit_id":"65ce43341eb799fd72001e8773687fbc2d5ca74e"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"25489e7f9a71102545fceea5fecd3b3c5768dd2c","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    description \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d255))"},{"line_number":128,"context_line":"    admin_state_up \u003d wtypes.wsattr(bool, default\u003dTrue)"},{"line_number":129,"context_line":"    listener_id \u003d wtypes.wsattr(wtypes.UuidType())"},{"line_number":130,"context_line":"    load_balancer_id \u003d wtypes.wsattr(wtypes.UuidType(), mandatory\u003dTrue)"},{"line_number":131,"context_line":"    protocol \u003d wtypes.wsattr(wtypes.Enum(str, *constants.SUPPORTED_PROTOCOLS),"},{"line_number":132,"context_line":"                             mandatory\u003dTrue)"},{"line_number":133,"context_line":"    lb_algorithm \u003d wtypes.wsattr("}],"source_content_type":"text/x-python","patch_set":41,"id":"1a1ced50_d139c5f3","line":130,"in_reply_to":"1a1ced50_3a9bd373","updated":"2017-03-21 15:49:05.000000000","message":"Ah, also this should not be mandatory (it is not in neutron-lbaas).","commit_id":"65ce43341eb799fd72001e8773687fbc2d5ca74e"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"003493bba77a421277a04dcfca167d2da55faa06","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    description \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d255))"},{"line_number":128,"context_line":"    admin_state_up \u003d wtypes.wsattr(bool, default\u003dTrue)"},{"line_number":129,"context_line":"    listener_id \u003d wtypes.wsattr(wtypes.UuidType())"},{"line_number":130,"context_line":"    load_balancer_id \u003d wtypes.wsattr(wtypes.UuidType(), mandatory\u003dTrue)"},{"line_number":131,"context_line":"    protocol \u003d wtypes.wsattr(wtypes.Enum(str, *constants.SUPPORTED_PROTOCOLS),"},{"line_number":132,"context_line":"                             mandatory\u003dTrue)"},{"line_number":133,"context_line":"    lb_algorithm \u003d wtypes.wsattr("}],"source_content_type":"text/x-python","patch_set":41,"id":"1a1ced50_230e413b","line":130,"in_reply_to":"1a1ced50_d139c5f3","updated":"2017-03-21 22:38:18.000000000","message":"Done","commit_id":"65ce43341eb799fd72001e8773687fbc2d5ca74e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b17d3fad6940a10c27f026c516b08d3a92f6d46b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    protocol \u003d wtypes.wsattr(wtypes.text)"},{"line_number":64,"context_line":"    lb_algorithm \u003d wtypes.wsattr(wtypes.text)"},{"line_number":65,"context_line":"    session_persistence \u003d wtypes.wsattr(SessionPersistenceResponse)"},{"line_number":66,"context_line":"    tenant_id \u003d wtypes.wsattr(wtypes.StringType())"},{"line_number":67,"context_line":"    loadbalancers \u003d wtypes.wsattr([MinimalLoadBalancer])"},{"line_number":68,"context_line":"    listeners \u003d wtypes.wsattr([MinimalListener])"},{"line_number":69,"context_line":"    created_at \u003d wtypes.wsattr(wtypes.datetime.datetime)"}],"source_content_type":"text/x-python","patch_set":52,"id":"ffe62b97_8696ea4b","line":66,"range":{"start_line":66,"start_character":4,"end_line":66,"end_character":50},"updated":"2017-03-27 21:25:16.000000000","message":"project_id is missing here.\nPlus tag both with:\n# TODO(johnsom) Remove after deprecation (R series)","commit_id":"208b05d53916bba46ce9bcba750bbd6f98ccb8c6"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"5983ba0775eaaf3efe2473d7fa572a6769463c65","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    protocol \u003d wtypes.wsattr(wtypes.text)"},{"line_number":64,"context_line":"    lb_algorithm \u003d wtypes.wsattr(wtypes.text)"},{"line_number":65,"context_line":"    session_persistence \u003d wtypes.wsattr(SessionPersistenceResponse)"},{"line_number":66,"context_line":"    tenant_id \u003d wtypes.wsattr(wtypes.StringType())"},{"line_number":67,"context_line":"    loadbalancers \u003d wtypes.wsattr([MinimalLoadBalancer])"},{"line_number":68,"context_line":"    listeners \u003d wtypes.wsattr([MinimalListener])"},{"line_number":69,"context_line":"    created_at \u003d wtypes.wsattr(wtypes.datetime.datetime)"}],"source_content_type":"text/x-python","patch_set":52,"id":"ffe62b97_a159d835","line":66,"range":{"start_line":66,"start_character":4,"end_line":66,"end_character":50},"in_reply_to":"ffe62b97_8696ea4b","updated":"2017-03-27 21:46:20.000000000","message":"Done","commit_id":"208b05d53916bba46ce9bcba750bbd6f98ccb8c6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b17d3fad6940a10c27f026c516b08d3a92f6d46b","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    listeners \u003d wtypes.wsattr([MinimalListener])"},{"line_number":69,"context_line":"    created_at \u003d wtypes.wsattr(wtypes.datetime.datetime)"},{"line_number":70,"context_line":"    updated_at \u003d wtypes.wsattr(wtypes.datetime.datetime)"},{"line_number":71,"context_line":"    provider \u003d wtypes.wsattr(wtypes.text)"},{"line_number":72,"context_line":"    status_description \u003d wtypes.wsattr(wtypes.text)"},{"line_number":73,"context_line":"    health_monitor \u003d wtypes.wsattr(health_monitor.HealthMonitorResponse)"},{"line_number":74,"context_line":"    health_monitor_id \u003d wtypes.wsattr(wtypes.UuidType())"}],"source_content_type":"text/x-python","patch_set":52,"id":"ffe62b97_26727e4a","line":71,"range":{"start_line":71,"start_character":4,"end_line":71,"end_character":41},"updated":"2017-03-27 21:25:16.000000000","message":"Pools don\u0027t have providers","commit_id":"208b05d53916bba46ce9bcba750bbd6f98ccb8c6"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"5983ba0775eaaf3efe2473d7fa572a6769463c65","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    listeners \u003d wtypes.wsattr([MinimalListener])"},{"line_number":69,"context_line":"    created_at \u003d wtypes.wsattr(wtypes.datetime.datetime)"},{"line_number":70,"context_line":"    updated_at \u003d wtypes.wsattr(wtypes.datetime.datetime)"},{"line_number":71,"context_line":"    provider \u003d wtypes.wsattr(wtypes.text)"},{"line_number":72,"context_line":"    status_description \u003d wtypes.wsattr(wtypes.text)"},{"line_number":73,"context_line":"    health_monitor \u003d wtypes.wsattr(health_monitor.HealthMonitorResponse)"},{"line_number":74,"context_line":"    health_monitor_id \u003d wtypes.wsattr(wtypes.UuidType())"}],"source_content_type":"text/x-python","patch_set":52,"id":"ffe62b97_8142543d","line":71,"range":{"start_line":71,"start_character":4,"end_line":71,"end_character":41},"in_reply_to":"ffe62b97_26727e4a","updated":"2017-03-27 21:46:20.000000000","message":"Done","commit_id":"208b05d53916bba46ce9bcba750bbd6f98ccb8c6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b17d3fad6940a10c27f026c516b08d3a92f6d46b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    created_at \u003d wtypes.wsattr(wtypes.datetime.datetime)"},{"line_number":70,"context_line":"    updated_at \u003d wtypes.wsattr(wtypes.datetime.datetime)"},{"line_number":71,"context_line":"    provider \u003d wtypes.wsattr(wtypes.text)"},{"line_number":72,"context_line":"    status_description \u003d wtypes.wsattr(wtypes.text)"},{"line_number":73,"context_line":"    health_monitor \u003d wtypes.wsattr(health_monitor.HealthMonitorResponse)"},{"line_number":74,"context_line":"    health_monitor_id \u003d wtypes.wsattr(wtypes.UuidType())"},{"line_number":75,"context_line":"    members \u003d wtypes.wsattr([member.MemberResponse])"}],"source_content_type":"text/x-python","patch_set":52,"id":"ffe62b97_c696323f","line":72,"range":{"start_line":72,"start_character":4,"end_line":72,"end_character":51},"updated":"2017-03-27 21:25:16.000000000","message":"We don\u0027t have status_descriptions","commit_id":"208b05d53916bba46ce9bcba750bbd6f98ccb8c6"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"5983ba0775eaaf3efe2473d7fa572a6769463c65","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    created_at \u003d wtypes.wsattr(wtypes.datetime.datetime)"},{"line_number":70,"context_line":"    updated_at \u003d wtypes.wsattr(wtypes.datetime.datetime)"},{"line_number":71,"context_line":"    provider \u003d wtypes.wsattr(wtypes.text)"},{"line_number":72,"context_line":"    status_description \u003d wtypes.wsattr(wtypes.text)"},{"line_number":73,"context_line":"    health_monitor \u003d wtypes.wsattr(health_monitor.HealthMonitorResponse)"},{"line_number":74,"context_line":"    health_monitor_id \u003d wtypes.wsattr(wtypes.UuidType())"},{"line_number":75,"context_line":"    members \u003d wtypes.wsattr([member.MemberResponse])"}],"source_content_type":"text/x-python","patch_set":52,"id":"ffe62b97_613f50b4","line":72,"range":{"start_line":72,"start_character":4,"end_line":72,"end_character":51},"in_reply_to":"ffe62b97_c696323f","updated":"2017-03-27 21:46:20.000000000","message":"Done","commit_id":"208b05d53916bba46ce9bcba750bbd6f98ccb8c6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b17d3fad6940a10c27f026c516b08d3a92f6d46b","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        wtypes.Enum(str, *constants.SUPPORTED_LB_ALGORITHMS),"},{"line_number":131,"context_line":"        mandatory\u003dTrue)"},{"line_number":132,"context_line":"    session_persistence \u003d wtypes.wsattr(SessionPersistencePOST)"},{"line_number":133,"context_line":"    project_id \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d36))"},{"line_number":134,"context_line":"    health_monitor \u003d wtypes.wsattr(health_monitor.HealthMonitorPOST)"},{"line_number":135,"context_line":"    members \u003d wtypes.wsattr([member.MemberPOST])"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"ffe62b97_6672c67d","line":133,"range":{"start_line":133,"start_character":4,"end_line":133,"end_character":14},"updated":"2017-03-27 21:25:16.000000000","message":"tenant_id missing\nAlso, tag them both with:\n# TODO(johnsom) Remove after deprecation (R series)","commit_id":"208b05d53916bba46ce9bcba750bbd6f98ccb8c6"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"5983ba0775eaaf3efe2473d7fa572a6769463c65","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        wtypes.Enum(str, *constants.SUPPORTED_LB_ALGORITHMS),"},{"line_number":131,"context_line":"        mandatory\u003dTrue)"},{"line_number":132,"context_line":"    session_persistence \u003d wtypes.wsattr(SessionPersistencePOST)"},{"line_number":133,"context_line":"    project_id \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d36))"},{"line_number":134,"context_line":"    health_monitor \u003d wtypes.wsattr(health_monitor.HealthMonitorPOST)"},{"line_number":135,"context_line":"    members \u003d wtypes.wsattr([member.MemberPOST])"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"ffe62b97_c154dc00","line":133,"range":{"start_line":133,"start_character":4,"end_line":133,"end_character":14},"in_reply_to":"ffe62b97_6672c67d","updated":"2017-03-27 21:46:20.000000000","message":"Done","commit_id":"208b05d53916bba46ce9bcba750bbd6f98ccb8c6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b17d3fad6940a10c27f026c516b08d3a92f6d46b","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    name \u003d wtypes.wsattr(wtypes.StringType())"},{"line_number":145,"context_line":"    description \u003d wtypes.wsattr(wtypes.StringType())"},{"line_number":146,"context_line":"    admin_state_up \u003d wtypes.wsattr(bool)"},{"line_number":147,"context_line":"    protocol \u003d wtypes.wsattr(wtypes.Enum(str, *constants.SUPPORTED_PROTOCOLS))"},{"line_number":148,"context_line":"    lb_algorithm \u003d wtypes.wsattr("},{"line_number":149,"context_line":"        wtypes.Enum(str, *constants.SUPPORTED_LB_ALGORITHMS))"},{"line_number":150,"context_line":"    session_persistence \u003d wtypes.wsattr(SessionPersistencePUT)"}],"source_content_type":"text/x-python","patch_set":52,"id":"ffe62b97_e6349695","line":147,"range":{"start_line":147,"start_character":4,"end_line":147,"end_character":78},"updated":"2017-03-27 21:25:16.000000000","message":"neutron lbaas doesn\u0027t allow put for protocol","commit_id":"208b05d53916bba46ce9bcba750bbd6f98ccb8c6"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"5983ba0775eaaf3efe2473d7fa572a6769463c65","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    name \u003d wtypes.wsattr(wtypes.StringType())"},{"line_number":145,"context_line":"    description \u003d wtypes.wsattr(wtypes.StringType())"},{"line_number":146,"context_line":"    admin_state_up \u003d wtypes.wsattr(bool)"},{"line_number":147,"context_line":"    protocol \u003d wtypes.wsattr(wtypes.Enum(str, *constants.SUPPORTED_PROTOCOLS))"},{"line_number":148,"context_line":"    lb_algorithm \u003d wtypes.wsattr("},{"line_number":149,"context_line":"        wtypes.Enum(str, *constants.SUPPORTED_LB_ALGORITHMS))"},{"line_number":150,"context_line":"    session_persistence \u003d wtypes.wsattr(SessionPersistencePUT)"}],"source_content_type":"text/x-python","patch_set":52,"id":"ffe62b97_418fac74","line":147,"range":{"start_line":147,"start_character":4,"end_line":147,"end_character":78},"in_reply_to":"ffe62b97_e6349695","updated":"2017-03-27 21:46:20.000000000","message":"I wonder why? It seems like it should be OK to change this?\nRemoved for now.","commit_id":"208b05d53916bba46ce9bcba750bbd6f98ccb8c6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0911e07c2b9de6bfba8baab4de0ffb5bcc3b6551","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    # TODO(johnsom) Remove after deprecation (R series)"},{"line_number":68,"context_line":"    tenant_id \u003d wtypes.wsattr(wtypes.StringType())"},{"line_number":69,"context_line":"    loadbalancers \u003d wtypes.wsattr([MinimalLoadBalancer])"},{"line_number":70,"context_line":"    listeners \u003d wtypes.wsattr([MinimalListener])"},{"line_number":71,"context_line":"    created_at \u003d wtypes.wsattr(wtypes.datetime.datetime)"},{"line_number":72,"context_line":"    updated_at \u003d wtypes.wsattr(wtypes.datetime.datetime)"},{"line_number":73,"context_line":"    health_monitor \u003d wtypes.wsattr(health_monitor.HealthMonitorResponse)"}],"source_content_type":"text/x-python","patch_set":53,"id":"ffe62b97_214388b1","line":70,"range":{"start_line":70,"start_character":4,"end_line":70,"end_character":48},"updated":"2017-03-27 22:17:26.000000000","message":"neutron-lbaas returns \"\"listeners\": [],\" during a create with just loadbalancer_id specified, but octavia v2 API is returning \"\"listeners\": null,\"","commit_id":"79aba306981f2eed6587e1cb8f8e6151e834c444"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b280619b929c089e5f992975f1aa514c5413faf0","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    # TODO(johnsom) Remove after deprecation (R series)"},{"line_number":68,"context_line":"    tenant_id \u003d wtypes.wsattr(wtypes.StringType())"},{"line_number":69,"context_line":"    loadbalancers \u003d wtypes.wsattr([MinimalLoadBalancer])"},{"line_number":70,"context_line":"    listeners \u003d wtypes.wsattr([MinimalListener])"},{"line_number":71,"context_line":"    created_at \u003d wtypes.wsattr(wtypes.datetime.datetime)"},{"line_number":72,"context_line":"    updated_at \u003d wtypes.wsattr(wtypes.datetime.datetime)"},{"line_number":73,"context_line":"    health_monitor \u003d wtypes.wsattr(health_monitor.HealthMonitorResponse)"}],"source_content_type":"text/x-python","patch_set":53,"id":"ffe62b97_ec7fd7dd","line":70,"range":{"start_line":70,"start_character":4,"end_line":70,"end_character":48},"in_reply_to":"ffe62b97_214388b1","updated":"2017-03-27 22:40:23.000000000","message":"Done","commit_id":"79aba306981f2eed6587e1cb8f8e6151e834c444"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0911e07c2b9de6bfba8baab4de0ffb5bcc3b6551","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    created_at \u003d wtypes.wsattr(wtypes.datetime.datetime)"},{"line_number":72,"context_line":"    updated_at \u003d wtypes.wsattr(wtypes.datetime.datetime)"},{"line_number":73,"context_line":"    health_monitor \u003d wtypes.wsattr(health_monitor.HealthMonitorResponse)"},{"line_number":74,"context_line":"    health_monitor_id \u003d wtypes.wsattr(wtypes.UuidType())"},{"line_number":75,"context_line":"    members \u003d wtypes.wsattr([member.MemberResponse])"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":53,"id":"ffe62b97_61cf5056","line":74,"range":{"start_line":74,"start_character":4,"end_line":74,"end_character":56},"updated":"2017-03-27 22:17:26.000000000","message":"When I did a pool create, neutron-lbaas returns this as \"\"healthmonitor_id\": null,\" but octavia v2 didn\u0027t return this at all.","commit_id":"79aba306981f2eed6587e1cb8f8e6151e834c444"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b280619b929c089e5f992975f1aa514c5413faf0","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    created_at \u003d wtypes.wsattr(wtypes.datetime.datetime)"},{"line_number":72,"context_line":"    updated_at \u003d wtypes.wsattr(wtypes.datetime.datetime)"},{"line_number":73,"context_line":"    health_monitor \u003d wtypes.wsattr(health_monitor.HealthMonitorResponse)"},{"line_number":74,"context_line":"    health_monitor_id \u003d wtypes.wsattr(wtypes.UuidType())"},{"line_number":75,"context_line":"    members \u003d wtypes.wsattr([member.MemberResponse])"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":53,"id":"ffe62b97_ac854fd1","line":74,"range":{"start_line":74,"start_character":4,"end_line":74,"end_character":56},"in_reply_to":"ffe62b97_61cf5056","updated":"2017-03-27 22:40:23.000000000","message":"Well, the HM patch is coming soon, so I assume it can be fixed there.","commit_id":"79aba306981f2eed6587e1cb8f8e6151e834c444"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0911e07c2b9de6bfba8baab4de0ffb5bcc3b6551","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    updated_at \u003d wtypes.wsattr(wtypes.datetime.datetime)"},{"line_number":73,"context_line":"    health_monitor \u003d wtypes.wsattr(health_monitor.HealthMonitorResponse)"},{"line_number":74,"context_line":"    health_monitor_id \u003d wtypes.wsattr(wtypes.UuidType())"},{"line_number":75,"context_line":"    members \u003d wtypes.wsattr([member.MemberResponse])"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @classmethod"},{"line_number":78,"context_line":"    def from_data_model(cls, data_model, children\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":53,"id":"ffe62b97_017be4f4","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":52},"updated":"2017-03-27 22:17:26.000000000","message":"neutron-lbaas returns \"\"members\": [],\" on pool create call, but octavia v2 API is not returning this at all.","commit_id":"79aba306981f2eed6587e1cb8f8e6151e834c444"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b280619b929c089e5f992975f1aa514c5413faf0","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    updated_at \u003d wtypes.wsattr(wtypes.datetime.datetime)"},{"line_number":73,"context_line":"    health_monitor \u003d wtypes.wsattr(health_monitor.HealthMonitorResponse)"},{"line_number":74,"context_line":"    health_monitor_id \u003d wtypes.wsattr(wtypes.UuidType())"},{"line_number":75,"context_line":"    members \u003d wtypes.wsattr([member.MemberResponse])"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @classmethod"},{"line_number":78,"context_line":"    def from_data_model(cls, data_model, children\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":53,"id":"ffe62b97_6c54e753","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":52},"in_reply_to":"ffe62b97_017be4f4","updated":"2017-03-27 22:40:23.000000000","message":"Members are in the next patch, I believe it can be (and is?) fixed there.","commit_id":"79aba306981f2eed6587e1cb8f8e6151e834c444"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1fc804eb060b1e4354c6d667406fce0bd27aa5de","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    admin_state_up \u003d wtypes.wsattr(bool)"},{"line_number":151,"context_line":"    lb_algorithm \u003d wtypes.wsattr("},{"line_number":152,"context_line":"        wtypes.Enum(str, *constants.SUPPORTED_LB_ALGORITHMS))"},{"line_number":153,"context_line":"    session_persistence \u003d wtypes.wsattr(SessionPersistencePUT)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"class PoolRootPut(types.BaseType):"}],"source_content_type":"text/x-python","patch_set":53,"id":"ffe62b97_2c437fb1","line":153,"range":{"start_line":153,"start_character":4,"end_line":153,"end_character":62},"updated":"2017-03-27 22:35:15.000000000","message":"When I switch from \n\"\"session_persistence\": {\"cookie_name\": \"ChocChip\", \"type\": \"APP_COOKIE\"}\"\nto \"\"session_persistence\": {\"cookie_name\": null, \"type\": \"SOURCE_IP\"},\"\nneutron-lbaas puts null in the cookie_name as SOURCE_IP does not use the cookie_name field.  Currently Octavia v2 API is leaving the cookie_name populated from the old setting.","commit_id":"79aba306981f2eed6587e1cb8f8e6151e834c444"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"95999822a5c6136b91b0136a2969e919d66b048c","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    admin_state_up \u003d wtypes.wsattr(bool)"},{"line_number":151,"context_line":"    lb_algorithm \u003d wtypes.wsattr("},{"line_number":152,"context_line":"        wtypes.Enum(str, *constants.SUPPORTED_LB_ALGORITHMS))"},{"line_number":153,"context_line":"    session_persistence \u003d wtypes.wsattr(SessionPersistencePUT)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"class PoolRootPut(types.BaseType):"}],"source_content_type":"text/x-python","patch_set":53,"id":"ffe62b97_67ce4083","line":153,"range":{"start_line":153,"start_character":4,"end_line":153,"end_character":62},"in_reply_to":"ffe62b97_2c437fb1","updated":"2017-03-27 23:19:07.000000000","message":"Hmm, this should be done inside the handler which is totally unrelated to the API... Looks like we\u0027re passing the None through correctly... I need to see how this worked in v1.","commit_id":"79aba306981f2eed6587e1cb8f8e6151e834c444"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"0b1f054b418e267892b15595fafabbb4d4c75fb8","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    admin_state_up \u003d wtypes.wsattr(bool)"},{"line_number":151,"context_line":"    lb_algorithm \u003d wtypes.wsattr("},{"line_number":152,"context_line":"        wtypes.Enum(str, *constants.SUPPORTED_LB_ALGORITHMS))"},{"line_number":153,"context_line":"    session_persistence \u003d wtypes.wsattr(SessionPersistencePUT)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"class PoolRootPut(types.BaseType):"}],"source_content_type":"text/x-python","patch_set":53,"id":"ffe62b97_87dca4e4","line":153,"range":{"start_line":153,"start_character":4,"end_line":153,"end_character":62},"in_reply_to":"ffe62b97_67ce4083","updated":"2017-03-27 23:35:16.000000000","message":"Can we open a bug for this and fix it separately?","commit_id":"79aba306981f2eed6587e1cb8f8e6151e834c444"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"95589b5a25034ed4ca53a2c4cd6134f7b64ebfec","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    admin_state_up \u003d wtypes.wsattr(bool)"},{"line_number":151,"context_line":"    lb_algorithm \u003d wtypes.wsattr("},{"line_number":152,"context_line":"        wtypes.Enum(str, *constants.SUPPORTED_LB_ALGORITHMS))"},{"line_number":153,"context_line":"    session_persistence \u003d wtypes.wsattr(SessionPersistencePUT)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"class PoolRootPut(types.BaseType):"}],"source_content_type":"text/x-python","patch_set":53,"id":"ffe62b97_f96678c1","line":153,"range":{"start_line":153,"start_character":4,"end_line":153,"end_character":62},"in_reply_to":"ffe62b97_87dca4e4","updated":"2017-03-28 00:04:20.000000000","message":"Done","commit_id":"79aba306981f2eed6587e1cb8f8e6151e834c444"}],"octavia/tests/unit/api/v2/types/test_pools.py":[{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"af67db37cfbe2fe70ec609f9f68820e04b8fd877","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from wsme import types as wsme_types"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# TODO(sshank): Change to v2 types."},{"line_number":20,"context_line":"from octavia.api.v1.types import pool as pool_type"},{"line_number":21,"context_line":"from octavia.common import constants"},{"line_number":22,"context_line":"from octavia.tests.unit.api.common import base"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"3a461143_21efd81e","line":20,"updated":"2017-01-31 18:58:05.000000000","message":"v2 types?","commit_id":"39f928500c9df26646df7f0c37353f3d39191390"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"8ed165da3ba6852ba9f3b532c5c63b32bc6923a2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from wsme import types as wsme_types"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# TODO(sshank): Change to v2 types."},{"line_number":20,"context_line":"from octavia.api.v1.types import pool as pool_type"},{"line_number":21,"context_line":"from octavia.common import constants"},{"line_number":22,"context_line":"from octavia.tests.unit.api.common import base"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"3a461143_04e1dcd0","line":20,"in_reply_to":"3a461143_21efd81e","updated":"2017-02-01 19:54:09.000000000","message":"Done","commit_id":"39f928500c9df26646df7f0c37353f3d39191390"}]}