)]}'
{"octavia/api/v2/controllers/__init__.py":[{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"16c62947922f2443672f1e775b6812edbe695aa4","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class BaseV2Controller(base.BaseController):"},{"line_number":24,"context_line":"    loadbalancers \u003d load_balancer.LoadBalancersController()"},{"line_number":25,"context_line":"    healthmonitors \u003d health_monitor.HealthMonitorController()"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @wsme_pecan.wsexpose(wtypes.text)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_55e5b0d9","line":24,"updated":"2017-01-30 17:03:59.000000000","message":"loadbalancers is not needed anymore....can be removed.","commit_id":"63f21192b5a5002f890dd815a32c5b3022a1c70c"}],"octavia/api/v2/controllers/health_monitor.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"35945a922f3bc278ed87f7f3bc4745baedd183b0","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def __init__(self):"},{"line_number":39,"context_line":"        super(HealthMonitorController, self).__init__()"},{"line_number":40,"context_line":"        self.load_balancer_id \u003d None"},{"line_number":41,"context_line":"        self.listener_id \u003d None"},{"line_number":42,"context_line":"        self.pool_id \u003d None"},{"line_number":43,"context_line":"        self.handler \u003d self.handler.health_monitor"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a1ced50_c202036f","line":40,"updated":"2017-03-20 19:28:14.000000000","message":"Really can\u0027t be storing this stuff in the class... It\u0027ll carry across requests.\nNeed to remove these and just pass relevant things to functions that need them.","commit_id":"b3919e7d29785a9d683e70dce1ef6185b50a252f"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"988fbf50ffb3bed3ce3cecf58e9957d1f8bb9cae","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def __init__(self):"},{"line_number":39,"context_line":"        super(HealthMonitorController, self).__init__()"},{"line_number":40,"context_line":"        self.load_balancer_id \u003d None"},{"line_number":41,"context_line":"        self.listener_id \u003d None"},{"line_number":42,"context_line":"        self.pool_id \u003d None"},{"line_number":43,"context_line":"        self.handler \u003d self.handler.health_monitor"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a1ced50_240042aa","line":40,"updated":"2017-03-20 20:36:47.000000000","message":"As per Adam\u0027s comment in PS#16:\na) HM ID patch merged, so maybe need fixes for that now that the column is there.\nb) Really can\u0027t be storing this stuff ( load_balancer_id \u003d None , etc) in the class... It\u0027ll carry across requests.\nNeed to remove these and just pass relevant things to functions that need them.","commit_id":"59d63d6a2e357175681d505f6b1f09c9697ada98"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"493c532bc7aece011cd9ff966e8f01c175b71b96","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def __init__(self):"},{"line_number":39,"context_line":"        super(HealthMonitorController, self).__init__()"},{"line_number":40,"context_line":"        self.load_balancer_id \u003d None"},{"line_number":41,"context_line":"        self.listener_id \u003d None"},{"line_number":42,"context_line":"        self.pool_id \u003d None"},{"line_number":43,"context_line":"        self.handler \u003d self.handler.health_monitor"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a1ced50_64095add","line":40,"updated":"2017-03-20 20:36:09.000000000","message":"Still really need to remove all of the code that uses `self` to store things like this... These classes are not per-request.","commit_id":"59d63d6a2e357175681d505f6b1f09c9697ada98"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"8e3f8cab35b0fc664a9f92c6f1332c42a3489e7c","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        return self._convert_db_to_type(db_hm, hm_types.HealthMonitorResponse)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @wsme_pecan.wsexpose(None, status_code\u003d202)"},{"line_number":176,"context_line":"    def delete(self, health_monitor):"},{"line_number":177,"context_line":"        \"\"\"Deletes a health monitor.\"\"\""},{"line_number":178,"context_line":"        context \u003d pecan.request.context.get(\u0027octavia_context\u0027)"},{"line_number":179,"context_line":"        id \u003d health_monitor.id"}],"source_content_type":"text/x-python","patch_set":22,"id":"dfeb2761_51cda95b","line":176,"range":{"start_line":176,"start_character":21,"end_line":176,"end_character":35},"updated":"2017-03-31 10:09:51.000000000","message":"do we need healthmonitor here?\nWont we have it from self itself?","commit_id":"3455bf5516e22ca53f8830ae3ba9f48465aebfd8"}],"octavia/api/v2/types/health_monitor.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"56ddf8637aa3d52285989c491c59ec8623629e95","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    healthmonitors \u003d wtypes.wsattr([HealthMonitorResponse])"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class HealthMonitorPOST(BaseHealthMonitorType):"},{"line_number":68,"context_line":"    \"\"\"Defines mandatory and optional attributes of a POST request.\"\"\""},{"line_number":69,"context_line":"    type \u003d wtypes.wsattr("},{"line_number":70,"context_line":"        wtypes.Enum(str, *constants.SUPPORTED_HEALTH_MONITOR_TYPES),"}],"source_content_type":"text/x-python","patch_set":23,"id":"dfeb2761_d45cf04c","line":67,"range":{"start_line":67,"start_character":6,"end_line":67,"end_character":23},"updated":"2017-04-01 00:32:12.000000000","message":"name is missing","commit_id":"4690ba8b30b34ecec3af303a20d0f95f4ec61435"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7a62c0e18c82b87e23778d9a4fdb1b6e66b6adca","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    healthmonitors \u003d wtypes.wsattr([HealthMonitorResponse])"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class HealthMonitorPOST(BaseHealthMonitorType):"},{"line_number":68,"context_line":"    \"\"\"Defines mandatory and optional attributes of a POST request.\"\"\""},{"line_number":69,"context_line":"    type \u003d wtypes.wsattr("},{"line_number":70,"context_line":"        wtypes.Enum(str, *constants.SUPPORTED_HEALTH_MONITOR_TYPES),"}],"source_content_type":"text/x-python","patch_set":23,"id":"dfeb2761_6543d0b0","line":67,"range":{"start_line":67,"start_character":6,"end_line":67,"end_character":23},"in_reply_to":"dfeb2761_d45cf04c","updated":"2017-04-04 19:29:04.000000000","message":"Done","commit_id":"4690ba8b30b34ecec3af303a20d0f95f4ec61435"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"56ddf8637aa3d52285989c491c59ec8623629e95","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    type \u003d wtypes.wsattr("},{"line_number":70,"context_line":"        wtypes.Enum(str, *constants.SUPPORTED_HEALTH_MONITOR_TYPES),"},{"line_number":71,"context_line":"        mandatory\u003dTrue)"},{"line_number":72,"context_line":"    delay \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":73,"context_line":"    timeout \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":74,"context_line":"    max_retries_down \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":75,"context_line":"    max_retries \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":23,"id":"dfeb2761_b4abac1b","line":72,"range":{"start_line":72,"start_character":26,"end_line":72,"end_character":47},"updated":"2017-04-01 00:32:12.000000000","message":"This has a non-negative restriction in neutron-lbaas, I think it should have a min/max restriction.","commit_id":"4690ba8b30b34ecec3af303a20d0f95f4ec61435"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7a62c0e18c82b87e23778d9a4fdb1b6e66b6adca","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    type \u003d wtypes.wsattr("},{"line_number":70,"context_line":"        wtypes.Enum(str, *constants.SUPPORTED_HEALTH_MONITOR_TYPES),"},{"line_number":71,"context_line":"        mandatory\u003dTrue)"},{"line_number":72,"context_line":"    delay \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":73,"context_line":"    timeout \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":74,"context_line":"    max_retries_down \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":75,"context_line":"    max_retries \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":23,"id":"dfeb2761_e537e04c","line":72,"range":{"start_line":72,"start_character":26,"end_line":72,"end_character":47},"in_reply_to":"dfeb2761_b4abac1b","updated":"2017-04-04 19:29:04.000000000","message":"Done","commit_id":"4690ba8b30b34ecec3af303a20d0f95f4ec61435"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"56ddf8637aa3d52285989c491c59ec8623629e95","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        wtypes.Enum(str, *constants.SUPPORTED_HEALTH_MONITOR_TYPES),"},{"line_number":71,"context_line":"        mandatory\u003dTrue)"},{"line_number":72,"context_line":"    delay \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":73,"context_line":"    timeout \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":74,"context_line":"    max_retries_down \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":75,"context_line":"    max_retries \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":76,"context_line":"    http_method \u003d wtypes.wsattr("}],"source_content_type":"text/x-python","patch_set":23,"id":"dfeb2761_7463e41b","line":73,"range":{"start_line":73,"start_character":4,"end_line":73,"end_character":65},"updated":"2017-04-01 00:32:12.000000000","message":"This has a non-negative restriction in neutron-lbaas, I think it should have a min/max restriction.","commit_id":"4690ba8b30b34ecec3af303a20d0f95f4ec61435"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7a62c0e18c82b87e23778d9a4fdb1b6e66b6adca","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        wtypes.Enum(str, *constants.SUPPORTED_HEALTH_MONITOR_TYPES),"},{"line_number":71,"context_line":"        mandatory\u003dTrue)"},{"line_number":72,"context_line":"    delay \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":73,"context_line":"    timeout \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":74,"context_line":"    max_retries_down \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":75,"context_line":"    max_retries \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":76,"context_line":"    http_method \u003d wtypes.wsattr("}],"source_content_type":"text/x-python","patch_set":23,"id":"dfeb2761_0533e463","line":73,"range":{"start_line":73,"start_character":4,"end_line":73,"end_character":65},"in_reply_to":"dfeb2761_7463e41b","updated":"2017-04-04 19:29:04.000000000","message":"Done","commit_id":"4690ba8b30b34ecec3af303a20d0f95f4ec61435"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"56ddf8637aa3d52285989c491c59ec8623629e95","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        mandatory\u003dTrue)"},{"line_number":72,"context_line":"    delay \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":73,"context_line":"    timeout \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":74,"context_line":"    max_retries_down \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":75,"context_line":"    max_retries \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":76,"context_line":"    http_method \u003d wtypes.wsattr("},{"line_number":77,"context_line":"        wtypes.text, default\u003dconstants.HEALTH_MONITOR_HTTP_DEFAULT_METHOD)"}],"source_content_type":"text/x-python","patch_set":23,"id":"dfeb2761_14bdb864","line":74,"range":{"start_line":74,"start_character":37,"end_line":74,"end_character":58},"updated":"2017-04-01 00:32:12.000000000","message":"This has a default and range restriction in neutron-lbaas:\n\u0027default\u0027: 3, \u0027validate\u0027: {\u0027type:range\u0027: [1, 10]},","commit_id":"4690ba8b30b34ecec3af303a20d0f95f4ec61435"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7a62c0e18c82b87e23778d9a4fdb1b6e66b6adca","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        mandatory\u003dTrue)"},{"line_number":72,"context_line":"    delay \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":73,"context_line":"    timeout \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":74,"context_line":"    max_retries_down \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":75,"context_line":"    max_retries \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":76,"context_line":"    http_method \u003d wtypes.wsattr("},{"line_number":77,"context_line":"        wtypes.text, default\u003dconstants.HEALTH_MONITOR_HTTP_DEFAULT_METHOD)"}],"source_content_type":"text/x-python","patch_set":23,"id":"dfeb2761_45168caa","line":74,"range":{"start_line":74,"start_character":37,"end_line":74,"end_character":58},"in_reply_to":"dfeb2761_14bdb864","updated":"2017-04-04 19:29:04.000000000","message":"Done","commit_id":"4690ba8b30b34ecec3af303a20d0f95f4ec61435"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"56ddf8637aa3d52285989c491c59ec8623629e95","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    delay \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":73,"context_line":"    timeout \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":74,"context_line":"    max_retries_down \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":75,"context_line":"    max_retries \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":76,"context_line":"    http_method \u003d wtypes.wsattr("},{"line_number":77,"context_line":"        wtypes.text, default\u003dconstants.HEALTH_MONITOR_HTTP_DEFAULT_METHOD)"},{"line_number":78,"context_line":"    url_path \u003d wtypes.wsattr("}],"source_content_type":"text/x-python","patch_set":23,"id":"dfeb2761_5468e0f3","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":69},"updated":"2017-04-01 00:32:12.000000000","message":"This has a range restriction in neutron-lbaas:\n\u0027validate\u0027: {\u0027type:range\u0027: [1, 10]},","commit_id":"4690ba8b30b34ecec3af303a20d0f95f4ec61435"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7a62c0e18c82b87e23778d9a4fdb1b6e66b6adca","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    delay \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":73,"context_line":"    timeout \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":74,"context_line":"    max_retries_down \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":75,"context_line":"    max_retries \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":76,"context_line":"    http_method \u003d wtypes.wsattr("},{"line_number":77,"context_line":"        wtypes.text, default\u003dconstants.HEALTH_MONITOR_HTTP_DEFAULT_METHOD)"},{"line_number":78,"context_line":"    url_path \u003d wtypes.wsattr("}],"source_content_type":"text/x-python","patch_set":23,"id":"dfeb2761_85f13498","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":69},"in_reply_to":"dfeb2761_5468e0f3","updated":"2017-04-04 19:29:04.000000000","message":"Done","commit_id":"4690ba8b30b34ecec3af303a20d0f95f4ec61435"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"56ddf8637aa3d52285989c491c59ec8623629e95","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    timeout \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":74,"context_line":"    max_retries_down \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":75,"context_line":"    max_retries \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":76,"context_line":"    http_method \u003d wtypes.wsattr("},{"line_number":77,"context_line":"        wtypes.text, default\u003dconstants.HEALTH_MONITOR_HTTP_DEFAULT_METHOD)"},{"line_number":78,"context_line":"    url_path \u003d wtypes.wsattr("},{"line_number":79,"context_line":"        wtypes.text, default\u003dconstants.HEALTH_MONITOR_DEFAULT_URL_PATH)"},{"line_number":80,"context_line":"    expected_codes \u003d wtypes.wsattr("}],"source_content_type":"text/x-python","patch_set":23,"id":"dfeb2761_346d5c04","line":77,"range":{"start_line":76,"start_character":4,"end_line":77,"end_character":74},"updated":"2017-04-01 00:32:12.000000000","message":"This has a default of \"GET\" in neutron-lbaas","commit_id":"4690ba8b30b34ecec3af303a20d0f95f4ec61435"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7a62c0e18c82b87e23778d9a4fdb1b6e66b6adca","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    timeout \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":74,"context_line":"    max_retries_down \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":75,"context_line":"    max_retries \u003d wtypes.wsattr(wtypes.IntegerType(), mandatory\u003dTrue)"},{"line_number":76,"context_line":"    http_method \u003d wtypes.wsattr("},{"line_number":77,"context_line":"        wtypes.text, default\u003dconstants.HEALTH_MONITOR_HTTP_DEFAULT_METHOD)"},{"line_number":78,"context_line":"    url_path \u003d wtypes.wsattr("},{"line_number":79,"context_line":"        wtypes.text, default\u003dconstants.HEALTH_MONITOR_DEFAULT_URL_PATH)"},{"line_number":80,"context_line":"    expected_codes \u003d wtypes.wsattr("}],"source_content_type":"text/x-python","patch_set":23,"id":"dfeb2761_452d6cfc","line":77,"range":{"start_line":76,"start_character":4,"end_line":77,"end_character":74},"in_reply_to":"dfeb2761_346d5c04","updated":"2017-04-04 19:29:04.000000000","message":"constants.HEALTH_MONITOR_HTTP_DEFAULT_METHOD is assigned GET.","commit_id":"4690ba8b30b34ecec3af303a20d0f95f4ec61435"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"56ddf8637aa3d52285989c491c59ec8623629e95","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    http_method \u003d wtypes.wsattr("},{"line_number":77,"context_line":"        wtypes.text, default\u003dconstants.HEALTH_MONITOR_HTTP_DEFAULT_METHOD)"},{"line_number":78,"context_line":"    url_path \u003d wtypes.wsattr("},{"line_number":79,"context_line":"        wtypes.text, default\u003dconstants.HEALTH_MONITOR_DEFAULT_URL_PATH)"},{"line_number":80,"context_line":"    expected_codes \u003d wtypes.wsattr("},{"line_number":81,"context_line":"        wtypes.text, default\u003dconstants.HEALTH_MONITOR_DEFAULT_EXPECTED_CODES)"},{"line_number":82,"context_line":"    admin_state_up \u003d wtypes.wsattr(bool, default\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":23,"id":"dfeb2761_147258e6","line":79,"range":{"start_line":79,"start_character":7,"end_line":79,"end_character":19},"updated":"2017-04-01 00:32:12.000000000","message":"This should be URLtype","commit_id":"4690ba8b30b34ecec3af303a20d0f95f4ec61435"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7a62c0e18c82b87e23778d9a4fdb1b6e66b6adca","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    http_method \u003d wtypes.wsattr("},{"line_number":77,"context_line":"        wtypes.text, default\u003dconstants.HEALTH_MONITOR_HTTP_DEFAULT_METHOD)"},{"line_number":78,"context_line":"    url_path \u003d wtypes.wsattr("},{"line_number":79,"context_line":"        wtypes.text, default\u003dconstants.HEALTH_MONITOR_DEFAULT_URL_PATH)"},{"line_number":80,"context_line":"    expected_codes \u003d wtypes.wsattr("},{"line_number":81,"context_line":"        wtypes.text, default\u003dconstants.HEALTH_MONITOR_DEFAULT_EXPECTED_CODES)"},{"line_number":82,"context_line":"    admin_state_up \u003d wtypes.wsattr(bool, default\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":23,"id":"dfeb2761_25326860","line":79,"range":{"start_line":79,"start_character":7,"end_line":79,"end_character":19},"in_reply_to":"dfeb2761_147258e6","updated":"2017-04-04 19:29:04.000000000","message":"Done","commit_id":"4690ba8b30b34ecec3af303a20d0f95f4ec61435"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"56ddf8637aa3d52285989c491c59ec8623629e95","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    url_path \u003d wtypes.wsattr("},{"line_number":79,"context_line":"        wtypes.text, default\u003dconstants.HEALTH_MONITOR_DEFAULT_URL_PATH)"},{"line_number":80,"context_line":"    expected_codes \u003d wtypes.wsattr("},{"line_number":81,"context_line":"        wtypes.text, default\u003dconstants.HEALTH_MONITOR_DEFAULT_EXPECTED_CODES)"},{"line_number":82,"context_line":"    admin_state_up \u003d wtypes.wsattr(bool, default\u003dTrue)"},{"line_number":83,"context_line":"    project_id \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d36))"},{"line_number":84,"context_line":"    tenant_id \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d36))"}],"source_content_type":"text/x-python","patch_set":23,"id":"dfeb2761_d473d0e6","line":81,"range":{"start_line":81,"start_character":8,"end_line":81,"end_character":19},"updated":"2017-04-01 00:32:12.000000000","message":"There is a regex restriction on this in neutron-lbaas:\n\u0027validate\u0027: {\n                \u0027type:regex\u0027: r\u0027^(\\d{3}(\\s*,\\s*\\d{3})*)$|^(\\d{3}-\\d{3})$\u0027\n            },","commit_id":"4690ba8b30b34ecec3af303a20d0f95f4ec61435"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7a62c0e18c82b87e23778d9a4fdb1b6e66b6adca","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    url_path \u003d wtypes.wsattr("},{"line_number":79,"context_line":"        wtypes.text, default\u003dconstants.HEALTH_MONITOR_DEFAULT_URL_PATH)"},{"line_number":80,"context_line":"    expected_codes \u003d wtypes.wsattr("},{"line_number":81,"context_line":"        wtypes.text, default\u003dconstants.HEALTH_MONITOR_DEFAULT_EXPECTED_CODES)"},{"line_number":82,"context_line":"    admin_state_up \u003d wtypes.wsattr(bool, default\u003dTrue)"},{"line_number":83,"context_line":"    project_id \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d36))"},{"line_number":84,"context_line":"    tenant_id \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d36))"}],"source_content_type":"text/x-python","patch_set":23,"id":"dfeb2761_05b6448b","line":81,"range":{"start_line":81,"start_character":8,"end_line":81,"end_character":19},"in_reply_to":"dfeb2761_d473d0e6","updated":"2017-04-04 19:29:04.000000000","message":"How to specify this validation?","commit_id":"4690ba8b30b34ecec3af303a20d0f95f4ec61435"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"328c3a46d08e72f93e045a5ab2df77b64c3e79b2","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"class HealthMonitorPOST(BaseHealthMonitorType):"},{"line_number":74,"context_line":"    \"\"\"Defines mandatory and optional attributes of a POST request.\"\"\""},{"line_number":75,"context_line":"    name \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d36))"},{"line_number":76,"context_line":"    type \u003d wtypes.wsattr("},{"line_number":77,"context_line":"        wtypes.Enum(str, *constants.SUPPORTED_HEALTH_MONITOR_TYPES),"},{"line_number":78,"context_line":"        mandatory\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":33,"id":"9ff52f3f_dee65de9","line":75,"range":{"start_line":75,"start_character":54,"end_line":75,"end_character":56},"updated":"2017-04-13 17:53:42.000000000","message":"name on load balancer is length 255 and the database column is 255.  This should be consistent.","commit_id":"2f866387896c9aefac310d5780cad953a73c5665"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b9b33d9bec76bc8adb0c51582a71826093aa4fcc","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"class HealthMonitorPOST(BaseHealthMonitorType):"},{"line_number":74,"context_line":"    \"\"\"Defines mandatory and optional attributes of a POST request.\"\"\""},{"line_number":75,"context_line":"    name \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d36))"},{"line_number":76,"context_line":"    type \u003d wtypes.wsattr("},{"line_number":77,"context_line":"        wtypes.Enum(str, *constants.SUPPORTED_HEALTH_MONITOR_TYPES),"},{"line_number":78,"context_line":"        mandatory\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":33,"id":"7ffa3b31_7250c033","line":75,"range":{"start_line":75,"start_character":54,"end_line":75,"end_character":56},"in_reply_to":"9ff52f3f_dee65de9","updated":"2017-04-13 23:33:31.000000000","message":"Done","commit_id":"2f866387896c9aefac310d5780cad953a73c5665"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6814bbc866c8ec892a742704e69c7325a9e96e2e","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    max_retries_down \u003d wtypes.wsattr("},{"line_number":82,"context_line":"        wtypes.IntegerType(minimum\u003dconstants.MIN_HM_RETRIES,"},{"line_number":83,"context_line":"                           maximum\u003dconstants.MAX_HM_RETRIES),"},{"line_number":84,"context_line":"        default\u003d3, mandatory\u003dTrue)"},{"line_number":85,"context_line":"    max_retries \u003d wtypes.wsattr("},{"line_number":86,"context_line":"        wtypes.IntegerType(minimum\u003dconstants.MIN_HM_RETRIES,"},{"line_number":87,"context_line":"                           maximum\u003dconstants.MAX_HM_RETRIES),"}],"source_content_type":"text/x-python","patch_set":33,"id":"7ffa3b31_c1fc6440","line":84,"range":{"start_line":84,"start_character":19,"end_line":84,"end_character":33},"updated":"2017-04-13 20:48:47.000000000","message":"This is not mandatory in neutron lbaas","commit_id":"2f866387896c9aefac310d5780cad953a73c5665"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b9b33d9bec76bc8adb0c51582a71826093aa4fcc","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    max_retries_down \u003d wtypes.wsattr("},{"line_number":82,"context_line":"        wtypes.IntegerType(minimum\u003dconstants.MIN_HM_RETRIES,"},{"line_number":83,"context_line":"                           maximum\u003dconstants.MAX_HM_RETRIES),"},{"line_number":84,"context_line":"        default\u003d3, mandatory\u003dTrue)"},{"line_number":85,"context_line":"    max_retries \u003d wtypes.wsattr("},{"line_number":86,"context_line":"        wtypes.IntegerType(minimum\u003dconstants.MIN_HM_RETRIES,"},{"line_number":87,"context_line":"                           maximum\u003dconstants.MAX_HM_RETRIES),"}],"source_content_type":"text/x-python","patch_set":33,"id":"7ffa3b31_324a3880","line":84,"range":{"start_line":84,"start_character":19,"end_line":84,"end_character":33},"in_reply_to":"7ffa3b31_c1fc6440","updated":"2017-04-13 23:33:31.000000000","message":"Done","commit_id":"2f866387896c9aefac310d5780cad953a73c5665"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"328c3a46d08e72f93e045a5ab2df77b64c3e79b2","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                           maximum\u003dconstants.MAX_HM_RETRIES),"},{"line_number":88,"context_line":"        mandatory\u003dTrue)"},{"line_number":89,"context_line":"    http_method \u003d wtypes.wsattr("},{"line_number":90,"context_line":"        wtypes.text, default\u003dconstants.HEALTH_MONITOR_HTTP_DEFAULT_METHOD)"},{"line_number":91,"context_line":"    url_path \u003d wtypes.wsattr("},{"line_number":92,"context_line":"        types.URLType(), default\u003dconstants.HEALTH_MONITOR_DEFAULT_URL_PATH)"},{"line_number":93,"context_line":"    expected_codes \u003d wtypes.wsattr("}],"source_content_type":"text/x-python","patch_set":33,"id":"9ff52f3f_be9dd95a","line":90,"range":{"start_line":90,"start_character":8,"end_line":90,"end_character":19},"updated":"2017-04-13 17:53:42.000000000","message":"This should be enumerated","commit_id":"2f866387896c9aefac310d5780cad953a73c5665"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b9b33d9bec76bc8adb0c51582a71826093aa4fcc","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                           maximum\u003dconstants.MAX_HM_RETRIES),"},{"line_number":88,"context_line":"        mandatory\u003dTrue)"},{"line_number":89,"context_line":"    http_method \u003d wtypes.wsattr("},{"line_number":90,"context_line":"        wtypes.text, default\u003dconstants.HEALTH_MONITOR_HTTP_DEFAULT_METHOD)"},{"line_number":91,"context_line":"    url_path \u003d wtypes.wsattr("},{"line_number":92,"context_line":"        types.URLType(), default\u003dconstants.HEALTH_MONITOR_DEFAULT_URL_PATH)"},{"line_number":93,"context_line":"    expected_codes \u003d wtypes.wsattr("}],"source_content_type":"text/x-python","patch_set":33,"id":"7ffa3b31_0d3b9dd1","line":90,"range":{"start_line":90,"start_character":8,"end_line":90,"end_character":19},"in_reply_to":"9ff52f3f_be9dd95a","updated":"2017-04-13 23:33:31.000000000","message":"Done","commit_id":"2f866387896c9aefac310d5780cad953a73c5665"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f422964eb4dfea6d6700a4835435a4b6d5da2bf7","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    http_method \u003d wtypes.wsattr("},{"line_number":90,"context_line":"        wtypes.text, default\u003dconstants.HEALTH_MONITOR_HTTP_DEFAULT_METHOD)"},{"line_number":91,"context_line":"    url_path \u003d wtypes.wsattr("},{"line_number":92,"context_line":"        types.URLType(), default\u003dconstants.HEALTH_MONITOR_DEFAULT_URL_PATH)"},{"line_number":93,"context_line":"    expected_codes \u003d wtypes.wsattr("},{"line_number":94,"context_line":"        wtypes.text, default\u003dconstants.HEALTH_MONITOR_DEFAULT_EXPECTED_CODES)"},{"line_number":95,"context_line":"    admin_state_up \u003d wtypes.wsattr(bool, default\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":33,"id":"7ffa3b31_446f42c5","line":92,"range":{"start_line":92,"start_character":8,"end_line":92,"end_character":23},"updated":"2017-04-13 20:59:43.000000000","message":"This is broken.  The type requires a scheme so relative URLs are not working.\nhttps://github.com/openstack/octavia/blame/master/octavia/common/validate.py#L34\nWe need to either create another method that allows relative URLs or remove the \"require_scheme\u003dTrue\" from this method.","commit_id":"2f866387896c9aefac310d5780cad953a73c5665"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b9b33d9bec76bc8adb0c51582a71826093aa4fcc","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    http_method \u003d wtypes.wsattr("},{"line_number":90,"context_line":"        wtypes.text, default\u003dconstants.HEALTH_MONITOR_HTTP_DEFAULT_METHOD)"},{"line_number":91,"context_line":"    url_path \u003d wtypes.wsattr("},{"line_number":92,"context_line":"        types.URLType(), default\u003dconstants.HEALTH_MONITOR_DEFAULT_URL_PATH)"},{"line_number":93,"context_line":"    expected_codes \u003d wtypes.wsattr("},{"line_number":94,"context_line":"        wtypes.text, default\u003dconstants.HEALTH_MONITOR_DEFAULT_EXPECTED_CODES)"},{"line_number":95,"context_line":"    admin_state_up \u003d wtypes.wsattr(bool, default\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":33,"id":"7ffa3b31_4df2c508","line":92,"range":{"start_line":92,"start_character":8,"end_line":92,"end_character":23},"in_reply_to":"7ffa3b31_446f42c5","updated":"2017-04-13 23:33:31.000000000","message":"Done","commit_id":"2f866387896c9aefac310d5780cad953a73c5665"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"328c3a46d08e72f93e045a5ab2df77b64c3e79b2","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    url_path \u003d wtypes.wsattr("},{"line_number":92,"context_line":"        types.URLType(), default\u003dconstants.HEALTH_MONITOR_DEFAULT_URL_PATH)"},{"line_number":93,"context_line":"    expected_codes \u003d wtypes.wsattr("},{"line_number":94,"context_line":"        wtypes.text, default\u003dconstants.HEALTH_MONITOR_DEFAULT_EXPECTED_CODES)"},{"line_number":95,"context_line":"    admin_state_up \u003d wtypes.wsattr(bool, default\u003dTrue)"},{"line_number":96,"context_line":"    # TODO(johnsom) Remove after deprecation (R series)"},{"line_number":97,"context_line":"    project_id \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d36))"}],"source_content_type":"text/x-python","patch_set":33,"id":"9ff52f3f_febc81bc","line":94,"range":{"start_line":94,"start_character":8,"end_line":94,"end_character":19},"updated":"2017-04-13 17:53:42.000000000","message":"There is a regex validation in neutron lbaas:\n\u0027type:regex\u0027: r\u0027^(\\d{3}(\\s*,\\s*\\d{3})*)$|^(\\d{3}-\\d{3})$\u0027","commit_id":"2f866387896c9aefac310d5780cad953a73c5665"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b9b33d9bec76bc8adb0c51582a71826093aa4fcc","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    url_path \u003d wtypes.wsattr("},{"line_number":92,"context_line":"        types.URLType(), default\u003dconstants.HEALTH_MONITOR_DEFAULT_URL_PATH)"},{"line_number":93,"context_line":"    expected_codes \u003d wtypes.wsattr("},{"line_number":94,"context_line":"        wtypes.text, default\u003dconstants.HEALTH_MONITOR_DEFAULT_EXPECTED_CODES)"},{"line_number":95,"context_line":"    admin_state_up \u003d wtypes.wsattr(bool, default\u003dTrue)"},{"line_number":96,"context_line":"    # TODO(johnsom) Remove after deprecation (R series)"},{"line_number":97,"context_line":"    project_id \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d36))"}],"source_content_type":"text/x-python","patch_set":33,"id":"7ffa3b31_cdeff5e7","line":94,"range":{"start_line":94,"start_character":8,"end_line":94,"end_character":19},"in_reply_to":"9ff52f3f_febc81bc","updated":"2017-04-13 23:33:31.000000000","message":"I\u0027m not sure the correct way to do this yet. Uploading the rest of the fixes while I figure this out.","commit_id":"2f866387896c9aefac310d5780cad953a73c5665"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"328c3a46d08e72f93e045a5ab2df77b64c3e79b2","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"class HealthMonitorPUT(BaseHealthMonitorType):"},{"line_number":108,"context_line":"    \"\"\"Defines attributes that are acceptable of a PUT request.\"\"\""},{"line_number":109,"context_line":"    name \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d36))"},{"line_number":110,"context_line":"    delay \u003d wtypes.wsattr(wtypes.IntegerType(minimum\u003d0))"},{"line_number":111,"context_line":"    timeout \u003d wtypes.wsattr(wtypes.IntegerType(minimum\u003d0))"},{"line_number":112,"context_line":"    max_retries_down \u003d wtypes.wsattr("}],"source_content_type":"text/x-python","patch_set":33,"id":"9ff52f3f_9ed0d5f9","line":109,"range":{"start_line":109,"start_character":54,"end_line":109,"end_character":56},"updated":"2017-04-13 17:53:42.000000000","message":"Same, 255","commit_id":"2f866387896c9aefac310d5780cad953a73c5665"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b9b33d9bec76bc8adb0c51582a71826093aa4fcc","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"class HealthMonitorPUT(BaseHealthMonitorType):"},{"line_number":108,"context_line":"    \"\"\"Defines attributes that are acceptable of a PUT request.\"\"\""},{"line_number":109,"context_line":"    name \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d36))"},{"line_number":110,"context_line":"    delay \u003d wtypes.wsattr(wtypes.IntegerType(minimum\u003d0))"},{"line_number":111,"context_line":"    timeout \u003d wtypes.wsattr(wtypes.IntegerType(minimum\u003d0))"},{"line_number":112,"context_line":"    max_retries_down \u003d wtypes.wsattr("}],"source_content_type":"text/x-python","patch_set":33,"id":"7ffa3b31_5245c46f","line":109,"range":{"start_line":109,"start_character":54,"end_line":109,"end_character":56},"in_reply_to":"9ff52f3f_9ed0d5f9","updated":"2017-04-13 23:33:31.000000000","message":"Done","commit_id":"2f866387896c9aefac310d5780cad953a73c5665"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"328c3a46d08e72f93e045a5ab2df77b64c3e79b2","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    max_retries \u003d wtypes.wsattr("},{"line_number":116,"context_line":"        wtypes.IntegerType(minimum\u003dconstants.MIN_HM_RETRIES,"},{"line_number":117,"context_line":"                           maximum\u003dconstants.MAX_HM_RETRIES))"},{"line_number":118,"context_line":"    http_method \u003d wtypes.wsattr(wtypes.text)"},{"line_number":119,"context_line":"    url_path \u003d wtypes.wsattr(types.URLType())"},{"line_number":120,"context_line":"    expected_codes \u003d wtypes.wsattr(wtypes.text)"},{"line_number":121,"context_line":"    admin_state_up \u003d wtypes.wsattr(bool)"}],"source_content_type":"text/x-python","patch_set":33,"id":"9ff52f3f_fe0a4188","line":118,"range":{"start_line":118,"start_character":32,"end_line":118,"end_character":43},"updated":"2017-04-13 17:53:42.000000000","message":"Should be enum","commit_id":"2f866387896c9aefac310d5780cad953a73c5665"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b9b33d9bec76bc8adb0c51582a71826093aa4fcc","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    max_retries \u003d wtypes.wsattr("},{"line_number":116,"context_line":"        wtypes.IntegerType(minimum\u003dconstants.MIN_HM_RETRIES,"},{"line_number":117,"context_line":"                           maximum\u003dconstants.MAX_HM_RETRIES))"},{"line_number":118,"context_line":"    http_method \u003d wtypes.wsattr(wtypes.text)"},{"line_number":119,"context_line":"    url_path \u003d wtypes.wsattr(types.URLType())"},{"line_number":120,"context_line":"    expected_codes \u003d wtypes.wsattr(wtypes.text)"},{"line_number":121,"context_line":"    admin_state_up \u003d wtypes.wsattr(bool)"}],"source_content_type":"text/x-python","patch_set":33,"id":"7ffa3b31_ed3751e3","line":118,"range":{"start_line":118,"start_character":32,"end_line":118,"end_character":43},"in_reply_to":"9ff52f3f_fe0a4188","updated":"2017-04-13 23:33:31.000000000","message":"Done","commit_id":"2f866387896c9aefac310d5780cad953a73c5665"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"328c3a46d08e72f93e045a5ab2df77b64c3e79b2","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                           maximum\u003dconstants.MAX_HM_RETRIES))"},{"line_number":118,"context_line":"    http_method \u003d wtypes.wsattr(wtypes.text)"},{"line_number":119,"context_line":"    url_path \u003d wtypes.wsattr(types.URLType())"},{"line_number":120,"context_line":"    expected_codes \u003d wtypes.wsattr(wtypes.text)"},{"line_number":121,"context_line":"    admin_state_up \u003d wtypes.wsattr(bool)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":33,"id":"9ff52f3f_be395942","line":120,"range":{"start_line":120,"start_character":35,"end_line":120,"end_character":46},"updated":"2017-04-13 17:53:42.000000000","message":"regex","commit_id":"2f866387896c9aefac310d5780cad953a73c5665"}],"octavia/db/migration/alembic_migrations/versions/52377704420e_add_timestamps_to_healthmonitor.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"729506e66c1c0fef8fe5878c455dc9f546bbd27d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    op.add_column(u\u0027health_monitor\u0027,"},{"line_number":42,"context_line":"                  sa.Column(\u0027operating_status\u0027,"},{"line_number":43,"context_line":"                            sa.String(16),"},{"line_number":44,"context_line":"                            nullable\u003dFalse)"},{"line_number":45,"context_line":"                  )"},{"line_number":46,"context_line":"    op.create_foreign_key("},{"line_number":47,"context_line":"        u\u0027fk_health_monitor_operating_status_name\u0027, u\u0027health_monitor\u0027,"}],"source_content_type":"text/x-python","patch_set":33,"id":"9ff52f3f_1e4cc59c","line":44,"range":{"start_line":44,"start_character":28,"end_line":44,"end_character":42},"updated":"2017-04-13 18:08:24.000000000","message":"If this is not nullable we need to do an update for existing health monitors.  Probably set them online if they are \"ACTIVE\" provisioning status.","commit_id":"2f866387896c9aefac310d5780cad953a73c5665"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b9b33d9bec76bc8adb0c51582a71826093aa4fcc","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    op.add_column(u\u0027health_monitor\u0027,"},{"line_number":42,"context_line":"                  sa.Column(\u0027operating_status\u0027,"},{"line_number":43,"context_line":"                            sa.String(16),"},{"line_number":44,"context_line":"                            nullable\u003dFalse)"},{"line_number":45,"context_line":"                  )"},{"line_number":46,"context_line":"    op.create_foreign_key("},{"line_number":47,"context_line":"        u\u0027fk_health_monitor_operating_status_name\u0027, u\u0027health_monitor\u0027,"}],"source_content_type":"text/x-python","patch_set":33,"id":"7ffa3b31_cd5375e2","line":44,"range":{"start_line":44,"start_character":28,"end_line":44,"end_character":42},"in_reply_to":"9ff52f3f_1e4cc59c","updated":"2017-04-13 23:33:31.000000000","message":"Oh right I forgot it needs to be the same as the others... I don\u0027t know that I can do conditionals here though? Just defaulting to ONLINE for the moment...","commit_id":"2f866387896c9aefac310d5780cad953a73c5665"}],"octavia/db/prepare.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"729506e66c1c0fef8fe5878c455dc9f546bbd27d","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"def create_health_monitor(hm_dict, pool_id\u003dNone):"},{"line_number":173,"context_line":"    hm_dict[\u0027provisioning_status\u0027] \u003d constants.PENDING_CREATE"},{"line_number":174,"context_line":"    hm_dict[\u0027operating_status\u0027] \u003d constants.OFFLINE"},{"line_number":175,"context_line":"    if pool_id:"},{"line_number":176,"context_line":"        hm_dict[\u0027id\u0027] \u003d pool_id"},{"line_number":177,"context_line":"        hm_dict[\u0027pool_id\u0027] \u003d pool_id"}],"source_content_type":"text/x-python","patch_set":33,"id":"9ff52f3f_c1a9e2df","line":174,"range":{"start_line":174,"start_character":34,"end_line":174,"end_character":51},"updated":"2017-04-13 18:08:24.000000000","message":"We need to update the HM flow MarkHealthMonitorActiveInDB to update this to ONLINE like we did for L7","commit_id":"2f866387896c9aefac310d5780cad953a73c5665"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b9b33d9bec76bc8adb0c51582a71826093aa4fcc","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"def create_health_monitor(hm_dict, pool_id\u003dNone):"},{"line_number":173,"context_line":"    hm_dict[\u0027provisioning_status\u0027] \u003d constants.PENDING_CREATE"},{"line_number":174,"context_line":"    hm_dict[\u0027operating_status\u0027] \u003d constants.OFFLINE"},{"line_number":175,"context_line":"    if pool_id:"},{"line_number":176,"context_line":"        hm_dict[\u0027id\u0027] \u003d pool_id"},{"line_number":177,"context_line":"        hm_dict[\u0027pool_id\u0027] \u003d pool_id"}],"source_content_type":"text/x-python","patch_set":33,"id":"7ffa3b31_8dd20d34","line":174,"range":{"start_line":174,"start_character":34,"end_line":174,"end_character":51},"in_reply_to":"9ff52f3f_c1a9e2df","updated":"2017-04-13 23:33:31.000000000","message":"Done","commit_id":"2f866387896c9aefac310d5780cad953a73c5665"}]}