)]}'
{"octavia/api/v1/types/listener.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"46312d2ce6b5372ef04ec2c33b9f1fdb17d87e9e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    insert_headers \u003d wtypes.wsattr(wtypes.DictType(str, str))"},{"line_number":48,"context_line":"    created_at \u003d wtypes.wsattr(wtypes.datetime.datetime)"},{"line_number":49,"context_line":"    updated_at \u003d wtypes.wsattr(wtypes.datetime.datetime)"},{"line_number":50,"context_line":"    timeout \u003d wtypes.wsattr(wtypes.IntegerType())"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @classmethod"},{"line_number":53,"context_line":"    def from_data_model(cls, data_model, children\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a25e98e_862cffac","line":50,"range":{"start_line":50,"start_character":4,"end_line":50,"end_character":11},"updated":"2017-03-13 23:04:07.000000000","message":"As we have a lot of timeouts (see the bug comments) can we be more specific at which one we are setting here?\nFrom the bug description I think this is for the client timeout, so client_timeout might be better.  I would also be in favor of adding a bunch of these since we are doing it....  server timeout is the pair to client, etc.","commit_id":"4a9d282ed2451b05e532836fb3677ded8717c213"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"46312d2ce6b5372ef04ec2c33b9f1fdb17d87e9e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    default_pool \u003d wtypes.wsattr(pool.PoolPOST)"},{"line_number":96,"context_line":"    l7policies \u003d wtypes.wsattr([l7policy.L7PolicyPOST], default\u003d[])"},{"line_number":97,"context_line":"    insert_headers \u003d wtypes.wsattr(wtypes.DictType(str, str))"},{"line_number":98,"context_line":"    timeout \u003d wtypes.wsattr(wtypes.Integer(), default\u003d50000)    "},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"class ListenerPUT(base.BaseType):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a25e98e_2181754b","line":98,"range":{"start_line":98,"start_character":54,"end_line":98,"end_character":59},"updated":"2017-03-13 23:04:07.000000000","message":"Use the constant here.","commit_id":"4a9d282ed2451b05e532836fb3677ded8717c213"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"23caf41f53baae0d4e152e0e3c3e9da5c317f456","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    default_pool \u003d wtypes.wsattr(pool.PoolPOST)"},{"line_number":96,"context_line":"    l7policies \u003d wtypes.wsattr([l7policy.L7PolicyPOST], default\u003d[])"},{"line_number":97,"context_line":"    insert_headers \u003d wtypes.wsattr(wtypes.DictType(str, str))"},{"line_number":98,"context_line":"    timeout \u003d wtypes.wsattr(wtypes.Integer(), default\u003d50000)    "},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"class ListenerPUT(base.BaseType):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_f2eb46da","line":98,"updated":"2016-12-21 06:43:47.000000000","message":"ditto","commit_id":"4a9d282ed2451b05e532836fb3677ded8717c213"}],"octavia/common/constants.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1429ec76b3f8b00446dc09a7a43866f3d83cf662","unresolved":false,"context_lines":[{"line_number":364,"context_line":"NOAUTH \u003d \u0027noauth\u0027"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"# Timeout"},{"line_number":367,"context_line":"DEFAULT_LISTENER_TIMEOUT \u003d 50000"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_32e7b2b1","line":367,"updated":"2017-03-20 15:01:43.000000000","message":"I agree with the comments in IRC, config file with default there is probably best.\nAlso, as I commented on the other patch, please be more specific with the name, there are a bunch of different timeouts possible.\nIn the config file also add a comment about the units.  In this case I think it is milliseconds.","commit_id":"656936667fe21253a37486899cf5ad1d874e5860"}],"octavia/db/models.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"46312d2ce6b5372ef04ec2c33b9f1fdb17d87e9e","unresolved":false,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    peer_port \u003d sa.Column(sa.Integer(), nullable\u003dTrue)"},{"line_number":389,"context_line":"    insert_headers \u003d sa.Column(sa.PickleType())"},{"line_number":390,"context_line":"    timeout \u003d sa.Column(sa.Integer, nullable\u003dFalse,"},{"line_number":391,"context_line":"                        default\u003dDEFAULT_LISTENER_TIMEOUT)    "},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    # This property should be a unique list of the default_pool and anything"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a25e98e_c181814f","line":390,"range":{"start_line":390,"start_character":36,"end_line":390,"end_character":50},"updated":"2017-03-13 23:04:07.000000000","message":"Since this is false, you will need to make a DB migration to update them all.  Maybe consider if undefined is ok to avoid a DB migration.","commit_id":"4a9d282ed2451b05e532836fb3677ded8717c213"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"23caf41f53baae0d4e152e0e3c3e9da5c317f456","unresolved":false,"context_lines":[{"line_number":388,"context_line":"    peer_port \u003d sa.Column(sa.Integer(), nullable\u003dTrue)"},{"line_number":389,"context_line":"    insert_headers \u003d sa.Column(sa.PickleType())"},{"line_number":390,"context_line":"    timeout \u003d sa.Column(sa.Integer, nullable\u003dFalse,"},{"line_number":391,"context_line":"                        default\u003dDEFAULT_LISTENER_TIMEOUT)    "},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    # This property should be a unique list of the default_pool and anything"},{"line_number":394,"context_line":"    # referenced by enabled L7Policies with at least one rule that also"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_f21426ea","line":391,"range":{"start_line":391,"start_character":57,"end_line":391,"end_character":61},"updated":"2016-12-21 06:43:47.000000000","message":"RED AREA.:)","commit_id":"4a9d282ed2451b05e532836fb3677ded8717c213"}]}