)]}'
{"octavia/controller/worker/flows/amphora_flows.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b2eff56eeaa5c6c025c8e07f5a034a3095050a03","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            prefix\u003dconstants.FAILOVER_AMPHORA_FLOW)"},{"line_number":324,"context_line":"        failover_amphora_flow.add(get_amp_subflow)"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"        if role:"},{"line_number":327,"context_line":"            # Update the new amphora with the failed amphora details"},{"line_number":328,"context_line":"            failover_amphora_flow.add(database_tasks.UpdateAmpFailoverDetails("},{"line_number":329,"context_line":"                requires\u003d(constants.AMPHORA, constants.AMP_DATA)))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_77178c54","line":326,"updated":"2017-02-02 16:39:11.000000000","message":"I would feel more comfortable with this if we were checking the amp\u0027s status instead.\nI.e.checking if the status is AMPHORA_ALLOCATED or maybe even better yet, if the amp actually has an LB configured.","commit_id":"4cf51cfb2e6c395595ba3594e1747c4744a7a325"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b1d92274ceb03b6e687af2930ae5b21be1bd0283","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            prefix\u003dconstants.FAILOVER_AMPHORA_FLOW)"},{"line_number":324,"context_line":"        failover_amphora_flow.add(get_amp_subflow)"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"        if role:"},{"line_number":327,"context_line":"            # Update the new amphora with the failed amphora details"},{"line_number":328,"context_line":"            failover_amphora_flow.add(database_tasks.UpdateAmpFailoverDetails("},{"line_number":329,"context_line":"                requires\u003d(constants.AMPHORA, constants.AMP_DATA)))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_7f784290","line":326,"in_reply_to":"3a461143_77178c54","updated":"2017-02-02 17:23:19.000000000","message":"I don\u0027t know that we have access to that here? I think knowing that role \u003d\u003d None is good enough, since every LB flow sets the role as soon as it takes the amp out of the pool.","commit_id":"4cf51cfb2e6c395595ba3594e1747c4744a7a325"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b2eff56eeaa5c6c025c8e07f5a034a3095050a03","unresolved":false,"context_lines":[{"line_number":366,"context_line":"            failover_amphora_flow.add(database_tasks.MarkAmphoraMasterInDB("},{"line_number":367,"context_line":"                name\u003dconstants.MARK_AMP_MASTER_INDB,"},{"line_number":368,"context_line":"                requires\u003dconstants.AMPHORA))"},{"line_number":369,"context_line":"            vrrp_subflow \u003d self.get_vrrp_subflow(role)"},{"line_number":370,"context_line":"            failover_amphora_flow.add(vrrp_subflow)"},{"line_number":371,"context_line":"        elif role \u003d\u003d constants.ROLE_BACKUP:"},{"line_number":372,"context_line":"            failover_amphora_flow.add(database_tasks.MarkAmphoraBackupInDB("}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_291dac66","line":369,"updated":"2017-02-02 16:39:11.000000000","message":"These sub-flows are going to be attempting to setup keepalived, which I suspect will fail if there is no VIP assigned.  These should all be skipped as well if it is a spare.","commit_id":"4cf51cfb2e6c395595ba3594e1747c4744a7a325"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b1d92274ceb03b6e687af2930ae5b21be1bd0283","unresolved":false,"context_lines":[{"line_number":366,"context_line":"            failover_amphora_flow.add(database_tasks.MarkAmphoraMasterInDB("},{"line_number":367,"context_line":"                name\u003dconstants.MARK_AMP_MASTER_INDB,"},{"line_number":368,"context_line":"                requires\u003dconstants.AMPHORA))"},{"line_number":369,"context_line":"            vrrp_subflow \u003d self.get_vrrp_subflow(role)"},{"line_number":370,"context_line":"            failover_amphora_flow.add(vrrp_subflow)"},{"line_number":371,"context_line":"        elif role \u003d\u003d constants.ROLE_BACKUP:"},{"line_number":372,"context_line":"            failover_amphora_flow.add(database_tasks.MarkAmphoraBackupInDB("}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_bf246aaf","line":369,"in_reply_to":"3a461143_291dac66","updated":"2017-02-02 17:23:19.000000000","message":"If it\u0027s a spare then role will be None, so none of these will run. Already covered. :)","commit_id":"4cf51cfb2e6c395595ba3594e1747c4744a7a325"}]}