)]}'
{"octavia/api/v1/controllers/load_balancer.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a6da913380cec389b926d931d404507351373f3b","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                network_driver \u003d utils.get_network_driver()"},{"line_number":133,"context_line":"                for subnet_id in network.subnets:"},{"line_number":134,"context_line":"                    # Use the first subnet, in case there are no ipv4 subnets"},{"line_number":135,"context_line":"                    if not load_balancer.vip.subnet_id:"},{"line_number":136,"context_line":"                        load_balancer.vip.subnet_id \u003d subnet_id"},{"line_number":137,"context_line":"                    subnet \u003d network_driver.get_subnet(subnet_id)"},{"line_number":138,"context_line":"                    if subnet.ip_version \u003d\u003d 4:"},{"line_number":139,"context_line":"                        load_balancer.vip.subnet_id \u003d subnet_id"}],"source_content_type":"text/x-python","patch_set":12,"id":"da36d5c6_1d6863ba","line":136,"range":{"start_line":135,"start_character":20,"end_line":136,"end_character":63},"updated":"2017-02-17 22:04:14.000000000","message":"Doesn\u0027t this mean it will never check another subnet on the network?","commit_id":"91abfe5bd32ba3460c93d8b63dd47c9c72316075"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7efd9ffb83c3b367dcf8de9a71ffe424e9cc28b5","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                network_driver \u003d utils.get_network_driver()"},{"line_number":133,"context_line":"                for subnet_id in network.subnets:"},{"line_number":134,"context_line":"                    # Use the first subnet, in case there are no ipv4 subnets"},{"line_number":135,"context_line":"                    if not load_balancer.vip.subnet_id:"},{"line_number":136,"context_line":"                        load_balancer.vip.subnet_id \u003d subnet_id"},{"line_number":137,"context_line":"                    subnet \u003d network_driver.get_subnet(subnet_id)"},{"line_number":138,"context_line":"                    if subnet.ip_version \u003d\u003d 4:"},{"line_number":139,"context_line":"                        load_balancer.vip.subnet_id \u003d subnet_id"}],"source_content_type":"text/x-python","patch_set":12,"id":"da36d5c6_1dca2350","line":136,"range":{"start_line":135,"start_character":20,"end_line":136,"end_character":63},"in_reply_to":"da36d5c6_1d6863ba","updated":"2017-02-17 22:27:07.000000000","message":"Nevermind, I see now.","commit_id":"91abfe5bd32ba3460c93d8b63dd47c9c72316075"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a6da913380cec389b926d931d404507351373f3b","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                        load_balancer.vip.subnet_id \u003d subnet_id"},{"line_number":137,"context_line":"                    subnet \u003d network_driver.get_subnet(subnet_id)"},{"line_number":138,"context_line":"                    if subnet.ip_version \u003d\u003d 4:"},{"line_number":139,"context_line":"                        load_balancer.vip.subnet_id \u003d subnet_id"},{"line_number":140,"context_line":"                        break"},{"line_number":141,"context_line":"                if not load_balancer.vip.subnet_id:"},{"line_number":142,"context_line":"                    raise exceptions.ValidationException(detail\u003d_("}],"source_content_type":"text/x-python","patch_set":12,"id":"da36d5c6_1d96a394","line":139,"range":{"start_line":139,"start_character":24,"end_line":139,"end_character":63},"updated":"2017-02-17 22:04:14.000000000","message":"Why are we assigning this again?\n\nI don\u0027t think this overall logic is what you want.","commit_id":"91abfe5bd32ba3460c93d8b63dd47c9c72316075"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7efd9ffb83c3b367dcf8de9a71ffe424e9cc28b5","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                        load_balancer.vip.subnet_id \u003d subnet_id"},{"line_number":137,"context_line":"                    subnet \u003d network_driver.get_subnet(subnet_id)"},{"line_number":138,"context_line":"                    if subnet.ip_version \u003d\u003d 4:"},{"line_number":139,"context_line":"                        load_balancer.vip.subnet_id \u003d subnet_id"},{"line_number":140,"context_line":"                        break"},{"line_number":141,"context_line":"                if not load_balancer.vip.subnet_id:"},{"line_number":142,"context_line":"                    raise exceptions.ValidationException(detail\u003d_("}],"source_content_type":"text/x-python","patch_set":12,"id":"da36d5c6_fdb46fd2","line":139,"range":{"start_line":139,"start_character":24,"end_line":139,"end_character":63},"in_reply_to":"da36d5c6_1d96a394","updated":"2017-02-17 22:27:07.000000000","message":"Nevermind, I see now.","commit_id":"91abfe5bd32ba3460c93d8b63dd47c9c72316075"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"e5d3b53891b520daf49d02fd7c392d90e5191bb2","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                        load_balancer.vip.subnet_id \u003d subnet_id"},{"line_number":137,"context_line":"                    subnet \u003d network_driver.get_subnet(subnet_id)"},{"line_number":138,"context_line":"                    if subnet.ip_version \u003d\u003d 4:"},{"line_number":139,"context_line":"                        load_balancer.vip.subnet_id \u003d subnet_id"},{"line_number":140,"context_line":"                        break"},{"line_number":141,"context_line":"                if not load_balancer.vip.subnet_id:"},{"line_number":142,"context_line":"                    raise exceptions.ValidationException(detail\u003d_("}],"source_content_type":"text/x-python","patch_set":12,"id":"da36d5c6_7d2cffab","line":139,"range":{"start_line":139,"start_character":24,"end_line":139,"end_character":63},"in_reply_to":"da36d5c6_fdb46fd2","updated":"2017-02-17 22:51:22.000000000","message":"Yeah if you have a cleaner way to do this, please let me know -- trying to minimize external calls, while still getting the first ipv4 subnet else the first subnet period.","commit_id":"91abfe5bd32ba3460c93d8b63dd47c9c72316075"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a6da913380cec389b926d931d404507351373f3b","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                    ))"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        # Validate just the subnet id"},{"line_number":147,"context_line":"        elif load_balancer.vip.subnet_id:"},{"line_number":148,"context_line":"            subnet \u003d validate.subnet_exists("},{"line_number":149,"context_line":"                subnet_id\u003dload_balancer.vip.subnet_id)"},{"line_number":150,"context_line":"            load_balancer.vip.network_id \u003d subnet.network_id"}],"source_content_type":"text/x-python","patch_set":12,"id":"da36d5c6_12f8527c","line":147,"updated":"2017-02-17 22:04:14.000000000","message":"Shouldn\u0027t we also validate the port_id?","commit_id":"91abfe5bd32ba3460c93d8b63dd47c9c72316075"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"e5d3b53891b520daf49d02fd7c392d90e5191bb2","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                    ))"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        # Validate just the subnet id"},{"line_number":147,"context_line":"        elif load_balancer.vip.subnet_id:"},{"line_number":148,"context_line":"            subnet \u003d validate.subnet_exists("},{"line_number":149,"context_line":"                subnet_id\u003dload_balancer.vip.subnet_id)"},{"line_number":150,"context_line":"            load_balancer.vip.network_id \u003d subnet.network_id"}],"source_content_type":"text/x-python","patch_set":12,"id":"da36d5c6_7d031f10","line":147,"in_reply_to":"da36d5c6_12f8527c","updated":"2017-02-17 22:51:22.000000000","message":"Ah, maybe? This wasn\u0027t done originally, so I didn\u0027t even think to add it, but I can.","commit_id":"91abfe5bd32ba3460c93d8b63dd47c9c72316075"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"cdb8b29d895315d8c2102397d9a683f06839ca10","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                    ))"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        # Validate just the subnet id"},{"line_number":147,"context_line":"        elif load_balancer.vip.subnet_id:"},{"line_number":148,"context_line":"            subnet \u003d validate.subnet_exists("},{"line_number":149,"context_line":"                subnet_id\u003dload_balancer.vip.subnet_id)"},{"line_number":150,"context_line":"            load_balancer.vip.network_id \u003d subnet.network_id"}],"source_content_type":"text/x-python","patch_set":12,"id":"da36d5c6_1802313f","line":147,"in_reply_to":"da36d5c6_7d031f10","updated":"2017-02-17 23:36:40.000000000","message":"Done","commit_id":"91abfe5bd32ba3460c93d8b63dd47c9c72316075"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"5aa0c59ccb175a0361d509a64be1bc2fc9d58361","unresolved":false,"context_lines":[{"line_number":33,"context_line":"import octavia.common.validate as validate"},{"line_number":34,"context_line":"from octavia.db import api as db_api"},{"line_number":35,"context_line":"from octavia.db import prepare as db_prepare"},{"line_number":36,"context_line":"from octavia.i18n import _, _LI"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"CONF \u003d cfg.CONF"},{"line_number":39,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba2be162_98869ad9","line":36,"range":{"start_line":36,"start_character":28,"end_line":36,"end_character":31},"updated":"2017-03-02 20:05:10.000000000","message":"where it is used?","commit_id":"cfce3429a2e987dec7b2353c70eef270867f3955"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"053e871d60cde995fc0909f33fe4fcbc26e39b67","unresolved":false,"context_lines":[{"line_number":33,"context_line":"import octavia.common.validate as validate"},{"line_number":34,"context_line":"from octavia.db import api as db_api"},{"line_number":35,"context_line":"from octavia.db import prepare as db_prepare"},{"line_number":36,"context_line":"from octavia.i18n import _, _LI"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"CONF \u003d cfg.CONF"},{"line_number":39,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba2be162_1077dad3","line":36,"range":{"start_line":36,"start_character":28,"end_line":36,"end_character":31},"in_reply_to":"ba2be162_2973a216","updated":"2017-03-02 23:02:46.000000000","message":"Per IRC, the _LI was already present, and I assume if unused it\u0027d be a pep8 error?","commit_id":"cfce3429a2e987dec7b2353c70eef270867f3955"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"e5ccc2d35bb2915819894503b033cecf5ef21025","unresolved":false,"context_lines":[{"line_number":33,"context_line":"import octavia.common.validate as validate"},{"line_number":34,"context_line":"from octavia.db import api as db_api"},{"line_number":35,"context_line":"from octavia.db import prepare as db_prepare"},{"line_number":36,"context_line":"from octavia.i18n import _, _LI"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"CONF \u003d cfg.CONF"},{"line_number":39,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba2be162_2973a216","line":36,"range":{"start_line":36,"start_character":28,"end_line":36,"end_character":31},"in_reply_to":"ba2be162_98869ad9","updated":"2017-03-02 21:19:53.000000000","message":"A number of places. Though, I\u0027m not sure if I NEED to import it... It might be one of those magical things that just works?","commit_id":"cfce3429a2e987dec7b2353c70eef270867f3955"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"e5ccc2d35bb2915819894503b033cecf5ef21025","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                project_id \u003d load_balancer.project_id"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        if not project_id:"},{"line_number":115,"context_line":"            raise exceptions.ValidationException(detail\u003d_("},{"line_number":116,"context_line":"                \"Missing project ID in request where one is required.\"))"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        load_balancer.project_id \u003d project_id"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba2be162_89580e8c","line":115,"updated":"2017-03-02 21:19:53.000000000","message":"Here is one place I use _()","commit_id":"cfce3429a2e987dec7b2353c70eef270867f3955"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"5aa0c59ccb175a0361d509a64be1bc2fc9d58361","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        load_balancer.project_id \u003d project_id"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        if not (load_balancer.vip.port_id"},{"line_number":121,"context_line":"                or load_balancer.vip.network_id"},{"line_number":122,"context_line":"                or load_balancer.vip.subnet_id):"},{"line_number":123,"context_line":"            raise exceptions.ValidationException(detail\u003d_("},{"line_number":124,"context_line":"                \"VIP must contain one of: port_id, network_id, subnet_id.\"))"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        # Validate the port id"},{"line_number":127,"context_line":"        if load_balancer.vip.port_id:"},{"line_number":128,"context_line":"            port \u003d validate.port_exists(port_id\u003dload_balancer.vip.port_id)"},{"line_number":129,"context_line":"            load_balancer.vip.network_id \u003d port.network_id"},{"line_number":130,"context_line":"        # If no port id, validate the network id (and subnet if provided)"},{"line_number":131,"context_line":"        elif load_balancer.vip.network_id:"},{"line_number":132,"context_line":"            network \u003d validate.network_exists_optionally_contains_subnet("},{"line_number":133,"context_line":"                network_id\u003dload_balancer.vip.network_id,"},{"line_number":134,"context_line":"                subnet_id\u003dload_balancer.vip.subnet_id)"},{"line_number":135,"context_line":"            # If subnet is not provided, pick the first subnet, preferring ipv4"},{"line_number":136,"context_line":"            if not load_balancer.vip.subnet_id:"},{"line_number":137,"context_line":"                network_driver \u003d utils.get_network_driver()"},{"line_number":138,"context_line":"                for subnet_id in network.subnets:"},{"line_number":139,"context_line":"                    # Use the first subnet, in case there are no ipv4 subnets"},{"line_number":140,"context_line":"                    if not load_balancer.vip.subnet_id:"},{"line_number":141,"context_line":"                        load_balancer.vip.subnet_id \u003d subnet_id"},{"line_number":142,"context_line":"                    subnet \u003d network_driver.get_subnet(subnet_id)"},{"line_number":143,"context_line":"                    if subnet.ip_version \u003d\u003d 4:"},{"line_number":144,"context_line":"                        load_balancer.vip.subnet_id \u003d subnet_id"},{"line_number":145,"context_line":"                        break"},{"line_number":146,"context_line":"                if not load_balancer.vip.subnet_id:"},{"line_number":147,"context_line":"                    raise exceptions.ValidationException(detail\u003d_("},{"line_number":148,"context_line":"                        \"Supplied network does not contain a subnet.\""},{"line_number":149,"context_line":"                    ))"},{"line_number":150,"context_line":"        # Validate just the subnet id"},{"line_number":151,"context_line":"        elif load_balancer.vip.subnet_id:"},{"line_number":152,"context_line":"            subnet \u003d validate.subnet_exists("},{"line_number":153,"context_line":"                subnet_id\u003dload_balancer.vip.subnet_id)"},{"line_number":154,"context_line":"            load_balancer.vip.network_id \u003d subnet.network_id"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        lock_session \u003d db_api.get_session(autocommit\u003dFalse)"},{"line_number":157,"context_line":"        if self.repositories.check_quota_met("}],"source_content_type":"text/x-python","patch_set":15,"id":"ba2be162_18738a16","line":154,"range":{"start_line":120,"start_character":8,"end_line":154,"end_character":60},"updated":"2017-03-02 20:05:10.000000000","message":"please make this readable","commit_id":"cfce3429a2e987dec7b2353c70eef270867f3955"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"053e871d60cde995fc0909f33fe4fcbc26e39b67","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        load_balancer.project_id \u003d project_id"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        if not (load_balancer.vip.port_id"},{"line_number":121,"context_line":"                or load_balancer.vip.network_id"},{"line_number":122,"context_line":"                or load_balancer.vip.subnet_id):"},{"line_number":123,"context_line":"            raise exceptions.ValidationException(detail\u003d_("},{"line_number":124,"context_line":"                \"VIP must contain one of: port_id, network_id, subnet_id.\"))"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        # Validate the port id"},{"line_number":127,"context_line":"        if load_balancer.vip.port_id:"},{"line_number":128,"context_line":"            port \u003d validate.port_exists(port_id\u003dload_balancer.vip.port_id)"},{"line_number":129,"context_line":"            load_balancer.vip.network_id \u003d port.network_id"},{"line_number":130,"context_line":"        # If no port id, validate the network id (and subnet if provided)"},{"line_number":131,"context_line":"        elif load_balancer.vip.network_id:"},{"line_number":132,"context_line":"            network \u003d validate.network_exists_optionally_contains_subnet("},{"line_number":133,"context_line":"                network_id\u003dload_balancer.vip.network_id,"},{"line_number":134,"context_line":"                subnet_id\u003dload_balancer.vip.subnet_id)"},{"line_number":135,"context_line":"            # If subnet is not provided, pick the first subnet, preferring ipv4"},{"line_number":136,"context_line":"            if not load_balancer.vip.subnet_id:"},{"line_number":137,"context_line":"                network_driver \u003d utils.get_network_driver()"},{"line_number":138,"context_line":"                for subnet_id in network.subnets:"},{"line_number":139,"context_line":"                    # Use the first subnet, in case there are no ipv4 subnets"},{"line_number":140,"context_line":"                    if not load_balancer.vip.subnet_id:"},{"line_number":141,"context_line":"                        load_balancer.vip.subnet_id \u003d subnet_id"},{"line_number":142,"context_line":"                    subnet \u003d network_driver.get_subnet(subnet_id)"},{"line_number":143,"context_line":"                    if subnet.ip_version \u003d\u003d 4:"},{"line_number":144,"context_line":"                        load_balancer.vip.subnet_id \u003d subnet_id"},{"line_number":145,"context_line":"                        break"},{"line_number":146,"context_line":"                if not load_balancer.vip.subnet_id:"},{"line_number":147,"context_line":"                    raise exceptions.ValidationException(detail\u003d_("},{"line_number":148,"context_line":"                        \"Supplied network does not contain a subnet.\""},{"line_number":149,"context_line":"                    ))"},{"line_number":150,"context_line":"        # Validate just the subnet id"},{"line_number":151,"context_line":"        elif load_balancer.vip.subnet_id:"},{"line_number":152,"context_line":"            subnet \u003d validate.subnet_exists("},{"line_number":153,"context_line":"                subnet_id\u003dload_balancer.vip.subnet_id)"},{"line_number":154,"context_line":"            load_balancer.vip.network_id \u003d subnet.network_id"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        lock_session \u003d db_api.get_session(autocommit\u003dFalse)"},{"line_number":157,"context_line":"        if self.repositories.check_quota_met("}],"source_content_type":"text/x-python","patch_set":15,"id":"ba2be162_704c969e","line":154,"range":{"start_line":120,"start_character":8,"end_line":154,"end_character":60},"in_reply_to":"ba2be162_094dfec3","updated":"2017-03-02 23:02:46.000000000","message":"Moved the big middle part to a new function.","commit_id":"cfce3429a2e987dec7b2353c70eef270867f3955"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"e5ccc2d35bb2915819894503b033cecf5ef21025","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        load_balancer.project_id \u003d project_id"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        if not (load_balancer.vip.port_id"},{"line_number":121,"context_line":"                or load_balancer.vip.network_id"},{"line_number":122,"context_line":"                or load_balancer.vip.subnet_id):"},{"line_number":123,"context_line":"            raise exceptions.ValidationException(detail\u003d_("},{"line_number":124,"context_line":"                \"VIP must contain one of: port_id, network_id, subnet_id.\"))"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        # Validate the port id"},{"line_number":127,"context_line":"        if load_balancer.vip.port_id:"},{"line_number":128,"context_line":"            port \u003d validate.port_exists(port_id\u003dload_balancer.vip.port_id)"},{"line_number":129,"context_line":"            load_balancer.vip.network_id \u003d port.network_id"},{"line_number":130,"context_line":"        # If no port id, validate the network id (and subnet if provided)"},{"line_number":131,"context_line":"        elif load_balancer.vip.network_id:"},{"line_number":132,"context_line":"            network \u003d validate.network_exists_optionally_contains_subnet("},{"line_number":133,"context_line":"                network_id\u003dload_balancer.vip.network_id,"},{"line_number":134,"context_line":"                subnet_id\u003dload_balancer.vip.subnet_id)"},{"line_number":135,"context_line":"            # If subnet is not provided, pick the first subnet, preferring ipv4"},{"line_number":136,"context_line":"            if not load_balancer.vip.subnet_id:"},{"line_number":137,"context_line":"                network_driver \u003d utils.get_network_driver()"},{"line_number":138,"context_line":"                for subnet_id in network.subnets:"},{"line_number":139,"context_line":"                    # Use the first subnet, in case there are no ipv4 subnets"},{"line_number":140,"context_line":"                    if not load_balancer.vip.subnet_id:"},{"line_number":141,"context_line":"                        load_balancer.vip.subnet_id \u003d subnet_id"},{"line_number":142,"context_line":"                    subnet \u003d network_driver.get_subnet(subnet_id)"},{"line_number":143,"context_line":"                    if subnet.ip_version \u003d\u003d 4:"},{"line_number":144,"context_line":"                        load_balancer.vip.subnet_id \u003d subnet_id"},{"line_number":145,"context_line":"                        break"},{"line_number":146,"context_line":"                if not load_balancer.vip.subnet_id:"},{"line_number":147,"context_line":"                    raise exceptions.ValidationException(detail\u003d_("},{"line_number":148,"context_line":"                        \"Supplied network does not contain a subnet.\""},{"line_number":149,"context_line":"                    ))"},{"line_number":150,"context_line":"        # Validate just the subnet id"},{"line_number":151,"context_line":"        elif load_balancer.vip.subnet_id:"},{"line_number":152,"context_line":"            subnet \u003d validate.subnet_exists("},{"line_number":153,"context_line":"                subnet_id\u003dload_balancer.vip.subnet_id)"},{"line_number":154,"context_line":"            load_balancer.vip.network_id \u003d subnet.network_id"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        lock_session \u003d db_api.get_session(autocommit\u003dFalse)"},{"line_number":157,"context_line":"        if self.repositories.check_quota_met("}],"source_content_type":"text/x-python","patch_set":15,"id":"ba2be162_094dfec3","line":154,"range":{"start_line":120,"start_character":8,"end_line":154,"end_character":60},"in_reply_to":"ba2be162_18738a16","updated":"2017-03-02 21:19:53.000000000","message":"Is it ... not? I mean, would more spacing help? I added comments throughout, I thought that would be good enough?","commit_id":"cfce3429a2e987dec7b2353c70eef270867f3955"}],"octavia/common/validate.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a6da913380cec389b926d931d404507351373f3b","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        network \u003d network_driver.get_network(network_id)"},{"line_number":223,"context_line":"    except Exception:"},{"line_number":224,"context_line":"        raise exceptions.InvalidSubresource(resource\u003d\u0027Network\u0027, id\u003dnetwork_id)"},{"line_number":225,"context_line":"    if subnet_id:"},{"line_number":226,"context_line":"        if not network.subnets or subnet_id not in [s.id for s"},{"line_number":227,"context_line":"                                                    in network.subnets]:"},{"line_number":228,"context_line":"            raise exceptions.InvalidSubresource(resource\u003d\u0027Subnet\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"da36d5c6_120cd241","line":225,"range":{"start_line":225,"start_character":4,"end_line":225,"end_character":17},"updated":"2017-02-17 22:04:14.000000000","message":"Doesn\u0027t this mean it won\u0027t validate that the network even has a subnet?  The title of this method implies it checks if there even is a subnet.","commit_id":"91abfe5bd32ba3460c93d8b63dd47c9c72316075"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"e5d3b53891b520daf49d02fd7c392d90e5191bb2","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        network \u003d network_driver.get_network(network_id)"},{"line_number":223,"context_line":"    except Exception:"},{"line_number":224,"context_line":"        raise exceptions.InvalidSubresource(resource\u003d\u0027Network\u0027, id\u003dnetwork_id)"},{"line_number":225,"context_line":"    if subnet_id:"},{"line_number":226,"context_line":"        if not network.subnets or subnet_id not in [s.id for s"},{"line_number":227,"context_line":"                                                    in network.subnets]:"},{"line_number":228,"context_line":"            raise exceptions.InvalidSubresource(resource\u003d\u0027Subnet\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"da36d5c6_5d581b57","line":225,"range":{"start_line":225,"start_character":4,"end_line":225,"end_character":17},"in_reply_to":"da36d5c6_120cd241","updated":"2017-02-17 22:51:22.000000000","message":"Ah, that\u0027s a case of the method-name being misleading then, the intention is \"check the network exists, and if given a subnet make sure it is inside that network\". I can rename it.","commit_id":"91abfe5bd32ba3460c93d8b63dd47c9c72316075"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"cdb8b29d895315d8c2102397d9a683f06839ca10","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        network \u003d network_driver.get_network(network_id)"},{"line_number":223,"context_line":"    except Exception:"},{"line_number":224,"context_line":"        raise exceptions.InvalidSubresource(resource\u003d\u0027Network\u0027, id\u003dnetwork_id)"},{"line_number":225,"context_line":"    if subnet_id:"},{"line_number":226,"context_line":"        if not network.subnets or subnet_id not in [s.id for s"},{"line_number":227,"context_line":"                                                    in network.subnets]:"},{"line_number":228,"context_line":"            raise exceptions.InvalidSubresource(resource\u003d\u0027Subnet\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"da36d5c6_38fff535","line":225,"range":{"start_line":225,"start_character":4,"end_line":225,"end_character":17},"in_reply_to":"da36d5c6_5d581b57","updated":"2017-02-17 23:36:40.000000000","message":"Done","commit_id":"91abfe5bd32ba3460c93d8b63dd47c9c72316075"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"8b22f304c99fd8db4034e9480a587e870e7c89cd","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        raise exceptions.InvalidSubresource(resource\u003d\u0027Network\u0027, id\u003dnetwork_id)"},{"line_number":235,"context_line":"    if subnet_id:"},{"line_number":236,"context_line":"        if not network.subnets or subnet_id not in [s.id for s"},{"line_number":237,"context_line":"                                                    in network.subnets]:"},{"line_number":238,"context_line":"            raise exceptions.InvalidSubresource(resource\u003d\u0027Subnet\u0027,"},{"line_number":239,"context_line":"                                                id\u003dsubnet_id)"},{"line_number":240,"context_line":"    return network"}],"source_content_type":"text/x-python","patch_set":13,"id":"da36d5c6_1c5dbce9","line":237,"updated":"2017-02-18 20:37:08.000000000","message":"Actually looks like there is a bug here, same issue as the last one I fixed (I originally thought network.subnets contained subnet objects, but it\u0027s just a list of IDs). Unfortunately the unit test is wrong because I misunderstood this when I was writing it. \u003e_\u003e","commit_id":"6f54fcce50eda9b0909908e03c1b3c8e4fcc91c4"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f18628204ad4f70b08db5798aad2ee832c7e7f52","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    network_driver \u003d utils.get_network_driver()"},{"line_number":208,"context_line":"    try:"},{"line_number":209,"context_line":"        port \u003d network_driver.get_port(port_id)"},{"line_number":210,"context_line":"    except Exception:"},{"line_number":211,"context_line":"        raise exceptions.InvalidSubresource(resource\u003d\u0027Port\u0027, id\u003dport_id)"},{"line_number":212,"context_line":"    return port"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba2be162_6d14c39f","line":210,"updated":"2017-03-02 22:33:36.000000000","message":"There is no unit test for this exception","commit_id":"cfce3429a2e987dec7b2353c70eef270867f3955"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f9b7f13eddbb0cda7d9df5e5cccb07b1500837dc","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    network_driver \u003d utils.get_network_driver()"},{"line_number":208,"context_line":"    try:"},{"line_number":209,"context_line":"        port \u003d network_driver.get_port(port_id)"},{"line_number":210,"context_line":"    except Exception:"},{"line_number":211,"context_line":"        raise exceptions.InvalidSubresource(resource\u003d\u0027Port\u0027, id\u003dport_id)"},{"line_number":212,"context_line":"    return port"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba2be162_70f01668","line":210,"in_reply_to":"ba2be162_6d14c39f","updated":"2017-03-02 22:58:44.000000000","message":"Done","commit_id":"cfce3429a2e987dec7b2353c70eef270867f3955"}],"octavia/network/drivers/neutron/allowed_address_pairs.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f18628204ad4f70b08db5798aad2ee832c7e7f52","unresolved":false,"context_lines":[{"line_number":337,"context_line":"                         \u0027device_owner\u0027: OCTAVIA_OWNER}}"},{"line_number":338,"context_line":"        try:"},{"line_number":339,"context_line":"            new_port \u003d self.neutron_client.create_port(port)"},{"line_number":340,"context_line":"        except Exception:"},{"line_number":341,"context_line":"            message \u003d _(\u0027Error creating neutron port on network \u0027"},{"line_number":342,"context_line":"                        \u0027{network_id}.\u0027).format("},{"line_number":343,"context_line":"                network_id\u003dload_balancer.vip.network_id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba2be162_0da3479e","line":340,"updated":"2017-03-02 22:33:36.000000000","message":"There is no unit test covering this exception case","commit_id":"cfce3429a2e987dec7b2353c70eef270867f3955"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f9b7f13eddbb0cda7d9df5e5cccb07b1500837dc","unresolved":false,"context_lines":[{"line_number":337,"context_line":"                         \u0027device_owner\u0027: OCTAVIA_OWNER}}"},{"line_number":338,"context_line":"        try:"},{"line_number":339,"context_line":"            new_port \u003d self.neutron_client.create_port(port)"},{"line_number":340,"context_line":"        except Exception:"},{"line_number":341,"context_line":"            message \u003d _(\u0027Error creating neutron port on network \u0027"},{"line_number":342,"context_line":"                        \u0027{network_id}.\u0027).format("},{"line_number":343,"context_line":"                network_id\u003dload_balancer.vip.network_id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba2be162_30e4deaa","line":340,"in_reply_to":"ba2be162_0da3479e","updated":"2017-03-02 22:58:44.000000000","message":"Done","commit_id":"cfce3429a2e987dec7b2353c70eef270867f3955"}],"octavia/tests/functional/api/v1/base.py":[{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"5aa0c59ccb175a0361d509a64be1bc2fc9d58361","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import pecan.testing"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from octavia.api import config as pconfig"},{"line_number":23,"context_line":"# needed for tests to function when run independently:"},{"line_number":24,"context_line":"from octavia.common import config  # noqa: F401"},{"line_number":25,"context_line":"from octavia.common import constants"},{"line_number":26,"context_line":"from octavia.db import api as db_api"},{"line_number":27,"context_line":"from octavia.db import repositories"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba2be162_f856b628","line":24,"range":{"start_line":23,"start_character":0,"end_line":24,"end_character":47},"updated":"2017-03-02 20:05:10.000000000","message":"I don\u0027t understand it. What does it mean to run independently?","commit_id":"cfce3429a2e987dec7b2353c70eef270867f3955"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"053e871d60cde995fc0909f33fe4fcbc26e39b67","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import pecan.testing"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from octavia.api import config as pconfig"},{"line_number":23,"context_line":"# needed for tests to function when run independently:"},{"line_number":24,"context_line":"from octavia.common import config  # noqa: F401"},{"line_number":25,"context_line":"from octavia.common import constants"},{"line_number":26,"context_line":"from octavia.db import api as db_api"},{"line_number":27,"context_line":"from octavia.db import repositories"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba2be162_906aeaec","line":24,"range":{"start_line":23,"start_character":0,"end_line":24,"end_character":47},"in_reply_to":"ba2be162_f856b628","updated":"2017-03-02 23:02:46.000000000","message":"Fixed per your suggestion in IRC.","commit_id":"cfce3429a2e987dec7b2353c70eef270867f3955"}]}
