)]}'
{"etc/octavia.conf":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b6092b5f4e897c210482ff9ec115036c0ccd3f0e","unresolved":false,"context_lines":[{"line_number":279,"context_line":"# Disable certificate validation on SSL connections"},{"line_number":280,"context_line":"# insecure \u003d False"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"# Maximum length for Amphora name. Default \u003d 0 (none)"},{"line_number":283,"context_line":"# max_name_length \u003d 0"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"[glance]"}],"source_content_type":"text/plain","patch_set":2,"id":"1a430d35_a0dbc47a","line":282,"updated":"2017-02-08 23:35:55.000000000","message":"We should at least mention here that it will use a random string.\nAlso, you should note that it will prefix \"a\"","commit_id":"a9386c171bb03e0dcf19e2730a09728bf81c48af"}],"octavia/common/config.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b6092b5f4e897c210482ff9ec115036c0ccd3f0e","unresolved":false,"context_lines":[{"line_number":397,"context_line":"                help\u003d_(\u0027Flag to indicate if nova anti-affinity feature is \u0027"},{"line_number":398,"context_line":"                       \u0027turned on.\u0027)),"},{"line_number":399,"context_line":"    cfg.IntOpt(\u0027max_name_length\u0027, default\u003d0,"},{"line_number":400,"context_line":"               help\u003d_(\u0027Maximum length for Amphora name. Default \u003d 0 (none)\u0027))"},{"line_number":401,"context_line":"]"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"neutron_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_e0294c9c","line":400,"range":{"start_line":400,"start_character":22,"end_line":400,"end_character":76},"updated":"2017-02-08 23:35:55.000000000","message":"We should at least mention here that it will use a random string.\nAlso, you should note that it will prefix \"a\"","commit_id":"a9386c171bb03e0dcf19e2730a09728bf81c48af"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"54e1368e221bdbe1095d962a246e31fb4d293d0a","unresolved":false,"context_lines":[{"line_number":397,"context_line":"                help\u003d_(\u0027Flag to indicate if nova anti-affinity feature is \u0027"},{"line_number":398,"context_line":"                       \u0027turned on.\u0027)),"},{"line_number":399,"context_line":"    cfg.IntOpt(\u0027max_name_length\u0027, default\u003d0,"},{"line_number":400,"context_line":"               help\u003d_(\u0027Maximum length for Amphora name. Default \u003d 0 (none)\u0027))"},{"line_number":401,"context_line":"]"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"neutron_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_abae452b","line":400,"range":{"start_line":400,"start_character":22,"end_line":400,"end_character":76},"in_reply_to":"1a430d35_e0294c9c","updated":"2017-02-09 00:11:02.000000000","message":"Yeah, will do. I was doing \"o-\" originally, but \"a\" for amp is fine I think, and is the minimum number of characters to get something that\u0027s at least somewhat recognizable as belonging to an amp.","commit_id":"a9386c171bb03e0dcf19e2730a09728bf81c48af"}],"octavia/compute/drivers/nova_driver.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b6092b5f4e897c210482ff9ec115036c0ccd3f0e","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                name \u003d \"\".join("},{"line_number":143,"context_line":"                    [r.choice(string.ascii_uppercase + string.digits)"},{"line_number":144,"context_line":"                     for i in range(CONF.nova.max_name_length)])"},{"line_number":145,"context_line":"                if CONF.nova.max_name_length \u003e 1:"},{"line_number":146,"context_line":"                    name \u003d \"a\" + name[:-1]"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"            amphora \u003d self.manager.create("}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_dd8d17d4","line":145,"updated":"2017-02-08 23:35:55.000000000","message":"Umm, this seems like a total overload of the meaning of that configuration setting.\nSince this is random does name collision matter?\nIt is nice to be able to at least trace back the amp / instance.","commit_id":"a9386c171bb03e0dcf19e2730a09728bf81c48af"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"54e1368e221bdbe1095d962a246e31fb4d293d0a","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                name \u003d \"\".join("},{"line_number":143,"context_line":"                    [r.choice(string.ascii_uppercase + string.digits)"},{"line_number":144,"context_line":"                     for i in range(CONF.nova.max_name_length)])"},{"line_number":145,"context_line":"                if CONF.nova.max_name_length \u003e 1:"},{"line_number":146,"context_line":"                    name \u003d \"a\" + name[:-1]"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"            amphora \u003d self.manager.create("}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_0bbf5961","line":145,"in_reply_to":"1a430d35_dd8d17d4","updated":"2017-02-09 00:11:02.000000000","message":"Yes, it\u0027s a little bit of an overload, in that I\u0027m trying to solve for two problems at once and they aren\u0027t technically related (name length restriction AND uniqueness requirement).\nOriginally what I was doing was removing hyphens from the UUID and then clipping it to the correct length, but due to the way UUID works that was \"less random\" (character limits, AND a certain set of bits in a UUID are fixed).","commit_id":"a9386c171bb03e0dcf19e2730a09728bf81c48af"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b6092b5f4e897c210482ff9ec115036c0ccd3f0e","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                    [r.choice(string.ascii_uppercase + string.digits)"},{"line_number":144,"context_line":"                     for i in range(CONF.nova.max_name_length)])"},{"line_number":145,"context_line":"                if CONF.nova.max_name_length \u003e 1:"},{"line_number":146,"context_line":"                    name \u003d \"a\" + name[:-1]"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"            amphora \u003d self.manager.create("},{"line_number":149,"context_line":"                name\u003dname, image\u003dimage_id, flavor\u003damphora_flavor,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_406ce007","line":146,"updated":"2017-02-08 23:35:55.000000000","message":"String concat with +?","commit_id":"a9386c171bb03e0dcf19e2730a09728bf81c48af"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b6092b5f4e897c210482ff9ec115036c0ccd3f0e","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                    [r.choice(string.ascii_uppercase + string.digits)"},{"line_number":144,"context_line":"                     for i in range(CONF.nova.max_name_length)])"},{"line_number":145,"context_line":"                if CONF.nova.max_name_length \u003e 1:"},{"line_number":146,"context_line":"                    name \u003d \"a\" + name[:-1]"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"            amphora \u003d self.manager.create("},{"line_number":149,"context_line":"                name\u003dname, image\u003dimage_id, flavor\u003damphora_flavor,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_60463c7c","line":146,"range":{"start_line":146,"start_character":37,"end_line":146,"end_character":42},"updated":"2017-02-08 23:35:55.000000000","message":"This generates one extra random character that just gets dropped.  Why not n-1 the range above?","commit_id":"a9386c171bb03e0dcf19e2730a09728bf81c48af"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"54e1368e221bdbe1095d962a246e31fb4d293d0a","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                    [r.choice(string.ascii_uppercase + string.digits)"},{"line_number":144,"context_line":"                     for i in range(CONF.nova.max_name_length)])"},{"line_number":145,"context_line":"                if CONF.nova.max_name_length \u003e 1:"},{"line_number":146,"context_line":"                    name \u003d \"a\" + name[:-1]"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"            amphora \u003d self.manager.create("},{"line_number":149,"context_line":"                name\u003dname, image\u003dimage_id, flavor\u003damphora_flavor,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_cbfb9145","line":146,"range":{"start_line":146,"start_character":37,"end_line":146,"end_character":42},"in_reply_to":"1a430d35_60463c7c","updated":"2017-02-09 00:11:02.000000000","message":"Ah actually I realized that it should be fine if I do that above, I was thinking it\u0027d be a problem but that was just my sick-brain. I\u0027ll remove this.","commit_id":"a9386c171bb03e0dcf19e2730a09728bf81c48af"}]}