)]}'
{"octavia/api/v1/controllers/load_balancer.py":[{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"7cebbb2037b8179c873f67ce71cf609ee079ffa6","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        context \u003d pecan.request.context.get(\u0027octavia_context\u0027)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        project_id \u003d context.project_id"},{"line_number":109,"context_line":"        if context.is_admin or CONF.auth_strategy \u003d\u003d constants.NOAUTH:"},{"line_number":110,"context_line":"            if load_balancer.project_id:"},{"line_number":111,"context_line":"                project_id \u003d load_balancer.project_id"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_f1fb1379","line":109,"range":{"start_line":109,"start_character":8,"end_line":109,"end_character":70},"updated":"2017-02-14 16:28:53.000000000","message":"but admin should be able to change project_id. With this code there is no way to override that value. Admin should be able to specify in post data project_id.","commit_id":"108ab279524d323552d825387e34d5ef0520292b"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"90db670c1b297907f2ea4dc81f4f66e402844287","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        context \u003d pecan.request.context.get(\u0027octavia_context\u0027)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        project_id \u003d context.project_id"},{"line_number":109,"context_line":"        if context.is_admin or CONF.auth_strategy \u003d\u003d constants.NOAUTH:"},{"line_number":110,"context_line":"            if load_balancer.project_id:"},{"line_number":111,"context_line":"                project_id \u003d load_balancer.project_id"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_ea723510","line":109,"range":{"start_line":109,"start_character":8,"end_line":109,"end_character":70},"in_reply_to":"fa31d9ce_a401543a","updated":"2017-02-14 18:12:18.000000000","message":"OK, my mistake. I saw load_balancer and I thought that it\u0027s taken from DB object not post. Sorry for that.","commit_id":"108ab279524d323552d825387e34d5ef0520292b"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d73e9b39cdb6ff68f8a6012a7de9ca8a38fc98de","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        context \u003d pecan.request.context.get(\u0027octavia_context\u0027)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        project_id \u003d context.project_id"},{"line_number":109,"context_line":"        if context.is_admin or CONF.auth_strategy \u003d\u003d constants.NOAUTH:"},{"line_number":110,"context_line":"            if load_balancer.project_id:"},{"line_number":111,"context_line":"                project_id \u003d load_balancer.project_id"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_a401543a","line":109,"range":{"start_line":109,"start_character":8,"end_line":109,"end_character":70},"in_reply_to":"fa31d9ce_e21dff62","updated":"2017-02-14 17:36:30.000000000","message":"I believe so?","commit_id":"108ab279524d323552d825387e34d5ef0520292b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a111de6836dcde830c967ab029e127755ffc05d4","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        context \u003d pecan.request.context.get(\u0027octavia_context\u0027)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        project_id \u003d context.project_id"},{"line_number":109,"context_line":"        if context.is_admin or CONF.auth_strategy \u003d\u003d constants.NOAUTH:"},{"line_number":110,"context_line":"            if load_balancer.project_id:"},{"line_number":111,"context_line":"                project_id \u003d load_balancer.project_id"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_e21dff62","line":109,"range":{"start_line":109,"start_character":8,"end_line":109,"end_character":70},"in_reply_to":"fa31d9ce_f1fb1379","updated":"2017-02-14 17:05:25.000000000","message":"Isn\u0027t that what the two lines below are doing?","commit_id":"108ab279524d323552d825387e34d5ef0520292b"}],"octavia/api/v1/controllers/quotas.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"968eb59e0b4f2dfd9c650560c3842ae25b9210e9","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        \"\"\"Update any or all quotas for a project.\"\"\""},{"line_number":56,"context_line":"        context \u003d pecan.request.context.get(\u0027octavia_context\u0027)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        new_project_id \u003d context.project_id"},{"line_number":59,"context_line":"        if context.is_admin or CONF.auth_strategy \u003d\u003d constants.NOAUTH:"},{"line_number":60,"context_line":"            if project_id:"},{"line_number":61,"context_line":"                new_project_id \u003d project_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_7130b0e9","line":58,"updated":"2017-02-09 14:57:44.000000000","message":"mmh, shouldn\u0027t only admins be able to update the quota?","commit_id":"c9fd3958e4c440881ab261dc2a8299cd135d44eb"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6674495f07ef2773ed598e780b68b1cea965caae","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        \"\"\"Update any or all quotas for a project.\"\"\""},{"line_number":56,"context_line":"        context \u003d pecan.request.context.get(\u0027octavia_context\u0027)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        new_project_id \u003d context.project_id"},{"line_number":59,"context_line":"        if context.is_admin or CONF.auth_strategy \u003d\u003d constants.NOAUTH:"},{"line_number":60,"context_line":"            if project_id:"},{"line_number":61,"context_line":"                new_project_id \u003d project_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_f22c71ad","line":58,"in_reply_to":"1a430d35_435da147","updated":"2017-02-10 17:57:00.000000000","message":"Yes, the code of policies is merged, it\u0027s just the validation part that isn\u0027t yet implemented.  We needed the base API controller code in place first.","commit_id":"c9fd3958e4c440881ab261dc2a8299cd135d44eb"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"07f308d9a68dff829076a10181cc19a3d3596d4b","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        \"\"\"Update any or all quotas for a project.\"\"\""},{"line_number":56,"context_line":"        context \u003d pecan.request.context.get(\u0027octavia_context\u0027)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        new_project_id \u003d context.project_id"},{"line_number":59,"context_line":"        if context.is_admin or CONF.auth_strategy \u003d\u003d constants.NOAUTH:"},{"line_number":60,"context_line":"            if project_id:"},{"line_number":61,"context_line":"                new_project_id \u003d project_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_435da147","line":58,"in_reply_to":"1a430d35_654d4ac4","updated":"2017-02-09 18:59:19.000000000","message":"Yeah, this should be handled by the oslo_policy stuff, right?\nI thought diltram was working on that, does he have a patch up for it?","commit_id":"c9fd3958e4c440881ab261dc2a8299cd135d44eb"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b64c97471967f4a201dc736882308823c4bb37f5","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        \"\"\"Update any or all quotas for a project.\"\"\""},{"line_number":56,"context_line":"        context \u003d pecan.request.context.get(\u0027octavia_context\u0027)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        new_project_id \u003d context.project_id"},{"line_number":59,"context_line":"        if context.is_admin or CONF.auth_strategy \u003d\u003d constants.NOAUTH:"},{"line_number":60,"context_line":"            if project_id:"},{"line_number":61,"context_line":"                new_project_id \u003d project_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_654d4ac4","line":58,"in_reply_to":"1a430d35_7130b0e9","updated":"2017-02-09 16:25:26.000000000","message":"We don\u0027t really have policy validation yet, but that is a good question....","commit_id":"c9fd3958e4c440881ab261dc2a8299cd135d44eb"}],"releasenotes/notes/api-create-project-id-4bb984b24d56de2e.yaml":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"07f308d9a68dff829076a10181cc19a3d3596d4b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    These objects will use the parent load balancer\u0027s project_id."},{"line_number":7,"context_line":"    Values passed into the project_id on those objects will be ignored"},{"line_number":8,"context_line":"    until the deprecation cycle has expired, at which point they will"},{"line_number":9,"context_line":"    cause an error.  "}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a430d35_c32fd1a5","line":9,"updated":"2017-02-09 18:59:19.000000000","message":"nit: extra space","commit_id":"c9fd3958e4c440881ab261dc2a8299cd135d44eb"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"adbeb8fde49464334fc6dfc72b7b15b798a0aa0e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    These objects will use the parent load balancer\u0027s project_id."},{"line_number":7,"context_line":"    Values passed into the project_id on those objects will be ignored"},{"line_number":8,"context_line":"    until the deprecation cycle has expired, at which point they will"},{"line_number":9,"context_line":"    cause an error.  "}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa31d9ce_b420269d","line":9,"in_reply_to":"1a430d35_c32fd1a5","updated":"2017-02-10 17:58:15.000000000","message":"Done","commit_id":"c9fd3958e4c440881ab261dc2a8299cd135d44eb"}]}