)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3f88600ee4d4842744087c871025b8fe5bbfd02f","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        octavia_dib_tracing_arg\u003d\"-x\""},{"line_number":41,"context_line":"    fi"},{"line_number":42,"context_line":"    if ! [ -f $OCTAVIA_AMP_IMAGE_FILE ]; then"},{"line_number":43,"context_line":"        $OCTAVIA_DIR/diskimage-create/diskimage-create.sh $octavia_dib_tracing_arg -s 2 -o $OCTAVIA_AMP_IMAGE_FILE -i ${OCTAVIA_AMP_BASE_OS:-ubuntu}"},{"line_number":44,"context_line":"    fi"},{"line_number":45,"context_line":"    upload_image file://${OCTAVIA_AMP_IMAGE_FILE} $TOKEN"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa31d9ce_707ee8af","line":43,"range":{"start_line":43,"start_character":140,"end_line":43,"end_character":148},"updated":"2017-02-09 21:51:37.000000000","message":"Adam make a good point.  We shouldn\u0027t also define a default here as there is already one in the diskimage-create script.  We should only have one location for the default settings.","commit_id":"132874cc2fc33108f9cd9a6e1f93b96285168187"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8cd652aa8b32a911673dadb2713bf70a4e9065bd","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        octavia_dib_tracing_arg\u003d\"-x\""},{"line_number":41,"context_line":"    fi"},{"line_number":42,"context_line":"    if ! [ -f $OCTAVIA_AMP_IMAGE_FILE ]; then"},{"line_number":43,"context_line":"        $OCTAVIA_DIR/diskimage-create/diskimage-create.sh $octavia_dib_tracing_arg -s 2 -o $OCTAVIA_AMP_IMAGE_FILE -i ${OCTAVIA_AMP_BASE_OS:-ubuntu}"},{"line_number":44,"context_line":"    fi"},{"line_number":45,"context_line":"    upload_image file://${OCTAVIA_AMP_IMAGE_FILE} $TOKEN"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a430d35_e3504d0d","line":43,"updated":"2017-02-09 18:35:12.000000000","message":"I think we should also expose the release parameter here,\n\u0027-d\u0027 distribution release id (default on ubuntu: xenial)\"\nInclude it only if it is defined vs. setting a default.","commit_id":"132874cc2fc33108f9cd9a6e1f93b96285168187"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"48a4cab0640cbec14edc254bf7cf787b5a14afff","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        octavia_dib_tracing_arg\u003d\"-x\""},{"line_number":41,"context_line":"    fi"},{"line_number":42,"context_line":"    if ! [ -f $OCTAVIA_AMP_IMAGE_FILE ]; then"},{"line_number":43,"context_line":"        $OCTAVIA_DIR/diskimage-create/diskimage-create.sh $octavia_dib_tracing_arg -s 2 -o $OCTAVIA_AMP_IMAGE_FILE -i ${OCTAVIA_AMP_BASE_OS:-ubuntu}"},{"line_number":44,"context_line":"    fi"},{"line_number":45,"context_line":"    upload_image file://${OCTAVIA_AMP_IMAGE_FILE} $TOKEN"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa31d9ce_d412a456","line":43,"in_reply_to":"1a430d35_e3504d0d","updated":"2017-02-13 22:37:30.000000000","message":"Done. See OCTAVIA_AMP_DISTRIBUTION_RELEASE_ID","commit_id":"132874cc2fc33108f9cd9a6e1f93b96285168187"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"48a4cab0640cbec14edc254bf7cf787b5a14afff","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        octavia_dib_tracing_arg\u003d\"-x\""},{"line_number":41,"context_line":"    fi"},{"line_number":42,"context_line":"    if ! [ -f $OCTAVIA_AMP_IMAGE_FILE ]; then"},{"line_number":43,"context_line":"        $OCTAVIA_DIR/diskimage-create/diskimage-create.sh $octavia_dib_tracing_arg -s 2 -o $OCTAVIA_AMP_IMAGE_FILE -i ${OCTAVIA_AMP_BASE_OS:-ubuntu}"},{"line_number":44,"context_line":"    fi"},{"line_number":45,"context_line":"    upload_image file://${OCTAVIA_AMP_IMAGE_FILE} $TOKEN"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa31d9ce_d439c4d8","line":43,"range":{"start_line":43,"start_character":140,"end_line":43,"end_character":148},"in_reply_to":"fa31d9ce_707ee8af","updated":"2017-02-13 22:37:30.000000000","message":"Done.\nAgreed. In PS4, if unset, nothing is passed to diskimage-create dso the script defaults are used.","commit_id":"132874cc2fc33108f9cd9a6e1f93b96285168187"}]}