)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"71ffdadd5e78f9b736c292fc8cd8f262b1eee426","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support vip bandwidth limitation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is spec for the feature."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ia47da1e26106c6353eebd880138df4b57bcf9db4"},{"line_number":12,"context_line":"Closes-Bug: #1657090"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a1ced50_b3ade4ea","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":29},"updated":"2017-03-23 02:59:17.000000000","message":"lets make it a bit more detailed","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"}],"specs/version1/vip-bandwidth-limitation.rst":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"5b7400d4a96b44839d4ddd347976294a8587d302","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Alternatives"},{"line_number":45,"context_line":"------------"},{"line_number":46,"context_line":"None"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Data model impact"},{"line_number":49,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_e9b2fc04","line":46,"updated":"2017-03-06 15:09:27.000000000","message":"There are two alternatives:\n1)  We expose the ports Octavia uses so the user can apply QoS, Security Groups, FWaaS, etc. -- but this might be too clunky?\n2) We let the user pass in a QoS policy he has created...","commit_id":"fa272c6a735e9f92ca22850aeb8489c1359de2f1"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"c1266d9e14d4dc3fed6e79ddefdc73c7263c7deb","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Alternatives"},{"line_number":45,"context_line":"------------"},{"line_number":46,"context_line":"None"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Data model impact"},{"line_number":49,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_0351a60e","line":46,"in_reply_to":"ba2be162_e9b2fc04","updated":"2017-03-08 02:10:30.000000000","message":"Thank you very much for this details. About 1), could we intro a \"vip payload\" which contains what more function user want?\njust a sample:\nI want QoS, SG, FWaas\n\n{\n  \"vip payload\":\n            {\n               \"QOS\":{},\n               \"SG\": {},\n               \"FWaas\":{}\n             }\n \n}","commit_id":"fa272c6a735e9f92ca22850aeb8489c1359de2f1"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"5b7400d4a96b44839d4ddd347976294a8587d302","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                   \u0027vip_qos_policy_id\u0027:{\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":61,"context_line":"                                        \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":62,"context_line":"                                        \u0027is_visible\u0027: True}"},{"line_number":63,"context_line":"                   \u0027max_kbps\u0027: {"},{"line_number":64,"context_line":"                                 \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":65,"context_line":"                                 \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":66,"context_line":"                                 \u0027validate\u0027: {None}}"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_89a7c0a5","line":63,"updated":"2017-03-06 15:09:27.000000000","message":"I have seen people getting confused with units so maybe we should do bytes? Thoughts?","commit_id":"fa272c6a735e9f92ca22850aeb8489c1359de2f1"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"c1266d9e14d4dc3fed6e79ddefdc73c7263c7deb","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                   \u0027vip_qos_policy_id\u0027:{\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":61,"context_line":"                                        \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":62,"context_line":"                                        \u0027is_visible\u0027: True}"},{"line_number":63,"context_line":"                   \u0027max_kbps\u0027: {"},{"line_number":64,"context_line":"                                 \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":65,"context_line":"                                 \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":66,"context_line":"                                 \u0027validate\u0027: {None}}"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_63b0a244","line":63,"in_reply_to":"ba2be162_89a7c0a5","updated":"2017-03-08 02:10:30.000000000","message":"This kust is the same with the defination with Qos.","commit_id":"fa272c6a735e9f92ca22850aeb8489c1359de2f1"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"5b7400d4a96b44839d4ddd347976294a8587d302","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Create/Update Loadbalancer Request::"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        POST /v2.0/lbaas/loadbalancers"},{"line_number":78,"context_line":"        {"},{"line_number":79,"context_line":"            \"loadbalancer\": {"},{"line_number":80,"context_line":"                \"name\": \"loadbalancer1\","}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_09003065","line":77,"updated":"2017-03-06 15:09:27.000000000","message":"Shouldn\u0027t update be a PUT?","commit_id":"fa272c6a735e9f92ca22850aeb8489c1359de2f1"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"c1266d9e14d4dc3fed6e79ddefdc73c7263c7deb","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Create/Update Loadbalancer Request::"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        POST /v2.0/lbaas/loadbalancers"},{"line_number":78,"context_line":"        {"},{"line_number":79,"context_line":"            \"loadbalancer\": {"},{"line_number":80,"context_line":"                \"name\": \"loadbalancer1\","}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_a2580658","line":77,"in_reply_to":"ba2be162_09003065","updated":"2017-03-08 02:10:30.000000000","message":"Thanks, this can be apply into POST/PUT request. This is my fault for not clear here. :). I will make it better.","commit_id":"fa272c6a735e9f92ca22850aeb8489c1359de2f1"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"5b7400d4a96b44839d4ddd347976294a8587d302","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"Testing"},{"line_number":175,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":176,"context_line":"Api tests from neutron-lbaas will be used to validate the new octavia API."},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Documentation Impact"},{"line_number":179,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba2be162_a91ac47a","line":176,"updated":"2017-03-06 15:09:27.000000000","message":"We will also need scenario tests --","commit_id":"fa272c6a735e9f92ca22850aeb8489c1359de2f1"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"c1266d9e14d4dc3fed6e79ddefdc73c7263c7deb","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"Testing"},{"line_number":175,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":176,"context_line":"Api tests from neutron-lbaas will be used to validate the new octavia API."},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Documentation Impact"},{"line_number":179,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_03860665","line":176,"in_reply_to":"ba2be162_a91ac47a","updated":"2017-03-08 02:10:30.000000000","message":"Thank you for reminding.:)","commit_id":"fa272c6a735e9f92ca22850aeb8489c1359de2f1"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"ef56a80dd3e02ed0de96f3bab8bfda1943f4867e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                         \u0027is_visible\u0027: True, \u0027default\u0027: 0,"},{"line_number":74,"context_line":"                         \u0027validate\u0027: {None}}"},{"line_number":75,"context_line":"        }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Some samples in Loadbalancer creation/update."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Create/Update Loadbalancer Request::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a30ddce_83a01fa1","line":76,"updated":"2017-03-08 15:08:17.000000000","message":"We should probably say that we either expect a policy id OR max_kbps/max_burst_kbps BUT not both.","commit_id":"61ac68b358961b2d72f7e374e64b6e2d7f14472f"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"36c3c6b9af348d5f8f6d7dcd8e0e334dab71d429","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                         \u0027is_visible\u0027: True, \u0027default\u0027: 0,"},{"line_number":74,"context_line":"                         \u0027validate\u0027: {None}}"},{"line_number":75,"context_line":"        }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Some samples in Loadbalancer creation/update."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Create/Update Loadbalancer Request::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a30ddce_3227a0b7","line":76,"in_reply_to":"9a30ddce_83a01fa1","updated":"2017-03-09 07:27:12.000000000","message":"Thank you very much. It is right. We need 1 of them, not both.","commit_id":"61ac68b358961b2d72f7e374e64b6e2d7f14472f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"4702be28c03d3c15f3831ab970c55a6baa2dfec9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  FWaaS, etc. -- TBD"},{"line_number":48,"context_line":"* Allow users to pass the QoS policy in Loadbalancer creation or update."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Data model impact"},{"line_number":51,"context_line":"-----------------"},{"line_number":52,"context_line":"There will be some minor data model changes to octavia in support of this"},{"line_number":53,"context_line":"change."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a1ff146_1a81424b","line":50,"updated":"2017-03-14 18:16:59.000000000","message":"Since you are proposing Octavia to create/manage QoS policies, we will also need to have a table (qos_policy) to track those.\nproject_id, policy_id, max_kbps, max_burst_kbps","commit_id":"09e969401535cc29c7f51e1d2bcf69bd3e75e811"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"26780569d1e409623a9ca72bba050244f86c6545","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  FWaaS, etc. -- TBD"},{"line_number":48,"context_line":"* Allow users to pass the QoS policy in Loadbalancer creation or update."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Data model impact"},{"line_number":51,"context_line":"-----------------"},{"line_number":52,"context_line":"There will be some minor data model changes to octavia in support of this"},{"line_number":53,"context_line":"change."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a1ff146_7df91080","line":50,"in_reply_to":"3a1ff146_1a81424b","updated":"2017-03-16 01:59:06.000000000","message":"Yeah, thanks for your kind suggesion. Originlly, I think we don\u0027t need to maintain the info, as neutron side had one already. But for your said, I think if we need control the qos, the necessary info of qos we must manage too. I think you are right.:)","commit_id":"09e969401535cc29c7f51e1d2bcf69bd3e75e811"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"4702be28c03d3c15f3831ab970c55a6baa2dfec9","unresolved":false,"context_lines":[{"line_number":53,"context_line":"change."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"* vip table"},{"line_number":56,"context_line":"  - `vip_qos_policy_id`: associated Qos policy id with vip port."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"REST API impact"},{"line_number":59,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a1ff146_5adada79","line":56,"range":{"start_line":56,"start_character":5,"end_line":56,"end_character":22},"updated":"2017-03-14 18:16:59.000000000","message":"vip is redundant here, the table is vip","commit_id":"09e969401535cc29c7f51e1d2bcf69bd3e75e811"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"26780569d1e409623a9ca72bba050244f86c6545","unresolved":false,"context_lines":[{"line_number":53,"context_line":"change."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"* vip table"},{"line_number":56,"context_line":"  - `vip_qos_policy_id`: associated Qos policy id with vip port."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"REST API impact"},{"line_number":59,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a1ff146_5d39b440","line":56,"range":{"start_line":56,"start_character":5,"end_line":56,"end_character":22},"in_reply_to":"3a1ff146_5adada79","updated":"2017-03-16 01:59:06.000000000","message":"Ok, thanks. :P","commit_id":"09e969401535cc29c7f51e1d2bcf69bd3e75e811"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"4702be28c03d3c15f3831ab970c55a6baa2dfec9","unresolved":false,"context_lines":[{"line_number":61,"context_line":"Proposed attribute::"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        EXTEND_FIELDS \u003d {"},{"line_number":64,"context_line":"            \u0027vip_qos_policy_id\u0027:{\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":65,"context_line":"                                \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":66,"context_line":"                                \u0027is_visible\u0027: True},"},{"line_number":67,"context_line":"            \u0027max_kbps\u0027: {"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a1ff146_1a5dc2e9","line":64,"range":{"start_line":64,"start_character":33,"end_line":64,"end_character":73},"updated":"2017-03-14 18:16:59.000000000","message":"So you are saying they cannot pass in a neutron qos_policy_id?  Why not?","commit_id":"09e969401535cc29c7f51e1d2bcf69bd3e75e811"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"26780569d1e409623a9ca72bba050244f86c6545","unresolved":false,"context_lines":[{"line_number":61,"context_line":"Proposed attribute::"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        EXTEND_FIELDS \u003d {"},{"line_number":64,"context_line":"            \u0027vip_qos_policy_id\u0027:{\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":65,"context_line":"                                \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":66,"context_line":"                                \u0027is_visible\u0027: True},"},{"line_number":67,"context_line":"            \u0027max_kbps\u0027: {"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a1ff146_3d84f8d2","line":64,"range":{"start_line":64,"start_character":33,"end_line":64,"end_character":73},"in_reply_to":"3a1ff146_1a5dc2e9","updated":"2017-03-16 01:59:06.000000000","message":"Sorry, michael, this must be my mistake. I intro user could pass an qos_policy_id. But this field I take a wrong value here. It should be \u0027allow_post\u0027: true, \u0027allow_put\u0027:true.","commit_id":"09e969401535cc29c7f51e1d2bcf69bd3e75e811"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"4702be28c03d3c15f3831ab970c55a6baa2dfec9","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            \u0027max_kbps\u0027: {"},{"line_number":68,"context_line":"                         \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":69,"context_line":"                         \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":70,"context_line":"                         \u0027validate\u0027: {None}},"},{"line_number":71,"context_line":"            \u0027max_burst_kbps\u0027: {"},{"line_number":72,"context_line":"                         \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":73,"context_line":"                         \u0027is_visible\u0027: True, \u0027default\u0027: 0,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a1ff146_ba2bce32","line":70,"range":{"start_line":70,"start_character":37,"end_line":70,"end_character":43},"updated":"2017-03-14 18:16:59.000000000","message":"We can validate they are positive integers at least.  Maybe neutron has a max value?","commit_id":"09e969401535cc29c7f51e1d2bcf69bd3e75e811"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"26780569d1e409623a9ca72bba050244f86c6545","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            \u0027max_kbps\u0027: {"},{"line_number":68,"context_line":"                         \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":69,"context_line":"                         \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":70,"context_line":"                         \u0027validate\u0027: {None}},"},{"line_number":71,"context_line":"            \u0027max_burst_kbps\u0027: {"},{"line_number":72,"context_line":"                         \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":73,"context_line":"                         \u0027is_visible\u0027: True, \u0027default\u0027: 0,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a1ff146_dd4a04ac","line":70,"range":{"start_line":70,"start_character":37,"end_line":70,"end_character":43},"in_reply_to":"3a1ff146_ba2bce32","updated":"2017-03-16 01:59:06.000000000","message":"Yeah, thanks very much, michael. Neutron side defined this in the positive int range like [0, max_value].","commit_id":"09e969401535cc29c7f51e1d2bcf69bd3e75e811"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"573cdbf65a6c6130497ef29b58308a85c7798de3","unresolved":false,"context_lines":[{"line_number":166,"context_line":"Work Items"},{"line_number":167,"context_line":"----------"},{"line_number":168,"context_line":"* Add the DB model and extend the table column."},{"line_number":169,"context_line":"* Extending Octavia/neutron lbaas API to accept Qos fields."},{"line_number":170,"context_line":"* Add Qos logic into Loadbalancer workflow."},{"line_number":171,"context_line":"* Add UTs to Octavia."},{"line_number":172,"context_line":"* Add API tests."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a1ff146_5ae49a0c","line":169,"updated":"2017-03-14 18:20:02.000000000","message":"Let\u0027s only add this in Octavia V2 API and not try to add it to neutron-lbaas.","commit_id":"09e969401535cc29c7f51e1d2bcf69bd3e75e811"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"26780569d1e409623a9ca72bba050244f86c6545","unresolved":false,"context_lines":[{"line_number":166,"context_line":"Work Items"},{"line_number":167,"context_line":"----------"},{"line_number":168,"context_line":"* Add the DB model and extend the table column."},{"line_number":169,"context_line":"* Extending Octavia/neutron lbaas API to accept Qos fields."},{"line_number":170,"context_line":"* Add Qos logic into Loadbalancer workflow."},{"line_number":171,"context_line":"* Add UTs to Octavia."},{"line_number":172,"context_line":"* Add API tests."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a1ff146_fdeee089","line":169,"in_reply_to":"3a1ff146_5ae49a0c","updated":"2017-03-16 01:59:06.000000000","message":"OK. I will rework this spec according your kind suggesion.","commit_id":"09e969401535cc29c7f51e1d2bcf69bd3e75e811"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"573cdbf65a6c6130497ef29b58308a85c7798de3","unresolved":false,"context_lines":[{"line_number":171,"context_line":"* Add UTs to Octavia."},{"line_number":172,"context_line":"* Add API tests."},{"line_number":173,"context_line":"* Update CLI to accept Qos fields."},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Dependencies"},{"line_number":176,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":177,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a1ff146_dabecad3","line":174,"updated":"2017-03-14 18:20:02.000000000","message":"Documentation\nAdd API validation code to validate access/existence of the qos_policy in neutron.","commit_id":"09e969401535cc29c7f51e1d2bcf69bd3e75e811"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"26780569d1e409623a9ca72bba050244f86c6545","unresolved":false,"context_lines":[{"line_number":171,"context_line":"* Add UTs to Octavia."},{"line_number":172,"context_line":"* Add API tests."},{"line_number":173,"context_line":"* Update CLI to accept Qos fields."},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Dependencies"},{"line_number":176,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":177,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a1ff146_fd9500e4","line":174,"in_reply_to":"3a1ff146_dabecad3","updated":"2017-03-16 01:59:06.000000000","message":"Agree. Thank you again.","commit_id":"09e969401535cc29c7f51e1d2bcf69bd3e75e811"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9ec13810cebde700099f2a1e6d469d45e0ed0095","unresolved":false,"context_lines":[{"line_number":32,"context_line":"focus on the attached port \"octavia-lb-vrrp-LOADBALNCER_ID\"."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"We could apply the Neutron qos policy which contains the bandwidth limit rule"},{"line_number":35,"context_line":"to the \"octavia-lb-vrrp-LOADBALNCER_ID\" ports, whatever the topology is"},{"line_number":36,"context_line":"active-passive or active-active."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"There are the following changes:"},{"line_number":39,"context_line":"* Extend a new column named \"vip_qos_policy_id\" in vip table."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a1ced50_e5523634","line":36,"range":{"start_line":35,"start_character":47,"end_line":36,"end_character":32},"updated":"2017-03-23 02:40:30.000000000","message":"whether the topology is active-active or active-passive","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"bcda3045f11bc6cc0c16ab46cfb11d13096895c5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"focus on the attached port \"octavia-lb-vrrp-LOADBALNCER_ID\"."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"We could apply the Neutron qos policy which contains the bandwidth limit rule"},{"line_number":35,"context_line":"to the \"octavia-lb-vrrp-LOADBALNCER_ID\" ports, whatever the topology is"},{"line_number":36,"context_line":"active-passive or active-active."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"There are the following changes:"},{"line_number":39,"context_line":"* Extend a new column named \"vip_qos_policy_id\" in vip table."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a1ced50_68b8db75","line":36,"range":{"start_line":35,"start_character":47,"end_line":36,"end_character":32},"in_reply_to":"1a1ced50_e5523634","updated":"2017-03-29 01:56:26.000000000","message":"OH, Thanks. Nice catch. :)","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"86b19266b9bb7922c114357325ec45c8a23599f1","unresolved":false,"context_lines":[{"line_number":32,"context_line":"focus on the attached port \"octavia-lb-vrrp-LOADBALNCER_ID\"."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"We could apply the Neutron qos policy which contains the bandwidth limit rule"},{"line_number":35,"context_line":"to the \"octavia-lb-vrrp-LOADBALNCER_ID\" ports, whatever the topology is"},{"line_number":36,"context_line":"active-passive or active-active."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"There are the following changes:"},{"line_number":39,"context_line":"* Extend a new column named \"vip_qos_policy_id\" in vip table."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ffe62b97_0a6623c2","line":36,"range":{"start_line":35,"start_character":47,"end_line":36,"end_character":32},"in_reply_to":"1a1ced50_e5523634","updated":"2017-03-29 00:16:33.000000000","message":"Or standalone","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"bcda3045f11bc6cc0c16ab46cfb11d13096895c5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"focus on the attached port \"octavia-lb-vrrp-LOADBALNCER_ID\"."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"We could apply the Neutron qos policy which contains the bandwidth limit rule"},{"line_number":35,"context_line":"to the \"octavia-lb-vrrp-LOADBALNCER_ID\" ports, whatever the topology is"},{"line_number":36,"context_line":"active-passive or active-active."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"There are the following changes:"},{"line_number":39,"context_line":"* Extend a new column named \"vip_qos_policy_id\" in vip table."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ffe62b97_0d7f5de0","line":36,"range":{"start_line":35,"start_character":47,"end_line":36,"end_character":32},"in_reply_to":"ffe62b97_0a6623c2","updated":"2017-03-29 01:56:26.000000000","message":"@Michael， Thank you.:)","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"17751277621fb42ee9b93f6e19b6b4c99093323c","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"There are the following changes:"},{"line_number":39,"context_line":"* Extend a new column named \"vip_qos_policy_id\" in vip table."},{"line_number":40,"context_line":"* Extend octavia API, we need pass the qos-policy or the bandwidth details"},{"line_number":41,"context_line":"into LoadBalancer creation/update."},{"line_number":42,"context_line":"* Add qos policy creation/update in Loadbalancer working flow."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a1ced50_cf755e64","line":41,"range":{"start_line":40,"start_character":2,"end_line":41,"end_character":34},"updated":"2017-03-22 21:12:22.000000000","message":"I have thought about this more.  Is there a reason we need to accept the max_kbps and max_burst_kbps?\nI am thinking this would be much simpler and clean if we simply just accept a neutron qos_policy_id that we apply to the VIPs as part of load balancer create/update.","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9ec13810cebde700099f2a1e6d469d45e0ed0095","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"There are the following changes:"},{"line_number":39,"context_line":"* Extend a new column named \"vip_qos_policy_id\" in vip table."},{"line_number":40,"context_line":"* Extend octavia API, we need pass the qos-policy or the bandwidth details"},{"line_number":41,"context_line":"into LoadBalancer creation/update."},{"line_number":42,"context_line":"* Add qos policy creation/update in Loadbalancer working flow."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a1ced50_c819cf23","line":41,"range":{"start_line":40,"start_character":2,"end_line":41,"end_character":34},"in_reply_to":"1a1ced50_45406a07","updated":"2017-03-23 02:40:30.000000000","message":"Michael, I think that accepting a QoS policy which can have multiple QoS rules ( one for minimum bandwidth, once for DSCP marking, one for Max Bandwidth ) can become cumbersome for LoadBalancer.\nWhat we are looking at is a way to assure that the loadbalancer will not in any way go beyond the targetted bandwidth.\nIdeally we should allow the user to mention the Max Speed for VIP Port, and create a QoS Policy ( with shared\u003dFalse), QoS Rule, and QoS Bandwidth limit rule .\nThe one thing which I am worried about is , how can we stop a user from deleting the QoS resource without affecting Loadbalancer.\nWhat I think is, the device-owner field might be something we can use in QoS policy delete/rule delete/bandwidth limit rule delete to stop this.\n\nzhaobo : comments?","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"86b19266b9bb7922c114357325ec45c8a23599f1","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"There are the following changes:"},{"line_number":39,"context_line":"* Extend a new column named \"vip_qos_policy_id\" in vip table."},{"line_number":40,"context_line":"* Extend octavia API, we need pass the qos-policy or the bandwidth details"},{"line_number":41,"context_line":"into LoadBalancer creation/update."},{"line_number":42,"context_line":"* Add qos policy creation/update in Loadbalancer working flow."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ffe62b97_085e2e43","line":41,"range":{"start_line":40,"start_character":2,"end_line":41,"end_character":34},"in_reply_to":"1a1ced50_c819cf23","updated":"2017-03-29 00:16:33.000000000","message":"Neutron should not allow a delete on a qos_policy that is in use, the user would have to remove it from the load balancer first.\nI still think the simplest first step here is for octavia to accept a neutron qos_policy_id on the load balancer create/update.  octavia would then apply that policy to the VIP port.\nThis way we don\u0027t have to extend our API every time the capability of neutron QoS increases.\nAs for DSCP, if the user creating the qos_policy specifies it, they should be able to allow neutron to implement it. If a octavia driver honors it, great, if not it should just be ignored (haproxy driver and octavia driver do not look at the DSCP field).","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"95f90b86130a49ec87fc8f2ef51a772798942eee","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"There are the following changes:"},{"line_number":39,"context_line":"* Extend a new column named \"vip_qos_policy_id\" in vip table."},{"line_number":40,"context_line":"* Extend octavia API, we need pass the qos-policy or the bandwidth details"},{"line_number":41,"context_line":"into LoadBalancer creation/update."},{"line_number":42,"context_line":"* Add qos policy creation/update in Loadbalancer working flow."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a1ced50_45406a07","line":41,"range":{"start_line":40,"start_character":2,"end_line":41,"end_character":34},"in_reply_to":"1a1ced50_cf755e64","updated":"2017-03-23 02:02:04.000000000","message":"Hi, michael. My thought about this is users can input the details of Qos, then Octavia can use the related parameters to create Qos rule and Qos policy in neutron. Then we can appliy the created Qos policy to the LB ports. This may make user operation more simple.","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"bcda3045f11bc6cc0c16ab46cfb11d13096895c5","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"There are the following changes:"},{"line_number":39,"context_line":"* Extend a new column named \"vip_qos_policy_id\" in vip table."},{"line_number":40,"context_line":"* Extend octavia API, we need pass the qos-policy or the bandwidth details"},{"line_number":41,"context_line":"into LoadBalancer creation/update."},{"line_number":42,"context_line":"* Add qos policy creation/update in Loadbalancer working flow."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ffe62b97_303158a4","line":41,"range":{"start_line":40,"start_character":2,"end_line":41,"end_character":34},"in_reply_to":"ffe62b97_085e2e43","updated":"2017-03-29 01:56:26.000000000","message":"@Michael, Hi sir. You said is very correct. I had discussed with reedip. We are agree with you about accept the qos_policy_id only. And now neutron Qos provide bandwidth limitation, min bandwidth limitation and DSCP tag. I think the first and second is good for this feature, and the third one we can make it like your suggestion.But there is a place not clear that if the qos policy not contain any bandwidth limitation rules, octavia should check the qos policy? If not, this must be different with the spec target, as the title is bandwidth limitation addition, hah. But I think this is good for us(octavia), we have no idea to intro an new one about this.","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9ec13810cebde700099f2a1e6d469d45e0ed0095","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Alternatives"},{"line_number":45,"context_line":"------------"},{"line_number":46,"context_line":"* We expose the ports Octavia uses so the user can apply QoS, Security Groups,"},{"line_number":47,"context_line":"  FWaaS, etc. -- TBD"},{"line_number":48,"context_line":"* Allow users to pass the QoS policy in Loadbalancer creation or update."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a1ced50_c89e2f62","line":47,"range":{"start_line":46,"start_character":2,"end_line":47,"end_character":20},"updated":"2017-03-23 02:40:30.000000000","message":"This is an interesting approach.\n\n- Do we want port mirroring in load VIP ports? If so, TaaS can be used.\n- Do we want to prevent specific packets ? SG / FWaaS can be used depending on where the packets need to be stopped\n\nBut I am not sure if QoS would fit the bill here","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"86b19266b9bb7922c114357325ec45c8a23599f1","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Alternatives"},{"line_number":45,"context_line":"------------"},{"line_number":46,"context_line":"* We expose the ports Octavia uses so the user can apply QoS, Security Groups,"},{"line_number":47,"context_line":"  FWaaS, etc. -- TBD"},{"line_number":48,"context_line":"* Allow users to pass the QoS policy in Loadbalancer creation or update."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ffe62b97_483d56db","line":47,"range":{"start_line":46,"start_character":2,"end_line":47,"end_character":20},"in_reply_to":"1a1ced50_c89e2f62","updated":"2017-03-29 00:16:33.000000000","message":"I have concerns about this from a \"break the amnphora\" perspective.  We are discussing security groups in another patch/bug.","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"bcda3045f11bc6cc0c16ab46cfb11d13096895c5","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Alternatives"},{"line_number":45,"context_line":"------------"},{"line_number":46,"context_line":"* We expose the ports Octavia uses so the user can apply QoS, Security Groups,"},{"line_number":47,"context_line":"  FWaaS, etc. -- TBD"},{"line_number":48,"context_line":"* Allow users to pass the QoS policy in Loadbalancer creation or update."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Data model impact"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ffe62b97_5015fce3","line":47,"range":{"start_line":46,"start_character":2,"end_line":47,"end_character":20},"in_reply_to":"ffe62b97_483d56db","updated":"2017-03-29 01:56:26.000000000","message":"@all, Thanks. This way should be updated now. :).","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9ec13810cebde700099f2a1e6d469d45e0ed0095","unresolved":false,"context_lines":[{"line_number":45,"context_line":"------------"},{"line_number":46,"context_line":"* We expose the ports Octavia uses so the user can apply QoS, Security Groups,"},{"line_number":47,"context_line":"  FWaaS, etc. -- TBD"},{"line_number":48,"context_line":"* Allow users to pass the QoS policy in Loadbalancer creation or update."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Data model impact"},{"line_number":51,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a1ced50_0892074c","line":48,"range":{"start_line":48,"start_character":30,"end_line":48,"end_character":36},"updated":"2017-03-23 02:40:30.000000000","message":"I prefer QoS Bandwidth Limit Rule than QoS Policy","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"86b19266b9bb7922c114357325ec45c8a23599f1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"------------"},{"line_number":46,"context_line":"* We expose the ports Octavia uses so the user can apply QoS, Security Groups,"},{"line_number":47,"context_line":"  FWaaS, etc. -- TBD"},{"line_number":48,"context_line":"* Allow users to pass the QoS policy in Loadbalancer creation or update."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Data model impact"},{"line_number":51,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ffe62b97_0a8aa368","line":48,"range":{"start_line":48,"start_character":30,"end_line":48,"end_character":36},"in_reply_to":"1a1ced50_0892074c","updated":"2017-03-29 00:16:33.000000000","message":"I think it should be at the policy level and not the rule.  Policy is the top level object for neutron.","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"86b19266b9bb7922c114357325ec45c8a23599f1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"* vip table"},{"line_number":60,"context_line":"  - `qos_policy_id`: associated Qos policy id with vip port."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* qos_policies table"},{"line_number":63,"context_line":"  For the database schema, the following table constructs would suffice::"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    CREATE TABLE qos_policies ("},{"line_number":66,"context_line":"        `policy_id` varchar(36) NOT NULL,"},{"line_number":67,"context_line":"        `project_id` varchar(255) DEFAULT NULL,,"},{"line_number":68,"context_line":"        `max_kbps` int(11) DEFAULT NULL,"},{"line_number":69,"context_line":"        `max_burst_kbps` int(11) DEFAULT NULL,,"},{"line_number":70,"context_line":"         PRIMARY KEY (`id`),"},{"line_number":71,"context_line":"         UNIQUE KEY `policy_id` (`policy_id`)"},{"line_number":72,"context_line":"    );"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"REST API impact"},{"line_number":75,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ffe62b97_0aef431e","line":72,"range":{"start_line":62,"start_character":1,"end_line":72,"end_character":6},"updated":"2017-03-29 00:16:33.000000000","message":"I don\u0027t think we need this at all if we just take the qos_policy_id and apply it to the vip port.","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9ec13810cebde700099f2a1e6d469d45e0ed0095","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* qos_policies table"},{"line_number":63,"context_line":"  For the database schema, the following table constructs would suffice::"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    CREATE TABLE qos_policies ("},{"line_number":66,"context_line":"        `policy_id` varchar(36) NOT NULL,"},{"line_number":67,"context_line":"        `project_id` varchar(255) DEFAULT NULL,,"},{"line_number":68,"context_line":"        `max_kbps` int(11) DEFAULT NULL,"},{"line_number":69,"context_line":"        `max_burst_kbps` int(11) DEFAULT NULL,,"},{"line_number":70,"context_line":"         PRIMARY KEY (`id`),"},{"line_number":71,"context_line":"         UNIQUE KEY `policy_id` (`policy_id`)"},{"line_number":72,"context_line":"    );"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"REST API impact"},{"line_number":75,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a1ced50_48af9f7c","line":72,"range":{"start_line":64,"start_character":0,"end_line":72,"end_character":5},"updated":"2017-03-23 02:40:30.000000000","message":"do we actually need it ?\nI think we can just refer the neutron QoS DB table for this","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"bcda3045f11bc6cc0c16ab46cfb11d13096895c5","unresolved":false,"context_lines":[{"line_number":59,"context_line":"* vip table"},{"line_number":60,"context_line":"  - `qos_policy_id`: associated Qos policy id with vip port."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* qos_policies table"},{"line_number":63,"context_line":"  For the database schema, the following table constructs would suffice::"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    CREATE TABLE qos_policies ("},{"line_number":66,"context_line":"        `policy_id` varchar(36) NOT NULL,"},{"line_number":67,"context_line":"        `project_id` varchar(255) DEFAULT NULL,,"},{"line_number":68,"context_line":"        `max_kbps` int(11) DEFAULT NULL,"},{"line_number":69,"context_line":"        `max_burst_kbps` int(11) DEFAULT NULL,,"},{"line_number":70,"context_line":"         PRIMARY KEY (`id`),"},{"line_number":71,"context_line":"         UNIQUE KEY `policy_id` (`policy_id`)"},{"line_number":72,"context_line":"    );"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"REST API impact"},{"line_number":75,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ffe62b97_90e4a40e","line":72,"range":{"start_line":62,"start_character":1,"end_line":72,"end_character":6},"in_reply_to":"ffe62b97_0aef431e","updated":"2017-03-29 01:56:26.000000000","message":"Yeah, according to your both suggesion, this table is not needed now.:). We just need qos_policy_id.","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9ec13810cebde700099f2a1e6d469d45e0ed0095","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Proposed attribute::"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        EXTEND_FIELDS \u003d {"},{"line_number":80,"context_line":"            \u0027vip_qos_policy_id\u0027:{\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":81,"context_line":"                                \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":82,"context_line":"                                \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a1ced50_28e343da","line":79,"range":{"start_line":79,"start_character":8,"end_line":79,"end_character":21},"updated":"2017-03-23 02:40:30.000000000","message":"might be EXTENDED_V2?","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"86b19266b9bb7922c114357325ec45c8a23599f1","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Proposed attribute::"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        EXTEND_FIELDS \u003d {"},{"line_number":80,"context_line":"            \u0027vip_qos_policy_id\u0027:{\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":81,"context_line":"                                \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":82,"context_line":"                                \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ffe62b97_cacddbb7","line":79,"range":{"start_line":79,"start_character":8,"end_line":79,"end_character":21},"in_reply_to":"1a1ced50_28e343da","updated":"2017-03-29 00:16:33.000000000","message":"Actually, the way octavia does this is a bit simpler.\n\nIt would go here: https://github.com/openstack/octavia/blob/master/octavia/api/v2/types/load_balancer.py#L93\nand\nhttps://github.com/openstack/octavia/blob/master/octavia/api/v2/types/load_balancer.py#L105","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"bcda3045f11bc6cc0c16ab46cfb11d13096895c5","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Proposed attribute::"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        EXTEND_FIELDS \u003d {"},{"line_number":80,"context_line":"            \u0027vip_qos_policy_id\u0027:{\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":81,"context_line":"                                \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":82,"context_line":"                                \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ffe62b97_d0b7ccf4","line":79,"range":{"start_line":79,"start_character":8,"end_line":79,"end_character":21},"in_reply_to":"ffe62b97_cacddbb7","updated":"2017-03-29 01:56:26.000000000","message":"Thanks very much. It\u0027s just a sample.","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"86b19266b9bb7922c114357325ec45c8a23599f1","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            \u0027vip_qos_policy_id\u0027:{\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":81,"context_line":"                                \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":82,"context_line":"                                \u0027is_visible\u0027: True},"},{"line_number":83,"context_line":"            \u0027max_kbps\u0027: {"},{"line_number":84,"context_line":"                         \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":85,"context_line":"                         \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":86,"context_line":"                         \u0027validate\u0027: {\u0027type:range\u0027: [0, DB_MAX_INT_VALUE]}},"},{"line_number":87,"context_line":"            \u0027max_burst_kbps\u0027: {"},{"line_number":88,"context_line":"                         \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":89,"context_line":"                         \u0027is_visible\u0027: True, \u0027default\u0027: 0,"},{"line_number":90,"context_line":"                         \u0027validate\u0027: {\u0027type:range\u0027: [0, DB_MAX_INT_VALUE]}}"},{"line_number":91,"context_line":"        }"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Some samples in Loadbalancer creation/update. Users allow pass \"qos_policy_id\""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ffe62b97_6ae5af37","line":90,"range":{"start_line":83,"start_character":12,"end_line":90,"end_character":75},"updated":"2017-03-29 00:16:33.000000000","message":"I think we don\u0027t need these, just the policy id.","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"bcda3045f11bc6cc0c16ab46cfb11d13096895c5","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            \u0027vip_qos_policy_id\u0027:{\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":81,"context_line":"                                \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":82,"context_line":"                                \u0027is_visible\u0027: True},"},{"line_number":83,"context_line":"            \u0027max_kbps\u0027: {"},{"line_number":84,"context_line":"                         \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":85,"context_line":"                         \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":86,"context_line":"                         \u0027validate\u0027: {\u0027type:range\u0027: [0, DB_MAX_INT_VALUE]}},"},{"line_number":87,"context_line":"            \u0027max_burst_kbps\u0027: {"},{"line_number":88,"context_line":"                         \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":89,"context_line":"                         \u0027is_visible\u0027: True, \u0027default\u0027: 0,"},{"line_number":90,"context_line":"                         \u0027validate\u0027: {\u0027type:range\u0027: [0, DB_MAX_INT_VALUE]}}"},{"line_number":91,"context_line":"        }"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Some samples in Loadbalancer creation/update. Users allow pass \"qos_policy_id\""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ffe62b97_90cdc486","line":90,"range":{"start_line":83,"start_character":12,"end_line":90,"end_character":75},"in_reply_to":"ffe62b97_6ae5af37","updated":"2017-03-29 01:56:26.000000000","message":"Thanks, I will update this spec soon.","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"86b19266b9bb7922c114357325ec45c8a23599f1","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        }"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Some samples in Loadbalancer creation/update. Users allow pass \"qos_policy_id\""},{"line_number":94,"context_line":"or qos_limitation details(\"max_kbps\"/\"max_burst_kbps\"), but not both of them."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Create/Update Loadbalancer Request::"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ffe62b97_8ac35389","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":77},"updated":"2017-03-29 00:16:33.000000000","message":"Can we just do qos_policy_id?","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"bcda3045f11bc6cc0c16ab46cfb11d13096895c5","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        }"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Some samples in Loadbalancer creation/update. Users allow pass \"qos_policy_id\""},{"line_number":94,"context_line":"or qos_limitation details(\"max_kbps\"/\"max_burst_kbps\"), but not both of them."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Create/Update Loadbalancer Request::"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ffe62b97_f082d0ff","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":77},"in_reply_to":"ffe62b97_8ac35389","updated":"2017-03-29 01:56:26.000000000","message":"ditto.:). Thanks for your very comprehensive suggestion.","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9ec13810cebde700099f2a1e6d469d45e0ed0095","unresolved":false,"context_lines":[{"line_number":160,"context_line":"Users will be able to specified qos_policy or qos details to create/update"},{"line_number":161,"context_line":"Loadbalancers."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Performance Impact"},{"line_number":164,"context_line":"------------------"},{"line_number":165,"context_line":"None"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Other deployer impact"},{"line_number":168,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a1ced50_48fddf6c","line":165,"range":{"start_line":163,"start_character":0,"end_line":165,"end_character":4},"updated":"2017-03-23 02:40:30.000000000","message":"if a new qos policy with limited max bandwidth is introduced, I guess there WILL be a performance impact if the values are not put in properly","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"86b19266b9bb7922c114357325ec45c8a23599f1","unresolved":false,"context_lines":[{"line_number":160,"context_line":"Users will be able to specified qos_policy or qos details to create/update"},{"line_number":161,"context_line":"Loadbalancers."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Performance Impact"},{"line_number":164,"context_line":"------------------"},{"line_number":165,"context_line":"None"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Other deployer impact"},{"line_number":168,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ffe62b97_ea3f7f84","line":165,"range":{"start_line":163,"start_character":0,"end_line":165,"end_character":4},"in_reply_to":"1a1ced50_48fddf6c","updated":"2017-03-29 00:16:33.000000000","message":"It will minimally increase the time to create a load balancer as we will need to validate the qos policy and it might increase the time to create the VIP port in neutron.","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"bcda3045f11bc6cc0c16ab46cfb11d13096895c5","unresolved":false,"context_lines":[{"line_number":160,"context_line":"Users will be able to specified qos_policy or qos details to create/update"},{"line_number":161,"context_line":"Loadbalancers."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Performance Impact"},{"line_number":164,"context_line":"------------------"},{"line_number":165,"context_line":"None"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"Other deployer impact"},{"line_number":168,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ffe62b97_b080c8f6","line":165,"range":{"start_line":163,"start_character":0,"end_line":165,"end_character":4},"in_reply_to":"ffe62b97_ea3f7f84","updated":"2017-03-29 01:56:26.000000000","message":"will update.:P","commit_id":"fb9b5c9d888541b87aa92629e8bfeffef5be1467"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f5c964098376c205a7c14e81be1316ac09dbc456","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        }"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Maybe the defination in Octavia is like::"},{"line_number":80,"context_line":"        vip_qos_policy_id \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d36))"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Some samples in Loadbalancer creation/update. Users allow pass \"qos_policy_id\"."},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"dfeb2761_f7f54dee","line":80,"range":{"start_line":80,"start_character":42,"end_line":80,"end_character":74},"updated":"2017-04-05 02:49:34.000000000","message":"wtypes.UuidType()","commit_id":"e16fd2d58fd5291347560deb6113ca924c5f4e81"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"74f6e3f40aa227ed0717de069fdd49586927b64f","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        }"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Maybe the defination in Octavia is like::"},{"line_number":80,"context_line":"        vip_qos_policy_id \u003d wtypes.wsattr(wtypes.StringType(max_length\u003d36))"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Some samples in Loadbalancer creation/update. Users allow pass \"qos_policy_id\"."},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"dfeb2761_52c9a723","line":80,"range":{"start_line":80,"start_character":42,"end_line":80,"end_character":74},"in_reply_to":"dfeb2761_f7f54dee","updated":"2017-04-05 05:58:39.000000000","message":"Hi michael, thanks for review.","commit_id":"e16fd2d58fd5291347560deb6113ca924c5f4e81"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f5c964098376c205a7c14e81be1316ac09dbc456","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Other end user impact"},{"line_number":132,"context_line":"---------------------"},{"line_number":133,"context_line":"Users will be able to specified qos_policy or qos details to create/update"},{"line_number":134,"context_line":"Loadbalancers."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":7,"id":"dfeb2761_b7c46592","line":133,"range":{"start_line":133,"start_character":43,"end_line":133,"end_character":57},"updated":"2017-04-05 02:49:34.000000000","message":"Just policy","commit_id":"e16fd2d58fd5291347560deb6113ca924c5f4e81"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"74f6e3f40aa227ed0717de069fdd49586927b64f","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Other end user impact"},{"line_number":132,"context_line":"---------------------"},{"line_number":133,"context_line":"Users will be able to specified qos_policy or qos details to create/update"},{"line_number":134,"context_line":"Loadbalancers."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":7,"id":"dfeb2761_6d90494b","line":133,"range":{"start_line":133,"start_character":43,"end_line":133,"end_character":57},"in_reply_to":"dfeb2761_b7c46592","updated":"2017-04-05 05:58:39.000000000","message":"Thanks.","commit_id":"e16fd2d58fd5291347560deb6113ca924c5f4e81"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f5c964098376c205a7c14e81be1316ac09dbc456","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Testing"},{"line_number":173,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":174,"context_line":"Api tests from neutron-lbaas will be used to validate the new octavia API."},{"line_number":175,"context_line":"Scenario tests is necessary."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":7,"id":"dfeb2761_b772257a","line":174,"range":{"start_line":174,"start_character":0,"end_line":174,"end_character":74},"updated":"2017-04-05 02:49:34.000000000","message":"Unit, functional, and API tests required","commit_id":"e16fd2d58fd5291347560deb6113ca924c5f4e81"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"74f6e3f40aa227ed0717de069fdd49586927b64f","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Testing"},{"line_number":173,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":174,"context_line":"Api tests from neutron-lbaas will be used to validate the new octavia API."},{"line_number":175,"context_line":"Scenario tests is necessary."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":7,"id":"dfeb2761_4d8105fb","line":174,"range":{"start_line":174,"start_character":0,"end_line":174,"end_character":74},"in_reply_to":"dfeb2761_b772257a","updated":"2017-04-05 05:58:39.000000000","message":"Done.:)","commit_id":"e16fd2d58fd5291347560deb6113ca924c5f4e81"}],"specs/version1/vip-qos-policy-application.rst":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1e3e61586f5ecc458f5edd3850a14a9f890a050c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"VMs want to access the external network. So we should take a bandwidth"},{"line_number":22,"context_line":"limitation towards vip port."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Also, if the upstream network resource had been used up mostly, but we still"},{"line_number":25,"context_line":"want the backend servers behind loadbalancer are accessible and stable. The min"},{"line_number":26,"context_line":"bandwidth limitation is needed for this scenario."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_9085e65c","line":24,"range":{"start_line":24,"start_character":64,"end_line":24,"end_character":67},"updated":"2017-04-05 06:32:40.000000000","message":"not required","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a5baceb4d530a9294a6fa4eaa842c65aa5e7b2ec","unresolved":false,"context_lines":[{"line_number":21,"context_line":"VMs want to access the external network. So we should take a bandwidth"},{"line_number":22,"context_line":"limitation towards vip port."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Also, if the upstream network resource had been used up mostly, but we still"},{"line_number":25,"context_line":"want the backend servers behind loadbalancer are accessible and stable. The min"},{"line_number":26,"context_line":"bandwidth limitation is needed for this scenario."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_d67481d1","line":24,"range":{"start_line":24,"start_character":64,"end_line":24,"end_character":67},"in_reply_to":"dfeb2761_9085e65c","updated":"2017-04-05 09:44:54.000000000","message":"Done","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1e3e61586f5ecc458f5edd3850a14a9f890a050c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"want the backend servers behind loadbalancer are accessible and stable. The min"},{"line_number":26,"context_line":"bandwidth limitation is needed for this scenario."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"For more QoS functions, in reality, we can not limit our users or"},{"line_number":29,"context_line":"depolyers to use loadbalance default drivers, such as haproxy driver and"},{"line_number":30,"context_line":"octavia driver. They may concerned more fields related QoS, like DSCP. They"},{"line_number":31,"context_line":"could integrate the third-party drivers which concerned the fields."}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_30805a46","line":28,"range":{"start_line":28,"start_character":39,"end_line":28,"end_character":45},"updated":"2017-04-05 06:32:40.000000000","message":"single word","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1e3e61586f5ecc458f5edd3850a14a9f890a050c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"bandwidth limitation is needed for this scenario."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"For more QoS functions, in reality, we can not limit our users or"},{"line_number":29,"context_line":"depolyers to use loadbalance default drivers, such as haproxy driver and"},{"line_number":30,"context_line":"octavia driver. They may concerned more fields related QoS, like DSCP. They"},{"line_number":31,"context_line":"could integrate the third-party drivers which concerned the fields."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_f0955288","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":9},"updated":"2017-04-05 06:32:40.000000000","message":"nit: deployers","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a5baceb4d530a9294a6fa4eaa842c65aa5e7b2ec","unresolved":false,"context_lines":[{"line_number":26,"context_line":"bandwidth limitation is needed for this scenario."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"For more QoS functions, in reality, we can not limit our users or"},{"line_number":29,"context_line":"depolyers to use loadbalance default drivers, such as haproxy driver and"},{"line_number":30,"context_line":"octavia driver. They may concerned more fields related QoS, like DSCP. They"},{"line_number":31,"context_line":"could integrate the third-party drivers which concerned the fields."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_d686c1b9","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":9},"in_reply_to":"dfeb2761_f0955288","updated":"2017-04-05 09:44:54.000000000","message":"Done","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1e3e61586f5ecc458f5edd3850a14a9f890a050c","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"For more QoS functions, in reality, we can not limit our users or"},{"line_number":29,"context_line":"depolyers to use loadbalance default drivers, such as haproxy driver and"},{"line_number":30,"context_line":"octavia driver. They may concerned more fields related QoS, like DSCP. They"},{"line_number":31,"context_line":"could integrate the third-party drivers which concerned the fields."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_90ea860c","line":30,"range":{"start_line":30,"start_character":15,"end_line":30,"end_character":69},"updated":"2017-04-05 06:32:40.000000000","message":"they may be more concerned about the fields /functions related to QoS , like DSCP markings.","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a5baceb4d530a9294a6fa4eaa842c65aa5e7b2ec","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"For more QoS functions, in reality, we can not limit our users or"},{"line_number":29,"context_line":"depolyers to use loadbalance default drivers, such as haproxy driver and"},{"line_number":30,"context_line":"octavia driver. They may concerned more fields related QoS, like DSCP. They"},{"line_number":31,"context_line":"could integrate the third-party drivers which concerned the fields."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_369ccd0c","line":30,"range":{"start_line":30,"start_character":15,"end_line":30,"end_character":69},"in_reply_to":"dfeb2761_90ea860c","updated":"2017-04-05 09:44:54.000000000","message":"Done","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1e3e61586f5ecc458f5edd3850a14a9f890a050c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"For more QoS functions, in reality, we can not limit our users or"},{"line_number":29,"context_line":"depolyers to use loadbalance default drivers, such as haproxy driver and"},{"line_number":30,"context_line":"octavia driver. They may concerned more fields related QoS, like DSCP. They"},{"line_number":31,"context_line":"could integrate the third-party drivers which concerned the fields."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_50f07efd","line":31,"range":{"start_line":31,"start_character":46,"end_line":31,"end_character":55},"updated":"2017-04-05 06:32:40.000000000","message":"are concerned about","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1e3e61586f5ecc458f5edd3850a14a9f890a050c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"For more QoS functions, in reality, we can not limit our users or"},{"line_number":29,"context_line":"depolyers to use loadbalance default drivers, such as haproxy driver and"},{"line_number":30,"context_line":"octavia driver. They may concerned more fields related QoS, like DSCP. They"},{"line_number":31,"context_line":"could integrate the third-party drivers which concerned the fields."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_f0daf275","line":31,"range":{"start_line":31,"start_character":56,"end_line":31,"end_character":59},"updated":"2017-04-05 06:32:40.000000000","message":"these","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1e3e61586f5ecc458f5edd3850a14a9f890a050c","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Proposed change"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":"This spec introduces the neutron QoS function to meet the requirements."},{"line_number":37,"context_line":"Currently, there are 3 ports(at least) in the loadbalancer created by octavia."},{"line_number":38,"context_line":"One is from the lb-mgmt-net, the others are from the vip-subnet, called"},{"line_number":39,"context_line":"\"loadbalancer-LOADBALANCER_ID\" and \"octavia-lb-vrrp-LOADBALNCER_ID\". The first"}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_b0e0ea27","line":36,"range":{"start_line":36,"start_character":25,"end_line":36,"end_character":32},"updated":"2017-04-05 06:32:40.000000000","message":"Neutron","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1e3e61586f5ecc458f5edd3850a14a9f890a050c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"Proposed change"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":"This spec introduces the neutron QoS function to meet the requirements."},{"line_number":37,"context_line":"Currently, there are 3 ports(at least) in the loadbalancer created by octavia."},{"line_number":38,"context_line":"One is from the lb-mgmt-net, the others are from the vip-subnet, called"},{"line_number":39,"context_line":"\"loadbalancer-LOADBALANCER_ID\" and \"octavia-lb-vrrp-LOADBALNCER_ID\". The first"},{"line_number":40,"context_line":"one is vip port, the second one is for vrrp HA, and it will set"}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_10c79698","line":37,"range":{"start_line":37,"start_character":70,"end_line":37,"end_character":77},"updated":"2017-04-05 06:32:40.000000000","message":"Octavia","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a5baceb4d530a9294a6fa4eaa842c65aa5e7b2ec","unresolved":false,"context_lines":[{"line_number":34,"context_line":"Proposed change"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":"This spec introduces the neutron QoS function to meet the requirements."},{"line_number":37,"context_line":"Currently, there are 3 ports(at least) in the loadbalancer created by octavia."},{"line_number":38,"context_line":"One is from the lb-mgmt-net, the others are from the vip-subnet, called"},{"line_number":39,"context_line":"\"loadbalancer-LOADBALANCER_ID\" and \"octavia-lb-vrrp-LOADBALNCER_ID\". The first"},{"line_number":40,"context_line":"one is vip port, the second one is for vrrp HA, and it will set"}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_7696d5f2","line":37,"range":{"start_line":37,"start_character":70,"end_line":37,"end_character":77},"in_reply_to":"dfeb2761_10c79698","updated":"2017-04-05 09:44:54.000000000","message":"Done","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1e3e61586f5ecc458f5edd3850a14a9f890a050c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"\"allowed_address_pairs\" toward vip fixed_ip. The qos policy should focus on the"},{"line_number":42,"context_line":"attached port \"octavia-lb-vrrp-LOADBALNCER_ID\"."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"We could apply the Neutron qos policy which contains the bandwidth limit rule"},{"line_number":45,"context_line":"to the \"octavia-lb-vrrp-LOADBALNCER_ID\" ports, whether the topology is"},{"line_number":46,"context_line":"active-active or standalone."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_7066e2c3","line":44,"range":{"start_line":44,"start_character":38,"end_line":44,"end_character":77},"updated":"2017-04-05 06:32:40.000000000","message":"not required","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a5baceb4d530a9294a6fa4eaa842c65aa5e7b2ec","unresolved":false,"context_lines":[{"line_number":41,"context_line":"\"allowed_address_pairs\" toward vip fixed_ip. The qos policy should focus on the"},{"line_number":42,"context_line":"attached port \"octavia-lb-vrrp-LOADBALNCER_ID\"."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"We could apply the Neutron qos policy which contains the bandwidth limit rule"},{"line_number":45,"context_line":"to the \"octavia-lb-vrrp-LOADBALNCER_ID\" ports, whether the topology is"},{"line_number":46,"context_line":"active-active or standalone."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_d601213a","line":44,"range":{"start_line":44,"start_character":38,"end_line":44,"end_character":77},"in_reply_to":"dfeb2761_7066e2c3","updated":"2017-04-05 09:44:54.000000000","message":"Done","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1e3e61586f5ecc458f5edd3850a14a9f890a050c","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Alternatives"},{"line_number":55,"context_line":"------------"},{"line_number":56,"context_line":"* Allow users to pass the QoS policy in Loadbalancer creation or update."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Data model impact"},{"line_number":59,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_500cfeea","line":56,"range":{"start_line":56,"start_character":14,"end_line":56,"end_character":72},"updated":"2017-04-05 06:32:40.000000000","message":"this is the same as the second step in the CHANGES mentioned above","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a5baceb4d530a9294a6fa4eaa842c65aa5e7b2ec","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Alternatives"},{"line_number":55,"context_line":"------------"},{"line_number":56,"context_line":"* Allow users to pass the QoS policy in Loadbalancer creation or update."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Data model impact"},{"line_number":59,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_36e72daf","line":56,"range":{"start_line":56,"start_character":14,"end_line":56,"end_character":72},"in_reply_to":"dfeb2761_500cfeea","updated":"2017-04-05 09:44:54.000000000","message":"This can be removed.","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1e3e61586f5ecc458f5edd3850a14a9f890a050c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"change."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"* vip table"},{"line_number":66,"context_line":"  - `qos_policy_id`: associated Qos policy id with vip port."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"REST API impact"},{"line_number":69,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_d0ffeea8","line":66,"range":{"start_line":66,"start_character":21,"end_line":66,"end_character":33},"updated":"2017-04-05 06:32:40.000000000","message":"associate","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a5baceb4d530a9294a6fa4eaa842c65aa5e7b2ec","unresolved":false,"context_lines":[{"line_number":63,"context_line":"change."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"* vip table"},{"line_number":66,"context_line":"  - `qos_policy_id`: associated Qos policy id with vip port."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"REST API impact"},{"line_number":69,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_56f63165","line":66,"range":{"start_line":66,"start_character":21,"end_line":66,"end_character":33},"in_reply_to":"dfeb2761_d0ffeea8","updated":"2017-04-05 09:44:54.000000000","message":"Done","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1e3e61586f5ecc458f5edd3850a14a9f890a050c","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        EXTEND_FIELDS \u003d {"},{"line_number":74,"context_line":"            \u0027vip_qos_policy_id\u0027:{\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":75,"context_line":"                                \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":76,"context_line":"                                \u0027is_visible\u0027: True}"},{"line_number":77,"context_line":"        }"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Maybe the defination in Octavia is like::"}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_70d94255","line":76,"updated":"2017-04-05 06:32:40.000000000","message":"You missed \ndefault: None","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a5baceb4d530a9294a6fa4eaa842c65aa5e7b2ec","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        EXTEND_FIELDS \u003d {"},{"line_number":74,"context_line":"            \u0027vip_qos_policy_id\u0027:{\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":75,"context_line":"                                \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":76,"context_line":"                                \u0027is_visible\u0027: True}"},{"line_number":77,"context_line":"        }"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Maybe the defination in Octavia is like::"}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_76f1356b","line":76,"in_reply_to":"dfeb2761_70d94255","updated":"2017-04-05 09:44:54.000000000","message":"Yeah. add it.","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1e3e61586f5ecc458f5edd3850a14a9f890a050c","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                                \u0027is_visible\u0027: True}"},{"line_number":77,"context_line":"        }"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Maybe the defination in Octavia is like::"},{"line_number":80,"context_line":"        vip_qos_policy_id \u003d wtypes.wsattr(wtypes.UuidType())"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Some samples in Loadbalancer creation/update. Users allow pass \"qos_policy_id\"."}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_50251e5b","line":79,"range":{"start_line":79,"start_character":0,"end_line":79,"end_character":5},"updated":"2017-04-05 06:32:40.000000000","message":"Maybe ??? :)","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1e3e61586f5ecc458f5edd3850a14a9f890a050c","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                                \u0027is_visible\u0027: True}"},{"line_number":77,"context_line":"        }"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Maybe the defination in Octavia is like::"},{"line_number":80,"context_line":"        vip_qos_policy_id \u003d wtypes.wsattr(wtypes.UuidType())"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Some samples in Loadbalancer creation/update. Users allow pass \"qos_policy_id\"."}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_f01f9205","line":79,"range":{"start_line":79,"start_character":10,"end_line":79,"end_character":20},"updated":"2017-04-05 06:32:40.000000000","message":"definition","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a5baceb4d530a9294a6fa4eaa842c65aa5e7b2ec","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                                \u0027is_visible\u0027: True}"},{"line_number":77,"context_line":"        }"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Maybe the defination in Octavia is like::"},{"line_number":80,"context_line":"        vip_qos_policy_id \u003d wtypes.wsattr(wtypes.UuidType())"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Some samples in Loadbalancer creation/update. Users allow pass \"qos_policy_id\"."}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_76c81521","line":79,"range":{"start_line":79,"start_character":0,"end_line":79,"end_character":5},"in_reply_to":"dfeb2761_50251e5b","updated":"2017-04-05 09:44:54.000000000","message":"Done","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a5baceb4d530a9294a6fa4eaa842c65aa5e7b2ec","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                                \u0027is_visible\u0027: True}"},{"line_number":77,"context_line":"        }"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Maybe the defination in Octavia is like::"},{"line_number":80,"context_line":"        vip_qos_policy_id \u003d wtypes.wsattr(wtypes.UuidType())"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Some samples in Loadbalancer creation/update. Users allow pass \"qos_policy_id\"."}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_16d309d7","line":79,"range":{"start_line":79,"start_character":10,"end_line":79,"end_character":20},"in_reply_to":"dfeb2761_f01f9205","updated":"2017-04-05 09:44:54.000000000","message":"hah.:). Thank you","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1e3e61586f5ecc458f5edd3850a14a9f890a050c","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Other end user impact"},{"line_number":132,"context_line":"---------------------"},{"line_number":133,"context_line":"Users will be able to specified qos_policy to create/update Loadbalancers."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Performance Impact"},{"line_number":136,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_d0edaef0","line":133,"range":{"start_line":133,"start_character":22,"end_line":133,"end_character":31},"updated":"2017-04-05 06:32:40.000000000","message":"specify","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a5baceb4d530a9294a6fa4eaa842c65aa5e7b2ec","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Other end user impact"},{"line_number":132,"context_line":"---------------------"},{"line_number":133,"context_line":"Users will be able to specified qos_policy to create/update Loadbalancers."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Performance Impact"},{"line_number":136,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_d653616a","line":133,"range":{"start_line":133,"start_character":22,"end_line":133,"end_character":31},"in_reply_to":"dfeb2761_d0edaef0","updated":"2017-04-05 09:44:54.000000000","message":"Done","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1e3e61586f5ecc458f5edd3850a14a9f890a050c","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Performance Impact"},{"line_number":136,"context_line":"------------------"},{"line_number":137,"context_line":"It will be a very short time to cost in loadbalancer creation, as we need"},{"line_number":138,"context_line":"validate the input qos policy."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Other deployer impact"},{"line_number":141,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_f0e4320f","line":138,"range":{"start_line":137,"start_character":0,"end_line":138,"end_character":30},"updated":"2017-04-05 06:32:40.000000000","message":"It also depends on the type of the QoS policy actually","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a5baceb4d530a9294a6fa4eaa842c65aa5e7b2ec","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Performance Impact"},{"line_number":136,"context_line":"------------------"},{"line_number":137,"context_line":"It will be a very short time to cost in loadbalancer creation, as we need"},{"line_number":138,"context_line":"validate the input qos policy."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Other deployer impact"},{"line_number":141,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_36596d8d","line":138,"range":{"start_line":137,"start_character":0,"end_line":138,"end_character":30},"in_reply_to":"dfeb2761_f0e4320f","updated":"2017-04-05 09:44:54.000000000","message":"Agree","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1e3e61586f5ecc458f5edd3850a14a9f890a050c","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Assignee(s)"},{"line_number":152,"context_line":"-----------"},{"line_number":153,"context_line":"zhaobo"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Work Items"},{"line_number":156,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_b0ea2ad5","line":153,"range":{"start_line":153,"start_character":0,"end_line":153,"end_character":6},"updated":"2017-04-05 06:32:40.000000000","message":"Can I join in ?","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"a5baceb4d530a9294a6fa4eaa842c65aa5e7b2ec","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Assignee(s)"},{"line_number":152,"context_line":"-----------"},{"line_number":153,"context_line":"zhaobo"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Work Items"},{"line_number":156,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"dfeb2761_d66a4118","line":153,"range":{"start_line":153,"start_character":0,"end_line":153,"end_character":6},"in_reply_to":"dfeb2761_b0ea2ad5","updated":"2017-04-05 09:44:54.000000000","message":"Sure. :). sorry.","commit_id":"44ffc3849c3b1d8b5b5a9a17e4b2e26bd2dcb844"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"431f8efd81c2878f972cd495d5efc8cfdfc6d25e","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Alternatives"},{"line_number":55,"context_line":"------------"},{"line_number":56,"context_line":"None"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Data model impact"},{"line_number":59,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bff0334d_f5c71a45","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":4},"updated":"2017-04-05 15:23:24.000000000","message":"Do nothing, do not enable QoS\nAccept the QoS parameters and implement on our own.","commit_id":"c1827ebcebcccf2dddf542fb0ecb77fd3acfab1d"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"0f5c67ed9365b3d338f5cf238ee64f0d095ffb19","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Alternatives"},{"line_number":55,"context_line":"------------"},{"line_number":56,"context_line":"None"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Data model impact"},{"line_number":59,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bff0334d_7e5e34e7","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":4},"in_reply_to":"bff0334d_f5c71a45","updated":"2017-04-06 03:07:30.000000000","message":"Thanks Micheal. I consider it is good to go based on the determinate way. :). I will add it.","commit_id":"c1827ebcebcccf2dddf542fb0ecb77fd3acfab1d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"431f8efd81c2878f972cd495d5efc8cfdfc6d25e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                \"vip_address\": \"10.0.0.4\","},{"line_number":96,"context_line":"                \"admin_state_up\": true,"},{"line_number":97,"context_line":"                \"flavor\": \"a7ae5d5a-d855-4f9a-b187-af66b53f4d04\","},{"line_number":98,"context_line":"                \"qos_policy_id\": \"b61f8b45-e888-4056-94f0-e3d5af96211f\""},{"line_number":99,"context_line":"            }"},{"line_number":100,"context_line":"        }"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"bff0334d_958e8e25","line":98,"range":{"start_line":98,"start_character":17,"end_line":98,"end_character":30},"updated":"2017-04-05 15:23:24.000000000","message":"Why did we drop the vip_ prefix?  I liked that it clarified where the qos_policy_id will be applied.","commit_id":"c1827ebcebcccf2dddf542fb0ecb77fd3acfab1d"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"0f5c67ed9365b3d338f5cf238ee64f0d095ffb19","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                \"vip_address\": \"10.0.0.4\","},{"line_number":96,"context_line":"                \"admin_state_up\": true,"},{"line_number":97,"context_line":"                \"flavor\": \"a7ae5d5a-d855-4f9a-b187-af66b53f4d04\","},{"line_number":98,"context_line":"                \"qos_policy_id\": \"b61f8b45-e888-4056-94f0-e3d5af96211f\""},{"line_number":99,"context_line":"            }"},{"line_number":100,"context_line":"        }"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"bff0334d_5edc9073","line":98,"range":{"start_line":98,"start_character":17,"end_line":98,"end_character":30},"in_reply_to":"bff0334d_958e8e25","updated":"2017-04-06 03:07:30.000000000","message":"Thanks for review. You are right, we need change the name like the subnet and ip address. :)","commit_id":"c1827ebcebcccf2dddf542fb0ecb77fd3acfab1d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"431f8efd81c2878f972cd495d5efc8cfdfc6d25e","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Performance Impact"},{"line_number":137,"context_line":"------------------"},{"line_number":138,"context_line":"* It will be a very short time to cost in loadbalancer creation, as we need"},{"line_number":139,"context_line":"validate the input QoS policy."},{"line_number":140,"context_line":"* The QoS policy in Neutron side will affect the network performance based on"},{"line_number":141,"context_line":"the different types of QoS rules."}],"source_content_type":"text/x-rst","patch_set":9,"id":"bff0334d_55ffe666","line":138,"range":{"start_line":138,"start_character":0,"end_line":138,"end_character":7},"updated":"2017-04-05 15:23:24.000000000","message":"You need a blank line between the title and the list.","commit_id":"c1827ebcebcccf2dddf542fb0ecb77fd3acfab1d"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"0f5c67ed9365b3d338f5cf238ee64f0d095ffb19","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Performance Impact"},{"line_number":137,"context_line":"------------------"},{"line_number":138,"context_line":"* It will be a very short time to cost in loadbalancer creation, as we need"},{"line_number":139,"context_line":"validate the input QoS policy."},{"line_number":140,"context_line":"* The QoS policy in Neutron side will affect the network performance based on"},{"line_number":141,"context_line":"the different types of QoS rules."}],"source_content_type":"text/x-rst","patch_set":9,"id":"bff0334d_1ebf28fc","line":138,"range":{"start_line":138,"start_character":0,"end_line":138,"end_character":7},"in_reply_to":"bff0334d_55ffe666","updated":"2017-04-06 03:07:30.000000000","message":"Thanks for correct. I will update.","commit_id":"c1827ebcebcccf2dddf542fb0ecb77fd3acfab1d"}]}