)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8f1e4da38aa4cc451193015aa3b8253e9d6fa22f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        octavia_dib_tracing_arg\u003d\"-x\""},{"line_number":39,"context_line":"    fi"},{"line_number":40,"context_line":"    if [[ ${OCTAVIA_AMP_BASE_OS:+1} ]] ; then"},{"line_number":41,"context_line":"    export PARAM_OCTAVIA_AMP_BASE_OS\u003d\u0027-i \u0027$OCTAVIA_AMP_BASE_OS"},{"line_number":42,"context_line":"    fi"},{"line_number":43,"context_line":"    if [[ ${OCTAVIA_AMP_DISTRIBUTION_RELEASE_ID:+1} ]] ; then"},{"line_number":44,"context_line":"    export PARAM_OCTAVIA_AMP_DISTRIBUTION_RELEASE_ID\u003d\u0027-d \u0027$OCTAVIA_AMP_DISTRIBUTION_RELEASE_ID"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ffe62b97_14313d0c","line":41,"updated":"2017-03-24 17:08:24.000000000","message":"These would now be unused as well.","commit_id":"4976033be32b55b0f74ff501ffd41a177dbc1bd5"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"179a0009b723d3c05e4dc5e634274fea18401f89","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        octavia_dib_tracing_arg\u003d\"-x\""},{"line_number":39,"context_line":"    fi"},{"line_number":40,"context_line":"    if [[ ${OCTAVIA_AMP_BASE_OS:+1} ]] ; then"},{"line_number":41,"context_line":"    export PARAM_OCTAVIA_AMP_BASE_OS\u003d\u0027-i \u0027$OCTAVIA_AMP_BASE_OS"},{"line_number":42,"context_line":"    fi"},{"line_number":43,"context_line":"    if [[ ${OCTAVIA_AMP_DISTRIBUTION_RELEASE_ID:+1} ]] ; then"},{"line_number":44,"context_line":"    export PARAM_OCTAVIA_AMP_DISTRIBUTION_RELEASE_ID\u003d\u0027-d \u0027$OCTAVIA_AMP_DISTRIBUTION_RELEASE_ID"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ffe62b97_d4451572","line":41,"updated":"2017-03-24 17:08:14.000000000","message":"if we\u0027re not using PARAM_ anymore, shouldn\u0027t you completely remove them?","commit_id":"4976033be32b55b0f74ff501ffd41a177dbc1bd5"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"179a0009b723d3c05e4dc5e634274fea18401f89","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    export PARAM_OCTAVIA_AMP_BASE_OS\u003d\u0027-i \u0027$OCTAVIA_AMP_BASE_OS"},{"line_number":42,"context_line":"    fi"},{"line_number":43,"context_line":"    if [[ ${OCTAVIA_AMP_DISTRIBUTION_RELEASE_ID:+1} ]] ; then"},{"line_number":44,"context_line":"    export PARAM_OCTAVIA_AMP_DISTRIBUTION_RELEASE_ID\u003d\u0027-d \u0027$OCTAVIA_AMP_DISTRIBUTION_RELEASE_ID"},{"line_number":45,"context_line":"    fi"},{"line_number":46,"context_line":"    if [[ ${OCTAVIA_AMP_IMAGE_SIZE:+1} ]] ; then"},{"line_number":47,"context_line":"    export PARAM_OCTAVIA_AMP_IMAGE_SIZE\u003d\u0027-s \u0027$OCTAVIA_AMP_IMAGE_SIZE"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ffe62b97_f4501935","line":44,"updated":"2017-03-24 17:08:14.000000000","message":"if we\u0027re not using PARAM_ anymore, shouldn\u0027t you completely remove them?","commit_id":"4976033be32b55b0f74ff501ffd41a177dbc1bd5"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"179a0009b723d3c05e4dc5e634274fea18401f89","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    export PARAM_OCTAVIA_AMP_DISTRIBUTION_RELEASE_ID\u003d\u0027-d \u0027$OCTAVIA_AMP_DISTRIBUTION_RELEASE_ID"},{"line_number":45,"context_line":"    fi"},{"line_number":46,"context_line":"    if [[ ${OCTAVIA_AMP_IMAGE_SIZE:+1} ]] ; then"},{"line_number":47,"context_line":"    export PARAM_OCTAVIA_AMP_IMAGE_SIZE\u003d\u0027-s \u0027$OCTAVIA_AMP_IMAGE_SIZE"},{"line_number":48,"context_line":"    fi"},{"line_number":49,"context_line":"    if ! [ -f $OCTAVIA_AMP_IMAGE_FILE ]; then"},{"line_number":50,"context_line":"        $OCTAVIA_DIR/diskimage-create/diskimage-create.sh $octavia_dib_tracing_arg -o $OCTAVIA_AMP_IMAGE_FILE -i ${OCTAVIA_AMP_BASE_OS} -d ${OCTAVIA_AMP_DISTRIBUTION_RELEASE_ID} -s ${OCTAVIA_AMP_IMAGE_SIZE}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ffe62b97_347d61b1","line":47,"updated":"2017-03-24 17:08:14.000000000","message":"if we\u0027re not using PARAM_ anymore, shouldn\u0027t you completely remove them?","commit_id":"4976033be32b55b0f74ff501ffd41a177dbc1bd5"}],"devstack/settings":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"89e986b6b43b4cb51d0bdb72c12238f823390299","unresolved":false,"context_lines":[{"line_number":47,"context_line":"OCTAVIA_AMP_CONN_TIMEOUT\u003d${OCTAVIA_AMP_CONN_TIMEOUT:-\"10\"}"},{"line_number":48,"context_line":"OCTAVIA_AMP_READ_TIMEOUT\u003d${OCTAVIA_AMP_READ_TIMEOUT:-\"120\"}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"OCTAVIA_AMP_BASE_OS\u003d\"ubuntu\""},{"line_number":51,"context_line":"OCTAVIA_AMP_DISTRIBUTION_RELEASE_ID\u003d\"xenial\""},{"line_number":52,"context_line":"OCTAVIA_AMP_IMAGE_SIZE\u003d2"},{"line_number":53,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ffe62b97_14bedd64","line":50,"updated":"2017-03-24 17:07:31.000000000","message":"This means we now have \"default\" values in two places.  In the diskimage-create.sh script and now here.","commit_id":"4976033be32b55b0f74ff501ffd41a177dbc1bd5"}]}
