)]}'
{"etc/octavia.conf":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b90385b820a56c7395a760f7d1196cf6d927e2a5","unresolved":false,"context_lines":[{"line_number":284,"context_line":"# Availability zone to use for creating Amphorae"},{"line_number":285,"context_line":"# availability_zone \u003d"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"# Disable anti-affinity in nova"},{"line_number":288,"context_line":"# enable_anti_affinity \u003d False"},{"line_number":289,"context_line":"# Set the anti-affinity policy to what is suitable."},{"line_number":290,"context_line":"# Nova supports: anti-affinity and soft-anti-affinity"}],"source_content_type":"text/plain","patch_set":6,"id":"dfeb2761_860d2740","line":287,"updated":"2017-03-31 16:22:13.000000000","message":"I think it\u0027s a little awkwardly worded like this, maybe \"Enable\" instead, and it is still clear that it\u0027s defaulting to False","commit_id":"76910e7f22555c49696c334f6157ae90a02ee676"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"9502c080d953c8495123c16fe6b4130b4944c31b","unresolved":false,"context_lines":[{"line_number":284,"context_line":"# Availability zone to use for creating Amphorae"},{"line_number":285,"context_line":"# availability_zone \u003d"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"# Disable anti-affinity in nova"},{"line_number":288,"context_line":"# enable_anti_affinity \u003d False"},{"line_number":289,"context_line":"# Set the anti-affinity policy to what is suitable."},{"line_number":290,"context_line":"# Nova supports: anti-affinity and soft-anti-affinity"}],"source_content_type":"text/plain","patch_set":6,"id":"dfeb2761_099b68c9","line":287,"in_reply_to":"dfeb2761_860d2740","updated":"2017-03-31 16:26:02.000000000","message":"Done","commit_id":"76910e7f22555c49696c334f6157ae90a02ee676"}],"octavia/common/config.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"a43cd1dd5379783957c66c049ffa9bc7588bfb6e","unresolved":false,"context_lines":[{"line_number":410,"context_line":"                      \u0027\"amphora-{UUID}\".\u0027)),"},{"line_number":411,"context_line":"    cfg.StrOpt(\u0027availability_zone\u0027, default\u003dNone,"},{"line_number":412,"context_line":"               help\u003d_(\u0027Availability zone to use for creating Amphorae\u0027)),"},{"line_number":413,"context_line":"    cfg.StrOpt(\u0027anti_affinity_policy\u0027, default\u003d\"anti-affinity\","},{"line_number":414,"context_line":"               help\u003d_(\u0027Sets the anti-affinity policy for nova\u0027)),"},{"line_number":415,"context_line":"]"},{"line_number":416,"context_line":"neutron_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_66cc6389","line":413,"updated":"2017-03-31 16:03:35.000000000","message":"You seem to have made a constant for \"anti-affinity\", should this be using it for the default value?\nAlso, Nit: Could we move this up to be next to \"enable_anti_affinity\"? :)","commit_id":"e884448ea693a8f6238c4dd7bf69bb5aa3dc4553"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"4a05b75117ef921c03a4998da8ff950a43490070","unresolved":false,"context_lines":[{"line_number":410,"context_line":"                      \u0027\"amphora-{UUID}\".\u0027)),"},{"line_number":411,"context_line":"    cfg.StrOpt(\u0027availability_zone\u0027, default\u003dNone,"},{"line_number":412,"context_line":"               help\u003d_(\u0027Availability zone to use for creating Amphorae\u0027)),"},{"line_number":413,"context_line":"    cfg.StrOpt(\u0027anti_affinity_policy\u0027, default\u003d\"anti-affinity\","},{"line_number":414,"context_line":"               help\u003d_(\u0027Sets the anti-affinity policy for nova\u0027)),"},{"line_number":415,"context_line":"]"},{"line_number":416,"context_line":"neutron_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_66690324","line":413,"in_reply_to":"dfeb2761_26c2db34","updated":"2017-03-31 16:13:12.000000000","message":"Ah, I looked at the next file and thought you added it, not removed it. My bad.","commit_id":"e884448ea693a8f6238c4dd7bf69bb5aa3dc4553"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"41f9466cb9d1ff1f191b1ad3b4aac6176017b42e","unresolved":false,"context_lines":[{"line_number":410,"context_line":"                      \u0027\"amphora-{UUID}\".\u0027)),"},{"line_number":411,"context_line":"    cfg.StrOpt(\u0027availability_zone\u0027, default\u003dNone,"},{"line_number":412,"context_line":"               help\u003d_(\u0027Availability zone to use for creating Amphorae\u0027)),"},{"line_number":413,"context_line":"    cfg.StrOpt(\u0027anti_affinity_policy\u0027, default\u003d\"anti-affinity\","},{"line_number":414,"context_line":"               help\u003d_(\u0027Sets the anti-affinity policy for nova\u0027)),"},{"line_number":415,"context_line":"]"},{"line_number":416,"context_line":"neutron_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_26c2db34","line":413,"in_reply_to":"dfeb2761_66cc6389","updated":"2017-03-31 16:08:55.000000000","message":"I removed the constant and only added it to the test. Since we don\u0027t use consonants anywhere else for config parameters I am not gonna start.\n\nMoved it up.","commit_id":"e884448ea693a8f6238c4dd7bf69bb5aa3dc4553"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1d463f6775ac31a3d06e02af50dabd9188a9e81f","unresolved":false,"context_lines":[{"line_number":403,"context_line":"    cfg.BoolOpt(\u0027enable_anti_affinity\u0027, default\u003dFalse,"},{"line_number":404,"context_line":"                help\u003d_(\u0027Flag to indicate if nova anti-affinity feature is \u0027"},{"line_number":405,"context_line":"                       \u0027turned on.\u0027)),"},{"line_number":406,"context_line":"    cfg.StrOpt(\u0027anti_affinity_policy\u0027, default\u003d\"anti-affinity\","},{"line_number":407,"context_line":"               help\u003d_(\u0027Sets the anti-affinity policy for nova\u0027)),"},{"line_number":408,"context_line":"    cfg.IntOpt(\u0027random_amphora_name_length\u0027, default\u003d0,"},{"line_number":409,"context_line":"               help\u003d_(\u0027If non-zero, generate a random name of the length \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"dfeb2761_e9672425","line":406,"range":{"start_line":406,"start_character":39,"end_line":406,"end_character":63},"updated":"2017-03-31 16:58:37.000000000","message":"This should be a \"choices\" restriction and use constants.\nSee auth strategy above.","commit_id":"b5677141e3f6a297782c8f3e8ebb831527967666"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"e511a5f65f36ef27f2277fe728e705d510189e53","unresolved":false,"context_lines":[{"line_number":403,"context_line":"    cfg.BoolOpt(\u0027enable_anti_affinity\u0027, default\u003dFalse,"},{"line_number":404,"context_line":"                help\u003d_(\u0027Flag to indicate if nova anti-affinity feature is \u0027"},{"line_number":405,"context_line":"                       \u0027turned on.\u0027)),"},{"line_number":406,"context_line":"    cfg.StrOpt(\u0027anti_affinity_policy\u0027, default\u003d\"anti-affinity\","},{"line_number":407,"context_line":"               help\u003d_(\u0027Sets the anti-affinity policy for nova\u0027)),"},{"line_number":408,"context_line":"    cfg.IntOpt(\u0027random_amphora_name_length\u0027, default\u003d0,"},{"line_number":409,"context_line":"               help\u003d_(\u0027If non-zero, generate a random name of the length \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"dfeb2761_5a2130fb","line":406,"range":{"start_line":406,"start_character":39,"end_line":406,"end_character":63},"in_reply_to":"dfeb2761_e9672425","updated":"2017-03-31 18:27:46.000000000","message":"Done","commit_id":"b5677141e3f6a297782c8f3e8ebb831527967666"}],"octavia/tests/unit/compute/drivers/test_nova_driver.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"a43cd1dd5379783957c66c049ffa9bc7588bfb6e","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"CONF \u003d cfg.CONF"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"ANTI_AFFINITY \u003d \"anti-affinity\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class Test_GetImageUuid(base.TestCase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_86940746","line":31,"updated":"2017-03-31 16:03:35.000000000","message":"Should we remove this and just use the constant?","commit_id":"e884448ea693a8f6238c4dd7bf69bb5aa3dc4553"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"41f9466cb9d1ff1f191b1ad3b4aac6176017b42e","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"CONF \u003d cfg.CONF"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"ANTI_AFFINITY \u003d \"anti-affinity\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class Test_GetImageUuid(base.TestCase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_c6e68fe9","line":31,"in_reply_to":"dfeb2761_86940746","updated":"2017-03-31 16:08:55.000000000","message":"I deleted the global constant. So this is the only one left.","commit_id":"e884448ea693a8f6238c4dd7bf69bb5aa3dc4553"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"4a05b75117ef921c03a4998da8ff950a43490070","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"CONF \u003d cfg.CONF"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"ANTI_AFFINITY \u003d \"anti-affinity\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class Test_GetImageUuid(base.TestCase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_2673fb17","line":31,"in_reply_to":"dfeb2761_c6e68fe9","updated":"2017-03-31 16:13:12.000000000","message":"Yeah misread that change as an add, not a remove. ;P","commit_id":"e884448ea693a8f6238c4dd7bf69bb5aa3dc4553"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1d463f6775ac31a3d06e02af50dabd9188a9e81f","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"CONF \u003d cfg.CONF"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"ANTI_AFFINITY \u003d \"anti-affinity\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class Test_GetImageUuid(base.TestCase):"}],"source_content_type":"text/x-python","patch_set":7,"id":"dfeb2761_1c6048ce","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":31},"updated":"2017-03-31 16:58:37.000000000","message":"Why?  It\u0027s in constants....","commit_id":"b5677141e3f6a297782c8f3e8ebb831527967666"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"e511a5f65f36ef27f2277fe728e705d510189e53","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"CONF \u003d cfg.CONF"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"ANTI_AFFINITY \u003d \"anti-affinity\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class Test_GetImageUuid(base.TestCase):"}],"source_content_type":"text/x-python","patch_set":7,"id":"dfeb2761_facb641b","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":31},"in_reply_to":"dfeb2761_1c6048ce","updated":"2017-03-31 18:27:46.000000000","message":"Put it back into constants...","commit_id":"b5677141e3f6a297782c8f3e8ebb831527967666"}],"releasenotes/notes/add-anti-affinity-policy-config-39df309fd12d443c.yaml":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"a43cd1dd5379783957c66c049ffa9bc7588bfb6e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds a new config parameter to specify the anti affinity policy"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dfeb2761_e68e332d","line":3,"updated":"2017-03-31 16:03:35.000000000","message":"Is this \"anti-affinity\"? or how does nova actually say it?","commit_id":"e884448ea693a8f6238c4dd7bf69bb5aa3dc4553"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"41f9466cb9d1ff1f191b1ad3b4aac6176017b42e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds a new config parameter to specify the anti affinity policy"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dfeb2761_26d77bf0","line":3,"in_reply_to":"dfeb2761_e68e332d","updated":"2017-03-31 16:08:55.000000000","message":"Done","commit_id":"e884448ea693a8f6238c4dd7bf69bb5aa3dc4553"}]}