)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"06210ab4e353a8dabb7b9538ff15b80b1a548507","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alexander Amerine \u003caamerine@blizzard.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-04-03 20:46:03 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"blueprint LBaaS Alternative Health Monitoring Port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6066680115294287f3e66759d5cb122007cbf723"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dfeb2761_1d08e68f","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":50},"updated":"2017-04-04 15:36:11.000000000","message":"Can you please add a Partial-Bug: #1541579\nThat will help tie this to the RFE bug.","commit_id":"045f862bd0a8e53a2a266d7dd2bda69387ee075f"}],"specs/version1/health_ip_port.rst":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"36ed39888c06c09fb883f1aefeaaefa63a109027","unresolved":false,"context_lines":[{"line_number":80,"context_line":"There are two APIs that will need to be modified, only slightly, to facilitate"},{"line_number":81,"context_line":"this change."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"POST /v2.0/lbaas/pools/{pool_id}/members"},{"line_number":84,"context_line":"PUT /v2.0/lbaas/pools/{pool_id}/members/{member_id}"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"These two calls will need two additional fields added to their JSON body data"},{"line_number":87,"context_line":"for the request and the JSON response data."}],"source_content_type":"text/x-rst","patch_set":5,"id":"bff0334d_12fa7f41","line":84,"range":{"start_line":83,"start_character":0,"end_line":84,"end_character":51},"updated":"2017-04-06 00:20:57.000000000","message":"These get squished to one line","commit_id":"3478148a203bb9f7ab9d46af74309e20f4640954"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"36ed39888c06c09fb883f1aefeaaefa63a109027","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"The field to be added to each is:"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":".. csv-table:: CSVTable"},{"line_number":92,"context_line":"    :header: Attribute Name,Type,Access,Default Value,Validation Conversion,Description"},{"line_number":93,"context_line":"    monitor_port,int,\"RW, all\",null,int,health check port (optional)"},{"line_number":94,"context_line":"    monitor_address,string (IP Address),\"RW, all\",null,string (IP Address),health check IP address"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bff0334d_124cbfc5","line":91,"range":{"start_line":91,"start_character":0,"end_line":91,"end_character":23},"updated":"2017-04-06 00:20:57.000000000","message":"This is not rendering correctly, see the docs gate.","commit_id":"3478148a203bb9f7ab9d46af74309e20f4640954"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"36ed39888c06c09fb883f1aefeaaefa63a109027","unresolved":false,"context_lines":[{"line_number":91,"context_line":".. csv-table:: CSVTable"},{"line_number":92,"context_line":"    :header: Attribute Name,Type,Access,Default Value,Validation Conversion,Description"},{"line_number":93,"context_line":"    monitor_port,int,\"RW, all\",null,int,health check port (optional)"},{"line_number":94,"context_line":"    monitor_address,string (IP Address),\"RW, all\",null,string (IP Address),health check IP address"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Security impact"},{"line_number":97,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bff0334d_b2d073cb","line":94,"range":{"start_line":94,"start_character":75,"end_line":94,"end_character":98},"updated":"2017-04-06 00:20:57.000000000","message":"Also optional","commit_id":"3478148a203bb9f7ab9d46af74309e20f4640954"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"36ed39888c06c09fb883f1aefeaaefa63a109027","unresolved":false,"context_lines":[{"line_number":91,"context_line":".. csv-table:: CSVTable"},{"line_number":92,"context_line":"    :header: Attribute Name,Type,Access,Default Value,Validation Conversion,Description"},{"line_number":93,"context_line":"    monitor_port,int,\"RW, all\",null,int,health check port (optional)"},{"line_number":94,"context_line":"    monitor_address,string (IP Address),\"RW, all\",null,string (IP Address),health check IP address"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Security impact"},{"line_number":97,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bff0334d_f2615b3b","line":94,"range":{"start_line":94,"start_character":20,"end_line":94,"end_character":39},"updated":"2017-04-06 00:20:57.000000000","message":"types.IPAddressType()","commit_id":"3478148a203bb9f7ab9d46af74309e20f4640954"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"36ed39888c06c09fb883f1aefeaaefa63a109027","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    :header: Attribute Name,Type,Access,Default Value,Validation Conversion,Description"},{"line_number":93,"context_line":"    monitor_port,int,\"RW, all\",null,int,health check port (optional)"},{"line_number":94,"context_line":"    monitor_address,string (IP Address),\"RW, all\",null,string (IP Address),health check IP address"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Security impact"},{"line_number":97,"context_line":"---------------"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"bff0334d_b20d1392","line":95,"updated":"2017-04-06 00:20:57.000000000","message":"Additional fields would be returned on get calls as well.","commit_id":"3478148a203bb9f7ab9d46af74309e20f4640954"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"20bf24f52fea53213b776efdd908658cb13f4f1f","unresolved":false,"context_lines":[{"line_number":135,"context_line":"need to supply the protocol port in their POSTs and PUTs to the health monitor"},{"line_number":136,"context_line":"APIs."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"If a plugin was written to be very brittle, it could be the case it would need"},{"line_number":139,"context_line":"to alter its GET handlers for members so that it accounts for the new JSON"},{"line_number":140,"context_line":"fields."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bff0334d_1864b2e3","line":140,"range":{"start_line":138,"start_character":0,"end_line":140,"end_character":7},"updated":"2017-04-06 23:33:12.000000000","message":"Actually GET comes from the database, so would not be impacted by handlers.\nI would just delete this paragraph.","commit_id":"9993c58e372a1e40d86565f2acf6a2473254466d"}],"specs/version1/health_port.rst":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"04855674b52e843547aa2f3a596075e443068b53","unresolved":false,"context_lines":[{"line_number":65,"context_line":"of Openstack."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Any HealthMonitor data models without this new feature would have a field"},{"line_number":68,"context_line":"for protocol port with the value -1 to signify that Octavia\u0027s LBaaS service"},{"line_number":69,"context_line":"should use the member\u0027s protocol port to assess health status."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dfeb2761_a6dd8271","line":68,"updated":"2017-04-04 00:55:50.000000000","message":"We can also do null instead of -1;","commit_id":"85b10833d024fa9b4d8a5c5a14aaf1bb3a7f2095"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"06210ab4e353a8dabb7b9538ff15b80b1a548507","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Proposed change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"The creation of a health monitor would now allow the specification of a port"},{"line_number":37,"context_line":"to monitor. If no port is specified the default behavior would be to use the"},{"line_number":38,"context_line":"port specified by the member."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"There would likely need to be some Horizon changes to support this feature,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dfeb2761_9d619608","line":37,"range":{"start_line":36,"start_character":70,"end_line":37,"end_character":11},"updated":"2017-04-04 15:36:11.000000000","message":"Can we also allow the setting of an IP address along with the port?\nI envision two new parameters per member:\nmonitor_address\nmonitor_port","commit_id":"045f862bd0a8e53a2a266d7dd2bda69387ee075f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"06210ab4e353a8dabb7b9538ff15b80b1a548507","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Proposed change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"The creation of a health monitor would now allow the specification of a port"},{"line_number":37,"context_line":"to monitor. If no port is specified the default behavior would be to use the"},{"line_number":38,"context_line":"port specified by the member."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"There would likely need to be some Horizon changes to support this feature,"},{"line_number":41,"context_line":"however by maintaining the old behavior as the default we will not create"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dfeb2761_1d65861e","line":38,"range":{"start_line":36,"start_character":0,"end_line":38,"end_character":29},"updated":"2017-04-04 15:36:11.000000000","message":"I think we should set this on a per-member level as opposed to the health monitor level.  It would allow more flexibility for the user.","commit_id":"045f862bd0a8e53a2a266d7dd2bda69387ee075f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"06210ab4e353a8dabb7b9538ff15b80b1a548507","unresolved":false,"context_lines":[{"line_number":56,"context_line":"Data model impact"},{"line_number":57,"context_line":"-----------------"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"The HealthMonitor data model would gain a new member variable called protocol"},{"line_number":60,"context_line":"port to store the port that the monitor will query for the health of the"},{"line_number":61,"context_line":"load balancer\u0027s listener\u0027s pool member."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"It is important to have the default behavior fall back on the protocol port of"},{"line_number":64,"context_line":"the member as this will allow any migrations to not break existing deployments"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dfeb2761_f0056912","line":61,"range":{"start_line":59,"start_character":0,"end_line":61,"end_character":39},"updated":"2017-04-04 15:36:11.000000000","message":"Again from above, I think this should be per-member.","commit_id":"045f862bd0a8e53a2a266d7dd2bda69387ee075f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"06210ab4e353a8dabb7b9538ff15b80b1a548507","unresolved":false,"context_lines":[{"line_number":65,"context_line":"of Openstack."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Any HealthMonitor data models without this new feature would have a field"},{"line_number":68,"context_line":"for protocol port with the value -1 or null to signify that Octavia\u0027s LBaaS"},{"line_number":69,"context_line":"service should use the member\u0027s protocol port to assess health status."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dfeb2761_9014dd45","line":68,"range":{"start_line":68,"start_character":27,"end_line":68,"end_character":43},"updated":"2017-04-04 15:36:11.000000000","message":"We should say just null.","commit_id":"045f862bd0a8e53a2a266d7dd2bda69387ee075f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"06210ab4e353a8dabb7b9538ff15b80b1a548507","unresolved":false,"context_lines":[{"line_number":133,"context_line":"Other contributors:"},{"line_number":134,"context_line":"  None"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Work Items"},{"line_number":137,"context_line":"----------"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"- Alter HealthMonitor Data Model"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dfeb2761_706839b8","line":136,"range":{"start_line":136,"start_character":0,"end_line":136,"end_character":10},"updated":"2017-04-04 15:36:11.000000000","message":"You may also need to update the API reference documentation if the impacted sections have been created.","commit_id":"045f862bd0a8e53a2a266d7dd2bda69387ee075f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"06210ab4e353a8dabb7b9538ff15b80b1a548507","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"- Alter HealthMonitor Data Model"},{"line_number":140,"context_line":"- Alter HealthMonitor APIs"},{"line_number":141,"context_line":"- Write or Alter Tests to verify new functionality"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dfeb2761_d06dc5cc","line":141,"range":{"start_line":141,"start_character":2,"end_line":141,"end_character":50},"updated":"2017-04-04 15:36:11.000000000","message":"Please call out unit tests, functional, and tempest tests.","commit_id":"045f862bd0a8e53a2a266d7dd2bda69387ee075f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"06210ab4e353a8dabb7b9538ff15b80b1a548507","unresolved":false,"context_lines":[{"line_number":161,"context_line":"The REST API impact will need to be addressed in documentation so developers"},{"line_number":162,"context_line":"moving forward know about the feature and can use it."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"References"},{"line_number":165,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":".. Octavia Roadmap Considerations: Health monitoring on alternate IPs and/or ports"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dfeb2761_10868d67","line":164,"range":{"start_line":164,"start_character":0,"end_line":164,"end_character":10},"updated":"2017-04-04 15:36:11.000000000","message":"You can include a link to the RFE bug and optionally the other RFEs marked as duplicate.","commit_id":"045f862bd0a8e53a2a266d7dd2bda69387ee075f"}]}