)]}'
{"octavia/api/common/types.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"80943cf4634cbf5d5f5d49324ce0ed5ce572777b","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class BaseType(wtypes.Base):"},{"line_number":64,"context_line":"    @classmethod"},{"line_number":65,"context_line":"    def _full_response(cls):"},{"line_number":66,"context_line":"        return False"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f044301_468f182a","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":22},"updated":"2017-05-05 06:45:52.000000000","message":"class method with private naming convention?","commit_id":"22681fbd5fa650443b1457029cdd6c82bc23d014"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"13a00da75f119ac7e138162f2db46fd9e4cce676","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class BaseType(wtypes.Base):"},{"line_number":64,"context_line":"    @classmethod"},{"line_number":65,"context_line":"    def _full_response(cls):"},{"line_number":66,"context_line":"        return False"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f044301_467ef8e4","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":22},"in_reply_to":"3f044301_468f182a","updated":"2017-05-05 06:50:32.000000000","message":"It being an instance / class / static method, and it using a private naming convention, seem to me to be completely unrelated. The class method is supposed to be used only *internally* to the types classes. It\u0027s not something designed to be part of an API contract. The only place it is used is within subclasses of itself.","commit_id":"22681fbd5fa650443b1457029cdd6c82bc23d014"}],"octavia/api/v2/controllers/listener.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"26815f9ba7ad11acd052ac159120269218fb64e0","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        except odb_exceptions.DBDuplicateEntry as de:"},{"line_number":147,"context_line":"            # Setting LB back to active because this is just a validation"},{"line_number":148,"context_line":"            # failure"},{"line_number":149,"context_line":"            lb_repo.update(session, lb_id,"},{"line_number":150,"context_line":"                           provisioning_status\u003dconstants.ACTIVE)"},{"line_number":151,"context_line":"            column_list \u003d [\u0027load_balancer_id\u0027, \u0027protocol_port\u0027]"},{"line_number":152,"context_line":"            constraint_list \u003d [\u0027uq_listener_load_balancer_id_protocol_port\u0027]"},{"line_number":153,"context_line":"            if [\u0027id\u0027] \u003d\u003d de.columns:"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f044301_ba05c1c4","side":"PARENT","line":150,"range":{"start_line":149,"start_character":1,"end_line":150,"end_character":64},"updated":"2017-05-05 15:48:20.000000000","message":"Why did you remove this?","commit_id":"7467aa28d4070867d47fcc35b8ce8dac1cd12d88"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"9bd0e2ceccaf3a632ccf7d2d34b6359c8607cf1e","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        except odb_exceptions.DBDuplicateEntry as de:"},{"line_number":147,"context_line":"            # Setting LB back to active because this is just a validation"},{"line_number":148,"context_line":"            # failure"},{"line_number":149,"context_line":"            lb_repo.update(session, lb_id,"},{"line_number":150,"context_line":"                           provisioning_status\u003dconstants.ACTIVE)"},{"line_number":151,"context_line":"            column_list \u003d [\u0027load_balancer_id\u0027, \u0027protocol_port\u0027]"},{"line_number":152,"context_line":"            constraint_list \u003d [\u0027uq_listener_load_balancer_id_protocol_port\u0027]"},{"line_number":153,"context_line":"            if [\u0027id\u0027] \u003d\u003d de.columns:"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f044301_1efee236","side":"PARENT","line":150,"range":{"start_line":149,"start_character":1,"end_line":150,"end_character":64},"in_reply_to":"3f044301_ba05c1c4","updated":"2017-05-05 21:03:39.000000000","message":"Because the whole thing is now in a lock_session that\u0027ll be rolled back in case of error, so we don\u0027t need to \"set it back\".","commit_id":"7467aa28d4070867d47fcc35b8ce8dac1cd12d88"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"26815f9ba7ad11acd052ac159120269218fb64e0","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        except odb_exceptions.DBError:"},{"line_number":160,"context_line":"            # Setting LB back to active because this is just a validation"},{"line_number":161,"context_line":"            # failure"},{"line_number":162,"context_line":"            lb_repo.update(session, lb_id,"},{"line_number":163,"context_line":"                           provisioning_status\u003dconstants.ACTIVE)"},{"line_number":164,"context_line":"            raise exceptions.InvalidOption(value\u003dlistener_dict.get(\u0027protocol\u0027),"},{"line_number":165,"context_line":"                                           option\u003d\u0027protocol\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f044301_5a123d0b","side":"PARENT","line":162,"updated":"2017-05-05 15:48:20.000000000","message":"Why did you remove this?","commit_id":"7467aa28d4070867d47fcc35b8ce8dac1cd12d88"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"9bd0e2ceccaf3a632ccf7d2d34b6359c8607cf1e","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        except odb_exceptions.DBError:"},{"line_number":160,"context_line":"            # Setting LB back to active because this is just a validation"},{"line_number":161,"context_line":"            # failure"},{"line_number":162,"context_line":"            lb_repo.update(session, lb_id,"},{"line_number":163,"context_line":"                           provisioning_status\u003dconstants.ACTIVE)"},{"line_number":164,"context_line":"            raise exceptions.InvalidOption(value\u003dlistener_dict.get(\u0027protocol\u0027),"},{"line_number":165,"context_line":"                                           option\u003d\u0027protocol\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f044301_de951ae6","side":"PARENT","line":162,"in_reply_to":"3f044301_5a123d0b","updated":"2017-05-05 21:03:39.000000000","message":"Same.","commit_id":"7467aa28d4070867d47fcc35b8ce8dac1cd12d88"}]}