)]}'
{"diskimage-create/diskimage-create.sh":[{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"b6f44cedb14b6088b67d2f621332acd62c4603a2","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"AMP_IMAGESIZE\u003d${AMP_IMAGESIZE:-2}"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"if [ \"$AMP_BASEOS\" \u003d \"rhel\" ] \u0026\u0026 ! [ \"$AMP_IMAGESIZE\" -ge 3 ]; then"},{"line_number":178,"context_line":"    echo \"RHEL based amphora requires an image size of at least 3GB\""},{"line_number":179,"context_line":"    exit 1"},{"line_number":180,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"ff346bd7_28941444","line":177,"range":{"start_line":177,"start_character":33,"end_line":177,"end_character":34},"updated":"2017-07-22 09:58:41.000000000","message":"@Michael\nThis is asking if $AMP_IMAGESIZE is not greater or equal to 3gb","commit_id":"d4dec9a886953cd96564503ddbd867cb20c2b146"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a0d8bfa51f77e40703f5ae83c2a678db82a42671","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"AMP_IMAGESIZE\u003d${AMP_IMAGESIZE:-2}"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"if [ \"$AMP_BASEOS\" \u003d \"rhel\" ] \u0026\u0026 ! [ \"$AMP_IMAGESIZE\" -ge 3 ]; then"},{"line_number":178,"context_line":"    echo \"RHEL based amphora requires an image size of at least 3GB\""},{"line_number":179,"context_line":"    exit 1"},{"line_number":180,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"ff346bd7_67bc90bb","line":177,"range":{"start_line":177,"start_character":55,"end_line":177,"end_character":57},"updated":"2017-07-21 22:30:30.000000000","message":"Shouldn\u0027t this be lt?","commit_id":"d4dec9a886953cd96564503ddbd867cb20c2b146"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"396cae4e49c2f962297557f99a84a57e83f81273","unresolved":false,"context_lines":[{"line_number":175,"context_line":"AMP_IMAGESIZE\u003d${AMP_IMAGESIZE:-2}"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"if [ \"$AMP_BASEOS\" \u003d \"rhel\" ] \u0026\u0026 [ \"$AMP_IMAGESIZE\" -lt 3 ]; then"},{"line_number":178,"context_line":"    echo \"RHEL based amphora requires an image size of at least 3GB\""},{"line_number":179,"context_line":"    exit 1"},{"line_number":180,"context_line":"fi"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff346bd7_ba7347b1","line":178,"updated":"2017-07-26 05:54:54.000000000","message":"Funny, I actually would have supported something like this instead of \"exit\":\n\nAMP_IMAGE_SIZE\u003d$(($AMP_IMAGE_SIZE\u003e\u003d3?$AMP_IMAGE_SIZE:3))","commit_id":"89285e0d2a6f570a50d93274de5309f07cde40e0"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"e348027da464ed3a6876034224fe1cd54356d297","unresolved":false,"context_lines":[{"line_number":175,"context_line":"AMP_IMAGESIZE\u003d${AMP_IMAGESIZE:-2}"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"if [ \"$AMP_BASEOS\" \u003d \"rhel\" ] \u0026\u0026 [ \"$AMP_IMAGESIZE\" -lt 3 ]; then"},{"line_number":178,"context_line":"    echo \"RHEL based amphora requires an image size of at least 3GB\""},{"line_number":179,"context_line":"    exit 1"},{"line_number":180,"context_line":"fi"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff346bd7_e30806da","line":178,"in_reply_to":"ff346bd7_ba7347b1","updated":"2017-07-26 07:37:56.000000000","message":"I understand your point, but IMHO I\u0027d prefer the user to be aware of the image size he/she need to allocate for that RHEL based amphora image, rather than the diskimage-create to have a separate default for that Linux flavor.\n\nThat also might help to prevent the user from blindly create a nova flavor with insufficient disk size, which as you know better than me, will leads to failures with creating loadbalancers.","commit_id":"89285e0d2a6f570a50d93274de5309f07cde40e0"}]}