)]}'
{"octavia/api/common/pagination.py":[{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"7c7e7eb8684de5cdf23704273dca00d8255cf916","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        if CONF.allow_filtering:"},{"line_number":200,"context_line":"            query_filter \u003d {}"},{"line_number":201,"context_line":"            for key, value in self.filter.items():"},{"line_number":202,"context_line":"                if hasattr(model, key):"},{"line_number":203,"context_line":"                    query_filter[key] \u003d value"},{"line_number":204,"context_line":"            query \u003d query.filter_by(**query_filter)"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_25c9f557","line":202,"range":{"start_line":202,"start_character":16,"end_line":202,"end_character":39},"updated":"2017-06-06 08:21:58.000000000","message":"if the model obj contains the attributes like \u0027__XXX__\u0027, is that OK?","commit_id":"93a51508082af5dd2cededafbb531215acc14db0"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"29db15d66416f79bfaba04c1b9a106d8092aea3c","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                query \u003d query.limit(self.limit)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        # We only need the ID"},{"line_number":281,"context_line":"        query \u003d query.options(load_only(model.id))"},{"line_number":282,"context_line":"        model_list \u003d query.all()"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        links \u003d None"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f201791_0670f1a4","line":281,"range":{"start_line":281,"start_character":8,"end_line":281,"end_character":13},"updated":"2017-06-22 02:56:12.000000000","message":"If you inspect this query right here it should look like:\n\nSELECT listener.id AS listener_id\nFROM listener\nWHERE listener.provisioning_status !\u003d %(provisioning_status_1)s ORDER BY listener.created_at ASC, listener.id ASC\n LIMIT %(param_1)s\n\nWhere before it was getting all of the columns from the DB.","commit_id":"48ce8cfaacb8b811d4f0cdcbe062327aacdf04dc"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"f276c070adf0814481c42555483fcdb4ff39b68c","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        # We only need the ID except for quotas"},{"line_number":281,"context_line":"        if hasattr(model, \u0027id\u0027):"},{"line_number":282,"context_line":"            query \u003d query.options(load_only(model.id))"},{"line_number":283,"context_line":"        model_list \u003d query.all()"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        links \u003d None"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f201791_1565b5b5","line":282,"range":{"start_line":282,"start_character":12,"end_line":282,"end_character":17},"updated":"2017-06-22 07:14:18.000000000","message":"adding my comment back in:\nIf you inspect this query right here it should look like:\nSELECT listener.id AS listener_id\nFROM listener\nWHERE listener.provisioning_status !\u003d %(provisioning_status_1)s ORDER BY listener.created_at ASC, listener.id ASC\n LIMIT %(param_1)s\nWhere before it was getting all of the columns from the DB.","commit_id":"14171fb7f85875773c6e81139b16b353a93ad5d7"}],"octavia/api/v2/controllers/base.py":[{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"7c7e7eb8684de5cdf23704273dca00d8255cf916","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    @staticmethod"},{"line_number":161,"context_line":"    def _get_member_variables(obj):"},{"line_number":162,"context_line":"        members \u003d [attr for attr in dir(obj) if not callable("},{"line_number":163,"context_line":"            getattr(obj, attr)) and not attr.startswith(\"_\")]"},{"line_number":164,"context_line":"        return members"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_253c552d","line":163,"range":{"start_line":162,"start_character":17,"end_line":163,"end_character":61},"updated":"2017-06-06 08:21:58.000000000","message":"OH, it\u0027s here. But like \u0027to_data_model\u0027.","commit_id":"93a51508082af5dd2cededafbb531215acc14db0"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d97890ef86407ad84b48882cddbec8dc61f40066","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    def _filter_fields(self, object_list, fields):"},{"line_number":179,"context_line":"        if CONF.allow_field_selection:"},{"line_number":180,"context_line":"            index \u003d 0"},{"line_number":181,"context_line":"            for obj in object_list:"},{"line_number":182,"context_line":"                members \u003d self._get_attrs(obj)"},{"line_number":183,"context_line":"                for member in members:"},{"line_number":184,"context_line":"                    if member not in fields:"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f201791_2db28a95","line":181,"updated":"2017-06-22 23:21:32.000000000","message":"Probably you just wanted `for index, obj in enumerate(object_list):`","commit_id":"fa6ed2af1bde4d625fb51319740517b8e263e45b"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"4077a8304d7f345081cb822bc64cd75db793e11d","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    def _filter_fields(self, object_list, fields):"},{"line_number":179,"context_line":"        if CONF.allow_field_selection:"},{"line_number":180,"context_line":"            index \u003d 0"},{"line_number":181,"context_line":"            for obj in object_list:"},{"line_number":182,"context_line":"                members \u003d self._get_attrs(obj)"},{"line_number":183,"context_line":"                for member in members:"},{"line_number":184,"context_line":"                    if member not in fields:"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f201791_c85e6411","line":181,"in_reply_to":"5f201791_2db28a95","updated":"2017-06-22 23:36:01.000000000","message":"Done","commit_id":"fa6ed2af1bde4d625fb51319740517b8e263e45b"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f517695136515fb0c6e090ba03de76d76ee56691","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                for member in members:"},{"line_number":183,"context_line":"                    if member not in fields:"},{"line_number":184,"context_line":"                        delattr(object_list[index], member)"},{"line_number":185,"context_line":"                index +\u003d 1"},{"line_number":186,"context_line":"        return object_list"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f201791_43f6b7fb","line":185,"updated":"2017-06-23 00:41:20.000000000","message":"Using that means you need to remove this index increment (though technically it will reset on the next loop, but ... \u003c_\u003c","commit_id":"ccbb01f86789a5acc8e840aa2eb73a669343107a"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"7296adcce7f84d86ad7abff025726041aa455306","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                for member in members:"},{"line_number":183,"context_line":"                    if member not in fields:"},{"line_number":184,"context_line":"                        delattr(object_list[index], member)"},{"line_number":185,"context_line":"                index +\u003d 1"},{"line_number":186,"context_line":"        return object_list"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f201791_63cc13bc","line":185,"in_reply_to":"5f201791_43f6b7fb","updated":"2017-06-23 00:42:05.000000000","message":")","commit_id":"ccbb01f86789a5acc8e840aa2eb73a669343107a"}],"octavia/db/base_models.py":[{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"ba04a7b1ad9e251550440926fa24f03742a93267","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            if filters[\u0027admin_state_up\u0027].lower() in [\u0027True\u0027, \u0027true\u0027, \u00271\u0027]:"},{"line_number":112,"context_line":"                filters[\u0027admin_state_up\u0027] \u003d True"},{"line_number":113,"context_line":"            else:"},{"line_number":114,"context_line":"                filters[\u0027admin_state_up\u0027] \u003d False"},{"line_number":115,"context_line":"        for attr, name_map in model.__v2_wsme__._child_map.items():"},{"line_number":116,"context_line":"            for k, v in name_map.items():"},{"line_number":117,"context_line":"                if v in filters:"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f231b9d_e60b63d3","line":114,"updated":"2017-06-14 18:50:01.000000000","message":"Not sure if I should default to false here or if I should throw an attribute error.","commit_id":"5870150347c67866b604486255a6762e19f7ac94"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"388dc177e103d4265c2d535aff5591c8375ec18d","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                filters[\u0027admin_state_up\u0027] \u003d True"},{"line_number":113,"context_line":"            else:"},{"line_number":114,"context_line":"                filters[\u0027admin_state_up\u0027] \u003d False"},{"line_number":115,"context_line":"        for attr, name_map in model.__v2_wsme__._child_map.items():"},{"line_number":116,"context_line":"            for k, v in name_map.items():"},{"line_number":117,"context_line":"                if v in filters:"},{"line_number":118,"context_line":"                    child_map[attr] \u003d {k: filters.pop(v)}"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f231b9d_b472277a","line":115,"range":{"start_line":115,"start_character":0,"end_line":115,"end_character":8},"updated":"2017-06-15 07:33:31.000000000","message":"both of these for loops could be list comprehensions but I didn\u0027t really see a point in doing that as it just makes this really ugly.","commit_id":"5870150347c67866b604486255a6762e19f7ac94"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"ba04a7b1ad9e251550440926fa24f03742a93267","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        translated_filters.update(filters)"},{"line_number":123,"context_line":"        if translated_filters:"},{"line_number":124,"context_line":"            query \u003d query.filter_by(**translated_filters)"},{"line_number":125,"context_line":"        for k, v in child_map.items():"},{"line_number":126,"context_line":"            query \u003d query.join(getattr(model, k)).filter_by(**v)"},{"line_number":127,"context_line":"        return query"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7f231b9d_e6d92357","line":125,"updated":"2017-06-14 18:50:01.000000000","message":"Right now the only thing that needs to map a child element is loadbalancers and the only thing it needs to map is the vip table.","commit_id":"5870150347c67866b604486255a6762e19f7ac94"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d97890ef86407ad84b48882cddbec8dc61f40066","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        child_map \u003d {}"},{"line_number":109,"context_line":"        # Convert admin_state_up to proper type"},{"line_number":110,"context_line":"        if \u0027admin_state_up\u0027 in filters:"},{"line_number":111,"context_line":"            if filters[\u0027admin_state_up\u0027].lower() in [\u0027true\u0027, \u00271\u0027]:"},{"line_number":112,"context_line":"                filters[\u0027admin_state_up\u0027] \u003d True"},{"line_number":113,"context_line":"            else:"},{"line_number":114,"context_line":"                filters[\u0027admin_state_up\u0027] \u003d False"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f201791_ad4c5a9e","line":111,"updated":"2017-06-22 23:21:32.000000000","message":"Probably you want: https://docs.openstack.org/developer/oslo.utils/api/strutils.html#oslo_utils.strutils.bool_from_string\n\nfilters[\u0027admin_state_up\u0027] \u003d oslo_utils.strutils.bool_from_string(filters[\u0027admin_state_up\u0027])","commit_id":"fa6ed2af1bde4d625fb51319740517b8e263e45b"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"4077a8304d7f345081cb822bc64cd75db793e11d","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        child_map \u003d {}"},{"line_number":109,"context_line":"        # Convert admin_state_up to proper type"},{"line_number":110,"context_line":"        if \u0027admin_state_up\u0027 in filters:"},{"line_number":111,"context_line":"            if filters[\u0027admin_state_up\u0027].lower() in [\u0027true\u0027, \u00271\u0027]:"},{"line_number":112,"context_line":"                filters[\u0027admin_state_up\u0027] \u003d True"},{"line_number":113,"context_line":"            else:"},{"line_number":114,"context_line":"                filters[\u0027admin_state_up\u0027] \u003d False"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f201791_68a51004","line":111,"in_reply_to":"5f201791_ad4c5a9e","updated":"2017-06-22 23:36:01.000000000","message":"Done","commit_id":"fa6ed2af1bde4d625fb51319740517b8e263e45b"}]}