)]}'
{"doc/source/main/policy.rst":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"5bda24aa0c3d9b6e930594bed93aa146e3390d2c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"----------------------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"This will output a policy file which includes all registered policy defaults"},{"line_number":50,"context_line":"and all policies configured with a policy file. This file shows the effective"},{"line_number":51,"context_line":"policy in use by the project::"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    oslopolicy-policy-generator"}],"source_content_type":"text/x-rst","patch_set":19,"id":"5f201791_c9191389","line":50,"updated":"2017-06-21 08:34:17.000000000","message":"is \"effective\" the right word here? I\u0027m having trouble parsing this, but it could just be me, I woke up really early today...","commit_id":"0ce46fe8d09c35b9f6494e335193a1c02812fb0e"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"947505862a1b30953b1170aca03aafe4a5c6afb3","unresolved":false,"context_lines":[{"line_number":47,"context_line":"----------------------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"This will output a policy file which includes all registered policy defaults"},{"line_number":50,"context_line":"and all policies configured with a policy file. This file shows the effective"},{"line_number":51,"context_line":"policy in use by the project::"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    oslopolicy-policy-generator"}],"source_content_type":"text/x-rst","patch_set":19,"id":"5f201791_e7997d1f","line":50,"in_reply_to":"5f201791_6e80af8c","updated":"2017-06-21 18:11:35.000000000","message":"Yep, I was definitely just tired, I get it now.","commit_id":"0ce46fe8d09c35b9f6494e335193a1c02812fb0e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a74dc0fc941aec6a27c46b3be909c9663eb8a64d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"----------------------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"This will output a policy file which includes all registered policy defaults"},{"line_number":50,"context_line":"and all policies configured with a policy file. This file shows the effective"},{"line_number":51,"context_line":"policy in use by the project::"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    oslopolicy-policy-generator"}],"source_content_type":"text/x-rst","patch_set":19,"id":"5f201791_6e80af8c","line":50,"in_reply_to":"5f201791_c9191389","updated":"2017-06-21 14:14:30.000000000","message":"Borrowed from here because I wanted to have reasonable docs in our project: https://docs.openstack.org/developer/oslo.policy/usage.html#merged-file-generation\n\nI think effective is the correct word as this takes into account not only the defaults in the code, but the operator override policy.json.  So this command generates the \"effective\" policy being enforced.","commit_id":"0ce46fe8d09c35b9f6494e335193a1c02812fb0e"}],"etc/policy/README.rst":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"5bda24aa0c3d9b6e930594bed93aa146e3390d2c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"The sample policy.json files described here can be copied into"},{"line_number":6,"context_line":"/etc/octavia/policy.json to override the default RBAC policy for Octavia."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"admin_or_owner-policy.json"},{"line_number":9,"context_line":"--------------------------"},{"line_number":10,"context_line":"This policy file disables the requirement for load-balancer service users to"},{"line_number":11,"context_line":"have one of the load-balancer:* roles.  It provides a similar policy to"}],"source_content_type":"text/x-rst","patch_set":19,"id":"5f201791_ac03850d","line":8,"updated":"2017-06-21 08:34:17.000000000","message":"Yep, I think I\u0027ll end up using this in my deployment... T_T","commit_id":"0ce46fe8d09c35b9f6494e335193a1c02812fb0e"}],"octavia/common/constants.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"0d27e45f596dc50f648cc1a51943f66e942d066f","unresolved":false,"context_lines":[{"line_number":423,"context_line":"DEFAULT_PAGE_SIZE \u003d 1000"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"# RBAC"},{"line_number":426,"context_line":"LOADBALANCER_API \u003d \u0027os_load-balancer_api\u0027"},{"line_number":427,"context_line":"RULE_ADMIN_OR_OWNER \u003d \u0027rule:admin_or_owner\u0027"},{"line_number":428,"context_line":"RULE_ADMIN_API \u003d \u0027rule:admin_api\u0027"},{"line_number":429,"context_line":"RULE_ANY \u003d \u0027@\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_4a3bb5d0","line":426,"updated":"2017-06-10 19:02:08.000000000","message":"I swear to @$*\u0026 these dashes are going to kill me. You did \"loadbalancer\" below, just use that, PLEASE. T_T","commit_id":"34fa691adec4e88c65fe93aff5839e6ccd399776"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bd11f26b46f252b178f80181d6b33fe8cfd54c47","unresolved":false,"context_lines":[{"line_number":423,"context_line":"DEFAULT_PAGE_SIZE \u003d 1000"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"# RBAC"},{"line_number":426,"context_line":"LOADBALANCER_API \u003d \u0027os_load-balancer_api\u0027"},{"line_number":427,"context_line":"RULE_ADMIN_OR_OWNER \u003d \u0027rule:admin_or_owner\u0027"},{"line_number":428,"context_line":"RULE_ADMIN_API \u003d \u0027rule:admin_api\u0027"},{"line_number":429,"context_line":"RULE_ANY \u003d \u0027@\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_fd5ea9e4","line":426,"in_reply_to":"7f231b9d_4a3bb5d0","updated":"2017-06-12 16:33:00.000000000","message":"Actually I can\u0027t, to be consistent this has to be our service catalog type, which is \"load-balancer\".","commit_id":"34fa691adec4e88c65fe93aff5839e6ccd399776"}],"octavia/tests/functional/api/v2/base.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"5bda24aa0c3d9b6e930594bed93aa146e3390d2c","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                    provisioning_status\u003dprovisioning_status,"},{"line_number":376,"context_line":"                    operating_status\u003doperating_status)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    def assert_final_listener_statuses(self, lb_id, listener_id, delete\u003dFalse):"},{"line_number":379,"context_line":"        expected_prov_status \u003d constants.ACTIVE"},{"line_number":380,"context_line":"        expected_op_status \u003d constants.ONLINE"},{"line_number":381,"context_line":"        if delete:"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f201791_4c4ab127","line":378,"updated":"2017-06-21 08:34:17.000000000","message":"I know this isn\u0027t something you touched, but you opened the can a little bit by removing the above check: why does this *set* the lb_status at all?","commit_id":"0ce46fe8d09c35b9f6494e335193a1c02812fb0e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a74dc0fc941aec6a27c46b3be909c9663eb8a64d","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                    provisioning_status\u003dprovisioning_status,"},{"line_number":376,"context_line":"                    operating_status\u003doperating_status)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    def assert_final_listener_statuses(self, lb_id, listener_id, delete\u003dFalse):"},{"line_number":379,"context_line":"        expected_prov_status \u003d constants.ACTIVE"},{"line_number":380,"context_line":"        expected_op_status \u003d constants.ONLINE"},{"line_number":381,"context_line":"        if delete:"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f201791_6e078f1e","line":378,"in_reply_to":"5f201791_4c4ab127","updated":"2017-06-21 14:14:30.000000000","message":"Agreed, this is similar to the load balancer stuff I fixed.  However, the overall test probably needs to be re-evaluated so I would prefer we do that in another patch.","commit_id":"0ce46fe8d09c35b9f6494e335193a1c02812fb0e"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"947505862a1b30953b1170aca03aafe4a5c6afb3","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                    provisioning_status\u003dprovisioning_status,"},{"line_number":376,"context_line":"                    operating_status\u003doperating_status)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    def assert_final_listener_statuses(self, lb_id, listener_id, delete\u003dFalse):"},{"line_number":379,"context_line":"        expected_prov_status \u003d constants.ACTIVE"},{"line_number":380,"context_line":"        expected_op_status \u003d constants.ONLINE"},{"line_number":381,"context_line":"        if delete:"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f201791_07beb964","line":378,"in_reply_to":"5f201791_6e078f1e","updated":"2017-06-21 18:11:35.000000000","message":"Fine by me, but we should try not to forget. ;)","commit_id":"0ce46fe8d09c35b9f6494e335193a1c02812fb0e"}],"octavia/tests/functional/api/v2/test_listener.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"5bda24aa0c3d9b6e930594bed93aa146e3390d2c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        super(TestListener, self).setUp()"},{"line_number":36,"context_line":"        self.lb \u003d self.create_load_balancer(uuidutils.generate_uuid())"},{"line_number":37,"context_line":"        self.lb_id \u003d self.lb.get(\u0027loadbalancer\u0027).get(\u0027id\u0027)"},{"line_number":38,"context_line":"        self.project_id \u003d self.lb.get(\u0027loadbalancer\u0027).get(\u0027project_id\u0027)"},{"line_number":39,"context_line":"        self.set_lb_status(self.lb_id)"},{"line_number":40,"context_line":"        self.listener_path \u003d self.LISTENERS_PATH + \u0027/{listener_id}\u0027"},{"line_number":41,"context_line":"        self.pool \u003d self.create_pool("}],"source_content_type":"text/x-python","patch_set":19,"id":"5f201791_6cf7adf7","line":38,"updated":"2017-06-21 08:34:17.000000000","message":"Is this going to ever be different from the self.project_id that\u0027s set in the base?","commit_id":"0ce46fe8d09c35b9f6494e335193a1c02812fb0e"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"947505862a1b30953b1170aca03aafe4a5c6afb3","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        super(TestListener, self).setUp()"},{"line_number":36,"context_line":"        self.lb \u003d self.create_load_balancer(uuidutils.generate_uuid())"},{"line_number":37,"context_line":"        self.lb_id \u003d self.lb.get(\u0027loadbalancer\u0027).get(\u0027id\u0027)"},{"line_number":38,"context_line":"        self.project_id \u003d self.lb.get(\u0027loadbalancer\u0027).get(\u0027project_id\u0027)"},{"line_number":39,"context_line":"        self.set_lb_status(self.lb_id)"},{"line_number":40,"context_line":"        self.listener_path \u003d self.LISTENERS_PATH + \u0027/{listener_id}\u0027"},{"line_number":41,"context_line":"        self.pool \u003d self.create_pool("}],"source_content_type":"text/x-python","patch_set":19,"id":"5f201791_47ab911c","line":38,"in_reply_to":"5f201791_6270c373","updated":"2017-06-21 18:11:35.000000000","message":"Sure.","commit_id":"0ce46fe8d09c35b9f6494e335193a1c02812fb0e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a74dc0fc941aec6a27c46b3be909c9663eb8a64d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        super(TestListener, self).setUp()"},{"line_number":36,"context_line":"        self.lb \u003d self.create_load_balancer(uuidutils.generate_uuid())"},{"line_number":37,"context_line":"        self.lb_id \u003d self.lb.get(\u0027loadbalancer\u0027).get(\u0027id\u0027)"},{"line_number":38,"context_line":"        self.project_id \u003d self.lb.get(\u0027loadbalancer\u0027).get(\u0027project_id\u0027)"},{"line_number":39,"context_line":"        self.set_lb_status(self.lb_id)"},{"line_number":40,"context_line":"        self.listener_path \u003d self.LISTENERS_PATH + \u0027/{listener_id}\u0027"},{"line_number":41,"context_line":"        self.pool \u003d self.create_pool("}],"source_content_type":"text/x-python","patch_set":19,"id":"5f201791_6270c373","line":38,"in_reply_to":"5f201791_6cf7adf7","updated":"2017-06-21 14:14:30.000000000","message":"Good point, I didn\u0027t see that there was one in the base that the \"create\" methods use.\nCan we defer this change to the end of the chain?  I will clean it up there?","commit_id":"0ce46fe8d09c35b9f6494e335193a1c02812fb0e"}],"octavia/tests/unit/common/test_policy.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"5bda24aa0c3d9b6e930594bed93aa146e3390d2c","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        super(IsAdminCheckTestCase, self).setUp()"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        self.conf \u003d self.useFixture(oslo_fixture.Config())"},{"line_number":173,"context_line":"        # diltram: this one must be removed after fixing issue in oslo.config"},{"line_number":174,"context_line":"        # https://bugs.launchpad.net/oslo.config/+bug/1645868"},{"line_number":175,"context_line":"        self.conf.conf.__call__(args\u003d[])"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"5f201791_6cafad94","line":173,"updated":"2017-06-21 08:34:17.000000000","message":"Is this a \"TODO(diltram):\"? Does he still work on this? Or are you just saying he was the one that told you this?","commit_id":"0ce46fe8d09c35b9f6494e335193a1c02812fb0e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a74dc0fc941aec6a27c46b3be909c9663eb8a64d","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        super(IsAdminCheckTestCase, self).setUp()"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        self.conf \u003d self.useFixture(oslo_fixture.Config())"},{"line_number":173,"context_line":"        # diltram: this one must be removed after fixing issue in oslo.config"},{"line_number":174,"context_line":"        # https://bugs.launchpad.net/oslo.config/+bug/1645868"},{"line_number":175,"context_line":"        self.conf.conf.__call__(args\u003d[])"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"5f201791_e22cd39a","line":173,"in_reply_to":"5f201791_6cafad94","updated":"2017-06-21 14:14:30.000000000","message":"This workaround is in other parts of the code so for find-and-remove purposes I copied the comment intact.  I just found that we needed this in additional areas due to the oslo bug.","commit_id":"0ce46fe8d09c35b9f6494e335193a1c02812fb0e"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"947505862a1b30953b1170aca03aafe4a5c6afb3","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        super(IsAdminCheckTestCase, self).setUp()"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        self.conf \u003d self.useFixture(oslo_fixture.Config())"},{"line_number":173,"context_line":"        # diltram: this one must be removed after fixing issue in oslo.config"},{"line_number":174,"context_line":"        # https://bugs.launchpad.net/oslo.config/+bug/1645868"},{"line_number":175,"context_line":"        self.conf.conf.__call__(args\u003d[])"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"5f201791_0763591c","line":173,"in_reply_to":"5f201791_e22cd39a","updated":"2017-06-21 18:11:35.000000000","message":"kk.","commit_id":"0ce46fe8d09c35b9f6494e335193a1c02812fb0e"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"5bda24aa0c3d9b6e930594bed93aa146e3390d2c","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        super(AdminRolePolicyTestCase, self).setUp()"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        self.conf \u003d self.useFixture(oslo_fixture.Config())"},{"line_number":216,"context_line":"        # diltram: this one must be removed after fixing issue in oslo.config"},{"line_number":217,"context_line":"        # https://bugs.launchpad.net/oslo.config/+bug/1645868"},{"line_number":218,"context_line":"        self.conf.conf.__call__(args\u003d[])"},{"line_number":219,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"5f201791_4c94f144","line":216,"updated":"2017-06-21 08:34:17.000000000","message":"same","commit_id":"0ce46fe8d09c35b9f6494e335193a1c02812fb0e"}]}