)]}'
{"etc/octavia.conf":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9772733dc284377fc98c32d68c1a72f90fff297a","unresolved":false,"context_lines":[{"line_number":122,"context_line":"# port_detach_timeout \u003d 300"},{"line_number":123,"context_line":"# Allow/disallow specific network object types when creating VIPs."},{"line_number":124,"context_line":"# By default, all types are allowed."},{"line_number":125,"context_line":"# allow_vip_network_id \u003d"},{"line_number":126,"context_line":"# allow_vip_subnet_id \u003d"},{"line_number":127,"context_line":"# allow_vip_port_id \u003d"},{"line_number":128,"context_line":"# List of network_ids that are valid for VIP creation"}],"source_content_type":"text/plain","patch_set":1,"id":"7f231b9d_4ddc4be3","line":125,"updated":"2017-06-16 20:50:59.000000000","message":"If they are allowed, there should be \"True\"s here","commit_id":"b345bc67cd15a47202434b8f78999283a708f876"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"a42af69310511d126ded28ae3705e10db0e6165d","unresolved":false,"context_lines":[{"line_number":122,"context_line":"# port_detach_timeout \u003d 300"},{"line_number":123,"context_line":"# Allow/disallow specific network object types when creating VIPs."},{"line_number":124,"context_line":"# By default, all types are allowed."},{"line_number":125,"context_line":"# allow_vip_network_id \u003d"},{"line_number":126,"context_line":"# allow_vip_subnet_id \u003d"},{"line_number":127,"context_line":"# allow_vip_port_id \u003d"},{"line_number":128,"context_line":"# List of network_ids that are valid for VIP creation"}],"source_content_type":"text/plain","patch_set":1,"id":"7f231b9d_56cefe59","line":125,"in_reply_to":"7f231b9d_4ddc4be3","updated":"2017-06-16 21:42:43.000000000","message":"Ah, I thought we left default values blank, but i see we don\u0027t, so yeah I\u0027ll do that.","commit_id":"b345bc67cd15a47202434b8f78999283a708f876"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9772733dc284377fc98c32d68c1a72f90fff297a","unresolved":false,"context_lines":[{"line_number":126,"context_line":"# allow_vip_subnet_id \u003d"},{"line_number":127,"context_line":"# allow_vip_port_id \u003d"},{"line_number":128,"context_line":"# List of network_ids that are valid for VIP creation"},{"line_number":129,"context_line":"# valid_vip_networks \u003d"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"[haproxy_amphora]"},{"line_number":132,"context_line":"# base_path \u003d /var/lib/octavia"}],"source_content_type":"text/plain","patch_set":1,"id":"7f231b9d_0de2d3a0","line":129,"updated":"2017-06-16 20:50:59.000000000","message":"Ummm, ok, so what is the setting for \"I don\u0027t care\" which should be default?","commit_id":"b345bc67cd15a47202434b8f78999283a708f876"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"a42af69310511d126ded28ae3705e10db0e6165d","unresolved":false,"context_lines":[{"line_number":126,"context_line":"# allow_vip_subnet_id \u003d"},{"line_number":127,"context_line":"# allow_vip_port_id \u003d"},{"line_number":128,"context_line":"# List of network_ids that are valid for VIP creation"},{"line_number":129,"context_line":"# valid_vip_networks \u003d"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"[haproxy_amphora]"},{"line_number":132,"context_line":"# base_path \u003d /var/lib/octavia"}],"source_content_type":"text/plain","patch_set":1,"id":"7f231b9d_36d94221","line":129,"in_reply_to":"7f231b9d_0de2d3a0","updated":"2017-06-16 21:42:43.000000000","message":"Yeah I need to make a note that blank \u003d\u003d no validation","commit_id":"b345bc67cd15a47202434b8f78999283a708f876"}],"octavia/common/config.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9772733dc284377fc98c32d68c1a72f90fff297a","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    cfg.BoolOpt(\u0027allow_vip_port_id\u0027, default\u003dTrue,"},{"line_number":100,"context_line":"                help\u003d_(\u0027Can users supply a port_id for their VIP?\u0027)),"},{"line_number":101,"context_line":"    cfg.ListOpt(\u0027valid_vip_networks\u0027,"},{"line_number":102,"context_line":"                help\u003d_(\u0027List of network_ids that are valid for VIP \u0027"},{"line_number":103,"context_line":"                       \u0027creation.\u0027)),"},{"line_number":104,"context_line":"]"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_7c79e3c5","line":102,"updated":"2017-06-16 20:50:59.000000000","message":"Same here, please add the \"how to ignore\", blank seems to imply no networks are valid.","commit_id":"b345bc67cd15a47202434b8f78999283a708f876"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"a42af69310511d126ded28ae3705e10db0e6165d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    cfg.BoolOpt(\u0027allow_vip_port_id\u0027, default\u003dTrue,"},{"line_number":100,"context_line":"                help\u003d_(\u0027Can users supply a port_id for their VIP?\u0027)),"},{"line_number":101,"context_line":"    cfg.ListOpt(\u0027valid_vip_networks\u0027,"},{"line_number":102,"context_line":"                help\u003d_(\u0027List of network_ids that are valid for VIP \u0027"},{"line_number":103,"context_line":"                       \u0027creation.\u0027)),"},{"line_number":104,"context_line":"]"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_9601366d","line":102,"in_reply_to":"7f231b9d_7c79e3c5","updated":"2017-06-16 21:42:43.000000000","message":"OK yeah, I\u0027ll update for \"blank \u003d no validation\"","commit_id":"b345bc67cd15a47202434b8f78999283a708f876"}],"octavia/common/exceptions.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9772733dc284377fc98c32d68c1a72f90fff297a","unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"class VIPValidationException(APIException):"},{"line_number":290,"context_line":"    msg \u003d _(\u0027Validation failure: VIP must contain one of: %(objects)s.\u0027)"},{"line_number":291,"context_line":"    code \u003d 400"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_8bd22fd0","line":290,"range":{"start_line":290,"start_character":33,"end_line":290,"end_character":36},"updated":"2017-06-16 20:50:59.000000000","message":"Is it VIP to the user or load balancer?  We don\u0027t directly expose the VIP to the user anymore.","commit_id":"b345bc67cd15a47202434b8f78999283a708f876"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"a42af69310511d126ded28ae3705e10db0e6165d","unresolved":false,"context_lines":[{"line_number":287,"context_line":""},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"class VIPValidationException(APIException):"},{"line_number":290,"context_line":"    msg \u003d _(\u0027Validation failure: VIP must contain one of: %(objects)s.\u0027)"},{"line_number":291,"context_line":"    code \u003d 400"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_76fc5a6f","line":290,"range":{"start_line":290,"start_character":33,"end_line":290,"end_character":36},"in_reply_to":"7f231b9d_8bd22fd0","updated":"2017-06-16 21:42:43.000000000","message":"To the user -- they passed in \"vip_network_id\"/etc as such","commit_id":"b345bc67cd15a47202434b8f78999283a708f876"}]}