)]}'
{"octavia/api/v2/controllers/load_balancer.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c8cf1cfbc01fb7bdfd0777ff56446d9bfa8e780d","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"class LoadBalancersController(base.BaseController, stats.StatsMixin):"},{"line_number":45,"context_line":"    _custom_actions \u003d {"},{"line_number":46,"context_line":"        \u0027statuses\u0027: [\u0027GET\u0027],"},{"line_number":47,"context_line":"        \u0027stats\u0027: [\u0027GET\u0027]"},{"line_number":48,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f201791_e84800cd","line":45,"updated":"2017-06-23 00:06:11.000000000","message":"Same issue here, custom_actions don\u0027t work this way.","commit_id":"bdc704b6ba170e027804240113345fe3d5acf712"}],"octavia/tests/functional/api/v2/base.py":[{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"8fcd263689efb476de093a93b8fb8bf826da463c","unresolved":false,"context_lines":[{"line_number":185,"context_line":"            request_errors\u003d0)"},{"line_number":186,"context_line":"        return db_ls.to_dict()"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def create_listener_stats_dynamic(self, listener_id, amphora_id,"},{"line_number":189,"context_line":"                                      bytes_in\u003d0, bytes_out\u003d0,"},{"line_number":190,"context_line":"                                      active_connections\u003d0,"},{"line_number":191,"context_line":"                                      total_connections\u003d0, request_errors\u003d0):"},{"line_number":192,"context_line":"        db_ls \u003d self.listener_stats_repo.create("},{"line_number":193,"context_line":"            db_api.get_session(), listener_id\u003dlistener_id,"},{"line_number":194,"context_line":"            amphora_id\u003damphora_id, bytes_in\u003dbytes_in,"},{"line_number":195,"context_line":"            bytes_out\u003dbytes_out, active_connections\u003dactive_connections,"},{"line_number":196,"context_line":"            total_connections\u003dtotal_connections, request_errors\u003drequest_errors)"},{"line_number":197,"context_line":"        return db_ls.to_dict()"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def create_amphora(self, amphora_id, loadbalancer_id, **optionals):"},{"line_number":200,"context_line":"        # We need to default these values in the request."}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_71ab5a74","line":197,"range":{"start_line":188,"start_character":4,"end_line":197,"end_character":30},"updated":"2017-06-16 08:13:59.000000000","message":"I could easily move this under create_listener_stats as well rather than make it its own method. as it doesn\u0027t change the functionality of the method. Opinions?","commit_id":"562c9fc0792d65afb6e4cd589453b2184282daa9"}],"octavia/tests/functional/api/v2/test_load_balancer.py":[{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"8fcd263689efb476de093a93b8fb8bf826da463c","unresolved":false,"context_lines":[{"line_number":1588,"context_line":"        ls \u003d self.create_listener_stats_dynamic("},{"line_number":1589,"context_line":"            listener_id\u003dli.get(\u0027id\u0027),"},{"line_number":1590,"context_line":"            amphora_id\u003damphora.id,"},{"line_number":1591,"context_line":"            bytes_in\u003drandom.randint(0, 9),"},{"line_number":1592,"context_line":"            bytes_out\u003drandom.randint(0, 9),"},{"line_number":1593,"context_line":"            total_connections\u003drandom.randint(0, 9))"},{"line_number":1594,"context_line":""},{"line_number":1595,"context_line":"        response \u003d self._getStats(lb[\u0027id\u0027])"},{"line_number":1596,"context_line":"        self.assertEqual(ls[\u0027bytes_in\u0027], response[\u0027bytes_in\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_719d9a64","line":1593,"range":{"start_line":1591,"start_character":12,"end_line":1593,"end_character":51},"updated":"2017-06-16 08:13:59.000000000","message":"not 100% sure about this. It just felt weird leaving these values as 0.","commit_id":"562c9fc0792d65afb6e4cd589453b2184282daa9"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"09e4d08dfb963173f1d5a4a77012fdf42ddd8787","unresolved":false,"context_lines":[{"line_number":1588,"context_line":"        ls \u003d self.create_listener_stats_dynamic("},{"line_number":1589,"context_line":"            listener_id\u003dli.get(\u0027id\u0027),"},{"line_number":1590,"context_line":"            amphora_id\u003damphora.id,"},{"line_number":1591,"context_line":"            bytes_in\u003drandom.randint(0, 9),"},{"line_number":1592,"context_line":"            bytes_out\u003drandom.randint(0, 9),"},{"line_number":1593,"context_line":"            total_connections\u003drandom.randint(0, 9))"},{"line_number":1594,"context_line":""},{"line_number":1595,"context_line":"        response \u003d self._getStats(lb[\u0027id\u0027])"},{"line_number":1596,"context_line":"        self.assertEqual(ls[\u0027bytes_in\u0027], response[\u0027bytes_in\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_ab0debe8","line":1593,"range":{"start_line":1591,"start_character":12,"end_line":1593,"end_character":51},"in_reply_to":"7f231b9d_653ca22e","updated":"2017-06-16 20:33:34.000000000","message":"That is a very valid point I will make that change.","commit_id":"562c9fc0792d65afb6e4cd589453b2184282daa9"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"af1a2413284d1126dbee8268a9a096114c5a435a","unresolved":false,"context_lines":[{"line_number":1588,"context_line":"        ls \u003d self.create_listener_stats_dynamic("},{"line_number":1589,"context_line":"            listener_id\u003dli.get(\u0027id\u0027),"},{"line_number":1590,"context_line":"            amphora_id\u003damphora.id,"},{"line_number":1591,"context_line":"            bytes_in\u003drandom.randint(0, 9),"},{"line_number":1592,"context_line":"            bytes_out\u003drandom.randint(0, 9),"},{"line_number":1593,"context_line":"            total_connections\u003drandom.randint(0, 9))"},{"line_number":1594,"context_line":""},{"line_number":1595,"context_line":"        response \u003d self._getStats(lb[\u0027id\u0027])"},{"line_number":1596,"context_line":"        self.assertEqual(ls[\u0027bytes_in\u0027], response[\u0027bytes_in\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_653ca22e","line":1593,"range":{"start_line":1591,"start_character":12,"end_line":1593,"end_character":51},"in_reply_to":"7f231b9d_719d9a64","updated":"2017-06-16 19:26:25.000000000","message":"Assuming that the default is 0, probably better to randomly generate a value from 1 to 9 to get some value out of this.","commit_id":"562c9fc0792d65afb6e4cd589453b2184282daa9"}]}