)]}'
{"octavia/tests/unit/api/handlers/queue/test_producer.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"41e4f67d6219d4ae5acb3830656bbc0e3c5606ee","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        mck_target \u003d mock.patch("},{"line_number":52,"context_line":"            \u0027octavia.api.handlers.queue.producer.messaging.Target\u0027)"},{"line_number":53,"context_line":"        mck_transport \u003d mock.patch("},{"line_number":54,"context_line":"            \u0027octavia.api.handlers.queue.producer.messaging.get_rpc_transport\u0027)"},{"line_number":55,"context_line":"        self.mck_client \u003d mock.create_autospec(messaging.RPCClient)"},{"line_number":56,"context_line":"        mck_client \u003d mock.patch("},{"line_number":57,"context_line":"            \u0027octavia.api.handlers.queue.producer.messaging.RPCClient\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_2c3c19be","line":54,"updated":"2017-07-07 22:06:31.000000000","message":"Actually I have to ask, if we had this wrong in this test class, but everything was still passing... Does this do anything?","commit_id":"a1c75e80439fd81ab2034732b3b9077dccae90b6"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"3a1f2f92f0a047bcda25439be9a62df918b121d2","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        mck_target \u003d mock.patch("},{"line_number":52,"context_line":"            \u0027octavia.api.handlers.queue.producer.messaging.Target\u0027)"},{"line_number":53,"context_line":"        mck_transport \u003d mock.patch("},{"line_number":54,"context_line":"            \u0027octavia.api.handlers.queue.producer.messaging.get_rpc_transport\u0027)"},{"line_number":55,"context_line":"        self.mck_client \u003d mock.create_autospec(messaging.RPCClient)"},{"line_number":56,"context_line":"        mck_client \u003d mock.patch("},{"line_number":57,"context_line":"            \u0027octavia.api.handlers.queue.producer.messaging.RPCClient\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_62e9cab5","line":54,"in_reply_to":"3f1d235d_15095c30","updated":"2017-07-10 21:39:23.000000000","message":"Yes but before this change, we have code running \"get_rpc_transport\" while we have mocked \"get_transport\". I\u0027ve looked through the oslo.messaging code to see if maybe get_rpc_transport somehow just calls get_transport but I can\u0027t find anything like that. Therefore, I wonder how the test is passing, if we\u0027re not mocking the get_rpc_transport object, but that\u0027s what is being called. Maybe mocking RPCClient below takes care of it at a lower level, and it doesn\u0027t even matter if we mock the transport??","commit_id":"a1c75e80439fd81ab2034732b3b9077dccae90b6"},{"author":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"change_message_id":"ef8c3ae94b24a8ec3da7274beb14a02574a762cf","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        mck_target \u003d mock.patch("},{"line_number":52,"context_line":"            \u0027octavia.api.handlers.queue.producer.messaging.Target\u0027)"},{"line_number":53,"context_line":"        mck_transport \u003d mock.patch("},{"line_number":54,"context_line":"            \u0027octavia.api.handlers.queue.producer.messaging.get_rpc_transport\u0027)"},{"line_number":55,"context_line":"        self.mck_client \u003d mock.create_autospec(messaging.RPCClient)"},{"line_number":56,"context_line":"        mck_client \u003d mock.patch("},{"line_number":57,"context_line":"            \u0027octavia.api.handlers.queue.producer.messaging.RPCClient\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_15095c30","line":54,"in_reply_to":"3f1d235d_2c3c19be","updated":"2017-07-08 04:08:07.000000000","message":"Adam Harwell: Because oslo.messaging which we imported at [1] will do something like commit message, so I think this OK.\n\n[1] https://github.com/openstack/octavia/blob/master/octavia/api/handlers/queue/producer.py#L30","commit_id":"a1c75e80439fd81ab2034732b3b9077dccae90b6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e1107cc52bcce8ec0b25ff4a503c45ece407c012","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        mck_target \u003d mock.patch("},{"line_number":52,"context_line":"            \u0027octavia.api.handlers.queue.producer.messaging.Target\u0027)"},{"line_number":53,"context_line":"        mck_transport \u003d mock.patch("},{"line_number":54,"context_line":"            \u0027octavia.api.handlers.queue.producer.messaging.get_rpc_transport\u0027)"},{"line_number":55,"context_line":"        self.mck_client \u003d mock.create_autospec(messaging.RPCClient)"},{"line_number":56,"context_line":"        mck_client \u003d mock.patch("},{"line_number":57,"context_line":"            \u0027octavia.api.handlers.queue.producer.messaging.RPCClient\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_67e130d1","line":54,"in_reply_to":"3f1d235d_62e9cab5","updated":"2017-07-21 22:33:04.000000000","message":"Yeah, fair question, why wasn\u0027t this test failing?","commit_id":"a1c75e80439fd81ab2034732b3b9077dccae90b6"}]}
