)]}'
{"octavia/controller/worker/flows/amphora_flows.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"d48dbe77ddd3443e15b142b97648b5e8a36546d5","unresolved":false,"context_lines":[{"line_number":302,"context_line":"            database_tasks.MarkAmphoraPendingDeleteInDB("},{"line_number":303,"context_line":"                rebind\u003d{constants.AMPHORA: constants.FAILED_AMPHORA},"},{"line_number":304,"context_line":"                requires\u003dconstants.AMPHORA))"},{"line_number":305,"context_line":"        failover_amphora_flow.add("},{"line_number":306,"context_line":"            database_tasks.MarkAmphoraHealthBusy("},{"line_number":307,"context_line":"                rebind\u003d{constants.AMPHORA: constants.FAILED_AMPHORA},"},{"line_number":308,"context_line":"                requires\u003dconstants.AMPHORA))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_5cb595cc","line":305,"updated":"2017-06-30 18:44:16.000000000","message":"Shouldn\u0027t we mark it buys earlier","commit_id":"8baf0ca1d7a9a64c2ae80b5d8731b36b0d16a901"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"02f35e170409d2f81d45322e175c13051a97da4d","unresolved":false,"context_lines":[{"line_number":302,"context_line":"            database_tasks.MarkAmphoraPendingDeleteInDB("},{"line_number":303,"context_line":"                rebind\u003d{constants.AMPHORA: constants.FAILED_AMPHORA},"},{"line_number":304,"context_line":"                requires\u003dconstants.AMPHORA))"},{"line_number":305,"context_line":"        failover_amphora_flow.add("},{"line_number":306,"context_line":"            database_tasks.MarkAmphoraHealthBusy("},{"line_number":307,"context_line":"                rebind\u003d{constants.AMPHORA: constants.FAILED_AMPHORA},"},{"line_number":308,"context_line":"                requires\u003dconstants.AMPHORA))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f1d235d_4277eed5","line":305,"in_reply_to":"3f1d235d_5cb595cc","updated":"2017-06-30 20:22:01.000000000","message":"Maybe? But, the only things that happen before this are the TestLBStatus, which ... arguably needs to be as soon as possible, and the ErrorOnRevert, which MUST happen before we attempt a lock... so the best we could do is move it up above the MarkPendingDelete, which also needs to happen ASAP. Really there are like 4 things that all need to happen FIRST, so take your pick? I think this is about as good as we get.","commit_id":"8baf0ca1d7a9a64c2ae80b5d8731b36b0d16a901"}],"octavia/controller/worker/tasks/database_tasks.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c7e248efdd8b4e491f5a3ca44e064f8e5be9cfff","unresolved":false,"context_lines":[{"line_number":892,"context_line":""},{"line_number":893,"context_line":""},{"line_number":894,"context_line":"class TestLBStatusSetPendingInDB(BaseDatabaseTask):"},{"line_number":895,"context_line":"    \"\"\"Test the LB\u0027s status to get a lock, and set it to PENDING_UPDATE"},{"line_number":896,"context_line":""},{"line_number":897,"context_line":"    \"\"\""},{"line_number":898,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_257e43e4","line":895,"updated":"2017-06-30 16:12:14.000000000","message":"We at least need to mention that this is passive and will complete even if the lock was not obtained.","commit_id":"fc9b88c56ff0cf91ee0242a997dd0f05409a9d55"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c7e248efdd8b4e491f5a3ca44e064f8e5be9cfff","unresolved":false,"context_lines":[{"line_number":899,"context_line":"    def execute(self, loadbalancer_id):"},{"line_number":900,"context_line":"        LOG.debug(\"Attempting to get a lock for loadbalancer %s to set \""},{"line_number":901,"context_line":"                  \"PENDING_UPDATE status\", loadbalancer_id)"},{"line_number":902,"context_line":"        self.loadbalancer_repo.test_and_set_provisioning_status("},{"line_number":903,"context_line":"            db_apis.get_session(), loadbalancer_id,"},{"line_number":904,"context_line":"            status\u003dconstants.PENDING_UPDATE)"},{"line_number":905,"context_line":"        LOG.debug(\"Set loadbalancer %s to PENDING_UPDATE\", loadbalancer_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_a5693326","line":902,"updated":"2017-06-30 16:12:14.000000000","message":"We should at least log here if the lock was not obtained (i.e. a return of False)\nIn reality we should raise an exception if the lock wasn\u0027t obtained.\nUgh, mixing exception culture with result code culture....  We should probably fix that in the future.","commit_id":"fc9b88c56ff0cf91ee0242a997dd0f05409a9d55"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"90bb86287cc67ac2d23c70f815c0c3bfbb5894ad","unresolved":false,"context_lines":[{"line_number":899,"context_line":"    def execute(self, loadbalancer_id):"},{"line_number":900,"context_line":"        LOG.debug(\"Attempting to get a lock for loadbalancer %s to set \""},{"line_number":901,"context_line":"                  \"PENDING_UPDATE status\", loadbalancer_id)"},{"line_number":902,"context_line":"        self.loadbalancer_repo.test_and_set_provisioning_status("},{"line_number":903,"context_line":"            db_apis.get_session(), loadbalancer_id,"},{"line_number":904,"context_line":"            status\u003dconstants.PENDING_UPDATE)"},{"line_number":905,"context_line":"        LOG.debug(\"Set loadbalancer %s to PENDING_UPDATE\", loadbalancer_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_d65bc32b","line":902,"in_reply_to":"3f1d235d_a5693326","updated":"2017-06-30 17:45:05.000000000","message":"Urg yeah I actually thought this was an exception function, I\u0027ll probably fix it so this raises.","commit_id":"fc9b88c56ff0cf91ee0242a997dd0f05409a9d55"}]}