)]}'
{"octavia/amphorae/backends/utils/haproxy_query.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"af2c367f7a66476941dbbb7982f0db91cad3c95a","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        final_results \u003d {}"},{"line_number":114,"context_line":"        for line in results:"},{"line_number":115,"context_line":"            # pxname: pool, svname: server_name, status: status"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"            # All the way up is UP, otherwise call it DOWN"},{"line_number":118,"context_line":"            if (line[\u0027status\u0027] !\u003d consts.UP and"},{"line_number":119,"context_line":"                    line[\u0027status\u0027] !\u003d consts.NO_CHECK):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_5d1527e4","side":"PARENT","line":116,"updated":"2017-07-27 22:11:52.000000000","message":"I really don\u0027t think we should remove this.  It will pass through status from HAproxy the reset of the code won\u0027t understand like MAINT, NOLB, \"MAINT (resolution)\" etc.  Why not just add an \"and consts.DRAIN\"?","commit_id":"bc1491e07b86c844344ec664cc7b1f35e77509ed"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"af2c367f7a66476941dbbb7982f0db91cad3c95a","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        final_results \u003d {}"},{"line_number":112,"context_line":"        for line in results:"},{"line_number":113,"context_line":"            # pxname: pool, svname: server_name, status: status"},{"line_number":114,"context_line":"            if line[\u0027pxname\u0027] not in final_results:"},{"line_number":115,"context_line":"                final_results[line[\u0027pxname\u0027]] \u003d dict(members\u003d{})"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"            if line[\u0027svname\u0027] \u003d\u003d \u0027BACKEND\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff346bd7_dda0f744","line":114,"updated":"2017-07-27 22:11:52.000000000","message":"Since we have the info here to \"correct\" the status and be consistent in our behavior and documentation, could we check if line[\u0027status\u0027] \u003d\u003d consts.UP and line[\u0027weight\u0027] \u003d\u003d 0 and update status to consts.DRAIN?\nI can\u0027t think of a scenario we have where that condition wouldn\u0027t mean draining for transitioning to draining.","commit_id":"f14f5e249109fa54b293d9e9ee0931dc1ef64043"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7f53af099ffef372fc56d3169e8194b2f19d1cdb","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        final_results \u003d {}"},{"line_number":114,"context_line":"        for line in results:"},{"line_number":115,"context_line":"            # pxname: pool, svname: server_name, status: status"},{"line_number":116,"context_line":"            if line[\u0027status\u0027] \u003d\u003d consts.UP and line[\u0027weight\u0027] \u003d\u003d 0:"},{"line_number":117,"context_line":"                line[\u0027status\u0027] \u003d consts.DRAIN"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"            if line[\u0027pxname\u0027] not in final_results:"}],"source_content_type":"text/x-python","patch_set":8,"id":"df3967d1_28bcbfb9","line":116,"updated":"2017-08-01 23:48:07.000000000","message":"nit: Might be nice to have a comment of why we needed to do this, but only if there is another patch","commit_id":"04c8421428d9465b81d9b279f40e573e8a0f05dc"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d7c5cb24d377ca5ea89a76a90d36547a8df1cf77","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        final_results \u003d {}"},{"line_number":114,"context_line":"        for line in results:"},{"line_number":115,"context_line":"            # pxname: pool, svname: server_name, status: status"},{"line_number":116,"context_line":"            if line[\u0027status\u0027] \u003d\u003d consts.UP and line[\u0027weight\u0027] \u003d\u003d 0:"},{"line_number":117,"context_line":"                line[\u0027status\u0027] \u003d consts.DRAIN"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"            if line[\u0027pxname\u0027] not in final_results:"}],"source_content_type":"text/x-python","patch_set":8,"id":"df3967d1_cbb2cd94","line":116,"in_reply_to":"df3967d1_28bcbfb9","updated":"2017-08-02 00:37:51.000000000","message":"Ah no, that\u0027s actually a good point -- is there a bug in ubuntu/haproxy somewhere that I could reference?","commit_id":"04c8421428d9465b81d9b279f40e573e8a0f05dc"}],"octavia/common/constants.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0ecec060ec5688d07dd44fe5f1c7337c5cdedb00","unresolved":false,"context_lines":[{"line_number":354,"context_line":"NO_CHECK \u003d \u0027no check\u0027"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"# DRAIN \u003d member is weight 0 and is in draining mode"},{"line_number":357,"context_line":"HAPROXY_MEMBER_STATUSES \u003d (UP, DOWN, DRAIN, NO_CHECK)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"# Quota Constants"},{"line_number":360,"context_line":"QUOTA_UNLIMITED \u003d -1"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff346bd7_49ec4529","line":357,"updated":"2017-07-28 01:15:27.000000000","message":"Doesn\u0027t this need updating too?","commit_id":"cdbe515367d34af3e773ab25abb1697bb488415b"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"08e85a4f68f152bd28afe6925cd569b5ce780781","unresolved":false,"context_lines":[{"line_number":354,"context_line":"NO_CHECK \u003d \u0027no check\u0027"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"# DRAIN \u003d member is weight 0 and is in draining mode"},{"line_number":357,"context_line":"HAPROXY_MEMBER_STATUSES \u003d (UP, DOWN, DRAIN, NO_CHECK)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"# Quota Constants"},{"line_number":360,"context_line":"QUOTA_UNLIMITED \u003d -1"}],"source_content_type":"text/x-python","patch_set":4,"id":"df3967d1_3db69adb","line":357,"in_reply_to":"ff346bd7_49ec4529","updated":"2017-07-28 22:02:05.000000000","message":"Erg, yes, forgot to add MAINT. I need to check whether UNKNOWN would go here too, I don\u0027t think so.","commit_id":"cdbe515367d34af3e773ab25abb1697bb488415b"}]}