)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15736,"name":"Ritesh Anand","email":"tellrit@gmail.com","username":"ritesh"},"change_message_id":"a179facafee34f7aeae39ed3e74dff6504b29852","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds support for SUSE distros"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"suse distros need to use rpm or zypper to check for"},{"line_number":10,"context_line":"existance of packages."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ieffba6714852eabbb7b6b6da5090d10ed904998c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df3967d1_7032dcf3","line":9,"updated":"2017-07-31 20:04:21.000000000","message":"I did not see zypper being used in the script. One can use zypper for the same purpose e.g. \"zypper se -i git-core\". I am not sure which one is better to use, but I would just mention the one in use in this commit message. Also would use all caps \"SUSE\".","commit_id":"9d79d12ba166d586fd5f097faeeee442ed79a1c0"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"9bc648bd8b4924259a3a06fa1f2c7b35425fd138","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds support for SUSE distros"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"suse distros need to use rpm or zypper to check for"},{"line_number":10,"context_line":"existance of packages."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ieffba6714852eabbb7b6b6da5090d10ed904998c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df3967d1_733541da","line":9,"in_reply_to":"df3967d1_7032dcf3","updated":"2017-08-01 00:41:38.000000000","message":"Done","commit_id":"9d79d12ba166d586fd5f097faeeee442ed79a1c0"}],"diskimage-create/diskimage-create.sh":[{"author":{"_account_id":15736,"name":"Ritesh Anand","email":"tellrit@gmail.com","username":"ritesh"},"change_message_id":"a179facafee34f7aeae39ed3e74dff6504b29852","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            echo \"Earlier versions don\u0027t support the extended attributes required.\""},{"line_number":260,"context_line":"            exit 1"},{"line_number":261,"context_line":"    fi"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"elif [[ $platform \u003d~ \"SUSE\" ]]; then"},{"line_number":264,"context_line":"    # OpenSUSE"},{"line_number":265,"context_line":"    # use rpm -qa to check for qemu-tools and git-core"}],"source_content_type":"text/x-sh","patch_set":1,"id":"df3967d1_55310a0b","line":262,"updated":"2017-07-31 20:04:21.000000000","message":"This empty line is not needed.","commit_id":"9d79d12ba166d586fd5f097faeeee442ed79a1c0"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"9bc648bd8b4924259a3a06fa1f2c7b35425fd138","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            echo \"Earlier versions don\u0027t support the extended attributes required.\""},{"line_number":260,"context_line":"            exit 1"},{"line_number":261,"context_line":"    fi"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"elif [[ $platform \u003d~ \"SUSE\" ]]; then"},{"line_number":264,"context_line":"    # OpenSUSE"},{"line_number":265,"context_line":"    # use rpm -qa to check for qemu-tools and git-core"}],"source_content_type":"text/x-sh","patch_set":1,"id":"df3967d1_f827ce63","line":262,"in_reply_to":"df3967d1_55310a0b","updated":"2017-08-01 00:41:38.000000000","message":"Done","commit_id":"9d79d12ba166d586fd5f097faeeee442ed79a1c0"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"b17cd57a81ca04312eda88b0bed92437ceaa8a97","unresolved":false,"context_lines":[{"line_number":263,"context_line":"elif [[ $platform \u003d~ \"SUSE\" ]]; then"},{"line_number":264,"context_line":"    # OpenSUSE"},{"line_number":265,"context_line":"    # use rpm -qa to check for qemu-tools and git-core"},{"line_number":266,"context_line":"    PKG_LIST\u003d\"qemu-tools git-core\""},{"line_number":267,"context_line":"    for pkg in $PKG_LIST; do"},{"line_number":268,"context_line":"        if ! rpm -q $pkg \u0026\u003e /dev/null; then"},{"line_number":269,"context_line":"            echo \"Required package \" ${pkg/\\*} \" is not installed.  Exiting.\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"df3967d1_1373c782","line":266,"range":{"start_line":266,"start_character":14,"end_line":266,"end_character":24},"updated":"2017-07-28 23:09:23.000000000","message":"qemu-tools*","commit_id":"9d79d12ba166d586fd5f097faeeee442ed79a1c0"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"9bc648bd8b4924259a3a06fa1f2c7b35425fd138","unresolved":false,"context_lines":[{"line_number":263,"context_line":"elif [[ $platform \u003d~ \"SUSE\" ]]; then"},{"line_number":264,"context_line":"    # OpenSUSE"},{"line_number":265,"context_line":"    # use rpm -qa to check for qemu-tools and git-core"},{"line_number":266,"context_line":"    PKG_LIST\u003d\"qemu-tools git-core\""},{"line_number":267,"context_line":"    for pkg in $PKG_LIST; do"},{"line_number":268,"context_line":"        if ! rpm -q $pkg \u0026\u003e /dev/null; then"},{"line_number":269,"context_line":"            echo \"Required package \" ${pkg/\\*} \" is not installed.  Exiting.\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"df3967d1_b3128957","line":266,"range":{"start_line":266,"start_character":14,"end_line":266,"end_character":24},"in_reply_to":"df3967d1_1373c782","updated":"2017-08-01 00:41:38.000000000","message":"Done","commit_id":"9d79d12ba166d586fd5f097faeeee442ed79a1c0"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"07bef804c320896f0c877415915ec1996d542fdd","unresolved":false,"context_lines":[{"line_number":263,"context_line":"elif [[ $platform \u003d~ \"SUSE\" ]]; then"},{"line_number":264,"context_line":"    # OpenSUSE"},{"line_number":265,"context_line":"    # use rpm -qa to check for qemu-tools and git-core"},{"line_number":266,"context_line":"    PKG_LIST\u003d\"qemu-tools git-core\""},{"line_number":267,"context_line":"    for pkg in $PKG_LIST; do"},{"line_number":268,"context_line":"        if ! rpm -q $pkg \u0026\u003e /dev/null; then"},{"line_number":269,"context_line":"            echo \"Required package \" ${pkg/\\*} \" is not installed.  Exiting.\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"df3967d1_95e65244","line":266,"range":{"start_line":266,"start_character":14,"end_line":266,"end_character":24},"in_reply_to":"df3967d1_1373c782","updated":"2017-07-31 19:27:10.000000000","message":"I dont\u0027 believe rpm can do wild cards. At least it did not do so for me.   and if you look at the Ubuntu case above they actually do an exact match. The reason for qemu-img* below is because they can\u0027t predict where the package will be.  In our case we know its in qemu-tools.","commit_id":"9d79d12ba166d586fd5f097faeeee442ed79a1c0"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"9bc648bd8b4924259a3a06fa1f2c7b35425fd138","unresolved":false,"context_lines":[{"line_number":263,"context_line":"elif [[ $platform \u003d~ \"SUSE\" ]]; then"},{"line_number":264,"context_line":"    # OpenSUSE"},{"line_number":265,"context_line":"    # use rpm -qa to check for qemu-tools and git-core"},{"line_number":266,"context_line":"    PKG_LIST\u003d\"qemu-tools git-core\""},{"line_number":267,"context_line":"    for pkg in $PKG_LIST; do"},{"line_number":268,"context_line":"        if ! rpm -q $pkg \u0026\u003e /dev/null; then"},{"line_number":269,"context_line":"            echo \"Required package \" ${pkg/\\*} \" is not installed.  Exiting.\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"df3967d1_98f562ce","line":266,"range":{"start_line":266,"start_character":14,"end_line":266,"end_character":24},"in_reply_to":"df3967d1_35c1e655","updated":"2017-08-01 00:41:38.000000000","message":"? multiple versions of  the package name, or of the package release version? if the former, we should list them explicitly, because otherwise you could get a false positive. \nFor example if we are looking for qemu-tools and we use qemu-tools* we would get a false positive if the sytem had qemu-tools-doc installed but not qemu-tools.","commit_id":"9d79d12ba166d586fd5f097faeeee442ed79a1c0"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"9bc648bd8b4924259a3a06fa1f2c7b35425fd138","unresolved":false,"context_lines":[{"line_number":263,"context_line":"elif [[ $platform \u003d~ \"SUSE\" ]]; then"},{"line_number":264,"context_line":"    # OpenSUSE"},{"line_number":265,"context_line":"    # use rpm -qa to check for qemu-tools and git-core"},{"line_number":266,"context_line":"    PKG_LIST\u003d\"qemu-tools git-core\""},{"line_number":267,"context_line":"    for pkg in $PKG_LIST; do"},{"line_number":268,"context_line":"        if ! rpm -q $pkg \u0026\u003e /dev/null; then"},{"line_number":269,"context_line":"            echo \"Required package \" ${pkg/\\*} \" is not installed.  Exiting.\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"df3967d1_d30d0d38","line":266,"range":{"start_line":266,"start_character":14,"end_line":266,"end_character":24},"in_reply_to":"df3967d1_95e65244","updated":"2017-08-01 00:41:38.000000000","message":"Done","commit_id":"9d79d12ba166d586fd5f097faeeee442ed79a1c0"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"22d514d92ccfc8c0af33916eefe83d4713226bff","unresolved":false,"context_lines":[{"line_number":263,"context_line":"elif [[ $platform \u003d~ \"SUSE\" ]]; then"},{"line_number":264,"context_line":"    # OpenSUSE"},{"line_number":265,"context_line":"    # use rpm -qa to check for qemu-tools and git-core"},{"line_number":266,"context_line":"    PKG_LIST\u003d\"qemu-tools git-core\""},{"line_number":267,"context_line":"    for pkg in $PKG_LIST; do"},{"line_number":268,"context_line":"        if ! rpm -q $pkg \u0026\u003e /dev/null; then"},{"line_number":269,"context_line":"            echo \"Required package \" ${pkg/\\*} \" is not installed.  Exiting.\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"df3967d1_35c1e655","line":266,"range":{"start_line":266,"start_character":14,"end_line":266,"end_character":24},"in_reply_to":"df3967d1_95e65244","updated":"2017-07-31 19:38:55.000000000","message":"The only reason I went in for the wild card is, since there might be multiple versions.","commit_id":"9d79d12ba166d586fd5f097faeeee442ed79a1c0"},{"author":{"_account_id":15736,"name":"Ritesh Anand","email":"tellrit@gmail.com","username":"ritesh"},"change_message_id":"a179facafee34f7aeae39ed3e74dff6504b29852","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            exit 1"},{"line_number":271,"context_line":"        fi"},{"line_number":272,"context_line":"    done"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"else"},{"line_number":275,"context_line":"    # fedora/centos/rhel"},{"line_number":276,"context_line":"    # Actual qemu-img name may be qemu-img, qemu-img-ev, qemu-img-rhev, ..."}],"source_content_type":"text/x-sh","patch_set":1,"id":"df3967d1_153b82eb","line":273,"updated":"2017-07-31 20:04:21.000000000","message":"This empty line is not needed.","commit_id":"9d79d12ba166d586fd5f097faeeee442ed79a1c0"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"9bc648bd8b4924259a3a06fa1f2c7b35425fd138","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            exit 1"},{"line_number":271,"context_line":"        fi"},{"line_number":272,"context_line":"    done"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"else"},{"line_number":275,"context_line":"    # fedora/centos/rhel"},{"line_number":276,"context_line":"    # Actual qemu-img name may be qemu-img, qemu-img-ev, qemu-img-rhev, ..."}],"source_content_type":"text/x-sh","patch_set":1,"id":"df3967d1_f3081129","line":273,"in_reply_to":"df3967d1_153b82eb","updated":"2017-08-01 00:41:38.000000000","message":"Done","commit_id":"9d79d12ba166d586fd5f097faeeee442ed79a1c0"},{"author":{"_account_id":15736,"name":"Ritesh Anand","email":"tellrit@gmail.com","username":"ritesh"},"change_message_id":"a179facafee34f7aeae39ed3e74dff6504b29852","unresolved":false,"context_lines":[{"line_number":282,"context_line":"            exit 1"},{"line_number":283,"context_line":"        fi"},{"line_number":284,"context_line":"    done"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"fi"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"if  [ \"$AMP_WORKING_DIR\" ]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"df3967d1_d524dac8","line":285,"updated":"2017-07-31 20:04:21.000000000","message":"This empty line is not needed.","commit_id":"9d79d12ba166d586fd5f097faeeee442ed79a1c0"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"9bc648bd8b4924259a3a06fa1f2c7b35425fd138","unresolved":false,"context_lines":[{"line_number":282,"context_line":"            exit 1"},{"line_number":283,"context_line":"        fi"},{"line_number":284,"context_line":"    done"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"fi"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"if  [ \"$AMP_WORKING_DIR\" ]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"df3967d1_734ae155","line":285,"in_reply_to":"df3967d1_d524dac8","updated":"2017-08-01 00:41:38.000000000","message":"Done","commit_id":"9d79d12ba166d586fd5f097faeeee442ed79a1c0"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"b956c7e52ecd8dc2e37f058e347d9c308eeed49a","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    fi"},{"line_number":262,"context_line":"elif [[ $platform \u003d~ \"SUSE\" ]]; then"},{"line_number":263,"context_line":"    # OpenSUSE"},{"line_number":264,"context_line":"    # use rpm -qa to check for qemu-tools and git-core"},{"line_number":265,"context_line":"    PKG_LIST\u003d\"qemu-tools git-core\""},{"line_number":266,"context_line":"    for pkg in $PKG_LIST; do"},{"line_number":267,"context_line":"        if ! rpm -q $pkg \u0026\u003e /dev/null; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"df3967d1_dd72b349","line":264,"range":{"start_line":264,"start_character":10,"end_line":264,"end_character":17},"updated":"2017-08-01 07:43:35.000000000","message":"you actually used \u0027rpm -q\u0027, which is fine, just fix the comment.","commit_id":"24c023a49e73abfdd0d08bcb07b6b14ccece3272"}]}