)]}'
{"octavia/amphorae/backends/agent/api_server/server.py":[{"author":{"_account_id":23848,"name":"Ji Chengke","email":"ckji@fiberhome.com","username":"jichengke"},"change_message_id":"953579783a607b6b89ff085a914e9641a814cfaa","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    def get_logs(self):"},{"line_number":193,"context_line":"        logfile_bases \u003d ["},{"line_number":194,"context_line":"            \u0027/var/log/amphora-agent.\u0027,"},{"line_number":195,"context_line":"            \u0027/var/log/syslog\u0027,"},{"line_number":196,"context_line":"            \u0027/var/log/haproxy\u0027"},{"line_number":197,"context_line":"        ]"},{"line_number":198,"context_line":"        all_log_data \u003d \"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_27901ced","line":195,"range":{"start_line":195,"start_character":12,"end_line":195,"end_character":29},"updated":"2017-08-15 02:42:15.000000000","message":"If amphora image is based on RHEL or CentOS, there is  /var/log/messages instead of /var/log/syslog.","commit_id":"8b6aeab2e3ef6b9266b9baf269372dabdafd001e"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"a5bebb5c3f4093fbadcf845f4917bb6356d3996b","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    def get_logs(self):"},{"line_number":193,"context_line":"        logfile_bases \u003d ["},{"line_number":194,"context_line":"            \u0027/var/log/amphora-agent.\u0027,"},{"line_number":195,"context_line":"            \u0027/var/log/syslog\u0027,"},{"line_number":196,"context_line":"            \u0027/var/log/haproxy\u0027"},{"line_number":197,"context_line":"        ]"},{"line_number":198,"context_line":"        all_log_data \u003d \"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_9d74abd0","line":195,"range":{"start_line":195,"start_character":12,"end_line":195,"end_character":29},"in_reply_to":"9f436f4f_27901ced","updated":"2017-08-15 12:48:58.000000000","message":"+1\nperhaps we should incorporate this to osutils?","commit_id":"8b6aeab2e3ef6b9266b9baf269372dabdafd001e"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f2709e4e7ab1b971b2ea18cf847714674ee0259a","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    def get_logs(self):"},{"line_number":193,"context_line":"        logfile_bases \u003d ["},{"line_number":194,"context_line":"            \u0027/var/log/amphora-agent.\u0027,"},{"line_number":195,"context_line":"            \u0027/var/log/syslog\u0027,"},{"line_number":196,"context_line":"            \u0027/var/log/haproxy\u0027"},{"line_number":197,"context_line":"        ]"},{"line_number":198,"context_line":"        all_log_data \u003d \"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_ef153441","line":195,"range":{"start_line":195,"start_character":12,"end_line":195,"end_character":29},"in_reply_to":"9f436f4f_9d74abd0","updated":"2017-08-15 18:05:04.000000000","message":"Technically because of the way this works, I could also just add that too and it\u0027d be fine for both. It\u0027s *globbing on the end of this, so no matches means continue the loop without grabbing any files for that base.","commit_id":"8b6aeab2e3ef6b9266b9baf269372dabdafd001e"}],"octavia/amphorae/drivers/haproxy/rest_api_driver.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1fc5b2c3cdb77b42a520dcd1ab2cc3b8d9c30900","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                              \u0027connection data: %(content)s\u0027,"},{"line_number":289,"context_line":"                              {\u0027content_type\u0027: content_type,"},{"line_number":290,"context_line":"                               \u0027content\u0027: r.content})"},{"line_number":291,"context_line":"                    logpath \u003d self._base_url(amp.lb_network_ip) + \u0027/logs\u0027"},{"line_number":292,"context_line":"                    logreq \u003d self.session.get("},{"line_number":293,"context_line":"                        verify\u003dCONF.haproxy_amphora.server_ca,"},{"line_number":294,"context_line":"                        url\u003dlogpath,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_c1952ee6","line":291,"range":{"start_line":291,"start_character":67,"end_line":291,"end_character":68},"updated":"2017-08-10 04:24:06.000000000","message":"Looks like this is not necessary","commit_id":"4a0b351b714ca369c02d32057faaa218d10acf53"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d3446e3f46f8dc9379de6a250746b622d81eef1d","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                              \u0027connection data: %(content)s\u0027,"},{"line_number":289,"context_line":"                              {\u0027content_type\u0027: content_type,"},{"line_number":290,"context_line":"                               \u0027content\u0027: r.content})"},{"line_number":291,"context_line":"                    logpath \u003d self._base_url(amp.lb_network_ip) + \u0027/logs\u0027"},{"line_number":292,"context_line":"                    logreq \u003d self.session.get("},{"line_number":293,"context_line":"                        verify\u003dCONF.haproxy_amphora.server_ca,"},{"line_number":294,"context_line":"                        url\u003dlogpath,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_789e1eb9","line":291,"range":{"start_line":291,"start_character":67,"end_line":291,"end_character":68},"in_reply_to":"9f436f4f_c1952ee6","updated":"2017-08-10 16:18:16.000000000","message":"Yeah but following the default above (which is \u0027/\u0027) and it doesn\u0027t seem to hurt it?","commit_id":"4a0b351b714ca369c02d32057faaa218d10acf53"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1fc5b2c3cdb77b42a520dcd1ab2cc3b8d9c30900","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                        url\u003dlogpath,"},{"line_number":295,"context_line":"                        headers\u003d{\u0027User-Agent\u0027: OCTAVIA_API_CLIENT},"},{"line_number":296,"context_line":"                        stream\u003dTrue)"},{"line_number":297,"context_line":"                    with open(\u0027/var/log/amphora-logs.gz\u0027, \u0027wb\u0027) as logfile:"},{"line_number":298,"context_line":"                        for data in logreq.iter_content(1024):"},{"line_number":299,"context_line":"                            logfile.write(data)"},{"line_number":300,"context_line":"                        LOG.debug(\"Amp logs are in: /var/log/amphora-logs.gz\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_c1f08e6a","line":297,"range":{"start_line":297,"start_character":31,"end_line":297,"end_character":40},"updated":"2017-08-10 04:24:06.000000000","message":"/opt/stack/logs/ gets picked up by the gates.\nMaybe do a mkdir -p to make sure it is there and drop them there.","commit_id":"4a0b351b714ca369c02d32057faaa218d10acf53"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1fc5b2c3cdb77b42a520dcd1ab2cc3b8d9c30900","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                        url\u003dlogpath,"},{"line_number":295,"context_line":"                        headers\u003d{\u0027User-Agent\u0027: OCTAVIA_API_CLIENT},"},{"line_number":296,"context_line":"                        stream\u003dTrue)"},{"line_number":297,"context_line":"                    with open(\u0027/var/log/amphora-logs.gz\u0027, \u0027wb\u0027) as logfile:"},{"line_number":298,"context_line":"                        for data in logreq.iter_content(1024):"},{"line_number":299,"context_line":"                            logfile.write(data)"},{"line_number":300,"context_line":"                        LOG.debug(\"Amp logs are in: /var/log/amphora-logs.gz\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_bc148da1","line":297,"range":{"start_line":297,"start_character":40,"end_line":297,"end_character":52},"updated":"2017-08-10 04:24:06.000000000","message":"Probably should make this unique in case the gate has more than one amp.  Amp uuid?","commit_id":"4a0b351b714ca369c02d32057faaa218d10acf53"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1fc5b2c3cdb77b42a520dcd1ab2cc3b8d9c30900","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                        url\u003dlogpath,"},{"line_number":295,"context_line":"                        headers\u003d{\u0027User-Agent\u0027: OCTAVIA_API_CLIENT},"},{"line_number":296,"context_line":"                        stream\u003dTrue)"},{"line_number":297,"context_line":"                    with open(\u0027/var/log/amphora-logs.gz\u0027, \u0027wb\u0027) as logfile:"},{"line_number":298,"context_line":"                        for data in logreq.iter_content(1024):"},{"line_number":299,"context_line":"                            logfile.write(data)"},{"line_number":300,"context_line":"                        LOG.debug(\"Amp logs are in: /var/log/amphora-logs.gz\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_5c492189","line":297,"range":{"start_line":297,"start_character":53,"end_line":297,"end_character":56},"updated":"2017-08-10 04:24:06.000000000","message":"This is not being stored in gz format.  The transport is gzipping, but that is removed on the receiving end by requests.","commit_id":"4a0b351b714ca369c02d32057faaa218d10acf53"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d3446e3f46f8dc9379de6a250746b622d81eef1d","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                        url\u003dlogpath,"},{"line_number":295,"context_line":"                        headers\u003d{\u0027User-Agent\u0027: OCTAVIA_API_CLIENT},"},{"line_number":296,"context_line":"                        stream\u003dTrue)"},{"line_number":297,"context_line":"                    with open(\u0027/var/log/amphora-logs.gz\u0027, \u0027wb\u0027) as logfile:"},{"line_number":298,"context_line":"                        for data in logreq.iter_content(1024):"},{"line_number":299,"context_line":"                            logfile.write(data)"},{"line_number":300,"context_line":"                        LOG.debug(\"Amp logs are in: /var/log/amphora-logs.gz\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_186a72b2","line":297,"range":{"start_line":297,"start_character":53,"end_line":297,"end_character":56},"in_reply_to":"9f436f4f_5c492189","updated":"2017-08-10 16:18:16.000000000","message":"Now it\u0027s gzip\u0027d :)","commit_id":"4a0b351b714ca369c02d32057faaa218d10acf53"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d3446e3f46f8dc9379de6a250746b622d81eef1d","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                        url\u003dlogpath,"},{"line_number":295,"context_line":"                        headers\u003d{\u0027User-Agent\u0027: OCTAVIA_API_CLIENT},"},{"line_number":296,"context_line":"                        stream\u003dTrue)"},{"line_number":297,"context_line":"                    with open(\u0027/var/log/amphora-logs.gz\u0027, \u0027wb\u0027) as logfile:"},{"line_number":298,"context_line":"                        for data in logreq.iter_content(1024):"},{"line_number":299,"context_line":"                            logfile.write(data)"},{"line_number":300,"context_line":"                        LOG.debug(\"Amp logs are in: /var/log/amphora-logs.gz\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_3873f6b3","line":297,"range":{"start_line":297,"start_character":40,"end_line":297,"end_character":52},"in_reply_to":"9f436f4f_bc148da1","updated":"2017-08-10 16:18:16.000000000","message":"Sure","commit_id":"4a0b351b714ca369c02d32057faaa218d10acf53"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"d3446e3f46f8dc9379de6a250746b622d81eef1d","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                        url\u003dlogpath,"},{"line_number":295,"context_line":"                        headers\u003d{\u0027User-Agent\u0027: OCTAVIA_API_CLIENT},"},{"line_number":296,"context_line":"                        stream\u003dTrue)"},{"line_number":297,"context_line":"                    with open(\u0027/var/log/amphora-logs.gz\u0027, \u0027wb\u0027) as logfile:"},{"line_number":298,"context_line":"                        for data in logreq.iter_content(1024):"},{"line_number":299,"context_line":"                            logfile.write(data)"},{"line_number":300,"context_line":"                        LOG.debug(\"Amp logs are in: /var/log/amphora-logs.gz\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_5870faa5","line":297,"range":{"start_line":297,"start_character":31,"end_line":297,"end_character":40},"in_reply_to":"9f436f4f_c1f08e6a","updated":"2017-08-10 16:18:16.000000000","message":"Going to choose /opt/stack/logs or /var/log","commit_id":"4a0b351b714ca369c02d32057faaa218d10acf53"}]}
