)]}'
{"devstack/contrib/new-octavia-devstack.sh":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"edf62eea3e070d2523e3a1888a620e2ca47b1004","unresolved":false,"context_lines":[{"line_number":15,"context_line":"git clone https://github.com/openstack-dev/devstack.git $HOME/devstack"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"cat \u003c\u003cEOF \u003e $HOME/devstack/localrc"},{"line_number":18,"context_line":"enable_plugin octavia-dashboard https://git.openstack.org/openstack/octavia-dashboard"},{"line_number":19,"context_line":"enable_plugin barbican https://review.openstack.org/openstack/barbican"},{"line_number":20,"context_line":"enable_plugin octavia https://review.openstack.org/openstack/octavia"},{"line_number":21,"context_line":"LIBS_FROM_GIT+\u003dpython-octaviaclient"}],"source_content_type":"text/x-sh","patch_set":15,"id":"ff82abbf_860d1192","line":18,"updated":"2017-11-21 01:30:50.000000000","message":"Why are we adding this?  Horizon is not enabled in this localrc.","commit_id":"70d670fbce88e287c1dc4a8916e298399d7c2ac8"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"67c65a9d48136657b739fab714fc41cefff5d8ad","unresolved":false,"context_lines":[{"line_number":15,"context_line":"git clone https://github.com/openstack-dev/devstack.git $HOME/devstack"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"cat \u003c\u003cEOF \u003e $HOME/devstack/localrc"},{"line_number":18,"context_line":"enable_plugin octavia-dashboard https://git.openstack.org/openstack/octavia-dashboard"},{"line_number":19,"context_line":"enable_plugin barbican https://review.openstack.org/openstack/barbican"},{"line_number":20,"context_line":"enable_plugin octavia https://review.openstack.org/openstack/octavia"},{"line_number":21,"context_line":"LIBS_FROM_GIT+\u003dpython-octaviaclient"}],"source_content_type":"text/x-sh","patch_set":15,"id":"ff82abbf_ab878e0f","line":18,"in_reply_to":"ff82abbf_860d1192","updated":"2017-11-22 12:57:26.000000000","message":"For some reason, devstack deploys horizon anyways.\nBut that\u0027s a valid point, I\u0027ll remove it.","commit_id":"70d670fbce88e287c1dc4a8916e298399d7c2ac8"}],"devstack/plugin.sh":[{"author":{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},"change_message_id":"9de7f10451bf6eddeb02cc95c754816b35611c0a","unresolved":false,"context_lines":[{"line_number":313,"context_line":"    fi"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    # TODO(johnsom) Change this to OSC when security group is working"},{"line_number":316,"context_line":"    id_and_mac\u003d$(openstack port create octavia-health-manager-$OCTAVIA_NODE-listen-port --security-group lb-health-mgr-sec-grp --device-owner Octavia:health-mgr --host\u003d$(hostname) --network lb-mgmt-net $PORT_FIXED_IP | awk \u0027/ id | mac_address / {print $4}\u0027)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    id_and_mac\u003d($id_and_mac)"},{"line_number":319,"context_line":"    MGMT_PORT_ID\u003d${id_and_mac[0]}"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5f2577a7_84a7c60b","line":316,"updated":"2017-09-17 18:22:05.000000000","message":"Seems code from Michael\u0027s patch is better:\n\n    MGMT_PORT_ID\u003d$(openstack port create --security-group lb-health-mgr-sec-grp --device-owner Octavia:health-mgr --binding-profile host_id\u003d$(hostname) -c id -f value --network lb-mgmt-net $PORT_FIXED_IP octavia-health-manager-$OCTAVIA_NODE-listen-port)\n    MGMT_PORT_MAC\u003d$(openstack port show -c mac_address -f value $MGMT_PORT_ID)","commit_id":"78c88c10f37fe80e3e83d90c4725c8bfbe6cdfb6"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"f9ce19b7e44fd979d6f219f3c5922d831efe61ef","unresolved":false,"context_lines":[{"line_number":313,"context_line":"    fi"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    # TODO(johnsom) Change this to OSC when security group is working"},{"line_number":316,"context_line":"    id_and_mac\u003d$(openstack port create octavia-health-manager-$OCTAVIA_NODE-listen-port --security-group lb-health-mgr-sec-grp --device-owner Octavia:health-mgr --host\u003d$(hostname) --network lb-mgmt-net $PORT_FIXED_IP | awk \u0027/ id | mac_address / {print $4}\u0027)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    id_and_mac\u003d($id_and_mac)"},{"line_number":319,"context_line":"    MGMT_PORT_ID\u003d${id_and_mac[0]}"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5f2577a7_cc0610cf","line":316,"in_reply_to":"5f2577a7_71025971","updated":"2017-09-18 06:30:09.000000000","message":"Hi again Tong, thank you for taking the time to review this patch.\n\nSo, I\u0027m not sure I agree here.\nShorter is not always better, for example with this version you have one less API call.\n\nI find both versions quite easy to comprehend, but let\u0027s see what Michael has to say.","commit_id":"78c88c10f37fe80e3e83d90c4725c8bfbe6cdfb6"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"8f9e68554607f8030c1ef3e1169d634b3695f281","unresolved":false,"context_lines":[{"line_number":313,"context_line":"    fi"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    # TODO(johnsom) Change this to OSC when security group is working"},{"line_number":316,"context_line":"    id_and_mac\u003d$(openstack port create octavia-health-manager-$OCTAVIA_NODE-listen-port --security-group lb-health-mgr-sec-grp --device-owner Octavia:health-mgr --host\u003d$(hostname) --network lb-mgmt-net $PORT_FIXED_IP | awk \u0027/ id | mac_address / {print $4}\u0027)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    id_and_mac\u003d($id_and_mac)"},{"line_number":319,"context_line":"    MGMT_PORT_ID\u003d${id_and_mac[0]}"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5f2577a7_e4b9eacb","line":316,"in_reply_to":"5f2577a7_84a7c60b","updated":"2017-09-17 20:18:43.000000000","message":"Hi Tong,\nWhat makes it better in your opinion?","commit_id":"78c88c10f37fe80e3e83d90c4725c8bfbe6cdfb6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"878834ebcc4e8a8bea3f35d53ca5225be7e29a55","unresolved":false,"context_lines":[{"line_number":313,"context_line":"    fi"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    # TODO(johnsom) Change this to OSC when security group is working"},{"line_number":316,"context_line":"    id_and_mac\u003d$(openstack port create octavia-health-manager-$OCTAVIA_NODE-listen-port --security-group lb-health-mgr-sec-grp --device-owner Octavia:health-mgr --host\u003d$(hostname) --network lb-mgmt-net $PORT_FIXED_IP | awk \u0027/ id | mac_address / {print $4}\u0027)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    id_and_mac\u003d($id_and_mac)"},{"line_number":319,"context_line":"    MGMT_PORT_ID\u003d${id_and_mac[0]}"}],"source_content_type":"text/x-sh","patch_set":5,"id":"7f515b1d_d4ed0526","line":316,"in_reply_to":"5f2577a7_cc0610cf","updated":"2017-09-23 00:46:09.000000000","message":"I agree with Tong, using the builtin openstack column/field parsing is better than relying on awk scripts that might break with minor changes to the formatting/syntax.\nJust don\u0027t copy my binding profile settings that didn\u0027t work. grin","commit_id":"78c88c10f37fe80e3e83d90c4725c8bfbe6cdfb6"},{"author":{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},"change_message_id":"a0649971963fe81889ad3507fe896b0c24752372","unresolved":false,"context_lines":[{"line_number":313,"context_line":"    fi"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    # TODO(johnsom) Change this to OSC when security group is working"},{"line_number":316,"context_line":"    id_and_mac\u003d$(openstack port create octavia-health-manager-$OCTAVIA_NODE-listen-port --security-group lb-health-mgr-sec-grp --device-owner Octavia:health-mgr --host\u003d$(hostname) --network lb-mgmt-net $PORT_FIXED_IP | awk \u0027/ id | mac_address / {print $4}\u0027)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    id_and_mac\u003d($id_and_mac)"},{"line_number":319,"context_line":"    MGMT_PORT_ID\u003d${id_and_mac[0]}"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5f2577a7_71025971","line":316,"in_reply_to":"5f2577a7_e4b9eacb","updated":"2017-09-18 05:25:19.000000000","message":"It saves a few line of code and more readable in my opinion.","commit_id":"78c88c10f37fe80e3e83d90c4725c8bfbe6cdfb6"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"a19f4ec1eb62c11457f4411c0fd48f01912a659f","unresolved":false,"context_lines":[{"line_number":313,"context_line":"    fi"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    # TODO(johnsom) Change this to OSC when security group is working"},{"line_number":316,"context_line":"    id_and_mac\u003d$(openstack port create octavia-health-manager-$OCTAVIA_NODE-listen-port --security-group lb-health-mgr-sec-grp --device-owner Octavia:health-mgr --host\u003d$(hostname) --network lb-mgmt-net $PORT_FIXED_IP | awk \u0027/ id | mac_address / {print $4}\u0027)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    id_and_mac\u003d($id_and_mac)"},{"line_number":319,"context_line":"    MGMT_PORT_ID\u003d${id_and_mac[0]}"}],"source_content_type":"text/x-sh","patch_set":5,"id":"7f515b1d_9891f055","line":316,"in_reply_to":"7f515b1d_d4ed0526","updated":"2017-09-25 09:15:52.000000000","message":"Done","commit_id":"78c88c10f37fe80e3e83d90c4725c8bfbe6cdfb6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"edf62eea3e070d2523e3a1888a620e2ca47b1004","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        PORT_FIXED_IP\u003d\"--fixed-ip subnet\u003d$SUBNET_ID,ip-address\u003d$OCTAVIA_MGMT_PORT_IP\""},{"line_number":320,"context_line":"    fi"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    # TODO(johnsom) Change this to OSC when security group is working"},{"line_number":323,"context_line":"    MGMT_PORT_ID\u003d$(openstack port create --security-group lb-health-mgr-sec-grp --device-owner Octavia:health-mgr --host\u003d$(hostname) -c id -f value --network lb-mgmt-net $PORT_FIXED_IP octavia-health-manager-$OCTAVIA_NODE-listen-port)"},{"line_number":324,"context_line":"    MGMT_PORT_MAC\u003d$(openstack port show -c mac_address -f value $MGMT_PORT_ID)"},{"line_number":325,"context_line":""}],"source_content_type":"text/x-sh","patch_set":15,"id":"ff82abbf_064fc1bd","line":322,"range":{"start_line":322,"start_character":4,"end_line":322,"end_character":69},"updated":"2017-11-21 01:30:50.000000000","message":"This comment can go away as you switched this to OSC","commit_id":"70d670fbce88e287c1dc4a8916e298399d7c2ac8"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"67c65a9d48136657b739fab714fc41cefff5d8ad","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        PORT_FIXED_IP\u003d\"--fixed-ip subnet\u003d$SUBNET_ID,ip-address\u003d$OCTAVIA_MGMT_PORT_IP\""},{"line_number":320,"context_line":"    fi"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    # TODO(johnsom) Change this to OSC when security group is working"},{"line_number":323,"context_line":"    MGMT_PORT_ID\u003d$(openstack port create --security-group lb-health-mgr-sec-grp --device-owner Octavia:health-mgr --host\u003d$(hostname) -c id -f value --network lb-mgmt-net $PORT_FIXED_IP octavia-health-manager-$OCTAVIA_NODE-listen-port)"},{"line_number":324,"context_line":"    MGMT_PORT_MAC\u003d$(openstack port show -c mac_address -f value $MGMT_PORT_ID)"},{"line_number":325,"context_line":""}],"source_content_type":"text/x-sh","patch_set":15,"id":"ff82abbf_2b737e4f","line":322,"range":{"start_line":322,"start_character":4,"end_line":322,"end_character":69},"in_reply_to":"ff82abbf_064fc1bd","updated":"2017-11-22 12:57:26.000000000","message":"Correct. Done.","commit_id":"70d670fbce88e287c1dc4a8916e298399d7c2ac8"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"987abc215ac9b415347ae78861f992453b121c0e","unresolved":false,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"function create_mgmt_network_interface {"},{"line_number":317,"context_line":"    if [ $OCTAVIA_MGMT_PORT_IP !\u003d \u0027auto\u0027 ]; then"},{"line_number":318,"context_line":"        SUBNET_ID\u003d$(openstack subnet show lb-mgmt-subnet | awk \u0027/ id / {print $4}\u0027)"},{"line_number":319,"context_line":"        PORT_FIXED_IP\u003d\"--fixed-ip subnet\u003d$SUBNET_ID,ip-address\u003d$OCTAVIA_MGMT_PORT_IP\""},{"line_number":320,"context_line":"    fi"},{"line_number":321,"context_line":""}],"source_content_type":"text/x-sh","patch_set":16,"id":"ff82abbf_6eb8b1c7","line":318,"range":{"start_line":318,"start_character":57,"end_line":318,"end_character":82},"updated":"2017-11-22 14:44:22.000000000","message":"Can be obtained directly from OSC with \"-f value -c id\"","commit_id":"e54c22f87421810c238849390f05b3e1a92e49da"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"132b2dd39889a1ff315b18a49ae6fefec2d92459","unresolved":false,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"function create_mgmt_network_interface {"},{"line_number":317,"context_line":"    if [ $OCTAVIA_MGMT_PORT_IP !\u003d \u0027auto\u0027 ]; then"},{"line_number":318,"context_line":"        SUBNET_ID\u003d$(openstack subnet show lb-mgmt-subnet | awk \u0027/ id / {print $4}\u0027)"},{"line_number":319,"context_line":"        PORT_FIXED_IP\u003d\"--fixed-ip subnet\u003d$SUBNET_ID,ip-address\u003d$OCTAVIA_MGMT_PORT_IP\""},{"line_number":320,"context_line":"    fi"},{"line_number":321,"context_line":""}],"source_content_type":"text/x-sh","patch_set":16,"id":"ff82abbf_e73fbfb1","line":318,"range":{"start_line":318,"start_character":57,"end_line":318,"end_character":82},"in_reply_to":"ff82abbf_6eb8b1c7","updated":"2017-11-26 11:23:15.000000000","message":"Done","commit_id":"e54c22f87421810c238849390f05b3e1a92e49da"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"b9360ca63106315b829fecea973e81e4b29aea95","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    else"},{"line_number":62,"context_line":"        export DIB_REPOREF_amphora_agent\u003d$(git -c \"$OCTAVIA_DIR\" log -1 --pretty\u003d\"format:%H\")"},{"line_number":63,"context_line":"    fi"},{"line_number":64,"context_line":"    TOKEN\u003d$(openstack token issue | grep \u0027 id \u0027 | get_field 2)"},{"line_number":65,"context_line":"    die_if_not_set $LINENO TOKEN \"Keystone failed to get token.\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    octavia_dib_tracing_arg\u003d"}],"source_content_type":"text/x-sh","patch_set":18,"id":"ff82abbf_ca4082a8","line":64,"updated":"2017-11-26 19:11:39.000000000","message":"openstack token issue -f value -c id","commit_id":"8f2dd93e3095ac14794384ccc25de26ca625a7dd"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"7365e53bbec8d19166a31e3de879ffc0f465b2d6","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    else"},{"line_number":62,"context_line":"        export DIB_REPOREF_amphora_agent\u003d$(git -c \"$OCTAVIA_DIR\" log -1 --pretty\u003d\"format:%H\")"},{"line_number":63,"context_line":"    fi"},{"line_number":64,"context_line":"    TOKEN\u003d$(openstack token issue | grep \u0027 id \u0027 | get_field 2)"},{"line_number":65,"context_line":"    die_if_not_set $LINENO TOKEN \"Keystone failed to get token.\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    octavia_dib_tracing_arg\u003d"}],"source_content_type":"text/x-sh","patch_set":18,"id":"ff82abbf_1df6b6fa","line":64,"in_reply_to":"ff82abbf_ca4082a8","updated":"2017-11-26 22:37:56.000000000","message":"Done","commit_id":"8f2dd93e3095ac14794384ccc25de26ca625a7dd"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"b9360ca63106315b829fecea973e81e4b29aea95","unresolved":false,"context_lines":[{"line_number":356,"context_line":""},{"line_number":357,"context_line":"function build_mgmt_network {"},{"line_number":358,"context_line":"    # Create network and attach a subnet"},{"line_number":359,"context_line":"    OCTAVIA_AMP_NETWORK_ID\u003d$(openstack network create lb-mgmt-net | awk \u0027/ id / {print $4}\u0027)"},{"line_number":360,"context_line":"    OCTAVIA_AMP_SUBNET_ID\u003d$(openstack subnet create --subnet-range $OCTAVIA_MGMT_SUBNET --allocation-pool start\u003d$OCTAVIA_MGMT_SUBNET_START,end\u003d$OCTAVIA_MGMT_SUBNET_END --network lb-mgmt-net lb-mgmt-subnet | awk \u0027/ id / {print $4}\u0027)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    # Create security group and rules"}],"source_content_type":"text/x-sh","patch_set":18,"id":"ff82abbf_8a46fabf","line":359,"updated":"2017-11-26 19:11:39.000000000","message":"openstack network create lb-mgmt-net -c id -f value","commit_id":"8f2dd93e3095ac14794384ccc25de26ca625a7dd"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"7365e53bbec8d19166a31e3de879ffc0f465b2d6","unresolved":false,"context_lines":[{"line_number":356,"context_line":""},{"line_number":357,"context_line":"function build_mgmt_network {"},{"line_number":358,"context_line":"    # Create network and attach a subnet"},{"line_number":359,"context_line":"    OCTAVIA_AMP_NETWORK_ID\u003d$(openstack network create lb-mgmt-net | awk \u0027/ id / {print $4}\u0027)"},{"line_number":360,"context_line":"    OCTAVIA_AMP_SUBNET_ID\u003d$(openstack subnet create --subnet-range $OCTAVIA_MGMT_SUBNET --allocation-pool start\u003d$OCTAVIA_MGMT_SUBNET_START,end\u003d$OCTAVIA_MGMT_SUBNET_END --network lb-mgmt-net lb-mgmt-subnet | awk \u0027/ id / {print $4}\u0027)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    # Create security group and rules"}],"source_content_type":"text/x-sh","patch_set":18,"id":"ff82abbf_7de4a23c","line":359,"in_reply_to":"ff82abbf_8a46fabf","updated":"2017-11-26 22:37:56.000000000","message":"Done","commit_id":"8f2dd93e3095ac14794384ccc25de26ca625a7dd"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"b9360ca63106315b829fecea973e81e4b29aea95","unresolved":false,"context_lines":[{"line_number":357,"context_line":"function build_mgmt_network {"},{"line_number":358,"context_line":"    # Create network and attach a subnet"},{"line_number":359,"context_line":"    OCTAVIA_AMP_NETWORK_ID\u003d$(openstack network create lb-mgmt-net | awk \u0027/ id / {print $4}\u0027)"},{"line_number":360,"context_line":"    OCTAVIA_AMP_SUBNET_ID\u003d$(openstack subnet create --subnet-range $OCTAVIA_MGMT_SUBNET --allocation-pool start\u003d$OCTAVIA_MGMT_SUBNET_START,end\u003d$OCTAVIA_MGMT_SUBNET_END --network lb-mgmt-net lb-mgmt-subnet | awk \u0027/ id / {print $4}\u0027)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    # Create security group and rules"},{"line_number":363,"context_line":"    openstack security group create lb-mgmt-sec-grp"}],"source_content_type":"text/x-sh","patch_set":18,"id":"ff82abbf_2a11eeac","line":360,"updated":"2017-11-26 19:11:39.000000000","message":"ditto, -f value -c id","commit_id":"8f2dd93e3095ac14794384ccc25de26ca625a7dd"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"7365e53bbec8d19166a31e3de879ffc0f465b2d6","unresolved":false,"context_lines":[{"line_number":357,"context_line":"function build_mgmt_network {"},{"line_number":358,"context_line":"    # Create network and attach a subnet"},{"line_number":359,"context_line":"    OCTAVIA_AMP_NETWORK_ID\u003d$(openstack network create lb-mgmt-net | awk \u0027/ id / {print $4}\u0027)"},{"line_number":360,"context_line":"    OCTAVIA_AMP_SUBNET_ID\u003d$(openstack subnet create --subnet-range $OCTAVIA_MGMT_SUBNET --allocation-pool start\u003d$OCTAVIA_MGMT_SUBNET_START,end\u003d$OCTAVIA_MGMT_SUBNET_END --network lb-mgmt-net lb-mgmt-subnet | awk \u0027/ id / {print $4}\u0027)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    # Create security group and rules"},{"line_number":363,"context_line":"    openstack security group create lb-mgmt-sec-grp"}],"source_content_type":"text/x-sh","patch_set":18,"id":"ff82abbf_dddb6e79","line":360,"in_reply_to":"ff82abbf_2a11eeac","updated":"2017-11-26 22:37:56.000000000","message":"Done","commit_id":"8f2dd93e3095ac14794384ccc25de26ca625a7dd"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"b9360ca63106315b829fecea973e81e4b29aea95","unresolved":false,"context_lines":[{"line_number":375,"context_line":"}"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"function configure_lb_mgmt_sec_grp {"},{"line_number":378,"context_line":"    OCTAVIA_MGMT_SEC_GRP_ID\u003d$(openstack security group list | awk \u0027 / lb-mgmt-sec-grp / {print $2}\u0027)"},{"line_number":379,"context_line":"    iniset ${OCTAVIA_CONF} controller_worker amp_secgroup_list ${OCTAVIA_MGMT_SEC_GRP_ID}"},{"line_number":380,"context_line":"}"},{"line_number":381,"context_line":""}],"source_content_type":"text/x-sh","patch_set":18,"id":"ff82abbf_ca2962e6","line":378,"updated":"2017-11-26 19:11:39.000000000","message":"openstack security group show lb-mgmt-sec-grp -f value -c id","commit_id":"8f2dd93e3095ac14794384ccc25de26ca625a7dd"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"7365e53bbec8d19166a31e3de879ffc0f465b2d6","unresolved":false,"context_lines":[{"line_number":375,"context_line":"}"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"function configure_lb_mgmt_sec_grp {"},{"line_number":378,"context_line":"    OCTAVIA_MGMT_SEC_GRP_ID\u003d$(openstack security group list | awk \u0027 / lb-mgmt-sec-grp / {print $2}\u0027)"},{"line_number":379,"context_line":"    iniset ${OCTAVIA_CONF} controller_worker amp_secgroup_list ${OCTAVIA_MGMT_SEC_GRP_ID}"},{"line_number":380,"context_line":"}"},{"line_number":381,"context_line":""}],"source_content_type":"text/x-sh","patch_set":18,"id":"ff82abbf_9de1662d","line":378,"in_reply_to":"ff82abbf_ca2962e6","updated":"2017-11-26 22:37:56.000000000","message":"Done","commit_id":"8f2dd93e3095ac14794384ccc25de26ca625a7dd"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"b9360ca63106315b829fecea973e81e4b29aea95","unresolved":false,"context_lines":[{"line_number":392,"context_line":"function create_amphora_flavor {"},{"line_number":393,"context_line":"    # Pass even if it exists to avoid race condition on multinode"},{"line_number":394,"context_line":"    openstack flavor create --id auto --ram 1024 --disk 2 --vcpus 1 --private m1.amphora -f value -c id || true"},{"line_number":395,"context_line":"    amp_flavor_id\u003d$(openstack flavor list --all -c ID -c Name | awk \u0027 / m1.amphora / {print $2}\u0027)"},{"line_number":396,"context_line":"    iniset $OCTAVIA_CONF controller_worker amp_flavor_id $amp_flavor_id"},{"line_number":397,"context_line":"}"},{"line_number":398,"context_line":""}],"source_content_type":"text/x-sh","patch_set":18,"id":"ff82abbf_ea26a615","line":395,"updated":"2017-11-26 19:11:39.000000000","message":"openstack flavor show m1.amphora -f value -c id","commit_id":"8f2dd93e3095ac14794384ccc25de26ca625a7dd"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"7365e53bbec8d19166a31e3de879ffc0f465b2d6","unresolved":false,"context_lines":[{"line_number":392,"context_line":"function create_amphora_flavor {"},{"line_number":393,"context_line":"    # Pass even if it exists to avoid race condition on multinode"},{"line_number":394,"context_line":"    openstack flavor create --id auto --ram 1024 --disk 2 --vcpus 1 --private m1.amphora -f value -c id || true"},{"line_number":395,"context_line":"    amp_flavor_id\u003d$(openstack flavor list --all -c ID -c Name | awk \u0027 / m1.amphora / {print $2}\u0027)"},{"line_number":396,"context_line":"    iniset $OCTAVIA_CONF controller_worker amp_flavor_id $amp_flavor_id"},{"line_number":397,"context_line":"}"},{"line_number":398,"context_line":""}],"source_content_type":"text/x-sh","patch_set":18,"id":"ff82abbf_3dd4da47","line":395,"in_reply_to":"ff82abbf_ea26a615","updated":"2017-11-26 22:37:56.000000000","message":"Done","commit_id":"8f2dd93e3095ac14794384ccc25de26ca625a7dd"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"b9360ca63106315b829fecea973e81e4b29aea95","unresolved":false,"context_lines":[{"line_number":475,"context_line":""},{"line_number":476,"context_line":"    iniset $OCTAVIA_CONF controller_worker amp_image_tag ${OCTAVIA_AMP_IMAGE_TAG}"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    OCTAVIA_AMP_NETWORK_ID\u003d$(openstack network list | awk \u0027/ lb-mgmt-net / {print $2}\u0027)"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"    iniset $OCTAVIA_CONF controller_worker amp_boot_network_list ${OCTAVIA_AMP_NETWORK_ID}"},{"line_number":481,"context_line":""}],"source_content_type":"text/x-sh","patch_set":18,"id":"ff82abbf_aa43beae","line":478,"updated":"2017-11-26 19:11:39.000000000","message":"openstack network list --name lb-mgmt-net -f value -c ID","commit_id":"8f2dd93e3095ac14794384ccc25de26ca625a7dd"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"7365e53bbec8d19166a31e3de879ffc0f465b2d6","unresolved":false,"context_lines":[{"line_number":475,"context_line":""},{"line_number":476,"context_line":"    iniset $OCTAVIA_CONF controller_worker amp_image_tag ${OCTAVIA_AMP_IMAGE_TAG}"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    OCTAVIA_AMP_NETWORK_ID\u003d$(openstack network list | awk \u0027/ lb-mgmt-net / {print $2}\u0027)"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"    iniset $OCTAVIA_CONF controller_worker amp_boot_network_list ${OCTAVIA_AMP_NETWORK_ID}"},{"line_number":481,"context_line":""}],"source_content_type":"text/x-sh","patch_set":18,"id":"ff82abbf_bdc78a96","line":478,"in_reply_to":"ff82abbf_aa43beae","updated":"2017-11-26 22:37:56.000000000","message":"I went with: openstack network show lb-mgmt-net -f value -c id\n\nwhich is kind of the same :)","commit_id":"8f2dd93e3095ac14794384ccc25de26ca625a7dd"}],"devstack/samples/multinode/local.conf":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"edf62eea3e070d2523e3a1888a620e2ca47b1004","unresolved":false,"context_lines":[{"line_number":52,"context_line":"enable_service q-l3"},{"line_number":53,"context_line":"enable_service q-meta"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# Cinder"},{"line_number":56,"context_line":"enable_service c-api"},{"line_number":57,"context_line":"enable_service c-vol"},{"line_number":58,"context_line":"enable_service c-sch"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# LBaaS V2 and Octavia"}],"source_content_type":"text/plain","patch_set":15,"id":"ff82abbf_06ab411d","line":58,"range":{"start_line":55,"start_character":0,"end_line":58,"end_character":20},"updated":"2017-11-21 01:30:50.000000000","message":"You removed cinder in the single node, why not remove it from the multi-node as well.  We don\u0027t need it.","commit_id":"70d670fbce88e287c1dc4a8916e298399d7c2ac8"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"67c65a9d48136657b739fab714fc41cefff5d8ad","unresolved":false,"context_lines":[{"line_number":52,"context_line":"enable_service q-l3"},{"line_number":53,"context_line":"enable_service q-meta"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# Cinder"},{"line_number":56,"context_line":"enable_service c-api"},{"line_number":57,"context_line":"enable_service c-vol"},{"line_number":58,"context_line":"enable_service c-sch"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# LBaaS V2 and Octavia"}],"source_content_type":"text/plain","patch_set":15,"id":"ff82abbf_2ba85e75","line":58,"range":{"start_line":55,"start_character":0,"end_line":58,"end_character":20},"in_reply_to":"ff82abbf_06ab411d","updated":"2017-11-22 12:57:26.000000000","message":"Done","commit_id":"70d670fbce88e287c1dc4a8916e298399d7c2ac8"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"987abc215ac9b415347ae78861f992453b121c0e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"enable_service c-sch"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# LBaaS V2 and Octavia"},{"line_number":62,"context_line":"enable_service q-lbaasv2"},{"line_number":63,"context_line":"enable_service octavia"},{"line_number":64,"context_line":"enable_service o-cw"}],"source_content_type":"text/plain","patch_set":16,"id":"ff82abbf_2eddc941","side":"PARENT","line":61,"range":{"start_line":61,"start_character":2,"end_line":61,"end_character":14},"updated":"2017-11-22 14:44:22.000000000","message":"Nitpicking: this should go too (same in other conf files)","commit_id":"825276d0e23bfb2f362b0390eeaeee895c7c9930"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"132b2dd39889a1ff315b18a49ae6fefec2d92459","unresolved":false,"context_lines":[{"line_number":58,"context_line":"enable_service c-sch"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# LBaaS V2 and Octavia"},{"line_number":62,"context_line":"enable_service q-lbaasv2"},{"line_number":63,"context_line":"enable_service octavia"},{"line_number":64,"context_line":"enable_service o-cw"}],"source_content_type":"text/plain","patch_set":16,"id":"ff82abbf_a7453745","side":"PARENT","line":61,"range":{"start_line":61,"start_character":2,"end_line":61,"end_character":14},"in_reply_to":"ff82abbf_2eddc941","updated":"2017-11-26 11:23:15.000000000","message":"Done","commit_id":"825276d0e23bfb2f362b0390eeaeee895c7c9930"}],"devstack/samples/singlenode/local.conf":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"edf62eea3e070d2523e3a1888a620e2ca47b1004","unresolved":false,"context_lines":[{"line_number":72,"context_line":"enable_service o-hk"},{"line_number":73,"context_line":"enable_service o-api"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"OCTAVIA_USE_PREGENERATED_CERTS\u003dTrue"},{"line_number":76,"context_line":"OCTAVIA_USE_PREGENERATED_SSH_KEY\u003dTrue"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# enable DVR"},{"line_number":79,"context_line":""}],"source_content_type":"text/plain","patch_set":15,"id":"ff82abbf_069261f7","line":76,"range":{"start_line":75,"start_character":0,"end_line":76,"end_character":37},"updated":"2017-11-21 01:30:50.000000000","message":"I don\u0027t think this is necessary for non-multinode installs.","commit_id":"70d670fbce88e287c1dc4a8916e298399d7c2ac8"}],"devstack/samples/singlenode/local.sh":[{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"873263980364becc4fcec3fb2b16d4b37976d290","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    touch ~/.ssh/known_hosts"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    ssh-keygen -R ${IP1}"},{"line_number":63,"context_line":"    ssh-keygen -R ${IP2}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    # Run a simple web server on the instances"},{"line_number":66,"context_line":"    chmod 0755 ${TOP_DIR}/webserver.sh"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5f2577a7_c22ff93c","line":63,"range":{"start_line":62,"start_character":0,"end_line":63,"end_character":24},"updated":"2017-09-18 08:46:26.000000000","message":"Testing is still not done.\nthis specific section fails and I\u0027m working to fix that.\n\nLog:\n\n\n2017-09-18 07:54:28.413 | ++local.sh:main:57                          awk \u0027/private/ {ip \u003d substr($5, 0, length($5)-1); if (ip ~ \"\\\\.\") print ip; else print $6}\u0027\n2017-09-18 07:54:28.413 | ++local.sh:main:57                          openstack server show node1\n2017-09-18 07:54:28.413 | ++local.sh:main:57                          cut -d\u003d -f 2\n2017-09-18 07:54:31.056 | +local.sh:main:57                          IP1\u003d\n2017-09-18 07:54:31.060 | ++local.sh:main:58                          openstack server show node2\n2017-09-18 07:54:31.061 | ++local.sh:main:58                          awk \u0027/private/ {ip \u003d substr($5, 0, length($5)-1); if (ip ~ \"\\\\.\") print ip; else print $6}\u0027\n2017-09-18 07:54:31.061 | ++local.sh:main:58                          cut -d\u003d -f 2\n2017-09-18 07:54:33.662 | +local.sh:main:58                          IP2\u003d\n2017-09-18 07:54:33.666 | +local.sh:main:60                          touch /opt/stack/.ssh/known_hosts\n2017-09-18 07:54:33.670 | +local.sh:main:62                          ssh-keygen -R\n2017-09-18 07:54:33.674 | option requires an argument -- R","commit_id":"78c88c10f37fe80e3e83d90c4725c8bfbe6cdfb6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"edf62eea3e070d2523e3a1888a620e2ca47b1004","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    scp -i ${DEVSTACK_LBAAS_SSH_KEY} -o StrictHostKeyChecking\u003dno ${TOP_DIR}/webserver.sh cirros@${IP1}:webserver.sh"},{"line_number":68,"context_line":"    scp -i ${DEVSTACK_LBAAS_SSH_KEY} -o StrictHostKeyChecking\u003dno ${TOP_DIR}/webserver.sh cirros@${IP2}:webserver.sh"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    screen_process node1 \"ssh -i ${DEVSTACK_LBAAS_SSH_KEY} -o StrictHostKeyChecking\u003dno cirros@${IP1} ./webserver.sh\""},{"line_number":71,"context_line":"    screen_process node2 \"ssh -i ${DEVSTACK_LBAAS_SSH_KEY} -o StrictHostKeyChecking\u003dno cirros@${IP2} ./webserver.sh\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":15,"id":"ff82abbf_062ee1a4","side":"PARENT","line":70,"updated":"2017-11-21 01:30:50.000000000","message":"ssh -o UserKnownHostsFile\u003d/dev/null -i /etc/octavia/.ssh/octavia_ssh_key -o StrictHostKeyChecking\u003dno -q cirros@${IP1} \"screen -d -m sh webserver.sh\"","commit_id":"825276d0e23bfb2f362b0390eeaeee895c7c9930"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"987abc215ac9b415347ae78861f992453b121c0e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# Polling functions"},{"line_number":21,"context_line":"function wait_for_loadbalancer_active() {"},{"line_number":22,"context_line":"  lb_name\u003d$1"},{"line_number":23,"context_line":"  while [ $(openstack loadbalancer list | grep $lb_name | grep ACTIVE | wc --lines) \u003d\u003d 0 ]; do"},{"line_number":24,"context_line":"    sleep 2"},{"line_number":25,"context_line":"  done"},{"line_number":26,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":16,"id":"ff82abbf_ce71bd0e","line":23,"range":{"start_line":23,"start_character":12,"end_line":23,"end_character":69},"updated":"2017-11-22 14:44:22.000000000","message":"To get status directly: \"openstack loadbalancer show $lb_name -f value -c provisioning_status\"\nSo something like:\nwhile [ $(openstack loadbalancer show $lb_name -f value -c provisioning_status) !\u003d \"ACTIVE\" ];","commit_id":"e54c22f87421810c238849390f05b3e1a92e49da"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"132b2dd39889a1ff315b18a49ae6fefec2d92459","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# Polling functions"},{"line_number":21,"context_line":"function wait_for_loadbalancer_active() {"},{"line_number":22,"context_line":"  lb_name\u003d$1"},{"line_number":23,"context_line":"  while [ $(openstack loadbalancer list | grep $lb_name | grep ACTIVE | wc --lines) \u003d\u003d 0 ]; do"},{"line_number":24,"context_line":"    sleep 2"},{"line_number":25,"context_line":"  done"},{"line_number":26,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":16,"id":"ff82abbf_c7b07b46","line":23,"range":{"start_line":23,"start_character":12,"end_line":23,"end_character":69},"in_reply_to":"ff82abbf_ce71bd0e","updated":"2017-11-26 11:23:15.000000000","message":"Done","commit_id":"e54c22f87421810c238849390f05b3e1a92e49da"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"987abc215ac9b415347ae78861f992453b121c0e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    openstack security group rule create --protocol icmp default"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    # Boot some instances"},{"line_number":49,"context_line":"    NOVA_BOOT_ARGS\u003d\"--key-name ${DEVSTACK_LBAAS_SSH_KEY_NAME} --image $(openstack image list | awk \u0027/ cirros-0.3.5-x86_64-disk / {print $2}\u0027) --flavor 1 --nic net-id\u003d$(openstack network list | awk \u0027/ private / {print $2}\u0027)\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    openstack server create ${NOVA_BOOT_ARGS} node1"},{"line_number":52,"context_line":"    openstack server create ${NOVA_BOOT_ARGS} node2"}],"source_content_type":"text/x-sh","patch_set":16,"id":"ff82abbf_4e492d89","line":49,"range":{"start_line":49,"start_character":88,"end_line":49,"end_character":140},"updated":"2017-11-22 14:44:22.000000000","message":"show cirros-0.3.5-x86_64-disk -f value -c id","commit_id":"e54c22f87421810c238849390f05b3e1a92e49da"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"987abc215ac9b415347ae78861f992453b121c0e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    openstack security group rule create --protocol icmp default"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    # Boot some instances"},{"line_number":49,"context_line":"    NOVA_BOOT_ARGS\u003d\"--key-name ${DEVSTACK_LBAAS_SSH_KEY_NAME} --image $(openstack image list | awk \u0027/ cirros-0.3.5-x86_64-disk / {print $2}\u0027) --flavor 1 --nic net-id\u003d$(openstack network list | awk \u0027/ private / {print $2}\u0027)\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    openstack server create ${NOVA_BOOT_ARGS} node1"},{"line_number":52,"context_line":"    openstack server create ${NOVA_BOOT_ARGS} node2"}],"source_content_type":"text/x-sh","patch_set":16,"id":"ff82abbf_6e31910b","line":49,"range":{"start_line":49,"start_character":186,"end_line":49,"end_character":221},"updated":"2017-11-22 14:44:22.000000000","message":"show private -f value -c id","commit_id":"e54c22f87421810c238849390f05b3e1a92e49da"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"132b2dd39889a1ff315b18a49ae6fefec2d92459","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    openstack security group rule create --protocol icmp default"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    # Boot some instances"},{"line_number":49,"context_line":"    NOVA_BOOT_ARGS\u003d\"--key-name ${DEVSTACK_LBAAS_SSH_KEY_NAME} --image $(openstack image list | awk \u0027/ cirros-0.3.5-x86_64-disk / {print $2}\u0027) --flavor 1 --nic net-id\u003d$(openstack network list | awk \u0027/ private / {print $2}\u0027)\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    openstack server create ${NOVA_BOOT_ARGS} node1"},{"line_number":52,"context_line":"    openstack server create ${NOVA_BOOT_ARGS} node2"}],"source_content_type":"text/x-sh","patch_set":16,"id":"ff82abbf_a7b3f74c","line":49,"range":{"start_line":49,"start_character":88,"end_line":49,"end_character":140},"in_reply_to":"ff82abbf_4e492d89","updated":"2017-11-26 11:23:15.000000000","message":"Done","commit_id":"e54c22f87421810c238849390f05b3e1a92e49da"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"132b2dd39889a1ff315b18a49ae6fefec2d92459","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    openstack security group rule create --protocol icmp default"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    # Boot some instances"},{"line_number":49,"context_line":"    NOVA_BOOT_ARGS\u003d\"--key-name ${DEVSTACK_LBAAS_SSH_KEY_NAME} --image $(openstack image list | awk \u0027/ cirros-0.3.5-x86_64-disk / {print $2}\u0027) --flavor 1 --nic net-id\u003d$(openstack network list | awk \u0027/ private / {print $2}\u0027)\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    openstack server create ${NOVA_BOOT_ARGS} node1"},{"line_number":52,"context_line":"    openstack server create ${NOVA_BOOT_ARGS} node2"}],"source_content_type":"text/x-sh","patch_set":16,"id":"ff82abbf_4786ab68","line":49,"range":{"start_line":49,"start_character":186,"end_line":49,"end_character":221},"in_reply_to":"ff82abbf_6e31910b","updated":"2017-11-26 11:23:15.000000000","message":"Done","commit_id":"e54c22f87421810c238849390f05b3e1a92e49da"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"987abc215ac9b415347ae78861f992453b121c0e","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    # Get Neutron router namespace details"},{"line_number":67,"context_line":"    NAMESPACE_NAME\u003d\u0027qrouter-\u0027$(openstack router show router1 | awk \u0027/ id / {print $4}\u0027)"},{"line_number":68,"context_line":"    NAMESPACE_CMD_PREFIX\u003d\u0027sudo ip netns exec\u0027"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    # Run a simple web server on the instances"}],"source_content_type":"text/x-sh","patch_set":16,"id":"ff82abbf_0ead6530","line":67,"range":{"start_line":67,"start_character":61,"end_line":67,"end_character":86},"updated":"2017-11-22 14:44:22.000000000","message":"-f value -c id","commit_id":"e54c22f87421810c238849390f05b3e1a92e49da"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"132b2dd39889a1ff315b18a49ae6fefec2d92459","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    # Get Neutron router namespace details"},{"line_number":67,"context_line":"    NAMESPACE_NAME\u003d\u0027qrouter-\u0027$(openstack router show router1 | awk \u0027/ id / {print $4}\u0027)"},{"line_number":68,"context_line":"    NAMESPACE_CMD_PREFIX\u003d\u0027sudo ip netns exec\u0027"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    # Run a simple web server on the instances"}],"source_content_type":"text/x-sh","patch_set":16,"id":"ff82abbf_678baf6d","line":67,"range":{"start_line":67,"start_character":61,"end_line":67,"end_character":86},"in_reply_to":"ff82abbf_0ead6530","updated":"2017-11-26 11:23:15.000000000","message":"Done","commit_id":"e54c22f87421810c238849390f05b3e1a92e49da"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"987abc215ac9b415347ae78861f992453b121c0e","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"if is_service_enabled octavia; then"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    SUBNET_ID\u003d$(openstack subnet list | awk \u0027/ private-subnet / {print $2}\u0027)"},{"line_number":82,"context_line":"    openstack loadbalancer create --name lb1 --vip-subnet-id $SUBNET_ID"},{"line_number":83,"context_line":"    wait_for_loadbalancer_active lb1"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-sh","patch_set":16,"id":"ff82abbf_ae9239f5","line":81,"range":{"start_line":81,"start_character":33,"end_line":81,"end_character":75},"updated":"2017-11-22 14:44:22.000000000","message":"show private-subnet -f value -c id","commit_id":"e54c22f87421810c238849390f05b3e1a92e49da"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"132b2dd39889a1ff315b18a49ae6fefec2d92459","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"if is_service_enabled octavia; then"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    SUBNET_ID\u003d$(openstack subnet list | awk \u0027/ private-subnet / {print $2}\u0027)"},{"line_number":82,"context_line":"    openstack loadbalancer create --name lb1 --vip-subnet-id $SUBNET_ID"},{"line_number":83,"context_line":"    wait_for_loadbalancer_active lb1"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-sh","patch_set":16,"id":"ff82abbf_2781274b","line":81,"range":{"start_line":81,"start_character":33,"end_line":81,"end_character":75},"in_reply_to":"ff82abbf_ae9239f5","updated":"2017-11-26 11:23:15.000000000","message":"Done","commit_id":"e54c22f87421810c238849390f05b3e1a92e49da"}]}