)]}'
{"octavia/controller/healthmanager/update_db.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"660735f3118669d7c2d620efc06dcfe1d86fbaeb","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        if self.sync_prv_status:"},{"line_number":65,"context_line":"            LOG.debug(\"%s %s provisioning_status %s. \""},{"line_number":66,"context_line":"                      \"Updating db and sending event.\","},{"line_number":67,"context_line":"                      entity_type, entity_id, old_op_status)"},{"line_number":68,"context_line":"            message.update("},{"line_number":69,"context_line":"                {constants.PROVISIONING_STATUS: old_op_status})"},{"line_number":70,"context_line":"        if message:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f4e5783_570097ab","line":67,"updated":"2017-10-13 19:25:44.000000000","message":"This isn\u0027t right -- you\u0027re now conflating operating_status and provisioning_status, which are completely different.","commit_id":"e50b964dbc16a5c2daa0eb3a7cf77d98abd6cd87"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"660735f3118669d7c2d620efc06dcfe1d86fbaeb","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                      \"Updating db and sending event.\","},{"line_number":67,"context_line":"                      entity_type, entity_id, old_op_status)"},{"line_number":68,"context_line":"            message.update("},{"line_number":69,"context_line":"                {constants.PROVISIONING_STATUS: old_op_status})"},{"line_number":70,"context_line":"        if message:"},{"line_number":71,"context_line":"            self.emit(entity_type, entity_id, message)"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f4e5783_37fd1bb1","line":69,"updated":"2017-10-13 19:25:44.000000000","message":"Same.","commit_id":"e50b964dbc16a5c2daa0eb3a7cf77d98abd6cd87"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"883cd59a2b348364e4eb02fa07052177fd9ecd09","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                                                              health[\u0027id\u0027])"},{"line_number":102,"context_line":"        listeners \u003d health[\u0027listeners\u0027]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        for lb in lbs_on_amp:"},{"line_number":105,"context_line":"            expected_listener_count +\u003d len(lb.listeners)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"            if lb.enabled is False:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f4e5783_88682ab9","line":104,"updated":"2017-10-13 20:58:20.000000000","message":"Why did you move this above the timestamp block?\nShouldn\u0027t we stamp the amp as healthy with the timestamp as early in this code as possible?","commit_id":"e50b964dbc16a5c2daa0eb3a7cf77d98abd6cd87"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"660735f3118669d7c2d620efc06dcfe1d86fbaeb","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        listeners \u003d health[\u0027listeners\u0027]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        for lb in lbs_on_amp:"},{"line_number":105,"context_line":"            expected_listener_count +\u003d len(lb.listeners)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"            if lb.enabled is False:"},{"line_number":108,"context_line":"                lb_status \u003d constants.OFFLINE"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f4e5783_d7b36709","line":105,"updated":"2017-10-13 19:25:44.000000000","message":"Was there a good reason for us having a very odd way of doing this count before? Were we just crazy? This does seem simpler...","commit_id":"e50b964dbc16a5c2daa0eb3a7cf77d98abd6cd87"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"660735f3118669d7c2d620efc06dcfe1d86fbaeb","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                if not listener:"},{"line_number":147,"context_line":"                    continue"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"                pools \u003d listener[\u0027pools\u0027]"},{"line_number":150,"context_line":"                for db_pool in db_listener.pools:"},{"line_number":151,"context_line":"                    pool_status \u003d None"},{"line_number":152,"context_line":"                    pool_id \u003d db_pool.id"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f4e5783_178c5f34","line":149,"updated":"2017-10-13 19:25:44.000000000","message":"Should this maybe be `listener.get(\u0027pools\u0027, [])` for safety? I forget if this is already guaranteed to be a list. Yes, I realize this was already in the old code. :P","commit_id":"e50b964dbc16a5c2daa0eb3a7cf77d98abd6cd87"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"660735f3118669d7c2d620efc06dcfe1d86fbaeb","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"                        # Deal with the members that are reporting from"},{"line_number":173,"context_line":"                        # the Amphora"},{"line_number":174,"context_line":"                        members \u003d pool[\u0027members\u0027]"},{"line_number":175,"context_line":"                        for db_member in db_pool.members:"},{"line_number":176,"context_line":"                            member_status \u003d None"},{"line_number":177,"context_line":"                            member_id \u003d db_member.id"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f4e5783_d796c73e","line":174,"updated":"2017-10-13 19:25:44.000000000","message":"Same as above, possibly `pool.get(\u0027members\u0027, [])` is safer.","commit_id":"e50b964dbc16a5c2daa0eb3a7cf77d98abd6cd87"}]}