)]}'
{"etc/octavia.conf":[{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"d56ad977e712679c64991ff46178e5c95006a331","unresolved":false,"context_lines":[{"line_number":159,"context_line":"# haproxy_stick_size \u003d 10k"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"# REST Driver specific"},{"line_number":162,"context_line":"# bind_host \u003d 192.168.123.123"},{"line_number":163,"context_line":"# bind_port \u003d 9443"},{"line_number":164,"context_line":"#"},{"line_number":165,"context_line":"# This setting is only needed with IPv6 link-local addresses (fe80::/64) are"}],"source_content_type":"text/plain","patch_set":1,"id":"ff5d4b2f_54b5b1ed","line":162,"range":{"start_line":162,"start_character":0,"end_line":162,"end_character":29},"updated":"2017-09-19 10:59:21.000000000","message":"remove this.","commit_id":"fff84f0ef123cb74f5f00fe029700f4ac4b8ddbe"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"1b9be89df9a9ccfe777f0688e937ca7c55ae7b77","unresolved":false,"context_lines":[{"line_number":159,"context_line":"# haproxy_stick_size \u003d 10k"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"# REST Driver specific"},{"line_number":162,"context_line":"# bind_host_list Example: 192.168.0.1, 192.168.0.2"},{"line_number":163,"context_line":"# bind_port \u003d 9443"},{"line_number":164,"context_line":"#"},{"line_number":165,"context_line":"# This setting is only needed with IPv6 link-local addresses (fe80::/64) are"}],"source_content_type":"text/plain","patch_set":27,"id":"3f4b6375_67258fab","line":162,"range":{"start_line":162,"start_character":0,"end_line":162,"end_character":50},"updated":"2017-10-30 06:52:23.000000000","message":"How about write the example in a new line? I didn\u0027t saw the new configuration option in the first time. :)","commit_id":"6e9fcc3b74af19578c02be7cc875fb9e2cf6535a"},{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"cce8c2a19901849cf9d4476c3054c84d38fb131f","unresolved":false,"context_lines":[{"line_number":159,"context_line":"# haproxy_stick_size \u003d 10k"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"# REST Driver specific"},{"line_number":162,"context_line":"# bind_host_list Example: 192.168.0.1, 192.168.0.2"},{"line_number":163,"context_line":"# bind_port \u003d 9443"},{"line_number":164,"context_line":"#"},{"line_number":165,"context_line":"# This setting is only needed with IPv6 link-local addresses (fe80::/64) are"}],"source_content_type":"text/plain","patch_set":27,"id":"3f4b6375_c53431fe","line":162,"range":{"start_line":162,"start_character":0,"end_line":162,"end_character":50},"in_reply_to":"3f4b6375_67258fab","updated":"2017-10-30 14:51:25.000000000","message":"Done","commit_id":"6e9fcc3b74af19578c02be7cc875fb9e2cf6535a"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"2e97ef2882383c1ff4f37a1fec758f9fa70741d7","unresolved":false,"context_lines":[{"line_number":159,"context_line":"# haproxy_stick_size \u003d 10k"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"# REST Driver specific"},{"line_number":162,"context_line":"# bind_host_list \u003d"},{"line_number":163,"context_line":"# Example for multiple values: 192.168.0.1, 192.168.0.2"},{"line_number":164,"context_line":"#"},{"line_number":165,"context_line":"# bind_port \u003d 9443"}],"source_content_type":"text/plain","patch_set":37,"id":"1f485f77_a83f65b2","line":162,"updated":"2017-11-15 22:33:51.000000000","message":"We usually retain old configuration parameters for two cycles but mark them for deprecation (see our other examples)","commit_id":"dcc957b631b27c0ff9faf50c9648a280ba3ac8b9"},{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"e515646b768a737e15cdcbb8c60758b03df5423d","unresolved":false,"context_lines":[{"line_number":159,"context_line":"# haproxy_stick_size \u003d 10k"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"# REST Driver specific"},{"line_number":162,"context_line":"# bind_host_list \u003d"},{"line_number":163,"context_line":"# Example for multiple values: 192.168.0.1, 192.168.0.2"},{"line_number":164,"context_line":"#"},{"line_number":165,"context_line":"# bind_port \u003d 9443"}],"source_content_type":"text/plain","patch_set":37,"id":"1f485f77_cb6bbbb4","line":162,"in_reply_to":"1f485f77_a83f65b2","updated":"2017-11-15 23:17:49.000000000","message":"Done","commit_id":"dcc957b631b27c0ff9faf50c9648a280ba3ac8b9"}],"octavia/amphorae/backends/agent/agent_jinja_cfg.py":[{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"42c86c28373c511149c426e3375178b688eb7af4","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            constants.AGENT_CONF_TEMPLATE)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def build_agent_config(self, amphora_id, bind_host \u003d None):"},{"line_number":38,"context_line":"        if bind_host is None:"},{"line_number":39,"context_line":"            bind_host \u003d CONF.haproxy_amphora.bind_host"},{"line_number":40,"context_line":"        return self.agent_template.render("},{"line_number":41,"context_line":"            {\u0027agent_server_ca\u0027: CONF.amphora_agent.agent_server_ca,"},{"line_number":42,"context_line":"             \u0027agent_server_cert\u0027: CONF.amphora_agent.agent_server_cert,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_53e35934","line":39,"range":{"start_line":38,"start_character":8,"end_line":39,"end_character":54},"updated":"2017-09-25 09:45:19.000000000","message":"Why?\nYou deleted this from octavia.conf, so there will be nothing at CONF.haproxy_amphora.bind_host","commit_id":"ff7e482daeb0404d666435489a54e021bbf2823a"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"5076a773f8bc70f674b509942ec0204d77af92f9","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.agent_template \u003d jinja_env.get_template("},{"line_number":35,"context_line":"            constants.AGENT_CONF_TEMPLATE)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def build_agent_config(self, amphora_id, bind_host\u003dNone):"},{"line_number":38,"context_line":"        if bind_host is None:"},{"line_number":39,"context_line":"            bind_host \u003d CONF.haproxy_amphora.bind_host"},{"line_number":40,"context_line":"        return self.agent_template.render("},{"line_number":41,"context_line":"            {\u0027agent_server_ca\u0027: CONF.amphora_agent.agent_server_ca,"},{"line_number":42,"context_line":"             \u0027agent_server_cert\u0027: CONF.amphora_agent.agent_server_cert,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f515b1d_80b0078c","line":39,"range":{"start_line":37,"start_character":45,"end_line":39,"end_character":54},"updated":"2017-09-27 09:05:09.000000000","message":"1. bind_host should always contain a value, so no need to default to None\n2. That if statement is not needed since you delete  CONF.haproxy_amphora.bind_host from octavia.conf","commit_id":"3e3fb95c088a7c5f190a56882005673744d40ac9"},{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"cef8c1543ed4345cb253aa723de51a1e6dc64e84","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.agent_template \u003d jinja_env.get_template("},{"line_number":35,"context_line":"            constants.AGENT_CONF_TEMPLATE)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def build_agent_config(self, amphora_id, bind_host\u003dNone):"},{"line_number":38,"context_line":"        if bind_host is None:"},{"line_number":39,"context_line":"            bind_host \u003d CONF.haproxy_amphora.bind_host"},{"line_number":40,"context_line":"        return self.agent_template.render("},{"line_number":41,"context_line":"            {\u0027agent_server_ca\u0027: CONF.amphora_agent.agent_server_ca,"},{"line_number":42,"context_line":"             \u0027agent_server_cert\u0027: CONF.amphora_agent.agent_server_cert,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f515b1d_738727b7","line":39,"range":{"start_line":37,"start_character":45,"end_line":39,"end_character":54},"in_reply_to":"7f515b1d_80b0078c","updated":"2017-09-27 09:41:52.000000000","message":"I\u0027ll get rid of that default and its subsequent lines later.","commit_id":"3e3fb95c088a7c5f190a56882005673744d40ac9"}],"octavia/cmd/agent.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"3ece2c627bf15d37f6496253b3eef59db2caf5b0","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    server_instance \u003d server.Server()"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    bind_ip_port_list \u003d ["},{"line_number":70,"context_line":"        (utils.ip_port_str(host, CONF.haproxy_amphora.bind_port))"},{"line_number":71,"context_line":"        for host in CONF.haproxy_amphora.bind_host_list"},{"line_number":72,"context_line":"    ]"},{"line_number":73,"context_line":"    options \u003d {"}],"source_content_type":"text/x-python","patch_set":49,"id":"df87a7cf_f0828552","line":70,"range":{"start_line":70,"start_character":8,"end_line":70,"end_character":9},"updated":"2017-12-14 08:17:29.000000000","message":"this is redundant","commit_id":"fa74b579349b15fdc4acf1f3f0923ebaf7433945"},{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"71990533246f036ac2c9b370cdb9d7d01a6b5337","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    server_instance \u003d server.Server()"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    bind_ip_port_list \u003d ["},{"line_number":70,"context_line":"        (utils.ip_port_str(host, CONF.haproxy_amphora.bind_port))"},{"line_number":71,"context_line":"        for host in CONF.haproxy_amphora.bind_host_list"},{"line_number":72,"context_line":"    ]"},{"line_number":73,"context_line":"    options \u003d {"}],"source_content_type":"text/x-python","patch_set":49,"id":"df87a7cf_34a3fc51","line":70,"range":{"start_line":70,"start_character":8,"end_line":70,"end_character":9},"in_reply_to":"df87a7cf_f0828552","updated":"2017-12-14 12:34:59.000000000","message":"Done","commit_id":"fa74b579349b15fdc4acf1f3f0923ebaf7433945"}],"octavia/common/config.py":[{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"d56ad977e712679c64991ff46178e5c95006a331","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                      \u0027suffixes.  Example: 10k\u0027)),"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    # REST server"},{"line_number":236,"context_line":"    cfg.IPOpt(\u0027bind_host\u0027, default\u003d\u0027::\u0027,"},{"line_number":237,"context_line":"              help\u003d_(\"The host IP to bind to\")),"},{"line_number":238,"context_line":"    cfg.PortOpt(\u0027bind_port\u0027, default\u003d9443,"},{"line_number":239,"context_line":"                help\u003d_(\"The port to bind to\")),"},{"line_number":240,"context_line":"    cfg.StrOpt(\u0027lb_network_interface\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff5d4b2f_54aa5185","line":237,"range":{"start_line":236,"start_character":0,"end_line":237,"end_character":48},"updated":"2017-09-19 10:59:21.000000000","message":"remove the default value here.","commit_id":"fff84f0ef123cb74f5f00fe029700f4ac4b8ddbe"},{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"48f63e2ef8f8f356a6e32771f2fa4c32c972720c","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                      \u0027suffixes.  Example: 10k\u0027)),"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    # REST server"},{"line_number":236,"context_line":"    cfg.IPOpt(\u0027bind_host\u0027, default\u003d\u0027::\u0027,"},{"line_number":237,"context_line":"              help\u003d_(\"The host IP to bind to\")),"},{"line_number":238,"context_line":"    cfg.PortOpt(\u0027bind_port\u0027, default\u003d9443,"},{"line_number":239,"context_line":"                help\u003d_(\"The port to bind to\")),"},{"line_number":240,"context_line":"    cfg.StrOpt(\u0027lb_network_interface\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_8e21a6b7","line":237,"range":{"start_line":236,"start_character":0,"end_line":237,"end_character":48},"in_reply_to":"ff5d4b2f_54aa5185","updated":"2017-09-25 11:41:37.000000000","message":"Done","commit_id":"fff84f0ef123cb74f5f00fe029700f4ac4b8ddbe"}],"octavia/common/utils.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"3ece2c627bf15d37f6496253b3eef59db2caf5b0","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        \"octavia_amp_mgmt_port\","},{"line_number":84,"context_line":"        amphora_id,"},{"line_number":85,"context_line":"        amphora_mgmt_network_id,"},{"line_number":86,"context_line":"        ]))"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"class exception_logger(object):"}],"source_content_type":"text/x-python","patch_set":49,"id":"df87a7cf_b07cfd72","line":86,"range":{"start_line":86,"start_character":4,"end_line":86,"end_character":8},"updated":"2017-12-14 08:17:29.000000000","message":"just remove these spaces.","commit_id":"fa74b579349b15fdc4acf1f3f0923ebaf7433945"},{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"71990533246f036ac2c9b370cdb9d7d01a6b5337","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        \"octavia_amp_mgmt_port\","},{"line_number":84,"context_line":"        amphora_id,"},{"line_number":85,"context_line":"        amphora_mgmt_network_id,"},{"line_number":86,"context_line":"        ]))"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"class exception_logger(object):"}],"source_content_type":"text/x-python","patch_set":49,"id":"df87a7cf_9491a8f4","line":86,"range":{"start_line":86,"start_character":4,"end_line":86,"end_character":8},"in_reply_to":"df87a7cf_b07cfd72","updated":"2017-12-14 12:34:59.000000000","message":"PEP8: Note that both options are equally good.","commit_id":"fa74b579349b15fdc4acf1f3f0923ebaf7433945"}],"octavia/controller/worker/tasks/compute_tasks.py":[{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"36ca32abac1f52519b9b1562f3a011820c3a9721","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        key_name \u003d None if not ssh_access else key_name"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        try:"},{"line_number":74,"context_line":"            port_ip_address \u003d CONF.haproxy_amphora.bind_host"},{"line_number":75,"context_line":"            if CONF.haproxy_amphora.build_rate_limit !\u003d -1:"},{"line_number":76,"context_line":"                self.rate_limit.add_to_build_request_queue("},{"line_number":77,"context_line":"                    amphora_id, build_type_priority)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff5d4b2f_5b45dc6f","line":74,"range":{"start_line":74,"start_character":12,"end_line":74,"end_character":60},"updated":"2017-09-19 13:48:06.000000000","message":"so port_ip_address should actually contain an IP address of a newly created port in the lb-mgmt-net instead, right?","commit_id":"fff84f0ef123cb74f5f00fe029700f4ac4b8ddbe"},{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"48f63e2ef8f8f356a6e32771f2fa4c32c972720c","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        key_name \u003d None if not ssh_access else key_name"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        try:"},{"line_number":74,"context_line":"            port_ip_address \u003d CONF.haproxy_amphora.bind_host"},{"line_number":75,"context_line":"            if CONF.haproxy_amphora.build_rate_limit !\u003d -1:"},{"line_number":76,"context_line":"                self.rate_limit.add_to_build_request_queue("},{"line_number":77,"context_line":"                    amphora_id, build_type_priority)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_2e4cf29c","line":74,"range":{"start_line":74,"start_character":12,"end_line":74,"end_character":60},"in_reply_to":"ff5d4b2f_5b45dc6f","updated":"2017-09-25 11:41:37.000000000","message":"ack","commit_id":"fff84f0ef123cb74f5f00fe029700f4ac4b8ddbe"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"d56ad977e712679c64991ff46178e5c95006a331","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                    port_ip_address,"},{"line_number":84,"context_line":"                    )"},{"line_number":85,"context_line":"                )"},{"line_number":86,"context_line":"            "},{"line_number":87,"context_line":"            if user_data_config_drive:"},{"line_number":88,"context_line":"                udtemplater \u003d user_data_jinja_cfg.UserDataJinjaCfg()"},{"line_number":89,"context_line":"                user_data \u003d udtemplater.build_user_data_config("}],"source_content_type":"text/x-python","patch_set":1,"id":"ff5d4b2f_74679527","line":86,"range":{"start_line":86,"start_character":0,"end_line":86,"end_character":12},"updated":"2017-09-19 10:59:21.000000000","message":"spaces, just clean them up and leave that line empty","commit_id":"fff84f0ef123cb74f5f00fe029700f4ac4b8ddbe"},{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"48f63e2ef8f8f356a6e32771f2fa4c32c972720c","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                    port_ip_address,"},{"line_number":84,"context_line":"                    )"},{"line_number":85,"context_line":"                )"},{"line_number":86,"context_line":"            "},{"line_number":87,"context_line":"            if user_data_config_drive:"},{"line_number":88,"context_line":"                udtemplater \u003d user_data_jinja_cfg.UserDataJinjaCfg()"},{"line_number":89,"context_line":"                user_data \u003d udtemplater.build_user_data_config("}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_0e513637","line":86,"range":{"start_line":86,"start_character":0,"end_line":86,"end_character":12},"in_reply_to":"ff5d4b2f_74679527","updated":"2017-09-25 11:41:37.000000000","message":"Done","commit_id":"fff84f0ef123cb74f5f00fe029700f4ac4b8ddbe"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"42c86c28373c511149c426e3375178b688eb7af4","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        key_name \u003d None if not ssh_access else key_name"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        try:"},{"line_number":74,"context_line":"            port_ip_address \u003d None"},{"line_number":75,"context_line":"            if CONF.haproxy_amphora.build_rate_limit !\u003d -1:"},{"line_number":76,"context_line":"                self.rate_limit.add_to_build_request_queue("},{"line_number":77,"context_line":"                    amphora_id, build_type_priority)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_d3d06953","line":74,"range":{"start_line":74,"start_character":12,"end_line":74,"end_character":34},"updated":"2017-09-25 09:45:19.000000000","message":"temp?","commit_id":"ff7e482daeb0404d666435489a54e021bbf2823a"},{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"48f63e2ef8f8f356a6e32771f2fa4c32c972720c","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        key_name \u003d None if not ssh_access else key_name"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        try:"},{"line_number":74,"context_line":"            port_ip_address \u003d None"},{"line_number":75,"context_line":"            if CONF.haproxy_amphora.build_rate_limit !\u003d -1:"},{"line_number":76,"context_line":"                self.rate_limit.add_to_build_request_queue("},{"line_number":77,"context_line":"                    amphora_id, build_type_priority)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_e9137465","line":74,"range":{"start_line":74,"start_character":12,"end_line":74,"end_character":34},"in_reply_to":"7f515b1d_d3d06953","updated":"2017-09-25 11:41:37.000000000","message":"yup. I\u0027ll set it in a later patch.","commit_id":"ff7e482daeb0404d666435489a54e021bbf2823a"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"a3248c1f1be876a4f866fb1a87599098ada8bd9c","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        :returns: an amphora"},{"line_number":63,"context_line":"        \"\"\""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        def _create_mgmt_port(port_name):"},{"line_number":66,"context_line":"            port_data \u003d {"},{"line_number":67,"context_line":"                \"name\": str(port_name),"},{"line_number":68,"context_line":"                \"network_id\": str("}],"source_content_type":"text/x-python","patch_set":12,"id":"7f515b1d_c604b31a","line":65,"range":{"start_line":65,"start_character":12,"end_line":65,"end_character":29},"updated":"2017-09-28 11:01:18.000000000","message":"looks like this function should belong at octavia.network.drivers.neutron.base.BaseNeutronDriver","commit_id":"47c08e6dc480bf3040b811d3d469d79b7af4ee41"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"a3248c1f1be876a4f866fb1a87599098ada8bd9c","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            port_data \u003d {"},{"line_number":67,"context_line":"                \"name\": str(port_name),"},{"line_number":68,"context_line":"                \"network_id\": str("},{"line_number":69,"context_line":"                    CONF.controller_worker.amp_boot_network_list[0]"},{"line_number":70,"context_line":"                ),"},{"line_number":71,"context_line":"                \"admin_state_up\": True,"},{"line_number":72,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":12,"id":"7f515b1d_e8009d03","line":69,"range":{"start_line":69,"start_character":20,"end_line":69,"end_character":67},"updated":"2017-09-28 11:01:18.000000000","message":"you should also handle cases of multiple lbaas mgmt networks.","commit_id":"47c08e6dc480bf3040b811d3d469d79b7af4ee41"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"a3248c1f1be876a4f866fb1a87599098ada8bd9c","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        try:"},{"line_number":91,"context_line":"            mgmt_port_ip_address \u003d None"},{"line_number":92,"context_line":"            try:"},{"line_number":93,"context_line":"                mgmt_port \u003d _create_mgmt_port(\"mgmt_port_\" + amphora_name)"},{"line_number":94,"context_line":"                ports.insert(0, mgmt_port)"},{"line_number":95,"context_line":"                mgmt_port_ip_address \u003d mgmt_port.fixed_ips[0].ip_address"},{"line_number":96,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":12,"id":"7f515b1d_c853a116","line":93,"range":{"start_line":93,"start_character":46,"end_line":93,"end_character":73},"updated":"2017-09-28 11:01:18.000000000","message":"the name should be more descriptive.\nfor example the naming we use for the health manager port:\noctavia-health-manager-standalone-listen-port\n\nso maybe something like: \"octavia_amphora_mgmt_\" + amphora_name","commit_id":"47c08e6dc480bf3040b811d3d469d79b7af4ee41"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"95322b7cc1d5e2ad92f39590725fcc5f0b0b5fa1","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            mgmt_ports \u003d []"},{"line_number":67,"context_line":"            try:"},{"line_number":68,"context_line":"                for amp_net in CONF.controller_worker.amp_boot_network_list:"},{"line_number":69,"context_line":"                    port_args \u003d {"},{"line_number":70,"context_line":"                        \"name\": str(port_name) + \"_\" + str(amp_net),"},{"line_number":71,"context_line":"                        \"network_id\": amp_net,"},{"line_number":72,"context_line":"                        \"admin_state_up\": True,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f515b1d_0c2074f6","line":69,"range":{"start_line":69,"start_character":20,"end_line":69,"end_character":29},"updated":"2017-10-02 11:40:29.000000000","message":"as we spoke: add server_group_id","commit_id":"590c2f3e26d78953dd41fd18b92dcbc554eb8237"},{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"39b1cb1402fec2ddb20fa2e811a4d59f489b1f39","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            mgmt_ports \u003d []"},{"line_number":67,"context_line":"            try:"},{"line_number":68,"context_line":"                for amp_net in CONF.controller_worker.amp_boot_network_list:"},{"line_number":69,"context_line":"                    port_args \u003d {"},{"line_number":70,"context_line":"                        \"name\": str(port_name) + \"_\" + str(amp_net),"},{"line_number":71,"context_line":"                        \"network_id\": amp_net,"},{"line_number":72,"context_line":"                        \"admin_state_up\": True,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f515b1d_bfebc410","line":69,"range":{"start_line":69,"start_character":20,"end_line":69,"end_character":29},"in_reply_to":"7f515b1d_0c2074f6","updated":"2017-10-02 12:18:54.000000000","message":"Done","commit_id":"590c2f3e26d78953dd41fd18b92dcbc554eb8237"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"95322b7cc1d5e2ad92f39590725fcc5f0b0b5fa1","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            try:"},{"line_number":68,"context_line":"                for amp_net in CONF.controller_worker.amp_boot_network_list:"},{"line_number":69,"context_line":"                    port_args \u003d {"},{"line_number":70,"context_line":"                        \"name\": str(port_name) + \"_\" + str(amp_net),"},{"line_number":71,"context_line":"                        \"network_id\": amp_net,"},{"line_number":72,"context_line":"                        \"admin_state_up\": True,"},{"line_number":73,"context_line":"                    }"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f515b1d_ec4198a7","line":70,"range":{"start_line":70,"start_character":32,"end_line":70,"end_character":67},"updated":"2017-10-02 11:40:29.000000000","message":"suggestion: \"_\".join([port_name, amp_net])","commit_id":"590c2f3e26d78953dd41fd18b92dcbc554eb8237"},{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"39b1cb1402fec2ddb20fa2e811a4d59f489b1f39","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            try:"},{"line_number":68,"context_line":"                for amp_net in CONF.controller_worker.amp_boot_network_list:"},{"line_number":69,"context_line":"                    port_args \u003d {"},{"line_number":70,"context_line":"                        \"name\": str(port_name) + \"_\" + str(amp_net),"},{"line_number":71,"context_line":"                        \"network_id\": amp_net,"},{"line_number":72,"context_line":"                        \"admin_state_up\": True,"},{"line_number":73,"context_line":"                    }"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f515b1d_1fc3f88a","line":70,"range":{"start_line":70,"start_character":32,"end_line":70,"end_character":67},"in_reply_to":"7f515b1d_ec4198a7","updated":"2017-10-02 12:18:54.000000000","message":"Check out my new implementation.\nNot sure it\u0027s any better the \u0027+\u0027 concatenation.","commit_id":"590c2f3e26d78953dd41fd18b92dcbc554eb8237"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"fdcf359cafaeaef1f429a43de6d5887256d6a043","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                    amphora_id, build_type_priority)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"            mgmt_port_ip_addresses \u003d list(itertools.chain.from_iterable("},{"line_number":80,"context_line":"                port.get_ip_addresses() for port in amphora_mgmt_ports))"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            agent_cfg \u003d agent_jinja_cfg.AgentJinjaTemplater()"},{"line_number":83,"context_line":"            config_drive_files[\u0027/etc/octavia/amphora-agent.conf\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":49,"id":"df87a7cf_140ef8e4","line":80,"updated":"2017-12-14 12:17:49.000000000","message":"Can we use list comprehension here?\n[port.get_ip_addresses() for port in amphora_mgmt_ports]","commit_id":"fa74b579349b15fdc4acf1f3f0923ebaf7433945"},{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"71990533246f036ac2c9b370cdb9d7d01a6b5337","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                    amphora_id, build_type_priority)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"            mgmt_port_ip_addresses \u003d list(itertools.chain.from_iterable("},{"line_number":80,"context_line":"                port.get_ip_addresses() for port in amphora_mgmt_ports))"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            agent_cfg \u003d agent_jinja_cfg.AgentJinjaTemplater()"},{"line_number":83,"context_line":"            config_drive_files[\u0027/etc/octavia/amphora-agent.conf\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":49,"id":"df87a7cf_b4e06c98","line":80,"in_reply_to":"df87a7cf_140ef8e4","updated":"2017-12-14 12:34:59.000000000","message":"Unfortunately not, perhaps PY3 has nicer solutions than mine here, but it won\u0027t be as straight forward as the one you\u0027ve suggested.","commit_id":"fa74b579349b15fdc4acf1f3f0923ebaf7433945"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"3ece2c627bf15d37f6496253b3eef59db2caf5b0","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                agent_cfg.build_agent_config("},{"line_number":85,"context_line":"                    amphora_id,"},{"line_number":86,"context_line":"                    mgmt_port_ip_addresses,"},{"line_number":87,"context_line":"                    )"},{"line_number":88,"context_line":"                )"},{"line_number":89,"context_line":"            if user_data_config_drive:"},{"line_number":90,"context_line":"                udtemplater \u003d user_data_jinja_cfg.UserDataJinjaCfg()"},{"line_number":91,"context_line":"                user_data \u003d udtemplater.build_user_data_config("}],"source_content_type":"text/x-python","patch_set":49,"id":"df87a7cf_9093f9a3","line":88,"range":{"start_line":87,"start_character":0,"end_line":88,"end_character":17},"updated":"2017-12-14 08:17:29.000000000","message":"re-indent this","commit_id":"fa74b579349b15fdc4acf1f3f0923ebaf7433945"}],"octavia/controller/worker/tasks/network_tasks.py":[{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"1b9be89df9a9ccfe777f0688e937ca7c55ae7b77","unresolved":false,"context_lines":[{"line_number":464,"context_line":"                count -\u003d 1"},{"line_number":465,"context_line":"            except Exception:"},{"line_number":466,"context_line":"                pass"},{"line_number":467,"context_line":"        return count"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"    def execute(self, amphora_id):"},{"line_number":470,"context_line":"        \"\"\"Create a list of ports with the management network"}],"source_content_type":"text/x-python","patch_set":27,"id":"3f4b6375_c2ee718a","line":467,"range":{"start_line":467,"start_character":7,"end_line":467,"end_character":20},"updated":"2017-10-30 06:52:23.000000000","message":"I think the local value is useless.","commit_id":"6e9fcc3b74af19578c02be7cc875fb9e2cf6535a"},{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"cce8c2a19901849cf9d4476c3054c84d38fb131f","unresolved":false,"context_lines":[{"line_number":464,"context_line":"                count -\u003d 1"},{"line_number":465,"context_line":"            except Exception:"},{"line_number":466,"context_line":"                pass"},{"line_number":467,"context_line":"        return count"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"    def execute(self, amphora_id):"},{"line_number":470,"context_line":"        \"\"\"Create a list of ports with the management network"}],"source_content_type":"text/x-python","patch_set":27,"id":"3f4b6375_452041b1","line":467,"range":{"start_line":467,"start_character":7,"end_line":467,"end_character":20},"in_reply_to":"3f4b6375_c2ee718a","updated":"2017-10-30 14:51:25.000000000","message":"Omitted.","commit_id":"6e9fcc3b74af19578c02be7cc875fb9e2cf6535a"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"1b9be89df9a9ccfe777f0688e937ca7c55ae7b77","unresolved":false,"context_lines":[{"line_number":520,"context_line":"                      \"id %s\", amphora_id)"},{"line_number":521,"context_line":"            for amp_net in CONF.controller_worker.amp_boot_network_list:"},{"line_number":522,"context_line":"                port_name \u003d self.get_mgmt_port_name(amphora_id, amp_net)"},{"line_number":523,"context_line":"                try:"},{"line_number":524,"context_line":"                    port_id \u003d self.network_driver.get_port_by_name("},{"line_number":525,"context_line":"                        port_name).id"},{"line_number":526,"context_line":"                except base.PortNotFound:"},{"line_number":527,"context_line":"                    LOG.warning(\"Port name %s not found to be deallocated\","},{"line_number":528,"context_line":"                                port_name)"},{"line_number":529,"context_line":"                    continue"},{"line_number":530,"context_line":"                try:"},{"line_number":531,"context_line":"                    self.network_driver.remove_port(port_id)"},{"line_number":532,"context_line":"                except Exception:"},{"line_number":533,"context_line":"                    LOG.exception(\"Failed to deallocate management port %s \""},{"line_number":534,"context_line":"                                  \"from amphora %s\", port_id, amphora_id)"}],"source_content_type":"text/x-python","patch_set":27,"id":"3f4b6375_8244f975","line":534,"range":{"start_line":523,"start_character":0,"end_line":534,"end_character":73},"updated":"2017-10-30 06:52:23.000000000","message":"how about move into 1 try-except block?","commit_id":"6e9fcc3b74af19578c02be7cc875fb9e2cf6535a"},{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"cce8c2a19901849cf9d4476c3054c84d38fb131f","unresolved":false,"context_lines":[{"line_number":520,"context_line":"                      \"id %s\", amphora_id)"},{"line_number":521,"context_line":"            for amp_net in CONF.controller_worker.amp_boot_network_list:"},{"line_number":522,"context_line":"                port_name \u003d self.get_mgmt_port_name(amphora_id, amp_net)"},{"line_number":523,"context_line":"                try:"},{"line_number":524,"context_line":"                    port_id \u003d self.network_driver.get_port_by_name("},{"line_number":525,"context_line":"                        port_name).id"},{"line_number":526,"context_line":"                except base.PortNotFound:"},{"line_number":527,"context_line":"                    LOG.warning(\"Port name %s not found to be deallocated\","},{"line_number":528,"context_line":"                                port_name)"},{"line_number":529,"context_line":"                    continue"},{"line_number":530,"context_line":"                try:"},{"line_number":531,"context_line":"                    self.network_driver.remove_port(port_id)"},{"line_number":532,"context_line":"                except Exception:"},{"line_number":533,"context_line":"                    LOG.exception(\"Failed to deallocate management port %s \""},{"line_number":534,"context_line":"                                  \"from amphora %s\", port_id, amphora_id)"}],"source_content_type":"text/x-python","patch_set":27,"id":"3f4b6375_e826e4ba","line":534,"range":{"start_line":523,"start_character":0,"end_line":534,"end_character":73},"in_reply_to":"3f4b6375_8244f975","updated":"2017-10-30 14:51:25.000000000","message":"I changed the layout according to your suggestion.","commit_id":"6e9fcc3b74af19578c02be7cc875fb9e2cf6535a"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"3ece2c627bf15d37f6496253b3eef59db2caf5b0","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                port_name \u003d utils.get_management_port_name(amphora_id,"},{"line_number":523,"context_line":"                                                           amp_net_id)"},{"line_number":524,"context_line":"                for mp in self.network_driver.get_port_by_name_and_net_id("},{"line_number":525,"context_line":"                    port_name,"},{"line_number":526,"context_line":"                    amp_net_id,"},{"line_number":527,"context_line":"                    unique_item\u003dFalse,"},{"line_number":528,"context_line":"                ):"},{"line_number":529,"context_line":"                    try:"},{"line_number":530,"context_line":"                        self.network_driver.remove_port(mp.id)"}],"source_content_type":"text/x-python","patch_set":49,"id":"df87a7cf_f0e7e545","line":527,"range":{"start_line":525,"start_character":20,"end_line":527,"end_character":38},"updated":"2017-12-14 08:17:29.000000000","message":"add 4 spaces for these","commit_id":"fa74b579349b15fdc4acf1f3f0923ebaf7433945"},{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"71990533246f036ac2c9b370cdb9d7d01a6b5337","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                port_name \u003d utils.get_management_port_name(amphora_id,"},{"line_number":523,"context_line":"                                                           amp_net_id)"},{"line_number":524,"context_line":"                for mp in self.network_driver.get_port_by_name_and_net_id("},{"line_number":525,"context_line":"                    port_name,"},{"line_number":526,"context_line":"                    amp_net_id,"},{"line_number":527,"context_line":"                    unique_item\u003dFalse,"},{"line_number":528,"context_line":"                ):"},{"line_number":529,"context_line":"                    try:"},{"line_number":530,"context_line":"                        self.network_driver.remove_port(mp.id)"}],"source_content_type":"text/x-python","patch_set":49,"id":"df87a7cf_94068820","line":527,"range":{"start_line":525,"start_character":20,"end_line":527,"end_character":38},"in_reply_to":"df87a7cf_f0e7e545","updated":"2017-12-14 12:34:59.000000000","message":"I\u0027m not sure why that would be better. Can you explain?","commit_id":"fa74b579349b15fdc4acf1f3f0923ebaf7433945"}],"octavia/tests/unit/controller/worker/tasks/test_network_tasks.py":[{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"fdcf359cafaeaef1f429a43de6d5887256d6a043","unresolved":false,"context_lines":[{"line_number":40,"context_line":"INTERFACE \u003d data_models.Interface(id\u003duuidutils.generate_uuid(),"},{"line_number":41,"context_line":"                                  compute_id\u003dCOMPUTE_ID, fixed_ips\u003dFIXED_IPS,"},{"line_number":42,"context_line":"                                  port_id\u003dPORT_ID)"},{"line_number":43,"context_line":"AMP_BOOT_NETWORKS \u003d [\"managment_netid\"]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class TestException(Exception):"}],"source_content_type":"text/x-python","patch_set":49,"id":"df87a7cf_7020b54a","line":43,"updated":"2017-12-14 12:17:49.000000000","message":"should be management_netid","commit_id":"fa74b579349b15fdc4acf1f3f0923ebaf7433945"},{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"2fcd07560a5c5748b7e7b5dba9b781d5511473b6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"INTERFACE \u003d data_models.Interface(id\u003duuidutils.generate_uuid(),"},{"line_number":41,"context_line":"                                  compute_id\u003dCOMPUTE_ID, fixed_ips\u003dFIXED_IPS,"},{"line_number":42,"context_line":"                                  port_id\u003dPORT_ID)"},{"line_number":43,"context_line":"AMP_BOOT_NETWORKS \u003d [\"managment_netid\"]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class TestException(Exception):"}],"source_content_type":"text/x-python","patch_set":49,"id":"df87a7cf_ffcfad26","line":43,"in_reply_to":"df87a7cf_5f8ed92e","updated":"2017-12-14 13:17:12.000000000","message":"thanks.","commit_id":"fa74b579349b15fdc4acf1f3f0923ebaf7433945"},{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"71990533246f036ac2c9b370cdb9d7d01a6b5337","unresolved":false,"context_lines":[{"line_number":40,"context_line":"INTERFACE \u003d data_models.Interface(id\u003duuidutils.generate_uuid(),"},{"line_number":41,"context_line":"                                  compute_id\u003dCOMPUTE_ID, fixed_ips\u003dFIXED_IPS,"},{"line_number":42,"context_line":"                                  port_id\u003dPORT_ID)"},{"line_number":43,"context_line":"AMP_BOOT_NETWORKS \u003d [\"managment_netid\"]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class TestException(Exception):"}],"source_content_type":"text/x-python","patch_set":49,"id":"df87a7cf_f42034b3","line":43,"in_reply_to":"df87a7cf_7020b54a","updated":"2017-12-14 12:34:59.000000000","message":"It is meant to be list object.","commit_id":"fa74b579349b15fdc4acf1f3f0923ebaf7433945"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"9aedbab65feabde1209f5fb484aa47c46648cd53","unresolved":false,"context_lines":[{"line_number":40,"context_line":"INTERFACE \u003d data_models.Interface(id\u003duuidutils.generate_uuid(),"},{"line_number":41,"context_line":"                                  compute_id\u003dCOMPUTE_ID, fixed_ips\u003dFIXED_IPS,"},{"line_number":42,"context_line":"                                  port_id\u003dPORT_ID)"},{"line_number":43,"context_line":"AMP_BOOT_NETWORKS \u003d [\"managment_netid\"]"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class TestException(Exception):"}],"source_content_type":"text/x-python","patch_set":49,"id":"df87a7cf_5f8ed92e","line":43,"in_reply_to":"df87a7cf_f42034b3","updated":"2017-12-14 12:50:53.000000000","message":"I think you want to write this [\"management_netid\"]\nSorry I didn\u0027t make myself clear.","commit_id":"fa74b579349b15fdc4acf1f3f0923ebaf7433945"}]}