)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"b71a2597b460b15111a85c1d0cc567117fbf4578","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add availability_zone to the amphora record"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This will enable a number of possible features that need to select"},{"line_number":10,"context_line":"amphorae based on their availability_zone."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8e26f99bca3496a454ba7bae2570f517e07d5fc2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f515b1d_0cbe90b3","line":9,"range":{"start_line":9,"start_character":19,"end_line":9,"end_character":46},"updated":"2017-10-08 19:33:16.000000000","message":"I\u0027m out of office this week but would love to get some examples, in order to provide an in-depth review for this (sounds right overall).","commit_id":"88b2931af39d3be96f78ba11a4f2641566650a03"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"620cd5d870f2d0190ba6c0087b77c97088dd034d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add availability_zone to the amphora record"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This will enable a number of possible features that need to select"},{"line_number":10,"context_line":"amphorae based on their availability_zone."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8e26f99bca3496a454ba7bae2570f517e07d5fc2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f515b1d_868fdb21","line":9,"range":{"start_line":9,"start_character":19,"end_line":9,"end_character":46},"in_reply_to":"7f515b1d_0cbe90b3","updated":"2017-10-09 22:45:32.000000000","message":"Yeah... I wasn\u0027t super specific because I can only think of a couple right now and one of them is internal-only, but I think something like:\n* Being able to build automation based on AZ for admins that want to do reporting/maintenance without querying nova 1000 times\n* Automatically evacuating AZs for maintenance\n* Some stuff I can\u0027t think of right now :P","commit_id":"88b2931af39d3be96f78ba11a4f2641566650a03"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"e4215c122501f3e3a209939ba9136dbebdf3d8e0","unresolved":false,"context_lines":[{"line_number":187,"context_line":"  type: integer"},{"line_number":188,"context_line":"cached-zone:"},{"line_number":189,"context_line":"  description: |"},{"line_number":190,"context_line":"    The availability zone of a compute instance."},{"line_number":191,"context_line":"  in: body"},{"line_number":192,"context_line":"  required: true"},{"line_number":193,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f4b6375_984a45aa","line":190,"updated":"2017-10-27 18:27:23.000000000","message":"The (availability) zone of a compute instance for scheduling.","commit_id":"28d0536e15dc504ce60bd4894a21e663c7bc584f"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"cf40c6a96b70381bd6522097f1d42c5e7ab9dde0","unresolved":false,"context_lines":[{"line_number":187,"context_line":"  type: integer"},{"line_number":188,"context_line":"cached-zone:"},{"line_number":189,"context_line":"  description: |"},{"line_number":190,"context_line":"    The availability zone of a compute instance."},{"line_number":191,"context_line":"  in: body"},{"line_number":192,"context_line":"  required: true"},{"line_number":193,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f4b6375_0e028c3f","line":190,"in_reply_to":"3f4b6375_0ed96cf3","updated":"2017-10-27 22:20:43.000000000","message":"works","commit_id":"28d0536e15dc504ce60bd4894a21e663c7bc584f"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"50805dab94ec410049d16967f4b2b94b7682eedc","unresolved":false,"context_lines":[{"line_number":187,"context_line":"  type: integer"},{"line_number":188,"context_line":"cached-zone:"},{"line_number":189,"context_line":"  description: |"},{"line_number":190,"context_line":"    The availability zone of a compute instance."},{"line_number":191,"context_line":"  in: body"},{"line_number":192,"context_line":"  required: true"},{"line_number":193,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f4b6375_0ed96cf3","line":190,"in_reply_to":"3f4b6375_984a45aa","updated":"2017-10-27 22:14:22.000000000","message":"How about \"The (availability) zone of a compute instance, cached at create time. This is not guaranteed to be current.\"","commit_id":"28d0536e15dc504ce60bd4894a21e663c7bc584f"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"e4215c122501f3e3a209939ba9136dbebdf3d8e0","unresolved":false,"context_lines":[{"line_number":189,"context_line":"  description: |"},{"line_number":190,"context_line":"    The availability zone of a compute instance."},{"line_number":191,"context_line":"  in: body"},{"line_number":192,"context_line":"  required: true"},{"line_number":193,"context_line":"  type: string"},{"line_number":194,"context_line":"cert-busy:"},{"line_number":195,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f4b6375_58ca8d1a","line":192,"updated":"2017-10-27 18:27:23.000000000","message":"can we not require that for system which don\u0027t have the AZ extension enabled?","commit_id":"28d0536e15dc504ce60bd4894a21e663c7bc584f"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"50805dab94ec410049d16967f4b2b94b7682eedc","unresolved":false,"context_lines":[{"line_number":189,"context_line":"  description: |"},{"line_number":190,"context_line":"    The availability zone of a compute instance."},{"line_number":191,"context_line":"  in: body"},{"line_number":192,"context_line":"  required: true"},{"line_number":193,"context_line":"  type: string"},{"line_number":194,"context_line":"cert-busy:"},{"line_number":195,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f4b6375_6eca201b","line":192,"in_reply_to":"3f4b6375_58ca8d1a","updated":"2017-10-27 22:14:22.000000000","message":"This is only output, not input -- the \"required\" field here is just due to the way these params are formatted. If we change it to \"false\" it\u0027ll put \"(optional)\" next to it in the docs, but it\u0027s *output*, so it will always be there... Just possibly empty.","commit_id":"28d0536e15dc504ce60bd4894a21e663c7bc584f"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"cf40c6a96b70381bd6522097f1d42c5e7ab9dde0","unresolved":false,"context_lines":[{"line_number":189,"context_line":"  description: |"},{"line_number":190,"context_line":"    The availability zone of a compute instance."},{"line_number":191,"context_line":"  in: body"},{"line_number":192,"context_line":"  required: true"},{"line_number":193,"context_line":"  type: string"},{"line_number":194,"context_line":"cert-busy:"},{"line_number":195,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f4b6375_2eed488b","line":192,"in_reply_to":"3f4b6375_6eca201b","updated":"2017-10-27 22:20:43.000000000","message":"not sure. I like to show it\u0027s optional for the people who don\u0027t have the AZ extension...","commit_id":"28d0536e15dc504ce60bd4894a21e663c7bc584f"}],"octavia/compute/drivers/nova_driver.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6ef2e907bac53e655e45914d562150215d1351de","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            try:"},{"line_number":234,"context_line":"                availability_zone \u003d getattr("},{"line_number":235,"context_line":"                    nova_response, \u0027OS-EXT-AZ:availability_zone\u0027)"},{"line_number":236,"context_line":"            except AttributeError:"},{"line_number":237,"context_line":"                LOG.warning(\u0027No availability zone listed for server %s\u0027,"},{"line_number":238,"context_line":"                            nova_response.id)"},{"line_number":239,"context_line":"            fault \u003d getattr(nova_response, \u0027fault\u0027, None)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4b6375_bbd486ea","line":236,"updated":"2017-10-31 23:46:21.000000000","message":"This exception path does not have a test.","commit_id":"1c0bf468d5ab3de82c9ce9f6c1ca2436ecc9b424"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"e9c9db436f6df7894ab7de7c95f49e54755684e8","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            try:"},{"line_number":234,"context_line":"                availability_zone \u003d getattr("},{"line_number":235,"context_line":"                    nova_response, \u0027OS-EXT-AZ:availability_zone\u0027)"},{"line_number":236,"context_line":"            except AttributeError:"},{"line_number":237,"context_line":"                LOG.warning(\u0027No availability zone listed for server %s\u0027,"},{"line_number":238,"context_line":"                            nova_response.id)"},{"line_number":239,"context_line":"            fault \u003d getattr(nova_response, \u0027fault\u0027, None)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4b6375_7b972eed","line":236,"in_reply_to":"3f4b6375_bbd486ea","updated":"2017-10-31 23:55:26.000000000","message":"I\u0027ll have to look into how to test this.","commit_id":"1c0bf468d5ab3de82c9ce9f6c1ca2436ecc9b424"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"daa40ec00b87b15e8ef87ef81d8956e12df4674f","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                availability_zone \u003d getattr("},{"line_number":235,"context_line":"                    nova_response, \u0027OS-EXT-AZ:availability_zone\u0027)"},{"line_number":236,"context_line":"            except AttributeError:"},{"line_number":237,"context_line":"                LOG.warning(\u0027No availability zone listed for server %s\u0027,"},{"line_number":238,"context_line":"                            nova_response.id)"},{"line_number":239,"context_line":"            fault \u003d getattr(nova_response, \u0027fault\u0027, None)"},{"line_number":240,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4b6375_7bdf2e0c","line":237,"range":{"start_line":237,"start_character":20,"end_line":237,"end_character":27},"updated":"2017-10-31 23:43:36.000000000","message":"Does this need to be a warning?\nInfo or debug?","commit_id":"1c0bf468d5ab3de82c9ce9f6c1ca2436ecc9b424"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"e9c9db436f6df7894ab7de7c95f49e54755684e8","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                availability_zone \u003d getattr("},{"line_number":235,"context_line":"                    nova_response, \u0027OS-EXT-AZ:availability_zone\u0027)"},{"line_number":236,"context_line":"            except AttributeError:"},{"line_number":237,"context_line":"                LOG.warning(\u0027No availability zone listed for server %s\u0027,"},{"line_number":238,"context_line":"                            nova_response.id)"},{"line_number":239,"context_line":"            fault \u003d getattr(nova_response, \u0027fault\u0027, None)"},{"line_number":240,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4b6375_5be9127e","line":237,"range":{"start_line":237,"start_character":20,"end_line":237,"end_character":27},"in_reply_to":"3f4b6375_7bdf2e0c","updated":"2017-10-31 23:55:26.000000000","message":"I guess INFO would be OK since it\u0027s possible this extension isn\u0027t available, and it\u0027s not actually a problem. I\u0027ll change this.","commit_id":"1c0bf468d5ab3de82c9ce9f6c1ca2436ecc9b424"}],"octavia/db/migration/alembic_migrations/versions/bf171d0d91c3_amphora_add_availability_zone.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"da1d2af66c64e45eecc37757449207f46e66a3d5","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def upgrade():"},{"line_number":32,"context_line":"    op.add_column(u\u0027amphora\u0027, sa.Column(u\u0027availability_zone\u0027, sa.String(255),"},{"line_number":33,"context_line":"                                        nullable\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_21101900","line":32,"range":{"start_line":32,"start_character":42,"end_line":32,"end_character":59},"updated":"2017-10-09 17:50:35.000000000","message":"Do you think we should call this \"compute_availability_zone\" or \"compute_AZ\"?\nIt would match the compute_id.\nWould we have internal amphora AZs at some point?","commit_id":"88b2931af39d3be96f78ba11a4f2641566650a03"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"620cd5d870f2d0190ba6c0087b77c97088dd034d","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def upgrade():"},{"line_number":32,"context_line":"    op.add_column(u\u0027amphora\u0027, sa.Column(u\u0027availability_zone\u0027, sa.String(255),"},{"line_number":33,"context_line":"                                        nullable\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_26b707f8","line":32,"range":{"start_line":32,"start_character":42,"end_line":32,"end_character":59},"in_reply_to":"7f515b1d_21101900","updated":"2017-10-09 22:45:32.000000000","message":"I honestly think it\u0027s fine as \"availability_zone\", I don\u0027t believe it is something specific to Nova, and if anything doesn\u0027t need it then it can be left as NULL and no big deal.","commit_id":"88b2931af39d3be96f78ba11a4f2641566650a03"}]}