)]}'
{"diskimage-create/diskimage-create.sh":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"a1e0aff79066c78d1d23130f67df52a2d873b641","unresolved":false,"context_lines":[{"line_number":364,"context_line":""},{"line_number":365,"context_line":"# Disable DHCP if requested"},{"line_number":366,"context_line":"if [ \"$AMP_DISABLE_DHCP\" -eq 1 ]; then"},{"line_number":367,"context_line":"    export DIB_BOOTLOADER_DEFAULT_CMDLINE\u003d\"net.ifnames\u003d0 biosdevname\u003d0 nofb nomodeset vga\u003dnormal\""},{"line_number":368,"context_line":"    AMP_element_sequence\u003d\"$AMP_element_sequence disable-dhcp\""},{"line_number":369,"context_line":"fi"},{"line_number":370,"context_line":""}],"source_content_type":"text/x-sh","patch_set":9,"id":"df7087c5_843e50d8","line":367,"updated":"2018-03-09 08:58:35.000000000","message":"Actually I\u0027m not 100% sure about this line... Is there a way we can just tweak the existing default rather than define it explicitly here? I wonder if some of these settings change things that aren\u0027t totally required by this patch...","commit_id":"fce17f6a180c6be05b1a075c6c8f073faa173ad2"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"9258fcfcaf481420e8edfef0748147a230312ec1","unresolved":false,"context_lines":[{"line_number":364,"context_line":""},{"line_number":365,"context_line":"# Disable DHCP if requested"},{"line_number":366,"context_line":"if [ \"$AMP_DISABLE_DHCP\" -eq 1 ]; then"},{"line_number":367,"context_line":"    export DIB_BOOTLOADER_DEFAULT_CMDLINE\u003d\"net.ifnames\u003d0 biosdevname\u003d0 nofb nomodeset vga\u003dnormal\""},{"line_number":368,"context_line":"    AMP_element_sequence\u003d\"$AMP_element_sequence disable-dhcp\""},{"line_number":369,"context_line":"fi"},{"line_number":370,"context_line":""}],"source_content_type":"text/x-sh","patch_set":9,"id":"df7087c5_0dfedc36","line":367,"in_reply_to":"df7087c5_843e50d8","updated":"2018-03-09 15:08:56.000000000","message":"https://wiki.centos.org/FAQ/CentOS7#head-31ebc6642958a0df12304d6aab9a49034a3b7802\n\nThis is required by ubuntu 16.04 and maybe some of the redhat distributions\n\nWhether we can just tweak the existing default, that I really don\u0027t know.","commit_id":"fce17f6a180c6be05b1a075c6c8f073faa173ad2"}],"elements/disable-dhcp/post-install.d/99-disable-dhcp":[{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"1ea1ed55263497d5e998813731963d6bf4f84c76","unresolved":false,"context_lines":[{"line_number":9,"context_line":"echo \"network: {config: disabled}\" \u003e /etc/cloud/cloud.cfg.d/99-disable-network-config.cfg"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"case \"$DISTRO_NAME\" in"},{"line_number":12,"context_line":"    \u0027fedora\u0027|\u0027centos\u0027|\u0027centos7\u0027|\u0027opensuse\u0027)"},{"line_number":13,"context_line":"    # turn off DHCP for eth0 (centos)"},{"line_number":14,"context_line":"    if [ -f /etc/sysconfig/network-scripts/ifcfg-eth0 ]; then"},{"line_number":15,"context_line":"        sed -i \u0027s/PERSISTENT_DHCLIENT\u003d\"1\"/PERSISTENT_DHCLIENT\u003d\"0\"/\u0027 /etc/sysconfig/network-scripts/ifcfg-eth0"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"df87a7cf_23d75226","line":12,"range":{"start_line":12,"start_character":5,"end_line":12,"end_character":41},"updated":"2017-12-13 20:13:50.000000000","message":"what about rhel7?","commit_id":"937f1cb64fcf49bcf6257c7ed9ed184f69d3150d"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"da32de135532e5c1019916221d19127743f18e26","unresolved":false,"context_lines":[{"line_number":9,"context_line":"echo \"network: {config: disabled}\" \u003e /etc/cloud/cloud.cfg.d/99-disable-network-config.cfg"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"case \"$DISTRO_NAME\" in"},{"line_number":12,"context_line":"    \u0027fedora\u0027|\u0027centos\u0027|\u0027centos7\u0027|\u0027opensuse\u0027)"},{"line_number":13,"context_line":"    # turn off DHCP for eth0 (centos)"},{"line_number":14,"context_line":"    if [ -f /etc/sysconfig/network-scripts/ifcfg-eth0 ]; then"},{"line_number":15,"context_line":"        sed -i \u0027s/PERSISTENT_DHCLIENT\u003d\"1\"/PERSISTENT_DHCLIENT\u003d\"0\"/\u0027 /etc/sysconfig/network-scripts/ifcfg-eth0"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"df87a7cf_119a98c4","line":12,"range":{"start_line":12,"start_character":5,"end_line":12,"end_character":41},"in_reply_to":"df87a7cf_23d75226","updated":"2017-12-13 21:36:07.000000000","message":"Done","commit_id":"937f1cb64fcf49bcf6257c7ed9ed184f69d3150d"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"9948528f4560e1fea040466edfba5025f1c7e7e7","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set -eu"},{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"echo \"network: {config: disabled}\" \u003e /etc/cloud/cloud.cfg.d/99-disable-network-config.cfg"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"case \"$DISTRO_NAME\" in"},{"line_number":12,"context_line":"    \u0027fedora\u0027|\u0027rhel\u0027|\u0027rhel7\u0027|\u0027centos\u0027|\u0027centos7\u0027|\u0027opensuse\u0027)"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"df87a7cf_42cfcb7e","line":9,"updated":"2017-12-15 02:58:34.000000000","message":"Here cloud init networking is disabled, so it will not generate any networking files overwritten something else.","commit_id":"71d98a2f967a23e1f4d79291286a7c23a0db0ee4"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"2147fc8c0d8290d3d7fe69e7889be85d9f390f85","unresolved":false,"context_lines":[{"line_number":15,"context_line":"        sed -i \u0027s/PERSISTENT_DHCLIENT\u003d\"1\"/PERSISTENT_DHCLIENT\u003d\"0\"/\u0027 /etc/sysconfig/network-scripts/ifcfg-eth0"},{"line_number":16,"context_line":"        sed -i \u0027s/PEERDNS\u003d\"yes\"/PEERDNS\u003d\"no\"/\u0027 /etc/sysconfig/network-scripts/ifcfg-eth0"},{"line_number":17,"context_line":"        sed -i \u0027s/BOOTPROTO\u003d\"dhcp\"/BOOTPROTO\u003d\"none\"/\u0027 /etc/sysconfig/network-scripts/ifcfg-eth0"},{"line_number":18,"context_line":"        sed -i \u0027s/ONBOOT\u003d\"yes\"/ONBOOT\u003d\"no\"/\u0027 /etc/sysconfig/network-scripts/ifcfg-eth0"},{"line_number":19,"context_line":"    fi"},{"line_number":20,"context_line":"    ;;"},{"line_number":21,"context_line":"    \u0027ubuntu\u0027|\u0027debian\u0027)"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"5f7c97a3_62b95613","line":18,"range":{"start_line":18,"start_character":9,"end_line":18,"end_character":86},"updated":"2018-05-27 17:58:34.000000000","message":"why would you want to completely disable this device on boot time?\nWon\u0027t that prevent any use of that NIC?\n\nSee: https://www.centos.org/docs/rhel-rg-en-3/s1-networkscripts-interfaces.html","commit_id":"ba0c98fe0340632fe6634c1d3e2227c2ad6aa0a8"}]}