)]}'
{"api-ref/source/parameters.yaml":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":283,"context_line":"  in: body"},{"line_number":284,"context_line":"  required: false"},{"line_number":285,"context_line":"  type: string"},{"line_number":286,"context_line":"frontend-id:"},{"line_number":287,"context_line":"  description: |"},{"line_number":288,"context_line":"    The frontend group\u0027s ID for the amphora."},{"line_number":289,"context_line":"  in: body"},{"line_number":290,"context_line":"  required: true"},{"line_number":291,"context_line":"  type: string"},{"line_number":292,"context_line":"frontend-interface:"},{"line_number":293,"context_line":"  description: |"},{"line_number":294,"context_line":"    The bound interface name of the frontend port on the amphora."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"bf8cb3f7_f5237abd","line":291,"range":{"start_line":286,"start_character":0,"end_line":291,"end_character":14},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":307,"context_line":"  in: body"},{"line_number":308,"context_line":"  required: true"},{"line_number":309,"context_line":"  type: string"},{"line_number":310,"context_line":"frontend-priority:"},{"line_number":311,"context_line":"  description: |"},{"line_number":312,"context_line":"    The priority of the amphora in the frontend group."},{"line_number":313,"context_line":"  in: body"},{"line_number":314,"context_line":"  required: true"},{"line_number":315,"context_line":"  type: string"},{"line_number":316,"context_line":"healthmonitor-delay:"},{"line_number":317,"context_line":"  description: |"},{"line_number":318,"context_line":"    The time, in seconds, between sending probes to members."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"bf8cb3f7_7519aa86","line":315,"range":{"start_line":310,"start_character":0,"end_line":315,"end_character":14},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"}],"api-ref/source/v2/amphora.inc":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":64,"context_line":"   - role: amphora-role"},{"line_number":65,"context_line":"   - status: amphora-status"},{"line_number":66,"context_line":"   - frontend_interface: frontend-interface"},{"line_number":67,"context_line":"   - frontend_id: frontend-id"},{"line_number":68,"context_line":"   - frontend_priority: frontend-priority"},{"line_number":69,"context_line":"   - cached_zone: cached-zone"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"bf8cb3f7_951eae6e","line":68,"range":{"start_line":67,"start_character":0,"end_line":68,"end_character":41},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":135,"context_line":"   - role: amphora-role"},{"line_number":136,"context_line":"   - status: amphora-status"},{"line_number":137,"context_line":"   - frontend_interface: frontend-interface"},{"line_number":138,"context_line":"   - frontend_id: frontend-id"},{"line_number":139,"context_line":"   - frontend_priority: frontend-priority"},{"line_number":140,"context_line":"   - cached_zone: cached-zone"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":15,"id":"bf8cb3f7_35132269","line":139,"range":{"start_line":138,"start_character":0,"end_line":139,"end_character":41},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"}],"api-ref/source/v2/examples/amphora-list-response.json":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"            \"role\": \"MASTER\","},{"line_number":15,"context_line":"            \"status\": \"ALLOCATED\","},{"line_number":16,"context_line":"            \"frontend_interface\": \"eth1\","},{"line_number":17,"context_line":"            \"frontend_id\": 1,"},{"line_number":18,"context_line":"            \"frontend_priority\": 100,"},{"line_number":19,"context_line":"            \"cached_zone\": \"zone1\""},{"line_number":20,"context_line":"        },"},{"line_number":21,"context_line":"        {"}],"source_content_type":"application/json","patch_set":15,"id":"bf8cb3f7_150a9e25","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":37},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            \"role\": \"BACKUP\","},{"line_number":33,"context_line":"            \"status\": \"ALLOCATED\","},{"line_number":34,"context_line":"            \"frontend_interface\": \"eth1\","},{"line_number":35,"context_line":"            \"frontend_id\": 1,"},{"line_number":36,"context_line":"            \"frontend_priority\": 200,"},{"line_number":37,"context_line":"            \"cached_zone\": \"zone2\""},{"line_number":38,"context_line":"        }"},{"line_number":39,"context_line":"    ]"}],"source_content_type":"application/json","patch_set":15,"id":"bf8cb3f7_d503d60e","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":37},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"}],"api-ref/source/v2/examples/amphora-show-response.json":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        \"role\": \"MASTER\","},{"line_number":14,"context_line":"        \"status\": \"ALLOCATED\","},{"line_number":15,"context_line":"        \"frontend_interface\": \"eth1\","},{"line_number":16,"context_line":"        \"frontend_id\": 1,"},{"line_number":17,"context_line":"        \"frontend_priority\": 100,"},{"line_number":18,"context_line":"        \"cached_zone\": \"zone1\""},{"line_number":19,"context_line":"    }"},{"line_number":20,"context_line":"}"}],"source_content_type":"application/json","patch_set":15,"id":"bf8cb3f7_a703890d","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":33},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"}],"octavia/amphorae/backends/agent/api_server/osutils.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"00fbb49194f8e8460abb9ba2468caab14a50e99c","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                gateway\u003dgateway,"},{"line_number":104,"context_line":"                mtu\u003dmtu,"},{"line_number":105,"context_line":"                frontend_ip\u003dfrontend_ip,"},{"line_number":106,"context_line":"                vrrp_ipv6\u003dvrrp_version is 6,"},{"line_number":107,"context_line":"                host_routes\u003drender_host_routes,"},{"line_number":108,"context_line":"            )"},{"line_number":109,"context_line":"            text_file.write(text)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff82abbf_f63f3d84","line":106,"updated":"2017-11-28 19:07:15.000000000","message":"This needs updated as you updated the template for it.","commit_id":"c487e4354751158d8be2e32de4cf4e1767070a8b"}],"octavia/amphorae/backends/agent/api_server/plug.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"4a7f615cee51258c8d0a8740597bf829e1ae424a","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            netmask\u003dnetmask,"},{"line_number":112,"context_line":"            gateway\u003dgateway,"},{"line_number":113,"context_line":"            mtu\u003dmtu,"},{"line_number":114,"context_line":"            vrrp_ip\u003dfrontend_ip,"},{"line_number":115,"context_line":"            vrrp_version\u003dvrrp_version,"},{"line_number":116,"context_line":"            render_host_routes\u003drender_host_routes)"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_dad11efd","line":114,"updated":"2017-11-27 18:59:49.000000000","message":"shouldn\u0027t we try to replace that, too?","commit_id":"07fab655bdf94aa9f792b6e08e78d609f0126f70"}],"octavia/amphorae/backends/agent/api_server/templates/plug_vip_ethX.conf.j2":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"30c6dd1b311e93d59afbf11c6de32327efc291b2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# Generated by Octavia agent"},{"line_number":18,"context_line":"auto {{ interface }} {{ interface }}:0"},{"line_number":19,"context_line":"{%- if frontend_ip %}"},{"line_number":20,"context_line":"iface {{ interface }} inet{{ \u00276\u0027 if frontend_ipv6 }} static"},{"line_number":21,"context_line":"address {{ frontend_ip }}"},{"line_number":22,"context_line":"broadcast {{ broadcast }}"},{"line_number":23,"context_line":"netmask {{ netmask }}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"ff82abbf_f6589dfa","line":20,"range":{"start_line":20,"start_character":36,"end_line":20,"end_character":49},"updated":"2017-11-28 19:08:41.000000000","message":"This got changed, so the code must also change.","commit_id":"c487e4354751158d8be2e32de4cf4e1767070a8b"}],"octavia/amphorae/backends/agent/api_server/templates/rh_plug_vip_ethX.conf.j2":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"527c63d2e9f0cd5e8ffb391b1b1a0ebc6e4adb05","unresolved":false,"context_lines":[{"line_number":21,"context_line":"USERCTL\u003d\"yes\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{%- if frontend_ip %}"},{"line_number":24,"context_line":"{%- if frontend_ipv6 %}"},{"line_number":25,"context_line":"IPV6INIT\u003d\"yes\""},{"line_number":26,"context_line":"IPV6_DEFROUTE\u003d\"yes\""},{"line_number":27,"context_line":"IPV6_AUTOCONF\u003d\"no\""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"ff82abbf_d671d977","line":24,"range":{"start_line":24,"start_character":7,"end_line":24,"end_character":20},"updated":"2017-11-28 19:09:01.000000000","message":"Same here","commit_id":"c487e4354751158d8be2e32de4cf4e1767070a8b"}],"octavia/amphorae/drivers/haproxy/rest_api_driver.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"d30a58384204882074c1b69879917d9becd8ba47","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            net_info \u003d {\u0027subnet_cidr\u0027: subnet.cidr,"},{"line_number":129,"context_line":"                        \u0027gateway\u0027: subnet.gateway_ip,"},{"line_number":130,"context_line":"                        \u0027mac_address\u0027: port.mac_address,"},{"line_number":131,"context_line":"                        \u0027vrrp_ip\u0027: amphora.frontend_ip,"},{"line_number":132,"context_line":"                        \u0027mtu\u0027: port.network.mtu,"},{"line_number":133,"context_line":"                        \u0027host_routes\u0027: host_routes}"},{"line_number":134,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_3f16fc56","line":131,"updated":"2017-11-27 18:30:47.000000000","message":"shouldn\u0027t we rename that as well?","commit_id":"07fab655bdf94aa9f792b6e08e78d609f0126f70"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"9ee285b62585dbb34a6743a0d0feec364021451a","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                        \u0027gateway\u0027: subnet.gateway_ip,"},{"line_number":130,"context_line":"                        \u0027mac_address\u0027: port.mac_address,"},{"line_number":131,"context_line":"                        \u0027frontend_ip\u0027: amphora.frontend_ip,"},{"line_number":132,"context_line":"                        # deprecated - maintained for backward compatibility"},{"line_number":133,"context_line":"                        \u0027vrrp_ip\u0027: amphora.frontend_ip,"},{"line_number":134,"context_line":"                        \u0027mtu\u0027: port.network.mtu,"},{"line_number":135,"context_line":"                        \u0027host_routes\u0027: host_routes}"}],"source_content_type":"text/x-python","patch_set":14,"id":"df87a7cf_ea56892a","line":132,"updated":"2017-12-08 19:27:09.000000000","message":"You should do the comment in this format (mention your name as a TODO, and the cycle it was deprecated so we know when we can remove it):\n\n# TODO(sanfern): Deprecated in Queens, maintained for backwards compatability","commit_id":"01421a493773475f99849ea4f13fd65248b537b8"}],"octavia/amphorae/drivers/keepalived/jinja/jinja_cfg.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            if amp.frontend_ip !\u003d amphora.frontend_ip:"},{"line_number":74,"context_line":"                peers_ips.append(amp.frontend_ip)"},{"line_number":75,"context_line":"        return self.get_template(self.keepalived_template).render("},{"line_number":76,"context_line":"            {\u0027frontend_group_name\u0027:"},{"line_number":77,"context_line":"                loadbalancer.frontend_group.frontend_group_name,"},{"line_number":78,"context_line":"             \u0027amp_role\u0027: amphora.role,"},{"line_number":79,"context_line":"             \u0027amp_intf\u0027: amphora.frontend_interface,"},{"line_number":80,"context_line":"             \u0027amp_frontend_id\u0027: amphora.frontend_id,"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_47563d09","line":77,"range":{"start_line":76,"start_character":13,"end_line":77,"end_character":64},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                loadbalancer.frontend_group.frontend_group_name,"},{"line_number":78,"context_line":"             \u0027amp_role\u0027: amphora.role,"},{"line_number":79,"context_line":"             \u0027amp_intf\u0027: amphora.frontend_interface,"},{"line_number":80,"context_line":"             \u0027amp_frontend_id\u0027: amphora.frontend_id,"},{"line_number":81,"context_line":"             \u0027amp_priority\u0027: amphora.frontend_priority,"},{"line_number":82,"context_line":"             \u0027vrrp_garp_refresh\u0027:"},{"line_number":83,"context_line":"                 CONF.keepalived_vrrp.vrrp_garp_refresh_interval,"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_675b412e","line":80,"range":{"start_line":80,"start_character":14,"end_line":80,"end_character":52},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":78,"context_line":"             \u0027amp_role\u0027: amphora.role,"},{"line_number":79,"context_line":"             \u0027amp_intf\u0027: amphora.frontend_interface,"},{"line_number":80,"context_line":"             \u0027amp_frontend_id\u0027: amphora.frontend_id,"},{"line_number":81,"context_line":"             \u0027amp_priority\u0027: amphora.frontend_priority,"},{"line_number":82,"context_line":"             \u0027vrrp_garp_refresh\u0027:"},{"line_number":83,"context_line":"                 CONF.keepalived_vrrp.vrrp_garp_refresh_interval,"},{"line_number":84,"context_line":"             \u0027vrrp_garp_refresh_repeat\u0027:"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_273d39bb","line":81,"range":{"start_line":81,"start_character":29,"end_line":81,"end_character":55},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":90,"context_line":"             \u0027amp_frontend_ip\u0027: amphora.frontend_ip,"},{"line_number":91,"context_line":"             \u0027peers_vrrp_ips\u0027: peers_ips,"},{"line_number":92,"context_line":"             \u0027vip_ip_address\u0027: loadbalancer.vip.ip_address,"},{"line_number":93,"context_line":"             \u0027advert_int\u0027: loadbalancer.frontend_group.advert_int,"},{"line_number":94,"context_line":"             \u0027check_script_path\u0027: util.keepalived_check_script_path(),"},{"line_number":95,"context_line":"             \u0027vrrp_check_interval\u0027:"},{"line_number":96,"context_line":"                 CONF.keepalived_vrrp.vrrp_check_interval,"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_c749ed60","line":93,"range":{"start_line":93,"start_character":40,"end_line":93,"end_character":54},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":92,"context_line":"             \u0027vip_ip_address\u0027: loadbalancer.vip.ip_address,"},{"line_number":93,"context_line":"             \u0027advert_int\u0027: loadbalancer.frontend_group.advert_int,"},{"line_number":94,"context_line":"             \u0027check_script_path\u0027: util.keepalived_check_script_path(),"},{"line_number":95,"context_line":"             \u0027vrrp_check_interval\u0027:"},{"line_number":96,"context_line":"                 CONF.keepalived_vrrp.vrrp_check_interval,"},{"line_number":97,"context_line":"             \u0027vrrp_fail_count\u0027: CONF.keepalived_vrrp.vrrp_fail_count,"},{"line_number":98,"context_line":"             \u0027vrrp_success_count\u0027:"},{"line_number":99,"context_line":"                 CONF.keepalived_vrrp.vrrp_success_count},"},{"line_number":100,"context_line":"            constants\u003dconstants)"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_c7900d99","line":99,"range":{"start_line":95,"start_character":13,"end_line":99,"end_character":58},"updated":"2017-12-20 18:39:01.000000000","message":"These VRRP specific settings were maintained, but others were changed to \"frontend\".  I think the other VRRP/keepalived specific settings should be maintained as \"vrrp\" and only the IP/port related elements changed to \"frontend\".","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"}],"octavia/amphorae/drivers/keepalived/jinja/templates/keepalived_base.template":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  rise {{ vrrp_success_count }}"},{"line_number":21,"context_line":"}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"vrrp_instance {{ frontend_group_name }} {"},{"line_number":24,"context_line":"  state {{ amp_role }}"},{"line_number":25,"context_line":"  interface {{ amp_intf }}"},{"line_number":26,"context_line":"  virtual_router_id {{ amp_frontend_id }}"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"bf8cb3f7_07dcb572","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":41},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":23,"context_line":"vrrp_instance {{ frontend_group_name }} {"},{"line_number":24,"context_line":"  state {{ amp_role }}"},{"line_number":25,"context_line":"  interface {{ amp_intf }}"},{"line_number":26,"context_line":"  virtual_router_id {{ amp_frontend_id }}"},{"line_number":27,"context_line":"  priority {{ amp_priority }}"},{"line_number":28,"context_line":"  nopreempt"},{"line_number":29,"context_line":"  garp_master_refresh {{ vrrp_garp_refresh }}"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"bf8cb3f7_27d9b982","line":26,"range":{"start_line":26,"start_character":1,"end_line":26,"end_character":41},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  garp_master_refresh_repeat {{ vrrp_garp_refresh_repeat }}"},{"line_number":31,"context_line":"  advert_int {{ advert_int }}"},{"line_number":32,"context_line":"  authentication {"},{"line_number":33,"context_line":"    auth_type {{ frontend_auth_type }}"},{"line_number":34,"context_line":"    auth_pass {{ frontend_auth_pass }}"},{"line_number":35,"context_line":"  }"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  unicast_src_ip {{ amp_frontend_ip }}"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"bf8cb3f7_c7e56d3a","line":34,"range":{"start_line":33,"start_character":4,"end_line":34,"end_character":38},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  unicast_src_ip {{ amp_frontend_ip }}"},{"line_number":38,"context_line":"  unicast_peer {"},{"line_number":39,"context_line":"{% for amp_frontend_ip in peers_vrrp_ips %}"},{"line_number":40,"context_line":"    {{ amp_frontend_ip }}"},{"line_number":41,"context_line":"{% endfor %}"},{"line_number":42,"context_line":"  }"},{"line_number":43,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":15,"id":"bf8cb3f7_27c21987","line":40,"range":{"start_line":39,"start_character":7,"end_line":40,"end_character":22},"updated":"2017-12-20 18:39:01.000000000","message":"This is slightly confusing and misleading.  Can we revert this to the amp_vrrp_ip?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"}],"octavia/amphorae/drivers/keepalived/vrrp_rest_driver.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"            self.client.reload_vrrp(amp)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def get_vrrp_interface(self, amphora):"},{"line_number":94,"context_line":"        return self.client.get_interface("},{"line_number":95,"context_line":"            amphora, amphora.frontend_ip)[\u0027interface\u0027]"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_c7e32da4","line":93,"range":{"start_line":93,"start_character":8,"end_line":93,"end_character":26},"updated":"2017-12-20 18:39:01.000000000","message":"Should this change to frontend?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"}],"octavia/api/v2/types/amphora.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    role \u003d wtypes.wsattr(wtypes.StringType())"},{"line_number":38,"context_line":"    status \u003d wtypes.wsattr(wtypes.StringType())"},{"line_number":39,"context_line":"    frontend_interface \u003d wtypes.wsattr(wtypes.StringType())"},{"line_number":40,"context_line":"    frontend_id \u003d wtypes.wsattr(wtypes.IntegerType())"},{"line_number":41,"context_line":"    frontend_priority \u003d wtypes.wsattr(wtypes.IntegerType())"},{"line_number":42,"context_line":"    cached_zone \u003d wtypes.wsattr(wtypes.StringType())"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_2700d934","line":41,"range":{"start_line":40,"start_character":4,"end_line":41,"end_character":59},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"e6ba5b9c8d4b1be4f10bdab8b38ed9900bf97134","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    role \u003d wtypes.wsattr(wtypes.StringType())"},{"line_number":38,"context_line":"    status \u003d wtypes.wsattr(wtypes.StringType())"},{"line_number":39,"context_line":"    frontend_interface \u003d wtypes.wsattr(wtypes.StringType())"},{"line_number":40,"context_line":"    frontend_id \u003d wtypes.wsattr(wtypes.IntegerType())"},{"line_number":41,"context_line":"    frontend_priority \u003d wtypes.wsattr(wtypes.IntegerType())"},{"line_number":42,"context_line":"    cached_zone \u003d wtypes.wsattr(wtypes.StringType())"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":15,"id":"3fa0c359_0090a649","line":41,"range":{"start_line":40,"start_character":4,"end_line":41,"end_character":59},"in_reply_to":"bf8cb3f7_2700d934","updated":"2018-02-20 19:17:35.000000000","message":"Yeah this has nothing to do with frontend, AFAIU...","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"}],"octavia/common/data_models.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            return obj.__class__.__name__ + obj.pool_id"},{"line_number":95,"context_line":"        elif obj.__class__.__name__ in [\u0027ListenerStatistics\u0027]:"},{"line_number":96,"context_line":"            return obj.__class__.__name__ + obj.listener_id + obj.amphora_id"},{"line_number":97,"context_line":"        elif obj.__class__.__name__ in [\u0027FrontendGroup\u0027, \u0027Vip\u0027]:"},{"line_number":98,"context_line":"            return obj.__class__.__name__ + obj.load_balancer_id"},{"line_number":99,"context_line":"        elif obj.__class__.__name__ in [\u0027AmphoraHealth\u0027]:"},{"line_number":100,"context_line":"            return obj.__class__.__name__ + obj.amphora_id"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_e7f9914d","line":97,"range":{"start_line":97,"start_character":41,"end_line":97,"end_character":54},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":411,"context_line":"    def __init__(self, id\u003dNone, project_id\u003dNone, name\u003dNone, description\u003dNone,"},{"line_number":412,"context_line":"                 provisioning_status\u003dNone, operating_status\u003dNone, enabled\u003dNone,"},{"line_number":413,"context_line":"                 topology\u003dNone, vip\u003dNone, listeners\u003dNone, amphorae\u003dNone,"},{"line_number":414,"context_line":"                 pools\u003dNone, frontend_group\u003dNone, server_group_id\u003dNone,"},{"line_number":415,"context_line":"                 created_at\u003dNone, updated_at\u003dNone):"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        self.id \u003d id"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_479e3d08","line":414,"range":{"start_line":414,"start_character":29,"end_line":414,"end_character":49},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        self.operating_status \u003d operating_status"},{"line_number":423,"context_line":"        self.enabled \u003d enabled"},{"line_number":424,"context_line":"        self.vip \u003d vip"},{"line_number":425,"context_line":"        self.frontend_group \u003d frontend_group"},{"line_number":426,"context_line":"        self.topology \u003d topology"},{"line_number":427,"context_line":"        self.listeners \u003d listeners or []"},{"line_number":428,"context_line":"        self.amphorae \u003d amphorae or []"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_67a34151","line":425,"range":{"start_line":425,"start_character":8,"end_line":425,"end_character":44},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        self.updated_at \u003d updated_at"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"class FrontendGroup(BaseDataModel):"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    def __init__(self, load_balancer_id\u003dNone, frontend_group_name\u003dNone,"},{"line_number":438,"context_line":"                 frontend_auth_type\u003dNone, frontend_auth_pass\u003dNone,"},{"line_number":439,"context_line":"                 advert_int\u003dNone, smtp_server\u003dNone,"},{"line_number":440,"context_line":"                 smtp_connect_timeout\u003dNone, load_balancer\u003dNone):"},{"line_number":441,"context_line":"        self.load_balancer_id \u003d load_balancer_id"},{"line_number":442,"context_line":"        self.frontend_group_name \u003d frontend_group_name"},{"line_number":443,"context_line":"        self.frontend_auth_type \u003d frontend_auth_type"},{"line_number":444,"context_line":"        self.frontend_auth_pass \u003d frontend_auth_pass"},{"line_number":445,"context_line":"        self.advert_int \u003d advert_int"},{"line_number":446,"context_line":"        self.load_balancer \u003d load_balancer"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"class Vip(BaseDataModel):"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_278539ae","line":446,"range":{"start_line":435,"start_character":0,"end_line":446,"end_character":42},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":487,"context_line":"                 status\u003dNone, lb_network_ip\u003dNone, frontend_ip\u003dNone,"},{"line_number":488,"context_line":"                 ha_ip\u003dNone, frontend_port_id\u003dNone, ha_port_id\u003dNone,"},{"line_number":489,"context_line":"                 load_balancer\u003dNone, role\u003dNone, cert_expiration\u003dNone,"},{"line_number":490,"context_line":"                 cert_busy\u003dFalse, frontend_interface\u003dNone, frontend_id\u003dNone,"},{"line_number":491,"context_line":"                 frontend_priority\u003dNone, cached_zone\u003dNone):"},{"line_number":492,"context_line":"        self.id \u003d id"},{"line_number":493,"context_line":"        self.load_balancer_id \u003d load_balancer_id"},{"line_number":494,"context_line":"        self.compute_id \u003d compute_id"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_a7c2a9e8","line":491,"range":{"start_line":490,"start_character":59,"end_line":491,"end_character":39},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        self.ha_port_id \u003d ha_port_id"},{"line_number":501,"context_line":"        self.role \u003d role"},{"line_number":502,"context_line":"        self.frontend_interface \u003d frontend_interface"},{"line_number":503,"context_line":"        self.frontend_id \u003d frontend_id"},{"line_number":504,"context_line":"        self.frontend_priority \u003d frontend_priority"},{"line_number":505,"context_line":"        self.load_balancer \u003d load_balancer"},{"line_number":506,"context_line":"        self.cert_expiration \u003d cert_expiration"},{"line_number":507,"context_line":"        self.cert_busy \u003d cert_busy"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_47b71d88","line":504,"range":{"start_line":503,"start_character":0,"end_line":504,"end_character":50},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"}],"octavia/common/jinja/haproxy/jinja_cfg.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            \u0027role\u0027: amphora.role,"},{"line_number":184,"context_line":"            \u0027status\u0027: amphora.status,"},{"line_number":185,"context_line":"            \u0027frontend_interface\u0027: amphora.frontend_interface,"},{"line_number":186,"context_line":"            \u0027frontend_priority\u0027: amphora.frontend_priority"},{"line_number":187,"context_line":"        }"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def _transform_listener(self, listener, tls_cert):"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_476cfd07","line":186,"range":{"start_line":186,"start_character":13,"end_line":186,"end_character":58},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"}],"octavia/controller/worker/flows/amphora_flows.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":419,"context_line":"            name\u003dsf_name + \u0027-\u0027 + constants.AMP_UPDATE_VRRP_INTF,"},{"line_number":420,"context_line":"            requires\u003dconstants.LOADBALANCER,"},{"line_number":421,"context_line":"            provides\u003dconstants.LOADBALANCER))"},{"line_number":422,"context_line":"        vrrp_subflow.add(database_tasks.CreateFrontendGroupForLB("},{"line_number":423,"context_line":"            name\u003dsf_name + \u0027-\u0027 + constants.CREATE_VRRP_GROUP_FOR_LB,"},{"line_number":424,"context_line":"            requires\u003dconstants.LOADBALANCER,"},{"line_number":425,"context_line":"            provides\u003dconstants.LOADBALANCER))"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_0776f5d9","line":422,"range":{"start_line":422,"start_character":45,"end_line":422,"end_character":56},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"}],"octavia/controller/worker/tasks/database_tasks.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":424,"context_line":"                                      frontend_port_id\u003d("},{"line_number":425,"context_line":"                                          amp_data.frontend_port_id),"},{"line_number":426,"context_line":"                                      ha_port_id\u003damp_data.ha_port_id,"},{"line_number":427,"context_line":"                                      frontend_id\u003d1)"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"class UpdateAmpFailoverDetails(BaseDatabaseTask):"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_c77fada9","line":427,"range":{"start_line":427,"start_character":38,"end_line":427,"end_character":51},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":437,"context_line":"        :param amp_data: data_models.Amphora object with update data"},{"line_number":438,"context_line":"        :returns: None"},{"line_number":439,"context_line":"        \"\"\""},{"line_number":440,"context_line":"        # role and frontend_priority will be updated later."},{"line_number":441,"context_line":"        self.repos.amphora.update(db_apis.get_session(), amphora.id,"},{"line_number":442,"context_line":"                                  frontend_ip\u003damp_data.frontend_ip,"},{"line_number":443,"context_line":"                                  ha_ip\u003damp_data.ha_ip,"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_e77c31b7","line":440,"range":{"start_line":440,"start_character":19,"end_line":440,"end_character":27},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":443,"context_line":"                                  ha_ip\u003damp_data.ha_ip,"},{"line_number":444,"context_line":"                                  frontend_port_id\u003damp_data.frontend_port_id,"},{"line_number":445,"context_line":"                                  ha_port_id\u003damp_data.ha_port_id,"},{"line_number":446,"context_line":"                                  frontend_id\u003damp_data.frontend_id)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"class AssociateFailoverAmphoraWithLBID(BaseDatabaseTask):"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_874be585","line":446,"range":{"start_line":446,"start_character":34,"end_line":446,"end_character":66},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":518,"context_line":"class _MarkAmphoraRoleAndPriorityInDB(BaseDatabaseTask):"},{"line_number":519,"context_line":"    \"\"\"Alter the amphora role and priority in DB.\"\"\""},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def _execute(self, amphora, amp_role, frontend_priority):"},{"line_number":522,"context_line":"        \"\"\"Alter the amphora role and priority in DB."},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"        :param amphora: Amphora to update."}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_a7506934","line":521,"range":{"start_line":521,"start_character":42,"end_line":521,"end_character":59},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":523,"context_line":""},{"line_number":524,"context_line":"        :param amphora: Amphora to update."},{"line_number":525,"context_line":"        :param amp_role: Amphora role to be set."},{"line_number":526,"context_line":"        :param frontend_priority: Frontend priority to set."},{"line_number":527,"context_line":"        :returns: None"},{"line_number":528,"context_line":"        \"\"\""},{"line_number":529,"context_line":"        LOG.debug(\"Mark %(role)s in DB for amphora: %(amp)s\","}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_4745dd6f","line":526,"range":{"start_line":526,"start_character":15,"end_line":526,"end_character":58},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":530,"context_line":"                  {\u0027role\u0027: amp_role, \u0027amp\u0027: amphora.id})"},{"line_number":531,"context_line":"        self.amphora_repo.update(db_apis.get_session(), amphora.id,"},{"line_number":532,"context_line":"                                 role\u003damp_role,"},{"line_number":533,"context_line":"                                 frontend_priority\u003dfrontend_priority)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    def _revert(self, result, amphora, *args, **kwargs):"},{"line_number":536,"context_line":"        \"\"\"Removes role and frontend_priority association."}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_674a6181","line":533,"range":{"start_line":533,"start_character":33,"end_line":533,"end_character":69},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":533,"context_line":"                                 frontend_priority\u003dfrontend_priority)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    def _revert(self, result, amphora, *args, **kwargs):"},{"line_number":536,"context_line":"        \"\"\"Removes role and frontend_priority association."},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"        :param result: Result of the association."},{"line_number":539,"context_line":"        :param amphora: Amphora which role/frontend_priority association"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_275c594a","line":536,"range":{"start_line":536,"start_character":28,"end_line":536,"end_character":46},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        \"\"\"Removes role and frontend_priority association."},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"        :param result: Result of the association."},{"line_number":539,"context_line":"        :param amphora: Amphora which role/frontend_priority association"},{"line_number":540,"context_line":"               failed."},{"line_number":541,"context_line":"        :returns: None"},{"line_number":542,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_c7580d58","line":539,"range":{"start_line":539,"start_character":43,"end_line":539,"end_character":56},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":549,"context_line":"        try:"},{"line_number":550,"context_line":"            self.amphora_repo.update(db_apis.get_session(), amphora.id,"},{"line_number":551,"context_line":"                                     role\u003dNone,"},{"line_number":552,"context_line":"                                     frontend_priority\u003dNone)"},{"line_number":553,"context_line":"        except Exception as e:"},{"line_number":554,"context_line":"            LOG.error(\"Failed to update amphora %(amp)s \""},{"line_number":555,"context_line":"                      \"role and frontend_priority to None due to: \""}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_e755111f","line":552,"range":{"start_line":552,"start_character":37,"end_line":552,"end_character":54},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":552,"context_line":"                                     frontend_priority\u003dNone)"},{"line_number":553,"context_line":"        except Exception as e:"},{"line_number":554,"context_line":"            LOG.error(\"Failed to update amphora %(amp)s \""},{"line_number":555,"context_line":"                      \"role and frontend_priority to None due to: \""},{"line_number":556,"context_line":"                      \"%(except)s\", {\u0027amp\u0027: amphora.id, \u0027except\u0027: e})"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_a735c9f9","line":555,"range":{"start_line":555,"start_character":32,"end_line":555,"end_character":50},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":1534,"context_line":"                                   frontend_port_id\u003damphora.frontend_port_id,"},{"line_number":1535,"context_line":"                                   ha_port_id\u003damphora.ha_port_id,"},{"line_number":1536,"context_line":"                                   role\u003damphora.role,"},{"line_number":1537,"context_line":"                                   frontend_id\u003damphora.frontend_id,"},{"line_number":1538,"context_line":"                                   frontend_priority\u003damphora.frontend_priority)"},{"line_number":1539,"context_line":""},{"line_number":1540,"context_line":""},{"line_number":1541,"context_line":"class GetListenersFromLoadbalancer(BaseDatabaseTask):"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_473abde7","line":1538,"range":{"start_line":1537,"start_character":35,"end_line":1538,"end_character":78},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":1566,"context_line":"        return loadbalancer.vip"},{"line_number":1567,"context_line":""},{"line_number":1568,"context_line":""},{"line_number":1569,"context_line":"class CreateFrontendGroupForLB(BaseDatabaseTask):"},{"line_number":1570,"context_line":"    \"\"\"Create a Frontend group for a load balancer.\"\"\""},{"line_number":1571,"context_line":""},{"line_number":1572,"context_line":"    def execute(self, loadbalancer):"},{"line_number":1573,"context_line":"        \"\"\"Create a Frontend group for a load balancer."},{"line_number":1574,"context_line":""},{"line_number":1575,"context_line":"        :param loadbalancer: Load balancer for which a Frontend group"},{"line_number":1576,"context_line":"               should be created"},{"line_number":1577,"context_line":"        :returns: Updated load balancer"},{"line_number":1578,"context_line":"        \"\"\""},{"line_number":1579,"context_line":"        try:"},{"line_number":1580,"context_line":"            loadbalancer.frontend_group \u003d self.repos.frontendgroup.create("},{"line_number":1581,"context_line":"                db_apis.get_session(),"},{"line_number":1582,"context_line":"                load_balancer_id\u003dloadbalancer.id,"},{"line_number":1583,"context_line":"                frontend_group_name\u003dstr(loadbalancer.id).replace(\u0027-\u0027, \u0027\u0027),"},{"line_number":1584,"context_line":"                frontend_auth_type\u003dconstants.VRRP_AUTH_DEFAULT,"},{"line_number":1585,"context_line":"                frontend_auth_pass\u003duuidutils.generate_uuid().replace("},{"line_number":1586,"context_line":"                    \u0027-\u0027, \u0027\u0027)[0:7],"},{"line_number":1587,"context_line":"                advert_int\u003dCONF.keepalived_vrrp.vrrp_advert_int)"},{"line_number":1588,"context_line":"        except odb_exceptions.DBDuplicateEntry:"},{"line_number":1589,"context_line":"            LOG.debug(\u0027Frontend_GROUP entry already exists for load balancer, \u0027"},{"line_number":1590,"context_line":"                      \u0027skipping create.\u0027)"},{"line_number":1591,"context_line":"        return loadbalancer"},{"line_number":1592,"context_line":""},{"line_number":1593,"context_line":""},{"line_number":1594,"context_line":"class DisableAmphoraHealthMonitoring(BaseDatabaseTask):"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_0724b5c5","line":1591,"range":{"start_line":1569,"start_character":0,"end_line":1591,"end_character":27},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"}],"octavia/db/base_models.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            return obj.__class__.__name__ + obj.pool_id"},{"line_number":38,"context_line":"        elif obj.__class__.__name__ in [\u0027ListenerStatistics\u0027]:"},{"line_number":39,"context_line":"            return obj.__class__.__name__ + obj.listener_id + obj.amphora_id"},{"line_number":40,"context_line":"        elif obj.__class__.__name__ in [\u0027FrontendGroup\u0027, \u0027Vip\u0027]:"},{"line_number":41,"context_line":"            return obj.__class__.__name__ + obj.load_balancer_id"},{"line_number":42,"context_line":"        elif obj.__class__.__name__ in [\u0027AmphoraHealth\u0027]:"},{"line_number":43,"context_line":"            return obj.__class__.__name__ + obj.amphora_id"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_67182181","line":40,"range":{"start_line":40,"start_character":41,"end_line":40,"end_character":54},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"}],"octavia/db/migration/alembic_migrations/versions/d7f02b85e054_rename_vrrp_to_frontend_l3_active_active.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"bf8cb3f7_2acd005d","updated":"2017-12-20 18:39:01.000000000","message":"As discussed in the IRC meeting we need to maintain the old database columns through a deprecation cycle so that operators can upgrade with limited/no downtime.\nI.e. upgrade DB, then go through and upgrade the Octavia processes.\nSo, these will need to be changed to add and anywhere these columns are added/updated will need to be updated to update both columns.","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        new_column_name\u003du\u0027frontend_interface\u0027,"},{"line_number":45,"context_line":"        existing_type\u003dsa.String(16), nullable\u003dTrue)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    op.alter_column("},{"line_number":48,"context_line":"        u\u0027amphora\u0027, u\u0027vrrp_id\u0027,"},{"line_number":49,"context_line":"        new_column_name\u003du\u0027frontend_id\u0027,"},{"line_number":50,"context_line":"        existing_type\u003dsa.Integer(), nullable\u003dTrue)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    op.alter_column("},{"line_number":53,"context_line":"        u\u0027amphora\u0027, u\u0027vrrp_priority\u0027,"},{"line_number":54,"context_line":"        new_column_name\u003du\u0027frontend_priority\u0027,"},{"line_number":55,"context_line":"        existing_type\u003dsa.Integer(), nullable\u003dTrue)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    op.rename_table(u\u0027vrrp_group\u0027, u\u0027frontend_group\u0027)"},{"line_number":58,"context_line":"    op.rename_table(u\u0027vrrp_auth_method\u0027, u\u0027frontend_auth_method\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    op.alter_column("},{"line_number":61,"context_line":"        u\u0027frontend_group\u0027, u\u0027vrrp_group_name\u0027,"},{"line_number":62,"context_line":"        new_column_name\u003du\u0027frontend_group_name\u0027,"},{"line_number":63,"context_line":"        existing_type\u003dsa.String(36), nullable\u003dTrue)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    op.alter_column("},{"line_number":66,"context_line":"        u\u0027frontend_group\u0027, u\u0027vrrp_auth_type\u0027,"},{"line_number":67,"context_line":"        new_column_name\u003du\u0027frontend_auth_type\u0027,"},{"line_number":68,"context_line":"        existing_type\u003dsa.String(16), nullable\u003dTrue)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    op.alter_column("},{"line_number":71,"context_line":"        u\u0027frontend_group\u0027, u\u0027vrrp_auth_pass\u0027,"},{"line_number":72,"context_line":"        new_column_name\u003du\u0027frontend_auth_pass\u0027,"},{"line_number":73,"context_line":"        existing_type\u003dsa.String(36), nullable\u003dTrue)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    op.drop_constraint(constraint_name\u003d\"fk_vrrp_group_load_balancer_id\","},{"line_number":76,"context_line":"                       table_name\u003d\"frontend_group\", type_\u003d\"foreignkey\")"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_155cde49","line":73,"range":{"start_line":47,"start_character":0,"end_line":73,"end_character":51},"updated":"2017-12-20 18:39:01.000000000","message":"These are all VRRP and keepalived specific items. Why are we renaming these?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"}],"octavia/db/models.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    __tablename__ \u003d \"health_monitor_type\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"class FrontendAuthMethod(base_models.BASE, base_models.LookupTableMixin):"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    __tablename__ \u003d \"frontend_auth_method\""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"class L7RuleType(base_models.BASE, base_models.LookupTableMixin):"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_c706cd21","line":79,"range":{"start_line":77,"start_character":0,"end_line":79,"end_character":42},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":339,"context_line":"    server_group_id \u003d sa.Column(sa.String(36), nullable\u003dTrue)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"class FrontendGroup(base_models.BASE):"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"    __data_model__ \u003d data_models.FrontendGroup"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    __tablename__ \u003d \"frontend_group\""},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    load_balancer_id \u003d sa.Column("},{"line_number":349,"context_line":"        sa.String(36),"},{"line_number":350,"context_line":"        sa.ForeignKey(\"load_balancer.id\","},{"line_number":351,"context_line":"                      name\u003d\"fk_frontend_group_load_balancer_id\"),"},{"line_number":352,"context_line":"        nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    frontend_group_name \u003d sa.Column(sa.String(36), nullable\u003dTrue)"},{"line_number":355,"context_line":"    frontend_auth_type \u003d sa.Column(sa.String(16), sa.ForeignKey("},{"line_number":356,"context_line":"        \"frontend_auth_method.name\","},{"line_number":357,"context_line":"        name\u003d\"fk_load_balancer_frontend_auth_method_name\"))"},{"line_number":358,"context_line":"    frontend_auth_pass \u003d sa.Column(sa.String(36), nullable\u003dTrue)"},{"line_number":359,"context_line":"    advert_int \u003d sa.Column(sa.Integer(), nullable\u003dTrue)"},{"line_number":360,"context_line":"    load_balancer \u003d orm.relationship(\"LoadBalancer\", uselist\u003dFalse,"},{"line_number":361,"context_line":"                                     backref\u003dorm.backref(\"frontend_group\","},{"line_number":362,"context_line":"                                                         uselist\u003dFalse,"},{"line_number":363,"context_line":"                                                         cascade\u003d\"delete\"))"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"class Vip(base_models.BASE):"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_e703d10e","line":363,"range":{"start_line":342,"start_character":0,"end_line":363,"end_character":75},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":509,"context_line":"        sa.ForeignKey(\"provisioning_status.name\","},{"line_number":510,"context_line":"                      name\u003d\"fk_container_provisioning_status_name\"))"},{"line_number":511,"context_line":"    frontend_interface \u003d sa.Column(sa.String(16), nullable\u003dTrue)"},{"line_number":512,"context_line":"    frontend_id \u003d sa.Column(sa.Integer(), nullable\u003dTrue)"},{"line_number":513,"context_line":"    frontend_priority \u003d sa.Column(sa.Integer(), nullable\u003dTrue)"},{"line_number":514,"context_line":"    cached_zone \u003d sa.Column(sa.String(255), nullable\u003dTrue)"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_aa03500d","line":513,"range":{"start_line":512,"start_character":4,"end_line":513,"end_character":62},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"}],"octavia/db/repositories.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        self.amphora \u003d AmphoraRepository()"},{"line_number":160,"context_line":"        self.sni \u003d SNIRepository()"},{"line_number":161,"context_line":"        self.amphorahealth \u003d AmphoraHealthRepository()"},{"line_number":162,"context_line":"        self.frontendgroup \u003d FrontendGroupRepository()"},{"line_number":163,"context_line":"        self.l7rule \u003d L7RuleRepository()"},{"line_number":164,"context_line":"        self.l7policy \u003d L7PolicyRepository()"},{"line_number":165,"context_line":"        self.amp_build_slots \u003d AmphoraBuildSlotsRepository()"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_0a127c59","line":162,"range":{"start_line":162,"start_character":8,"end_line":162,"end_character":54},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":1100,"context_line":"        return amp.to_data_model()"},{"line_number":1101,"context_line":""},{"line_number":1102,"context_line":""},{"line_number":1103,"context_line":"class FrontendGroupRepository(BaseRepository):"},{"line_number":1104,"context_line":"    model_class \u003d models.FrontendGroup"},{"line_number":1105,"context_line":""},{"line_number":1106,"context_line":"    def update(self, session, load_balancer_id, **model_kwargs):"},{"line_number":1107,"context_line":"        \"\"\"Updates a FrontendGroup entry for by load_balancer_id.\"\"\""},{"line_number":1108,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":1109,"context_line":"            session.query(self.model_class).filter_by("},{"line_number":1110,"context_line":"                load_balancer_id\u003dload_balancer_id).update(model_kwargs)"},{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":""},{"line_number":1113,"context_line":"class L7RuleRepository(BaseRepository):"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_2a0f402f","line":1110,"range":{"start_line":1103,"start_character":0,"end_line":1110,"end_character":71},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"}],"octavia/network/drivers/neutron/allowed_address_pairs.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def _plug_amphora_vip(self, amphora, subnet):"},{"line_number":86,"context_line":"        # We need a vip port owned by Octavia for Act/Stby and failover"},{"line_number":87,"context_line":"        try:"},{"line_number":88,"context_line":"            port \u003d {\u0027port\u0027: {\u0027name\u0027: \u0027octavia-lb-vrrp-\u0027 + amphora.id,"},{"line_number":89,"context_line":"                             \u0027network_id\u0027: subnet.network_id,"},{"line_number":90,"context_line":"                             \u0027fixed_ips\u0027: [{\u0027subnet_id\u0027: subnet.id}],"},{"line_number":91,"context_line":"                             \u0027admin_state_up\u0027: True,"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_8a9a0cc3","line":88,"range":{"start_line":88,"start_character":38,"end_line":88,"end_character":54},"updated":"2017-12-20 18:39:01.000000000","message":"This should be updated to frontend","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":421,"context_line":"            # Delete the Frontend port if we created it"},{"line_number":422,"context_line":"            try:"},{"line_number":423,"context_line":"                port \u003d self.get_port(amphora.frontend_port_id)"},{"line_number":424,"context_line":"                if port.name.startswith(\u0027octavia-lb-vrrp-\u0027):"},{"line_number":425,"context_line":"                    self.neutron_client.delete_port(amphora.frontend_port_id)"},{"line_number":426,"context_line":"            except (neutron_client_exceptions.NotFound,"},{"line_number":427,"context_line":"                    neutron_client_exceptions.PortNotFoundClient):"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_0a3b5cd1","line":424,"range":{"start_line":424,"start_character":52,"end_line":424,"end_character":56},"updated":"2017-12-20 18:39:01.000000000","message":"These should all be updated to be frontend","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"}],"octavia/tests/functional/amphorae/backend/agent/api_server/test_server.py":[{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"4a7f615cee51258c8d0a8740597bf829e1ae424a","unresolved":false,"context_lines":[{"line_number":1616,"context_line":"            \u0027subnet_cidr\u0027: \u0027203.0.113.0/24\u0027,"},{"line_number":1617,"context_line":"            \u0027gateway\u0027: \u0027203.0.113.1\u0027,"},{"line_number":1618,"context_line":"            \u0027mac_address\u0027: \u0027123\u0027,"},{"line_number":1619,"context_line":"            \u0027frontend_ip\u0027: \u0027203.0.113.4\u0027,"},{"line_number":1620,"context_line":"            \u0027mtu\u0027: 1450,"},{"line_number":1621,"context_line":"            \u0027host_routes\u0027: [{\u0027destination\u0027: \u0027203.0.114.0/24\u0027,"},{"line_number":1622,"context_line":"                             \u0027nexthop\u0027: \u0027203.0.113.5\u0027},"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_babf7aa8","line":1619,"updated":"2017-11-27 18:59:49.000000000","message":"in the agent it\u0027s still called vrrp_ip - please search the source and adjust the son accordingly","commit_id":"07fab655bdf94aa9f792b6e08e78d609f0126f70"}],"octavia/tests/functional/api/v2/test_amphora.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            \u0027role\u0027: constants.ROLE_STANDALONE,"},{"line_number":51,"context_line":"            \u0027status\u0027: constants.AMPHORA_ALLOCATED,"},{"line_number":52,"context_line":"            \u0027frontend_interface\u0027: \u0027eth1\u0027,"},{"line_number":53,"context_line":"            \u0027frontend_id\u0027: 1,"},{"line_number":54,"context_line":"            \u0027frontend_priority\u0027: 100,"},{"line_number":55,"context_line":"            \u0027cached_zone\u0027: None"},{"line_number":56,"context_line":"        }"},{"line_number":57,"context_line":"        self.amp \u003d self.amphora_repo.create(self.session, **self.amp_args)"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_4a408408","line":54,"range":{"start_line":53,"start_character":0,"end_line":54,"end_character":37},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            \u0027role\u0027: constants.ROLE_MASTER,"},{"line_number":73,"context_line":"            \u0027status\u0027: constants.AMPHORA_READY,"},{"line_number":74,"context_line":"            \u0027frontend_interface\u0027: \u0027eth1\u0027,"},{"line_number":75,"context_line":"            \u0027frontend_id\u0027: 1,"},{"line_number":76,"context_line":"            \u0027frontend_priority\u0027: 100,"},{"line_number":77,"context_line":"            \u0027cached_zone\u0027: None"},{"line_number":78,"context_line":"        }"},{"line_number":79,"context_line":"        return self.amphora_repo.create(self.session, **amp_args)"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_6a454817","line":76,"range":{"start_line":75,"start_character":0,"end_line":76,"end_character":37},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"}],"octavia/tests/functional/db/base.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self._seed_lookup_table(session, constants.SUPPORTED_LB_TOPOLOGIES,"},{"line_number":72,"context_line":"                                models.LBTopology)"},{"line_number":73,"context_line":"        self._seed_lookup_table(session, constants.SUPPORTED_VRRP_AUTH,"},{"line_number":74,"context_line":"                                models.FrontendAuthMethod)"},{"line_number":75,"context_line":"        self._seed_lookup_table(session, constants.SUPPORTED_L7RULE_TYPES,"},{"line_number":76,"context_line":"                                models.L7RuleType)"},{"line_number":77,"context_line":"        self._seed_lookup_table(session,"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_8a5f6ce4","line":74,"range":{"start_line":74,"start_character":39,"end_line":74,"end_character":48},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                                constants.SUPPORTED_L7RULE_COMPARE_TYPES,"},{"line_number":79,"context_line":"                                models.L7RuleCompareType)"},{"line_number":80,"context_line":"        self._seed_lookup_table(session, constants.SUPPORTED_L7POLICY_ACTIONS,"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"                                models.L7PolicyAction)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def _seed_lookup_table(self, session, name_list, model_cls):"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_6a5ea8e7","line":81,"updated":"2017-12-20 18:39:01.000000000","message":"Please remove this extra line","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"}],"octavia/tests/functional/db/test_models.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":859,"context_line":"            return obj.__class__.__name__ + obj.pool_id"},{"line_number":860,"context_line":"        elif obj.__class__.__name__ in [\u0027ListenerStatistics\u0027]:"},{"line_number":861,"context_line":"            return obj.__class__.__name__ + obj.listener_id + obj.amphora_id"},{"line_number":862,"context_line":"        elif obj.__class__.__name__ in [\u0027FrontendGroup\u0027, \u0027Vip\u0027]:"},{"line_number":863,"context_line":"            return obj.__class__.__name__ + obj.load_balancer_id"},{"line_number":864,"context_line":"        elif obj.__class__.__name__ in [\u0027AmphoraHealth\u0027]:"},{"line_number":865,"context_line":"            return obj.__class__.__name__ + obj.amphora_id"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_2a70a072","line":862,"range":{"start_line":862,"start_character":41,"end_line":862,"end_character":54},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"}],"octavia/tests/functional/db/test_repositories.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.sni_repo \u003d repo.SNIRepository()"},{"line_number":56,"context_line":"        self.amphora_repo \u003d repo.AmphoraRepository()"},{"line_number":57,"context_line":"        self.amphora_health_repo \u003d repo.AmphoraHealthRepository()"},{"line_number":58,"context_line":"        self.frontend_group_repo \u003d repo.FrontendGroupRepository()"},{"line_number":59,"context_line":"        self.l7policy_repo \u003d repo.L7PolicyRepository()"},{"line_number":60,"context_line":"        self.l7rule_repo \u003d repo.L7RuleRepository()"},{"line_number":61,"context_line":"        self.quota_repo \u003d repo.QuotasRepository()"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_aa0910de","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":65},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        repo_attr_names \u003d (\u0027load_balancer\u0027, \u0027vip\u0027, \u0027health_monitor\u0027,"},{"line_number":99,"context_line":"                           \u0027session_persistence\u0027, \u0027pool\u0027, \u0027member\u0027, \u0027listener\u0027,"},{"line_number":100,"context_line":"                           \u0027listener_stats\u0027, \u0027amphora\u0027, \u0027sni\u0027,"},{"line_number":101,"context_line":"                           \u0027amphorahealth\u0027, \u0027frontendgroup\u0027, \u0027l7rule\u0027,"},{"line_number":102,"context_line":"                           \u0027l7policy\u0027, \u0027amp_build_slots\u0027, \u0027amp_build_req\u0027,"},{"line_number":103,"context_line":"                           \u0027quotas\u0027)"},{"line_number":104,"context_line":"        for repo_attr in repo_attr_names:"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_4a0e44e6","line":101,"range":{"start_line":101,"start_character":45,"end_line":101,"end_character":59},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":127,"context_line":"              \u0027provisioning_status\u0027: constants.PENDING_UPDATE,"},{"line_number":128,"context_line":"              \u0027operating_status\u0027: constants.OFFLINE,"},{"line_number":129,"context_line":"              \u0027topology\u0027: constants.TOPOLOGY_ACTIVE_STANDBY,"},{"line_number":130,"context_line":"              \u0027frontend_group\u0027: None,"},{"line_number":131,"context_line":"              \u0027server_group_id\u0027: uuidutils.generate_uuid(),"},{"line_number":132,"context_line":"              \u0027project_id\u0027: uuidutils.generate_uuid(),"},{"line_number":133,"context_line":"              \u0027id\u0027: uuidutils.generate_uuid()}"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_6a13080f","line":130,"range":{"start_line":130,"start_character":14,"end_line":130,"end_character":31},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":397,"context_line":"               \u0027subnet_id\u0027: uuidutils.generate_uuid()}"},{"line_number":398,"context_line":"        lb \u003d {\u0027name\u0027: \u0027lb1\u0027, \u0027description\u0027: \u0027desc1\u0027, \u0027enabled\u0027: True,"},{"line_number":399,"context_line":"              \u0027topology\u0027: constants.TOPOLOGY_ACTIVE_STANDBY,"},{"line_number":400,"context_line":"              \u0027frontend_group\u0027: None,"},{"line_number":401,"context_line":"              \u0027server_group_id\u0027: uuidutils.generate_uuid(),"},{"line_number":402,"context_line":"              \u0027project_id\u0027: project_id, \u0027vip\u0027: vip,"},{"line_number":403,"context_line":"              \u0027provisioning_status\u0027: constants.PENDING_CREATE,"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_0af83cc2","line":400,"range":{"start_line":400,"start_character":14,"end_line":400,"end_character":30},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":423,"context_line":"               \u0027subnet_id\u0027: uuidutils.generate_uuid()}"},{"line_number":424,"context_line":"        lb \u003d {\u0027name\u0027: \u0027lb1\u0027, \u0027description\u0027: \u0027desc1\u0027, \u0027enabled\u0027: True,"},{"line_number":425,"context_line":"              \u0027topology\u0027: constants.TOPOLOGY_ACTIVE_STANDBY,"},{"line_number":426,"context_line":"              \u0027frontend_group\u0027: None,"},{"line_number":427,"context_line":"              \u0027server_group_id\u0027: uuidutils.generate_uuid(),"},{"line_number":428,"context_line":"              \u0027project_id\u0027: project_id,"},{"line_number":429,"context_line":"              \u0027provisioning_status\u0027: constants.PENDING_CREATE,"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_2af500cc","line":426,"range":{"start_line":426,"start_character":14,"end_line":426,"end_character":31},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":544,"context_line":"               \u0027subnet_id\u0027: uuidutils.generate_uuid()}"},{"line_number":545,"context_line":"        lb \u003d {\u0027name\u0027: \u0027lb1\u0027, \u0027description\u0027: \u0027desc1\u0027, \u0027enabled\u0027: True,"},{"line_number":546,"context_line":"              \u0027topology\u0027: constants.TOPOLOGY_ACTIVE_STANDBY,"},{"line_number":547,"context_line":"              \u0027frontend_group\u0027: None,"},{"line_number":548,"context_line":"              \u0027server_group_id\u0027: uuidutils.generate_uuid(),"},{"line_number":549,"context_line":"              \u0027project_id\u0027: project_id, \u0027vip\u0027: vip,"},{"line_number":550,"context_line":"              \u0027provisioning_status\u0027: constants.PENDING_CREATE,"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_8a2d2c48","line":547,"range":{"start_line":547,"start_character":15,"end_line":547,"end_character":30},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":582,"context_line":"                        \u0027id\u0027: uuidutils.generate_uuid()}"},{"line_number":583,"context_line":"        lb2 \u003d {\u0027name\u0027: \u0027lb2\u0027, \u0027description\u0027: \u0027desc2\u0027, \u0027enabled\u0027: True,"},{"line_number":584,"context_line":"               \u0027topology\u0027: constants.TOPOLOGY_ACTIVE_STANDBY,"},{"line_number":585,"context_line":"               \u0027frontend_group\u0027: None,"},{"line_number":586,"context_line":"               \u0027server_group_id\u0027: uuidutils.generate_uuid(),"},{"line_number":587,"context_line":"               \u0027project_id\u0027: project_id, \u0027vip\u0027: vip,"},{"line_number":588,"context_line":"               \u0027provisioning_status\u0027: constants.PENDING_CREATE,"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_aa3270a6","line":585,"range":{"start_line":585,"start_character":15,"end_line":585,"end_character":32},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":3141,"context_line":"            self.session, amphora_id\u003damphora_health.amphora_id))"},{"line_number":3142,"context_line":""},{"line_number":3143,"context_line":""},{"line_number":3144,"context_line":"class FrontendGroupRepositoryTest(BaseRepositoryTest):"},{"line_number":3145,"context_line":"    def setUp(self):"},{"line_number":3146,"context_line":"        super(FrontendGroupRepositoryTest, self).setUp()"},{"line_number":3147,"context_line":"        self.lb \u003d self.lb_repo.create("},{"line_number":3148,"context_line":"            self.session, id\u003dself.FAKE_UUID_1, project_id\u003dself.FAKE_UUID_2,"},{"line_number":3149,"context_line":"            name\u003d\"lb_name\", description\u003d\"lb_description\","},{"line_number":3150,"context_line":"            provisioning_status\u003dconstants.ACTIVE,"},{"line_number":3151,"context_line":"            operating_status\u003dconstants.ONLINE, enabled\u003dTrue)"},{"line_number":3152,"context_line":""},{"line_number":3153,"context_line":"    def test_update(self):"},{"line_number":3154,"context_line":"        self.frontendgroup \u003d self.frontend_group_repo.create("},{"line_number":3155,"context_line":"            self.session,"},{"line_number":3156,"context_line":"            load_balancer_id\u003dself.lb.id,"},{"line_number":3157,"context_line":"            frontend_group_name\u003d\u0027TESTVRRPGROUP\u0027,"},{"line_number":3158,"context_line":"            frontend_auth_type\u003dconstants.VRRP_AUTH_DEFAULT,"},{"line_number":3159,"context_line":"            frontend_auth_pass\u003d\u0027TESTPASS\u0027,"},{"line_number":3160,"context_line":"            advert_int\u003d1)"},{"line_number":3161,"context_line":""},{"line_number":3162,"context_line":"        # Validate baseline"},{"line_number":3163,"context_line":"        old_frontend_group \u003d self.frontend_group_repo.get("},{"line_number":3164,"context_line":"            self.session,"},{"line_number":3165,"context_line":"            load_balancer_id\u003dself.lb.id)"},{"line_number":3166,"context_line":""},{"line_number":3167,"context_line":"        self.assertEqual(\u0027TESTVRRPGROUP\u0027,"},{"line_number":3168,"context_line":"                         old_frontend_group.frontend_group_name)"},{"line_number":3169,"context_line":"        self.assertEqual(constants.VRRP_AUTH_DEFAULT,"},{"line_number":3170,"context_line":"                         old_frontend_group.frontend_auth_type)"},{"line_number":3171,"context_line":"        self.assertEqual(\u0027TESTPASS\u0027, old_frontend_group.frontend_auth_pass)"},{"line_number":3172,"context_line":"        self.assertEqual(1, old_frontend_group.advert_int)"},{"line_number":3173,"context_line":""},{"line_number":3174,"context_line":"        # Test update"},{"line_number":3175,"context_line":"        self.frontend_group_repo.update(self.session,"},{"line_number":3176,"context_line":"                                        load_balancer_id\u003dself.lb.id,"},{"line_number":3177,"context_line":"                                        frontend_group_name\u003d\u0027TESTVRRPGROUP2\u0027,"},{"line_number":3178,"context_line":"                                        frontend_auth_type\u003d\u0027AH\u0027,"},{"line_number":3179,"context_line":"                                        frontend_auth_pass\u003d\u0027TESTPASS2\u0027,"},{"line_number":3180,"context_line":"                                        advert_int\u003d2)"},{"line_number":3181,"context_line":""},{"line_number":3182,"context_line":"        new_frontend_group \u003d self.frontend_group_repo.get("},{"line_number":3183,"context_line":"            self.session, load_balancer_id\u003dself.lb.id)"},{"line_number":3184,"context_line":"        self.assertEqual(\u0027TESTVRRPGROUP2\u0027,"},{"line_number":3185,"context_line":"                         new_frontend_group.frontend_group_name)"},{"line_number":3186,"context_line":"        self.assertEqual(\u0027AH\u0027, new_frontend_group.frontend_auth_type)"},{"line_number":3187,"context_line":"        self.assertEqual(\u0027TESTPASS2\u0027, new_frontend_group.frontend_auth_pass)"},{"line_number":3188,"context_line":"        self.assertEqual(2, new_frontend_group.advert_int)"},{"line_number":3189,"context_line":""},{"line_number":3190,"context_line":""},{"line_number":3191,"context_line":"class L7PolicyRepositoryTest(BaseRepositoryTest):"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_6a2c6847","line":3188,"range":{"start_line":3144,"start_character":0,"end_line":3188,"end_character":58},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"}],"octavia/tests/unit/amphorae/drivers/keepalived/jinja/test_jinja_cfg.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self.amphora1.role \u003d constants.ROLE_MASTER"},{"line_number":43,"context_line":"        self.amphora1.frontend_interface \u003d \u0027eth1\u0027"},{"line_number":44,"context_line":"        self.amphora1.frontend_id \u003d 1"},{"line_number":45,"context_line":"        self.amphora1.frontend_priority \u003d 100"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        self.amphora2 \u003d mock.MagicMock()"},{"line_number":48,"context_line":"        self.amphora2.status \u003d constants.AMPHORA_ALLOCATED"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_8ad20c34","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":45},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        self.amphora2.role \u003d constants.ROLE_BACKUP"},{"line_number":51,"context_line":"        self.amphora2.frontend_interface \u003d \u0027eth1\u0027"},{"line_number":52,"context_line":"        self.amphora2.frontend_id \u003d 1"},{"line_number":53,"context_line":"        self.amphora2.frontend_priority \u003d 90"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self.lb \u003d mock.MagicMock()"},{"line_number":56,"context_line":"        self.lb.amphorae \u003d [self.amphora1, self.amphora2]"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_aad7d023","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":44},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self.lb \u003d mock.MagicMock()"},{"line_number":56,"context_line":"        self.lb.amphorae \u003d [self.amphora1, self.amphora2]"},{"line_number":57,"context_line":"        self.lb.frontend_group.frontend_group_name \u003d \u0027TESTGROUP\u0027"},{"line_number":58,"context_line":"        self.lb.frontend_group.frontend_auth_type \u003d constants.VRRP_AUTH_DEFAULT"},{"line_number":59,"context_line":"        self.lb.frontend_group.frontend_auth_pass \u003d \u0027TESTPASSWORD\u0027"},{"line_number":60,"context_line":"        self.lb.vip.ip_address \u003d \u002710.1.0.5\u0027"},{"line_number":61,"context_line":"        self.lb.frontend_group.advert_int \u003d 10"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        self.ref_conf \u003d (\"vrrp_script check_script {\\n\""},{"line_number":64,"context_line":"                         \"  script /tmp/test/vrrp/check_script.sh\\n\""}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_2ae3c007","line":61,"range":{"start_line":57,"start_character":0,"end_line":61,"end_character":46},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"}],"octavia/tests/unit/common/sample_configs/sample_configs.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    in_amphora \u003d collections.namedtuple("},{"line_number":25,"context_line":"        \u0027amphora\u0027, \u0027id, lb_network_ip, frontend_ip, ha_ip,\u0027"},{"line_number":26,"context_line":"                   \u0027frontend_port_id, ha_port_id, role, status,\u0027"},{"line_number":27,"context_line":"                   \u0027frontend_interface, frontend_priority\u0027)"},{"line_number":28,"context_line":"    return in_amphora("},{"line_number":29,"context_line":"        id\u003d\u0027sample_amphora_id_1\u0027,"},{"line_number":30,"context_line":"        lb_network_ip\u003d\u002710.0.1.1\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_eaecf8f4","line":27,"range":{"start_line":27,"start_character":40,"end_line":27,"end_character":58},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        role\u003dNone,"},{"line_number":36,"context_line":"        status\u003d\u0027ACTIVE\u0027,"},{"line_number":37,"context_line":"        frontend_interface\u003dNone,"},{"line_number":38,"context_line":"        frontend_priority\u003dNone)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"RET_PERSISTENCE \u003d {"},{"line_number":41,"context_line":"    \u0027type\u0027: \u0027HTTP_COOKIE\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_caefb4e7","line":38,"range":{"start_line":38,"start_character":8,"end_line":38,"end_character":31},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":303,"context_line":"    \u0027role\u0027: None,"},{"line_number":304,"context_line":"    \u0027status\u0027: \u0027ACTIVE\u0027,"},{"line_number":305,"context_line":"    \u0027frontend_interface\u0027: None,"},{"line_number":306,"context_line":"    \u0027frontend_priority\u0027: None}"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"RET_LB \u003d {"},{"line_number":309,"context_line":"    \u0027host_amphora\u0027: RET_AMPHORA,"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_8abbece3","line":306,"range":{"start_line":306,"start_character":5,"end_line":306,"end_character":30},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":381,"context_line":"    )"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"def sample_vrrp_group_tuple():"},{"line_number":385,"context_line":"    in_vrrp_group \u003d collections.namedtuple("},{"line_number":386,"context_line":"        \u0027frontend_group\u0027, \u0027load_balancer_id, frontend_auth_type,\u0027"},{"line_number":387,"context_line":"                          \u0027frontend_auth_pass, advert_int, smtp_server,\u0027"},{"line_number":388,"context_line":"                          \u0027 smtp_connect_timeout, frontend_group_name\u0027)"},{"line_number":389,"context_line":"    return in_vrrp_group("},{"line_number":390,"context_line":"        frontend_group_name\u003d\u0027sample_loadbalancer_id_1\u0027,"},{"line_number":391,"context_line":"        load_balancer_id\u003d\u0027sample_loadbalancer_id_1\u0027,"},{"line_number":392,"context_line":"        frontend_auth_type\u003d\u0027PASS\u0027,"},{"line_number":393,"context_line":"        frontend_auth_pass\u003d\u0027123\u0027,"},{"line_number":394,"context_line":"        advert_int\u003d\u00271\u0027,"},{"line_number":395,"context_line":"        smtp_server\u003d\u0027\u0027,"},{"line_number":396,"context_line":"        smtp_connect_timeout\u003d\u0027\u0027)"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"def sample_vip_tuple():"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_4ab5e4ed","line":396,"range":{"start_line":384,"start_character":0,"end_line":396,"end_character":32},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"}],"octavia/tests/unit/controller/worker/tasks/test_database_tasks.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":47,"context_line":"FRONTEND_IP \u003d \u0027192.0.5.3\u0027"},{"line_number":48,"context_line":"HA_IP \u003d \u0027192.0.5.4\u0027"},{"line_number":49,"context_line":"AMP_ROLE \u003d \u0027FAKE_ROLE\u0027"},{"line_number":50,"context_line":"FRONTEND_ID \u003d random.randrange(255)"},{"line_number":51,"context_line":"FRONTEND_PRIORITY \u003d random.randrange(100)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"_amphora_mock \u003d mock.MagicMock()"},{"line_number":54,"context_line":"_amphora_mock.id \u003d AMP_ID"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_2acc2088","line":51,"range":{"start_line":50,"start_character":0,"end_line":51,"end_character":41},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":59,"context_line":"_amphora_mock.ha_port_id \u003d HA_PORT_ID"},{"line_number":60,"context_line":"_amphora_mock.frontend_port_id \u003d FRONTEND_PORT_ID"},{"line_number":61,"context_line":"_amphora_mock.role \u003d AMP_ROLE"},{"line_number":62,"context_line":"_amphora_mock.frontend_id \u003d FRONTEND_ID"},{"line_number":63,"context_line":"_amphora_mock.frontend_priority \u003d FRONTEND_PRIORITY"},{"line_number":64,"context_line":"_amphorae \u003d [_amphora_mock]"},{"line_number":65,"context_line":"_loadbalancer_mock \u003d mock.MagicMock()"},{"line_number":66,"context_line":"_loadbalancer_mock.id \u003d LB_ID"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_aaa590b7","line":63,"range":{"start_line":62,"start_character":0,"end_line":63,"end_character":51},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":78,"context_line":"_vip_mock.port_id \u003d PORT_ID"},{"line_number":79,"context_line":"_vip_mock.subnet_id \u003d SUBNET_ID"},{"line_number":80,"context_line":"_vip_mock.ip_address \u003d VIP_IP"},{"line_number":81,"context_line":"_frontend_group_mock \u003d mock.MagicMock()"},{"line_number":82,"context_line":"_cert_mock \u003d mock.MagicMock()"},{"line_number":83,"context_line":"_pem_mock \u003d \"\"\"Junk"},{"line_number":84,"context_line":"-----BEGIN CERTIFICATE-----"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_6aaf8894","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":39},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":485,"context_line":"            ha_ip\u003dHA_IP,"},{"line_number":486,"context_line":"            frontend_port_id\u003dFRONTEND_PORT_ID,"},{"line_number":487,"context_line":"            ha_port_id\u003dHA_PORT_ID,"},{"line_number":488,"context_line":"            frontend_id\u003d1)"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    def test_update_amp_failover_details(self,"},{"line_number":491,"context_line":"                                         mock_generate_uuid,"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_0a94bc43","line":488,"range":{"start_line":488,"start_character":11,"end_line":488,"end_character":26},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":506,"context_line":"            ha_ip\u003dHA_IP,"},{"line_number":507,"context_line":"            frontend_port_id\u003dFRONTEND_PORT_ID,"},{"line_number":508,"context_line":"            ha_port_id\u003dHA_PORT_ID,"},{"line_number":509,"context_line":"            frontend_id\u003dFRONTEND_ID)"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    @mock.patch(\u0027octavia.db.repositories.AmphoraRepository.associate\u0027)"},{"line_number":512,"context_line":"    def test_associate_failover_amphora_with_lb_id("}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_2a918053","line":509,"range":{"start_line":509,"start_character":12,"end_line":509,"end_character":36},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":1672,"context_line":"        self.assertEqual(HA_IP, new_amp.ha_ip)"},{"line_number":1673,"context_line":"        self.assertEqual(FRONTEND_PORT_ID, new_amp.frontend_port_id)"},{"line_number":1674,"context_line":"        self.assertEqual(AMP_ROLE, new_amp.role)"},{"line_number":1675,"context_line":"        self.assertEqual(FRONTEND_ID, new_amp.frontend_id)"},{"line_number":1676,"context_line":"        self.assertEqual(FRONTEND_PRIORITY, new_amp.frontend_priority)"},{"line_number":1677,"context_line":""},{"line_number":1678,"context_line":"    def test_mark_amphora_role_indb(self,"},{"line_number":1679,"context_line":"                                    mock_generate_uuid,"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_ca9d7467","line":1676,"range":{"start_line":1675,"start_character":0,"end_line":1676,"end_character":70},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":1688,"context_line":"        mark_amp_master_indb.execute(_amphora_mock)"},{"line_number":1689,"context_line":"        repo.AmphoraRepository.update.assert_called_once_with("},{"line_number":1690,"context_line":"            \u0027TEST\u0027, AMP_ID, role\u003d\u0027MASTER\u0027,"},{"line_number":1691,"context_line":"            frontend_priority\u003dconstants.ROLE_MASTER_PRIORITY)"},{"line_number":1692,"context_line":""},{"line_number":1693,"context_line":"        mock_amphora_repo_update.reset_mock()"},{"line_number":1694,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_8a89ac27","line":1691,"range":{"start_line":1691,"start_character":12,"end_line":1691,"end_character":29},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":1694,"context_line":""},{"line_number":1695,"context_line":"        mark_amp_master_indb.revert(\"BADRESULT\", _amphora_mock)"},{"line_number":1696,"context_line":"        repo.AmphoraRepository.update.assert_called_once_with("},{"line_number":1697,"context_line":"            \u0027TEST\u0027, AMP_ID, role\u003dNone, frontend_priority\u003dNone)"},{"line_number":1698,"context_line":""},{"line_number":1699,"context_line":"        mock_amphora_repo_update.reset_mock()"},{"line_number":1700,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_aa8ef02b","line":1697,"range":{"start_line":1697,"start_character":39,"end_line":1697,"end_character":56},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":1708,"context_line":"        mark_amp_backup_indb.execute(_amphora_mock)"},{"line_number":1709,"context_line":"        repo.AmphoraRepository.update.assert_called_once_with("},{"line_number":1710,"context_line":"            \u0027TEST\u0027, AMP_ID, role\u003d\u0027BACKUP\u0027,"},{"line_number":1711,"context_line":"            frontend_priority\u003dconstants.ROLE_BACKUP_PRIORITY)"},{"line_number":1712,"context_line":""},{"line_number":1713,"context_line":"        mock_amphora_repo_update.reset_mock()"},{"line_number":1714,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_6a88e81e","line":1711,"range":{"start_line":1711,"start_character":12,"end_line":1711,"end_character":31},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":1714,"context_line":""},{"line_number":1715,"context_line":"        mark_amp_backup_indb.revert(\"BADRESULT\", _amphora_mock)"},{"line_number":1716,"context_line":"        repo.AmphoraRepository.update.assert_called_once_with("},{"line_number":1717,"context_line":"            \u0027TEST\u0027, AMP_ID, role\u003dNone, frontend_priority\u003dNone)"},{"line_number":1718,"context_line":""},{"line_number":1719,"context_line":"        mock_amphora_repo_update.reset_mock()"},{"line_number":1720,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_0a7d9c1b","line":1717,"range":{"start_line":1717,"start_character":39,"end_line":1717,"end_character":55},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":1722,"context_line":"        mark_amp_standalone_indb.execute(_amphora_mock)"},{"line_number":1723,"context_line":"        repo.AmphoraRepository.update.assert_called_once_with("},{"line_number":1724,"context_line":"            \u0027TEST\u0027, AMP_ID, role\u003d\u0027STANDALONE\u0027,"},{"line_number":1725,"context_line":"            frontend_priority\u003dNone)"},{"line_number":1726,"context_line":""},{"line_number":1727,"context_line":"        mock_amphora_repo_update.reset_mock()"},{"line_number":1728,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_2a7ae023","line":1725,"range":{"start_line":1725,"start_character":12,"end_line":1725,"end_character":29},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":1728,"context_line":""},{"line_number":1729,"context_line":"        mark_amp_standalone_indb.revert(\"BADRESULT\", _amphora_mock)"},{"line_number":1730,"context_line":"        repo.AmphoraRepository.update.assert_called_once_with("},{"line_number":1731,"context_line":"            \u0027TEST\u0027, AMP_ID, role\u003dNone, frontend_priority\u003dNone)"},{"line_number":1732,"context_line":""},{"line_number":1733,"context_line":"        # Test revert with exception"},{"line_number":1734,"context_line":"        mock_amphora_repo_update.reset_mock()"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_ca76d43f","line":1731,"range":{"start_line":1731,"start_character":39,"end_line":1731,"end_character":56},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":1735,"context_line":"        mock_amphora_repo_update.side_effect \u003d Exception(\u0027fail\u0027)"},{"line_number":1736,"context_line":"        mark_amp_standalone_indb.revert(\"BADRESULT\", _amphora_mock)"},{"line_number":1737,"context_line":"        repo.AmphoraRepository.update.assert_called_once_with("},{"line_number":1738,"context_line":"            \u0027TEST\u0027, AMP_ID, role\u003dNone, frontend_priority\u003dNone)"},{"line_number":1739,"context_line":""},{"line_number":1740,"context_line":"    @mock.patch(\u0027octavia.db.repositories.FrontendGroupRepository.create\u0027)"},{"line_number":1741,"context_line":"    def test_create_frontend_group_for_lb(self,"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_8a8e8c25","line":1738,"range":{"start_line":1738,"start_character":39,"end_line":1738,"end_character":56},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":1737,"context_line":"        repo.AmphoraRepository.update.assert_called_once_with("},{"line_number":1738,"context_line":"            \u0027TEST\u0027, AMP_ID, role\u003dNone, frontend_priority\u003dNone)"},{"line_number":1739,"context_line":""},{"line_number":1740,"context_line":"    @mock.patch(\u0027octavia.db.repositories.FrontendGroupRepository.create\u0027)"},{"line_number":1741,"context_line":"    def test_create_frontend_group_for_lb(self,"},{"line_number":1742,"context_line":"                                          mock_frontend_group_create,"},{"line_number":1743,"context_line":"                                          mock_generate_uuid,"},{"line_number":1744,"context_line":"                                          mock_LOG,"},{"line_number":1745,"context_line":"                                          mock_get_session,"},{"line_number":1746,"context_line":"                                          mock_loadbalancer_repo_update,"},{"line_number":1747,"context_line":"                                          mock_listener_repo_update,"},{"line_number":1748,"context_line":"                                          mock_amphora_repo_update,"},{"line_number":1749,"context_line":"                                          mock_amphora_repo_delete):"},{"line_number":1750,"context_line":""},{"line_number":1751,"context_line":"        mock_get_session.side_effect \u003d [\u0027TEST\u0027,"},{"line_number":1752,"context_line":"                                        odb_exceptions.DBDuplicateEntry]"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_aa93504f","line":1749,"range":{"start_line":1740,"start_character":1,"end_line":1749,"end_character":68},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"789cb56b72b2093bf45bd02d4989a8452b4cb6c4","unresolved":false,"context_lines":[{"line_number":1750,"context_line":""},{"line_number":1751,"context_line":"        mock_get_session.side_effect \u003d [\u0027TEST\u0027,"},{"line_number":1752,"context_line":"                                        odb_exceptions.DBDuplicateEntry]"},{"line_number":1753,"context_line":"        create_frontend_group \u003d database_tasks.CreateFrontendGroupForLB()"},{"line_number":1754,"context_line":"        create_frontend_group.execute(_loadbalancer_mock)"},{"line_number":1755,"context_line":"        mock_frontend_group_create.assert_called_once_with("},{"line_number":1756,"context_line":"            \u0027TEST\u0027, load_balancer_id\u003dLB_ID,"},{"line_number":1757,"context_line":"            frontend_group_name\u003dLB_ID.replace(\u0027-\u0027, \u0027\u0027),"},{"line_number":1758,"context_line":"            frontend_auth_type\u003dconstants.VRRP_AUTH_DEFAULT,"},{"line_number":1759,"context_line":"            frontend_auth_pass\u003dmock_generate_uuid.return_value.replace("},{"line_number":1760,"context_line":"                \u0027-\u0027, \u0027\u0027)[0:7], advert_int\u003d1)"},{"line_number":1761,"context_line":"        create_frontend_group.execute(_loadbalancer_mock)"},{"line_number":1762,"context_line":""},{"line_number":1763,"context_line":"    @mock.patch(\u0027octavia.db.repositories.AmphoraHealthRepository.delete\u0027)"},{"line_number":1764,"context_line":"    def test_disable_amphora_health_monitoring(self,"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf8cb3f7_4a988469","line":1761,"range":{"start_line":1753,"start_character":0,"end_line":1761,"end_character":57},"updated":"2017-12-20 18:39:01.000000000","message":"This is VRRP specific, why are we renaming this?","commit_id":"a3b2bd1ebfdf01f849022eddf7214b1405fdff94"}]}