)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1301ced2a4dad5306fb212970c8408596ce37645","unresolved":false,"context_lines":[{"line_number":19,"context_line":"(when available) running in permissive mode."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Made the rebind-sshd element generic to streamline the script"},{"line_number":22,"context_line":"Use POSIX syntax for logrotate kill command"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I391b2a95d54c7b9fd8f31d3e2c136ff9cc3451f1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9f91af0f_e2d604c4","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":43},"updated":"2018-01-05 01:19:33.000000000","message":"Can you cite a reference for this. My understanding is that the SIGUSR1 format *is* the POSIX.1-1990 standard.","commit_id":"687d5387d04b238b164b279e16583c000b7fccc5"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"a48dfbbc47f7b11778e8a3c3a08adcb6f710c8ef","unresolved":false,"context_lines":[{"line_number":19,"context_line":"(when available) running in permissive mode."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Made the rebind-sshd element generic to streamline the script"},{"line_number":22,"context_line":"Use POSIX syntax for logrotate kill command"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I391b2a95d54c7b9fd8f31d3e2c136ff9cc3451f1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9f91af0f_8825cdc4","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":43},"in_reply_to":"9f91af0f_e2d604c4","updated":"2018-01-05 15:29:06.000000000","message":"http://pubs.opengroup.org/onlinepubs/9699919799/utilities/kill.html\n\"Values of signal_name shall be recognized in a case-independent fashion, without the SIG prefix\"\n\nI found this in my tests, triggered by logrotate using sh, not bash (man bash):\n\"If bash is invoked with the name sh, it tries to mimic the startup behavior of historical versions of sh as closely as possible, while conforming to the POSIX standard as well\"\nWhich with SIGUSR1, would generate eror:\nlogrotate_script: line 1: kill: SIGUSR1: invalid signal specification\n\nThis can also be seen in the output of \"kill -l\", if run in /bin/sh it does not show the SIG prefix","commit_id":"687d5387d04b238b164b279e16583c000b7fccc5"}],"diskimage-create/README.rst":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"6e5a798787539c42b23a8c33450e1cfdbeafe2d2","unresolved":false,"context_lines":[{"line_number":134,"context_line":"Using distribution packages for amphora agent"},{"line_number":135,"context_line":"---------------------------------------------"},{"line_number":136,"context_line":"By default, amphora agent is installed from Octavia Git repository."},{"line_number":137,"context_line":"To use distribution packages, use the \"-n\" option."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Note this needs a base system image with the required repositories enabled (for"},{"line_number":140,"context_line":"example RDO repositories for CentOS/Fedora). One of these variables must be"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff82abbf_87e5a40b","line":137,"range":{"start_line":137,"start_character":38,"end_line":137,"end_character":42},"updated":"2017-11-24 11:15:29.000000000","message":"Should be -p option","commit_id":"21382191a5fa5d7ea85658d8c35a31df11e4520a"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"d58fd6e59cfa01e2595f23897d10a2ded3cbc2fa","unresolved":false,"context_lines":[{"line_number":134,"context_line":"Using distribution packages for amphora agent"},{"line_number":135,"context_line":"---------------------------------------------"},{"line_number":136,"context_line":"By default, amphora agent is installed from Octavia Git repository."},{"line_number":137,"context_line":"To use distribution packages, use the \"-n\" option."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Note this needs a base system image with the required repositories enabled (for"},{"line_number":140,"context_line":"example RDO repositories for CentOS/Fedora). One of these variables must be"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff82abbf_5930e4e8","line":137,"range":{"start_line":137,"start_character":38,"end_line":137,"end_character":42},"in_reply_to":"ff82abbf_87e5a40b","updated":"2017-11-24 11:30:35.000000000","message":"Indeed!","commit_id":"21382191a5fa5d7ea85658d8c35a31df11e4520a"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1301ced2a4dad5306fb212970c8408596ce37645","unresolved":false,"context_lines":[{"line_number":147,"context_line":"DIB_CLOUD_IMAGES"},{"line_number":148,"context_line":"    - Directory base URL to download the image from"},{"line_number":149,"context_line":"    - Default: depends on the distribution"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"RHEL specific variables"},{"line_number":152,"context_line":"------------------------"},{"line_number":153,"context_line":"Building a RHEL-based image requires:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f91af0f_e2460422","line":150,"updated":"2018-01-05 01:19:33.000000000","message":"In the patch comments you listed out an example, can we get that added here?\n\nHere is an example to build a CentOS amphora with Pike RPM files:\n\n# Get image\nwget https://cloud.centos.org/centos/7/images/CentOS-7-x86_64-GenericCloud-1711.qcow2\n# Add repository\nvirt-customize -a CentOS-7-x86_64-GenericCloud-1711.qcow2  --selinux-relabel --run-command \u0027yum install -y centos-release-openstack-pike\u0027\n# Point to modified image and run script\nexport DIB_LOCAL_IMAGE\u003d/home/stack/CentOS-7-x86_64-GenericCloud-1711.qcow2\n./diskimage-create.sh -p -i centos","commit_id":"687d5387d04b238b164b279e16583c000b7fccc5"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"a48dfbbc47f7b11778e8a3c3a08adcb6f710c8ef","unresolved":false,"context_lines":[{"line_number":147,"context_line":"DIB_CLOUD_IMAGES"},{"line_number":148,"context_line":"    - Directory base URL to download the image from"},{"line_number":149,"context_line":"    - Default: depends on the distribution"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"RHEL specific variables"},{"line_number":152,"context_line":"------------------------"},{"line_number":153,"context_line":"Building a RHEL-based image requires:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f91af0f_c8143551","line":150,"in_reply_to":"9f91af0f_e2460422","updated":"2018-01-05 15:29:06.000000000","message":"Sure, will add!","commit_id":"687d5387d04b238b164b279e16583c000b7fccc5"}],"diskimage-create/diskimage-create.sh":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"6e5a798787539c42b23a8c33450e1cfdbeafe2d2","unresolved":false,"context_lines":[{"line_number":328,"context_line":"else"},{"line_number":329,"context_line":"    AMP_element_sequence\u003d\"$AMP_element_sequence amphora-agent\""},{"line_number":330,"context_line":"    # SELinux policies may depend on other packages, run in permissive"},{"line_number":331,"context_line":"    AMP_element_sequence\u003d\"$AMP_element_sequence selinux-permissive\""},{"line_number":332,"context_line":"fi"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"# Add keepalived-octavia element"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ff82abbf_e715909d","line":331,"updated":"2017-11-24 11:15:29.000000000","message":"This changes the behavior for Ubuntu by adding selinux-permissive to the sequence. Did you do it on purpose?","commit_id":"21382191a5fa5d7ea85658d8c35a31df11e4520a"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"d58fd6e59cfa01e2595f23897d10a2ded3cbc2fa","unresolved":false,"context_lines":[{"line_number":328,"context_line":"else"},{"line_number":329,"context_line":"    AMP_element_sequence\u003d\"$AMP_element_sequence amphora-agent\""},{"line_number":330,"context_line":"    # SELinux policies may depend on other packages, run in permissive"},{"line_number":331,"context_line":"    AMP_element_sequence\u003d\"$AMP_element_sequence selinux-permissive\""},{"line_number":332,"context_line":"fi"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"# Add keepalived-octavia element"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ff82abbf_d972b4ad","line":331,"in_reply_to":"ff82abbf_e715909d","updated":"2017-11-24 11:30:35.000000000","message":"Yes, to limit the distro-specific checks. The selinux-permissive element is basically a no-op if selinux is not installed:\nhttps://github.com/openstack/diskimage-builder/blob/master/diskimage_builder/elements/selinux-permissive/install.d/11-selinux-permissive","commit_id":"21382191a5fa5d7ea85658d8c35a31df11e4520a"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1301ced2a4dad5306fb212970c8408596ce37645","unresolved":false,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"AMP_element_sequence\u003d${AMP_element_sequence:-\"base vm\"}"},{"line_number":308,"context_line":"if [ \"${AMP_BASEOS}\" \u003d \"centos\" ] || [ \"${AMP_BASEOS}\" \u003d \"rhel\" ]; then"},{"line_number":309,"context_line":"    AMP_element_sequence\u003d\"$AMP_element_sequence ${AMP_BASEOS}7\""},{"line_number":310,"context_line":"else"},{"line_number":311,"context_line":"    AMP_element_sequence\u003d\"$AMP_element_sequence ${AMP_BASEOS}\""},{"line_number":312,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9f91af0f_4261f0a8","line":309,"range":{"start_line":309,"start_character":61,"end_line":309,"end_character":62},"updated":"2018-01-05 01:19:33.000000000","message":"Should we be using the -d/AMP_DIB_RELEASE setting here? I hate having a version hard coded here.","commit_id":"687d5387d04b238b164b279e16583c000b7fccc5"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"a48dfbbc47f7b11778e8a3c3a08adcb6f710c8ef","unresolved":false,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"AMP_element_sequence\u003d${AMP_element_sequence:-\"base vm\"}"},{"line_number":308,"context_line":"if [ \"${AMP_BASEOS}\" \u003d \"centos\" ] || [ \"${AMP_BASEOS}\" \u003d \"rhel\" ]; then"},{"line_number":309,"context_line":"    AMP_element_sequence\u003d\"$AMP_element_sequence ${AMP_BASEOS}7\""},{"line_number":310,"context_line":"else"},{"line_number":311,"context_line":"    AMP_element_sequence\u003d\"$AMP_element_sequence ${AMP_BASEOS}\""},{"line_number":312,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9f91af0f_4b1d7f64","line":309,"range":{"start_line":309,"start_character":61,"end_line":309,"end_character":62},"in_reply_to":"9f91af0f_4261f0a8","updated":"2018-01-05 15:29:06.000000000","message":"Sure, I will use that, and set AMP_DIB_RELEASE to default to 7 for these two distros","commit_id":"687d5387d04b238b164b279e16583c000b7fccc5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a9a6d424321bc8987d23d93879e9b64398219ed8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    echo \"            [-a i386 | **amd64** | armhf ]\""},{"line_number":24,"context_line":"    echo \"            [-b **haproxy** ]\""},{"line_number":25,"context_line":"    echo \"            [-c **~/.cache/image-create** | \u003ccache directory\u003e ]\""},{"line_number":26,"context_line":"    echo \"            [-d **xenial** | trusty | \u003cother release id\u003e ]\""},{"line_number":27,"context_line":"    echo \"            [-h]\""},{"line_number":28,"context_line":"    echo \"            [-i **ubuntu** | fedora | centos | rhel ]\""},{"line_number":29,"context_line":"    echo \"            [-n]\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"7f96bb07_c062f716","line":26,"range":{"start_line":26,"start_character":26,"end_line":26,"end_character":36},"updated":"2018-01-22 23:31:34.000000000","message":"**xenial**/**7**","commit_id":"191d57361cd03354fc1eb2bf891c305fc00dd786"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"d0e899272ad6945f50a2f5ab398ca153cd938b78","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    echo \"            [-a i386 | **amd64** | armhf ]\""},{"line_number":24,"context_line":"    echo \"            [-b **haproxy** ]\""},{"line_number":25,"context_line":"    echo \"            [-c **~/.cache/image-create** | \u003ccache directory\u003e ]\""},{"line_number":26,"context_line":"    echo \"            [-d **xenial** | trusty | \u003cother release id\u003e ]\""},{"line_number":27,"context_line":"    echo \"            [-h]\""},{"line_number":28,"context_line":"    echo \"            [-i **ubuntu** | fedora | centos | rhel ]\""},{"line_number":29,"context_line":"    echo \"            [-n]\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"7f96bb07_0be6b417","line":26,"range":{"start_line":26,"start_character":26,"end_line":26,"end_character":36},"in_reply_to":"7f96bb07_c062f716","updated":"2018-01-23 10:29:27.000000000","message":"Done","commit_id":"191d57361cd03354fc1eb2bf891c305fc00dd786"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"230192be04290cbdc7001304ac6323e328129f60","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    echo \"        \u0027-a\u0027 is the architecture type for the image (default: amd64)\""},{"line_number":39,"context_line":"    echo \"        \u0027-b\u0027 is the backend type (default: haproxy)\""},{"line_number":40,"context_line":"    echo \"        \u0027-c\u0027 is the path to the cache directory (default: ~/.cache/image-create)\""},{"line_number":41,"context_line":"    echo \"        \u0027-d\u0027 distribution release id (default on ubuntu: xenial)\""},{"line_number":42,"context_line":"    echo \"        \u0027-h\u0027 display this help message\""},{"line_number":43,"context_line":"    echo \"        \u0027-i\u0027 is the base OS (default: ubuntu)\""},{"line_number":44,"context_line":"    echo \"        \u0027-n\u0027 disable sshd (default: enabled)\""}],"source_content_type":"text/x-sh","patch_set":8,"id":"7f96bb07_a1d47f48","line":41,"range":{"start_line":41,"start_character":48,"end_line":41,"end_character":73},"updated":"2018-01-23 10:36:10.000000000","message":"default: xenial (Ubuntu), 7 (RHEL/CentOS)","commit_id":"d43d3fce86040f6b7e190d83380e6f7106260202"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"c0feff7f1448bb0907dadce14b0098552d446a6c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    echo \"        \u0027-a\u0027 is the architecture type for the image (default: amd64)\""},{"line_number":39,"context_line":"    echo \"        \u0027-b\u0027 is the backend type (default: haproxy)\""},{"line_number":40,"context_line":"    echo \"        \u0027-c\u0027 is the path to the cache directory (default: ~/.cache/image-create)\""},{"line_number":41,"context_line":"    echo \"        \u0027-d\u0027 distribution release id (default on ubuntu: xenial)\""},{"line_number":42,"context_line":"    echo \"        \u0027-h\u0027 display this help message\""},{"line_number":43,"context_line":"    echo \"        \u0027-i\u0027 is the base OS (default: ubuntu)\""},{"line_number":44,"context_line":"    echo \"        \u0027-n\u0027 disable sshd (default: enabled)\""}],"source_content_type":"text/x-sh","patch_set":8,"id":"7f96bb07_41133b67","line":41,"range":{"start_line":41,"start_character":48,"end_line":41,"end_character":73},"in_reply_to":"7f96bb07_a1d47f48","updated":"2018-01-23 10:53:55.000000000","message":"Ack, I noted it for a later fix","commit_id":"d43d3fce86040f6b7e190d83380e6f7106260202"}],"elements/amphora-agent-package/README.rst":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"438ed60039124b20c1da18f0d2c611d8cedb5222","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Element to install an Octavia Amphora agent from distribution packages"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Note: this requires a sytem base image modified to include OpenStack"},{"line_number":4,"context_line":"repositories"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff82abbf_e2055412","line":3,"updated":"2017-11-27 20:46:36.000000000","message":"Why can\u0027t the element handle this?","commit_id":"9d6aeee71ebbdc906ae298c181240a7f0e9ef84c"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"8b029379b646848ad97aa0e472295a66d6c11135","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Element to install an Octavia Amphora agent from distribution packages"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Note: this requires a sytem base image modified to include OpenStack"},{"line_number":4,"context_line":"repositories"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff82abbf_b02228b8","line":3,"in_reply_to":"ff82abbf_e2055412","updated":"2017-11-28 11:07:58.000000000","message":"That was one comment by Nir too, who sugggested the package option could accept a parameter: the repo url (with the element handling it properly depending on system type)\n\nThough covering all cases (and distributions) may get complex between:\n* repositories with only a configuration file to download\n* repositories setup via other package (RDO stable example: \"yum install -y centos-release-openstack-pike\")\n* repositories setup via a separate configuration tool (dynamic configuration\n* local repo in image\n\nThe two last points can come in when integrating the script in a build system (for CentOS for example, to get images already built and available in RDO repositories)","commit_id":"9d6aeee71ebbdc906ae298c181240a7f0e9ef84c"}],"elements/amphora-agent-package/package-installs.yaml":[{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"bece120804eec745fce63e9ad479ed14fecfd76d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"openstack-octavia-amphora-agent:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff82abbf_91906a4c","line":1,"updated":"2017-11-27 08:42:34.000000000","message":"A suggestion (if you disagree, I\u0027m okay with the current name as well): will something like amphora-agent-distro-package be more descriptive here?","commit_id":"0fcc81e5e889b6881dd737a8243de1d4ba90fb23"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"939caa3e76505b752efa327917f76f9d68c4f859","unresolved":false,"context_lines":[{"line_number":1,"context_line":"openstack-octavia-amphora-agent:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff82abbf_97313a5d","line":1,"in_reply_to":"ff82abbf_91906a4c","updated":"2017-11-27 10:16:04.000000000","message":"It is the package (as in rpm/deb) name here, for now it is the same for CentOS/RHEL and openSUSE, Ubuntu does not have one yet\n\nThough this renaming can be done with a pkg-map mapping file I think","commit_id":"0fcc81e5e889b6881dd737a8243de1d4ba90fb23"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"438ed60039124b20c1da18f0d2c611d8cedb5222","unresolved":false,"context_lines":[{"line_number":1,"context_line":"openstack-octavia-amphora-agent:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff82abbf_42c76097","line":1,"updated":"2017-11-27 20:46:36.000000000","message":"The package-installs module can install packages for specific OS releases. Why can\u0027t we consolidate this into just one amphora-agent and use install types?\nhttps://docs.openstack.org/diskimage-builder/latest/user_guide/install_types.html\nhttps://github.com/openstack/diskimage-builder/tree/master/diskimage_builder/elements/package-installs","commit_id":"9d6aeee71ebbdc906ae298c181240a7f0e9ef84c"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"8b029379b646848ad97aa0e472295a66d6c11135","unresolved":false,"context_lines":[{"line_number":1,"context_line":"openstack-octavia-amphora-agent:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff82abbf_1063d4b3","line":1,"in_reply_to":"ff82abbf_42c76097","updated":"2017-11-28 11:07:58.000000000","message":"We can, I had missed that feature!\n\nSo the main script would set DIB_INSTALLTYPE_amphora_agent either to source or package, allowing to merge elements and be able to build both source and package based images","commit_id":"9d6aeee71ebbdc906ae298c181240a7f0e9ef84c"}],"elements/amphora-agent/README.rst":[{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"46fb3558662301e5f657582dc4acedf386c61870","unresolved":false,"context_lines":[{"line_number":4,"context_line":"distribution repositories, define the following:"},{"line_number":5,"context_line":"    export DIB_INSTALLTYPE_amphora_agent\u003dpackage"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Note: this requires a sytem base image modified to include OpenStack"},{"line_number":8,"context_line":"repositories"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff82abbf_b372cee2","line":7,"updated":"2017-12-01 13:09:48.000000000","message":"sytem -\u003e system","commit_id":"d1587781aac74f47840e5c9352f781ae656ad0e1"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"235285b17953def9646426be43f7532147c955d9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"distribution repositories, define the following:"},{"line_number":5,"context_line":"    export DIB_INSTALLTYPE_amphora_agent\u003dpackage"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Note: this requires a sytem base image modified to include OpenStack"},{"line_number":8,"context_line":"repositories"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff82abbf_a57cc172","line":7,"in_reply_to":"ff82abbf_b372cee2","updated":"2017-12-01 13:22:24.000000000","message":"Done","commit_id":"d1587781aac74f47840e5c9352f781ae656ad0e1"}],"elements/amphora-agent/element-deps":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a9a6d424321bc8987d23d93879e9b64398219ed8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7f96bb07_60fe8339","line":6,"updated":"2018-01-22 23:31:34.000000000","message":"svc-map","commit_id":"191d57361cd03354fc1eb2bf891c305fc00dd786"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"d0e899272ad6945f50a2f5ab398ca153cd938b78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7f96bb07_8ba084a7","line":6,"in_reply_to":"7f96bb07_60fe8339","updated":"2018-01-23 10:29:27.000000000","message":"Done","commit_id":"191d57361cd03354fc1eb2bf891c305fc00dd786"}],"elements/amphora-agent/install.d/amphora-agent-package-install/package-installs-amphora-agent":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1301ced2a4dad5306fb212970c8408596ce37645","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9f91af0f_4d77e1a1","updated":"2018-01-05 01:19:33.000000000","message":"This method is deprecated as listed here: https://github.com/openstack/diskimage-builder/tree/master/diskimage_builder/elements/package-installs#package-installs\n\nThere should be a package-installs file in the root of the element with the proper install types.","commit_id":"687d5387d04b238b164b279e16583c000b7fccc5"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"a48dfbbc47f7b11778e8a3c3a08adcb6f710c8ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9f91af0f_4bac9f33","in_reply_to":"9f91af0f_4d77e1a1","updated":"2018-01-05 15:29:06.000000000","message":"I had placed it here to only trigger when installing packages,\nbut I now see the root file has support for installtype value, so I will move this there","commit_id":"687d5387d04b238b164b279e16583c000b7fccc5"}],"elements/amphora-agent/install.d/amphora-agent-source-install/75-amphora-agent-install":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1301ced2a4dad5306fb212970c8408596ce37645","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"install -D -g root -o root -m 0644 ${SCRIPTDIR}/amphora-agent.logrotate /etc/logrotate.d/amphora-agent"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"case \"$DIB_INIT_SYSTEM\" in"},{"line_number":26,"context_line":"    upstart)"},{"line_number":27,"context_line":"        install -D -g root -o root -m 0644 ${SCRIPTDIR}/amphora-agent.conf /etc/init/amphora-agent.conf"},{"line_number":28,"context_line":"        ;;"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f91af0f_02e8c8b1","line":25,"updated":"2018-01-05 01:19:33.000000000","message":"DIB_INIT_SYSTEM no longer gets set as you have removed the dib-init-system element from element-deps","commit_id":"687d5387d04b238b164b279e16583c000b7fccc5"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"a48dfbbc47f7b11778e8a3c3a08adcb6f710c8ef","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"install -D -g root -o root -m 0644 ${SCRIPTDIR}/amphora-agent.logrotate /etc/logrotate.d/amphora-agent"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"case \"$DIB_INIT_SYSTEM\" in"},{"line_number":26,"context_line":"    upstart)"},{"line_number":27,"context_line":"        install -D -g root -o root -m 0644 ${SCRIPTDIR}/amphora-agent.conf /etc/init/amphora-agent.conf"},{"line_number":28,"context_line":"        ;;"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f91af0f_4bca5f6d","line":25,"in_reply_to":"9f91af0f_02e8c8b1","updated":"2018-01-05 15:29:06.000000000","message":"Nice catch, I probably had the correct value brought in as dep for certs-ramfs in my tests. I will readd it as dependency to this element","commit_id":"687d5387d04b238b164b279e16583c000b7fccc5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a9a6d424321bc8987d23d93879e9b64398219ed8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"SCRIPTDIR\u003d$(dirname $0)"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"install-packages build-essential libffi-dev libssl-dev python-dev"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"pip install -U -c /opt/upper-constraints.txt /opt/amphora-agent"},{"line_number":14,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"7f96bb07_a0ec8b8f","line":11,"updated":"2018-01-22 23:31:34.000000000","message":"This should really go back in package-installs","commit_id":"191d57361cd03354fc1eb2bf891c305fc00dd786"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"d0e899272ad6945f50a2f5ab398ca153cd938b78","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"SCRIPTDIR\u003d$(dirname $0)"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"install-packages build-essential libffi-dev libssl-dev python-dev"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"pip install -U -c /opt/upper-constraints.txt /opt/amphora-agent"},{"line_number":14,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"7f96bb07_0b947443","line":11,"in_reply_to":"7f96bb07_a0ec8b8f","updated":"2018-01-23 10:29:27.000000000","message":"Done","commit_id":"191d57361cd03354fc1eb2bf891c305fc00dd786"}],"elements/amphora-agent/install.d/amphora-agent-source-install/amphora-agent.logrotate":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1301ced2a4dad5306fb212970c8408596ce37645","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    delaycompress"},{"line_number":8,"context_line":"    sharedscripts"},{"line_number":9,"context_line":"    postrotate"},{"line_number":10,"context_line":"        kill -s USR1 $(cat /var/run/amphora-agent.pid)"},{"line_number":11,"context_line":"    endscript"},{"line_number":12,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"9f91af0f_22ee2c88","line":10,"range":{"start_line":10,"start_character":16,"end_line":10,"end_character":20},"updated":"2018-01-05 01:19:33.000000000","message":"Please cite the reference for this as commented on the commit message.","commit_id":"687d5387d04b238b164b279e16583c000b7fccc5"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"a48dfbbc47f7b11778e8a3c3a08adcb6f710c8ef","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    delaycompress"},{"line_number":8,"context_line":"    sharedscripts"},{"line_number":9,"context_line":"    postrotate"},{"line_number":10,"context_line":"        kill -s USR1 $(cat /var/run/amphora-agent.pid)"},{"line_number":11,"context_line":"    endscript"},{"line_number":12,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"9f91af0f_8baf07e2","line":10,"range":{"start_line":10,"start_character":16,"end_line":10,"end_character":20},"in_reply_to":"9f91af0f_22ee2c88","updated":"2018-01-05 15:29:06.000000000","message":"Done","commit_id":"687d5387d04b238b164b279e16583c000b7fccc5"}],"elements/amphora-agent/package-installs.yaml":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1301ced2a4dad5306fb212970c8408596ce37645","unresolved":false,"context_lines":[{"line_number":1,"context_line":"build-essential:"},{"line_number":2,"context_line":"libffi-dev:"},{"line_number":3,"context_line":"libssl-dev:"},{"line_number":4,"context_line":"python-dev:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f91af0f_2da93dde","side":"PARENT","line":4,"range":{"start_line":2,"start_character":0,"end_line":4,"end_character":11},"updated":"2018-01-05 01:19:33.000000000","message":"These aren\u0027t required to build the python dependency wheels anymore?","commit_id":"bb9bb2d05b268cff9846e0a09ad3940be5fe5a80"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"a48dfbbc47f7b11778e8a3c3a08adcb6f710c8ef","unresolved":false,"context_lines":[{"line_number":1,"context_line":"build-essential:"},{"line_number":2,"context_line":"libffi-dev:"},{"line_number":3,"context_line":"libssl-dev:"},{"line_number":4,"context_line":"python-dev:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f91af0f_0bbd37d7","side":"PARENT","line":4,"range":{"start_line":2,"start_character":0,"end_line":4,"end_character":11},"in_reply_to":"9f91af0f_2da93dde","updated":"2018-01-05 15:29:06.000000000","message":"Sorry I probably lost them why moving the step to elements/amphora-agent/install.d/amphora-agent-source-install/75-amphora-agent-install I will readd them to that file \n\n(moving the step in the source install element allows to skip installing all these packages on distribution systems)","commit_id":"bb9bb2d05b268cff9846e0a09ad3940be5fe5a80"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a9a6d424321bc8987d23d93879e9b64398219ed8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7f96bb07_80d06fcb","line":3,"updated":"2018-01-22 23:31:34.000000000","message":"Why aren\u0027t the old packages here under installtype source?","commit_id":"191d57361cd03354fc1eb2bf891c305fc00dd786"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"d0e899272ad6945f50a2f5ab398ca153cd938b78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7f96bb07_ab8c6035","line":3,"in_reply_to":"7f96bb07_80d06fcb","updated":"2018-01-23 10:29:27.000000000","message":"Done","commit_id":"191d57361cd03354fc1eb2bf891c305fc00dd786"}],"elements/amphora-agent/pkg-map":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a9a6d424321bc8987d23d93879e9b64398219ed8","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    }"},{"line_number":6,"context_line":"  },"},{"line_number":7,"context_line":"  \"default\": {"},{"line_number":8,"context_line":"    \"amphora-agent\": \"openstack-octavia-amphora-agent\""},{"line_number":9,"context_line":"  }"},{"line_number":10,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"7f96bb07_c0c67717","line":8,"updated":"2018-01-22 23:31:34.000000000","message":"I don\u0027t think this should be default, it seems like the source install should be default.","commit_id":"191d57361cd03354fc1eb2bf891c305fc00dd786"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"d0e899272ad6945f50a2f5ab398ca153cd938b78","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    }"},{"line_number":6,"context_line":"  },"},{"line_number":7,"context_line":"  \"default\": {"},{"line_number":8,"context_line":"    \"amphora-agent\": \"openstack-octavia-amphora-agent\""},{"line_number":9,"context_line":"  }"},{"line_number":10,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"7f96bb07_cb768c3f","line":8,"in_reply_to":"7f96bb07_c0c67717","updated":"2018-01-23 10:29:27.000000000","message":"Done","commit_id":"191d57361cd03354fc1eb2bf891c305fc00dd786"}],"elements/amphora-agent/post-install.d/11-enable-amphora-agent-systemd":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1301ced2a4dad5306fb212970c8408596ce37645","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9f91af0f_22394c40","updated":"2018-01-05 01:19:33.000000000","message":"By disabling the dib-init-system element the other init systems (openrc) do not get explicitly enabled. We aren\u0027t using this at the moment, but it\u0027s a side effect.","commit_id":"687d5387d04b238b164b279e16583c000b7fccc5"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"a48dfbbc47f7b11778e8a3c3a08adcb6f710c8ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9f91af0f_ebaed396","in_reply_to":"9f91af0f_22394c40","updated":"2018-01-05 15:29:06.000000000","message":"Support for openrc? Nice, another reason then to keep it then, along with elements/amphora-agent/install.d/amphora-agent-source-install/75-amphora-agent-install comment","commit_id":"687d5387d04b238b164b279e16583c000b7fccc5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1301ced2a4dad5306fb212970c8408596ce37645","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set -eu"},{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# Service name depends on install type"},{"line_number":10,"context_line":"if [[ -e /usr/lib/systemd/system/amphora-agent.service ]]; then"},{"line_number":11,"context_line":"    systemctl enable amphora-agent"},{"line_number":12,"context_line":"elif [[ -e /usr/lib/systemd/system/octavia-amphora-agent.service ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f91af0f_a27c7cb5","line":9,"updated":"2018-01-05 01:19:33.000000000","message":"Isn\u0027t this what svc-map is for?\nhttps://docs.openstack.org/diskimage-builder/latest/elements/svc-map/README.html","commit_id":"687d5387d04b238b164b279e16583c000b7fccc5"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"a48dfbbc47f7b11778e8a3c3a08adcb6f710c8ef","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set -eu"},{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# Service name depends on install type"},{"line_number":10,"context_line":"if [[ -e /usr/lib/systemd/system/amphora-agent.service ]]; then"},{"line_number":11,"context_line":"    systemctl enable amphora-agent"},{"line_number":12,"context_line":"elif [[ -e /usr/lib/systemd/system/octavia-amphora-agent.service ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f91af0f_2b183bd1","line":9,"in_reply_to":"9f91af0f_a27c7cb5","updated":"2018-01-05 15:29:06.000000000","message":"On same system, the file can have different names :( If coming from RPM, it will have the octavia- prefix (I think that comes from a naming convention):\nhttps://github.com/rdo-packages/octavia-distgit/blob/rpm-master/octavia-amphora-agent.service\n\nWhile source installation will not (from elements/amphora-agent/install.d/amphora-agent-source-install/ ).","commit_id":"687d5387d04b238b164b279e16583c000b7fccc5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a9a6d424321bc8987d23d93879e9b64398219ed8","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set -eu"},{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# Service name depends on install type"},{"line_number":10,"context_line":"if [[ -e /usr/lib/systemd/system/amphora-agent.service ]]; then"},{"line_number":11,"context_line":"    systemctl enable amphora-agent"},{"line_number":12,"context_line":"elif [[ -e /usr/lib/systemd/system/octavia-amphora-agent.service ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"7f96bb07_4055874f","line":9,"updated":"2018-01-22 23:31:34.000000000","message":"This should use svc-map","commit_id":"191d57361cd03354fc1eb2bf891c305fc00dd786"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"d0e899272ad6945f50a2f5ab398ca153cd938b78","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set -eu"},{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# Service name depends on install type"},{"line_number":10,"context_line":"if [[ -e /usr/lib/systemd/system/amphora-agent.service ]]; then"},{"line_number":11,"context_line":"    systemctl enable amphora-agent"},{"line_number":12,"context_line":"elif [[ -e /usr/lib/systemd/system/octavia-amphora-agent.service ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"7f96bb07_2b9db056","line":9,"in_reply_to":"7f96bb07_4055874f","updated":"2018-01-23 10:29:27.000000000","message":"Done","commit_id":"191d57361cd03354fc1eb2bf891c305fc00dd786"}],"elements/amphora-agent/svc-map":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1301ced2a4dad5306fb212970c8408596ce37645","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9f91af0f_026e8800","updated":"2018-01-05 01:19:33.000000000","message":"Why was this deleted?  This seems relevant for the RHEL/CentOS naming difference.","commit_id":"687d5387d04b238b164b279e16583c000b7fccc5"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"a48dfbbc47f7b11778e8a3c3a08adcb6f710c8ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9f91af0f_8bdb87eb","in_reply_to":"9f91af0f_026e8800","updated":"2018-01-05 15:29:06.000000000","message":"The logic was mostly moved to amphora-agent/post-install.d/11-enable-amphora-agent-systemd as the unit file can be named differently (I was not sure of side effect of renaming it here, and package file follows a naming convention)","commit_id":"687d5387d04b238b164b279e16583c000b7fccc5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a9a6d424321bc8987d23d93879e9b64398219ed8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7f96bb07_20715b0d","updated":"2018-01-22 23:31:34.000000000","message":"Since you are creating a different name for the systemd package this should still exist and include your distros.","commit_id":"191d57361cd03354fc1eb2bf891c305fc00dd786"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"d0e899272ad6945f50a2f5ab398ca153cd938b78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7f96bb07_cbabec72","in_reply_to":"7f96bb07_20715b0d","updated":"2018-01-23 10:29:27.000000000","message":"Done","commit_id":"191d57361cd03354fc1eb2bf891c305fc00dd786"}],"elements/rebind-sshd/finalise.d/98-rebind-sshd-after-dhcp":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a9a6d424321bc8987d23d93879e9b64398219ed8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Ubuntu-only action"},{"line_number":4,"context_line":"if [ \"$DISTRO_NAME\" !\u003d \"ubuntu\" ]; then"},{"line_number":5,"context_line":"    exit 0"},{"line_number":6,"context_line":"fi"},{"line_number":7,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"7f96bb07_a0856bd1","line":4,"updated":"2018-01-22 23:31:34.000000000","message":"This seems pretty blanket, why not list out the exceptions?","commit_id":"191d57361cd03354fc1eb2bf891c305fc00dd786"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"d0e899272ad6945f50a2f5ab398ca153cd938b78","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Ubuntu-only action"},{"line_number":4,"context_line":"if [ \"$DISTRO_NAME\" !\u003d \"ubuntu\" ]; then"},{"line_number":5,"context_line":"    exit 0"},{"line_number":6,"context_line":"fi"},{"line_number":7,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"7f96bb07_ebd4a8eb","line":4,"in_reply_to":"7f96bb07_a0856bd1","updated":"2018-01-23 10:29:27.000000000","message":"Done","commit_id":"191d57361cd03354fc1eb2bf891c305fc00dd786"}]}