)]}'
{"octavia/network/data_models.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"95cccbdef43b92e990e28c3ce64586ae78534a89","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        self.status \u003d status"},{"line_number":116,"context_line":"        self.router_id \u003d router_id"},{"line_number":117,"context_line":"        self.port_id \u003d port_id"},{"line_number":118,"context_line":"        self.floating_network_id \u003d floating_network_id"},{"line_number":119,"context_line":"        self.floating_ip_address \u003d floating_ip_address"},{"line_number":120,"context_line":"        self.fixed_ip_address \u003d fixed_ip_address"},{"line_number":121,"context_line":"        self.fixed_port_id \u003d fixed_port_id"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f91af0f_471be671","line":118,"updated":"2018-01-09 18:53:43.000000000","message":"See, this comes in from floating network id","commit_id":"1c44d1a9b5cbf0534ee72eca331541ce36bc7895"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"95cccbdef43b92e990e28c3ce64586ae78534a89","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        self.fixed_port_id \u003d fixed_port_id"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        # Need to provide this for compatibility in case it is used as a VIP"},{"line_number":124,"context_line":"        self.network_id \u003d floating_network_id"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class AmphoraNetworkConfig(data_models.BaseDataModel):"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f91af0f_072b9e82","line":124,"updated":"2018-01-09 18:53:43.000000000","message":"As does this -- see the comment! :P","commit_id":"1c44d1a9b5cbf0534ee72eca331541ce36bc7895"}],"octavia/network/drivers/neutron/utils.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b22c0fd5fb6abd762ea70af55906b354aa701b74","unresolved":false,"context_lines":[{"line_number":82,"context_line":"# We can\u0027t use \"floating_ip\" because we need to match the neutron client method"},{"line_number":83,"context_line":"def convert_floatingip_dict_to_model(floating_ip_dict):"},{"line_number":84,"context_line":"    floating_ip \u003d floating_ip_dict.get(\u0027floatingip\u0027, floating_ip_dict)"},{"line_number":85,"context_line":"    return network_models.FloatingIP("},{"line_number":86,"context_line":"        id\u003dfloating_ip.get(\u0027id\u0027),"},{"line_number":87,"context_line":"        description\u003dfloating_ip.get(\u0027description\u0027),"},{"line_number":88,"context_line":"        project_id\u003dfloating_ip.get(\u0027project_id\u0027, floating_ip.get(\u0027tenant_id\u0027)),"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f91af0f_598eb5d0","line":85,"updated":"2018-01-05 16:34:06.000000000","message":"The network_id isn\u0027t needed here?\n\nnetwork/data_models.py L#124","commit_id":"1c44d1a9b5cbf0534ee72eca331541ce36bc7895"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"95cccbdef43b92e990e28c3ce64586ae78534a89","unresolved":false,"context_lines":[{"line_number":82,"context_line":"# We can\u0027t use \"floating_ip\" because we need to match the neutron client method"},{"line_number":83,"context_line":"def convert_floatingip_dict_to_model(floating_ip_dict):"},{"line_number":84,"context_line":"    floating_ip \u003d floating_ip_dict.get(\u0027floatingip\u0027, floating_ip_dict)"},{"line_number":85,"context_line":"    return network_models.FloatingIP("},{"line_number":86,"context_line":"        id\u003dfloating_ip.get(\u0027id\u0027),"},{"line_number":87,"context_line":"        description\u003dfloating_ip.get(\u0027description\u0027),"},{"line_number":88,"context_line":"        project_id\u003dfloating_ip.get(\u0027project_id\u0027, floating_ip.get(\u0027tenant_id\u0027)),"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f91af0f_0b264acf","line":85,"in_reply_to":"9f91af0f_598eb5d0","updated":"2018-01-09 18:53:43.000000000","message":"That comes from \"floating_network_id\" which is below","commit_id":"1c44d1a9b5cbf0534ee72eca331541ce36bc7895"}],"octavia/tests/unit/network/drivers/neutron/test_utils.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b22c0fd5fb6abd762ea70af55906b354aa701b74","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            router_id\u003dt_constants.MOCK_ROUTER_ID,"},{"line_number":110,"context_line":"            port_id\u003dt_constants.MOCK_PORT_ID,"},{"line_number":111,"context_line":"            floating_network_id\u003dt_constants.MOCK_NETWORK_ID,"},{"line_number":112,"context_line":"            network_id\u003dt_constants.MOCK_NETWORK_ID,"},{"line_number":113,"context_line":"            floating_ip_address\u003dt_constants.MOCK_IP_ADDRESS,"},{"line_number":114,"context_line":"            fixed_ip_address\u003dt_constants.MOCK_IP_ADDRESS2,"},{"line_number":115,"context_line":"            fixed_port_id\u003dt_constants.MOCK_PORT_ID2"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f91af0f_d949658b","line":112,"updated":"2018-01-05 16:34:06.000000000","message":"How is this passing?\nThe model to dict doesn\u0027t have network_id in it.","commit_id":"1c44d1a9b5cbf0534ee72eca331541ce36bc7895"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"95cccbdef43b92e990e28c3ce64586ae78534a89","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            router_id\u003dt_constants.MOCK_ROUTER_ID,"},{"line_number":110,"context_line":"            port_id\u003dt_constants.MOCK_PORT_ID,"},{"line_number":111,"context_line":"            floating_network_id\u003dt_constants.MOCK_NETWORK_ID,"},{"line_number":112,"context_line":"            network_id\u003dt_constants.MOCK_NETWORK_ID,"},{"line_number":113,"context_line":"            floating_ip_address\u003dt_constants.MOCK_IP_ADDRESS,"},{"line_number":114,"context_line":"            fixed_ip_address\u003dt_constants.MOCK_IP_ADDRESS2,"},{"line_number":115,"context_line":"            fixed_port_id\u003dt_constants.MOCK_PORT_ID2"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f91af0f_e70a3a1e","line":112,"in_reply_to":"9f91af0f_d949658b","updated":"2018-01-09 18:53:43.000000000","message":"It does. It translates floating_network_id to network_id also for compatibility with the FixedIP model, while also maintaining the correctly named field for the FloatingIP upstream model.","commit_id":"1c44d1a9b5cbf0534ee72eca331541ce36bc7895"}]}