)]}'
{"octavia/amphorae/backends/utils/udp_check.sh":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d6f96c41454bf40d43a2cab52771bb5d7afa9864","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"/usr/bin/nc -uz -w1 $1 $2 | grep succeeded \u003e /dev/null"},{"line_number":3,"context_line":"exit $?"}],"source_content_type":"text/x-sh","patch_set":15,"id":"5f7c97a3_c3e37e33","line":2,"updated":"2018-05-11 18:19:51.000000000","message":"Two things here:\n1. This doesn\u0027t work for me without the \u0027-v\u0027 flag.\n2. I don\u0027t think we need the grep, nc should return a 0 status code for success and 1 for failure. At least it does on my host when testing with NTP ports.","commit_id":"d004d0f87d224e94ff8bfe400e062450311aae19"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"e8c08bc4ee0f1f38a9430d7b4f7b0af663ed5c30","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"/usr/bin/nc -uz -w1 $1 $2 | grep succeeded \u003e /dev/null"},{"line_number":3,"context_line":"exit $?"}],"source_content_type":"text/x-sh","patch_set":15,"id":"5f7c97a3_c51e0bba","line":2,"in_reply_to":"5f7c97a3_c3e37e33","updated":"2018-05-14 12:06:03.000000000","message":"Thanks, Michael, You are right. I will fix them you mentioned.","commit_id":"d004d0f87d224e94ff8bfe400e062450311aae19"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"c5af5d75c090cc5ca19931badb3e2ac5edf7b1e2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"nc_cmd\u003d`which nc`"},{"line_number":3,"context_line":"$nc_cmd -uzv -w1 $1 $2 \u003e /dev/null"},{"line_number":4,"context_line":"exit $?"}],"source_content_type":"text/x-sh","patch_set":43,"id":"5f7c97a3_5af8707c","line":3,"updated":"2018-08-01 16:01:08.000000000","message":"NIT: -v is superfluous since we post to /dev/null anyway\n-w1 -- https://developer.openstack.org/api-ref/load-balancer/v2/#create-health-monitor suggests this should be the timeout parameter","commit_id":"8dc83e545520df9df37287c61ee3da7811255db1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"19eb8a219ba965ccdb97c4d129149939d393cd78","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"nc_cmd\u003d`which nc`"},{"line_number":3,"context_line":"$nc_cmd -uzv -w1 $1 $2 \u003e /dev/null"},{"line_number":4,"context_line":"exit $?"}],"source_content_type":"text/x-sh","patch_set":43,"id":"5f7c97a3_bd2dfe45","line":3,"in_reply_to":"5f7c97a3_5af8707c","updated":"2018-08-01 16:34:03.000000000","message":"Agreed, -v is not really needed anymore.\nHowever, the -w 1 is required. This is maximum time it will stay connected to the remote port.\nSo I\u0027m not sure this is a good map to the HM timeout, which also applies here as a superset of this timeout. Unfortunately with nc, the connection timeout and idle timeout are the same setting, -w.\nMy vote is to leave this as is for now.  The HM timeout will still apply in the keepalived config.","commit_id":"8dc83e545520df9df37287c61ee3da7811255db1"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"5d2c5bc423499896eeb25cc495c50b0b3709c630","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"nc_cmd\u003d`which nc`"},{"line_number":3,"context_line":"$nc_cmd -uzv -w1 $1 $2 \u003e /dev/null"},{"line_number":4,"context_line":"exit $?"}],"source_content_type":"text/x-sh","patch_set":43,"id":"5f7c97a3_bd2adee2","line":3,"in_reply_to":"5f7c97a3_bd2dfe45","updated":"2018-08-01 16:44:37.000000000","message":"Thanks for kind review. Ha, just want to readable when I exec the srcipt. ;-)","commit_id":"8dc83e545520df9df37287c61ee3da7811255db1"}],"octavia/common/constants.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5c2cf7a1fb3dcdda95eb606a4767f9b492326c2a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"HEALTH_MONITOR_HTTP \u003d \u0027HTTP\u0027"},{"line_number":33,"context_line":"HEALTH_MONITOR_HTTPS \u003d \u0027HTTPS\u0027"},{"line_number":34,"context_line":"HEALTH_MONITOR_TLS_HELLO \u003d \u0027TLS-HELLO\u0027"},{"line_number":35,"context_line":"HEALTH_MONITOR_UDP_CONNECT \u003d \u0027UDP_CONNECT\u0027"},{"line_number":36,"context_line":"SUPPORTED_HEALTH_MONITOR_TYPES \u003d (HEALTH_MONITOR_HTTP, HEALTH_MONITOR_HTTPS,"},{"line_number":37,"context_line":"                                  HEALTH_MONITOR_PING, HEALTH_MONITOR_TCP,"},{"line_number":38,"context_line":"                                  HEALTH_MONITOR_TLS_HELLO)"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f7c97a3_9e9e8666","line":35,"range":{"start_line":35,"start_character":30,"end_line":35,"end_character":41},"updated":"2018-07-25 23:51:57.000000000","message":"This should be \u0027UDP-CONNECT\u0027 like TLS-HELLO above.","commit_id":"789e623ce1d852a78d744bfd2b0776fa335bbe8b"}],"octavia/common/jinja/lvs/jinja_cfg.py":[{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"b937c4060705b01d1f54a13bddc36611621ebc50","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import jinja2"},{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from octavia.common.config import cfg"},{"line_number":19,"context_line":"from octavia.common import constants"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_2ec71c15","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":9},"updated":"2018-01-26 06:56:43.000000000","message":"I100 Import statements are in the wrong order. import os should be before import jinja2\n\nI201 Missing newline before sections or imports.","commit_id":"897de0ed942887006ab0ca0f1fbd72cf037db40e"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"e067e6dd771b7000d777dbb09f62aa02b06c0b22","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import jinja2"},{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from octavia.common.config import cfg"},{"line_number":19,"context_line":"from octavia.common import constants"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_4cc15054","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":9},"in_reply_to":"5f93b717_2ec71c15","updated":"2018-01-26 08:06:30.000000000","message":"Done","commit_id":"897de0ed942887006ab0ca0f1fbd72cf037db40e"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"b937c4060705b01d1f54a13bddc36611621ebc50","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            ret_value[\u0027health_monitor\u0027] \u003d self._transform_health_monitor("},{"line_number":192,"context_line":"                pool.health_monitor)"},{"line_number":193,"context_line":"        if pool.session_persistence:"},{"line_number":194,"context_line":"            ret_value[\u0027session_persistence\u0027] \u003d \\"},{"line_number":195,"context_line":"                self._transform_session_persistence(pool.session_persistence)"},{"line_number":196,"context_line":"        return ret_value"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_6ee444ad","line":194,"updated":"2018-01-26 06:56:43.000000000","message":"O346 Backslash line continuations not allowed","commit_id":"897de0ed942887006ab0ca0f1fbd72cf037db40e"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"e067e6dd771b7000d777dbb09f62aa02b06c0b22","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            ret_value[\u0027health_monitor\u0027] \u003d self._transform_health_monitor("},{"line_number":192,"context_line":"                pool.health_monitor)"},{"line_number":193,"context_line":"        if pool.session_persistence:"},{"line_number":194,"context_line":"            ret_value[\u0027session_persistence\u0027] \u003d \\"},{"line_number":195,"context_line":"                self._transform_session_persistence(pool.session_persistence)"},{"line_number":196,"context_line":"        return ret_value"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_ecb5bcef","line":194,"in_reply_to":"5f93b717_6ee444ad","updated":"2018-01-26 08:06:30.000000000","message":"Done","commit_id":"897de0ed942887006ab0ca0f1fbd72cf037db40e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d6f96c41454bf40d43a2cab52771bb5d7afa9864","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    constants.LB_ALGORITHM_SOURCE_IP: \u0027sh\u0027"},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"BASE_PATH \u003d \u0027/var/lib/octavia\u0027"},{"line_number":34,"context_line":"BASE_CRT_DIR \u003d BASE_PATH + \u0027/certs\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"CHECK_SCRIPT_NAME \u003d \u0027udp_check.sh\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f7c97a3_23b0328a","line":33,"updated":"2018-05-11 18:19:51.000000000","message":"CONF.haproxy_amphora.base_path","commit_id":"d004d0f87d224e94ff8bfe400e062450311aae19"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"e8c08bc4ee0f1f38a9430d7b4f7b0af663ed5c30","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    constants.LB_ALGORITHM_SOURCE_IP: \u0027sh\u0027"},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"BASE_PATH \u003d \u0027/var/lib/octavia\u0027"},{"line_number":34,"context_line":"BASE_CRT_DIR \u003d BASE_PATH + \u0027/certs\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"CHECK_SCRIPT_NAME \u003d \u0027udp_check.sh\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f7c97a3_a57f4fde","line":33,"in_reply_to":"5f7c97a3_23b0328a","updated":"2018-05-14 12:06:03.000000000","message":"Done","commit_id":"d004d0f87d224e94ff8bfe400e062450311aae19"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d6f96c41454bf40d43a2cab52771bb5d7afa9864","unresolved":false,"context_lines":[{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"BASE_PATH \u003d \u0027/var/lib/octavia\u0027"},{"line_number":34,"context_line":"BASE_CRT_DIR \u003d BASE_PATH + \u0027/certs\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"CHECK_SCRIPT_NAME \u003d \u0027udp_check.sh\u0027"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"5f7c97a3_e3a55a48","line":34,"updated":"2018-05-11 18:19:51.000000000","message":"CONF.haproxy.base_cert_dir","commit_id":"d004d0f87d224e94ff8bfe400e062450311aae19"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"e8c08bc4ee0f1f38a9430d7b4f7b0af663ed5c30","unresolved":false,"context_lines":[{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"BASE_PATH \u003d \u0027/var/lib/octavia\u0027"},{"line_number":34,"context_line":"BASE_CRT_DIR \u003d BASE_PATH + \u0027/certs\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"CHECK_SCRIPT_NAME \u003d \u0027udp_check.sh\u0027"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"5f7c97a3_6585b7ce","line":34,"in_reply_to":"5f7c97a3_e3a55a48","updated":"2018-05-14 12:06:03.000000000","message":"Done","commit_id":"d004d0f87d224e94ff8bfe400e062450311aae19"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d6f96c41454bf40d43a2cab52771bb5d7afa9864","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        return JINJA_ENV.get_template(os.path.basename("},{"line_number":102,"context_line":"            self.keepalivedlvs_template))"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def render_loadbalancer_obj(self, host_amphora, listener, **kwargs):"},{"line_number":105,"context_line":"        \"\"\"Renders a templated configuration from a load balancer object"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        :param host_amphora: The Amphora this configuration is hosted on"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f7c97a3_1ef78dd5","line":104,"updated":"2018-05-11 18:19:51.000000000","message":"I think this is wrong and should just be render keepalived template without the rest of these transforms.","commit_id":"d004d0f87d224e94ff8bfe400e062450311aae19"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"e8c08bc4ee0f1f38a9430d7b4f7b0af663ed5c30","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        return JINJA_ENV.get_template(os.path.basename("},{"line_number":102,"context_line":"            self.keepalivedlvs_template))"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def render_loadbalancer_obj(self, host_amphora, listener, **kwargs):"},{"line_number":105,"context_line":"        \"\"\"Renders a templated configuration from a load balancer object"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        :param host_amphora: The Amphora this configuration is hosted on"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f7c97a3_cd263169","line":104,"in_reply_to":"5f7c97a3_1ef78dd5","updated":"2018-05-14 12:06:03.000000000","message":"I introduce these function for making the udp process logic clear, https://review.openstack.org/#/c/529651/17/octavia/amphorae/drivers/haproxy/rest_api_driver.py  . This is my original thought for make sure the code decoulping and simulate the haproxy jinja render the whole udp configuration.","commit_id":"d004d0f87d224e94ff8bfe400e062450311aae19"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d6f96c41454bf40d43a2cab52771bb5d7afa9864","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        }"},{"line_number":133,"context_line":"        return ret_value"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def _transform_amphora(self, amphora):"},{"line_number":136,"context_line":"        \"\"\"Transform an amphora into an object that will"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"           be processed by the templating system."}],"source_content_type":"text/x-python","patch_set":15,"id":"5f7c97a3_5e118503","line":135,"updated":"2018-05-11 18:19:51.000000000","message":"If this jinja_cfg is for the keepalived jinja template, why is all of this other stuff from octavia/common/jinja/haproxy/jinja_cfg.py in here?","commit_id":"d004d0f87d224e94ff8bfe400e062450311aae19"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"e8c08bc4ee0f1f38a9430d7b4f7b0af663ed5c30","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        }"},{"line_number":133,"context_line":"        return ret_value"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def _transform_amphora(self, amphora):"},{"line_number":136,"context_line":"        \"\"\"Transform an amphora into an object that will"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"           be processed by the templating system."}],"source_content_type":"text/x-python","patch_set":15,"id":"5f7c97a3_cda95190","line":135,"in_reply_to":"5f7c97a3_5e118503","updated":"2018-05-14 12:06:03.000000000","message":"Yeah, as my thought below, so I think it\u0027s better to accept the same parameters. This function is used by _transform_loadbalancer.","commit_id":"d004d0f87d224e94ff8bfe400e062450311aae19"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d6f96c41454bf40d43a2cab52771bb5d7afa9864","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            \u0027timeout\u0027: monitor.timeout,"},{"line_number":242,"context_line":"            \u0027enabled\u0027: monitor.enabled,"},{"line_number":243,"context_line":"            \u0027fall_threshold\u0027: monitor.fall_threshold,"},{"line_number":244,"context_line":"            \u0027check_script_path\u0027: (self._get_default_lvs_check_script_path()"},{"line_number":245,"context_line":"                                  if monitor.type \u003d\u003d"},{"line_number":246,"context_line":"                                  constants.HEALTH_MONITOR_UDP_CONNECT else"},{"line_number":247,"context_line":"                                  None)"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f7c97a3_5e5c25ec","line":244,"updated":"2018-05-11 18:19:51.000000000","message":"Why didn\u0027t we just merge this into the existing haproxy jinja?\nhttps://github.com/openstack/octavia/blob/master/octavia/common/jinja/haproxy/jinja_cfg.py\nI don\u0027t like  having two different jinja_cfg for the same configuration files. We should be able to merge it into the existing file and use conditionals in the jinja to make the right choices.","commit_id":"d004d0f87d224e94ff8bfe400e062450311aae19"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"e8c08bc4ee0f1f38a9430d7b4f7b0af663ed5c30","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            \u0027timeout\u0027: monitor.timeout,"},{"line_number":242,"context_line":"            \u0027enabled\u0027: monitor.enabled,"},{"line_number":243,"context_line":"            \u0027fall_threshold\u0027: monitor.fall_threshold,"},{"line_number":244,"context_line":"            \u0027check_script_path\u0027: (self._get_default_lvs_check_script_path()"},{"line_number":245,"context_line":"                                  if monitor.type \u003d\u003d"},{"line_number":246,"context_line":"                                  constants.HEALTH_MONITOR_UDP_CONNECT else"},{"line_number":247,"context_line":"                                  None)"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f7c97a3_cd0cf195","line":244,"in_reply_to":"5f7c97a3_5e5c25ec","updated":"2018-05-14 12:06:03.000000000","message":"@Micheal, do you mean merge this whole file into haproxy/jinja_cfg?  And using the listener protocol for generating the haproxy or lvs configuration, that\u0027s just my thought, as if we not using protocol \u0027UDP\u0027 to split these 2 cases, I\u0027m afaid the terrible conditional check would be. If you have time, could you please have a look https://review.openstack.org/#/c/525420/15/octavia/tests/unit/common/jinja/lvs/test_lvs_jinja_cfg.py , the test mentioned what I want to say.","commit_id":"d004d0f87d224e94ff8bfe400e062450311aae19"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"44761bb078e7870d8843dd9c28245a05962293c4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"BASE_PATH \u003d CONF.haproxy_amphora.base_path"},{"line_number":37,"context_line":"BASE_CRT_DIR \u003d CONF.haproxy_amphora.base_cert_dir"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"CHECK_SCRIPT_NAME \u003d \u0027udp_check.sh\u0027"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_be33cf60","line":37,"updated":"2018-06-25 22:03:49.000000000","message":"This is not used and should be removed.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"aa39d36401725d2cf9ed6344f96e779123c6e1e3","unresolved":false,"context_lines":[{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"BASE_PATH \u003d CONF.haproxy_amphora.base_path"},{"line_number":37,"context_line":"BASE_CRT_DIR \u003d CONF.haproxy_amphora.base_cert_dir"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"CHECK_SCRIPT_NAME \u003d \u0027udp_check.sh\u0027"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_0762af3e","line":37,"in_reply_to":"5f7c97a3_be33cf60","updated":"2018-06-26 07:21:38.000000000","message":"Done","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"44761bb078e7870d8843dd9c28245a05962293c4","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def __init__(self,"},{"line_number":51,"context_line":"                 base_amp_path\u003dNone,"},{"line_number":52,"context_line":"                 base_crt_dir\u003dNone,"},{"line_number":53,"context_line":"                 keepalivedlvs_template\u003dNone,"},{"line_number":54,"context_line":"                 log_http\u003dNone,"},{"line_number":55,"context_line":"                 log_server\u003dNone,"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_1e4443b7","line":52,"updated":"2018-06-25 22:03:49.000000000","message":"This is not used and should be removed.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"aa39d36401725d2cf9ed6344f96e779123c6e1e3","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def __init__(self,"},{"line_number":51,"context_line":"                 base_amp_path\u003dNone,"},{"line_number":52,"context_line":"                 base_crt_dir\u003dNone,"},{"line_number":53,"context_line":"                 keepalivedlvs_template\u003dNone,"},{"line_number":54,"context_line":"                 log_http\u003dNone,"},{"line_number":55,"context_line":"                 log_server\u003dNone,"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_27656b45","line":52,"in_reply_to":"5f7c97a3_1e4443b7","updated":"2018-06-26 07:21:38.000000000","message":"Done","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"44761bb078e7870d8843dd9c28245a05962293c4","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                 base_amp_path\u003dNone,"},{"line_number":52,"context_line":"                 base_crt_dir\u003dNone,"},{"line_number":53,"context_line":"                 keepalivedlvs_template\u003dNone,"},{"line_number":54,"context_line":"                 log_http\u003dNone,"},{"line_number":55,"context_line":"                 log_server\u003dNone,"},{"line_number":56,"context_line":"                 timeout_client\u003dNone,"},{"line_number":57,"context_line":"                 timeout_server\u003dNone,"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_3e6d7f2e","line":54,"updated":"2018-06-25 22:03:49.000000000","message":"This is not used and should be removed.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"aa39d36401725d2cf9ed6344f96e779123c6e1e3","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                 base_amp_path\u003dNone,"},{"line_number":52,"context_line":"                 base_crt_dir\u003dNone,"},{"line_number":53,"context_line":"                 keepalivedlvs_template\u003dNone,"},{"line_number":54,"context_line":"                 log_http\u003dNone,"},{"line_number":55,"context_line":"                 log_server\u003dNone,"},{"line_number":56,"context_line":"                 timeout_client\u003dNone,"},{"line_number":57,"context_line":"                 timeout_server\u003dNone,"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_c757d759","line":54,"in_reply_to":"5f7c97a3_3e6d7f2e","updated":"2018-06-26 07:21:38.000000000","message":"Done","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"44761bb078e7870d8843dd9c28245a05962293c4","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                 base_crt_dir\u003dNone,"},{"line_number":53,"context_line":"                 keepalivedlvs_template\u003dNone,"},{"line_number":54,"context_line":"                 log_http\u003dNone,"},{"line_number":55,"context_line":"                 log_server\u003dNone,"},{"line_number":56,"context_line":"                 timeout_client\u003dNone,"},{"line_number":57,"context_line":"                 timeout_server\u003dNone,"},{"line_number":58,"context_line":"                 timeout_connect\u003dNone):"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_dec6cb16","line":55,"updated":"2018-06-25 22:03:49.000000000","message":"This is not used and should be removed.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"aa39d36401725d2cf9ed6344f96e779123c6e1e3","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                 base_crt_dir\u003dNone,"},{"line_number":53,"context_line":"                 keepalivedlvs_template\u003dNone,"},{"line_number":54,"context_line":"                 log_http\u003dNone,"},{"line_number":55,"context_line":"                 log_server\u003dNone,"},{"line_number":56,"context_line":"                 timeout_client\u003dNone,"},{"line_number":57,"context_line":"                 timeout_server\u003dNone,"},{"line_number":58,"context_line":"                 timeout_connect\u003dNone):"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_e75a1380","line":55,"in_reply_to":"5f7c97a3_dec6cb16","updated":"2018-06-26 07:21:38.000000000","message":"Done","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"44761bb078e7870d8843dd9c28245a05962293c4","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                 keepalivedlvs_template\u003dNone,"},{"line_number":54,"context_line":"                 log_http\u003dNone,"},{"line_number":55,"context_line":"                 log_server\u003dNone,"},{"line_number":56,"context_line":"                 timeout_client\u003dNone,"},{"line_number":57,"context_line":"                 timeout_server\u003dNone,"},{"line_number":58,"context_line":"                 timeout_connect\u003dNone):"},{"line_number":59,"context_line":"        \"\"\"Keepalived LVS configuration generation"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_3ef49f54","line":56,"updated":"2018-06-25 22:03:49.000000000","message":"This is not used and should be removed.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"aa39d36401725d2cf9ed6344f96e779123c6e1e3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                 keepalivedlvs_template\u003dNone,"},{"line_number":54,"context_line":"                 log_http\u003dNone,"},{"line_number":55,"context_line":"                 log_server\u003dNone,"},{"line_number":56,"context_line":"                 timeout_client\u003dNone,"},{"line_number":57,"context_line":"                 timeout_server\u003dNone,"},{"line_number":58,"context_line":"                 timeout_connect\u003dNone):"},{"line_number":59,"context_line":"        \"\"\"Keepalived LVS configuration generation"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_a7509b5f","line":56,"in_reply_to":"5f7c97a3_3ef49f54","updated":"2018-06-26 07:21:38.000000000","message":"Done","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"44761bb078e7870d8843dd9c28245a05962293c4","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                 log_http\u003dNone,"},{"line_number":55,"context_line":"                 log_server\u003dNone,"},{"line_number":56,"context_line":"                 timeout_client\u003dNone,"},{"line_number":57,"context_line":"                 timeout_server\u003dNone,"},{"line_number":58,"context_line":"                 timeout_connect\u003dNone):"},{"line_number":59,"context_line":"        \"\"\"Keepalived LVS configuration generation"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_de948bea","line":57,"updated":"2018-06-25 22:03:49.000000000","message":"This is not used and should be removed.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"aa39d36401725d2cf9ed6344f96e779123c6e1e3","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                 log_http\u003dNone,"},{"line_number":55,"context_line":"                 log_server\u003dNone,"},{"line_number":56,"context_line":"                 timeout_client\u003dNone,"},{"line_number":57,"context_line":"                 timeout_server\u003dNone,"},{"line_number":58,"context_line":"                 timeout_connect\u003dNone):"},{"line_number":59,"context_line":"        \"\"\"Keepalived LVS configuration generation"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_474bc7af","line":57,"in_reply_to":"5f7c97a3_de948bea","updated":"2018-06-26 07:21:38.000000000","message":"Done","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"44761bb078e7870d8843dd9c28245a05962293c4","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                 log_server\u003dNone,"},{"line_number":56,"context_line":"                 timeout_client\u003dNone,"},{"line_number":57,"context_line":"                 timeout_server\u003dNone,"},{"line_number":58,"context_line":"                 timeout_connect\u003dNone):"},{"line_number":59,"context_line":"        \"\"\"Keepalived LVS configuration generation"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        :param base_amp_path: Base path for amphora data"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_fe9707ea","line":58,"updated":"2018-06-25 22:03:49.000000000","message":"This is not used and should be removed.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"aa39d36401725d2cf9ed6344f96e779123c6e1e3","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                 log_server\u003dNone,"},{"line_number":56,"context_line":"                 timeout_client\u003dNone,"},{"line_number":57,"context_line":"                 timeout_server\u003dNone,"},{"line_number":58,"context_line":"                 timeout_connect\u003dNone):"},{"line_number":59,"context_line":"        \"\"\"Keepalived LVS configuration generation"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        :param base_amp_path: Base path for amphora data"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_674603aa","line":58,"in_reply_to":"5f7c97a3_fe9707ea","updated":"2018-06-26 07:21:38.000000000","message":"Done","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"44761bb078e7870d8843dd9c28245a05962293c4","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        \"\"\"Keepalived LVS configuration generation"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        :param base_amp_path: Base path for amphora data"},{"line_number":62,"context_line":"        :param base_crt_dir: Base directory for certificate storage"},{"line_number":63,"context_line":"        :param keepalivedlvs_template: Absolute path to Jinja template"},{"line_number":64,"context_line":"        :param log_http: logging path"},{"line_number":65,"context_line":"        :param log_server: erver logging path"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_de132bb7","line":62,"updated":"2018-06-25 22:03:49.000000000","message":"This is not used and should be removed.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"aa39d36401725d2cf9ed6344f96e779123c6e1e3","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        \"\"\"Keepalived LVS configuration generation"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        :param base_amp_path: Base path for amphora data"},{"line_number":62,"context_line":"        :param base_crt_dir: Base directory for certificate storage"},{"line_number":63,"context_line":"        :param keepalivedlvs_template: Absolute path to Jinja template"},{"line_number":64,"context_line":"        :param log_http: logging path"},{"line_number":65,"context_line":"        :param log_server: erver logging path"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_07c70f14","line":62,"in_reply_to":"5f7c97a3_de132bb7","updated":"2018-06-26 07:21:38.000000000","message":"Done","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"44761bb078e7870d8843dd9c28245a05962293c4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        :param base_amp_path: Base path for amphora data"},{"line_number":62,"context_line":"        :param base_crt_dir: Base directory for certificate storage"},{"line_number":63,"context_line":"        :param keepalivedlvs_template: Absolute path to Jinja template"},{"line_number":64,"context_line":"        :param log_http: logging path"},{"line_number":65,"context_line":"        :param log_server: erver logging path"},{"line_number":66,"context_line":"        :param timeout_client: Timeout client"},{"line_number":67,"context_line":"        :param timeout_server: Timeout server"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_de61eb3a","line":64,"updated":"2018-06-25 22:03:49.000000000","message":"This is not used and should be removed.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"aa39d36401725d2cf9ed6344f96e779123c6e1e3","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        :param base_amp_path: Base path for amphora data"},{"line_number":62,"context_line":"        :param base_crt_dir: Base directory for certificate storage"},{"line_number":63,"context_line":"        :param keepalivedlvs_template: Absolute path to Jinja template"},{"line_number":64,"context_line":"        :param log_http: logging path"},{"line_number":65,"context_line":"        :param log_server: erver logging path"},{"line_number":66,"context_line":"        :param timeout_client: Timeout client"},{"line_number":67,"context_line":"        :param timeout_server: Timeout server"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_27f32b75","line":64,"in_reply_to":"5f7c97a3_de61eb3a","updated":"2018-06-26 07:21:38.000000000","message":"Done","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"44761bb078e7870d8843dd9c28245a05962293c4","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        :param base_crt_dir: Base directory for certificate storage"},{"line_number":63,"context_line":"        :param keepalivedlvs_template: Absolute path to Jinja template"},{"line_number":64,"context_line":"        :param log_http: logging path"},{"line_number":65,"context_line":"        :param log_server: erver logging path"},{"line_number":66,"context_line":"        :param timeout_client: Timeout client"},{"line_number":67,"context_line":"        :param timeout_server: Timeout server"},{"line_number":68,"context_line":"        :param timeout_connect: Timeout connect"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_fec94724","line":65,"updated":"2018-06-25 22:03:49.000000000","message":"This is not used and should be removed.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"aa39d36401725d2cf9ed6344f96e779123c6e1e3","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        :param base_crt_dir: Base directory for certificate storage"},{"line_number":63,"context_line":"        :param keepalivedlvs_template: Absolute path to Jinja template"},{"line_number":64,"context_line":"        :param log_http: logging path"},{"line_number":65,"context_line":"        :param log_server: erver logging path"},{"line_number":66,"context_line":"        :param timeout_client: Timeout client"},{"line_number":67,"context_line":"        :param timeout_server: Timeout server"},{"line_number":68,"context_line":"        :param timeout_connect: Timeout connect"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_07f06f66","line":65,"in_reply_to":"5f7c97a3_fec94724","updated":"2018-06-26 07:21:38.000000000","message":"Done","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"44761bb078e7870d8843dd9c28245a05962293c4","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        :param keepalivedlvs_template: Absolute path to Jinja template"},{"line_number":64,"context_line":"        :param log_http: logging path"},{"line_number":65,"context_line":"        :param log_server: erver logging path"},{"line_number":66,"context_line":"        :param timeout_client: Timeout client"},{"line_number":67,"context_line":"        :param timeout_server: Timeout server"},{"line_number":68,"context_line":"        :param timeout_connect: Timeout connect"},{"line_number":69,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_9e9a9310","line":66,"updated":"2018-06-25 22:03:49.000000000","message":"This is not used and should be removed.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"aa39d36401725d2cf9ed6344f96e779123c6e1e3","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        :param keepalivedlvs_template: Absolute path to Jinja template"},{"line_number":64,"context_line":"        :param log_http: logging path"},{"line_number":65,"context_line":"        :param log_server: erver logging path"},{"line_number":66,"context_line":"        :param timeout_client: Timeout client"},{"line_number":67,"context_line":"        :param timeout_server: Timeout server"},{"line_number":68,"context_line":"        :param timeout_connect: Timeout connect"},{"line_number":69,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_67db63e9","line":66,"in_reply_to":"5f7c97a3_9e9a9310","updated":"2018-06-26 07:21:38.000000000","message":"Done","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"44761bb078e7870d8843dd9c28245a05962293c4","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        :param log_http: logging path"},{"line_number":65,"context_line":"        :param log_server: erver logging path"},{"line_number":66,"context_line":"        :param timeout_client: Timeout client"},{"line_number":67,"context_line":"        :param timeout_server: Timeout server"},{"line_number":68,"context_line":"        :param timeout_connect: Timeout connect"},{"line_number":69,"context_line":"        \"\"\""},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_be9d0f0a","line":67,"updated":"2018-06-25 22:03:49.000000000","message":"This is not used and should be removed.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"aa39d36401725d2cf9ed6344f96e779123c6e1e3","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        :param log_http: logging path"},{"line_number":65,"context_line":"        :param log_server: erver logging path"},{"line_number":66,"context_line":"        :param timeout_client: Timeout client"},{"line_number":67,"context_line":"        :param timeout_server: Timeout server"},{"line_number":68,"context_line":"        :param timeout_connect: Timeout connect"},{"line_number":69,"context_line":"        \"\"\""},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_47e0a797","line":67,"in_reply_to":"5f7c97a3_be9d0f0a","updated":"2018-06-26 07:21:38.000000000","message":"Done","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"44761bb078e7870d8843dd9c28245a05962293c4","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        :param log_server: erver logging path"},{"line_number":66,"context_line":"        :param timeout_client: Timeout client"},{"line_number":67,"context_line":"        :param timeout_server: Timeout server"},{"line_number":68,"context_line":"        :param timeout_connect: Timeout connect"},{"line_number":69,"context_line":"        \"\"\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        self.base_amp_path \u003d base_amp_path or BASE_PATH"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_7e83f7a9","line":68,"updated":"2018-06-25 22:03:49.000000000","message":"This is not used and should be removed.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"aa39d36401725d2cf9ed6344f96e779123c6e1e3","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        :param log_server: erver logging path"},{"line_number":66,"context_line":"        :param timeout_client: Timeout client"},{"line_number":67,"context_line":"        :param timeout_server: Timeout server"},{"line_number":68,"context_line":"        :param timeout_connect: Timeout connect"},{"line_number":69,"context_line":"        \"\"\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        self.base_amp_path \u003d base_amp_path or BASE_PATH"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_a7d5fbb8","line":68,"in_reply_to":"5f7c97a3_7e83f7a9","updated":"2018-06-26 07:21:38.000000000","message":"Done","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"44761bb078e7870d8843dd9c28245a05962293c4","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        \"\"\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        self.base_amp_path \u003d base_amp_path or BASE_PATH"},{"line_number":72,"context_line":"        self.base_crt_dir \u003d base_crt_dir or BASE_CRT_DIR"},{"line_number":73,"context_line":"        self.keepalivedlvs_template \u003d (keepalivedlvs_template or"},{"line_number":74,"context_line":"                                       KEEPALIVED_LVS_TEMPLATE)"},{"line_number":75,"context_line":"        self.log_http \u003d log_http"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_3eea5f9f","line":72,"updated":"2018-06-25 22:03:49.000000000","message":"This is not used and should be removed.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"aa39d36401725d2cf9ed6344f96e779123c6e1e3","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        \"\"\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        self.base_amp_path \u003d base_amp_path or BASE_PATH"},{"line_number":72,"context_line":"        self.base_crt_dir \u003d base_crt_dir or BASE_CRT_DIR"},{"line_number":73,"context_line":"        self.keepalivedlvs_template \u003d (keepalivedlvs_template or"},{"line_number":74,"context_line":"                                       KEEPALIVED_LVS_TEMPLATE)"},{"line_number":75,"context_line":"        self.log_http \u003d log_http"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_e7cf7325","line":72,"in_reply_to":"5f7c97a3_3eea5f9f","updated":"2018-06-26 07:21:38.000000000","message":"Done","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"44761bb078e7870d8843dd9c28245a05962293c4","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self.base_crt_dir \u003d base_crt_dir or BASE_CRT_DIR"},{"line_number":73,"context_line":"        self.keepalivedlvs_template \u003d (keepalivedlvs_template or"},{"line_number":74,"context_line":"                                       KEEPALIVED_LVS_TEMPLATE)"},{"line_number":75,"context_line":"        self.log_http \u003d log_http"},{"line_number":76,"context_line":"        self.log_server \u003d log_server"},{"line_number":77,"context_line":"        self.timeout_client \u003d timeout_client"},{"line_number":78,"context_line":"        self.timeout_server \u003d timeout_server"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_9e57f35a","line":75,"updated":"2018-06-25 22:03:49.000000000","message":"This is not used and should be removed.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"aa39d36401725d2cf9ed6344f96e779123c6e1e3","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self.base_crt_dir \u003d base_crt_dir or BASE_CRT_DIR"},{"line_number":73,"context_line":"        self.keepalivedlvs_template \u003d (keepalivedlvs_template or"},{"line_number":74,"context_line":"                                       KEEPALIVED_LVS_TEMPLATE)"},{"line_number":75,"context_line":"        self.log_http \u003d log_http"},{"line_number":76,"context_line":"        self.log_server \u003d log_server"},{"line_number":77,"context_line":"        self.timeout_client \u003d timeout_client"},{"line_number":78,"context_line":"        self.timeout_server \u003d timeout_server"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_c7ccb735","line":75,"in_reply_to":"5f7c97a3_9e57f35a","updated":"2018-06-26 07:21:38.000000000","message":"Done","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"44761bb078e7870d8843dd9c28245a05962293c4","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        self.keepalivedlvs_template \u003d (keepalivedlvs_template or"},{"line_number":74,"context_line":"                                       KEEPALIVED_LVS_TEMPLATE)"},{"line_number":75,"context_line":"        self.log_http \u003d log_http"},{"line_number":76,"context_line":"        self.log_server \u003d log_server"},{"line_number":77,"context_line":"        self.timeout_client \u003d timeout_client"},{"line_number":78,"context_line":"        self.timeout_server \u003d timeout_server"},{"line_number":79,"context_line":"        self.timeout_connect \u003d timeout_connect"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_9eccd334","line":76,"updated":"2018-06-25 22:03:49.000000000","message":"This is not used and should be removed.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"aa39d36401725d2cf9ed6344f96e779123c6e1e3","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        self.keepalivedlvs_template \u003d (keepalivedlvs_template or"},{"line_number":74,"context_line":"                                       KEEPALIVED_LVS_TEMPLATE)"},{"line_number":75,"context_line":"        self.log_http \u003d log_http"},{"line_number":76,"context_line":"        self.log_server \u003d log_server"},{"line_number":77,"context_line":"        self.timeout_client \u003d timeout_client"},{"line_number":78,"context_line":"        self.timeout_server \u003d timeout_server"},{"line_number":79,"context_line":"        self.timeout_connect \u003d timeout_connect"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_e7e8d37b","line":76,"in_reply_to":"5f7c97a3_9eccd334","updated":"2018-06-26 07:21:38.000000000","message":"Done","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"44761bb078e7870d8843dd9c28245a05962293c4","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                                       KEEPALIVED_LVS_TEMPLATE)"},{"line_number":75,"context_line":"        self.log_http \u003d log_http"},{"line_number":76,"context_line":"        self.log_server \u003d log_server"},{"line_number":77,"context_line":"        self.timeout_client \u003d timeout_client"},{"line_number":78,"context_line":"        self.timeout_server \u003d timeout_server"},{"line_number":79,"context_line":"        self.timeout_connect \u003d timeout_connect"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_1e8e83d0","line":77,"updated":"2018-06-25 22:03:49.000000000","message":"This is not used and should be removed.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"aa39d36401725d2cf9ed6344f96e779123c6e1e3","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                                       KEEPALIVED_LVS_TEMPLATE)"},{"line_number":75,"context_line":"        self.log_http \u003d log_http"},{"line_number":76,"context_line":"        self.log_server \u003d log_server"},{"line_number":77,"context_line":"        self.timeout_client \u003d timeout_client"},{"line_number":78,"context_line":"        self.timeout_server \u003d timeout_server"},{"line_number":79,"context_line":"        self.timeout_connect \u003d timeout_connect"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_87031f42","line":77,"in_reply_to":"5f7c97a3_1e8e83d0","updated":"2018-06-26 07:21:38.000000000","message":"Done","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"44761bb078e7870d8843dd9c28245a05962293c4","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.log_http \u003d log_http"},{"line_number":76,"context_line":"        self.log_server \u003d log_server"},{"line_number":77,"context_line":"        self.timeout_client \u003d timeout_client"},{"line_number":78,"context_line":"        self.timeout_server \u003d timeout_server"},{"line_number":79,"context_line":"        self.timeout_connect \u003d timeout_connect"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def build_config(self, listener, **kwargs):"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_3e89ffc5","line":78,"updated":"2018-06-25 22:03:49.000000000","message":"This is not used and should be removed.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"aa39d36401725d2cf9ed6344f96e779123c6e1e3","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.log_http \u003d log_http"},{"line_number":76,"context_line":"        self.log_server \u003d log_server"},{"line_number":77,"context_line":"        self.timeout_client \u003d timeout_client"},{"line_number":78,"context_line":"        self.timeout_server \u003d timeout_server"},{"line_number":79,"context_line":"        self.timeout_connect \u003d timeout_connect"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def build_config(self, listener, **kwargs):"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_a7fe5b35","line":78,"in_reply_to":"5f7c97a3_3e89ffc5","updated":"2018-06-26 07:21:38.000000000","message":"Done","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"44761bb078e7870d8843dd9c28245a05962293c4","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.log_server \u003d log_server"},{"line_number":77,"context_line":"        self.timeout_client \u003d timeout_client"},{"line_number":78,"context_line":"        self.timeout_server \u003d timeout_server"},{"line_number":79,"context_line":"        self.timeout_connect \u003d timeout_connect"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def build_config(self, listener, **kwargs):"},{"line_number":82,"context_line":"        \"\"\"Convert a logical configuration to the Keepalived LVS version"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_debd6b68","line":79,"updated":"2018-06-25 22:03:49.000000000","message":"This is not used and should be removed.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"aa39d36401725d2cf9ed6344f96e779123c6e1e3","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.log_server \u003d log_server"},{"line_number":77,"context_line":"        self.timeout_client \u003d timeout_client"},{"line_number":78,"context_line":"        self.timeout_server \u003d timeout_server"},{"line_number":79,"context_line":"        self.timeout_connect \u003d timeout_connect"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def build_config(self, listener, **kwargs):"},{"line_number":82,"context_line":"        \"\"\"Convert a logical configuration to the Keepalived LVS version"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_676da32d","line":79,"in_reply_to":"5f7c97a3_debd6b68","updated":"2018-06-26 07:21:38.000000000","message":"Done","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"44761bb078e7870d8843dd9c28245a05962293c4","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        self.timeout_server \u003d timeout_server"},{"line_number":79,"context_line":"        self.timeout_connect \u003d timeout_connect"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def build_config(self, listener, **kwargs):"},{"line_number":82,"context_line":"        \"\"\"Convert a logical configuration to the Keepalived LVS version"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        :param listener: The listener configuration"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_a1ee501e","line":81,"updated":"2018-06-25 22:03:49.000000000","message":"This is not used and should be removed.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"aa39d36401725d2cf9ed6344f96e779123c6e1e3","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        self.timeout_server \u003d timeout_server"},{"line_number":79,"context_line":"        self.timeout_connect \u003d timeout_connect"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def build_config(self, listener, **kwargs):"},{"line_number":82,"context_line":"        \"\"\"Convert a logical configuration to the Keepalived LVS version"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        :param listener: The listener configuration"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_876c7f36","line":81,"in_reply_to":"5f7c97a3_a1ee501e","updated":"2018-06-26 07:21:38.000000000","message":"No, this is used in https://review.openstack.org/#/c/529651/25/octavia/amphorae/drivers/haproxy/rest_api_driver.py@74","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"44761bb078e7870d8843dd9c28245a05962293c4","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                loader\u003dtemplate_loader,"},{"line_number":98,"context_line":"                trim_blocks\u003dTrue,"},{"line_number":99,"context_line":"                lstrip_blocks\u003dTrue)"},{"line_number":100,"context_line":"        JINJA_ENV.filters[\u0027hash_amp_id\u0027] \u003d octavia_utils.base64_sha1_string"},{"line_number":101,"context_line":"        return JINJA_ENV.get_template(os.path.basename("},{"line_number":102,"context_line":"            self.keepalivedlvs_template))"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_1ea76352","line":100,"updated":"2018-06-25 22:03:49.000000000","message":"This is not used and should be removed.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"aa39d36401725d2cf9ed6344f96e779123c6e1e3","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                loader\u003dtemplate_loader,"},{"line_number":98,"context_line":"                trim_blocks\u003dTrue,"},{"line_number":99,"context_line":"                lstrip_blocks\u003dTrue)"},{"line_number":100,"context_line":"        JINJA_ENV.filters[\u0027hash_amp_id\u0027] \u003d octavia_utils.base64_sha1_string"},{"line_number":101,"context_line":"        return JINJA_ENV.get_template(os.path.basename("},{"line_number":102,"context_line":"            self.keepalivedlvs_template))"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_a7673b51","line":100,"in_reply_to":"5f7c97a3_1ea76352","updated":"2018-06-26 07:21:38.000000000","message":"Done","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"44761bb078e7870d8843dd9c28245a05962293c4","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            \u0027protocol_mode\u0027: PROTOCOL_MAP[listener.protocol],"},{"line_number":140,"context_line":"            \u0027enabled\u0027: listener.enabled"},{"line_number":141,"context_line":"        }"},{"line_number":142,"context_line":"        if listener.connection_limit and listener.connection_limit \u003e -1:"},{"line_number":143,"context_line":"            ret_value[\u0027connection_limit\u0027] \u003d listener.connection_limit"},{"line_number":144,"context_line":"        if listener.default_pool:"},{"line_number":145,"context_line":"            ret_value[\u0027default_pool\u0027] \u003d self._transform_pool("}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_81d7944f","line":142,"updated":"2018-06-25 22:03:49.000000000","message":"This branch is not covered by a unit test.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"aa39d36401725d2cf9ed6344f96e779123c6e1e3","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            \u0027protocol_mode\u0027: PROTOCOL_MAP[listener.protocol],"},{"line_number":140,"context_line":"            \u0027enabled\u0027: listener.enabled"},{"line_number":141,"context_line":"        }"},{"line_number":142,"context_line":"        if listener.connection_limit and listener.connection_limit \u003e -1:"},{"line_number":143,"context_line":"            ret_value[\u0027connection_limit\u0027] \u003d listener.connection_limit"},{"line_number":144,"context_line":"        if listener.default_pool:"},{"line_number":145,"context_line":"            ret_value[\u0027default_pool\u0027] \u003d self._transform_pool("}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_27980b19","line":142,"in_reply_to":"5f7c97a3_81d7944f","updated":"2018-06-26 07:21:38.000000000","message":"will add it. Thanks","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"44761bb078e7870d8843dd9c28245a05962293c4","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        }"},{"line_number":164,"context_line":"        members \u003d [self._transform_member(x) for x in pool.members]"},{"line_number":165,"context_line":"        ret_value[\u0027members\u0027] \u003d members"},{"line_number":166,"context_line":"        if pool.health_monitor:"},{"line_number":167,"context_line":"            ret_value[\u0027health_monitor\u0027] \u003d self._transform_health_monitor("},{"line_number":168,"context_line":"                pool.health_monitor)"},{"line_number":169,"context_line":"        if pool.session_persistence:"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_e1d1a858","line":166,"updated":"2018-06-25 22:03:49.000000000","message":"This branch is not covered by a unit test.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"aa39d36401725d2cf9ed6344f96e779123c6e1e3","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        }"},{"line_number":164,"context_line":"        members \u003d [self._transform_member(x) for x in pool.members]"},{"line_number":165,"context_line":"        ret_value[\u0027members\u0027] \u003d members"},{"line_number":166,"context_line":"        if pool.health_monitor:"},{"line_number":167,"context_line":"            ret_value[\u0027health_monitor\u0027] \u003d self._transform_health_monitor("},{"line_number":168,"context_line":"                pool.health_monitor)"},{"line_number":169,"context_line":"        if pool.session_persistence:"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_e79d3309","line":166,"in_reply_to":"5f7c97a3_e1d1a858","updated":"2018-06-26 07:21:38.000000000","message":"will add it. Thanks","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"}],"octavia/common/jinja/lvs/templates/__init__.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8b8c3321ac621f661e3f6f623c017086299308e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f93b717_2e8abc1a","updated":"2018-01-26 06:48:26.000000000","message":"__init__.py should only be used for directories with python code in it.  Jinja templates don\u0027t count.","commit_id":"897de0ed942887006ab0ca0f1fbd72cf037db40e"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"e067e6dd771b7000d777dbb09f62aa02b06c0b22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f93b717_0cbb48e2","in_reply_to":"5f93b717_2e8abc1a","updated":"2018-01-26 08:06:30.000000000","message":"Correct, will remove this file.","commit_id":"897de0ed942887006ab0ca0f1fbd72cf037db40e"}],"octavia/common/jinja/lvs/templates/base.j2":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8b8c3321ac621f661e3f6f623c017086299308e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f93b717_ee0db490","updated":"2018-01-26 06:48:26.000000000","message":"Do we need to use the macros for this or can this be consolidated and simplified into one template file?","commit_id":"897de0ed942887006ab0ca0f1fbd72cf037db40e"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"e067e6dd771b7000d777dbb09f62aa02b06c0b22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f93b717_8c9bd870","in_reply_to":"5f93b717_ee0db490","updated":"2018-01-26 08:06:30.000000000","message":"It is true that we can simply make it into 1 template file. But this style looks clear than that. Also other templates use the macros.","commit_id":"897de0ed942887006ab0ca0f1fbd72cf037db40e"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"bef7f7fecde2b69863054cfb7ca997876a60cc27","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"#}"},{"line_number":16,"context_line":"# Configuration for Listener {{ udp_listener_id }}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{% block global_definitions %}{% endblock global_definitions %}"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":45,"id":"5f7c97a3_aba36643","line":16,"updated":"2018-08-02 09:25:59.000000000","message":"I think it\u0027s better to do loadbalancer ID rather than listener ID here -- the name of the file should be based on the listener ID, so people can already see that? But, lb-id would be useful as it is otherwise hard to find without going to the DB.\nSee the way I just changed it to work that way in the non-udp version of this template: https://review.openstack.org/#/c/572730/5/octavia/common/jinja/haproxy/templates/base.j2\n\n... actually I can\u0027t find where the name of this file is set, DOES IT use the same scheme as the non-udp version and include the listener-id in the filename?","commit_id":"008ccb652dce9a260c5eb90796994dd459a4fcff"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"91041a43c6938ea6f931b76d1f594d5931402320","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"#}"},{"line_number":16,"context_line":"# Configuration for Listener {{ udp_listener_id }}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{% block global_definitions %}{% endblock global_definitions %}"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":45,"id":"5f7c97a3_7e98a5ca","line":16,"in_reply_to":"5f7c97a3_aba36643","updated":"2018-08-02 15:11:49.000000000","message":"I think having the listener here is kind of useful.\nWe can always just add a line for the load balancer ID.\nI will add that in my follow up patch.\nI REALLY don\u0027t want to hold up merge and miss the release with a comment line though....","commit_id":"008ccb652dce9a260c5eb90796994dd459a4fcff"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"ea8f1c94811e356ba1d4ba0297f4a735f3ab925a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"#}"},{"line_number":16,"context_line":"# Configuration for Listener {{ udp_listener_id }}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{% block global_definitions %}{% endblock global_definitions %}"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":45,"id":"5f7c97a3_de46a222","line":16,"in_reply_to":"5f7c97a3_aba36643","updated":"2018-08-02 09:38:49.000000000","message":"The cfg file will be named like\nhttps://review.openstack.org/#/c/529651/58/octavia/amphorae/backends/agent/api_server/util.py@85  in patch 2.\n\nAlso this \"# Configuration for Listener \" will be used for generating the mapping of listener - pool - healthmonitor - members, like https://review.openstack.org/#/c/529651/58/octavia/amphorae/backends/utils/keepalivedlvs_query.py , as we just know the realserver/virtual server ip, not like haproxy does, so I think it maybe the right way to comment the resource id.\n\nIf we want loadbalancer id, we can add, but can not remove listener id..","commit_id":"008ccb652dce9a260c5eb90796994dd459a4fcff"}],"octavia/common/jinja/lvs/templates/keepalivedlvs.cfg.j2":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8b8c3321ac621f661e3f6f623c017086299308e0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{% from \u0027macros.j2\u0027 import virtualserver_macro %}"},{"line_number":18,"context_line":"{% set udp_listener_id \u003d loadbalancer.listener.id %}"},{"line_number":19,"context_line":"{% block global_definitions %}"},{"line_number":20,"context_line":"net_namespace haproxy-amphorae"},{"line_number":21,"context_line":"{% endblock global_definitions %}"},{"line_number":22,"context_line":"{% block proxies %}"},{"line_number":23,"context_line":"    {% if loadbalancer.enabled and loadbalancer.listener.enabled %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5f93b717_2e8f1c24","line":20,"range":{"start_line":20,"start_character":22,"end_line":20,"end_character":30},"updated":"2018-01-26 06:48:26.000000000","message":"amphora","commit_id":"897de0ed942887006ab0ca0f1fbd72cf037db40e"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"e067e6dd771b7000d777dbb09f62aa02b06c0b22","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{% from \u0027macros.j2\u0027 import virtualserver_macro %}"},{"line_number":18,"context_line":"{% set udp_listener_id \u003d loadbalancer.listener.id %}"},{"line_number":19,"context_line":"{% block global_definitions %}"},{"line_number":20,"context_line":"net_namespace haproxy-amphorae"},{"line_number":21,"context_line":"{% endblock global_definitions %}"},{"line_number":22,"context_line":"{% block proxies %}"},{"line_number":23,"context_line":"    {% if loadbalancer.enabled and loadbalancer.listener.enabled %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5f93b717_9119b57a","line":20,"range":{"start_line":20,"start_character":22,"end_line":20,"end_character":30},"in_reply_to":"5f93b717_2e8f1c24","updated":"2018-01-26 08:06:30.000000000","message":"Done","commit_id":"897de0ed942887006ab0ca0f1fbd72cf037db40e"}],"octavia/common/jinja/lvs/templates/macros.j2":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d6f96c41454bf40d43a2cab52771bb5d7afa9864","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#   Copyright (c) 2015 Rackspace"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"5f7c97a3_5e2ae52b","line":1,"updated":"2018-05-11 18:19:51.000000000","message":"You might want to fix this as this is really a new file and could have your copyright","commit_id":"d004d0f87d224e94ff8bfe400e062450311aae19"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"e8c08bc4ee0f1f38a9430d7b4f7b0af663ed5c30","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#   Copyright (c) 2015 Rackspace"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"5f7c97a3_e51b07c7","line":1,"in_reply_to":"5f7c97a3_5e2ae52b","updated":"2018-05-14 12:06:03.000000000","message":"Thanks, I will fix it.","commit_id":"d004d0f87d224e94ff8bfe400e062450311aae19"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"04cb3078ca71780aa2bea3bcabf9a1468d374b5d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"{% endmacro %}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"{% macro virtualserver_macro(constants, listener, lb_vip_address, default_pool) %}"},{"line_number":81,"context_line":"virtual_server {{ lb_vip_address }} {{ listener.protocol_port }} {"},{"line_number":82,"context_line":"    {% if default_pool and default_pool.enabled %}"},{"line_number":83,"context_line":"    {{ lb_algo_macro(default_pool) }}"},{"line_number":84,"context_line":"    {% if default_pool.session_persistence and default_pool.session_persistence.type \u003d\u003d \u0027ONE_PACKET_SCHEDULING\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"5f7c97a3_8f6b3bb7","line":81,"updated":"2018-06-25 23:59:10.000000000","message":"The check for pool and pool enabled needs to be before this. If no \"lb_algo\" line is configured for the virtual server, the syslog fills with \"IPVS: Scheduler module ip_vs_ not found\" errors.\nSame with a pool with no members, the syslog fills with \"IPVS: Service already exists\" errors.\nWe need to not render the virtual server block until there  is one or more members.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"aa39d36401725d2cf9ed6344f96e779123c6e1e3","unresolved":false,"context_lines":[{"line_number":78,"context_line":"{% endmacro %}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"{% macro virtualserver_macro(constants, listener, lb_vip_address, default_pool) %}"},{"line_number":81,"context_line":"virtual_server {{ lb_vip_address }} {{ listener.protocol_port }} {"},{"line_number":82,"context_line":"    {% if default_pool and default_pool.enabled %}"},{"line_number":83,"context_line":"    {{ lb_algo_macro(default_pool) }}"},{"line_number":84,"context_line":"    {% if default_pool.session_persistence and default_pool.session_persistence.type \u003d\u003d \u0027ONE_PACKET_SCHEDULING\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"5f7c97a3_3a734250","line":81,"in_reply_to":"5f7c97a3_4fae83e7","updated":"2018-06-26 07:21:38.000000000","message":"Thanks, but there is a problem here, should we send to amp_agent to upload/reload the keepalive conf file if just bind a \u0027empty\u0027 Listener/pool/healthmonitor? As the exsting haproxy case do that in every operations, such as creating Listener, creating a pool for this Listener, create a healthmonitor for this pool.. This sounds like a different process. Also it will affect the operating_status fresh. That means once the listener pool owns a enabled member, that\u0027s the chance to update the status by udp heartbeat. (I think https://review.openstack.org/#/c/529651/25/octavia/amphorae/backends/utils/keepalivedlvs_query.py@121 need to be refactored also).","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f4f22d8a8d7a393985ee3eb7a3e69d1a7cf06437","unresolved":false,"context_lines":[{"line_number":78,"context_line":"{% endmacro %}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"{% macro virtualserver_macro(constants, listener, lb_vip_address, default_pool) %}"},{"line_number":81,"context_line":"virtual_server {{ lb_vip_address }} {{ listener.protocol_port }} {"},{"line_number":82,"context_line":"    {% if default_pool and default_pool.enabled %}"},{"line_number":83,"context_line":"    {{ lb_algo_macro(default_pool) }}"},{"line_number":84,"context_line":"    {% if default_pool.session_persistence and default_pool.session_persistence.type \u003d\u003d \u0027ONE_PACKET_SCHEDULING\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"5f7c97a3_4fae83e7","line":81,"in_reply_to":"5f7c97a3_8f6b3bb7","updated":"2018-06-25 23:59:57.000000000","message":"oh, and the one or more members must be enabled.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5c2cf7a1fb3dcdda95eb606a4767f9b492326c2a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        {% if pool.health_monitor.fall_threshold %}"},{"line_number":39,"context_line":"        retry {{ pool.health_monitor.fall_threshold }}"},{"line_number":40,"context_line":"        {% endif %}"},{"line_number":41,"context_line":"        {% if pool.health_monitor.type \u003d\u003d \u0027UDP_CONNECT\u0027 %}"},{"line_number":42,"context_line":"        {{ misc_check_macro(pool, member, pool.health_monitor) -}}"},{"line_number":43,"context_line":"        {% endif %}"},{"line_number":44,"context_line":"        {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":39,"id":"5f7c97a3_bebfc2a9","line":41,"range":{"start_line":41,"start_character":43,"end_line":41,"end_character":54},"updated":"2018-07-25 23:51:57.000000000","message":"UDP_CONNECT -\u003e UDP-CONNECT","commit_id":"789e623ce1d852a78d744bfd2b0776fa335bbe8b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"870118c3aa121ceaae46f6ec9e2989867709144e","unresolved":false,"context_lines":[{"line_number":85,"context_line":"virtual_server {{ lb_vip_address }} {{ listener.protocol_port }} {"},{"line_number":86,"context_line":"    {{ lb_algo_macro(default_pool) }}"},{"line_number":87,"context_line":"    {% if default_pool.session_persistence and default_pool.session_persistence.type \u003d\u003d constants.SESSION_PERSISTENCE_ONE_PACKET_SCHEDULING %}"},{"line_number":88,"context_line":"    ops"},{"line_number":89,"context_line":"    {% endif %}"},{"line_number":90,"context_line":"    lb_kind NAT"},{"line_number":91,"context_line":"    protocol {{ listener.protocol_mode }}"}],"source_content_type":"text/x-jinja2","patch_set":42,"id":"5f7c97a3_fd3384c2","line":88,"range":{"start_line":88,"start_character":3,"end_line":88,"end_character":7},"updated":"2018-08-01 05:14:11.000000000","message":"This should be the default setting as this is how a pool with no session persistence works.\nIt should be removed/disabled if the user specifies \"SOURCE_IP\" which is the default for LVS.","commit_id":"26d5975abe6dd2bd4b8d75777450facd3fb64b47"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"17cb8bea7cc61f422ef76cd7d8a055be0cd7eb36","unresolved":false,"context_lines":[{"line_number":85,"context_line":"virtual_server {{ lb_vip_address }} {{ listener.protocol_port }} {"},{"line_number":86,"context_line":"    {{ lb_algo_macro(default_pool) }}"},{"line_number":87,"context_line":"    {% if default_pool.session_persistence and default_pool.session_persistence.type \u003d\u003d constants.SESSION_PERSISTENCE_ONE_PACKET_SCHEDULING %}"},{"line_number":88,"context_line":"    ops"},{"line_number":89,"context_line":"    {% endif %}"},{"line_number":90,"context_line":"    lb_kind NAT"},{"line_number":91,"context_line":"    protocol {{ listener.protocol_mode }}"}],"source_content_type":"text/x-jinja2","patch_set":42,"id":"5f7c97a3_1879aef9","line":88,"range":{"start_line":88,"start_character":3,"end_line":88,"end_character":7},"in_reply_to":"5f7c97a3_fd3384c2","updated":"2018-08-01 11:03:28.000000000","message":"Hmmm, I\u0027m struggle to remove the \"SESSION_PERSISTENCE_ONE_PACKET_SCHEDULING\" of session_persistence.type. I think we do it as default, that means the \"SESSION_PERSISTENCE_ONE_PACKET_SCHEDULING\" type lose its meaning.","commit_id":"26d5975abe6dd2bd4b8d75777450facd3fb64b47"}],"octavia/tests/unit/common/sample_configs/sample_configs.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"44761bb078e7870d8843dd9c28245a05962293c4","unresolved":false,"context_lines":[{"line_number":393,"context_line":""},{"line_number":394,"context_line":"RET_UDP_MEMBER \u003d {"},{"line_number":395,"context_line":"    \u0027id\u0027: \u0027member_id_1\u0027,"},{"line_number":396,"context_line":"    \u0027address\u0027: \u002710.0.0.72\u0027,"},{"line_number":397,"context_line":"    \u0027protocol_port\u0027: 82,"},{"line_number":398,"context_line":"    \u0027weight\u0027: 13,"},{"line_number":399,"context_line":"    \u0027enabled\u0027: True"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_41641cb3","line":396,"range":{"start_line":396,"start_character":16,"end_line":396,"end_character":25},"updated":"2018-06-25 22:03:49.000000000","message":"Please use TEST-NET reserved IP addresses:\n192.0.2.0/24, 198.51.100.0/24, or 203.0.113.0/24","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"aa39d36401725d2cf9ed6344f96e779123c6e1e3","unresolved":false,"context_lines":[{"line_number":393,"context_line":""},{"line_number":394,"context_line":"RET_UDP_MEMBER \u003d {"},{"line_number":395,"context_line":"    \u0027id\u0027: \u0027member_id_1\u0027,"},{"line_number":396,"context_line":"    \u0027address\u0027: \u002710.0.0.72\u0027,"},{"line_number":397,"context_line":"    \u0027protocol_port\u0027: 82,"},{"line_number":398,"context_line":"    \u0027weight\u0027: 13,"},{"line_number":399,"context_line":"    \u0027enabled\u0027: True"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_3a5022d5","line":396,"range":{"start_line":396,"start_character":16,"end_line":396,"end_character":25},"in_reply_to":"5f7c97a3_41641cb3","updated":"2018-06-26 07:21:38.000000000","message":"ok,I will get the sample IP from one of these prefixes.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"44761bb078e7870d8843dd9c28245a05962293c4","unresolved":false,"context_lines":[{"line_number":401,"context_line":""},{"line_number":402,"context_line":"UDP_MEMBER_1 \u003d {"},{"line_number":403,"context_line":"    \u0027id\u0027: \u0027sample_member_id_1\u0027,"},{"line_number":404,"context_line":"    \u0027address\u0027: \u002710.0.0.99\u0027,"},{"line_number":405,"context_line":"    \u0027enabled\u0027: True,"},{"line_number":406,"context_line":"    \u0027protocol_port\u0027: 82,"},{"line_number":407,"context_line":"    \u0027weight\u0027: 13"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_e10448c8","line":404,"range":{"start_line":404,"start_character":16,"end_line":404,"end_character":25},"updated":"2018-06-25 22:03:49.000000000","message":"Please use TEST-NET reserved IP addresses:\n192.0.2.0/24, 198.51.100.0/24, or 203.0.113.0/24","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"4bd342473d236cc97b16f130ee5c39b0ca0428fb","unresolved":false,"context_lines":[{"line_number":401,"context_line":""},{"line_number":402,"context_line":"UDP_MEMBER_1 \u003d {"},{"line_number":403,"context_line":"    \u0027id\u0027: \u0027sample_member_id_1\u0027,"},{"line_number":404,"context_line":"    \u0027address\u0027: \u002710.0.0.99\u0027,"},{"line_number":405,"context_line":"    \u0027enabled\u0027: True,"},{"line_number":406,"context_line":"    \u0027protocol_port\u0027: 82,"},{"line_number":407,"context_line":"    \u0027weight\u0027: 13"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_ba9ae9c1","line":404,"range":{"start_line":404,"start_character":16,"end_line":404,"end_character":25},"in_reply_to":"5f7c97a3_5a4b9e26","updated":"2018-06-26 13:53:13.000000000","message":"I recheck, UDP_MEMBER_1 and UDP_MEMBER_2 would be generated by sample Pool and listener, which hard code in L664","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"aa39d36401725d2cf9ed6344f96e779123c6e1e3","unresolved":false,"context_lines":[{"line_number":401,"context_line":""},{"line_number":402,"context_line":"UDP_MEMBER_1 \u003d {"},{"line_number":403,"context_line":"    \u0027id\u0027: \u0027sample_member_id_1\u0027,"},{"line_number":404,"context_line":"    \u0027address\u0027: \u002710.0.0.99\u0027,"},{"line_number":405,"context_line":"    \u0027enabled\u0027: True,"},{"line_number":406,"context_line":"    \u0027protocol_port\u0027: 82,"},{"line_number":407,"context_line":"    \u0027weight\u0027: 13"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_5a4b9e26","line":404,"range":{"start_line":404,"start_character":16,"end_line":404,"end_character":25},"in_reply_to":"5f7c97a3_e10448c8","updated":"2018-06-26 07:21:38.000000000","message":"ok,I will get the sample IP from one of these prefixes.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"44761bb078e7870d8843dd9c28245a05962293c4","unresolved":false,"context_lines":[{"line_number":409,"context_line":""},{"line_number":410,"context_line":"UDP_MEMBER_2 \u003d {"},{"line_number":411,"context_line":"    \u0027id\u0027: \u0027sample_member_id_2\u0027,"},{"line_number":412,"context_line":"    \u0027address\u0027: \u002710.0.0.98\u0027,"},{"line_number":413,"context_line":"    \u0027enabled\u0027: True,"},{"line_number":414,"context_line":"    \u0027protocol_port\u0027: 82,"},{"line_number":415,"context_line":"    \u0027weight\u0027: 13"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_010864d6","line":412,"range":{"start_line":412,"start_character":16,"end_line":412,"end_character":25},"updated":"2018-06-25 22:03:49.000000000","message":"Please use TEST-NET reserved IP addresses:\n192.0.2.0/24, 198.51.100.0/24, or 203.0.113.0/24","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"aa39d36401725d2cf9ed6344f96e779123c6e1e3","unresolved":false,"context_lines":[{"line_number":409,"context_line":""},{"line_number":410,"context_line":"UDP_MEMBER_2 \u003d {"},{"line_number":411,"context_line":"    \u0027id\u0027: \u0027sample_member_id_2\u0027,"},{"line_number":412,"context_line":"    \u0027address\u0027: \u002710.0.0.98\u0027,"},{"line_number":413,"context_line":"    \u0027enabled\u0027: True,"},{"line_number":414,"context_line":"    \u0027protocol_port\u0027: 82,"},{"line_number":415,"context_line":"    \u0027weight\u0027: 13"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_fa5f0ae2","line":412,"range":{"start_line":412,"start_character":16,"end_line":412,"end_character":25},"in_reply_to":"5f7c97a3_010864d6","updated":"2018-06-26 07:21:38.000000000","message":"ok,I will get the sample IP from one of these prefixes.","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"4bd342473d236cc97b16f130ee5c39b0ca0428fb","unresolved":false,"context_lines":[{"line_number":409,"context_line":""},{"line_number":410,"context_line":"UDP_MEMBER_2 \u003d {"},{"line_number":411,"context_line":"    \u0027id\u0027: \u0027sample_member_id_2\u0027,"},{"line_number":412,"context_line":"    \u0027address\u0027: \u002710.0.0.98\u0027,"},{"line_number":413,"context_line":"    \u0027enabled\u0027: True,"},{"line_number":414,"context_line":"    \u0027protocol_port\u0027: 82,"},{"line_number":415,"context_line":"    \u0027weight\u0027: 13"}],"source_content_type":"text/x-python","patch_set":21,"id":"5f7c97a3_da9d65bb","line":412,"range":{"start_line":412,"start_character":16,"end_line":412,"end_character":25},"in_reply_to":"5f7c97a3_fa5f0ae2","updated":"2018-06-26 13:53:13.000000000","message":"ditto","commit_id":"7b300f3f9329a7edd327ca8a2f7af102ba9e8093"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5c2cf7a1fb3dcdda95eb606a4767f9b492326c2a","unresolved":false,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"RET_UDP_HEALTH_MONITOR \u003d {"},{"line_number":360,"context_line":"    \u0027id\u0027: \u0027sample_monitor_id_1\u0027,"},{"line_number":361,"context_line":"    \u0027type\u0027: \u0027UDP_CONNECT\u0027,"},{"line_number":362,"context_line":"    \u0027delay\u0027: 30,"},{"line_number":363,"context_line":"    \u0027timeout\u0027: 31,"},{"line_number":364,"context_line":"    \u0027enabled\u0027: True,"}],"source_content_type":"text/x-python","patch_set":39,"id":"5f7c97a3_fe9c5a5d","line":361,"range":{"start_line":361,"start_character":13,"end_line":361,"end_character":24},"updated":"2018-07-25 23:51:57.000000000","message":"UDP_CONNECT -\u003e UDP-CONNECT","commit_id":"789e623ce1d852a78d744bfd2b0776fa335bbe8b"}]}
