)]}'
{"diskimage-create/diskimage-create.sh":[{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"95e24d17ee60c10a3cb7a1d91250f4ede7a38b26","unresolved":false,"context_lines":[{"line_number":331,"context_line":"AMP_element_sequence\u003d\"$AMP_element_sequence no-resolvconf\""},{"line_number":332,"context_line":"AMP_element_sequence\u003d\"$AMP_element_sequence amphora-agent\""},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"if [ \"$AMP_ENFORCE_SELINUX\" -ne 1 ]; then"},{"line_number":335,"context_line":"    AMP_element_sequence\u003d\"$AMP_element_sequence selinux-permissive\""},{"line_number":336,"context_line":"fi"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"# Add keepalived-octavia element"},{"line_number":339,"context_line":"AMP_element_sequence\u003d\"$AMP_element_sequence keepalived-octavia\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"df87a7cf_4d8d982f","line":336,"range":{"start_line":334,"start_character":0,"end_line":336,"end_character":2},"updated":"2017-12-17 22:25:45.000000000","message":"I think we should make an exception (and perhaps print a warning) in case the selected OS for amphora is Ubuntu.\n\nIIRC, SELinux is not active in the Ubuntu cloud image.\nAdded Michael to keep me honest here.","commit_id":"9d375873fd70d55d98d7caf0390196346bac3533"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"600250496dfb6882210a18a9955d793a2dfd1533","unresolved":false,"context_lines":[{"line_number":331,"context_line":"AMP_element_sequence\u003d\"$AMP_element_sequence no-resolvconf\""},{"line_number":332,"context_line":"AMP_element_sequence\u003d\"$AMP_element_sequence amphora-agent\""},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"if [ \"$AMP_ENFORCE_SELINUX\" -ne 1 ]; then"},{"line_number":335,"context_line":"    AMP_element_sequence\u003d\"$AMP_element_sequence selinux-permissive\""},{"line_number":336,"context_line":"fi"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"# Add keepalived-octavia element"},{"line_number":339,"context_line":"AMP_element_sequence\u003d\"$AMP_element_sequence keepalived-octavia\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"df87a7cf_b3b4ab83","line":336,"range":{"start_line":334,"start_character":0,"end_line":336,"end_character":2},"in_reply_to":"df87a7cf_4d8d982f","updated":"2017-12-18 15:37:47.000000000","message":"For Ubuntu the element is basically a no-op (it just writes 2 lines in unused configuration files as it does not run SELinux):\nhttps://github.com/openstack/diskimage-builder/tree/master/diskimage_builder/elements/selinux-permissive\n(tempest checks run with that)","commit_id":"9d375873fd70d55d98d7caf0390196346bac3533"}]}