)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"0405d0fe7a1e0dd63b4f8404b7f8bbf8cc3cf4c5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bernard Cafarelli \u003cbcafarel@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-12-11 13:12:02 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Force SELinux context for amphora keepalived proces"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Similar to Ic8bf097499b00ca32dcb501aadfda59755039194 this fixes"},{"line_number":10,"context_line":"keepalived running in ifconfig_t domain"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df87a7cf_a3396bd7","line":7,"updated":"2017-12-11 14:37:20.000000000","message":"proces-\u003eprocess","commit_id":"86f227475e802974e4d9d7dee9704ef13948ce25"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"21beaf94f2a9661e7418d0398de4695618886459","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bernard Cafarelli \u003cbcafarel@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-12-11 13:12:02 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Force SELinux context for amphora keepalived proces"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Similar to Ic8bf097499b00ca32dcb501aadfda59755039194 this fixes"},{"line_number":10,"context_line":"keepalived running in ifconfig_t domain"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df87a7cf_23c47bf4","line":7,"in_reply_to":"df87a7cf_a3396bd7","updated":"2017-12-11 15:05:13.000000000","message":"Done","commit_id":"86f227475e802974e4d9d7dee9704ef13948ce25"},{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"0405d0fe7a1e0dd63b4f8404b7f8bbf8cc3cf4c5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Force SELinux context for amphora keepalived proces"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Similar to Ic8bf097499b00ca32dcb501aadfda59755039194 this fixes"},{"line_number":10,"context_line":"keepalived running in ifconfig_t domain"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5da54f8867093ca69798d812c532fac004aab8f0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df87a7cf_43497f5d","line":9,"updated":"2017-12-11 14:37:20.000000000","message":"a comma before this?","commit_id":"86f227475e802974e4d9d7dee9704ef13948ce25"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"21beaf94f2a9661e7418d0398de4695618886459","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Force SELinux context for amphora keepalived proces"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Similar to Ic8bf097499b00ca32dcb501aadfda59755039194 this fixes"},{"line_number":10,"context_line":"keepalived running in ifconfig_t domain"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5da54f8867093ca69798d812c532fac004aab8f0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df87a7cf_c3b6ef8a","line":9,"in_reply_to":"df87a7cf_43497f5d","updated":"2017-12-11 15:05:13.000000000","message":"Done","commit_id":"86f227475e802974e4d9d7dee9704ef13948ce25"}],"octavia/amphorae/backends/agent/api_server/templates/keepalived.systemd.j2":[{"author":{"_account_id":2245,"name":"Jacky Hu","email":"hudayou@hotmail.com","username":"hudayou"},"change_message_id":"577b629d740dc211e3738ecb0e49b7a0f3cc9768","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[Service]"},{"line_number":7,"context_line":"# Force context as we start keepalived under \"ip netns exec\""},{"line_number":8,"context_line":"SELinuxContext\u003dsystem_u:system_r:keepalived_t:s0"},{"line_number":9,"context_line":"Type\u003dforking"},{"line_number":10,"context_line":"KillMode\u003dprocess"},{"line_number":11,"context_line":"ExecStart\u003d/sbin/ip netns exec {{ amphora_nsname }} {{ keepalived_cmd }} -D -d -f {{ keepalived_cfg }} -p {{ keepalived_pid }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"df87a7cf_ccbe21d4","line":8,"updated":"2017-12-11 13:21:17.000000000","message":"Why not prefix this with -?","commit_id":"86f227475e802974e4d9d7dee9704ef13948ce25"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"e409c2b51a4db06a728370db2f97d38892926ecd","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[Service]"},{"line_number":7,"context_line":"# Force context as we start keepalived under \"ip netns exec\""},{"line_number":8,"context_line":"SELinuxContext\u003dsystem_u:system_r:keepalived_t:s0"},{"line_number":9,"context_line":"Type\u003dforking"},{"line_number":10,"context_line":"KillMode\u003dprocess"},{"line_number":11,"context_line":"ExecStart\u003d/sbin/ip netns exec {{ amphora_nsname }} {{ keepalived_cmd }} -D -d -f {{ keepalived_cfg }} -p {{ keepalived_pid }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"df87a7cf_c0a90590","line":8,"in_reply_to":"df87a7cf_ccbe21d4","updated":"2017-12-11 14:13:42.000000000","message":"For non-SELinux systems this is already silently ignored:\nhttps://www.freedesktop.org/software/systemd/man/systemd.exec.html\nFor SELinux ones, this should not fail, and if it fails errors should not be ignored","commit_id":"86f227475e802974e4d9d7dee9704ef13948ce25"}]}